[kwrited] [Bug 386067] New: Use seperate notifications for each message

This suits the new notification system in 5.11 Kind regards, Sefa Eyeoglu -- You are receiving this mail because: You are the assignee for the bug.

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sefaeyeoglu requested review of this revision. REVISION SUMMARY Adds a checkbox and changes the filter of the ListView models. REPOSITORY R115 Plasma

[kwrited] [Bug 386067] Use seperate notifications for each message

https://bugs.kde.org/show_bug.cgi?id=386067 --- Comment #2 from Sefa Eyeoglu --- If I run "wall Test" multiple times the messages are combined in one single notification, without any seperator. -- You are receiving this mail because: You are the assignee for the bug.

[kwrited] [Bug 386067] Use seperate notifications for each message

https://bugs.kde.org/show_bug.cgi?id=386067 --- Comment #4 from Sefa Eyeoglu --- Nice! If really need to look into KF5. If I would have known, that it is just one flag I would have created a patch months ago. Thank you anyway David. -- You are receiving this mail because: You are the assignee

D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#538988 , @ngraham wrote: > Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port

D24289: Fix wrong KCM device icon for specific form factors

sefaeyeoglu created this revision. sefaeyeoglu added reviewers: VDG, Plasma, ngraham, GB_2. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sefaeyeoglu requested review of this revision. REVISION SUMMARY The KCM did not know how different form factors should be

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66945. sefaeyeoglu added a comment. Align mute button centered with slider REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66943=66945 BRANCH feat-applet-ux REVISION DETAIL

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu updated this revision to Diff 66951. sefaeyeoglu added a comment. Put checkbox into own category REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=66926=66951 BRANCH arcpatch-D13243 REVISION DETAIL

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66943. sefaeyeoglu added a comment. Fix wrong display name of default-device button REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66920=66943 BRANCH feat-applet-ux REVISION DETAIL

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu updated this revision to Diff 66952. sefaeyeoglu added a comment. Change behaviour of configuration. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=66951=66952 BRANCH arcpatch-D13243 REVISION DETAIL

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66908. sefaeyeoglu added a comment. Use QQC2 ToolButton instead of Button for Mute. Add stepping to volume slider, similar to applet. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu updated this revision to Diff 66926. sefaeyeoglu added a comment. Add copyright header REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=66925=66926 BRANCH arcpatch-D13243 REVISION DETAIL

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66909. sefaeyeoglu edited the test plan for this revision. sefaeyeoglu added a comment. Remove redundant whitespace from copyright header REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu updated this revision to Diff 66925. sefaeyeoglu added a comment. Rebase onto master REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=35273=66925 BRANCH arcpatch-D13243 REVISION DETAIL

D24161: Make KCM look more like applet

sefaeyeoglu marked 2 inline comments as done. sefaeyeoglu added inline comments. INLINE COMMENTS > ngraham wrote in VolumeSlider.qml:44 > Hmm, I don't like how this makes tickmarks appear. If you need to round the > value, you can do that in `onMoved: { blabla; }`, or just round the value of >

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66917. sefaeyeoglu added a comment. Remove stepping again, change label text of port selection REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66909=66917 BRANCH feat-applet-ux

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66920. sefaeyeoglu edited the test plan for this revision. sefaeyeoglu added a comment. Make icon full height for playback devices, too REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu added a comment. In D13243#538434 , @ngraham wrote: > Yikes, looks like this never went anywhere. :/ > > Can you rebase it? I actually don't remember ever making this but of course I can :D REPOSITORY R115 Plasma Audio

D24161: Make KCM look more like applet

sefaeyeoglu marked 2 inline comments as done. sefaeyeoglu added a comment. Right! I completely forgot about that. Will work on it REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24161 To: sefaeyeoglu, #plasma, #vdg Cc: ngraham, davidedmundson,

D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#538429 , @ngraham wrote: > I love it, and the code changes look sane to me. > > #plasma folks or @drosca, any objections? Glad you like it  Looks like

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu added a comment. In D13243#538519 , @davidedmundson wrote: > What's the use case? I have a "module-null-sink" loaded at all times. I use it to record from via OBS, so I can selectively record Desktop Audio. (This is coupled

D24161: Make KCM look more like applet

sefaeyeoglu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sefaeyeoglu requested review of this revision. REVISION SUMMARY I was looking through changes in plasma-pa and noticed, that the KCM looks very different in contrast to the applet. TEST

D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#536408 , @GB_2 wrote: > Please add reviewers and subscribers next time. Sorry. I didn't know who I should add so I just added #VDG as subscriber. REPOSITORY

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 9. sefaeyeoglu added a comment. Set domain for all i18n strings REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=7=9 BRANCH feat-applet-ux REVISION DETAIL

D24161: Make KCM look more like applet

sefaeyeoglu added inline comments. INLINE COMMENTS > MuteButton.qml:32 > +ToolTip.visible: hovered > +ToolTip.text: i18ndc("kcm_pulseaudio", "Mute audio stream", "Mute %1", > inputText.text) // a little hacky > checkable: true I actually think this is the wrong way of doing

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66783. sefaeyeoglu added a comment. Import QtQuick.Controls as QQC2 and fix ToolTip delay REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=9=66783 BRANCH feat-applet-ux REVISION

D24161: Make KCM look more like applet

sefaeyeoglu added inline comments. INLINE COMMENTS > ngraham wrote in Applications.qml:49 > I don't think the addition of the word "Streams" adds useful information here. The applet already says Streams here. > ngraham wrote in MuteButton.qml:32 > Using the attached `ToolTip` property is just

D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#538988 , @ngraham wrote: > Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port

D13243: [applet] Add checkbox to show virtual streams

sefaeyeoglu added a comment. In D13243#572829 , @ngraham wrote: > @sefaeyeoglu what do you think about the above? ^^ I could find the time to work on this yet. Generally I like that idea. We could then also make the volume step global

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu added a comment. F7566730: 1570716308.png Looks like replacing the label with a combobox breaks alignment in the KCM and exceeds the full width in the applet. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu added a comment. In D24407#544707 , @ngraham wrote: > That should be fixed by D24402 , in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu added a comment. Nice work! It looks very good now. One odd thing I just noticed: F7566825: plasma-pa-duplicate-defualt.mp4 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To:

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu added a comment. In D24407#544715 , @ngraham wrote: > In D24407#544714 , @sefaeyeoglu wrote: > > > In D24407#544707 , @ngraham wrote: > >

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu accepted this revision. sefaeyeoglu added a comment. This revision is now accepted and ready to land. In D24407#544728 , @ngraham wrote: > I had a feeling. I say let's land this, then fix that. Do you agree? No objections 

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu added a comment. Ping! REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D13243 REVISION DETAIL https://phabricator.kde.org/D13243 To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,