Re: [compiz] [RFC] Draft for a compositing manager specification

2010-08-15 Thread Thomas Lübking
Am Sunday 15 August 2010 schrieb Martin Gräßlin: On Sunday 15 August 2010 16:19:04 Sam Spilsbury wrote: The compositor should set the _NET_CM_SHADOW_SUPPORTED hint and clients should set the following information in the _NET_CM_SHADOW property on the window. 0 | shadow color (32 bit

Re: Review Request: new kwin effect: roundedcorners - make corners of the desktop rounded

2010-09-21 Thread Thomas Lübking
://svn.reviewboard.kde.org/r/5225/ --- (Updated 2010-09-21 18:34:04) Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking. Summary --- Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect makes corners

Re: The KWin Coding Style Situation

2010-11-28 Thread Thomas Lübking
Hummm... but /I/ _really_ *like* the style as it is now!!! ... /sarcasm As for the transition, i guess it mostly depends on automated fixing reliability (i ran that once in kdevelop years ago and _never_ tried it again, but i guess the tools have meanwhile improved ;-) Otherwise (ie if

Re: [RFC] Enforcing Compositing

2011-02-20 Thread Thomas Lübking
Am 20.02.2011, 13:38 Uhr, schrieb Martin Gräßlin mgraess...@kde.org: With Mesa 7.10 it seems that the driver problems (Mesa 7.8) which hit us in 4.5 are finally gone and our new compositor is performing much, much better than the one we have in 4.6. This means from a performance

Re: [RFC] Enforcing Compositing

2011-02-20 Thread Thomas Lübking
Am 20.02.2011, 15:45 Uhr, schrieb Martin Gräßlin mgraess...@kde.org: If we know that R100 does not support it, we could use the GLPlatform to w/o kms glxgears ran @200fps - that's not much, but might be enough. the problem seems that the driver only provides GL 1.2 for the GPU - whether for

Re: [RFC] Enforcing Compositing

2011-02-20 Thread Thomas Lübking
Am 20.02.2011, 22:06 Uhr, schrieb Martin Gräßlin mgraess...@kde.org: On Sunday 20 February 2011 22:00:58 Davide Bettio wrote: I can't understand the point about removing enable/disable options. if we don't want to give the user the possibility to disable, we don't need an option to

Re: Review Request: Remove Drawbound Move/Resize Functionality

2011-05-25 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101411/#review3519 --- No, not implemented in Bespin - couldn't come up with a fancy

Re: Focus stealing prevention and SNI conflicts

2011-07-23 Thread Thomas Lübking
Am Sat, 23 Jul 2011 09:16:06 +0200 schrieb Martin Gräßlin mgraess...@kde.org: I think the problem would go away if all windows opened from a SNI context menu are transient to Plasma. So how do we either a) communicate to the applications that they should set the Plasma's WID as its parent or

Re: Focus stealing prevention and SNI conflicts

2011-07-23 Thread Thomas Lübking
Disclaimer: i know that this is a stupid mail because Aaron probably does not receive it anyway. Am Sat, 23 Jul 2011 21:58:05 +0200 schrieb Aaron J. Seigo ase...@kde.org: p.s. please keep both mailing lists in the CC; i would have missed Thomas' email if Martin hadn't re-replied to both

Re: Focus stealing prevention and SNI conflicts

2011-07-23 Thread Thomas Lübking
Am Sat, 23 Jul 2011 21:58:05 +0200 schrieb Aaron J. Seigo ase...@kde.org: i'm not sure if this is a settings issue on my side or if focus stealing prevention is expecting window handling patterns that are not currently being adhered to by applications. if the latter, we must document

Re: RFC: Remove Opacity from Alt+F3 menu

2011-08-18 Thread Thomas Lübking
Am Thu, 18 Aug 2011 19:20:08 +0200 schrieb Martin Gräßlin mgraess...@kde.org: Hi all, just an idea I had today: do we really need the opacity menu in the Alt+F3 menu? I think it's just a leftover from the time when kwin used to control kcompmgr. I'd say the entire menu just is a mess. Most

Re: RFC: Remove Opacity from Alt+F3 menu

2011-08-19 Thread Thomas Lübking
Am Fri, 19 Aug 2011 10:19:24 +0200 schrieb Christoph Feck christ...@maxiom.de: If you remove the menu entries, at least make sure you have global shortcuts for changing transparency quickly (+/- by 20%, set to opaque), so that I can assign gestures to those operations. Leaving the generally

Re: Review Request: Implement Decoration Policy

2011-08-26 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102434/#review6024 --- And if you remove _KDE_NET_WM_WINDOW_TYPE_OVERRIDE then what?

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-29 Thread Thomas Lübking
Am Thu, 29 Sep 2011 22:14:59 +0200 schrieb Martin Gräßlin mgraess...@kde.org: But when compositing is turned off, you currently get the plain old implementation including screen savers. And I don't want to change that code. Seconding Marco: Why? So there are some solutions: * drop

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Thomas Lübking
/r/103202/#comment7139 ibeg your pardon? to me this looks like you delete the same entry forever (what *will* crash at a point) since you don't remove it - should be takeFirst, yesno? - Thomas Lübking On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Thomas Lübking
On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote: plasma/private/containment_p.h, line 71 http://git.reviewboard.kde.org/r/103202/diff/1/?file=41732#file41732line71 ibeg your pardon? to me this looks like you delete the same entry forever (what *will* crash at a point

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Thomas Lübking
On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote: plasma/private/containment_p.h, line 71 http://git.reviewboard.kde.org/r/103202/diff/1/?file=41732#file41732line71 ibeg your pardon? to me this looks like you delete the same entry forever (what *will* crash at a point

Re: Review Request: [Patch 1/2] Fix Sliding Popups

2011-12-09 Thread Thomas Lübking
- use QApplication::desktop()-width() instead, should usually come for free. - Thomas Lübking On Dec. 9, 2011, 5:18 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: [Patch 2/2] Fix Sliding Popups

2011-12-09 Thread Thomas Lübking
to blurring, and yes: i've even completely disabled the generic effects before ;-) - Thomas Lübking On Dec. 9, 2011, 5:35 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: [Patch 2/2] Fix Sliding Popups

2011-12-10 Thread Thomas Lübking
requires the other patch applied (the extender thingies aren't catched at all here) - Thomas Lübking On Dec. 10, 2011, 11:39 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Re: [RFC] Remove Xinerama related options

2012-01-20 Thread Thomas Lübking
Am 20.01.2012, 13:31 Uhr, schrieb Martin Gräßlin mgraess...@kde.org: On Friday 20 January 2012 13:11:03 Alex Fiestas wrote: On Friday, January 20, 2012 11:32:13 AM Martin Gräßlin wrote: From the userinterface the only useful option is Show unmanaged windows on which should be kept.

Re: Re: Re: [RFC] Remove Xinerama related options

2012-01-20 Thread Thomas Lübking
Am 20.01.2012, 17:11 Uhr, schrieb Martin Gräßlin mgraess...@kde.org: So basically i guess this option is dead (unless it's read somewhere else and exported to the root window - but i don't know. My root window looks unspectacular in this regard) lxr will help for that :-) a) cool - wasn't

Re: Re: Re: [RFC] Remove Xinerama related options

2012-01-20 Thread Thomas Lübking
Am 20.01.2012, 19:08 Uhr, schrieb Shaun Reich shaun.re...@kdemail.net: lxr has both C++ understanding (which is that default textbox you see, Thanks a lot. It's the KGlobalSettings::splashScreenDesktopGeometry() in kdeglobals.cpp what sounds like legacy code(*) since nowadays splashscreens

Re: Review Request: Drop Xinerama related options in KWin

2012-01-22 Thread Thomas Lübking
On Jan. 22, 2012, 6:09 p.m., Alex Fiestas wrote: Tested and everything works as expected :) ! just ftr: afaics there's no way for a desktop wall (ie. treating all screens as one) left, is it? personally i don't mind, but there might have been claims on this at kcd. - Thomas

Re: Review Request: Rename window deocration Laptop to Minimal

2012-03-15 Thread Thomas Lübking
minimal functionality or stuff. About the comment: why not paint it directly into the preview? If you write a tldr; novel into a tooltip, that's not gonna help either. - Thomas Lübking On March 15, 2012, 7:28 a.m., Martin Gräßlin wrote

Re: Review Request: Rename window deocration Laptop to Minimal

2012-03-15 Thread Thomas Lübking
On March 15, 2012, 12:16 p.m., Thomas Lübking wrote: Leightweight? - Minimal is generic and could just as well read minimal functionality or stuff. About the comment: why not paint it directly into the preview? If you write a tldr; novel into a tooltip, that's not gonna help either

Re: Review Request: [RFC]: Rename Configure Window Behavior to Configure Window Management

2012-03-15 Thread Thomas Lübking
string is bad, but i don't know whether joe windows user can make anything out of window management (the concept of a window manager and titlebars not being part of the actual window is usually confusing when you're first confronted with it - i do recall that from my very own past) - Thomas Lübking

Re: Review Request: Rename window deocration Laptop to Minimal

2012-03-15 Thread Thomas Lübking
On March 15, 2012, 12:16 p.m., Thomas Lübking wrote: Leightweight? - Minimal is generic and could just as well read minimal functionality or stuff. About the comment: why not paint it directly into the preview? If you write a tldr; novel into a tooltip, that's not gonna help either

Re: Review Request: Drop Decorations B2 and Plastik

2012-03-15 Thread Thomas Lübking
, but to mimic other OS is rather a task for kdeartwork.or kde-look.org - Thomas Lübking On March 15, 2012, 7:14 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104281

Re: Re: Help us finding the new name for Laptop window decoration

2012-03-16 Thread Thomas Lübking
Am 16.03.2012, 13:54 Uhr, schrieb Martin Gräßlin mgraess...@kde.org: btw, is it just me or does it have drawing errors when there are spaces between buttons? no, it's not just you. I just enabled it and it shows the same bug as we know from Plastik already. Ah bitrot is such a wonderful

Re: Re: Help us finding the new name for Laptop window decoration

2012-03-16 Thread Thomas Lübking
Am 16.03.2012, 16:42 Uhr, schrieb Thomas Lübking thomas.luebk...@gmail.com: Seems it simply assumes a prefilled background, I'll have a look and fix that in no minutes in case Nuno has no supergreat idea for another deco ;-) Mehhh ... it inherits KCommonDecoration - in case we still

Re: Help us finding the new name for Laptop window decoration

2012-03-16 Thread Thomas Lübking
Am 16.03.2012, 16:51 Uhr, schrieb Christoph Feck christ...@maxiom.de: The whole point of a net-friendly window decoration is to not transfer bitmaps, but simple fillRect/drawRect calls. As such, if it uses gradients at all, it should not cache them. If QPixmap is not entirely stupid, the

Re: Help us finding the new name for Laptop window decoration

2012-03-16 Thread Thomas Lübking
Am 16.03.2012, 16:51 Uhr, schrieb Christoph Feck christ...@maxiom.de: qpaintengine_x11.cpp has (even) linear gradients deactivated :-( http://qt.gitorious.org/qt/qt/blobs/4.8/src/gui/painting/qpaintengine_x11.cpp#line441 I know that this used to be an fglrx issue, maybe we should check for an

Re: Redesign kwin's kcm All effects

2012-03-18 Thread Thomas Lübking
Am 18.03.2012, 17:48 Uhr, schrieb Giorgos Tsiapaliwkas terie...@gmail.com: What do you think? Should we change the All effects tab? There likely has to remain a way for users to disable random effects. Eg. the screenshot effect is nice and you want to use it, unless VBOs are broken on

Re: Redesign kwin's kcm All effects

2012-03-18 Thread Thomas Lübking
Am 18.03.2012, 20:38 Uhr, schrieb Rick Stockton rickstock...@reno-computerhelp.com: Definitely fix and add videos. Actually: why? One could simply run some virtual Effect::demo() = 0;, yesno? So why have the user wait for the download, stressing kde.org servers, just to see a low-res

Re: Creating windows without a minimize button

2012-03-19 Thread Thomas Lübking
Am 19.03.2012, 02:23 Uhr, schrieb Nikos Chantziaras rea...@gmail.com: On 18/03/12 15:04, Martin Gräßlin wrote: The hint you want to set would only remove the minimize button but does not prevent you from minimizing the window as like I wrote there is no hint to forbid window minimization. This

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-03-27 Thread Thomas Lübking
has (single user approach - fix that by logging him in as root and watch the project fail ;-) - Thomas Lübking On March 27, 2012, 2:22 p.m., Lamarque Vieira Souza wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-03-27 Thread Thomas Lübking
On March 27, 2012, 2:30 p.m., Thomas Lübking wrote: Does the new patch actually *silently* skip move impossible attempts?? Excuse my ignorance, but why are system resources actually needed to be *moved* anywhere by a random user - what means they're now gone in their original location

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-03-27 Thread Thomas Lübking
On March 27, 2012, 2:30 p.m., Thomas Lübking wrote: Does the new patch actually *silently* skip move impossible attempts?? Excuse my ignorance, but why are system resources actually needed to be *moved* anywhere by a random user - what means they're now gone in their original location

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-03-30 Thread Thomas Lübking
/r/104417/#comment9482 !QUrl::isLocalFile()? - Thomas Lübking On March 30, 2012, 6:57 p.m., Lamarque Vieira Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417

Re: Review Request: Move trim malloc from KWorkspace to KWin

2012-04-07 Thread Thomas Lübking
On April 7, 2012, 9:15 a.m., Martin Gräßlin wrote: if nobody reviews this change, I'm going to push on Monday. It's totally ok from my POV - mallopt is always quite specific and (aside the actual configuration) not that kind of magic to have it in a library. - Thomas

Re: Review Request: [KActivityManagerDaemon] Activity Changed On Screen Display

2012-05-07 Thread Thomas Lübking
On May 7, 2012, 6:04 p.m., Ivan Čukić wrote: I really don't like having this as a kamd plugin. In general, I dream of a day when kamd will have no GUI code whatsoever. What about using knotify and extending it by an OSD? - Thomas

Review Request: use window role to detect the dashboard

2012-06-28 Thread Thomas Lübking
://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: use window role to detect the dashboard

2012-07-03 Thread Thomas Lübking
, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Thomas Lübking
On Sept. 6, 2012, 12:29 p.m., David Faure wrote: A number of comments on the implementation, but also a more general comment: does it even make sense to use a Speller in multiple threads, and to change the language from one thread while another one is using the speller for

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Thomas Lübking
. I've fixed your other comments in v2 of the diff, let me know if there is anything else. Thomas Lübking wrote: would it not make more sense to just kill the pending (and now worthless?) thread instead (no idea how expensive this spellchecking is to be threaded) to not waste cpu

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Thomas Lübking
On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote: That's pretty bonkers. This class was never meant to be used like that. Holding an object in two threads is not going to work unless you make the entire communication synchronous effectively reducing all the multi-threading aspects to a

Re: Review Request: Block screen edge activation for fullscreen windows

2012-10-04 Thread Thomas Lübking
On Oct. 4, 2012, 1:13 p.m., Thomas Lübking wrote: Special case solution? This will (by assumed behavior, didn't look into details) for quite sure trigger bug reports (can't switch desktops, present windows no longer works with fullscreen browser_here), so here's a warning about

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-12-09 Thread Thomas Lübking
On March 30, 2012, 8:18 p.m., Thomas Lübking wrote: service/jobs/nepomuk/Move.cpp, line 352 http://git.reviewboard.kde.org/r/104417/diff/5/?file=55320#file55320line352 !QUrl::isLocalFile()? Lamarque Vieira Souza wrote: isLocalFile() was introduced in Qt 4.8.0 and we still

Re: plasma and new shadow mess

2012-12-25 Thread Thomas Lübking
On Montag, 24. Dezember 2012 23:12:22 CEST, Weng Xuetian wrote: Hi Plasma world, As new shadow lands in KDE 4.10 RC1, some unintentional mess is introduced. https://bugs.kde.org/show_bug.cgi?id=311502 https://bugs.kde.org/show_bug.cgi?id=311995 I doubt those have much relation, notably

Re: Review Request: try fix tooltip shadow problem

2012-12-25 Thread Thomas Lübking
#312168. Wild guess from your patch: don't remove the shadows before, but *after* the hiding (eventually later, ie. in the deconstructor or on the destroyed signal) to avoid confusations between the deleted window size and the dirty area. - Thomas Lübking On Dec. 25, 2012, 12:14 a.m

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-04 Thread Thomas Lübking
/kwindowsystem_x11.cpp f9b3cc1 Diff: http://git.reviewboard.kde.org/r/107983/diff/ Testing --- see summary Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
://git.reviewboard.kde.org/r/107983/diff/ Testing --- see summary Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review24713 --- On Jan. 5, 2013, 2:38 p.m., Thomas Lübking wrote

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
--- On Jan. 5, 2013, 2:38 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 Diff: http://git.reviewboard.kde.org/r/107983/diff/ Testing --- see summary Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: Because the XFixesSelectSelectionInput() call specifies that the event should be delivered to winId(). KSelectionOwner does not send XFixes events; they are generated by the X server. Thomas Lübking wrote: Ok, problem

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: Because the XFixesSelectSelectionInput() call specifies that the event should be delivered to winId(). KSelectionOwner does not send XFixes events; they are generated by the X server. Thomas Lübking wrote: Ok, problem

Re: Review Request: fix kwin tabbox shadow

2013-01-06 Thread Thomas Lübking
On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote: I don't like having a link dependency on plasmagenericshell. If that is supposed to be used, then it needs to go to the workspaces libs. I also think that this approach just doesn't scale. We use Plasma styled dialogs for more

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
/#review25012 --- On Jan. 5, 2013, 5:08 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
plasma theme change caused by this. Trying to find you why.. Thomas Lübking wrote: The XFixesSelectionNotify event fires one every selection owner event, usually it'll be the cnp system (when you eg. mark text) The problem should ideally be fixed in Qt instead of working

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
://git.reviewboard.kde.org/r/107983/#review25025 --- On Jan. 9, 2013, 12:52 a.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2013-01-10 Thread Thomas Lübking
On Jan. 10, 2013, 6:42 a.m., Martin Gräßlin wrote: the big question is whether the code has been like that for historic reasons or whether there are problems with some window managers. I am for 99 % sure that it's for historic reasons, but the remaining 1 % tells me that it's

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-10 Thread Thomas Lübking
remains. This addresses bug 179042. http://bugs.kde.org/show_bug.cgi?id=179042 Diffs (updated) - kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 Diff: http://git.reviewboard.kde.org/r/107983/diff/ Testing --- see summary Thanks, Thomas Lübking

Re: Review Request 108375: fix bug 311116 / screenlocker hiding

2013-01-13 Thread Thomas Lübking
/greeter/screensaverwindow.cpp adb2587 Diff: http://git.reviewboard.kde.org/r/108375/diff/ Testing --- Screensaver - Emulation ;-) m_showScreenSaver = true; // screensaverWindow-setBackground(backgroundPix); screensaverWindow-setAutoFillBackground(true); Thanks, Thomas Lübking

Re: Review Request 108377: fix rest von 313020

2013-01-13 Thread Thomas Lübking
, ie. black screen. This addresses bug 313020. http://bugs.kde.org/show_bug.cgi?id=313020 Diffs - ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml 0e78fdd Diff: http://git.reviewboard.kde.org/r/108377/diff/ Testing --- Thanks, Thomas Lübking

Re: Review Request 108375: fix bug 311116 / screenlocker hiding

2013-01-13 Thread Thomas Lübking
://git.reviewboard.kde.org/r/108375/#comment19351 all changes in greeter.cpp are wrong and relics and i've reset the file locally - sorry for having it in the patch - Thomas Lübking On Jan. 13, 2013, 11:22 a.m., Thomas Lübking wrote

XDpms in screenlocker

2013-01-13 Thread Thomas Lübking
** please keep me in CC ** While stepping across the ksmserver/screenlocker/greeter/* code i noticed that there's (intended) support to show the screensaver on pressing esc, but no equivalent to re/activate dmps (DPMSForceLevel, xdpms force off) I've failed to find resp. API in powerdevil

Re: Review Request 108375: fix bug 311116 / screenlocker hiding

2013-01-13 Thread Thomas Lübking
/screensaverwindow.cpp adb2587 Diff: http://git.reviewboard.kde.org/r/108375/diff/ Testing --- Screensaver - Emulation ;-) m_showScreenSaver = true; // screensaverWindow-setBackground(backgroundPix); screensaverWindow-setAutoFillBackground(true); Thanks, Thomas Lübking

Re: Review Request 108375: fix bug 311116 / screenlocker hiding

2013-01-13 Thread Thomas Lübking
, visit: http://git.reviewboard.kde.org/r/108375/#review25397 --- On Jan. 13, 2013, 9:32 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit

Re: XDpms in screenlocker

2013-01-13 Thread Thomas Lübking
, Aaron J. Seigo wrote: On Sunday, January 13, 2013 13:55:54 Thomas Lübking wrote: ** please keep me in CC ** While stepping across the ksmserver/screenlocker/greeter/* code i noticed that there's (intended) support to show the screensaver on pressing esc, but no equivalent to re/activate dmps

Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-14 Thread Thomas Lübking
On Jan. 14, 2013, 7:59 a.m., Thomas Lübking wrote: my 2c only: if air has an unnotable *highlight* frame this should be fixed in the theme. if it is not fixable in the theme because the focus is on a mostly light and airy appearance i would frankly raise the question of usability

Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-14 Thread Thomas Lübking
/ Testing --- Yes, reliably toggles the screen even after press-holding the escape key (then wait for the actual screen state and then controlled toggling it) Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-14 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108417/#review25531 --- On Jan. 14, 2013, 9:12 p.m., Thomas Lübking wrote

Re: Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-14 Thread Thomas Lübking
powerdevil is inactive. I guess in that case asyncCall would simply silently fail, but better safe than sorry. Thomas Lübking wrote: It'll silently fail whereas the query for the interface is a synchronous (blocking) call which needs either to be performed off-thread

Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-14 Thread Thomas Lübking
On Jan. 14, 2013, 7:59 a.m., Thomas Lübking wrote: my 2c only: if air has an unnotable *highlight* frame this should be fixed in the theme. if it is not fixable in the theme because the focus is on a mostly light and airy appearance i would frankly raise the question of usability

Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-15 Thread Thomas Lübking
On Jan. 15, 2013, 3:06 p.m., Aaron J. Seigo wrote: yes, looks proper. on a broader note, it's probably hard/impossible to make the viewitem svg work for this use case and the general use case of QML views .. so +1 from me. I'd rather say if theme can not provide this, the

Re: Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-15 Thread Thomas Lübking
powerdevil is inactive. I guess in that case asyncCall would simply silently fail, but better safe than sorry. Thomas Lübking wrote: It'll silently fail whereas the query for the interface is a synchronous (blocking) call which needs either to be performed off-thread

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-01-15 Thread Thomas Lübking
--- On Jan. 9, 2013, 2 a.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983

Review Request 108441: prevent false positive mouse deactivation of screensaver

2013-01-16 Thread Thomas Lübking
--- Yes, also no dangerous asserts included (turned out i've debug compiling only fake enabled for kwin ;-) Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Thomas Lübking
because of eg. the requirement to mask the window (no idea whether that works at all) and doesn't catch plasma dialogs etc. - yet (aside the margin issue) better that what is there and the fix in the shadow frame is pretty much required. - Thomas Lübking On Jan. 16, 2013, 1:57 p.m., Martin

Re: Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-16 Thread Thomas Lübking
. If this is a companion to https://git.reviewboard.kde.org/r/108375/ (but for the simple locker) then what about just dismissing the unlock dialog on Escape? This is what the old screensaver did if I read correctly. In fact, is that an approach that works for all varieties of locker? Thomas Lübking wrote

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Thomas Lübking
On Jan. 16, 2013, 5:58 p.m., Sebastian Kügler wrote: This patch brings a big improvement on the contrast, works better even than I expected. :) On KDE/4.10 I'm getting the following build error: /home/sebas/kdesvn/src/kde-workspace/kwin/tabbox/../workspace.h: In function ‘bool

Re: Review Request 108375: fix bug 311116 / screenlocker hiding

2013-01-16 Thread Thomas Lübking
--- On Jan. 13, 2013, 9:32 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108375

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Thomas Lübking
a solution for KWin tells libplasma that we use compositing ;-) Thomas Lübking wrote: Does https://git.reviewboard.kde.org/r/107983/ not work for you? plasma could use the selectionwatcher, but must instantiate it after the eventloop is up Sebastian Kügler wrote: Thomas

Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-25 Thread Thomas Lübking
the geometry from VT1 as well - blast!) everything is nicely black (with compositing) Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-26 Thread Thomas Lübking
://git.reviewboard.kde.org/r/108585/#review26205 --- On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-26 Thread Thomas Lübking
On Jan. 26, 2013, 2:03 p.m., Oliver Henshaw wrote: I don't have multiple monitors to test with, but can you test with the the LockWindow set to some colour other than black? Just so that any bizarre side effects are more obvious. Thomas Lübking wrote: What bizarre side effects

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Thomas Lübking
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108585/#review26301 --- On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote: --- This is an automatically generated

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Thomas Lübking
(if the lockerwindow moved itself above the greeter) - at least activateWindow will not raise the window. - Thomas Lübking On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Thomas Lübking
for the Qt::transparent. This also requires it to be 32bit, ie. ARGB - is that lockerwindow constructed out of sth. else here (eg. plasma-desktop) or do you eventually run into this with the oxygen-transparent style or the resp. settings of QtCurve or Bespin? - Thomas Lübking On Jan. 28, 2013, 2:38

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Thomas Lübking
On Jan. 28, 2013, 3:27 p.m., Thomas Lübking wrote: ksmserver/screenlocker/greeter/greeterapp.cpp, line 210 http://git.reviewboard.kde.org/r/108643/diff/1/?file=109632#file109632line210 This is pointless because the greeter view is not managed (view-setWindowFlags(Qt

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Thomas Lübking
On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote: What kinda strucks me is that the window is translucent for the Qt::transparent. This also requires it to be 32bit, ie. ARGB - is that lockerwindow constructed out of sth. else here (eg. plasma-desktop) or do you eventually run

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-29 Thread Thomas Lübking
a 32bit drawable here (or this is maybe an issue in the driver) - Thomas Lübking On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-30 Thread Thomas Lübking
://git.reviewboard.kde.org/r/108438/#comment20104 No idea how expensive this is (eg. whether there's an I/O) but it could be cached (since iirc we connect the themeChange signal anyway) - Thomas Lübking On Jan. 30, 2013, 7:25 a.m., Martin Gräßlin wrote

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/#review26419 --- Ship it! Ship It! - Thomas Lübking On Jan. 30, 2013, 1:28

Re: Review Request 108513: Rewrite of KWin's Screen Edge Handling

2013-02-07 Thread Thomas Lübking
/#comment20329 F*** I ran into that yesterday and wanted to mention it. You forgot to bump the ABI (leading to *very* ominous crash reports here ;-) - Thomas Lübking On Feb. 4, 2013, 8:50 a.m., Martin Gräßlin wrote

Re: Review Request 104281: Drop Decorations B2, Laptop and Plastik

2013-02-09 Thread Thomas Lübking
On Feb. 7, 2013, 9:25 p.m., Albert Astals Cid wrote: I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited? Aaron J. Seigo wrote: plastik is gone, but b2 and laptop are still there. Albert Astals Cid wrote:

Re: Review Request 108957: Adding BAMF support to KWin

2013-02-14 Thread Thomas Lübking
frankly have no concept for the above ready (esp: who'd forgets information in the root case) but am not convinced about the bamf approach. It looks like some of my hack solutions in this regard, not anything like a proper solution. - Thomas Lübking On Feb. 14, 2013, 12:02 p.m., Martin Gräßlin

Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app

2013-03-11 Thread Thomas Lübking
the trigger dock type (thus managed) would more or less get you what you want (below -active- fullscreen windows, above everything else) - however they'd be below kwin screenedges (corners or to switch VD w/o moving a window) then (while currently above those) - Thomas Lübking On Aug. 22, 2012, 6:44

  1   2   3   4   >