D19893: Fix "Tooltip can not be displayed"

trmdi updated this revision to Diff 54699. trmdi added a comment. Change the target of the patch REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19893?vs=54352=54699 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19893 AFFECTED

D19893: [KickerDash] Add missed argument in addFavorite

trmdi added a comment. In D19893#437455 , @ngraham wrote: > Which bug are we fixing? A bit more context would be helpful. :) I can't find any one in the bug tracker, but you can easily reproduce it like I said at "Before" in the "Test

D20249: Make the Configuration button more understandable

trmdi added a comment. In D20249#443373 , @mvourlakos wrote: > I think would prefer a hovering mechanism, a rectangle with transparency e.g. 0.5 when this option is hovered How would the user know it's a button to hover it? He's

D20249: Make the Configuration button more understandable

trmdi created this revision. trmdi added reviewers: Latte Dock, rooty. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Without the button background, it's difficult to realize that it's a button. REPOSITORY

D20249: Make the Configuration button more understandable

trmdi updated this revision to Diff 55472. trmdi added a comment. Set hoverColor REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20249?vs=55412=55472 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20249 AFFECTED FILES

D20128: Center align shortcut badges when iconSize < 48

trmdi added a comment. In D20128#440574 , @mvourlakos wrote: > Checking the Badge height didn't work out well? I think checking the iconSize is enough. Because: - when iconSize >= 60, height = 0.4 * iconSize -> no need to center

D20128: Center align shortcut badges when iconSize < 48

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY When iconSize is not big enough, center aligned shortcut badges look better than top-left aligned

D20128: Center align shortcut badges when iconSize < 48

trmdi added a comment. Can you explain more about the number 58? I choose 48 because I think it is the minimum size that center aligning still looks good. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20128 To: trmdi, #latte_dock Cc: mvourlakos,

D20128: Center align shortcut badges when iconSize < 48

trmdi updated this revision to Diff 55107. trmdi added a comment. Add comments REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20128?vs=55072=55107 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20128 AFFECTED FILES

D20128: Center align shortcut badges when iconSize < 48

This revision was automatically updated to reflect the committed changes. Closed by commit R878:5fe27176fa12: Center align shortcut badges when iconSize 48 (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20128?vs=55107=55108 REVISION

D19309: Improve Unity Indicator

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Fix the bug "UnityRect is smaller than the icon in some cases", caused by `anchors.margin: 4`

D19309: Improve Unity Indicator

trmdi added a comment. In D19309#422634 , @mvourlakos wrote: > @trmdi do you have commit access? > > If not you can apply for one and you can reference me I tried it, but not sure if/when they will accept it. So could you please

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 52167. trmdi added a comment. This revision is now accepted and ready to land. Do not drag the item after right clicking on it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52130=52167 REVISION DETAIL

D19096: Improvements for long label items in Application Dashboard

trmdi added inline comments. INLINE COMMENTS > hein wrote in ItemGridDelegate.qml:117 > What do the hover changes do in this patch? :) It helps to display the tooltip. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma,

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 52321. trmdi edited the test plan for this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52167=52321 REVISION DETAIL

D19096: Improvements for long label items in Application Dashboard

trmdi added a comment. On some small screens e.g <= 1024x768, `units.iconSizes.large` is a bit too big, it may look better with `units.iconSizes.medium` > property int iconSize: smallScreen ? units.iconSizes.large : units.iconSizes.huge Should I change it in this patch or create

D19096: Improvements for long label items in Application Dashboard

trmdi added a comment. In D19096#416391 , @hein wrote: > What's all the unrelated code changes about mouse handling trying to achieve? > > Have you tested this with a few common screen resolutions / aspect ratios? The original grid was

D19800: [Application Dashboard] Improve mouse handler

trmdi created this revision. trmdi added reviewers: hein, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Clear pressedItem when dragging items - Correct the "view" attached property to

D19800: [Application Dashboard] Improve mouse handler

trmdi added a comment. In D19800#431914 , @ngraham wrote: > While I can't get the bug to happen as often with this, I still can sometimes--especially when I drag the top-left-most item down one column. > > This might need @hein's magic

D19800: [Application Dashboard] Improve mouse handler

trmdi added a comment. Ok, it will be fixed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19800 To: trmdi, hein, ngraham, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19800: [Application Dashboard] Improve mouse handler

trmdi updated this revision to Diff 54052. trmdi added a comment. Improve the code. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19800?vs=53992=54052 BRANCH fix-390424 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19800

D17073: Do not crop albumArt

trmdi added inline comments. INLINE COMMENTS > ngraham wrote in ToolTipInstance.qml:338 > No need to reduce the opacity here if the song name is bold. I think that makes it look nicer. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein,

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53884. trmdi added a comment. Use `Font.Bold` for the song name. (I feel it's a bit too bold though.) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=53812=53884 REVISION DETAIL

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53710. trmdi added a comment. This revision is now accepted and ready to land. Improve some stuff: - Use smaller fontsize, lineHeight for track/artist - "Anchor" albumArtImage's bottom to playerControlsLoader's top - When artist == "", let the song

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53769. trmdi added a comment. - Add 2px to leftMargin of track/artist. I don't set the margin of the Next button because it has its own padding. - Resize the player icon when "minimized, we don't have a preview" Is it fine enough to commit now ?

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53770. trmdi added a comment. Remove duplicated "ToolTipWindowMouseArea" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=53769=53770 REVISION DETAIL https://phabricator.kde.org/D17073 AFFECTED FILES

D17073: Do not crop albumArt

trmdi added a comment. - Using a bigger font size means less characters could be display. I don't see what is more important between artist/song. - I don't think the topMargin is needed because there is already a space between the song name and the cover image. My goal is to keep the cover

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53812. trmdi added a comment. Increase the contrast between the song name and the artist. F6689279: image.png REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19096: Improvements for long label items in Application Dashboard

trmdi abandoned this revision. trmdi added a comment. In D19096#427329 , @hein wrote: > I'm sorry, but I can't accept this patch as-is - the hoverArea-related changes are just wrong, it's not OK to couple a delegate to the view by making it set

D19893: Fix "Tooltip can not be displayed"

trmdi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH fix-tooltip (branched from master) REVISION DETAIL https://phabricator.kde.org/D19893 AFFECTED FILES

D19096: [Kicker] Fix "Tooltip can not be displayed"

trmdi requested review of this revision. trmdi added a comment. Are you ok with the new implementation? @hein REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, broulik Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2,

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 54349. trmdi added a comment. This revision is now accepted and ready to land. Update code style, only fix the tooltip bug. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52321=54349 BRANCH fix-tooltip

D19096: Improvements for long label items in Application Dashboard

trmdi added a comment. In D19096#434638 , @abetts wrote: > Does this patch only concern itself with the icons and labels below them or also the categories on the right? If so, it feels like the category labels on the right are huge in

D19777: Apply changes for tooltip from upstream

trmdi updated this revision to Diff 53940. trmdi added a comment. Delete the forgotten lines REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19777?vs=53937=53940 BRANCH update-tooltip (branched from master) REVISION DETAIL

D19777: Apply changes for tooltip from upstream

trmdi added a comment. Yes, it works for me. How did you apply the patch ? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19777 To: trmdi, mvourlakos, rooty Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19777: Apply changes for tooltip from upstream

trmdi created this revision. trmdi added reviewers: mvourlakos, rooty. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Do not crop albumArt - Use smaller fontsizes for labels. REPOSITORY R878 Latte Dock

D19777: Apply changes for tooltip from upstream

trmdi updated this revision to Diff 53941. trmdi added a comment. Small fix for margins REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19777?vs=53940=53941 BRANCH update-tooltip (branched from master) REVISION DETAIL

D18805: Workaround for the bug 393630 - SystemTray part

trmdi added a comment. @davidedmundson Nice approach. I don't really understand the root cause though. So, could you please do it for me? Thank you! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18805 To: trmdi, #plasma, ngraham, broulik,

D18805: Workaround for the bug 393630 - SystemTray part

trmdi added a comment. In D18805#407599 , @fvogt wrote: > You can select "Abandon revision" as action. Done. Thank you. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18805 To: trmdi, #plasma,

D19096: Increase the label's area

trmdi created this revision. trmdi added reviewers: ngraham, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Decrease some others' areas to increase the label's area to enable it to display 2 lines of

D19096: Increase the label's area to display 2 lines of text when needed

trmdi updated this revision to Diff 51941. trmdi retitled this revision from "Increase the label's area" to "Increase the label's area to display 2 lines of text when needed". trmdi edited the summary of this revision. trmdi edited the test plan for this revision. REPOSITORY R119 Plasma

D18918: Make the text of "View Settings" action more specific

trmdi added a comment. In D18918#410552 , @mvourlakos wrote: > for Latte panels after startup or after switching layouts if the user right clicks the panel the menu is appearing correctly as: > > **Panel Setings...** ? Whenever

D18918: Make the text of "View Settings" action more specific

trmdi added a comment. In D18918#410614 , @mvourlakos wrote: > I don't think it is needed, you can try to update the action text just a little before the menu is shown > > Qmenu has an aboutToShow signal and containment has as a

D18918: Make the text of "View Settings" action more specific

trmdi added inline comments. INLINE COMMENTS > mvourlakos wrote in menu.cpp:91 > is this still needed if we check the value each time we show up the context > menu? Yes, it's needed. Because when you're opening the Setting window and you right click on the view, it will close the Setting

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51515. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51498=51515 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp To: trmdi, mvourlakos Cc:

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51498. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51481=51498 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18918: Make the text of "View Settings" action more specific

trmdi added inline comments. INLINE COMMENTS > mvourlakos wrote in menu.cpp:68 > when we add character & in the menus it means that a modifier+ > activates that option what is the shortcut that add widgets? For example, " widgets..." - shortcut: `Alt+a` - the shortcut only works when that

D18918: Make the text of "View Settings" action more specific

trmdi added inline comments. INLINE COMMENTS > mvourlakos wrote in menu.cpp:92 > in this slot is also needed: > > m_configureAction->setEnabled(true); > > there are cases that the Dock Settings is shown when !configuring but it is > not enabled I don't understand. my code only change the

D18976: Improve Contextmenu

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Display Dock Settings/Panel Settings instead of View Settings - Hide View Settings when

D18976: Improve Contextmenu

trmdi updated this revision to Diff 51573. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18976?vs=51563=51573 REVISION DETAIL https://phabricator.kde.org/D18976 AFFECTED FILES containmentactions/contextmenu/menu.cpp To: trmdi, #latte_dock Cc:

D18976: Improve Contextmenu

trmdi added a comment. Oh, wait... I've just seen it is disabled unexpectedly. Do you know why ? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18976 To: trmdi, #latte_dock, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18976: Improve Contextmenu

trmdi updated this revision to Diff 51613. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18976?vs=51573=51613 REVISION DETAIL https://phabricator.kde.org/D18976 AFFECTED FILES containmentactions/contextmenu/menu.cpp To: trmdi, #latte_dock,

D18918: Make the text of "View Settings" action more specific

trmdi added a comment. In D18918#409852 , @mvourlakos wrote: > ok, just checked the previous mentioned class has access to containment() that means that through its configuration the menu could be informed for the type, so directly access to

D18918: Make the text of "View Settings" action more specific

trmdi added a comment. In D18918#409850 , @mvourlakos wrote: > Personally I dont like the approach, this wont work in some cases e.g. when right clicking plasma taskmanager. but when right clicking on plasma taskmanager, there is not

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51431. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51389=51431 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES app/view/contextmenu.cpp app/view/view.cpp app/view/view.h To: trmdi,

D18918: Make the text of "View Settings" action more specific

trmdi created this revision. trmdi added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY If it's a dock -> Dock Settings... If it's a panel -> Panel Settings... REPOSITORY R878 Latte

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51389. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51387=51389 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES app/view/contextmenu.cpp app/view/view.cpp app/view/view.h To: trmdi,

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51456. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51431=51456 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51464. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51459=51464 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51458. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51456=51458 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51459. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51458=51459 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18918: Make the text of "View Settings" action more specific

trmdi added inline comments. INLINE COMMENTS > view.cpp:333 > +}; > +const QString viewSettingsText(m_behaveAsPlasmaPanel? > viewSettingsTexts[1] : viewSettingsTexts[2]); > +const QString strippedText(a->text().replace("&", "")); I've found a bug here: when inEditMode,

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51481. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51464=51481 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18805: Workaround for the bug 393630 - SystemTray part

trmdi added a comment. In D18805#406916 , @anthonyfieroni wrote: > I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in. Does my

D18805: Workaround for the bug 393630 - SystemTray part

trmdi created this revision. trmdi added reviewers: Plasma, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Require: https://phabricator.kde.org/D18804 BUG: 393630 REPOSITORY R120

D18717: improvements for global shortcuts

trmdi updated this revision to Diff 51015. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50978=51015 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h

D18717: improvements for global shortcuts

trmdi marked an inline comment as done. trmdi added a comment. 1, please make a check that sortedViewsList returns count()>0 and if it doesnt it can return a nullptr -> done 2, your turn REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717 To: trmdi,

D18717: improvements for global shortcuts

trmdi added a comment. In D18717#406296 , @mvourlakos wrote: > @trmdi would you like to commit it for you? > Can I use your fullname shown at: https://phabricator.kde.org/p/trmdi/ ? > and what is your email? Yes, I don't have the

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 52130. trmdi added a comment. Fix tooltip's height. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52097=52130 REVISION DETAIL https://phabricator.kde.org/D19096 AFFECTED FILES

D19096: Improvements for long label items

trmdi updated this revision to Diff 52097. trmdi retitled this revision from "Increase the label's area to display 2 lines of text when needed" to "Improvements for long label items". trmdi edited the summary of this revision. trmdi edited the test plan for this revision. REPOSITORY R119

D19777: Apply changes for tooltip from upstream

This revision was automatically updated to reflect the committed changes. Closed by commit R878:432d6fb75349: Apply changes for tooltip from upstream (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19777?vs=53941=53952 REVISION DETAIL

D25310: Use the right value of EnableMagicMimeActions

trmdi created this revision. trmdi added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY BUG: 409801 TEST PLAN The bug is fixed. REPOSITORY R120 Plasma Workspace BRANCH

D25310: Use the right value of EnableMagicMimeActions

trmdi added a comment. Ping! REPOSITORY R120 Plasma Workspace BRANCH fix-enableMagicMimeActions (branched from master) REVISION DETAIL https://phabricator.kde.org/D25310 To: trmdi, #plasma, ngraham, apol Cc: ngraham, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25310: Use the right value of EnableMagicMimeActions

trmdi added a comment. Ah, I think like you, just following the existing code. :D In D25310#572211 , @davidedmundson wrote: > I can't really object, as you're just following the existing code, but I don't really understand why we're doing

D25758: Use the right value of enableMagicMimeActions

trmdi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25758 AFFECTED FILES klipper/urlgrabber.cpp To: trmdi Cc:

D25310: Use the right value of EnableMagicMimeActions

trmdi updated this revision to Diff 70933. trmdi added a comment. Remove unneeded code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25310?vs=69759=70933 BRANCH fix-enableMagicMimeActions REVISION DETAIL https://phabricator.kde.org/D25310

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71408. trmdi added a comment. - emit signals when setConnected REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71391=71408 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71488. trmdi added a comment. - Improve comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71408=71488 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71594. trmdi added a comment. - No need to setConnected manually REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71488=71594 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. In D25807#579125 , @davidre wrote: > I have a question about naming. If I had an application like panel or latte I would call setAvailableScreenRect? That seems kinda backwards to me? That part of the screen is not

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71391. trmdi added a comment. - Redirect the signals - Rename the functions - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into add-otherShellHelper REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi created this revision. trmdi added reviewers: Plasma, mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Allow to set the available screen rect/region from outside through dbus. REPOSITORY R120

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71079. trmdi added a comment. - Fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71077=71079 BRANCH add-otherShellHelper REVISION DETAIL https://phabricator.kde.org/D25807 AFFECTED FILES

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. @davidedmundson Concerning the type of screenId should be QString, I think it need another patch, because Plasma::Corona's availableScreenRect also requires that type: https://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00331 REPOSITORY

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71650. trmdi added a comment. - Use QString type for the dbus screenId parameters REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71649=71650 BRANCH add-otherShellHelper (branched from master)

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71648. trmdi marked 2 inline comments as done. trmdi added a comment. - Add a missed line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71647=71648 BRANCH add-otherShellHelper (branched from master)

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71647. trmdi added a comment. - Follow David's guide REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71594=71647 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71649. trmdi added a comment. - Add another missed line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71648=71649 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D25580: [System Tray] Unified data model for System Tray items

trmdi added a comment. Please make sure it would not bring this bug back: https://phabricator.kde.org/R120:6fcf9a5e03ba573fd0bfe30125f4c739b196a989 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25580 To: kmaterka, #plasma, broulik, ngraham, nicolasfella

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71979. trmdi added a comment. - Use screenName instead of id in setAvailableScreenRect/Region() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71802=71979 BRANCH add-otherShellHelper (branched from

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71980. trmdi added a comment. - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into add-otherShellHelper - Just rename the screenId parameter of test() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. @mvourlakos Latte can guard that the order of screens are the same with plasmashell right? Because I see this: https://github.com/KDE/latte-dock/blob/master/app/screenpool.cpp REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25807

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. In D25807#578640 , @davidedmundson wrote: > The problem is that on wayland (and to some extent x11 is racey) the order of screens within QApplication::screens might not be in sync across processes. Is it possible

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. In D25807#581161 , @mvourlakos wrote: > In D25807#581126 , @trmdi wrote: > > > @mvourlakos > > Latte can guard that the order of screens within Latte is synced with

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71802. trmdi added a comment. - Remove unneeded code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71650=71802 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi added a comment. Hmm, I think the 1.5 ratio makes a nice shape, the thumbnail is also not too small. A tooltip has texts and a thumbnail, we needn't too focus in the thumbnail. F8098753: image.png REPOSITORY R119 Plasma Desktop REVISION

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi updated this revision to Diff 75287. trmdi added a comment. - Remove the redundant line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27149?vs=75286=75287 BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 76596. trmdi added a comment. Never show before position is set REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=75883=76596 BRANCH arcpatch-D27458 (branched from master) REVISION DETAIL

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 76597. trmdi added a comment. Small fix. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=76596=76597 BRANCH arcpatch-D27458 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27458

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 76629. trmdi added a comment. Rename m_realVisible to m_requestedVisible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=76597=76629 BRANCH arcpatch-D27458 (branched from master) REVISION DETAIL

  1   2   3   >