D25539: feat(kcm): add revert timer

liushuyu added a comment. Any other suggestions for this patch? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma, romangg Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D25539: feat(kcm): add revert timer

liushuyu updated this revision to Diff 70390. liushuyu added a comment. Use InlineMessage instead of MessageBox and move the timer to the QML portion REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25539?vs=70329=70390 BRANCH master REVISION DETAIL

D25539: feat(kcm): add revert timer

liushuyu marked 2 inline comments as done. liushuyu added a comment. Now it looks like this F7785973: image.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma, romangg Cc: ngraham, broulik,

D25539: feat(kcm): add revert timer

liushuyu marked 2 inline comments as done. liushuyu added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:32 > Doesn't seem to be used; the timer duration is hardcoded on the C++ side Now, it's used by the Timer > ngraham wrote in main.qml:110 > I would change these to

D25539: KScreen KCM: Add a revert timer to the settings page

liushuyu created this revision. liushuyu added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. liushuyu requested review of this revision. REVISION SUMMARY Add a revert timer and an option for the user to revert the settings when they accidentally

D25539: KScreen KCM: Add a revert timer to the settings page

liushuyu updated this revision to Diff 70329. liushuyu added a comment. Fix the diff REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25539?vs=70328=70329 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25539 AFFECTED FILES

D25539: feat(kcm): add revert timer

liushuyu added a comment. After applying the patches from https://cgit.kde.org/kirigami.git/commit/?id=8c1e5b1336e6dcae0a1b7756977fcd9368f853a2, it now looks like this: F7787159: image.png REPOSITORY R104 KScreen REVISION DETAIL

D25539: feat(kcm): add revert timer

liushuyu updated this revision to Diff 70451. liushuyu added a comment. Update icons and stop the timer on actions pressed REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25539?vs=70390=70451 BRANCH master REVISION DETAIL

D25539: feat(kcm): add revert timer

liushuyu updated this revision to Diff 70474. liushuyu added a comment. Address ndavis' comments REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25539?vs=70451=70474 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25539 AFFECTED FILES

D25539: feat(kcm): add revert timer

liushuyu added a comment. In D25539#568678 , @ndavis wrote: > Is there a way to tell the revert timer not to be used if the user only makes a change that requires a session restart? It wouldn't be very useful to ask a user to confirm if the

D25539: feat(kcm): add revert timer

liushuyu abandoned this revision. liushuyu added a comment. This patch has been migrated to https://invent.kde.org/plasma/kscreen/-/merge_requests/1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma, romangg Cc: ngraham, broulik,