[Differential] [Accepted] D1670: New login screen

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Just fix those minor nitpicks and then good to go, thanks! INLINE COMMENTS > screenModel.qml:14 > > //We create two monitors here, the left one

[Differential] [Updated] D1765: [KRunner] Disable high dpi scaling

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1765 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, sebas

[Differential] [Request, 3 lines] D1765: [KRunner] Disable high dpi scaling

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It uses Plasma

[Differential] [Commented On] D1765: [KRunner] Disable high dpi scaling

broulik added a comment. It's not just about the positioning (looks more like a kwin bug or something like that) but also the TextField sizing is completely broken because Plasma Components don't handle Qt scaling well. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Closed] D1737: [Desktop Containment] Remove debug elements

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPd812831eebe6: [Desktop Containment] Remove debug elements (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Request, 34 lines] D1771: [Workspace Options] Add option to disable OSD

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a dependency: D1770: [OSD] Allow disabling OSD through config file. Restricted Application added a project: Plasma.

[Differential] [Request, 9 lines] D1770: [OSD] Allow disabling OSD through config file

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Works. REPOSITORY

[Differential] [Updated] D1770: [OSD] Allow disabling OSD through config file

broulik added a dependent revision: D1771: [Workspace Options] Add option to disable OSD. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1770 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

broulik added a comment. F143325: Screenshot_20160605_203840.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 2 lines] D1769: [Service Runner] Don't use KRun::runService

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It blocks KRunner while

[Differential] [Closed] D1578: [Notifications] Unbreak notification actions

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe772deb6468b: [Notifications] Unbreak notification actions (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1578?vs=3730=4213#toc REPOSITORY rPLASMAWORKSPACE

[Differential] [Changed Subscribers] D1800: Load a Wallpaper plugin in kscreenlocker_greet

broulik added inline comments. INLINE COMMENTS > greeterapp.cpp:198 > +[this, qmlObject, view] { > +auto item = dynamic_cast(qmlObject->rootObject()); > +if (!item) { qobject_cast > greeterapp.cpp:200 > +if (!item) { > +

[Differential] [Accepted] D1796: Improve API documentation

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH more-documentation REVISION DETAIL https://phabricator.kde.org/D1796 EMAIL PREFERENCES

[Differential] [Accepted] D1795: [windowsystem] Implement (un)minimizeWindow through KWayland::Client::PlasmaWindow

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland BRANCH minimize-kwindowsystem REVISION DETAIL https://phabricator.kde.org/D1795 EMAIL

[Differential] [Request, 25 lines] D1788: [Pager] Don't update models when not visible

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When there is only one

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

broulik added a comment. See https://phabricator.kde.org/D1771 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, graesslin

[Differential] [Commented On] D1770: [OSD] Allow disabling OSD through config file

broulik added a comment. See https://phabricator.kde.org/D1771 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1770 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: mart, graesslin,

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

broulik added inline comments. INLINE COMMENTS > mart wrote in Panel.qml:32 > perhaps as a property of the view could work Ah yeah, it's not on containment, I put it on panel. yay for testing my patches :D REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Updated, 73 lines] D1757: [Panel] Reduce duplicate enabled borders calculation

broulik updated this revision to Diff 4233. broulik added a comment. - It's panel.enabledBorders, not containment - Remove onPrefixChanged handler REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1757?vs=4189=4233 REVISION DETAIL

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

broulik added a comment. Ping REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mart, davidedmundson, #plasma Cc: mart, davidedmundson, plasma-devel,

[Differential] [Closed] D1756: [PanelView] Expose enabled borders as property and also forward it to PanelShadows

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE97269b5aa9c2: [PanelView] Expose enabled borders as property and also forward it to… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1756?vs=4188=4282#toc

[Differential] [Closed] D1778: [PanelConfigView] Set enabled borders on PanelShadow

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE66688af5c3a1: [PanelConfigView] Set enabled borders on PanelShadow (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1592: [Device Notifier] Add option to disable popup on new device

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE9c2f167b6caf: [Device Notifier] Add option to disable popup on new device (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1592?vs=3770=4284#toc REPOSITORY

[Differential] [Commented On] D1670: New login screen

broulik added a comment. That last one was a "Fix it, then Ship it!" comment Go go go before our VDG guys get even more impatient ;) REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH login REVISION DETAIL https://phabricator.kde.org/D1670 EMAIL PREFERENCES

[Differential] [Request, 39 lines] D1778: [PanelConfigView] Set enabled borders on PanelShadow

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes the panel

[Differential] [Updated] D1778: [PanelConfigView] Set enabled borders on PanelShadow

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, sebas

[Differential] [Updated, 2 lines] D1769: [Service Runner] Don't use KRun::runService

broulik updated this revision to Diff 4246. broulik added a comment. Use "new KRun" REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1769?vs=4211=4246 REVISION DETAIL https://phabricator.kde.org/D1769 AFFECTED FILES

[Differential] [Commented On] D1788: [Pager] Don't update models when not visible

broulik added a comment. What could cause this root.visible problem? The container is invisible and removing the explicit applet.visible = true call in the Panel doesn't help either. I tried everything, yet still initially it thinks it's visible. REPOSITORY rPLASMADESKTOP Plasma

[Differential] [Request, 7 lines] D1781: [Task Manager] Don't show "Move To Desktop" menu when there is just one virtual desktop

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Right click - no annoying menu

[Differential] [Updated, 53 lines] D1673: WIP: [Libtaskmanager] Add support for regular expression mapping

broulik updated this revision to Diff 4254. broulik added a comment. - Rebase ontop of new libtaskmanager - was a straight forward port :) Cool side-effect: Chome webapp windows are no longer grouped to other Chrome browser windows, making them behave like real applications. REPOSITORY

[Differential] [Closed] D1782: [Task Manager] Fix adding launcher

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP2c0767395ce9: [Task Manager] Fix adding launcher (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1782?vs=4255=4258

[Differential] [Closed] D1781: [Task Manager] Don't show "Move To Desktop" menu when there is just one virtual desktop

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP2429e5699344: [Task Manager] Don't show "Move To Desktop" menu when there is just one… (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1673: WIP: [Libtaskmanager] Add support for regular expression mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE92efc6ca6ec3: [Libtaskmanager] Add support for regular expression mapping (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1673: WIP: [Libtaskmanager] Add support for regular expression mapping

broulik added a comment. Will do, once I figure out what I forgot to update: plasmashell: symbol lookup error: /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so: undefined symbol: _ZN11TaskManager12GroupManagerC1EP7QObject :) REPOSITORY

[Differential] [Updated] D1782: [Task Manager] Fix adding launcher

broulik updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1782 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: plasma-devel, sebas

[Differential] [Request, 2 lines] D1782: [Task Manager] Fix adding launcher

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's requestAddLauncher,

[Differential] [Closed] D1765: [KRunner] Disable high dpi scaling

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb22a742395fb: [KRunner] Disable high-dpi scaling (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1635: [OSD] Make volume OSD thresholds consistent with Volume Applet

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEad36c6dba6a7: [OSD] Make volume OSD thresholds consistent with Volume Applet (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1769: [Service Runner] Don't use KRun::runService

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE83eacf74ce6a: [Service Runner] Don't use KRun::runService (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1769?vs=4246=4247#toc REPOSITORY rPLASMAWORKSPACE

[Differential] [Closed] D1562: [OSD] Enable wrapping into two lines

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE695d6272149c: [OSD] Enable wrapping into two lines (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1350: [Digital Clock] Allow copying current date to clipboard

broulik added a comment. Is there a way to force an update of the DataSource data? Since it's 1min aligned the seconds in the menu will always be 0 (or 1 or 59) and I don't see a (public) method to force an update. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Request, 43 lines] D1830: [DrKonqi] Remove heartbeat icon

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's

[Differential] [Commented On] D1830: [DrKonqi] Remove heartbeat icon

broulik added a comment. F148033: Screenshot_20160612_213822.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 12 lines] D1832: [DrKonqi] Add config to directly show backtrace

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As suggested by some

[Differential] [Closed] D1752: [Panel Configuration] Disallow pressing Escape whilst manipulating panel

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPad1313fe277f: [Panel Configuration] Disallow pressing Escape whilst manipulating panel (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Request, 74 lines] D1757: [Panel] Reduce duplicate enabled borders calculation

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of calculating them

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

broulik added inline comments. INLINE COMMENTS > Panel.qml:29 > + > +//onPrefixChanged: adjustBorders(); > onRepaintNeeded: adjustPrefix(); Dunno if we still need this, ie. if we need a way to signal this back to cpp > Panel.qml:32 > > -visible: false //adjust borders is run

[Differential] [Updated] D1735: Notify about low peripheral batteries (mouse, keyboard)

broulik updated the summary for this revision. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1735 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: colomar, lueck, graesslin,

[Differential] [Request, 12 lines] D1752: [Panel Configuration] Disallow pressing Escape whilst manipulating panel

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When dragging the panel

[Differential] [Request, 106 lines] D1756: [PanelView] Expose enabled borders as property and also forward it to PanelShadows

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I noticed that panels

[Differential] [Closed] D1793: [Device Notifier] Be more declarative

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6c0b1e542c19: [Device Notifier] Be more declarative (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1793?vs=4285=4373#toc REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Closed] D1788: [Pager] Don't update models when not visible

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP87b7e283a58a: [Pager] Don't update models when not visible (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Abandoned] D1748: [KCM Keyboard] Delay initializing mouse

broulik abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1748 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: graesslin, drosca, davidedmundson, plasma-devel, sebas

[Differential] [Commented On] D1735: Notify about low peripheral batteries (mouse, keyboard)

broulik added a comment. Ping REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1735 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: colomar, lueck, graesslin, plasma-devel, sebas

[Differential] [Request, 13 lines] D1839: [Panel] Fix warning and don't cause side-effects in binding

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The length binding was

[Differential] [Closed] D1757: [Panel] Reduce duplicate enabled borders calculation

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb003ca6b79a0: [Panel] Reduce duplicate enabled borders calculation (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1757?vs=4233=4378#toc REPOSITORY

[Differential] [Accepted] D1831: Add rule for chromium to taskmanagerrulesrc for proper grouping.

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. He sat next to me while writing the patch and it works. :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1831 EMAIL PREFERENCES

[Differential] [Updated, 75 lines] D1479: [Notifications] Limit notification size and add scroll bar if needed

broulik retitled this revision from "[Notifications] Limit notification size and scroll to the bottom if needed" to "[Notifications] Limit notification size and add scroll bar if needed". broulik updated the summary for this revision. broulik updated the test plan for this revision. broulik set

[Differential] [Request, 5 lines] D1845: [Compact Applet] Hide tooltip when showing contextual actions

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When you hover an applet and

[Differential] [Request, 11 lines] D1848: [System Tray] Fix current item highlight

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The highlight currently

[Differential] [Closed] D1845: [Compact Applet] Hide tooltip when showing contextual actions

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP6af06c0075f6: [Compact Applet] Hide tooltip when showing contextual actions (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1830: [DrKonqi] Remove heartbeat icon

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE845738011d4c: [DrKonqi] Remove heartbeat icon (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 5 lines] D1847: [System Tray AbstractItem] Hide tooltip when clicking item

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When you click an item

[Differential] [Changed Subscribers] D1856: more creative output type detection in xrandr backend

broulik added inline comments. INLINE COMMENTS > xrandroutput.cpp:258 > + > +Q_FOREACH(const QString , embedded) { > +if (name.toUpper().startsWith(pre)) { range for, embedded is const REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/xrandrtype REVISION DETAIL

[Differential] [Closed] D1847: [System Tray AbstractItem] Hide tooltip when clicking item

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf117addb616a: [System Tray AbstractItem] Hide tooltip when clicking item (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 8 lines] D1869: [Containment Actions] Offer "Remove this panel" option only when panel is being edited

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We only

[Differential] [Request, 810 lines] D1867: [Calendar Applet] Show day or week number in icon

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Rather

[Differential] [Changed Subscribers] D1865: TasksModel: cache launcherCount().

broulik added inline comments. INLINE COMMENTS > tasksmodel.cpp:763 > + > +d->launcherCount = launchers.count(); > +} Better set the new value before emitting the change signal REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1865 EMAIL

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

broulik added a comment. Might need a new icon though F149458: Screenshot_20160614_144210.png F149459: Screenshot_20160614_144217.png F149460: Screenshot_20160614_144303.png

[Differential] [Closed] D1832: [DrKonqi] Add config to directly show backtrace

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE17597ee16fe0: [DrKonqi] Add config to directly show backtrace (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 2 lines] D1874: [XWindowTasksModel] Ignore when client is transient for itself

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Now I get Android Studio

[Differential] [Closed] D1874: [XWindowTasksModel] Ignore when client is transient for itself

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE58ea81b94ba3: [XWindowTasksModel] Ignore when client is transient for itself (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

broulik added a comment. That icon has been shipped, but never used, with the calendar applet for so long I don't even find a trace of it being added in git log. It's plasma-workspace/applets/calendar/package/contents/images/mini-calendar.svgz REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Request, 6 lines] D1888: [startkde] Call KSplash dbus after checking for kinit

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The check was supposed

[Differential] [Closed] D1869: [Containment Actions] Offer "Remove this panel" option only when panel is being edited

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEa5b728b27fdd: [Containment Actions] Offer "Remove this panel" option only when panel is… (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1888: [startkde] Call KSplash dbus after checking for kinit

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3955e784f179: [startkde] Call KSplash dbus after checking for kinit (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 793 lines] D1867: [Calendar Applet] Show day or week number in icon

broulik updated this revision to Diff 4501. broulik added a comment. Use a C++ applet instead of a private import REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1867?vs=4454=4501 REVISION DETAIL https://phabricator.kde.org/D1867

[Differential] [Updated, 795 lines] D1867: [Calendar Applet] Show day or week number in icon

broulik updated this revision to Diff 4503. broulik added a comment. Fix cmake to include calendar subdir instead of installing REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1867?vs=4501=4503 REVISION DETAIL

[Differential] [Request, 5 lines] D1891: [Holiday Events] Handle holidays spanning multiple days

broulik created this revision. broulik added reviewers: Plasma, graesslin, mck182. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We are

[Differential] [Commented On] D1891: [Holiday Events] Handle holidays spanning multiple days

broulik added a comment. F150532: Screenshot_20160615_160623.png Easter Monday shown REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1891 EMAIL PREFERENCES

[Differential] [Updated] D1891: [Holiday Events] Handle holidays spanning multiple days

broulik updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1891 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, graesslin, mck182 Cc: plasma-devel,

[Differential] [Request, 8 lines] D1853: [Task Manager] Allow minimizing/restoring windows/groups by middle clicking

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 345081 FIXED-IN:

[Differential] [Closed] D1848: [System Tray] Fix current item highlight

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE91f80fbe9b40: [System Tray] Fix current item highlight (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1853: [Task Manager] Allow minimizing/restoring windows/groups by middle clicking

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP2a24828eedfb: [Task Manager] Allow minimizing/restoring windows/groups by middle clicking (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1849: Write out QT_SCREEN_SCALE_FACTORS instead of deprecated QT_DEVICE_PIXEL_RATIO

broulik added a comment. Do we need a kconfig update script? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D1849 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1850: Write out scaling in QT_SCREEN_SCALE_FACTORS format

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH scale_factos REVISION DETAIL https://phabricator.kde.org/D1850 EMAIL PREFERENCES

[Differential] [Updated, 10 lines] D1847: [System Tray AbstractItem] Hide tooltip when clicking item

broulik updated this revision to Diff 4414. broulik added a comment. Also apply the same CompactApplet patch so this actually all works reliably REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1847?vs=4407=4414 REVISION DETAIL

[Differential] [Closed] D1839: [Panel] Fix warning and don't cause side-effects in binding

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP52b4809728bf: [Panel] Fix warning and don't cause side-effects in binding (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1735: Notify about low peripheral batteries (mouse, keyboard)

This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL550bdc40d4e8: Merge branch 'broulik/notifyPeripherals' (authored by broulik). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1735?vs=4163=4388

[Differential] [Changed Subscribers] D1841: Tasks model: don't load 4 icon sizes to then just use one.

broulik added inline comments. INLINE COMMENTS > xwindowtasksmodel.cpp:662 > + > +// FIXME Hard-coding 64x64 or SizeLarge is not scaling-aware. > Can't you make a property where the applet tells it the size it likes to have, similar to what you do with the drag pixmap size? REPOSITORY

[Differential] [Updated, 10 lines] D1839: [Panel] Fix warning and don't cause side-effects in binding

broulik updated this revision to Diff 4386. broulik added a comment. Use "when" to not mess with the panel length until we have a containment. Otherwise we would start and briefly have the panel at 0 size which looks ugly. This probably was concealed by the old code just throwing an

[Differential] [Request, 51 lines] D1793: [Device Notifier] Be more declarative

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of having a

[Differential] [Changed Subscribers] D1796: Improve API documentation

broulik added inline comments. INLINE COMMENTS > plasmawindowmanagement.h:163 > +/** > + * @returns The currently active PlasmaWindow, the PlasmaWindow which > returns @c true in @link{PlasmaWindow::isActive}. > + **/ or nullptr if there's no such window (in case this can happen)

[Differential] [Commented On] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop

broulik added a comment. If I set a window to show on all desktops, it reports -1. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1706 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma,

[Differential] [Updated, 89 lines] D1718: [PanelView] Check whether we're X11 before calling QX11Info::connection()

broulik updated this revision to Diff 4076. broulik added a comment. Wrap everything inside if (QX11Info::isPlatformX11()) { REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1718?vs=4075=4076 REVISION DETAIL

[Differential] [Closed] D1716: [Panel Configuration] Close when pressing Escape

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPf32e0c990e99: [Panel Configuration] Close when pressing Escape (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1715: [Desktop Toolbox] Close toolbox popup before triggering action

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPe3bf0a5bb0a9: [Desktop Toolbox] Close toolbox popup before triggering action (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Request, 2 lines] D1715: [Desktop Toolbox] Close toolbox popup before triggering action

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The still open dialog might

[Differential] [Updated] D1716: [Panel Configuration] Close when pressing Escape

broulik retitled this revision from "[Panel Configuration] Close when pressing Escap" to "[Panel Configuration] Close when pressing Escape". REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1716 EMAIL PREFERENCES

[Differential] [Request, 12 lines] D1716: [Panel Configuration] Close when pressing Escap

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When pressing Escape the

  1   2   3   4   5   6   7   8   9   10   >