[Differential] [Updated, 916 lines] D409: new mobile components

2015-10-27 Thread mart (Marco Martin)
mart updated this revision to Diff 1066. REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D409?vs=1009=1066 REVISION DETAIL https://phabricator.kde.org/D409 AFFECTED FILES components/mobilecomponents/ActionGroup.qml

[Differential] [Commented On] D409: new mobile components

2015-10-27 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS components/mobilecomponents/ActionGroup.qml:26 yes, to do a tree-like thing components/mobilecomponents/ContextDrawer.qml:40 I'm still not sure wether the dependencies should be. I think i'll go for using qqc and wrapping the other classes that i

[Differential] [Updated] D409: new mobile components

2015-10-27 Thread mart (Marco Martin)
mart marked 5 inline comments as done. mart added a comment. REPOSITORY rPLASMAMOBILE plasma-mobile REVISION DETAIL https://phabricator.kde.org/D409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma: Mobile Cc: davidedmundson,

[Differential] [Closed] D409: new mobile components

2015-11-02 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. mart marked 4 inline comments as done. Closed by commit rPLASMAMOBILEd3b28119a79f: new mobile components (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D409?vs=1110=1141#toc REPOSITORY

[Differential] [Updated, 917 lines] D409: new mobile components

2015-10-30 Thread mart (Marco Martin)
mart updated this revision to Diff 1110. REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D409?vs=1066=1110 REVISION DETAIL https://phabricator.kde.org/D409 AFFECTED FILES components/mobilecomponents/ActionGroup.qml

[Differential] [Request, 3,636 lines] D502: RFC: start in making plasma deps optional

2015-11-05 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma: Mobile. mart set the repository for this revision to rPLASMAMOBILE plasma-mobile. Herald added a subscriber: plasma-devel. REVISION SUMMARY make a wrapper for theme and units: one using plasma deps and one without, with more hardcoded

[Differential] [Accepted] D729: Add Package to activesettings module

2016-01-02 Thread mart (Marco Martin)
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. We'll have to definitely get rid of that class, but for now just to unbreak things is fine REVISION DETAIL https://phabricator.kde.org/D729 EMAIL PREFERENCES

[Differential] [Closed] D502: RFC: start in making plasma deps optional

2015-12-01 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAMOBILE962e592afdf2: RFC: start in making plasma deps optional (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D502?vs=1329=1436#toc REPOSITORY rPLASMAMOBILE

[Differential] [Updated, 9,642 lines] D502: RFC: start in making plasma deps optional

2015-11-19 Thread mart (Marco Martin)
mart updated this revision to Diff 1329. mart added a comment. weekly update of the current status of the branch REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D502?vs=1178=1329 REVISION DETAIL https://phabricator.kde.org/D502 AFFECTED

[Differential] [Accepted] D782: Require Qt 5.5

2016-01-12 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH qt-increase-version REVISION DETAIL https://phabricator.kde.org/D782 EMAIL PREFERENCES

[Differential] [Accepted] D1768: Pass screen ID to systray applets

2016-06-06 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. yeah, i'm not happy that the screen is not passed. I'm not sure i like this approach completely (if the panel gets moved to another screen the internal screen

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > mart wrote in Panel.qml:32 > there is no enabledborders property in containment? (neither i want such a > property, is not the right place) perhaps as a property of the view could work REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Closed] D1791: Give a screen to systray applets

2016-06-07 Thread mart (Marco Martin)
mart closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1791 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson Cc: davidedmundson, plasma-devel, sebas

[Differential] [Accepted] D1778: [PanelConfigView] Set enabled borders on PanelShadow

2016-06-07 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 12 lines] D1791: Give a screen to systray applets

2016-06-07 Thread mart (Marco Martin)
mart updated this revision to Diff 4277. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1791?vs=4276=4277 REVISION DETAIL https://phabricator.kde.org/D1791 AFFECTED FILES applets/systemtray/container/systemtraycontainer.cpp

[Differential] [Accepted] D1788: [Pager] Don't update models when not visible

2016-06-07 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1788 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-07 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in Panel.qml:29 > In PanelView::themeChanged > > call positionPanel() > Will acheive the same thing. > > and then we can get rid of this. ok REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Request, 13 lines] D1791: Give a screen to systray applets

2016-06-07 Thread mart (Marco Martin)
mart created this revision. mart set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY don't hardcode -a as the internal systray screen anymore. give

[Differential] [Accepted] D1770: [OSD] Allow disabling OSD through config file

2016-06-07 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. ah, ok fine then ;) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1770 EMAIL PREFERENCES

[Differential] [Commented On] D1770: [OSD] Allow disabling OSD through config file

2016-06-06 Thread mart (Marco Martin)
mart added a comment. this configuration is intended for kiosk setups? if it's hidden, there is always the risk of bitrot REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1770 EMAIL PREFERENCES

[Differential] [Commented On] D1768: Pass screen ID to systray applets

2016-06-06 Thread mart (Marco Martin)
mart added a comment. yeah, i'm not happy that the screen is not passed. I'm not sure i like this approach completely (if the panel gets moved to another screen the internal screen won't be updated?), but i didn't manage to think about a viable way to pass the screen without making the

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread mart (Marco Martin)
mart added a comment. I don't understand what the patch is supposed to be doing.. the enabled bprders of the svg can be calculated only based on the location of the panel, that has been completely removed INLINE COMMENTS > broulik wrote in Panel.qml:29 > Dunno if we still need this, ie. if

[Differential] [Requested Changes To] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread mart (Marco Martin)
mart requested changes to this revision. mart added a reviewer: mart. This revision now requires changes to proceed. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated, 14 lines] D1791: Give a screen to systray applets

2016-06-07 Thread mart (Marco Martin)
mart updated this revision to Diff 4279. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1791?vs=4277=4279 REVISION DETAIL https://phabricator.kde.org/D1791 AFFECTED FILES applets/systemtray/container/systemtraycontainer.cpp

[Differential] [Accepted] D1826: systemtray container: fix m_internalSystray nullptr crash

2016-06-12 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1826 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, mart

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

2016-06-10 Thread mart (Marco Martin)
mart added a comment. shouldn't be kde2QtFilter() fixed instead? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1813 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1793: [Device Notifier] Be more declarative

2016-06-10 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1793 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D1814: Add TaskManager requestActivities

2016-06-10 Thread mart (Marco Martin)
mart added a comment. +1 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1814 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, sebas

[Differential] [Accepted] D1752: [Panel Configuration] Disallow pressing Escape whilst manipulating panel

2016-06-03 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1752 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-13 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, davidedmundson, #plasma,

[Differential] [Commented On] D1772: Port custom collasablebutton to KWidgetAddons::KCollapsibleGroupBox

2016-06-13 Thread mart (Marco Martin)
mart added a comment. +1 REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D1772 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, sebas

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

2016-06-13 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D1816#34042, @davidedmundson wrote: > ok, but it'd have to be 5.8 given we're past dependency freeze. yeah, makes sense, let's go for 5.8 REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

2016-06-13 Thread mart (Marco Martin)
mart added a comment. even if not optimal i think we should go for it REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1735: Notify about low peripheral batteries (mouse, keyboard)

2016-06-13 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil BRANCH broulik/notifyPeripherals REVISION DETAIL https://phabricator.kde.org/D1735 EMAIL PREFERENCES

[Differential] [Accepted] D1839: [Panel] Fix warning and don't cause side-effects in binding

2016-06-13 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1839 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1848: [System Tray] Fix current item highlight

2016-06-13 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1848 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1847: [System Tray AbstractItem] Hide tooltip when clicking item

2016-06-13 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1847 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1830: [DrKonqi] Remove heartbeat icon

2016-06-13 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. makes sense REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1830 EMAIL PREFERENCES

[Differential] [Accepted] D1845: [Compact Applet] Hide tooltip when showing contextual actions

2016-06-13 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1845 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1860: make kirigamiplugin also directly linkable

2016-06-14 Thread mart (Marco Martin)
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. apart minor cosmetic issues is good to go. do you have permissions to push on git? INLINE COMMENTS > kirigamiplugin.h:69 > +QUrl componentPath(const QString ) const; > +QString

[Differential] [Commented On] D1860: make kirigamiplugin also directly linkable

2016-06-14 Thread mart (Marco Martin)
mart added a comment. ok, you can send me a patch with git format-patch, o with git am i can push it with you as author. for future ones, you gan do: https://identity.kde.org/index.php?r=developerApplication REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL

[Differential] [Accepted] D1895: Finish implementation of mode in which launchers are not kept separate.

2016-06-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1895 EMAIL PREFERENCES

[Differential] [Accepted] D1896: Expose separate-launchers toggle in config.

2016-06-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1896 EMAIL PREFERENCES

[Differential] [Accepted] D1869: [Containment Actions] Offer "Remove this panel" option only when panel is being edited

2016-06-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1869 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1867: [Calendar Applet] Show day or week number in icon

2016-06-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > calendarplugin.h:37 > + > +class CalendarPlugin : public QQmlExtensionPlugin > +{ i would prefer to have a c++ calendar applet instead of

[Differential] [Accepted] D1882: Expose inline grouping mode.

2016-06-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH blblblbl REVISION DETAIL https://phabricator.kde.org/D1882 EMAIL PREFERENCES

[Differential] [Accepted] D1881: Add an inline grouping mode.

2016-06-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1881 EMAIL PREFERENCES

[Differential] [Accepted] D1889: [shell] Properly position DesktopView on Wayland

2016-06-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH desktopview-set-position REVISION DETAIL https://phabricator.kde.org/D1889 EMAIL PREFERENCES

[Differential] [Accepted] D1849: Write out QT_SCREEN_SCALE_FACTORS instead of deprecated QT_DEVICE_PIXEL_RATIO

2016-06-13 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D1849 EMAIL PREFERENCES

[Differential] [Accepted] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

2016-05-31 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1721 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D1670: New login screen

2016-05-26 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > broulik wrote in Background.qml:36 > Rectangle still allows Gradient with GradientStop, just that the gradient can > only be top to bottom which is what we want here anyway. are we sure that one is implemented with a software renderer? REPOSITORY

[Differential] [Accepted] D1562: [OSD] Enable wrapping into two lines

2016-05-26 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1562 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1680: [server] Don't destroy resource from dtor of a Resource sub class

2016-05-26 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH no-destroy-from-dtor REVISION DETAIL https://phabricator.kde.org/D1680 EMAIL PREFERENCES

[Differential] [Commented On] D1664: Update for Breeze-gtk

2016-05-26 Thread mart (Marco Martin)
mart added a comment. doesn't seem to apply over breeze-gtk master i get: The next patch would delete the file Breeze-dark-gtk/assets/arrow-down-active.png, which does not exist! Assume -R? [n] (while there is Breeze-dark-gtk/gtk-2.0/assets/ and Breeze-dark-gtk/gtk-3.0/assets/ )

[Differential] [Accepted] D1664: Update for Breeze-gtk

2016-05-26 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rBREEZEGTK Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D1664 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dirrukd,

[Differential] [Changed Subscribers] D1724: Import Task Manager widgets ports to the new library.

2016-06-01 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > Task.qml:203 > +var smartLauncher = Qt.createQmlObject(" > +import org.kde.plasma.private.taskmanager 0.1 as TaskManagerApplet; > +TaskManagerApplet.SmartLauncherItem { }", task); maybe using an inline Component{} ? REPOSITORY

[Differential] [Commented On] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop

2016-06-01 Thread mart (Marco Martin)
mart added a comment. there was an inconsistency at some point between the applet counting from 0 and x counting from 1 iirc, and nowdays *should* be possible to remove that if (KWindowSystem::numberOfDesktops() < 2) { code? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Accepted] D1723: Rename Task Manager applets out of the way of rewrites.

2016-06-01 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. that should go in asap REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1723 EMAIL PREFERENCES

[Differential] [Accepted] D1966: Set System Tray AppletItem width properly

2016-06-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1966 EMAIL PREFERENCES

[Differential] [Accepted] D1967: Don't try to reorder an item before itself.

2016-06-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1967 EMAIL PREFERENCES

[Differential] [Accepted] D821: Drop not needed KF5::Plasma dependency

2016-01-14 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-plasma-dependency REVISION DETAIL https://phabricator.kde.org/D821 EMAIL PREFERENCES

[Differential] [Accepted] D2013: Right align the distribution logo

2016-06-28 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKINFOCENTER KInfoCenter BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2013 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, jriddell,

[Differential] [Commented On] D1986: WIP: Save PanelView settings in terms of grid units

2016-06-28 Thread mart (Marco Martin)
mart added a comment. anyways, i like the idea. uh, also no more plans of supporting QT_SCREEN_SCALE_FACTORS instead? (in this case the pixel based sizes should be just fine as they would be scaled?) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Accepted] D1901: [PolicyAgent] Ignore "Keep screen on" request while screen is locked

2016-06-28 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1901 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D2020: [Folder View internallibkonq] Use KIO::highlightInFileManager

2016-06-28 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2020 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D2009: Update Keyboard focus when the Surface of the active client changes

2016-06-28 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH update-keyboard-focus-x11-5.7 REVISION DETAIL https://phabricator.kde.org/D2009 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D1986: WIP: Save PanelView settings in terms of grid units

2016-06-28 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > panelview.cpp:1096 > > +void PanelView::writeScaledConfigEntry(const char *name, int pixelSize) > +{ why adding a new setter and getter that work in pixels? if something like that should be added, i wuld like just working with grid units.

[Differential] [Accepted] D2023: Properly trigger repaint for sofware cursor

2016-06-28 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH platform-cursor-repaint REVISION DETAIL https://phabricator.kde.org/D2023 EMAIL PREFERENCES

[Differential] [Accepted] D1800: Load a Wallpaper plugin in kscreenlocker_greet

2016-06-28 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH wallpaper-plugin REVISION DETAIL https://phabricator.kde.org/D1800 EMAIL PREFERENCES

[Differential] [Accepted] D1801: [lnf] Make LockScreen.qml an Item instead of an Image

2016-06-28 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH lnf-lockscreen-item REVISION DETAIL https://phabricator.kde.org/D1801 EMAIL PREFERENCES

[Differential] [Accepted] D819: [shell] Listen for QEvent::PlatformSurface to perform Wayland integration

2016-02-09 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH wayland-platform-surface REVISION DETAIL https://phabricator.kde.org/D819 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D902: [DesktopView] Allow Shift modifier for triggering KRunner

2016-02-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D902 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH mklapetek/selectableTextInNotifications REVISION DETAIL https://phabricator.kde.org/D899 EMAIL PREFERENCES

[Differential] [Accepted] D1009: Added indicator of whether there are windows in an activity to the switcher

2016-02-22 Thread mart (Marco Martin)
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. it will take a lot of thinking on the wayland side ;) but yes, i like it REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1009 EMAIL

[Differential] [Accepted] D1037: fix build properly by adding the lib dir to the includes

2016-02-29 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1037 EMAIL PREFERENCES

[Differential] [Accepted] D1007: [server] Add a signal SeatInterface::focusedPointerChanged

2016-02-23 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-seat-signal-pointer-changed REVISION DETAIL https://phabricator.kde.org/D1007 EMAIL PREFERENCES

[Differential] [Accepted] D742: Wayland integration: support for server-side decorations

2016-01-19 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. INLINE COMMENTS src/platformtheme/kwaylandintegration.cpp:94 since is a long name already, going all the way, waylandserverdecoration ? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma

[Differential] [Accepted] D948: Don't show applet handle outside of desktop

2016-02-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH handle-position (branched from master) REVISION DETAIL https://phabricator.kde.org/D948 EMAIL PREFERENCES

[Differential] [Accepted] D986: Revamp of the activity switcher backend

2016-02-18 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D986 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan,

[Differential] [Request, 109 lines] D987: KSplash looking consistent to sddm and lockscreen

2016-02-18 Thread mart (Marco Martin)
mart created this revision. mart set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY this makes kspash be in a rectanle that looks just like the one used now in lockscreen and sddm.

[Differential] [Updated] D987: KSplash looking consistent to sddm and lockscreen

2016-02-18 Thread mart (Marco Martin)
mart added reviewers: davidedmundson, broulik, andreaska. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, broulik, andreaska Cc:

[Differential] [Commented On] D987: KSplash looking consistent to sddm and lockscreen

2016-02-18 Thread mart (Marco Martin)
mart added a comment. http://youtu.be/68FDY4t0cIE REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, broulik, andreaska Cc: plasma-devel

[Differential] [Updated, 108 lines] D987: KSplash looking consistent to sddm and lockscreen

2016-02-18 Thread mart (Marco Martin)
mart updated this revision to Diff 2394. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D987?vs=2392=2394 REVISION DETAIL https://phabricator.kde.org/D987 AFFECTED FILES lookandfeel/contents/splash/Splash.qml EMAIL PREFERENCES

[Differential] [Accepted] D1045: Emit PaletteChanged when setting colors from look and feel package

2016-03-01 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH kcm-laf (branched from master) REVISION DETAIL https://phabricator.kde.org/D1045 EMAIL PREFERENCES

[Differential] [Accepted] D1152: [client] Perform ConnectionThread::roundtrip through QPA interface

2016-03-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH roundtrip-qpa-5.6 REVISION DETAIL https://phabricator.kde.org/D1152 EMAIL PREFERENCES

[Differential] [Accepted] D1153: [plugins/qpa] Add a roundtrip platform function

2016-03-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH qpa-roundtrip-5.6 REVISION DETAIL https://phabricator.kde.org/D1153 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1143: do not install development helper files via cmake

2016-03-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. REPOSITORY rBREEZEGTK Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D1143 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, graesslin, mart Cc: plasma-devel

[Differential] [Accepted] D1090: [krunner] Make it work on Wayland

2016-03-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1120: LayoutManager: Restore rotation on remove applet undo

2016-03-11 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH undo-rotation (branched from Plasma/5.6) REVISION DETAIL https://phabricator.kde.org/D1120 EMAIL PREFERENCES

[Differential] [Accepted] D1128: Trigger a roundtrip after creating the ServerSideDecoration

2016-03-12 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH kwayland-roundtrip-server REVISION DETAIL https://phabricator.kde.org/D1128 EMAIL PREFERENCES

[Differential] [Commented On] D1134: Alternatives: Add new applet only after the old one was removed

2016-03-12 Thread mart (Marco Martin)
mart added a comment. good that makes it look more uniform. tough at some point there was the idea of the possibility of running a script between the addition of the new one and the destruction of the old one, making possible for a script to try to convert some of the config between the

[Differential] [Accepted] D1171: simple cleanup in geometryByDistance

2016-03-19 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma, apol, mart

[Differential] [Accepted] D1161: PanelView length cleanup

2016-03-19 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH REVISION DETAIL https://phabricator.kde.org/D1161 EMAIL PREFERENCES

[Differential] [Accepted] D1271: Use a QTabWidget for the different modes in DebugConsole

2016-03-31 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. yes :D REPOSITORY rKWIN KWin BRANCH debug-console-tab-widget REVISION DETAIL https://phabricator.kde.org/D1271 EMAIL PREFERENCES

[Differential] [Accepted] D1390: systemtray: Disable tooltip when applet is expanded

2016-04-12 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH systray-currentpopup REVISION DETAIL https://phabricator.kde.org/D1390 EMAIL PREFERENCES

[Differential] [Accepted] D1391: systemtray: Align menu to item's topleft corner

2016-04-12 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH systray-menupos REVISION DETAIL https://phabricator.kde.org/D1391 EMAIL PREFERENCES

[Differential] [Accepted] D1338: Fix null values in currency conversion

2016-04-07 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D1338 EMAIL PREFERENCES

[Differential] [Commented On] D1340: Rename AbstractBackend to Platform

2016-04-07 Thread mart (Marco Martin)
mart added a comment. the new name sounds better, but.. didn't you want to keep kwayland binary compatible? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1340 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma

[Differential] [Accepted] D1162: Panel cleanup

2016-03-19 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. INLINE COMMENTS desktoppackage/contents/views/Panel.qml:120 what happens if the sequece of events happens: 1) preferredWidth changes, tries to update the length, but it can't because

[Differential] [Request, 67 lines] D1170: Api to rename activities in desktop scripting

2016-03-19 Thread mart (Marco Martin)
mart created this revision. mart set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY the api containment.name was incorrect and broken, (using it it actually breaks the whole layout

  1   2   3   4   5   6   7   8   9   10   >