[Differential] [Commented On] D3188: Modified distance function to keep aspect ratio as close as possible

mart added a comment. almost perfect :) last thing, can the test be moved in a subfolder called autotests? (just a convention) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES

[Differential] [Accepted] D3225: Don't snap to auto-hidden panels

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH dont-snap-to-auto-hidden-panel-5.8 REVISION DETAIL https://phabricator.kde.org/D3225 EMAIL PREFERENCES

[Differential] [Accepted] D3188: Modified distance function to keep aspect ratio as close as possible

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH arcpatch-D3188 REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D3131: Show full scrollbar only on mouse over

mart retitled this revision from "[WIP]: show full scrollbar only on mouse over" to "Show full scrollbar only on mouse over". REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 171 lines] D3131: [WIP]: show full scrollbar only on mouse over

mart updated this revision to Diff 7701. mart added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. - use the internal breeze animation machinery - use the same graphics for the handle not under mouse - scrollbar on mouse

[Differential] [Commented On] D3131: [WIP]: show full scrollbar only on mouse over

mart added a comment. In https://phabricator.kde.org/D3131#58136, @hpereiradacosta wrote: > Hello, > the idea is nice. For the implementation however, rather than changing the opacity of the painter, I think it would be more efficiency with changing the opacity of the colors that are

[Differential] [Accepted] D3184: Bring potd wallpaper back to life.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3184 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng,

[Differential] [Updated] D3183: Port potd (picture of the day) dataengine to KF5.

mart added a comment. code looks good. I tested the urls, annotated inline those that work and those that don't. Unfortunately there are still two that don't, in flickr, where a no longer valid api key is used and the wikipedia one. INLINE COMMENTS > apodprovider.cpp:83 > { > -KUrl

[Differential] [Accepted] D3151: Trigger resize of input window when deco size changes

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH input-window-maximize-5.8 REVISION DETAIL https://phabricator.kde.org/D3151 EMAIL PREFERENCES

[Differential] [Commented On] D3166: make sure containment actions config is up to date

mart added a comment. In https://phabricator.kde.org/D3166#59071, @davidedmundson wrote: > It's still a bodge round broken user code. it is, but the thing is, that's the way is supported by the api right now, and there are users for it, so it has to work, regardless if it's quite

[Differential] [Updated, 168 lines] D3131: Show full scrollbar only on mouse over

mart updated this revision to Diff 7725. mart added a comment. - try harder to figure out the widget is under mouse when drawing the arrow we can't know if the widget is under mouse by the style option, and we can't access the widget when using the qstyle over QML, so check either the

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

mart added a comment. In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote: > Hi Marco, > > Couple of comments on the look of it > > 1/ if you set the animation time to somehting long (500ms), then hover on a scrollbar, in the groove, and not on the handle, while

[Differential] [Closed] D3131: Show full scrollbar only on mouse over

This revision was automatically updated to reflect the committed changes. mart marked 4 inline comments as done. Closed by commit rBREEZEe33206e4f74f: Show full scrollbar only on mouse over (authored by mart). REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3191: guard against dataengine missing

mart added a comment. In https://phabricator.kde.org/D3191#59338, @davidedmundson wrote: > So why is PluginLoader::loadDataEngine returning something? from https://bugs.kde.org/show_bug.cgi?id=371779 it looks like it's not? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION

[Differential] [Updated, 136 lines] D3210: make scrollbar size configurable

mart updated this revision to Diff 7783. mart added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. - Merge branch 'master' into arcpatch-D3210 REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE

[Differential] [Updated, 46 lines] D3191: guard against dataengine missing

mart updated this revision to Diff 7790. mart added a comment. - remove unneeded isValid() calls REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3191?vs=7733=7790 BRANCH arcpatch-D3191_1 REVISION DETAIL

[Differential] [Updated, 162 lines] D3131: Show full scrollbar only on mouse over

mart updated this revision to Diff 7736. mart added a comment. - adress comments REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3131?vs=7725=7736 BRANCH arcpatch-D3131 REVISION DETAIL https://phabricator.kde.org/D3131 AFFECTED FILES

[Differential] [Commented On] D3210: make scrollbar size configurable

mart added a comment. In https://phabricator.kde.org/D3210#60230, @hpereiradacosta wrote: > So, just to make sure I understand: > > - 1 option to "only show full scrollbar on mouse over" (as we have now) > - 1 option to "use slim scrollbar" (with reduced width handle) Is that what

[Differential] [Updated, 92 lines] D3210: make scrollbar size configurable

mart updated this revision to Diff 7870. mart added a comment. - make the scrollbar size config a simple checkbox REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3210?vs=7783=7870 BRANCH arcpatch-D3210 REVISION DETAIL

[Differential] [Accepted] D3256: Close popups on escape

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH arcpatch-D3200 REVISION DETAIL https://phabricator.kde.org/D3256 EMAIL PREFERENCES

[Differential] [Accepted] D3250: Use Plasma tooling for installing plasmoids

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3250 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart

[Differential] [Accepted] D3257: Close the system tray on escape - system tray

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3257 EMAIL PREFERENCES

[Differential] [Commented On] D3204: [KSMServer] Turn user switcher into a separate binary

mart added a comment. +1 from me, other opinions? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3204 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: mart, plasma-devel, lesliezhai,

[Differential] [Accepted] D3249: Use our tooling for installing plasmoids

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3249 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma,

[Differential] [Commented On] D3256: Close popups on escape

mart added a comment. In https://phabricator.kde.org/D3256#60552, @mart wrote: > speaking of which, i'm noticing the systray has its own popup and no esc, so adding the same thing there right now ah, seen now your other rr for the tray, nevermind :) REPOSITORY rPLASMADESKTOP

[Differential] [Accepted] D3253: [desktopgrid] Don't manipulate virtual desktop of desktop window

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. having desktop windows not on all desktops i guess historically is for the old feature of different wallpapers for each desktop REPOSITORY rKWIN KWin BRANCH

[Differential] [Accepted] D3259: Don't handle closing the popup ourselves

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3259 EMAIL PREFERENCES

[Differential] [Accepted] D3228: [helpers/killer] Force to platform XCB

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH killer-force-xcb-5.8 REVISION DETAIL https://phabricator.kde.org/D3228 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3243: [kioslave/remote] Port away from kdelibs4support

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH port-remote REVISION DETAIL https://phabricator.kde.org/D3243 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D3257: Close the system tray on escape - system tray

mart added inline comments. INLINE COMMENTS > PlasmoidPopupsContainer.qml:30 > focus: true > -Keys.forwardTo: [currentItem] > wouldn't this break keyboard navigation in an item if supported? (like going up and down in the device list in the device notifier) REPOSITORY

[Differential] [Accepted] D3231: [Lock Screen] Show "Switch User" button only if allowed

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3231 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3256: Close popups on escape

mart added a comment. speaking of which, i'm noticing the systray has its own popup and no esc, so adding the same thing there right now REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH arcpatch-D3200 REVISION DETAIL https://phabricator.kde.org/D3256 EMAIL PREFERENCES

[Differential] [Commented On] D3210: make scrollbar size configurable

mart added a comment. In https://phabricator.kde.org/D3210#60493, @colomar wrote: > If I understood it correctly (that there is only a checkbox "Only show full scrollbar on mouse over" added to the config) then that is exactly what I had in mind. in this latest version there are

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

mart added a comment. any news on this? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Abandoned] D3166: make sure containment actions config is up to date

mart abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3166 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: davidedmundson, plasma-devel, lesliezhai,

[Differential] [Request, 6 lines] D3263: fix behavior of scrollable systray popups

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it's very rare that the icon list in the hidden area of the systray is long enough to get a scrollbar, but

[Differential] [Closed] D3263: fix behavior of scrollable systray popups

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEae658c33c8a6: fix behavior of scrollable systray popups (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3263?vs=7903=7904#toc REPOSITORY rPLASMAWORKSPACE

[Differential] [Accepted] D3209: [Notification Applet] Position dialog before showing it

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. tested locally on x11, it seems to still work correctly INLINE COMMENTS > notificationshelper.cpp:150 > > -QTimer::singleShot(300, popup, ::show); > +

[Differential] [Accepted] D3220: Introduce new pre-layout script hook

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. Let's go with this, maybe use two different wariables for the script paths, but let's go with it. even if is a new thing, it should go on 5.8 as well tough.

[Differential] [Request, 21 lines] D3166: make sure containment actions config is up to date

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY if the containment actions plugins have been configured in the startup script, their config must be reloaded

[Differential] [Request, 46 lines] D3191: guard against dataengine missing

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this should never happen, but weird distribution packaging policies can make this happen. At least don't crash

[Differential] [Changed Subscribers] D3188: Modified distance function to keep aspect ratio as close as possible

mart added inline comments. INLINE COMMENTS > image.cpp:186 > > -//qDebug() << "wanted" << m_targetSize << "options" << images; > - > -// choose the nearest resolution, always preferring images with the same > aspect ratio > +//float targetAspectRatio = (m_targetSize.height() > 0

[Differential] [Requested Changes To] D3188: Modified distance function to keep aspect ratio as close as possible

mart requested changes to this revision. mart added a reviewer: mart. This revision now requires changes to proceed. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES

[Differential] [Accepted] D3168: Use microphone volume icon for capture devices/streams in applet

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D3168 EMAIL PREFERENCES

[Differential] [Accepted] D3120: [kwineffects] Add hide/show cursor to EffectsHandler

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH effects-show-hide-cursor REVISION DETAIL https://phabricator.kde.org/D3120 EMAIL PREFERENCES

[Differential] [Updated, 162 lines] D3131: Show full scrollbar only on mouse over

mart updated this revision to Diff 7720. mart added a comment. - don't draw the handle separatedly REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3131?vs=7701=7720 BRANCH arcpatch-D3131 REVISION DETAIL https://phabricator.kde.org/D3131 AFFECTED

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

mart added a comment. In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote: > Hi Marco, > > Couple of comments on the look of it > > 1/ if you set the animation time to somehting long (500ms), then hover on a scrollbar, in the groove, and not on the handle, while

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

mart added a comment. In https://phabricator.kde.org/D3131#59205, @mart wrote: > In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote: > > > 3/ I agree that the animation looks good on views like dolphin and systemsettings. However for views with a header, or when you

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

mart added a comment. In https://phabricator.kde.org/D3131#59229, @hpereiradacosta wrote: > > also should be minimized since iirc their intention is also to make the scrollbar a bit slimmer by default (painted around as wide as progressbars, maybe still with wider blank working mouse

[Differential] [Request, 197 lines] D3024: Remove WaylandDialogFilter

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY now that KWayland is a framework, it's used directly from Dialog, no need to inject kwayland usage from here

[Differential] [Closed] D3021: restore all panel properties

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEaea33cddb547: restore all panel properties (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3021?vs=7305=7309

[Differential] [Closed] D3024: Remove WaylandDialogFilter

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE092c2c7cf734: Remove WaylandDialogFilter (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3024?vs=7311=7312

[Differential] [Request, 27 lines] D3021: restore all panel properties

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY restore the missing panel properties: alignment minimum length maximum length offset also, allow non

[Differential] [Closed] D3017: enable all preview plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEc05f2fc2171e: enable all preview plugins (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3017?vs=7296=7302

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

mart added a comment. i am in favor of this chane, but i think the real reson of the breakage should be investigated as well, uf there may be problems in kconfigwidget itself REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3048 EMAIL PREFERENCES

[Differential] [Updated] D3048: [Colors KCM] Default scheme is now installed as a file

mart added a comment. hmm, also wouldn't be loaded if a kde app is loaded from another desktopwithout config prior existing i guess INLINE COMMENTS > colorscm.cpp:118 > const QString name = group.readEntry("Name", info.baseName()); > -QListWidgetItem * newItem = new

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

mart added a comment. In https://phabricator.kde.org/D3048#56489, @ochurlaud wrote: > In https://phabricator.kde.org/D3048#56488, @mart wrote: > > > i am in favor of this chane, but i think the real reson of the breakage should be investigated as well, uf there may be problems in

[Differential] [Accepted] D2986: Systray: Move all icon resolution to dataengine

mart accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2986 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: roberts, #plasma, davidedmundson, mart Cc: davidedmundson,

[Differential] [Accepted] D3000: If we manually invoke ::restore remove the pending timer to call restore

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3000 EMAIL PREFERENCES

[Differential] [Accepted] D2991: Fix moving windows to a different activity.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2991 EMAIL PREFERENCES

[Differential] [Updated, 7 lines] D3006: fix screenForContainment when screen ids > count

mart updated this revision to Diff 7265. mart added a comment. - bring back old logic REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3006?vs=7263=7265 BRANCH phab/screenforcont REVISION DETAIL https://phabricator.kde.org/D3006

[Differential] [Closed] D3006: fix screenForContainment when screen ids > count

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEca1bf0e3e4c0: fix screenForContainment when screen ids > count (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3006: fix screenForContainment when screen ids > count

mart added a comment. this version has the old logic again, it iterates trough all the screens but doesn't check for ids being < of the count, it just checks that thre is a qscreen for that screen id by using the association in screenpool REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Request, 3 lines] D3017: enable all preview plugins

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY try to preview everything that's found in the list. by default not all image types are enabled, like svg,

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

mart added a comment. In https://phabricator.kde.org/D3530#65867, @dfaure wrote: > But desktop:/ and applications:/ make no sense in other workspaces (I'm surprised we even still have applications:/, it's kind of a toy, isn't it?). > > (ok applications:/ might make sense in gnome,

[Differential] [Accepted] D3425: If we get a notification with no body, treat the subject line as the body

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3425 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3508: Implement borderlessMaximizedWindows for Wayland windows

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH shell-client-borderless-maximized-windows REVISION DETAIL https://phabricator.kde.org/D3508 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

mart added inline comments. INLINE COMMENTS > groupingplasmoid.kdev4:1 > +[Buildset] > +BuildItems=@Variant(\x00\x00\x00\t\x00\x00\x00\x00\x01\x00\x00\x00\x0b\x00\x00\x00\x00\x01\x00\x00\x00 > > \x00g\x00r\x00o\x00u\x00p\x00i\x00n\x00g\x00p\x00l\x00a\x00s\x00m\x00o\x00i\x00d) this foder

[Differential] [Accepted] D3585: Fix building library with qmake

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3585 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Requested Changes To] D3630: [Digital Clock] Bug fixes and ui code optimization

mart requested changes to this revision. mart added a reviewer: mart. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DigitalClock.qml:57 > // if the date/timezone cannot be fit with the smallest font to its > designated space > -readonly

[Differential] [Accepted] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3620 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Changed Subscribers] D3606: Listen for broadcast notifications on system bus

mart added a subscriber: davidedmundson. mart added a comment. In https://phabricator.kde.org/D3606#67751, @davidedmundson wrote: > Note that actions won't work, we'd always be replying on the session bus. (this is solvable) is that even possible to add an action at all from

[Differential] [Commented On] D3598: rework kscreen's OSD logic

mart added a comment. In https://phabricator.kde.org/D3598#67455, @sebas wrote: > protocol), we'll move this code into its own daemon and kwin will authorize that daemon. THat's basically the same approach we'll have to take with powerdevil. so in the end the authorized process

[Differential] [Commented On] D3606: Listen for broadcast notifications on system bus

mart added a comment. In https://phabricator.kde.org/D3606#67898, @broulik wrote: > What would be the best place to put a little utility (similar to notify-send or kdialog --passivepopup) for this? kde-cli-tools REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Differential] [Accepted] D3615: [Kicker] Hide "Edit Applications..." context menu entry if system immutable

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3615 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Accepted] D3658: Set Automatic login flag to adjust SDDM config directly

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3658 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3679: Introduce undefined fields

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH master REVISION DETAIL https://phabricator.kde.org/D3679 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc:

[Differential] [Accepted] D2687: [Icon Widget] Bring back properties dialog

mart accepted this revision. mart added a reviewer: mart. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure, mart Cc: mart, plasma-devel,

[Differential] [Commented On] D3638: Implement drag from free space also for QtQuickControls

mart added a comment. +1 any news on that? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D3638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, hpereiradacosta Cc: mart, plasma-devel, lesliezhai,

[Differential] [Accepted] D3688: [Runners] Register actions right away

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3688 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D3658: Set Automatic login flag to adjust SDDM config directly

mart added a comment. did the helper already supported the action or is a different rr? REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D3658 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart,

[Differential] [Commented On] D3660: Plasma 5.9 "Canopee" Wallpaper

mart added a comment. like it a lot! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3660 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kvermette, #plasma Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D2687: [Icon Widget] Bring back properties dialog

mart added a comment. for me +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure Cc: mart, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

mart added inline comments. INLINE COMMENTS > appentry.h:79 > AppGroupEntry(AppsModel *parentModel, KServiceGroup::Ptr group, > -bool flat, bool sorted, bool separators, int appNameFormat); > +bool paginate, int pageSize, bool flat, bool sorted, bool >

[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

mart added a comment. yes, if you are comparing with an item height, it should stay in pixelSize REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma,

[Differential] [Accepted] D3581: [PlasmaShell] Introduce activateTaskManagerEntry(index) method

mart accepted this revision. mart added a reviewer: mart. mart added a comment. not pretty for sure, but unfortunately i don't see much ways to avoid this, so go for it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3581 EMAIL PREFERENCES

[Differential] [Accepted] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > TextField.qml:49 > +// this takes into account kiosk restriction > +readonly property bool __effectiveRevealPasswordButtonShown: >

[Differential] [Accepted] D3651: Add utility to send broadcast notifications

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D3651 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D3655: Kicker backend changes for Simple Menu.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3655 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc:

[Differential] [Accepted] D3666: Test the variable type without warning

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3666 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

[Differential] [Commented On] D3606: RFC: Listen for broadcast notifications on system bus

mart added a comment. since is rfc this is my comment: I like the idea a lot REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3606 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: mart, plasma-devel,

[Differential] [Updated, 175 lines] D3603: Option to show percentage charge in the icon

mart updated this revision to Diff 8840. mart added a comment. - add missing file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8802=8840 BRANCH phab/batterypercent REVISION DETAIL https://phabricator.kde.org/D3603 AFFECTED FILES

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

mart added a comment. F672027: Spectacle.T21326.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3603 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: broulik,

[Differential] [Updated, 177 lines] D3603: Option to show percentage charge in the icon

mart updated this revision to Diff 8843. mart added a comment. - use anchors REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8840=8843 BRANCH phab/batterypercent REVISION DETAIL https://phabricator.kde.org/D3603 AFFECTED FILES

[Differential] [Closed] D3603: Option to show percentage charge in the icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:27ac0b760855: Option to show percentage charge in the icon (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8843=8844 REVISION

[Differential] [Accepted] D3681: Fix KAuthActionReply usage

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D3681 EMAIL PREFERENCES

[Differential] [Accepted] D3684: WIP: Media Controls on lock screen

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3684 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D3685: Add SDDM theme install/uninstall with GHNS to the SDDM KCM

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH ghns REVISION DETAIL https://phabricator.kde.org/D3685 EMAIL PREFERENCES

[Differential] [Closed] D3553: Fix 2 RTL bugs

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4fada5bdb032: Fix 2 RTL bugs (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3553?vs=8647=9037 REVISION DETAIL

[Differential] [Accepted] D3680: Don't list separately plasmoids from metadata.desktop and .json

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > packageloader.cpp:251 > + > +if (dirs.contains(dir)) > +continue; use { } BRANCH master REVISION DETAIL

<    4   5   6   7   8   9   10   11   >