[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

xuetianweng added inline comments. INLINE COMMENTS > graesslin wrote in main_wayland.cpp:449 > > Don't do this. Otherwise qtvirtualkeyboard will be the only usable input > > method for Qt. > > That's totally fine in this case. It only affects KWin and KWin doesn't have > any text input

[Differential] [Changed Subscribers] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

xuetianweng added inline comments. INLINE COMMENTS > main_wayland.cpp:449 > qunsetenv("QT_DEVICE_PIXEL_RATIO"); > -qunsetenv("QT_IM_MODULE"); > +qputenv("QT_IM_MODULE", "qtvirtualkeyboard"); > qputenv("QSG_RENDER_LOOP", "basic"); Don't do this. Otherwise qtvirtualkeyboard will

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

xuetianweng added inline comments. INLINE COMMENTS > graesslin wrote in main_wayland.cpp:449 > I don't understand the concern. The QT_IM_MODULE env variable set here in the > code only affects KWin. It is not passed to any other process. > > Setting QT_IM_MODULE env variables will still

[Differential] [Updated] D2000: Make it possible to adjust volume even if it's muted

xuetianweng marked an inline comment as done. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2000 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: jensreuterberg, plasma-devel, sebas

[Differential] [Updated, 8 lines] D2000: Make it possible to adjust volume even if it's muted

xuetianweng updated this revision to Diff 4779. xuetianweng added a comment. change it against master REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2000?vs=4749=4779 BRANCH master REVISION DETAIL

[Differential] [Accepted] D1998: Make sure to unmute when changing volume with hotkeys

xuetianweng accepted this revision. xuetianweng added a comment. This revision is now accepted and ready to land. LGTM tested on my desktop. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1998 EMAIL PREFERENCES

[Differential] [Updated, 7 lines] D2000: Make it possible to adjust volume even if it's muted

xuetianweng updated this revision to Diff 4714. xuetianweng added a comment. also do the same thing to kcm's slider REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2000?vs=4713=4714 BRANCH Plasma/5.7 REVISION DETAIL

[Differential] [Commented On] D2000: Make it possible to adjust volume even if it's muted

xuetianweng added inline comments. INLINE COMMENTS > drosca wrote in VolumeSlider.qml:44 > It should also change opacity when muted here. I'd rather not, because this is widget style, and disable style is actually "grey out". REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL

[Differential] [Commented On] D2000: Make it possible to adjust volume even if it's muted

xuetianweng added a comment. In https://phabricator.kde.org/D2000#36954, @drosca wrote: > The same is in applet, disabled slider is greyed out. And Jens has a point here, it would be better if we come up with a different way to visualize muted stream without changing opacity of sliders

[Differential] [Updated, 8 lines] D2000: Make it possible to adjust volume even if it's muted

xuetianweng updated this revision to Diff 4749. xuetianweng added a comment. also apply opacity to kcm's slider REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2000?vs=4714=4749 BRANCH Plasma/5.7 REVISION DETAIL

[Differential] [Request, 4 lines] D2000: Make it possible to adjust volume even if it's muted

xuetianweng created this revision. xuetianweng added a reviewer: drosca. xuetianweng added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Do not disable the slider if it's muted. It would be more convinient if it's possible to change muted item

[Differential] [Accepted] D1094: [KRunner] Don't override user input in history

xuetianweng accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1094 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma,

[Differential] [Request, 7 lines] D1075: Display mouse image in mouse kcm properly on highdpi screen

xuetianweng created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1075 AFFECTED FILES kcms/input/mouse.cpp EMAIL PREFERENCES

[Differential] [Updated] D1075: Display mouse image in mouse kcm properly on highdpi screen

xuetianweng added reviewers: broulik, apol. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1075 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, broulik, apol Cc: plasma-devel

[Differential] [Closed] D2000: Make it possible to adjust volume even if it's muted

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA3f4e449de8bf: Make it possible to adjust volume even if it's muted (authored by xuetianweng). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3184: Bring potd wallpaper back to life.

xuetianweng added a reviewer: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3184 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated] D3183: Port potd (picture of the day) dataengine to KF5.

xuetianweng added a dependent revision: D3184: Bring potd wallpaper back to life.. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, #plasma

[Differential] [Updated] D3184: Bring potd wallpaper back to life.

xuetianweng added a dependency: D3183: Port potd (picture of the day) dataengine to KF5.. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3184 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart Cc:

[Differential] [Request, 345 lines] D3184: Bring potd wallpaper back to life.

xuetianweng created this revision. xuetianweng added a reviewer: mart. xuetianweng added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Port the potd wallpaper plugin to KF5/QML. TEST PLAN Test manually with plasmashell REPOSITORY

[Differential] [Request, 564 lines] D3183: Port potd (picture of the day) dataengine to KF5.

xuetianweng created this revision. xuetianweng added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Osei site was discontinued, replace it with its successor which is also from NOAA. Also fix flickr,

[Differential] [Updated] D3183: Port potd (picture of the day) dataengine to KF5.

xuetianweng added a reviewer: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated, 346 lines] D3184: Bring potd wallpaper back to life.

xuetianweng updated this revision to Diff 7712. xuetianweng added a comment. add missing change in CMakeLists.txt REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3184?vs=7711=7712 BRANCH master REVISION DETAIL

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

xuetianweng added inline comments. INLINE COMMENTS > mart wrote in wcpotdprovider.cpp:54 > other copy of invalid url emm.. I thought I fixed. nvm. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES

[Differential] [Updated, 571 lines] D3183: Port potd (picture of the day) dataengine to KF5.

xuetianweng updated this revision to Diff 8083. xuetianweng marked 8 inline comments as done. xuetianweng added a comment. Update flickr api key and wiki potd url REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3183?vs=7710=8083 BRANCH

[Differential] [Closed] D3372: Remove Webkit usage in potd data engine.

xuetianweng closed this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma, plasma-devel, lesliezhai,

[Differential] [Updated] D3372: Remove Webkit usage in potd data engine.

xuetianweng updated the summary for this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma,

[Differential] [Updated] D3372: Remove Webkit usage in potd data engine.

xuetianweng updated the summary for this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma,

[Differential] [Closed] D3183: Port potd (picture of the day) dataengine to KF5.

xuetianweng closed this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Closed] D3184: Bring potd wallpaper back to life.

This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS8f1310dd1e9a: Bring potd wallpaper back to life. (authored by xuetianweng). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3184?vs=7712=8180#toc REPOSITORY rKDEPLASMAADDONS

[Differential] [Changed Subscribers] D3372: Remove Webkit usage in potd data engine.

xuetianweng added a subscriber: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma, plasma-devel, lesliezhai,

[Differential] [Request, 114 lines] D3372: Remove Webkit usage in potd data engine.

xuetianweng created this revision. xuetianweng added reviewers: mart, hein, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For natgeoprovider, since the page it can be accepted by QXmlStreamReader to get

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng added a comment. In https://phabricator.kde.org/D3829#71988, @graesslin wrote: > In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote: > > > In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > > > > > Could you explain the relationship to global

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng added a comment. In https://phabricator.kde.org/D3829#72924, @graesslin wrote: > I would say the overall problem is that this here still uses an XLib event queue. But Qt uses an xcb connection. I would say this needs a porting away from the XLib code and use Qt's XCB

[Differential] [Request, 31 lines] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng created this revision. xuetianweng added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For some reason, the XI event is not received if the change is from global shortcut. This

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng added a comment. In https://phabricator.kde.org/D3829#71724, @knambiar wrote: > Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588 Yeah, I suspect so. I already put it in CCBUG, but I'd prefer reporter to confirm it. REPOSITORY R119

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng added a comment. In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel I don't really sure about this. So basically XlibNotifications