Re: C++/library requirements for Plasma 5.26

On Thursday, 7 July 2022 14:55:03 CEST Ivan Čukić wrote: > Not because of QCoro itself, but that clang doesn't yet officially > support coroutines. According to [1] they have a partial support > since version 8, and according to [2] they might lead to problems > when coroutines might be resumed on

Re: Using C++20 in Plasma

> On Fri, 6 Aug 2021 at 12:06, Nicolas Fella wrote: > > I would like to explore whether it would be feasible from a distribution > > POV to use C++20 in Plasma (and other non-Frameworks projects). >From the FreeBSD side of things, the "oldest" version of the distribution still supported is 11.4

Re: plasma-systemmonitor in kdereview

On 2020 tobula d. 19id 00:28:38 CEST Albert Astals Cid wrote: > El dijous, 1 d’octubre de 2020, a les 11:36:12 CEST, Arjen Hiemstra va escriure: > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It > > can be found at https://invent.kde.org/plasma/plasma-systemmonitor . >

D29847: Fixes compile problem for freebsd because of missing crypt.h

adridg added a comment. This review should be closed: a change landed via invent that makes it unnecessary (`` is no longer used in the users kcm). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd

D29847: Fixes compile problem for freebsd because of missing crypt.h

adridg added a comment. https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes There's already a CMake-time check for ``, it's just not used. (`HAVE_CRYPT_H`) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 To: usta, #plasma,

D24810: Ensure defintion of XDG_DATA_DIRS

adridg added a subscriber: davidedmundson. adridg added a comment. Calling @davidedmundson .. I would migrate this to invent, except in 3c1a34a26dbdf7c123782746881d914cd47b27b6 the similar adjustment for

D20562: Use (better) path to libICE when doing check_library_exists.

adridg closed this revision. adridg added a comment. Pushed via invent in 0c4ad7f1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20562 To: adridg, davidedmundson Cc:

Re: Information regarding upcoming Gitlab Migration

On 2020 prilula d. 28id 13:35:22 CEST Ben Cooksley wrote: > Would some form of git alias/custom command script that works similar > to the following be suitable? > > git kde-clone skrooge > > That script would then search the appropriate groups (ignoring any > personal repositories including

Re: Information regarding upcoming Gitlab Migration

There are a whole bunch of considerations and use-cases being discussed at once in this thread, and Leinir's post made me think a bit about different actors can interact with "the collection of repositories". One actor is "tooling", as Albert has pointed out. Whatever the resulting structure

Re: Information regarding upcoming Gitlab Migration

On 2020 mayula d. 1id 07:08:41 CEST Ben Cooksley wrote: > On Fri, May 1, 2020 at 2:46 AM Nate Graham wrote: > > If I'm understanding things, we have solutions to most or all of the > > objections raised so far: > > > > - Projects will be allowed to live in--or at least appear in--multiple > >

D27980: make opengl module support multiple dri devices

adridg added inline comments. INLINE COMMENTS > apol wrote in opengl.cpp:335 > Probably want to list them all on BSD too, right @adridg? Possibly. I don't have any machines with multiple cards, so I can't tell -- I'd have to ask Niclas about this. I don't know if it's possible for the

D24810: Ensure defintion of XDG_DATA_DIRS

adridg added inline comments. INLINE COMMENTS > dfaure wrote in startplasma.cpp:197 > Wait, where does /usr/local/etc/xdg come from? > https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html > says the default is only /etc/xdg. On FreeBSD (other BSD's, too), `/etc` is for

D24750: Fix reading environment variables with newline

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. Looked for -0 alternatives, couldn't find any. Dave tells me there's sufficient fallbacks, and otherwise we'll just patch it out in packaging. REPOSITORY R120 Plasma Workspace BRANCH

D20562: Use (better) path to libICE when doing check_library_exists.

adridg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. adridg requested review of this revision. REVISION SUMMARY Using just "ICE" means that -lICE gets passed to the linker for this test, and *that* might not be in the default linker path.

D17785: Update logic for disabling the PCI module.

This revision was automatically updated to reflect the committed changes. Closed by commit R102:39ede9c7e64b: Update logic for disabling the PCI module. (authored by adridg). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17785?vs=48155=48190 REVISION

D17785: Update logic for disabling the PCI module.

adridg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. adridg requested review of this revision. REVISION SUMMARY FreeBSD on ThunderX2 does support PCI, and apparently the KCM even works. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234256

D13752: Kill solidautoeject

adridg added a comment. - Start systemsettings; under *workspace*, *startup and shutdown*, find *background services*. - Untick the box for *Drive Ejector*; also check status is *not running*, click *stop* button if it is still running. - Insert CD, pick *open in file manager* from the

D13752: Kill solidautoeject

adridg added a comment. It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change; what I've written above is current behavior on FreeBSD 11 with Plasma 5.12.5; HAL is running. REPOSITORY R120 Plasma Workspace REVISION

D13752: Kill solidautoeject

adridg added a comment. Since the ticket is rather unclear on what functionality is being tested, or how: - Put a CD with an ISO9660 filesystem in the drive (I used one with Debian from 1995 on it) - When device notifier pops up, pick "open with filemanager" (`*`) - Ensure the

D11235: [DrKonqi] Request change of ptrace scope from KCrash

adridg added a comment. Comments directed at licensing and non-Linux cases. INLINE COMMENTS > queryptrace.cpp:1 > +#include > + Missing file header / license bits > queryptrace.cpp:49 > + > +#endif For non-Linuxen, include a null implementation here. > queryptrace.h:1 > +#ifndef

D9713: Add script to unlock a broken session via ConsoleKit.

adridg added inline comments. INLINE COMMENTS > abstractlocker.cpp:69 > +text = text_ck; > +} else if (haveService("org.freedesktop.login1.Session")) { > +text = text_ld; Drop ".Session", since the service is registered (Manjaro, KDE Neon) as

D7681: Update human-readable tier designation in API dox

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8a233471fc54: Update human-readable tier designation in API dox (authored by adridg). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7681?vs=19146=25479 REVISION

D9149: Allow running the tool without a display

adridg abandoned this revision. adridg added a comment. Careful use of -platform minimal allows running the tool with no changes to the code or kcm. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9149 To: adridg, #plasma, mart Cc: apol, plasma-devel,

D9149: Allow running the tool without a display

adridg added a reviewer: mart. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9149 To: adridg, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9149: Allow running the tool without a display

adridg created this revision. adridg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Switch to QCoreApplication - Check for availability of a primary screen before querying pixmap depth; if

D8695: Fix ampersand characters not showing in tab titles

adridg added inline comments. INLINE COMMENTS > Workspace.cpp:142 > +// Title ampersands must be doubled or will not be displayed and used as > QT shortcut > +insertTab(-1, sheet, dlg.sheetTitle().replace( "&", "&&" ) ); > mSheetList.append( sheet ); Are you sure this won't affect

D8694: Add .arcconfig

adridg created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D8694 AFFECTED FILES .arcconfig To: adridg Cc: plasma-devel,

D8694: Add .arcconfig

This revision was automatically updated to reflect the committed changes. Closed by commit R106:1f8fec738573: Add .arcconfig (authored by adridg). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8694?vs=22030=22031 REVISION DETAIL

D7681: Update human-readable tier designation in API dox

adridg created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY text is wrong TEST PLAN re-generate APIdox and read text REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL

D6000: Handle differences in PAM headers

This revision was automatically updated to reflect the committed changes. Closed by commit R107:38ff660bb81c: Handle differences in PAM headers (authored by adridg). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6000?vs=14912=15009 REVISION

D6000: Handle differences in PAM headers

adridg added a comment. See, e.g., https://build-sandbox.kde.org/view/Plasma/job/Plasma kwallet-pam kf5-qt5 FreeBSDQt5.7/1/console That's the compile failure (pam_kwallet.c:39:10: fatal error: 'security/pam_ext.h' file not found) without these changes. REPOSITORY R107 KWallet PAM

D6000: Handle differences in PAM headers

adridg created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY FreeBSD has neither pam_ext.h nor pam_syslog(), so check for headers and add defines as appropriate. TEST PLAN Builds on FreeBSD, now.

D5825: Include signal.h for kill(), and prototype kqueue/kevent stuff...

adridg added inline comments. INLINE COMMENTS > kcheckpass.c:77 > +#endif > > #define THROTTLE 3 Possibly add #if !(HAVE_SIGNALFD_H_ || HAVE_EVENT_H) #error #endif to double-check that it's one or the other (reflecting the check in CMake) > kcheckpass.c:384 > +EV_SET([1], SIGUSR2,

D5825: Include signal.h for kill(), and prototype kqueue/kevent stuff...

adridg added a comment. The recent change that uses signalfd() is a linuxism. Possibly a glibism as well. This patch introduces an alternate path for systems without signalfd(), using kevent() to do the Same Thing (tm) .. but as tcberner says, it's not been tested. Consider it a prototype.

D5778: [backlighthelper] Remove unreachable code from backlighthelper

adridg added a comment. It's a little more complicated than this: - FreeBSD has a port, libudev-devd, which provides the udev API on FreeBSD - I don't know how extensive the API is that that library provides, and whether the entire udev backend would work with it - In packaging, we

D5717: Fix autotests on the FreeBSD CI.

This revision was automatically updated to reflect the committed changes. Closed by commit R127:a5d279198fee: Fix autotests on the FreeBSD CI. (authored by adridg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5717?vs=14155=14160 REVISION DETAIL

D5717: Fix autotests on the FreeBSD CI.

adridg added a reviewer: graesslin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5717 To: adridg, bcooksley, graesslin Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas

D5717: Fix autotests on the FreeBSD CI.

adridg created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY Include explicitly, for EPROTO. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL