D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

2020-06-05 Thread Ahmad Samir
ahmadsamir closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29710

To: ahmadsamir, #plasma, bport, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-18 Thread Ahmad Samir
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e3b251fd5b06: [IconApplet] Port KRun to 
ApplicationLauncherJob (authored by ahmadsamir).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29687?vs=83017=83038

REVISION DETAIL
  https://phabricator.kde.org/D29687

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: ahmadsamir, #plasma, broulik, dfaure
Cc: dfaure, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-17 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 83017.
ahmadsamir added a comment.


  Remove one include

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29687?vs=82943=83017

BRANCH
  l-krun-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29687

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: ahmadsamir, #plasma, broulik, dfaure
Cc: dfaure, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-15 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> broulik wrote in iconapplet.cpp:435
> but "desktop file path" is what we're doing. what I believe is happening that 
> you're actually launching the original file, not the one the icon uses.

I tried with:

  KService::Ptr service = KService::serviceByStorageId(m_localPath);
  qDebug() << "entryPath" << service->entryPath();
  KIO::ApplicationLauncherJob *job = new KIO::ApplicationLauncherJob(service);

and got:
entryPath "/home/ahmad/.local/share/plasma_icons/org.kde.dolphin.desktop"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-15 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82943.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29687?vs=82714=82943

BRANCH
  l-krun-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29687

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-15 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> broulik wrote in iconapplet.cpp:435
> But why would `serviceByStorageId` work then?
> Looks like this needs to be `KService::Ptr(new KService(m_localPath))` then?

According to the kservice docs KService::serviceByStorageId() param is  "the 
storage id or desktop-file path of the service", so I guess that's why it works.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-15 Thread Ahmad Samir
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

2020-05-13 Thread Ahmad Samir
ahmadsamir added a comment.


  Continuing the discussion from IRC, plasma 5.18 branch still uses 
QFontDialog, so https://bugs.kde.org/show_bug.cgi?id=420287 isn't directly 
related. However if users remove the ',Regular' bit from kdeglobals, 
QFontDialog will probably select the wrong style sometimes...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-neareast-addendum (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29710

To: ahmadsamir, #plasma, bport, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

2020-05-13 Thread Ahmad Samir
ahmadsamir added a comment.


  In D29710#670151 , @ahmadsamir 
wrote:
  
  > Also, is it OK to backport 
https://commits.kde.org/plasma-desktop/0325d698181055cdaaa93b24ee80172132822d35 
and this diff to Plasma/5.18?
  
  
  Scratch that, 5.18 min. required KF is 5.66, and the KFontChooserDialog is 
only in KF 5.69.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29710

To: ahmadsamir, #plasma, bport, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

2020-05-13 Thread Ahmad Samir
ahmadsamir added a comment.


  Also, is it OK to backport 
https://commits.kde.org/plasma-desktop/0325d698181055cdaaa93b24ee80172132822d35 
and this diff to Plasma/5.18?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29710

To: ahmadsamir, #plasma, bport, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

2020-05-13 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, bport, broulik.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This cleans up after commit 0325d698181055cdaaa93 
.

TEST PLAN
  make && ctest

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-neareast-addendum (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29710

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: ahmadsamir, #plasma, bport, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-13 Thread Ahmad Samir
ahmadsamir added a comment.


  I forgot to submit my reply to your inline comment

INLINE COMMENTS

> broulik wrote in iconapplet.cpp:435
> `m_localPath` is a *path* so you want `serviceByDesktopPath`

I tried that first, and it doesn't work; those .desktop files are in a 
~/.local/share/plasma_icons, ksycoca doesn't know about that location.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-13 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82714.
ahmadsamir added a comment.


  Use KNotificationJobUiDelegate

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29687?vs=82681=82714

BRANCH
  l-krun-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29687

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-12 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, broulik.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

TEST PLAN
  Open the Application Launcher, right click any app -> Add to Panel (Widget),
  then click the icon on the panel, it should launch.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-krun-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29687

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: ahmadsamir, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29155: [Fonts KCM] Remove redundant nearestExistingFont()

2020-05-05 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0325d6981810: [Fonts KCM] Remove redundant 
nearestExistingFont() (authored by ahmadsamir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29155?vs=81110=81989

REVISION DETAIL
  https://phabricator.kde.org/D29155

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, bport, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29155: [Fonts KCM] Remove redundant nearestExistingFont()

2020-05-05 Thread Ahmad Samir
ahmadsamir added a comment.


  In D29155#663178 , @bport wrote:
  
  > I don't think we will have same behavior, we don't only check name but also 
size, type...
  >  If we are ok to fallback in all case to the same font that can work.
  >
  > From your test plan, something look strange you don't end with a monospaced 
font for fixed font as fallback ?
  
  
  What happens currently is it selects "Sans Serif".

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-setnearest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29155

To: ahmadsamir, #plasma, bport, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

2020-04-28 Thread Ahmad Samir
ahmadsamir accepted this revision.
ahmadsamir added a comment.
This revision is now accepted and ready to land.


  The change makes sense; but please wait for @bport review too.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  make-small-font-smaller-when-changing-all-font-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29156

To: ngraham, #plasma, ahmadsamir, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

2020-04-28 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> fonts.cpp:271
> +// tiny, they want a tiny font everywhere.
> +if (font.pointSize() > 8) {
> +smallestFont.setPointSize(font.pointSize() - 2);

Nit-pick: I'd store font.pointSize() in a const int, and use that instead of 
calling pointSize() more than once.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29156

To: ngraham, #plasma, ahmadsamir, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

2020-04-28 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> fonts.cpp:267
> +QFont smallerSmallestFont = font;
> +smallerSmallestFont.setPointSize(font.pointSize() - 2);
> +
> m_settings->setSmallestReadableFont(applyFontDiff(m_settings->smallestReadableFont(),
>  smallerSmallestFont, fontDiffFlags));

But if the user selects a very small size, then size - 2 will be even tinier. 
Maybe make it conditional for size >= 6 or 8?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29156

To: ngraham, #plasma, ahmadsamir, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29155: [Fonts KCM] Remove redundant nearestExistingFont()

2020-04-24 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 81110.
ahmadsamir edited the summary of this revision.
ahmadsamir removed a reviewer: ngraham.
ahmadsamir added a comment.


  Tweak commit message

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29155?vs=81109=81110

BRANCH
  l-setnearest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29155

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29155: [Fonts KCM] Remove redundant nearestExistingFont()

2020-04-24 Thread Ahmad Samir
ahmadsamir added a reviewer: ngraham.
ahmadsamir added a comment.


  If that diff is a no-go, it'll have to be D27785 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29155

To: ahmadsamir, #plasma, bport, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29155: [Fonts KCM] Remove redundant nearestExistingFont()

2020-04-24 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, bport.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  It seems that nearestExistingFont() gets the same result of
  `fc-match font-name`, which is basically the sans serif default font
  on the system; this seems redundant as KFontChooser will fallback to
  selecting the first font family in the list if the initial font it
  was called with doesn't exist _and_ KFontChooser always puts "Sans Serif",
  "Serif" and "Monospace" at the top of the list.
  
  Removing nearestExistingFont() solves the issue in bug 420287 as
  the font it returns will have the styleName property set, after we
  went to so much trouble to clear that property so that setBold() can
  work.
  
  CCBUG: 420287

TEST PLAN
  Before the patch:
  
  - In kdeglobals [General] set: fixed=Blah Mono,12,-1,5,50,0,0,0,0,0 
toolBarFont=Bogus Serif,12,-1,5,50,0,0,0,0,0
  - Load the fonts KCM, and open the font dialog for Fixed and Toolbar, in both 
cases the default "sans serif" font on the system is selected, in my case it's 
"DejaVu Sans"
  
  Apply the patch and repeat, the "Sans Serif" entry is selected, which is
  an alias to "DejaVu Sans" on my system.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-setnearest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29155

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

2020-04-22 Thread Ahmad Samir
ahmadsamir added a reviewer: bport.
ahmadsamir added a comment.


  Does InlineMessage have a "Don't show again" capability? it'll become 
irritating after seeing it 1-2 times.
  
  IIUC, the fontsHaveChanged() signal, nothing is listening to it in KDE code 
doesn't mean other 3rd party software isn't, and it's a change in behaviour for 
the KCM; I am not sure if it can be repurposed.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29080

To: ngraham, #vdg, #plasma, cblack, bport
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

2020-04-21 Thread Ahmad Samir
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28000

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28135: Port away from deprecated QSet/QList methods in some places

2020-04-21 Thread Ahmad Samir
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

2020-04-20 Thread Ahmad Samir
ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  Talking with kbroulik on irc confirms your POV, the format of those patterns 
aren't documented anywhere so changing the matching now would change the 
behaviour...
  
  I'll abandon this, (I suggest that X-Plasma-DropUrlPatterns should be 
documented somewhere so that there's a defined format on which to base the 
contract of not breaking API :/).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol, broulik
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

2020-04-19 Thread Ahmad Samir
ahmadsamir added a reviewer: broulik.
ahmadsamir added a comment.


  I had trouble finding what urlPatterns would look like, and only found 
trash:/ and run:/, also couldn't find any documentation about 
X-Plasma-DropUrlPatterns.
  
  Porting regex, especially with the pesky QRegExp::Wildcard, seeing what the 
pattern should look like always helps (and then adding a comment in the code 
with examples, that helps future changes, some docs say that the best 
regex-handling-code is one that has comments with examples of what the regex is 
supposed to match).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol, broulik
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

2020-04-19 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  AFAICS, from grep'ing for "DropUrlPatterns" in 
/usr/share/{kservices5,plasma/plasmoids/}
  "urlPatterns" is either run:/ or trash:/, hence startsWith() should suffice.

TEST PLAN
  make && ctest

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28978

AFFECTED FILES
  src/plasma/pluginloader.cpp

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

2020-04-09 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:90ac7c210411: [Fonts KCM] Use KFontChooserDialog instead 
of QFontDialog (authored by ahmadsamir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27808?vs=79736=79737

REVISION DETAIL
  https://phabricator.kde.org/D27808

AFFECTED FILES
  CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml

To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

2020-04-09 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79736.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27808?vs=78519=79736

BRANCH
  l-kfontchooserdialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27808

AFFECTED FILES
  CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml

To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

2020-04-07 Thread Ahmad Samir
ahmadsamir added a comment.


  In D27518#643502 , @sitter wrote:
  
  > My point is that this diff adds kguiaddons as a link library but doesn't 
actually use any symbol, so it may as well not be a link library (or something 
ought to call some function of kguiaddons so it actually links it) ;)
  
  
  I got/agree with the first half of your point, "so it may as well not be a 
link library".
  
  The thing is systemsettings5 will always pull kguiaddons as an indirect 
dependency:
  
  - systemsettings5 requires libKF5ConfigWidgets.so.5
  - libKF5ConfigWidgets5 requires libKF5GuiAddons.so.5
  
  I am talking about rpm-based distros (since rpm is the package-system I am 
familiar with), I am sure it's the same in other distros/package managers.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D27518

To: ahmadsamir, #plasma, apol
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

2020-04-07 Thread Ahmad Samir
ahmadsamir added a comment.


  In D27518#643466 , @sitter wrote:
  
  > FYI linking a library without actually using any symbols is not going to do 
anything in practice because many distros link with --as-needed which undoes 
unnecessary linking. also see https://markmail.org/message/m3mdrsfgxoyfjtte
  
  
  Yes, some distros do that indeed (the ones I am sure of are Mandriva, Mageia, 
OpenSuse); IINM, a, hacky, way to find out when compiling is to omit the entry 
from target_link_libraries(), if the compilation succeeds, then it's not 
NEEDED, and we needn't add it.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D27518

To: ahmadsamir, #plasma, apol
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

2020-04-04 Thread Ahmad Samir
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

2020-04-03 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
ahmadsamir marked an inline comment as done.
Closed by commit R120:a8fb4ce827ab: [Klipper] Upate the klipper docbook after 
porting to QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28534?vs=79200=79201

REVISION DETAIL
  https://phabricator.kde.org/D28534

AFFECTED FILES
  doc/klipper/index.docbook

To: ahmadsamir, #plasma, davidedmundson, apol, broulik, yurchor
Cc: yurchor, kde-doc-english, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> yurchor wrote in index.docbook:34
> Can you bump the date and version?
> 
> Thanks in advance for your work.

Done. Thanks.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28534

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: yurchor, kde-doc-english, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79200.
ahmadsamir added a comment.


  Bump date and version

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28534?vs=79197=79200

BRANCH
  l-klipper-docs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28534

AFFECTED FILES
  doc/klipper/index.docbook

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: yurchor, kde-doc-english, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, davidedmundson, apol, broulik.
Herald added projects: Plasma, Documentation.
Herald added a subscriber: kde-doc-english.
ahmadsamir requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-klipper-docs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28534

AFFECTED FILES
  doc/klipper/index.docbook

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: kde-doc-english, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D28519: [KMenuEdit] Port QRegExp to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir added a comment.


  In D28519#640339 , @apol wrote:
  
  > It could make sense for you to test that the names are properly parsed 
besides just making sure it starts.
  
  
  Done.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D28519

To: ahmadsamir, #plasma, davidedmundson, mlaurent, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28519: [KMenuEdit] Port QRegExp to QRegularExpression

2020-04-03 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R103:1e30c84ab32b: [KMenuEdit] Port QRegExp to 
QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28519?vs=79188=79194

REVISION DETAIL
  https://phabricator.kde.org/D28519

AFFECTED FILES
  menufile.cpp
  menuinfo.cpp
  treeview.cpp

To: ahmadsamir, #plasma, davidedmundson, mlaurent, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28519: [KMenuEdit] Port QRegExp to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79188.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a subscriber: apol.
ahmadsamir added a comment.


  Add proper test plan

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28519?vs=79152=79188

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28519

AFFECTED FILES
  menufile.cpp
  menuinfo.cpp
  treeview.cpp

To: ahmadsamir, #plasma, davidedmundson, mlaurent, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28519: [KMenuEdit] Port QRegExp to QRegularExpression

2020-04-02 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, davidedmundson, mlaurent.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

TEST PLAN
  The code compiles and kmenuedit still starts as expected

REPOSITORY
  R103 KMenu Editor

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28519

AFFECTED FILES
  menufile.cpp
  menuinfo.cpp
  treeview.cpp

To: ahmadsamir, #plasma, davidedmundson, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

2020-04-01 Thread Ahmad Samir
ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  Not needed with D27808 , which will use 
KFontChooserDialog everywhere.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27830: [Fonts KCM] Make the font selection dialog highlight the correct style

2020-04-01 Thread Ahmad Samir
ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  See D27808 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27830

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

2020-04-01 Thread Ahmad Samir
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28000

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-04-01 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bcfd7f28370d: [Kilpper] Port QRegExp to 
QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27914?vs=78634=79040

REVISION DETAIL
  https://phabricator.kde.org/D27914

AFFECTED FILES
  klipper/clipcommandprocess.cpp
  klipper/configdialog.cpp
  klipper/editactiondialog.cpp
  klipper/klipperpopup.cpp
  klipper/popupproxy.cpp
  klipper/popupproxy.h
  klipper/urlgrabber.cpp
  klipper/urlgrabber.h

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

2020-03-30 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R126:30a713025624: [kioclient] Fix kioclient5 
--commands usage messages (authored by ahmadsamir).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28423?vs=78856=78876

REVISION DETAIL
  https://phabricator.kde.org/D28423

AFFECTED FILES
  kioclient/kioclient.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

2020-03-30 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  It should use 'kioclient5'.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  l-help-messages (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28423

AFFECTED FILES
  kioclient/kioclient.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-28 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in urlgrabber.h:185
> I think it's a silly way to do the port but okay, probably works and we get 
> to move on.

What is silly about it?

The original code in ClipCommandProcess used:
const QStringList matches = action.regExpMatches();
which was:
QStringList regExpMatches() const { return m_myRegExp.capturedTexts(); }

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-klipper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-27 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in urlgrabber.h:185
> Then you want to store a match?

The code stores the QRegularExpression::capturedTexts(), m_regexCapturedTexts, 
which is eventually what ClipCommandProcess uses.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-27 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in urlgrabber.h:185
> Then call it m_regularExpression?

Another point (which I forgot since it has been some time since I last looked 
at this patch), QRegExp stores the match info in itself, whereas 
QRegularExpression stores the match info in a QRegularExpressionMatch object 
(returned from calling QRegularExpression::match()), so if I use a 
m_regularExpression I'll have to add a getter for it, so that it can be called 
from URLGrabber::matchingActions().

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-27 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in urlgrabber.h:185
> Why did you change how it works right here?

I find it confusing to call the pattern "regExp" and the QRegExp object 
"m_myRegExp".

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-27 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 78634.
ahmadsamir added a comment.


  Rebase; and friendly ping

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27914?vs=77170=78634

BRANCH
  l-klipper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27914

AFFECTED FILES
  klipper/clipcommandprocess.cpp
  klipper/configdialog.cpp
  klipper/editactiondialog.cpp
  klipper/klipperpopup.cpp
  klipper/popupproxy.cpp
  klipper/popupproxy.h
  klipper/urlgrabber.cpp
  klipper/urlgrabber.h

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28232: [SpellChecking KCM] Fix the build

2020-03-26 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:646bd3eecc72: [SpellChecking KCM] Fix the build (authored 
by ahmadsamir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28232?vs=78554=78555

REVISION DETAIL
  https://phabricator.kde.org/D28232

AFFECTED FILES
  CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp

To: ahmadsamir, #plasma, bport, meven, crossi, ervin, davidedmundson
Cc: davidedmundson, bcooksley, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28232: [SpellChecking KCM] Fix the build

2020-03-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 78554.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28232?vs=78347=78554

BRANCH
  l-fix-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28232

AFFECTED FILES
  CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp

To: ahmadsamir, #plasma, bport, meven, crossi, ervin, davidedmundson
Cc: davidedmundson, bcooksley, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

2020-03-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 78519.
ahmadsamir retitled this revision from "[Fonts KCM] Port 
KFontDialog/KFontChooser to QFontDialog" to "[Fonts KCM] Use KFontChooserDialog 
instead of QFontDialog".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir edited reviewers, added: cfeck, bport; removed: ervin.
ahmadsamir removed subscribers: cfeck, bport.
ahmadsamir added a comment.


  Use KFontChooserDialog

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27808?vs=76867=78519

BRANCH
  l-kfontchooserdialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27808

AFFECTED FILES
  CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml

To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-03-26 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> export_scheme_dialog.cpp:46
>  int item=0;
> -Q_FOREACH(QString component, mComponents)
> +for(QString component : qAsConst(mComponents))
>  {

const QString &

> export_scheme_dialog.cpp:74
> +const auto buttons = mButtons.buttons();
> +for(QAbstractButton const *button : buttons)
>  {

const QAbstractButton *button

> kglobalshortcutseditor.cpp:708
>  {
> -Q_FOREACH (ComponentData *cd, d->components) {
> +for (ComponentData *cd : qAsConst(d->components)) {
>  if (cd->editor()->isModified()) {

I would make the ComponentData::editor() method const, then 'const 
ComponentData *cd'.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-25 Thread Ahmad Samir
ahmadsamir added a comment.


  I am not so sure about the QPlatform integration bit, it looks easier/cleaner 
to just use KFontChooserDialog; QFontDialog isn't widely used in KDE code, so 
porting to KFontChooserDialog is doable (though that sounds like going back in 
time to using KFontDialog in KDE4, then porting to QFontDialog in KF5... now 
back to KFont* variant).
  
  For now I'll port the code here to KFontChooserDialog.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28232: [SpellChecking KCM] Fix the build

2020-03-25 Thread Ahmad Samir
ahmadsamir added a comment.


  I don't know when the CI will be updated, probably soon based on what I read 
on IRC #kde-devel, but until then isn't it better to keep the CI working for 
plasma-desktop? I could rework the patch to make it conditional on 5.14 and 
keep the iterator-based ctors as-is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28232: [SpellChecking KCM] Fix the build

2020-03-25 Thread Ahmad Samir
ahmadsamir added a comment.


  In D28232#634281 , @bport wrote:
  
  > Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem 
to depend on it
  
  
  But the CI still uses 5.12 for the opensuse image, and probably 5.13 for the 
freebsd AFAIK.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28135: Port away from deprecated QSet/QList methods in some places

2020-03-24 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 78355.
ahmadsamir added a comment.


  QStringList has a sort() method

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28135?vs=77979=78355

BRANCH
  l-qset-fromlist (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28135

AFFECTED FILES
  applets/kicker/plugin/runnermodel.cpp
  dataengines/systemmonitor/systemmonitor.cpp
  kcms/translations/translationsmodel.cpp
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/taskgroupingproxymodel.cpp
  wallpapers/image/backgroundlistmodel.cpp

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27503: [KCM Spellchecking] port to KPropertySkeletonItem

2020-03-24 Thread Ahmad Samir
ahmadsamir added a comment.


  Should be fixed by D28232 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: usta, ahmadsamir, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D28232: [SpellChecking KCM] Fix the build

2020-03-24 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, bport, meven, crossi, ervin.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  QList/QSet iterator-based ctors are available since Qt 5.14, so we
  could make the code conditional based on that to keep it building
  against older Qt versions. However I think the reason behind converting
  from QStringList to QSet was to remove duplicates, so use
  QStringList::removeDuplicates() and sort() instead.
  
  Bump KF5 min. required version to 5.69.0 because of Sonnet/ConfigView
  which first appeared in that version.

TEST PLAN
  make && ctest

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-fix-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28232

AFFECTED FILES
  CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27503: [KCM Spellchecking] port to KPropertySkeletonItem

2020-03-23 Thread Ahmad Samir
ahmadsamir added a comment.


  This failed to build on the CI 
https://build.kde.org/job/Plasma/job/plasma-desktop/, I guess you'll need to 
bump the min required version of KF5 to 5.69.0.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: ahmadsamir, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


CI mail filtering (was Re: Manner in which kde-gtk-config development is conducted)

2020-03-22 Thread Ahmad Samir

On 21/03/2020 22:38, Ben Cooksley wrote:

On Sun, Mar 22, 2020 at 3:08 AM David Edmundson
 wrote:


You're absolutely right that mistakes were made and have reason to be
frustrated.

kde-gtk-config is now maintained by new developers.
Plasma has a new influx of new people which is good to see and
something we need to foster carefully.

Overall these new devs are doing a super job and we want to encourage them.

Ultimately there are two parties at fault:
  - brand new developers who didn't know the rules. KDE has a lot of
rules and they're certainly not all written down in a consistent
location.

  - the more "senior" Plasma people (me, Kai, Aleix, etc) who do know
the rules, not paying due attention to something that's now under
Plasma's umbrella


which means that the repository is no longer eligible to form
part of a KDE release module and should be moved to Playground


I think this is an overreaction that punishes the wrong people. Users.


The reaction is intended to force the hand of Plasma as a collective
group to pay attention to the notifications from the CI system - which
it delivers to the plasma-devel mailing list.
I know that some people do pay attention to these, but it is evident
that others do not or have active filtering in place to ensure they
don't see them.



The traffic of CI mail can be a bit daunting, and failure mails could simply go unnoticed, so I 
suggest some "reverse filtering", i.e. I've just created a filter in Thunderbird:

From: CI System 
X-Jenkins-Results: FAILURE

(in TBird you can create customise message headers and add a new one).

I don't care as much about success reports, (and I haven't yet dug in the mails to create a filter 
to cull mails about successful builds that have some unit tests failure).


I suggest that if you commit regulary to a KDE repo to make a habit of checking the results of the 
unit tests on the CI every now and then (jenkins has a nice web interface). Unit tests could pass 
locally and fail on the CI for some reason.


[...]


My, beginner-dev, 2 p's,

--
Ahmad Samir


D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

2020-03-21 Thread Ahmad Samir
ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  OK.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28079

To: ahmadsamir, #plasma, dfaure, davidedmundson, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D28026: further constrict line parsing of .so files

2020-03-20 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> backtraceparsergdb.cpp:75
>  if (!regExp.cap(7).isEmpty()) { //we have file information (stuff 
> after from|at)
>  bool file = regExp.cap(8) == QLatin1String("at"); //'at' means 
> we have a source file (likely)
>  // Gdb isn't entirely consistent here, when it uses 'from' it 
> always refers to a library, but

(Needs rebasing on master).
I'd move this and define "const bool file" in one place.

> backtraceparsergdb.cpp:82
> +file = file
> +&& completeSuffix != QStringLiteral("so") /* libf.so 
> (so) */
> +&& !completeSuffix.startsWith(QStringLiteral("so.")) /* 
> libf.so.1 (so.1) */

IIUC, QLatin1String is better for string comparisons.

> backtraceparsergdb.cpp:84
> +&& !completeSuffix.startsWith(QStringLiteral("so.")) /* 
> libf.so.1 (so.1) */
> +&& !completeSuffix.contains(QStringLiteral(".so") /* 
> libf-1.0.so.1 (0.so.1)*/);
>  if (file) {

startsWith() and contains() have QLatin1String overloads.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28026

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28098: remove pointless and arbitrary 4 line frame limit

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment.


  This makes sense; also it fixes a part of the backtraceparsertest unit test, 
test_bug168000, which currently fails on master (output after export'ing 
QT_LOGGING_RULES="*drkonqi*=true"):
  
3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) 
org.kde.drkonqi.parser: Rating: 24 out of 24 Usefulness: Useless
3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) 
org.kde.drkonqi.parser: 90%: 21.6 70%: 16.8 40%: 9.6
3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) 
org.kde.drkonqi.parser: Have seen stack base: false Lines counted: 3
3: FAIL!  : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) 
Compared values are not the same
3:Actual   (btUsefulness): "Useless"
3:Expected (result)  : "MayBeUseful"
3:Loc: 
[/home/ahmad/rpmbuild/dev/drkonqi/src/tests/backtraceparsertest/backtraceparsertest.cpp(71)]
  
  the rating is perfect but gets killed by the frame number limit.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28098

To: sitter, apol, bcooksley
Cc: ahmadsamir, bcooksley, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D28098: remove pointless and arbitrary 4 line frame limit

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment.


  In D28098#629338 , @bcooksley 
wrote:
  
  > There should be no further changes to Dr Konqi at this time as it fails to 
build from source on both FreeBSD and Windows.
  >  Please see the relevant CI jobs for more information - 
https://build.kde.org/view/Failing/job/Plasma/job/drkonqi/
  
  
  That should really be fixed by D28123 ; I 
see the latest build was ~ 2 hours ago, but it still fails, maybe the CI still 
doesn't have latest KCrash?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28098

To: sitter, apol, bcooksley
Cc: ahmadsamir, bcooksley, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D28027: fix line rating for new format when function name is missing

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment.


  In D28027#630512 , @sitter wrote:
  
  > D28026 
  
  
  Ah, yes, that's where those "packagekit" lines are. Thanks :)

REPOSITORY
  R871 DrKonqi

BRANCH
  parse-rate

REVISION DETAIL
  https://phabricator.kde.org/D28027

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28027: fix line rating for new format when function name is missing

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment.


  This doesn't apply cleanly.

REPOSITORY
  R871 DrKonqi

BRANCH
  parse-rate

REVISION DETAIL
  https://phabricator.kde.org/D28027

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28042: [DrKonqi] Port QRegExp to QRegularExpression

2020-03-19 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:8d8062fe6bdc: [DrKonqi] Port QRegExp to 
QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28042?vs=77744=77995

REVISION DETAIL
  https://phabricator.kde.org/D28042

AFFECTED FILES
  src/bugzillaintegration/bugzillalib.cpp
  src/gdbhighlighter.cpp
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparserkdbgwin.cpp

To: ahmadsamir, #plasma, davidedmundson, sitter, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28135: Port away from deprecated QSet/QList methods in some places

2020-03-19 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in runnermodel.cpp:179
> But toSet() returns new container m_runners and runners are unmodified.

I don't mind reverting that bit, but it seems wasteful to me to throw 
newRunners away, it is sorted and has no duplicates

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28135: Port away from deprecated QSet/QList methods in some places

2020-03-19 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in runnermodel.cpp:179
> Here should be `m_runners = runners` to be exactly same as previous. I don't 
> see much benefit of having duplicate items.

IIUC, the original code used toSet() to remove duplicates from both "m_runners" 
and "runners", because QSet doesn't allow duplicate items.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28135: Port away from deprecated QSet/QList methods in some places

2020-03-19 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, davidedmundson, apol.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-qset-fromlist (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28135

AFFECTED FILES
  applets/kicker/plugin/runnermodel.cpp
  dataengines/systemmonitor/systemmonitor.cpp
  kcms/translations/translationsmodel.cpp
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/taskgroupingproxymodel.cpp
  wallpapers/image/backgroundlistmodel.cpp

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28132: [Calculator Runner] Minor code optimisation

2020-03-18 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cd37cc6926c3: [Calculator Runner] Minor code optimisation 
(authored by ahmadsamir).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28132?vs=77945=77957

REVISION DETAIL
  https://phabricator.kde.org/D28132

AFFECTED FILES
  runners/calculator/calculatorrunner.cpp

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28132: [Calculator Runner] Minor code optimisation

2020-03-18 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, apol.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Remove redunant QString::contains() checks.
  
  Create one QRegularExpression object and use setPattern().

TEST PLAN
  make && ctest

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-calcrun (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28132

AFFECTED FILES
  runners/calculator/calculatorrunner.cpp

To: ahmadsamir, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f444ebe595a2: Port some usage of QRegExp to 
QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27857?vs=77906=77932

REVISION DETAIL
  https://phabricator.kde.org/D27857

AFFECTED FILES
  applets/digital-clock/plugin/clipboardmenu.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  ksmserver/server.cpp
  libkworkspace/kdisplaymanager.cpp
  libkworkspace/kworkspace.cpp
  runners/calculator/calculatorrunner.cpp
  shell/panelview.cpp

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77906.
ahmadsamir added reviewers: davidedmundson, apol, broulik.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27857?vs=77905=77906

BRANCH
  l-qregexp-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27857

AFFECTED FILES
  applets/digital-clock/plugin/clipboardmenu.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  ksmserver/server.cpp
  libkworkspace/kdisplaymanager.cpp
  libkworkspace/kworkspace.cpp
  runners/calculator/calculatorrunner.cpp
  shell/panelview.cpp

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77905.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27857?vs=77898=77905

BRANCH
  l-qregexp-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27857

AFFECTED FILES
  applets/digital-clock/plugin/clipboardmenu.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  ksmserver/server.cpp
  libkworkspace/kdisplaymanager.cpp
  libkworkspace/kworkspace.cpp
  runners/calculator/calculatorrunner.cpp
  shell/panelview.cpp

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in server.cpp:671
> Why the changes from [0-9] to \d?

Less cluttered; but maybe not as readable. I'll revert it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27857

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28075: [kstyle] Properly unregister widgets in ShadowHelper

2020-03-18 Thread Ahmad Samir
ahmadsamir added a comment.


  Could be something on my system no idea what though. Sorry for the noise.
  
  Anyway, the important thing is that the test passes on the CI system.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28075

To: zzag, #plasma, cblack
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28075: [kstyle] Properly unregister widgets in ShadowHelper

2020-03-18 Thread Ahmad Samir
ahmadsamir added a comment.


  FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a 
SIGSEGV even after building breeze with this diff:
  
Thread 1 "kdatetimeeditte" received signal SIGSEGV, Segmentation fault.
0x70c6c770 in qDeleteAll::const_iterator> (begin=..., end=...)
at /usr/include/qt5/QtCore/qalgorithms.h:320
320 delete *begin;
(gdb) bt
#0  0x70c6c770 in qDeleteAll::const_iterator> (begin=..., end=...)
at /usr/include/qt5/QtCore/qalgorithms.h:320
#1  0x70c6bdb8 in qDeleteAll > 
(c=...) at /usr/include/qt5/QtCore/qalgorithms.h:328
#2  0x70c69319 in Breeze::ShadowHelper::~ShadowHelper 
(this=0x547ca0, __in_chrg=)
at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:106
#3  0x70c69380 in Breeze::ShadowHelper::~ShadowHelper 
(this=0x547ca0, __in_chrg=)
at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:107
#4  0x70c701a2 in Breeze::Style::~Style (this=0x547a40, 
__in_chrg=)
at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:200
#5  0x70c70206 in Breeze::Style::~Style (this=0x547a40, 
__in_chrg=)
at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:202
#6  0x777ff5e8 in QApplication::~QApplication (this=0x7fffdd00, 
__in_chrg=) at kernel/qapplication.cpp:812
#7  0x00408f65 in main (argc=1, argv=0x7fffde58) at 
/home/ahmad/rpmbuild/dev/kwidgetsaddons/autotests/kdatetimeedittest.cpp:31

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28075

To: zzag, #plasma, cblack
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77898.
ahmadsamir marked 2 inline comments as done.
ahmadsamir removed reviewers: davidedmundson, apol, broulik.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27857?vs=76991=77898

BRANCH
  l-qregexp-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27857

AFFECTED FILES
  applets/digital-clock/plugin/clipboardmenu.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  ksmserver/server.cpp
  libkworkspace/kdisplaymanager.cpp
  libkworkspace/kworkspace.cpp
  runners/calculator/calculatorrunner.cpp
  shell/panelview.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27857

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-17 Thread Ahmad Samir
ahmadsamir added a comment.


  I spent some time looking (and hacking at a kdeplatformfontdialoghelper...) 
at the code in kdeplatformfiledialoghelper, KFontChooser and KFontDialog, and I 
am starting to think that moving KFontDialog to KWidgetAddons (where 
KFontChooser and KFontRequester live) is a better/more viable solution. Also 
the differences/features between KFonDialog/KFontChooser v.s. QFontDialog are 
numerous, unlike KIO open file dialog v.s. QFileDialog.
  
  Are there examples of how to move/port a class from one repo to another?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28095: Bump required version of KF5 to 5.69.0

2020-03-17 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:ce461918868d: Bump required version of KF5 to 5.69.0 
(authored by ahmadsamir).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28095?vs=77812=77813

REVISION DETAIL
  https://phabricator.kde.org/D28095

AFFECTED FILES
  CMakeLists.txt

To: ahmadsamir, #frameworks, dfaure, apol, sitter
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D28095: Bump required version of KF5 to 5.69.0

2020-03-17 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  KCrash::setErrorMessage() was introduced in 5.69.0.

REPOSITORY
  R871 DrKonqi

BRANCH
  l-kcrash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28095

AFFECTED FILES
  CMakeLists.txt

To: ahmadsamir, #frameworks, dfaure, apol, sitter
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

2020-03-17 Thread Ahmad Samir
ahmadsamir added a comment.


  For background see: https://bugs.kde.org/show_bug.cgi?id=414742
  
  I may be wrong, but personally I think QMimeDatabase is acting sensibly by 
not allowing to remove the "main" glob pattern of a mimetype.
  
  Also IIUC it seems other tools are sort of doing the same, e.g. gio (see the 
bug report for some testing I posted there).
  
  So, either this diff makes sense, or someone will have to put his upstream Qt 
hat on and change QMimeDatabase :p; I dug into the git history upstream, and 
IIRC it seems QMimeDatabase prepends the main glob pattern since 2012 (from 
before it was merged into qtbase).

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28079

To: ahmadsamir, #plasma, dfaure, davidedmundson, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

2020-03-16 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77754.
ahmadsamir added a comment.


  Tweak comment

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28079?vs=77753=77754

BRANCH
  l-mainglobpattern (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28079

AFFECTED FILES
  keditfiletype/filetypedetails.cpp
  keditfiletype/mimetypedata.cpp
  keditfiletype/tests/filetypestest.cpp

To: ahmadsamir, #plasma, dfaure, davidedmundson, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

2020-03-16 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, dfaure, davidedmundson, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  QMimeDatabase re-adds/prepends the "main" glob pattern (the first one
  in the system-wide xml file) to the glob patterns list, even if the user
  has previously removed it e.g. via the filetypes kcm, as a result of that:
  
  - Don't change the sort order of m_patterns. It seems the list returned by 
QMimeType::globPatterns() is "ordered". Also no need to sort() the patterns 
list in the unit test or in MimeTypeData::isMimeTypeDirty()
  - Disable the "Remove" button for the first entry in the glob patterns list 
view
  
  Fix filetypetest (unit test), use "*.inf" instead of "*.txt", the latter
  was always re-added by QMimeDatabase, which made the test fail.

TEST PLAN
  Before applying the diff:
  
- Open the filetypes kcm, and remove the first glob pattern, "*.mp3" from 
audio/mpeg, apply, restart, note that it's been added back to the top of the 
list.
  - Go to text/plain mimetype, the first entry isn't "*.txt"
  
  
  
  
  - Apply the diff then try again, the "Remove" button should be disabled when 
you select the first row in the patterns list view.
  - Select a different entry, "Remove" button should become enabled.
  - Go to text/plain mimetype, "*.txt" is the first entry.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  l-mainglobpattern (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28079

AFFECTED FILES
  keditfiletype/filetypedetails.cpp
  keditfiletype/mimetypedata.cpp
  keditfiletype/tests/filetypestest.cpp

To: ahmadsamir, #plasma, dfaure, davidedmundson, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D28042: [DrKonqi] Port QRegExp to QRegularExpression

2020-03-16 Thread Ahmad Samir
ahmadsamir added a comment.


  In D28042#628179 , @sitter wrote:
  
  > I wouldn't terribly mind a second pair of eyes.
  >
  > Code generally looks good to me though, so if nobody else comments feel 
free to land in a couple days.
  
  
  OK, thanks.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28042

To: ahmadsamir, #plasma, davidedmundson, sitter, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28042: [DrKonqi] Port QRegExp to QRegularExpression

2020-03-16 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77744.
ahmadsamir added a comment.


  Fix comment grammar

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28042?vs=77606=77744

BRANCH
  l-QRE-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28042

AFFECTED FILES
  src/bugzillaintegration/bugzillalib.cpp
  src/gdbhighlighter.cpp
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparserkdbgwin.cpp

To: ahmadsamir, #plasma, davidedmundson, sitter, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27675: feat: avoid duplicated text when assembling user-facing output names

2020-03-16 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> utils.cpp:64
> +return append(name, QLatin1Char('(') + output->name() + 
> QLatin1Char(')'));
>  }
>  }

If I am reading this correctly, you could keep the old code and use 
simplified():
const QString outName = output->name().simplified();

then later on:
name = name.simplified();
if (!name.isEmpty() && name != oName) {

  return name + QLatin1Char('(') + outName + QLatin1Char(')');

}

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D27675

To: dvratil, #plasma, romangg
Cc: ahmadsamir, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

2020-03-16 Thread Ahmad Samir
ahmadsamir added a comment.


  In D27785#628110 , @bport wrote:
  
  > Ok for me but need to wait approval on font dialog review (to ensure 
correct font style is selected when editing)
  
  
  Thanks.
  
  The font dialog review, D27808 , took a 
different turn..., see https://phabricator.kde.org/D27808#625255 for details.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28042: [DrKonqi] Port QRegExp to QRegularExpression

2020-03-14 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, davidedmundson, sitter, apol.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern(),
  unless the pattern is already anchored by "^" and "$".
  
  BacktraceLineGdb::parse():
  
  - set QRegularExpression::DotMatchesEverythingOption, since gdb breaks some 
stack frame lines to mulitple lines for readability, e.g.: "#5  
0x7f50e99f776f in QWidget::testAttribute_helper (this=0x6e6440,\n 
attribute=Qt::WA_WState_Created) at kernel/qwidget.cpp:9081\n" this matches 
QRegExp behaviour where a "." char matches new lines by default.
  - Use clustering parentheses (?:) so as not to capture groups that aren't 
needed, less bookkeeping for QRegularExpression/PCRE
  
  Replace QRegularExpression with QString comparison, the latter is usually
  faster.
  
  All unit tests still pass.

REPOSITORY
  R871 DrKonqi

BRANCH
  l-QRE-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28042

AFFECTED FILES
  src/bugzillaintegration/bugzillalib.cpp
  src/gdbhighlighter.cpp
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparserkdbgwin.cpp

To: ahmadsamir, #plasma, davidedmundson, sitter, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

2020-03-12 Thread Ahmad Samir
ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in kstart.cpp:184
> Wouldn't it be easier here to just do `windowtitle.compare(info.name(), 
> Qt::CaseInsensitive)` and skip the regex?

I thought about that, but looking at the code I found:

  void KStart::sendRule() {
  KXMessages msg;
  QString message;
  if( !windowtitle.isEmpty() )
  message += QStringLiteral("title=") + windowtitle + 
QStringLiteral("\ntitlematch=3\n"); // 3 = regexp match

which made me leave the regex in...

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28000

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

2020-03-12 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77481.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Fix commit message

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28000?vs=77480=77481

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28000

AFFECTED FILES
  kcmshell/main.cpp
  kstart/kstart.cpp

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

2020-03-12 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, apol, davidedmundson.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28000

AFFECTED FILES
  kcmshell/main.cpp
  kstart/kstart.cpp

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-11 Thread Ahmad Samir
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

2020-03-11 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77442.
ahmadsamir retitled this revision from "[Fonts KCM] Change 
setNearestExistingFonts() to set the fonts only when necessary" to "[Fonts KCM] 
Change how nearestExistingFonts() finds a matching font".
ahmadsamir edited the summary of this revision.
ahmadsamir removed a subscriber: bport.
ahmadsamir added a comment.


  Rebase
  Actually address comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=77268=77442

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart, bport


  1   2   >