D26199: Remove unneeded shortcut for page naviagtion

[Alexey Min]

alexeymin added a comment.


  Doesn't work for me, needs very fresh kirigami too?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26199

To: nicolasfella, #discover_software_store
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26069: Fix usage of deprecated QSet/QList methods

[Alexey Min]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:34d68d4ec5a5: Fix usage of deprecated QSet/QList methods 
(authored by alexeymin).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26069?vs=71749=71977

REVISION DETAIL
  https://phabricator.kde.org/D26069

AFFECTED FILES
  libdiscover/resources/StandardBackendUpdater.cpp

To: alexeymin, apol, ngraham
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26069: Fix usage of deprecated QSet/QList methods

[Alexey Min]

alexeymin added a comment.


  Should be fine now?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26069

To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26069: Fix usage of deprecated QSet/QList methods

[Alexey Min]

alexeymin updated this revision to Diff 71749.
alexeymin added a comment.


  I feel sad doing such things

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26069?vs=71748=71749

BRANCH
  arcpatch-D26069

REVISION DETAIL
  https://phabricator.kde.org/D26069

AFFECTED FILES
  libdiscover/resources/StandardBackendUpdater.cpp

To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26069: Fix usage of deprecated QSet/QList methods

[Alexey Min]

alexeymin updated this revision to Diff 71748.
alexeymin added a comment.


  Add QT_VERSION_CHECK checks

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26069?vs=71731=71748

BRANCH
  arcpatch-D26069

REVISION DETAIL
  https://phabricator.kde.org/D26069

AFFECTED FILES
  libdiscover/resources/StandardBackendUpdater.cpp

To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26069: Fix usage of deprecated QSet/QList methods

[Alexey Min]

alexeymin added a comment.


  No :( just checked, Qt 5.12's 
https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qset.h?h=v5.12.0 
is missing `inline QSet(InputIterator first, InputIterator last)`, which 
appeared only in 5.14.
  
  I guess I need an `#ifdef` for QSet construction then.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26069

To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26069: Fix usage of deprecated QSet/QList methods

[Alexey Min]

alexeymin created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexeymin requested review of this revision.

REVISION SUMMARY
  COmpiiling with Qt 5.14 produces the following warnings:
  
  .../libdiscover/resources/StandardBackendUpdater.cpp:70:43: warning:
  
‘QList QSet::toList() const [with T = AbstractResource*]’ is 
deprecated:
Use values() instead. [-Wdeprecated-declarations]
  
  .../libdiscover/resources/StandardBackendUpdater.cpp:220:48: warning:
  
‘QSet QList::toSet() const [with T = AbstractResource*]’ is 
deprecated:
Use QSet(list.begin(), list.end()) instead. [-Wdeprecated-declarations]

TEST PLAN
  clean build with Qt 5.14 with no warnings

REPOSITORY
  R134 Discover Software Store

BRANCH
  alexeymin/fix-deprecation-warnings

REVISION DETAIL
  https://phabricator.kde.org/D26069

AFFECTED FILES
  libdiscover/resources/StandardBackendUpdater.cpp

To: alexeymin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

[Alexey Min]

alexeymin added inline comments.

INLINE COMMENTS

> apol wrote in startplasma-wayland.cpp:91
> Please see 
> https://invent.kde.org/kde/plasma-phone-components/merge_requests/38

Indeed, I overlooked, probably lack of `{ }` around `for` loop confused me..

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah, mart, davidedmundson
Cc: mart, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

[Alexey Min]

alexeymin added inline comments.

INLINE COMMENTS

> apol wrote in startplasma-wayland.cpp:91
> This is not changing, --xwayland is already on by default. In fact it will be 
> possible to change the defaults by passing some arguments to 
> startplasma-wayland.

Currently I can edit simple shell script (kwinwrapper) and remove the argument 
to kwin_wayland. If this is going to be hardcoded in the executable, it cannot 
be edited easily. I know I can work around (continue to use script). But 
despite the words "more flexible" in title, some flexibility in fact will be 
lost in the end (when using startplasma_wayland to start plasma-mobile session)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

[Alexey Min]

alexeymin added inline comments.

INLINE COMMENTS

> startplasma-wayland.cpp:91
> +} else {
> +args = QStringList { QStringLiteral("--xwayland"), 
> QStringLiteral("--libinput"), QStringLiteral("--exit-with-session=" 
> CMAKE_INSTALL_FULL_LIBEXECDIR "/startplasma-waylandsession") };
> +}

having `--xwayland` always by default will unfortunately break my device port 
(xwayland crashes for me for some reason)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

[Alexey Min]

alexeymin added a comment.


  Good to see more flexibility!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22418: WIP [wayland] make automatic backend selection truly automatic

[Alexey Min]

alexeymin added a comment.


  > not convinced that removing the ifdef is the solution
  
  It is, because now availability and presence of command-line options is 
decided at KWin **compile** time, and it should be decided at **run** time 
based on the actual list of available plugins. Just removing `#ifdefs` already 
solves the problem that I cannot pass `--hwcomposer` argument to `kwin_wayland` 
if KWin was built without libhybris support and hwcomposer plugin is installed 
later and it can be loaded perfectly (and works fine). That's why we'll have to 
remove `#ifdef`s anyway.
  
  I wanted to go with the minimalistic and non-invasive approach, with as 
little bloodshed as possible. But if you wish to see some rewrites, how about 
this:
  
  - Each plugin has a method to help in autodetection process (`canLoad()`) 
that quickly checks if the environment conditions are correct and allow loading 
of this plugin. Previously there was a function `automaticBackendSelection()`, 
that did that by just checking `qEnvironmentVariableIsSet` and so; now each 
plugin can do more complicated tests than just env vars checking.
  - Each plugin has a concept of "priority" for automatic loading, because we 
need some order among them. This was previously also in 
`automaticBackendSelection()`, the order of `if` statements. The priority is 
saved in JSON metadata, the same way as the `"input"` property is now stored 
and tested in `Application::initPlatform() `: 
https://cgit.kde.org/kwin.git/tree/main.cpp?h=Plasma/5.17#n442
  
  It is not trivial to move CLI args providing and parsing into plugins, 
because some common arguments like `--width` and `--height` are only used for 
windowed backends, for example ( 
https://cgit.kde.org/kwin.git/tree/main_wayland.cpp?h=Plasma/5.17#n420 ) and 
some plugins have specific CLI options, like `--x11-display` for x11-windowed 
backend or `--fb-device` for framebuffer backend, `--wayland-display` for 
nested wayland. But maybe it's still possible by extending base `Platform` 
class even more...

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22418

To: alexeymin, romangg, #kwin
Cc: PureTryOut, graesslin, kwin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22418: WIP [wayland] make automatic backend selection truly automatic

[Alexey Min]

alexeymin updated this revision to Diff 69838.
alexeymin added a comment.


  - remove unwanted change in translated string

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22418?vs=69837=69838

BRANCH
  alexeymin/rework-wayland-backends-plugin-system

REVISION DETAIL
  https://phabricator.kde.org/D22418

AFFECTED FILES
  CMakeLists.txt
  main_wayland.cpp
  platform.h
  plugins/platforms/drm/drm.json
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_backend.h
  plugins/platforms/fbdev/fb_backend.cpp
  plugins/platforms/fbdev/fb_backend.h
  plugins/platforms/fbdev/fbdev.json
  plugins/platforms/hwcomposer/hwcomposer.json
  plugins/platforms/hwcomposer/hwcomposer_backend.cpp
  plugins/platforms/hwcomposer/hwcomposer_backend.h
  plugins/platforms/virtual/virtual.json
  plugins/platforms/virtual/virtual_backend.cpp
  plugins/platforms/virtual/virtual_backend.h
  plugins/platforms/wayland/wayland.json
  plugins/platforms/wayland/wayland_backend.cpp
  plugins/platforms/wayland/wayland_backend.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h
  plugins/platforms/x11/windowed/x11.json
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.h

To: alexeymin, romangg, #kwin
Cc: PureTryOut, graesslin, kwin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22418: WIP [wayland] make automatic backend selection truly automatic

[Alexey Min]

alexeymin updated this revision to Diff 69837.
alexeymin added a comment.


  - Link kwin_wayland with Wayland::Client
  - Platform: add canLoad() function and implement in all backends
  - Add autoLoadPriority to wayland backends plugins JSON metadata
  - main_wayland: sort loaded plugins by autoLoadPriority
  - main_wayland: automatic backend selection based on their priority

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22418?vs=61646=69837

BRANCH
  alexeymin/rework-wayland-backends-plugin-system

REVISION DETAIL
  https://phabricator.kde.org/D22418

AFFECTED FILES
  CMakeLists.txt
  main_wayland.cpp
  platform.h
  plugins/platforms/drm/drm.json
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_backend.h
  plugins/platforms/fbdev/fb_backend.cpp
  plugins/platforms/fbdev/fb_backend.h
  plugins/platforms/fbdev/fbdev.json
  plugins/platforms/hwcomposer/hwcomposer.json
  plugins/platforms/hwcomposer/hwcomposer_backend.cpp
  plugins/platforms/hwcomposer/hwcomposer_backend.h
  plugins/platforms/virtual/virtual.json
  plugins/platforms/virtual/virtual_backend.cpp
  plugins/platforms/virtual/virtual_backend.h
  plugins/platforms/wayland/wayland.json
  plugins/platforms/wayland/wayland_backend.cpp
  plugins/platforms/wayland/wayland_backend.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h
  plugins/platforms/x11/windowed/x11.json
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.h

To: alexeymin, romangg, #kwin
Cc: PureTryOut, graesslin, kwin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24363: Fix several build system errors

[Alexey Min]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:731b85008c21: Fix several build system errors (authored 
by alexeymin).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67233=67314

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

[Alexey Min]

alexeymin marked an inline comment as done.
alexeymin added a comment.


  Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our 
main documentation page https://api.kde.org/frameworks/index.html . If it is 
really Tier 3, then maybe it does not even make sense to make IconThemes and 
ConfigWidgets optional?
  
  > The subgroup value looks wrong
  
  And maybe should I include a change to `mtainfo.yaml` modifying `subgroup: 
Tier 1` to `subgroup: Tier 3` then?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

[Alexey Min]

alexeymin updated this revision to Diff 67233.
alexeymin added a comment.


  - Bring back missing KF5_DEP_VERSION

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67207=67233

BRANCH
  alexeymin/fix-cmake-errors

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

[Alexey Min]

alexeymin reopened this revision.
alexeymin added a comment.


  Phabricator, you're drunk, it is not pushed to master

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24363: Fix several builsystem errors

[Alexey Min]

alexeymin added a comment.


  Second error is revealed after the first one is fixed:
  
Scanning dependencies of target qqc2desktopstyleplugin
[ 40%] Building CXX object 
plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin_autogen/mocs_compilation.cpp.o
[ 60%] Building CXX object 
plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin.cpp.o
[ 80%] Building CXX object 
plugin/CMakeFiles/qqc2desktopstyleplugin.dir/kquickstyleitem.cpp.o

/home/minnehanov/dev/kde/fw/qqc2-desktop-style/plugin/kquickstyleitem.cpp:54:10:
 fatal error: ksharedconfig.h: Нет такого файла или каталога
 #include 
  ^
compilation terminated.
  
  `plugin/kquickstyleitem.cpp` includes `ksharedconfig.h` but KConfig was not 
specified as a link dependency for this target. Previously it was found 
transitively via KF5ConfigWidgets I guess? Now without those optional 
dependencies it cannot be built. So KConfig should explicitly be specified as 
another required KF5 dependency, along with Kirigami.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24363: Fix several builsystem errors

[Alexey Min]

alexeymin added a comment.


  First of all, if you try to build qqc2-desktop-style on a system with only 
Qt5 and other Tier 1 frameworks installed, you will get the following cmake 
configure log (https://paste.ubuntu.com/p/YRjSRWm9g6/):
  
OS Kubuntu 18.04 LTS
Custom-built Qt 5.14 in ~/prefix514
Other Tier 1 Frameworks also built and installed in ~/prefix514

The C compiler identification is GNU 7.4.0
The CXX compiler identification is GNU 7.4.0
Check for working C compiler: /usr/bin/cc
Check for working C compiler: /usr/bin/cc -- works
Detecting C compiler ABI info
Detecting C compiler ABI info - done
Detecting C compile features
Detecting C compile features - done
Check for working CXX compiler: /usr/bin/c++
Check for working CXX compiler: /usr/bin/c++ -- works
Detecting CXX compiler ABI info
Detecting CXX compiler ABI info - done
Detecting CXX compile features
Detecting CXX compile features - done
Installing in the same prefix as Qt, adopting their path scheme.
Setting build type to 'Debug' as none was specified.
Looking for __GLIBC__
Looking for __GLIBC__ - found
Performing Test _OFFT_IS_64BIT
Performing Test _OFFT_IS_64BIT - Success
Performing Test HAVE_DATE_TIME
Performing Test HAVE_DATE_TIME - Success
Found KF5Kirigami2: 
/home/minnehanov/prefix514/lib/x86_64-linux-gnu/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake
 (found version "5.63.0") 
Found KF5: success (found suitable version "5.63.0", minimum required is 
"5.62.0") found components: Kirigami2 
Could NOT find KF5IconThemes (missing: KF5IconThemes_DIR)
Could NOT find KF5IconThemes: found neither KF5IconThemesConfig.cmake nor 
kf5iconthemes-config.cmake 
Could NOT find KF5ConfigWidgets (missing: KF5ConfigWidgets_DIR)
Could NOT find KF5ConfigWidgets: found neither KF5ConfigWidgetsConfig.cmake 
nor kf5configwidgets-config.cmake 
Could NOT find KF5 (missing: IconThemes ConfigWidgets) (Required is at 
least version "5.62.0")
Found X11: /usr/include   
Looking for XOpenDisplay in 
/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so
Looking for XOpenDisplay in 
/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - found
Looking for gethostbyname
Looking for gethostbyname - found
Looking for connect
Looking for connect - found
Looking for remove
Looking for remove - found
Looking for shmat
Looking for shmat - found
Looking for IceConnectionNumber in ICE
Looking for IceConnectionNumber in ICE - found
Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1") 
The following OPTIONAL packages have been found:

 * Freetype
 * Fontconfig
 * X11
 * Qt5X11Extras (required version >= 5.11.0)
 * PkgConfig

-- The following REQUIRED packages have been found:

 * ECM (required version >= 5.62.0)
 * Qt5Network (required version >= 5.14.0)
 * Qt5Qml (required version >= 5.14.0)
 * Qt5QmlModels (required version >= 5.14.0)
 * Qt5Quick
 * Qt5Gui
 * Qt5Widgets
 * Qt5QuickControls2
 * Qt5 (required version >= 5.11.0)
 * Qt5Core (required version >= 5.11.0)
 * KF5Kirigami2 (required version >= 5.62.0)

-- The following OPTIONAL packages have not been found:

 * KF5IconThemes (required version >= 5.62.0)
 * KF5ConfigWidgets (required version >= 5.62.0)

-- The following REQUIRED packages have not been found:

 * KF5 (required version >= 5.62.0)

CMake Error at 
/home/minnehanov/prefix514/share/cmake-3.15/Modules/FeatureSummary.cmake:457 
(message):
  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake
  run.
  
  So, at first cmake says that KF5 is found with Kirigami as required 
dependency, and then next invocation of `find_package` - KF5 is NOT found, with 
optional deps of IconThemes and ConfigWidgets. Optional, but still not found. 
So, to solve that problem, change the second `find_package` invocaition to a 
two separate calls for individual components, not involving KF5 as whole.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24363: qqc2-desktop-style: Fix several builsystem errors

[Alexey Min]

alexeymin created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexeymin requested review of this revision.

TEST PLAN
  without this patch, try to build with only Qt5 and Tier 1 frameworks 
installed and see it fails

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  alexeymin/fix-cmake-errors

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23350: Chaning default iconSize in systemtray

[Alexey Min]

alexeymin added a comment.


  I can confirm the issue that tray icons are to small on 4k display

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

To: xshram, ngraham
Cc: alexeymin, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22418: wayland: make automatic backend selection truly automatic

[Alexey Min]

alexeymin created this revision.
alexeymin added reviewers: romangg, zzag.
Herald added a project: KWin.
Herald added a subscriber: kwin.
alexeymin requested review of this revision.

REVISION SUMMARY
  Choose backend automatically, based on actually available
  plugins at runtime, independently of kwin compile options.
  Don't limit command line options too.

TEST PLAN
  compile kwin without some of backends. Then
  compile kwin with that backend separately, manually
  copy the appropriate plugin into plugins directory.
  Verify that `kwin_wayland --help` lists that option,
  and running kwin_wayland without arguments, with proper
  environment automatically selects proper backend plugin.

REPOSITORY
  R108 KWin

BRANCH
  alexeymin/automatic-backend-selection

REVISION DETAIL
  https://phabricator.kde.org/D22418

AFFECTED FILES
  main_wayland.cpp

To: alexeymin, romangg, zzag
Cc: kwin, plasma-devel, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, 
mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart

D22014: Add a copy of FindKXB from kwin

[Alexey Min]

alexeymin added a comment.


  typo in title :)

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22014

To: lbeltrame, cgiboudeaux
Cc: alexeymin, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21273: Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API.

[Alexey Min]

alexeymin added a comment.


  Hm, looks ideologically similar to how it was done in SDL2...
  https://hg.libsdl.org/SDL/file/792c26401463/src/power/linux/SDL_syspower.c

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson
Cc: alexeymin, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18802: Fix pragma once problem with process class

[Alexey Min]

alexeymin added a comment.


  Is it because process.h exists somewhere else?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18802

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18651: [Task Manager] Sort manually by default

[Alexey Min]

alexeymin added a comment.


  In D18651#403466 , @broulik wrote:
  
  > +1 first thing I change on a fresh setup
  
  
  me too, along with single click to open to double click 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  allow-task-re-ordering-by-default (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D18651

To: ngraham, #vdg, #plasma, hein
Cc: alexeymin, broulik, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18621: Add again a button to manually scan for wireless networks

[Alexey Min]

alexeymin added a comment.


  In D18621#402558 , @ngraham wrote:
  
  > In my opinion, this sort of thing is a "help the user feel in control" 
issue.
  
  
  +1, it would be cool to have a button to scan for wireless networks. Today I 
tried to connect to Wi-Fi while having a wired connection activated, and no 
W-Fi networks were shown in plasma-nm applet. I had to use `nmtui` to connect 
to wireless net, so shame that plasma-nm lacks this functionality.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18621

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: alexeymin, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16330: Add a vertical spacer item

[Alexey Min]

alexeymin added a comment.


  1. What if in the future another, horizontal spacer component will become 
needed? Will you add a HorizontalSpacer.qml then?  Maybe have just a Spacer 
with `horizontal` property?
  2. Why `Rectangle`, it could be just `Item`, it does not cause rendering 
(Rectangle does)
  
  Probably it is possible use just `Item` itself, without special control.
  P.S. ^^ Just some thoughts, ignore me if I don't make sense.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D16330

To: ngraham, mart, #kirigami
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16073: openconnect: add missing dependency Qt5Xml

[Alexey Min]

alexeymin accepted this revision.
alexeymin added a comment.
This revision is now accepted and ready to land.


  
https://cgit.kde.org/plasma-nm.git/diff/vpn/openconnect/CMakeLists.txt?id=a44b7f38c548d756b6cb822c047ef71cf67645f5
  Probably this commit could remove dependency on QtXml (I'm not sure, QtDbus 
probably depends on QtXml and QtDbus was removed)
  If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: fatal 
error: QDomDocument: No such file or directory` then fine...

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

To: asturmlechner, #plasma, alexeymin
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15696: Fix qmake build

[Alexey Min]

alexeymin added a comment.


  How can I reproduce broken build? Any test plan?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

[Alexey Min]

alexeymin added a comment.


  Maybe add it to .pro file too then?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15233: Add a tooltip for the appentry in the kicker

[Alexey Min]

alexeymin added a comment.


  Why isn't repository for this review set? Which repo it should be?

REVISION DETAIL
  https://phabricator.kde.org/D15233

To: underwit, #plasma
Cc: alexeymin, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

[Alexey Min]

alexeymin added a comment.


  Don't know how much offtopic will be what I'm going to say, but I recently 
ran into an issue while packaging QQC2 application in flatpak with 
org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, 
but under flatpak it failed to start with the following message: `QWidget: 
Cannot create a QWidget without QApplication`. Of course, I had only 
QGuiApplication. But I wasn't using widgets! The only class from QtWidgets was 
QSystemTrayIcon for a nice integration with desktop. My guess was that was 
caused by platform style used in flatpak's KDE runtime may use widgets. But 
this was unexpected, without flatpak all was working. In the end I was forced 
to use QApplication, and visually saw the style used was ogr.kde.desktop.
  
  I wrote a small test QML QQC2 program with QGuiApplication and packaged it 
with flatpak with the same runtime, surprisingly, it started OK, without any 
error message. Basically, QQC2 ApplicationWindow with a button inside, not 
linked to widgets. ( https://github.com/minlexx/test_qqc2hello - repo with test 
scripts )
  
  So, if the program is linked to Qt5Widgets in any way, it has to use 
QApplication in flatpak's org.kde.Platform even if it does not use widgets? Is 
it related to this patch? Will it solve my problem? (if included in flatpak's 
kde runtime) 

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D14000

To: rjvbb, #frameworks
Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13919: [Fonts KCM] Generate font rendering previews only on X

[Alexey Min]

alexeymin added a comment.


  This is probably for  BUG: 396214 ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13919

To: broulik, #plasma, fvogt
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13920: [Font Management KCM] Only show on xcb platform

[Alexey Min]

alexeymin added a comment.


  BUG: 396214 or better BUG: 364746 ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13920

To: broulik, #plasma, fvogt
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Alexey Min]

alexeymin added a comment.


  How exactly I can test if something works? And what are the requirements? 
PipeWire? Something else?

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications
Cc: jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D12698: WIP: Show SNI to install browser-side extension

[Alexey Min]

alexeymin added a comment.


  In D12698#259554 , @zzag wrote:
  
  > Also, there is Firefox Nightly, which has its own icon too.
  
  
  Nightly users shall suffer! Icon mismatch is not fatal error, at least 
nightly users should know what they have signed up to :)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12476: kcm_opengl: Fix retrieval of DRI information

[Alexey Min]

alexeymin accepted this revision.
alexeymin added a comment.
This revision is now accepted and ready to land.


  In D12476#258427 , @roberts wrote:
  
  > It will fail gracefully, it checks for the presence of these /proc or /sys 
files and only acts if they exist. This code is only called if an EGL context 
is successfully created in any case, and in fact on Wayland rendering _is_ 
always direct.
  
  
  Yeah, after reading about wayland more, I think so, it always uses DRM to 
render.
  
  In D12476#257806 , @roberts wrote:
  
  > Can I ask for a reviewer for this under X11?
  
  
  Seems to work for me in X11, too 
  F5834748: kinfocenter X11 test.png 
  
  About code, I don't like all those single-line `if`s whout braces around, and 
KDE coding style 
 says:
  `Use curly braces even when the body of a conditional statement contains only 
one line.`
  But I guess the existing code already has this problem.
  I'd say +1

REPOSITORY
  R102 KInfoCenter

BRANCH
  kcm_opengl_fix_dri_info

REVISION DETAIL
  https://phabricator.kde.org/D12476

To: roberts, #plasma, alexeymin
Cc: alexeymin, wbauer, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12476: kcm_opengl: Fix retrieval of DRI information

[Alexey Min]

alexeymin added a comment.


  I'm not completely sure that IsDirect should be manually set to true in 
wayland code path (it looks like a hack just to test).
  What happens if IsDirect is set to true, but software rendering is active? 
Will get_dri_device() fail gracefully or something horrible will happen? :)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12476

To: roberts, #plasma
Cc: alexeymin, wbauer, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12679: Show SNI when software renderer is in use

[Alexey Min]

alexeymin added a comment.


  In D12679#257717 , @davidedmundson 
wrote:
  
  > I give them a KCM where they can easily toggle it back. That's only really 
useful after they've fixed their real problem, but I don't think we can really 
help with that.
  
  
  Well, I mean, some hint like "Open system settings, go there ... toggle this 
... " ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12679

To: davidedmundson, #plasma
Cc: alexeymin, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12679: Show SNI when software renderer is in use

[Alexey Min]

alexeymin added a comment.


  Should this notifier provide some tip for user on how to go back to hardware 
rendering? Or is it not relevant here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12679

To: davidedmundson, #plasma
Cc: alexeymin, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12476: kcm_opengl: Fix retrieval of DRI information

[Alexey Min]

alexeymin added a comment.


  I've tested this and it seems to work!
  
  F5821132: kinfocenter DRI info wayland.png 

  
  But in wayland I had to add some changes: set `IsDirect = true;` before 
calling `print_screen_info()` in `get_gl_info_egl_qt()` line ~ 929.
  Otherwise, `get_dri_device()` is never called in this block in 
`print_screen_info()`:
  
if (IsDirect) {
if (get_dri_device())  {
l2 = newItem(l1, i18n("3D Accelerator"));
l2->setExpanded(true);
l3 = newItem(l2, l3, i18n("Vendor"), dri_info.vendor);
l3 = newItem(l2, l3, i18n("Device"), dri_info.device);
l3 = newItem(l2, l3, i18n("Subvendor"), dri_info.subvendor);
l3 = newItem(l2, l3, i18n("Revision"), dri_info.rev);
} else {
l2 = newItem(l1, l2, i18n("3D Accelerator"), i18n("unknown"));
}
}
  
  For X11, `IsDirect` is initialized in `get_gl_info_glx()` line 767 by:
  
IsDirect = glXIsDirect(dpy, ctx);
  
  Fow wayland path, it stays false forever, I guess. Though direct rendering 
**IS** used.
  
  Without this hack I only get this:
  F5821138: kinfocenter DRI info wayland bad.png 

  
  `3D Accelerator` section is gone, and `Driver` section lacks kernel module 
information. :(

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12476

To: roberts, #plasma
Cc: alexeymin, wbauer, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

[Alexey Min]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:702c7ca86e94: Fix displaying OpenGL info on wayland: do 
not require OpenGL 3.2 (authored by alexeymin).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12003?vs=31536=31731

REVISION DETAIL
  https://phabricator.kde.org/D12003

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: alexeymin, #plasma, graesslin, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

[Alexey Min]

alexeymin added a comment.


  On wayland, without this patch with OpenGL 3.2 version requested, it fails 
with error: 
  F5796592: wayland before.png 
  and outputs in terminal:
  
Could not get requested OpenGL profile, requested 
QSurfaceFormat::OpenGLContextProfile(CoreProfile) got 
QSurfaceFormat::OpenGLContextProfile(NoProfile)
Could not get requested OpenGL profile, requested 
QSurfaceFormat::OpenGLContextProfile(CompatibilityProfile) got 
QSurfaceFormat::OpenGLContextProfile(NoProfile)
  
  With this fix, it loads, and shows that opengl version is only 2.1:
  F5796598: wayland after.png 
  
  With this fix, on X11:
  F5796603: kinfocenter X11 after.png 
  
  This code in kinfocenter was added 4 years ago in commit: 
https://cgit.kde.org/kinfocenter.git/commit/?id=dc62d965ff21c9840b3284acbb91f7b44bd9e394
 from review: https://git.reviewboard.kde.org/r/115952/ but I don't understand 
why 3.2 is required. :)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12003

To: alexeymin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

[Alexey Min]

alexeymin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
alexeymin requested review of this revision.

REVISION SUMMARY
  Removing the requirement of 3.2 version just fixes it for my AMD RX560 on 
amdgpu opensource driver, which only has 2.1 version.

TEST PLAN
  Run kinfocenter, choose Graphical information - OpenGL tab. It should open 
without errors.

REPOSITORY
  R102 KInfoCenter

BRANCH
  fix_wayland_opengl

REVISION DETAIL
  https://phabricator.kde.org/D12003

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: alexeymin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Alexey Min]

alexeymin added a comment.


  While I'm here and still remember some things that I don't like here - naming:
  
  There is a class `EventsPlugin` and files `eventsplugin.{h,cpp}`, class 
`EventsManager` and files `eventsmanager.{h,cpp}` and this is fine.
  But there is also class `EventHandler`, but files are called 
`events.{h,cpp}`, it makes it a little bit harder to quickly read the code; 
maybe it makes sense to rename file also to `eventhandler.h` ?
  Also class `FakeInputEventHandler` in file `fakeinputevents.h`; it may be 
also better to name the file `fakeinputeventhandler.h`...
  
  And the most important suggestion I have: can this work be split in 2 parts:
  
  - first part, split event handling into a separate type of plugin, and add a 
new event handler plugins, so we can test it on X11 first (even without 
wayland) and be sure it still works? (Hopefully this part can be done fast 
enough)
  - second part, add a new shiny GBM framebuffer plugin, and new dependencies 
on libdrm, libgbm, epoxy...
  
  Will be a bit easier to review and test, step by step.
  What do you think?

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin
Cc: alexeymin, plasma-devel, ragreen, schernikov, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10807: fileindexerconfig: Exclude Vaults by default

[Alexey Min]

alexeymin added a comment.


  Maybe when a new vault is configured, it should add itself to baloo 
exceptions.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10807

To: michaelh, #baloo, #frameworks, ngraham, #plasma
Cc: alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, michaelh, 
kmorwinski, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D9804: Add BusyIndicator to the styled controls list

[Alexey Min]

alexeymin added a comment.


  https://api.kde.org/frameworks/index.html says:
  
  > Tier 1 frameworks depend only on Qt (and possibly a small number of other 
third-party libraries), so can easily be used by any Qt-based project.
  
  Can tier 1 framework depend on other tier 1 framework?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D9804

To: Kanedias, mart
Cc: alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9542: Improve display of technical app info

[Alexey Min]

alexeymin added a comment.


  I don't spot any obvious problems in QML any more. And I like newer version 
more than previous...

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9542

To: ngraham, apol, #vdg, #discover_software_store
Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9542: Improve display of technical app info

[Alexey Min]

alexeymin added a comment.


  "After" definitely looks better :)

INLINE COMMENTS

> ApplicationPage.qml:153
>  Layout.fillWidth: true
> -text: appInfo.application.comment
> +Text {
> +text: appInfo.application.comment

Why do you put a `Text` inside a label? Why not use `font.bold` property of 
Label itself?

> ApplicationPage.qml:166
> +columns: 2
>  Layout.fillWidth: true
> +

Does `Layout.fillWidth` have an effect here? Shouldn't it be inside of 
QQC2.Label block?

> ApplicationPage.qml:189
> +elide: Text.ElideRight
> +text: version ? i18n("%1", version) : ""
> +}

Translation is probably not needed here now

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9542

To: ngraham, apol, #vdg, #discover_software_store
Cc: alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D1231: Add Remote Access interface to KWayland

[Alexey Min]

alexeymin added a comment.


  In https://phabricator.kde.org/D1231#39191, @Kanedias wrote:
  
  > ...
  >  Besides, I didn't find any mentions of multi-screen capabilities in Krfb 
at all. It currently works like this:
  >
  >   d->framebufferImage = XGetImage(QX11Info::display(),
  >   id,
  >   0,
  >   0,
  >   QApplication::desktop()->width(),
  >   QApplication::desktop()->height(),
  >   AllPlanes,
  >   ZPixmap);
  >   
  >
  > If that's the requirement, there will be huge amount of work to implement 
it from ground up.
  >  Patchset for KRfb is already enormous and rewrites half of the input 
system into plugins instead of built-in libraries (to integrate it with 
fake-input). I doubt it will endure another set of additions, the review will 
take forever.
  >  I think we should implement screen indexing in protocol but start with 
passing screen №1 only for now.
  
  
  Speaking about krfb, after https://phabricator.kde.org/D5211 X11 plugin (and 
`XGetImage` code) does not exist anymore. And krfb is aware of having multiple 
screens, but it shares only primary screen area:
  
  - xcb plugin: 
https://cgit.kde.org/krfb.git/tree/framebuffers/xcb/xcb_framebuffer.cpp#n171
  - qt plugin: 
https://cgit.kde.org/krfb.git/tree/framebuffers/qt/qtframebuffer.cpp#n81
  
  I cannot imagine how VNC server application can properly serve multiple 
monitors at once, especially if they have different resolutions (merge them 
into one big image covering all monitors at once, with black border around the 
smaller one?). So I think if krfb will ever support multiple monitors 
explicitly, there will be a combo box to select which screen to share.
  
  Do you think other screen recording applications will need to capture several 
monitors at once?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson
Cc: alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Alexey Min]

alexeymin added a comment.


  There was a https://phabricator.kde.org/D5211, that added `xcb` framebuffer 
plugin; and after that `x11` framebuffer was removed from source tree ( 
https://phabricator.kde.org/R437:f131f7ddba584779144e7f737a98b24de430824c ), so 
this patch of needs to be slightly updated to match the new krfb source.
  I'm not competent in all this Wayland/OpenGL/GBM things (yet) but at least I 
hope that i can test this, when kwin part is ready and merged (which one it is? 
https://phabricator.kde.org/D123? https://phabricator.kde.org/D1231?) so this 
work will not be forgotten in the annals of history :)

INLINE COMMENTS

> CMakeLists.txt:58
> +find_package(gbm)
> +set_package_properties(gbm PROPERTIES TYPE OPTIONAL PURPOSE "Required for 
> egl ouput of drm backend.")
> +set(HAVE_GBM FALSE)

"ouput" => "output"?

> krfb_events_fakeinput.desktop:5
> +Comment[ru]=Обработчик событий для KRfb на базе интерфейса FakeInput KWin
> +Comment[x-test]=KWin FakeInput based event handler for KRfbxx
> +Name=KWin FakeInput based event handler for KRfb

xx at the beginning?

> gbmframebuffer.cpp:296
> +{
> +format.bitsPerPixel = 32;
> +format.depth = 32;

Is the format *always* the same? True color 32bpp?

> logging.h:25
> +
> +Q_DECLARE_LOGGING_CATEGORY(KRFB_GBM)
> +#endif

maybe whole this logging thing can be ported to ecm_qt_declare_logging_category 
( https://api.kde.org/ecm/module/ECMQtDeclareLoggingCategory.html ) ?

> x11framebufferplugin.cpp:23
>  #include "x11framebuffer.h"
>  

no x11 plugin anymore :(

> krfb-events.json:4
> +"Description": "Events plugins for KRfb",
> +"Description[x-test]": "xxFrame Buffer plugins for KRfbxx"
> +},

"xxFrame Buffer plugins for KRfbxx" -> "xxEvents plugins for KRfbxx" ? :)

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin
Cc: alexeymin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas