D28059: Be more accurate in reporting the x86 CPU features solid detects

[Allan Sandfeld Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:53ff92062221: Be more accurate in reporting the x86 CPU 
features solid detects (authored by carewolf).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28059?vs=77658=77718

REVISION DETAIL
  https://phabricator.kde.org/D28059

AFFECTED FILES
  Modules/devinfo/soldevicetypes.cpp

To: carewolf, sitter, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28059: Be more accurate in reporting the x86 CPU features solid detects

[Allan Sandfeld Jensen]

carewolf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
carewolf requested review of this revision.

REPOSITORY
  R102 KInfoCenter

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D28059

AFFECTED FILES
  Modules/devinfo/soldevicetypes.cpp

To: carewolf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26923: Fix systemtray configuration

[Allan Sandfeld Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ce69fc4ea914: Fix systemtray configuration (authored by 
carewolf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26923?vs=74379=77568

REVISION DETAIL
  https://phabricator.kde.org/D26923

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: carewolf, #plasma_workspaces, davidedmundson
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27522: Fix date-label size in vertical layout

[Allan Sandfeld Jensen]

carewolf updated this revision to Diff 76092.
carewolf added a comment.


  Fixing also for short data and very long dates

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27522?vs=76055=76092

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27522

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: carewolf, ndavis, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27522: Fix date-label size in vertical layout

[Allan Sandfeld Jensen]

carewolf added a comment.


  In my case the text was too small.
  
  I wonder how exactly Text.Fit works, if it just increases font-size for short 
format to fill width that could make it too big.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27522

To: carewolf, ndavis, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27522: Fix date-label size in vertical layout

[Allan Sandfeld Jensen]

carewolf added a comment.


  It only affects vertical panels, it is in the vertical panel configuration.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27522

To: carewolf, ndavis, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27522: Fix date-label size in vertical layout

[Allan Sandfeld Jensen]

carewolf updated this revision to Diff 76055.
carewolf added a comment.


  Fix the logic to what was probably originally meant.
  
  Elided is still disabled as it triggers too aggresively on narrow fits.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27522?vs=76054=76055

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27522

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: carewolf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27522: Fix date-label size in vertical layout

[Allan Sandfeld Jensen]

carewolf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
carewolf requested review of this revision.

REVISION SUMMARY
  The text was smaller than than minimum configuration, and
  also smaller than the width allowed for.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27522

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: carewolf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26923: Fix systemtray configuration

[Allan Sandfeld Jensen]

carewolf updated this revision to Diff 74379.
carewolf added a comment.


  Changed name of property instead

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26923?vs=74378=74379

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D26923

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: carewolf, #plasma_workspaces, davidedmundson
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Allan Sandfeld Jensen]

carewolf added a comment.


  In D26586#600864 , @kmaterka wrote:
  
  > In D26586#600853 , @carewolf 
wrote:
  >
  > > This change break settings for me due to currentValue in 
ConfigEntries.qml conflicting. It works if I rename the variable to something 
else
  >
  >
  > Are you using Qt 5.14?
  
  
  Yes. Btw see https://phabricator.kde.org/D26923

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, 
mart
Cc: carewolf, ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, 
Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D26923: Fix systemtray configuration

[Allan Sandfeld Jensen]

carewolf created this revision.
carewolf added reviewers: Plasma: Workspaces, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
carewolf requested review of this revision.

REVISION SUMMARY
  The property currentValue is conflicting making the qml file not run.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D26923

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: carewolf, #plasma_workspaces, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Allan Sandfeld Jensen]

carewolf added a comment.


  This change break settings for me due to currentValue in ConfigEntries.qml 
conflicting. It works if I rename the variable to something else

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, 
mart
Cc: carewolf, ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, 
Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Re: RFC: Running clang-format across all Plasma (and more?) repos

[Allan Sandfeld Jensen]

On Donnerstag, 11. Juli 2019 16:18:08 CEST David Edmundson wrote:
> One topic discussed at the recent Plasma sprint was that we should run
> a code formatting tool (clang-format) over all our repos to ease all
> future review comments about whitespace.
> 
> All new contributions simply have to run the same tool and we get
> consistent code without having to comment on every minor thing in a
> review individually.
> 
> I've written up a wall of text outlining steps, challenges etc.
> https://phabricator.kde.org/T11214
> 
> Does anyone have any thoughts / objections?
> 
I would argue against it. clang-format is extremely primitive and stupid, it 
can't implement KDE or Qt coding styles or anything close to it, and will just 
make mess of manually indented code. You can could try to make a style that 
rougly appriximates KDE coding style (as good as clang-format can get with its 
primitive configuration), and then offer that for newbies so they follow at 
least basic rules, but a total reformatting of all code would be an objective 
downgrade of source code readablity and requires simplifying KDE coding styles 
to something that clang-format supports.

'Allan

D7036: Remove fake dependency on QtScript

[Allan Sandfeld Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:b6ed1afd8a8a: libksysguard does not appear to use 
QtScript, but just includes it. (authored by carewolf).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7036?vs=17496=17790

REVISION DETAIL
  https://phabricator.kde.org/D7036

AFFECTED FILES
  CMakeLists.txt
  processui/CMakeLists.txt
  processui/scripting.cpp

To: carewolf, sandsmark, jriddell, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7036: Remove fake dependency on QtScript

[Allan Sandfeld Jensen]

carewolf added reviewers: sandsmark, jriddell.

REVISION DETAIL
  https://phabricator.kde.org/D7036

To: carewolf, sandsmark, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7036: Remove fake dependency on QtScript

[Allan Sandfeld Jensen]

carewolf updated this revision to Diff 17496.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7036?vs=17495=17496

REVISION DETAIL
  https://phabricator.kde.org/D7036

AFFECTED FILES
  CMakeLists.txt
  processui/CMakeLists.txt
  processui/scripting.cpp

To: carewolf
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7036: Remove fake dependency on QtScript

[Allan Sandfeld Jensen]

carewolf created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  libksysguard does not appear to use QtScript, but just includes it.
  
  Removing it makes it build with a clean Qt5.9 where QtScript no longer exists.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D7036

AFFECTED FILES
  CMakeLists.txt
  processui/CMakeLists.txt
  processui/scripting.cpp

To: carewolf
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas