[frameworks-plasma] [Bug 457079] Remove "&" character from tooltip from Configure File Launcher icon

[Andreas Sturmlechner]

https://bugs.kde.org/show_bug.cgi?id=457079

Andreas Sturmlechner  changed:

   What|Removed |Added

 CC||ast...@gentoo.org

--- Comment #2 from Andreas Sturmlechner  ---
You probably mean commit 939273025ed92246b5e6d1e3a944a8c88bbc682b in
qqc2-desktop-style, should product be fixed then?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D23883#530551 , @davidedmundson 
wrote:
  
  > It only exists as a hack around some Qt5.9(?) bug to allow plasma stuff to 
be in wayland without needing us to force an environment variable.
  >  Personally I want to kill it, but AFAIK SuSE still uses it. Worst case we 
can just copy the 5 lines into kcmshell.
  
  
  Any update here? Can this hack be dropped now?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23883

To: heikobecker, #plasma
Cc: davidedmundson, asturmlechner, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Re: Plasma 5.20 and Qt versions

[Andreas Sturmlechner]

On Fri, 12 Jun 2020 at 13:34, David Edmundson
 wrote:
> We're in the process of determining our dependencies for Plasma 5.20, our 
> release in about 4 months.
>
> Ideally we would like to depend on Qt5.15, we can land some wayland fixes 
> that would be otherwise hard to  #ifdef as well as do some big code cleanup.

No problem for Gentoo, Qt 5.15.0 is available since release day and
will be stable in ~2 months together with Release Service 20.04.3 and
after fixing all other consumers.

Regards,
Andreas

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D29514#665912 , @ngraham wrote:
  
  > In D29514#665911 , 
@asturmlechner wrote:
  >
  > > In D29514#665869 , @ngraham 
wrote:
  > >
  > > > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  > >
  > >
  > > Where is synaptics-properties.h located on your system, if you even have 
been building touchpad kcm so far?
  >
  >
  > It's in `/usr/include/xorg`.
  >
  > I must confess I've never actually been able to build it, so I appreciate 
your efforts here to fix that.
  
  
  In that case yes it must have failed so far during build, now cmake will warn 
you already. It is now the same as with Evdev, Libinput and Synaptics, if you 
don't have them in system paths you would have to somehow feed the alternative 
paths to cmake.
  
  In D29514#665912 , @ngraham wrote:
  
  > What I'd really like is the ability to build just the libinput one if I 
don't have the synaptics dev stuff installed.
  
  
  Me too, unfortunately that will take a bit more work untangling the bits. In 
our source package I use this patch which enables me to bundle only the four 
headers and get rid of them as build dependencies, then point cmake to the 
bundle dir: 
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-plasma/plasma-desktop/files/plasma-desktop-5.18.5-override-include-dirs.patch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D29514#665869 , @ngraham wrote:
  
  > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  
  
  Where is synaptics-properties.h located on your system, if you even have been 
building touchpad kcm so far?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  x11 backend of the touchpad KCM uses xserver-properties.h that is part of
  xorg-server package. As XORG_INCLUDE_DIRS seems to be empty, so far, it was
  relying on Synaptics_INCLUDE_DIRS implicitly and worked only if the header
  happened to be in the same directory as Synaptics' which is the case most of
  the time.
  
  FindXorgServer.cmake is just a copy of FindXorgLibinput, adapted accordingly.

TEST PLAN
  Pointed Synaptics_INCLUDE_DIRS somewhere else than /usr/include/xorg and build
  succeeded.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29514

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXorgServer.cmake
  kcms/CMakeLists.txt
  kcms/touchpad/backends/x11.cmake

To: asturmlechner, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29215

To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  Otherwise, this does not get the header from Synaptics_INCLUDE_DIRS.

TEST PLAN
  Still builds.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29215

AFFECTED FILES
  kcms/touchpad/backends/x11/synapticstouchpad.cpp

To: asturmlechner, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Andreas Sturmlechner]

asturmlechner added a comment.


  Thanks for keeping pipewire optional, this is in line with how we have been 
packaging xdg-desktop-portal-kde in Gentoo so far, we had just been 
conditionally disabling the cmake finding of these 3 libraries to do it, and 
will switch over to using the new option then.

INLINE COMMENTS

> CMakeLists.txt:23-24
>  
> -find_package(PipeWire)
> -set_package_properties(PipeWire PROPERTIES
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -find_package(GBM)
> -set_package_properties(GBM PROPERTIES
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -find_package(Epoxy)
> -set_package_properties(Epoxy PROPERTIES DESCRIPTION "libepoxy"
> -URL "https://github.com/anholt/libepoxy;
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -if (PipeWire_FOUND AND GBM_FOUND AND Epoxy_FOUND)
> -set (SCREENCAST_ENABLED true)
> +if(DISABLE_PIPEWIRE_SUPPORT)
> +message(STATUS "Disabling PipeWire support")
> +set(HAVE_PIPEWIRE_SUPPORT 0)

maybe make it a proper cmake option?

> CMakeLists.txt:51-52
> +
> +find_package(KF5 ${KF5_MIN_VERSION} REQUIRED
> +)
>  endif()

This is odd, is it a leftover or did you forget to add an actual KF5 dependency 
here?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma
Cc: asturmlechner, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt, ngraham
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, crossi, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D22210#547637 , @davidedmundson 
wrote:
  
  > 1. A period where both X and wayland say "Plasma".
  >
  >   1 is super super bad. Which means we need to patch one of the Plasma 
entries first. I would block this happening.
  
  
  It is the status quo for everyone using a DM other than SDDM on 
, so any decision here is going to be an improvement.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 67992.
asturmlechner added a comment.


  Switch back to Plasma (Wayland)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22210?vs=62165=67992

BRANCH
  arcpatch-D22210

REVISION DETAIL
  https://phabricator.kde.org/D22210

AFFECTED FILES
  login-sessions/plasmawayland.desktop.cmake

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D22210#547621 , @ngraham wrote:
  
  > "Plasma on Xorg" is a yucky string to display to users.
  
  
  well, it is what Gnome apparently does, so at least it would have lead to 
some uniformity. But no strong opinion here.
  
  In D22210#547621 , @ngraham wrote:
  
  > IMO it would be preferable to display "Plasma on Wayland (Wayland) for a 
limited period of time while the Plasma and SDDM versions aren't yet aligned.
  
  
  ...except I wasn't sure if you could call Plasma running "on" Wayland in the 
same sense as it is running "on" Xorg.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

[Andreas Sturmlechner]

asturmlechner added a comment.


  copy that for Gentoo.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23883

To: heikobecker, #plasma
Cc: davidedmundson, asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23148: Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D23148

To: asturmlechner, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23148: Add missing headers

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
asturmlechner requested review of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23148

AFFECTED FILES
  libs/declarative/networkstatus.cpp
  libs/handler.cpp
  libs/handler.h

To: asturmlechner, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 62165.
asturmlechner added a comment.


  drop translations, rename to 'Plasma on Xorg'

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22210?vs=60995=62165

BRANCH
  session-rename

REVISION DETAIL
  https://phabricator.kde.org/D22210

AFFECTED FILES
  login-sessions/plasma.desktop.cmake

To: asturmlechner, #plasma, davidedmundson
Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  FWIW, Gnome appear to be calling theirs 'Gnome on Xorg' (and likewise, just 
'Gnome' for the wayland session).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  I'll have to do this downstream, anyway...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4dcd1588c1cf: doc: Some different phrasing, one instance 
of s/KDE/Plasma/ (authored by asturmlechner).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22214?vs=61010=61164

REVISION DETAIL
  https://phabricator.kde.org/D22214

AFFECTED FILES
  doc/kcontrol/autostart/index.docbook

To: asturmlechner, #plasma, ngraham
Cc: plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22214

AFFECTED FILES
  doc/kcontrol/autostart/index.docbook

To: asturmlechner, #plasma
Cc: plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  Well, what's the current situation - SDDM have made the decision on their 
part to append that tech-garbage for Wayland sessions, users end up with:
  
  - Plasma
  - Plasma (Wayland)
  
  Per linked issue it is not going to be like that forever; on every(?) other 
DM, like lightdm, users can choose between:
  
  - Plasma
  - Plasma
  
  ...unless whatever downstream patching has been done to alleviate that issue. 
That's a real problem, not only because it relies on downstreams to do 
something, maybe not the right thing, and for users who do not know what to 
report when they have a problem entering a session (and frustration to decide 
which is which). Both choices will remain available in the foreseeable future.
  
  I'd like to get us to a situation where the session naming is consistent on 
all DMs, the SDDM hack can be dropped and no one needs to patch anything. 
`Plasma (Wayland)` would eventually become the default choice anyway, then be 
displayed just as `Plasma` if we don't do anything on our side and only fix 
SDDM.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  SDDM as of 0.18.1 appends " (Wayland)" to the Name of any session file it
  finds in wayland-sessions dir, and Plasma is relying on that behaviour to
  distinguish between its X11 and Wayland sessions. This leads to duplicate
  "Plasma" entries on any other DM not applying the same hack, e.g. lightdm,
  and users are lost without downstream patching.
  
  Instead of waiting for which of (SDDM, Plasma) is doing something about
  it first, renaming X11 session to "Plasma (X11)" appears to be the most
  elegant solution out of the deadlock. SDDM can be fixed any time later.
  
  CCBUG: https://bugs.kde.org/show_bug.cgi?id=368409
  See also: https://github.com/sddm/sddm/pull/997

REPOSITORY
  R120 Plasma Workspace

BRANCH
  session-rename

REVISION DETAIL
  https://phabricator.kde.org/D22210

AFFECTED FILES
  login-sessions/plasma.desktop.cmake

To: asturmlechner, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19011: Thunderbolt KCM and KDED module

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D19011#480868 , @ngraham wrote:
  
  > and we should lobby distros to ship with the new repo/package.
  
  
  Provide a tarball and I'll gladly turn our git master ebuild into a release 
ebuild. ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: pino, zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, 
trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, 
asturmlechner, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D8626: DDCUtil: Improved DDCUtil support for brightness control

[Andreas Sturmlechner]

asturmlechner added a comment.


  Hm, any reason why this is still pending?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D8626

To: dvogel, broulik, davidedmundson
Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18361: libkworkspace: Allow standalone build

[Andreas Sturmlechner]

asturmlechner added a comment.


  For the record, I would have been in support of this. ;)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18361

To: heikobecker
Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14147: Port from GConf to GSettings

[Andreas Sturmlechner]

asturmlechner added inline comments.

INLINE COMMENTS

> drosca wrote in CMakeLists.txt:46
> This should probably use cache variables:
> 
>   set(USE_GCONF FALSE CACHE STRING "Build with GConf")
>   set(USE_GSETTINGS TRUE CACHE STRING "Build with GSettings")

this still needs to be addressed, anything else though?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, 
sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml 
(authored by asturmlechner).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16073?vs=43221=43247

REVISION DETAIL
  https://phabricator.kde.org/D16073

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt

To: asturmlechner, #plasma, alexeymin
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D16073#340107 , @alexeymin 
wrote:
  
  > If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: 
fatal error: QDomDocument: No such file or directory` then fine...
  
  
  Yes, it was exactly that: https://bugs.gentoo.org/668166

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

To: asturmlechner, #plasma, alexeymin
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 43221.
asturmlechner added a comment.


  Only pull in Qt5Xml if OpenConnect is requested.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16073?vs=43220=43221

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  QDomDocument is imported from vpn/openconnect/openconnectauth.cpp

TEST PLAN
  Build succeeds now.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

AFFECTED FILES
  CMakeLists.txt
  vpn/openconnect/CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15435: Add translucent background attribute to desktop icon popup menu

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:cc47b95094a3: Add translucent background attribute to 
desktop icon popup menu (authored by anemeth, committed by asturmlechner).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15435?vs=41432=41509

REVISION DETAIL
  https://phabricator.kde.org/D15435

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: anemeth, hein, davidedmundson, #plasma
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

[Andreas Sturmlechner]

asturmlechner added a comment.


  ping - could we get this in for 5.14?

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8267

To: ostroffjh, #plasma, apol
Cc: tfoster, apol, asturmlechner, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D13255: Make dependency on KF5NetworkManagerQt optional

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R845:42723bb3cb70: Make dependency on KF5NetworkManagerQt 
optional (authored by arfrever, committed by asturmlechner).

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13255?vs=35985=36035

REVISION DETAIL
  https://phabricator.kde.org/D13255

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/config-plasma-vault.cmake
  kded/service.cpp

To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13255: Make dependency on KF5NetworkManagerQt optional

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 35985.
asturmlechner added a comment.


  Use Q_UNUSED

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13255?vs=35896=35985

BRANCH
  arcpatch-D13255

REVISION DETAIL
  https://phabricator.kde.org/D13255

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/config-plasma-vault.cmake
  kded/service.cpp

To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13255: Make dependency on KF5NetworkManagerQt optional

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 35896.
asturmlechner added a comment.


  Update addressing 2/3 points raised

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13255?vs=35291=35896

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13255

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/config-plasma-vault.cmake
  kded/service.cpp

To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13255: Make dependency on KF5NetworkManagerQt optional

[Andreas Sturmlechner]

asturmlechner added a comment.


  (this is me forwarding a Gentoo user contribution)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D13255

To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13255: Make dependency on KF5NetworkManagerQt optional

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added reviewers: Plasma, ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R845 Plasma Vault

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D13255

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/config-plasma-vault.cmake
  kded/service.cpp

To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13188: Respect libdir for Firefox native messaging host manifest

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D13188

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner, #plasma
Cc: jgrulich, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12547: Fix build with Qt 5.11 (missing QStyle)

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12547

To: asturmlechner, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12547: Fix build with Qt 5.11 (missing QStyle)

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  Necessary after 6a9df821 


REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12547

AFFECTED FILES
  core/ModuleView.cpp

To: asturmlechner, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11794: Drop unused dependency

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0a349abccb5f: Drop unused dependency (authored by 
asturmlechner).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11794?vs=30887=30917

REVISION DETAIL
  https://phabricator.kde.org/D11794

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner, #plasma, mart
Cc: mart, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11794: Drop unused dependency

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11794

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11413: Fix build with Qt 5.11 (missing headers)

[Andreas Sturmlechner]

asturmlechner abandoned this revision.
asturmlechner added a comment.


  Obsolete by f83d0336a875f04361acb714c2eab490335d8d88 


REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D11413

To: asturmlechner, ivan, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11413: Fix build with Qt 5.11 (missing headers)

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R845 Plasma Vault

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11413

AFFECTED FILES
  kded/ui/mountdialog.cpp
  kded/ui/vaultconfigurationwizard.cpp

To: asturmlechner, ivan
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

[Andreas Sturmlechner]

asturmlechner added a comment.


  > (so as to not conflict with kdelibs4's kdesu).
  
  I don't think you need to care about conflicts with kde-runtime at this 
point. There is no reason why on a Plasma-5 system the old binary should be 
present as it works like a drop-in replacement.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D10541

To: sitter
Cc: asturmlechner, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

[Andreas Sturmlechner]

asturmlechner added a subscriber: apol.
asturmlechner added a comment.


  It seems to me there was no change to these files since they were imported 
into this reporitory with 8ba33ca2a934dc1f2a34659eab1eef11f89c170c 
, so 
the issue must predate that.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8267

To: ostroffjh, #plasma
Cc: apol, asturmlechner, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

Re: how to find kdesu?

[Andreas Sturmlechner]

On Wednesday, 17 January 2018 at 12:43, Harald Sitter wrote:
> Should this bugger maybe be in bin/ rather than libexec/?

Historically, it was moved around between bin and libexec at least once, but 
ultimately ended up in libexec because 'it should not be available in std. 
path'. (Some) distributions have since been providing a link to /usr/bin.

Regards

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

[Andreas Sturmlechner]

asturmlechner added a comment.


  ping - anyone here to give a ship it? ;)

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8267

To: ostroffjh, #plasma
Cc: asturmlechner, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R572 releaseme

REVISION DETAIL
  https://phabricator.kde.org/D7981

To: asturmlechner, #plasma, sitter, O2 releaseme
Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

[Andreas Sturmlechner]

asturmlechner added a comment.


  In https://phabricator.kde.org/D7981#149086, @sitter wrote:
  
  > Note that ki18n is also currently marked REQUIRED though.
  
  
  thanks, I'm not concerned about ki18n as I have not seen it being optional 
anywhere.

REPOSITORY
  R572 releaseme

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7981

To: asturmlechner, #plasma, sitter, O2 releaseme
Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

[Andreas Sturmlechner]

asturmlechner edited the summary of this revision.

REPOSITORY
  R572 releaseme

REVISION DETAIL
  https://phabricator.kde.org/D7981

To: asturmlechner, #plasma, sitter, O2 releaseme
Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 19901.
asturmlechner added a comment.
Owners added a reviewer: O2: releaseme.


  Re-added search for KF5DocTools

REPOSITORY
  R572 releaseme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7981?vs=19893=19901

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7981

AFFECTED FILES
  lib/releaseme/cmakeeditor.rb

To: asturmlechner, #plasma, sitter, O2 releaseme
Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

[Andreas Sturmlechner]

asturmlechner added a comment.


  In https://phabricator.kde.org/D7981#148820, @sitter wrote:
  
  > This breaks repos which have no find_package call already.
  
  
  Fine, I can re-add that without REQUIRED keyword. Out of curiousity, do you 
know of an example?

REPOSITORY
  R572 releaseme

REVISION DETAIL
  https://phabricator.kde.org/D7981

To: asturmlechner, #plasma, sitter
Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added reviewers: Plasma, sitter.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Many packages have KF5DocTools optional, but as soon as a release is
  made that assumption is broken. It would be nice for release script
  not to contradict behavior of the git version.
  
  Since kdoctools_install is now conditional, I've dropped the separate
  find_package call - there won't be translated docs without a doc dir
  in git and thus an already existing search for KF5DocTools. This is
  similar to how it is done in KDE Applications.

REPOSITORY
  R572 releaseme

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7981

AFFECTED FILES
  lib/releaseme/cmakeeditor.rb

To: asturmlechner, #plasma, sitter
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7756: Don't enter test subdirectories if BUILD_TESTING=OFF

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:ffc2a64d1f97: Don't enter test subdirectories if 
BUILD_TESTING=OFF (authored by asturmlechner).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7756?vs=19352=19355

REVISION DETAIL
  https://phabricator.kde.org/D7756

AFFECTED FILES
  archive/CMakeLists.txt
  man/CMakeLists.txt

To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7756: Don't enter test subdirectories if BUILD_TESTING=OFF

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Qt5Test is an optional dependency but not followed in some subdirs.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7756

AFFECTED FILES
  archive/CMakeLists.txt
  man/CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D6494

To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui

[Andreas Sturmlechner]

asturmlechner added a comment.


  So, now that the required change is in plasma-framework 5.37 I guess it would 
be safe for me to push - and also raise the minimum KF5 version to 5.37?

REPOSITORY
  R118 Plasma SDK

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6494

To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

Re: kscreenlocker: loginctl/systemd

[Andreas Sturmlechner]

On Wednesday, 9 August 2017 at 14:00, Hartmut Goebel wrote:
> Now when building kscreenlocker I get this message:
> 
> -- The following RUNTIME packages have not been found:
> 
>  * loginctl , Send control commands to the login manager ,
> 
>Needed for emergency unlock in case that the greeter is broken. In
> case your distribution does not provide loginctl please contact
> plasma-devel@kde.org to discuss alternatives.
> 
> This sounds like loginctl being an requirement. Is it a requirement or
> just an option? If it's an option, how can I get rid of this warning and
> actively disable this feature?

Shouldn't you have elogind packaged for that purpose?

Regards,
Andreas

D6175: Fix build with future glibc (major/minor macros), BSD compatible

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:35c278e52537: Fix build with future glibc (major/minor 
macros), BSD compatible (authored by asturmlechner).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6175?vs=17180=17186

REVISION DETAIL
  https://phabricator.kde.org/D6175

AFFECTED FILES
  logind.cpp

To: asturmlechner, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6175: Fix build with future glibc (major/minor macros), BSD compatible

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 17180.
asturmlechner added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Switch to master

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6175?vs=15332=17180

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6175

AFFECTED FILES
  logind.cpp

To: asturmlechner, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6493: Add KF5WindowSystem to link interface

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5033a104e226: Add KF5WindowSystem to link interface 
(authored by asturmlechner).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6493?vs=16896=16913

REVISION DETAIL
  https://phabricator.kde.org/D6493

AFFECTED FILES
  KF5PlasmaConfig.cmake.in

To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, davidedmundson, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6493: Add KF5WindowSystem to link interface

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 16896.
asturmlechner added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.


  Changed according to review

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6493?vs=16151=16896

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6493

AFFECTED FILES
  KF5PlasmaConfig.cmake.in

To: asturmlechner, #plasma
Cc: plasma-devel, davidedmundson, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6495: Don't list KF5::WindowSystem in public libraries

[Andreas Sturmlechner]

asturmlechner added a comment.


  Thanks, works for me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6495

To: davidedmundson, #plasma
Cc: asturmlechner, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Depends on https://phabricator.kde.org/D6493

TEST PLAN
  Builds fine.

REPOSITORY
  R118 Plasma SDK

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6494

AFFECTED FILES
  CMakeLists.txt
  engineexplorer/CMakeLists.txt
  engineexplorer/ktreeviewsearchline.cpp
  plasmoidviewer/CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6175: Fix build with future glibc (major/minor macros), BSD compatible

[Andreas Sturmlechner]

asturmlechner added a comment.


  In https://phabricator.kde.org/D6175#115496, @graesslin wrote:
  
  > If I understand correctly this is no longer a change suited for the 5.8 
branch.
  
  
  Okay, then I guess 5.10 would be it?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6175

To: asturmlechner, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D6175: Fix build with future glibc (major/minor macros), BSD compatible

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  Also adding sys/types.h which is not implicitly included from all over.
  
  Thanks-to: [ade] in #kde-devel
  
  See also:
  https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html
  https://git.reviewboard.kde.org/r/127662/

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D6175

AFFECTED FILES
  logind.cpp

To: asturmlechner, #plasma
Cc: plasma-devel, kwin, #kwin, adridg, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

[Andreas Sturmlechner]

asturmlechner added a comment.


  Should this be picked for 5.8 branch as well?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D5853

To: asturmlechner, #plasma, mart
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:0a34d8667c6e: Remove gtk+-3 build dep, install versioned 
gtk.css dirs unconditionally (authored by asturmlechner).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5853?vs=14510=14644

REVISION DETAIL
  https://phabricator.kde.org/D5853

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-gtk/CMakeLists.txt
  CMakeLists.txt

To: asturmlechner, #plasma, mart
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

[Andreas Sturmlechner]

asturmlechner added a comment.


  Yes, I have commit access - it just happens to be my first use of arcanist 
instead of rbtools - can I git push straight to Plasma/5.10 branch?

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5853

To: asturmlechner, #plasma, mart
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  GTK will search /usr/share/themes//gtk- and then earlier
  versions all the way back to 3.0.
  
  See also:
  
https://developer.gnome.org/gtk3/stable/GtkCssProvider.html#GtkCssProvider.description

TEST PLAN
  breeze-gtk installs gtk-3.x dirs to the expected location.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5853

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-gtk/CMakeLists.txt
  CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Re: Re: DrKonqi dependencies

[Andreas Sturmlechner]

On Sunday, 19 March 2017 at 16:22, Martin Gräßlin wrote:
> Am 2017-03-19 14:19, schrieb Kai Uwe Broulik:
> > I'd be fine with splitting drkonqi into its own repository, René
> > recently brought this up as well.
> 
> Ideally it would be part of KF5, e.g. a kcrash-runtime tier-3 repo.

So how should this be tackled? Is it realistic to prepare it while part of 
plasma-workspace or (more likely) split first, then move to KF5 when ready?

Re: Re: DrKonqi dependencies

[Andreas Sturmlechner]

On Sunday, 19 March 2017 at 14:19, Kai Uwe Broulik wrote:
> I'd be fine with splitting drkonqi into its own repository, René recently
> brought this up as well.

Since I was pondering the idea anyway, might as well attach my patch to build 
drkonqi standalone from its subdir.
commit 1ee858f194fd2c8dcb2cbd3f436fffe7207ba0cc
Author: Andreas Sturmlechner <andreas.sturmlech...@gmail.com>
Date:   Sun Mar 19 12:54:34 2017 +0100

drkonqi: Standalone sub-project

diff --git a/drkonqi/CMakeLists.txt b/drkonqi/CMakeLists.txt
index cdae1d49..3923a8f4 100644
--- a/drkonqi/CMakeLists.txt
+++ b/drkonqi/CMakeLists.txt
@@ -1,5 +1,68 @@
+project(drkonqi)
+
 include (CheckFunctionExists)
 
+if(${CMAKE_SOURCE_DIR} STREQUAL ${drkonqi_SOURCE_DIR})
+set(PROJECT_VERSION "5.9.90")
+set(PROJECT_VERSION_MAJOR 5)
+
+cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)
+
+set(QT_MIN_VERSION "5.7.0")
+set(KF5_MIN_VERSION "5.29.0")
+find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS DBus Gui Widgets Xml)
+find_package(ECM 1.8.0 REQUIRED NO_MODULE)
+set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
+
+include(KDEInstallDirs)
+include(KDECMakeSettings)
+include(KDECompilerSettings NO_POLICY_SCOPE)
+include(ECMPackageConfigHelpers)
+include(ECMMarkNonGuiExecutable)
+include(CMakePackageConfigHelpers)
+include(WriteBasicConfigVersionFile)
+include(CheckIncludeFiles)
+include(FeatureSummary)
+include(ECMOptionalAddSubdirectory)
+include(ECMQtDeclareLoggingCategory)
+include(KDEPackageAppTemplates)
+include(ECMMarkAsTest)
+
+find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS
+Completion
+Config
+ConfigWidgets
+CoreAddons
+Crash
+I18n
+IdleTime
+JobWidgets
+KIO
+Notifications
+Service
+Wallet
+WidgetsAddons
+)
+find_package(KF5XmlRpcClient REQUIRED)
+
+find_package(X11)
+set_package_properties(X11 PROPERTIES DESCRIPTION "X11 libraries"
+URL "http://www.x.org;
+TYPE OPTIONAL
+PURPOSE "Required for X11 support")
+
+if(X11_FOUND)
+find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS X11Extras)
+set(HAVE_X11 1)
+endif()
+
+if(BUILD_TESTING)
+find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Concurrent Test)
+endif()
+
+configure_file(../config-X11.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-X11.h)
+endif()
+
 check_function_exists("strsignal" HAVE_STRSIGNAL)
 check_function_exists("uname" HAVE_UNAME)
 
@@ -114,3 +177,7 @@ if (HAVE_X11)
 endif()
 
 install(TARGETS drkonqi DESTINATION ${KDE_INSTALL_LIBEXECDIR})
+
+if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
+feature_summary(WHAT ALL FATAL_ON_MISSING_REQUIRED_PACKAGES)
+endif()

Re: DrKonqi dependencies

[Andreas Sturmlechner]

On 19.03.2017 11:56, Christoph Feck wrote:
> Using openSUSE packages here, installing drkonqi does not drag in the 
> Plasma workspace, only some KF5 frameworks. So the splitting can also be 
> done by the distribution.

Them fixing it in packaging does not make it right though. Everone building 
drkonqi still has to go through all of plasma-workspace or hack around it. 
Every (?) application linking against KCrash does profit from drkonqi - to me 
this is very similar to khelpcenter, or speaking of lib-app pairs, KF5Wallet 
and kwalletmanager. The question imo is if drkonqi should rather be in 
Applications or be kept as part of Plasma, just standalone.

Regards,
Andreas

Re: Review Request 122209: [plasma-workspace] Make tests optional

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122209/
---

(Updated Feb. 8, 2017, noon)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Qt5Test should not be mandatory.


Diffs
-

  CMakeLists.txt 907c00836531db511a91860993a54acd89720055 
  ksmserver/CMakeLists.txt c0543e29904b663b3600832e5e8855b3927ee3ce 
  ksmserver/screenlocker/greeter/CMakeLists.txt 
d502cb82516e85a76685d7e3d7106a41dcf0cfff 

Diff: https://git.reviewboard.kde.org/r/122209/diff/


Testing
---

Built with (all successful) and without tests.


Thanks,

Andreas Sturmlechner

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/
---

(Updated Jan. 15, 2017, 6:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Ivan Čukić and Martin Koller.


Changes
---

Submitted with commit b1243563fa2f5a07db6b8a26c966874bfd1c27dd by Andreas 
Sturmlechner to branch master.


Repository: kio-extras


Description
---

2 commits:

- Make activities kioslave optional: Not everyone builds this for a Plasma 
desktop, Qt5Sql is already only searched for in that subdirectory, so this 
gives some nice modularity.
- Make KF5Html dependency optional: only used by man


Diffs
-

  CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 

Diff: https://git.reviewboard.kde.org/r/129783/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/
---

(Updated Jan. 15, 2017, 7:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Ivan Čukić and Martin Koller.


Changes
---

Submitted with commit b1243563fa2f5a07db6b8a26c966874bfd1c27dd by Andreas 
Sturmlechner to branch master.


Repository: kio-extras


Description
---

2 commits:

- Make activities kioslave optional: Not everyone builds this for a Plasma 
desktop, Qt5Sql is already only searched for in that subdirectory, so this 
gives some nice modularity.
- Make KF5Html dependency optional: only used by man


Diffs
-

  CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 

Diff: https://git.reviewboard.kde.org/r/129783/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/
---

(Updated Jan. 15, 2017, 1:08 p.m.)


Review request for Plasma.


Changes
---

rebased and added info about KF5KHtml purpose


Repository: kio-extras


Description
---

2 commits:

- Make activities kioslave optional: Not everyone builds this for a Plasma 
desktop, Qt5Sql is already only searched for in that subdirectory, so this 
gives some nice modularity.
- Make KF5Html dependency optional: only used by man


Diffs (updated)
-

  CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 

Diff: https://git.reviewboard.kde.org/r/129783/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

> On Jan. 7, 2017, 4:48 a.m., Anthony Fieroni wrote:
> > CMakeLists.txt, line 168
> > <https://git.reviewboard.kde.org/r/129783/diff/1/?file=488757#file488757line168>
> >
> > You still need find_package(KF5KHtml QUIET)

In the line above, but QUIET is indeed prettier, thanks.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/#review101846
---


On Jan. 7, 2017, 12:38 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129783/
> ---
> 
> (Updated Jan. 7, 2017, 12:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> 2 commits:
> 
> - Make activities kioslave optional: Not everyone builds this for a Plasma 
> desktop, Qt5Sql is already only searched for in that subdirectory, so this 
> gives some nice modularity.
> - Make KF5Html dependency optional: only used by man
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 
> 
> Diff: https://git.reviewboard.kde.org/r/129783/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/
---

(Updated Jan. 7, 2017, 12:38 p.m.)


Review request for Plasma.


Changes
---

add QUIET to find_package call


Repository: kio-extras


Description
---

2 commits:

- Make activities kioslave optional: Not everyone builds this for a Plasma 
desktop, Qt5Sql is already only searched for in that subdirectory, so this 
gives some nice modularity.
- Make KF5Html dependency optional: only used by man


Diffs (updated)
-

  CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 

Diff: https://git.reviewboard.kde.org/r/129783/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/
---

Review request for Plasma.


Repository: kio-extras


Description
---

2 commits:

- Make activities kioslave optional: Not everyone builds this for a Plasma 
desktop, Qt5Sql is already only searched for in that subdirectory, so this 
gives some nice modularity.
- Make KF5Html dependency optional: only used by man


Diffs
-

  CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 

Diff: https://git.reviewboard.kde.org/r/129783/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129725: [sddm-kcm] Drop unused dependency

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129725/
---

(Updated Dec. 30, 2016, 1:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 5755bf5743758333efc1961a04aeae76163dd326 by Andreas 
Sturmlechner to branch Plasma/5.8.


Repository: sddm-kcm


Description
---

Drop unused dependency


Diffs
-

  CMakeLists.txt 24d7239ef3df342b330c55670085cdb04621348f 

Diff: https://git.reviewboard.kde.org/r/129725/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Review Request 129725: [sddm-kcm] Drop unused dependency

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129725/
---

Review request for Plasma.


Repository: sddm-kcm


Description
---

Drop unused dependency


Diffs
-

  CMakeLists.txt 24d7239ef3df342b330c55670085cdb04621348f 

Diff: https://git.reviewboard.kde.org/r/129725/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 128957: Make KF5Baloo optional

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128957/
---

(Updated Nov. 4, 2016, 9:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Changes
---

Submitted with commit 2b7258fdd86bff594799a154f651ce396c4e69a8 by Andreas 
Sturmlechner to branch master.


Repository: plasma-desktop


Description
---

https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html

Regardless of the current state of Baloo, it is not very deeply tied into 
Plasma. Usage in plasma-desktop comes down to providing the file search kcm.


Diffs
-

  CMakeLists.txt cf2e79a8eaf12c944fea845ff688840a561abf6b 
  kcms/CMakeLists.txt 53ca49a4d17a05c3d8d9a6a4c2e37a6ec0fd9284 

Diff: https://git.reviewboard.kde.org/r/128957/diff/


Testing
---

Several days of Plasma-5 without any issues. Usage of krunner without any 
segfaults.


Thanks,

Andreas Sturmlechner

Re: Review Request 128957: Make KF5Baloo optional

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128957/
---

(Updated Oct. 20, 2016, 8:07 p.m.)


Review request for Plasma and David Edmundson.


Changes
---

rebased on top of latest changes, changed from OPTIONAL to RECOMMENDED 
dependency.


Repository: plasma-desktop


Description
---

https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html

Regardless of the current state of Baloo, it is not very deeply tied into 
Plasma. Usage in plasma-desktop comes down to providing the file search kcm.


Diffs (updated)
-

  CMakeLists.txt cf2e79a8eaf12c944fea845ff688840a561abf6b 
  kcms/CMakeLists.txt 53ca49a4d17a05c3d8d9a6a4c2e37a6ec0fd9284 

Diff: https://git.reviewboard.kde.org/r/128957/diff/


Testing
---

Several days of Plasma-5 without any issues. Usage of krunner without any 
segfaults.


Thanks,

Andreas Sturmlechner

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/
---

(Updated Oct. 20, 2016, 7:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit dfefc273af38b9031ba596c20c52165ae4d2b6c3 by Andreas 
Sturmlechner to branch master.


Repository: plasma-workspace


Description
---

https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html

Regardless of the current state of Baloo, it is not very deeply tied into 
Plasma. Usage in plasma-workspace comes down to providing the baloo runner.


Diffs
-

  CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
  runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 

Diff: https://git.reviewboard.kde.org/r/128956/diff/


Testing
---

Several days of Plasma-5 without any issues. Usage of krunner without any 
segfaults.


Thanks,

Andreas Sturmlechner

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

> On Oct. 9, 2016, 5:46 p.m., Andreas Hartmetz wrote:
> > Why not add logic to the runner to disable it automatically in the 
> > appropriate conditions? It doesn't have to be as simplistic as "there is no 
> > Baloo database at all". The other Andreas sort of suggested that and 
> > dismissed it right away but I think it's a good idea.
> > For example, it could be tri-state: Disabled by default if Baloo file 
> > search is disabled, enabled if file search is enabled, or explicitly 
> > enabled / disabled. While it's ugly, it also covers the case that somebody 
> > uses only E-mail indexing. E-mail indexing is super useful IME, and 
> > somebody might want to use it from krunner. I just use it from KMail, 
> > though...
> > One could also add an option to the Baloo KCM to clear the file index, 
> > which would automatically disable the runner (not sure if this is doable 
> > with a small amount of work / code).
> > I don't think it is a good idea to effectively make distributions choose 
> > Baloo support or not in krunner. If they still really want to, they can 
> > probably use the cascading feature of KConfig and supply a global config 
> > file that disables the Baloo runner by default.

Oh, it totally makes sense to interact with the KCM setting, it's just outside 
the scope of this RR. To a user it is not at all obvious that they need to 
disable it in two places. They will just start to type in krunner or K menu 
with a big chance of a segfault. The KCM itself should additionally stop the 
indexing when being disabled.

The default would always be _with_ Baloo, but giving choice to disable build 
for certain systems is just a nice thing to do. To kind of enforce that 
default, one could also add a default-on option to cmake so that it continued 
to fail to configure with missing Baloo instead of silently build without it.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99882
---


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> ---
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into 
> Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> ---
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any 
> segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote:
> > >Usage of krunner without any segfaults.
> > 
> > You can just disable it with the provided checkbox, you don't gain anything 
> > from disabling it at compile time.
> 
> Andreas Sturmlechner wrote:
> That's not quite true; even with runtime-disabled baloo there have been 
> segfaults (due to the fact there was no db).
> 
> David Edmundson wrote:
> Not if you disable the search plugins in krunner.
> 
> Andreas Sturmlechner wrote:
> That should probably be tied to the KCM checkbox as well - you wouldn't 
> expect having to disable it in two places. Regardless, this is all happening 
> after login when baloo is already doing its indexing first-run - and we know 
> that the KCM checkbox does not stop the ongoing indexing.
> 
> Providing it as an option at build time does not mean you are less 
> committed to Baloo as a whole. But it makes it possible to disable it based 
> on architecture (you may argue with the 1GB-segfault-limit it is broken 
> enough on 32 bit) or choice (using a different indexing mechanism).
> 
> Anthony Fieroni wrote:
> I think you can provide backtrace for issue to be resolved, since to 
> disable plugin in compile time.
> 
> Andreas Sturmlechner wrote:
> I could provide a few nice quotes there, but really, the relevant 
> discussion is linked in the description above. Basically, Plasma-5 currently 
> hard-depends on a Framework that is (knowingly!) broken on 32 bit and has no 
> maintainer. Even though given that, it is not the core reason for trying to 
> make it optional.
> 
> David Edmundson wrote:
> To some extent I agree with you,  there is no extra burden for us and the 
> current CMake is wrong anwyay.
> 
> But I don't think you've stated what your core reason for making it 
> optional actually is.

The core reason for me is a pragmatic view on the build system, especially in a 
big repository: Imo it is a nice place to indicate what is possible. If you 
insist that every component is required - most of them will be - and leave it 
to binary packaging, people will do their thing anyway and possibly do it 
wrong, at which point it may come back at you later in bugzilla. In this case 
it will mostly get us rid of baloo and its dependencies, even if they are not 
that big, but e.g. to someone preparing systems with /home over NFS it signals 
that no bad things will happen for having a feature disabled that simply will 
not work there nor make sense.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99316
---


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> ---
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into 
> Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> ---
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any 
> segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

> On Sept. 20, 2016, 12:29 p.m., Marco Martin wrote:
> > -1, would mean one code path/build config option to maintain for us
> 
> Andreas Sturmlechner wrote:
> I would understand if Plasma did much more with Baloo. But I don't see 
> that right now, it enables two rather isolated modules. While the config 
> option can be revoked any time in the future should it become impossible to 
> support, there are machines right now where the presence of Baloo does not 
> make sense at all.
> 
> Sebastian Kügler wrote:
> That may well be the case, but Marco (and I agree with him) argues that 
> we don't want increased maintenance and support burden, since we're already 
> spread thinly. A compile-time option causes this overhead, and that's the 
> reason why it's not popular among developers.

If you have a dependency chain of A—B—C where Baloo is A and its existence 
influences B and C, then I perfectly understand it. But as it stands, this is 
one runner besides other runners, just so happening to be inside the same 
repository, with zero reverse dependencies. Not a single ifdef is going to be 
added. Same for the KCM in plasma-desktop. So basically you're fine if 'build 
all' runs successfully and do not have to do anything in addition to support 
this change.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99320
-------


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> ---
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into 
> Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> ---
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any 
> segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote:
> > >Usage of krunner without any segfaults.
> > 
> > You can just disable it with the provided checkbox, you don't gain anything 
> > from disabling it at compile time.
> 
> Andreas Sturmlechner wrote:
> That's not quite true; even with runtime-disabled baloo there have been 
> segfaults (due to the fact there was no db).
> 
> David Edmundson wrote:
> Not if you disable the search plugins in krunner.
> 
> Andreas Sturmlechner wrote:
> That should probably be tied to the KCM checkbox as well - you wouldn't 
> expect having to disable it in two places. Regardless, this is all happening 
> after login when baloo is already doing its indexing first-run - and we know 
> that the KCM checkbox does not stop the ongoing indexing.
> 
> Providing it as an option at build time does not mean you are less 
> committed to Baloo as a whole. But it makes it possible to disable it based 
> on architecture (you may argue with the 1GB-segfault-limit it is broken 
> enough on 32 bit) or choice (using a different indexing mechanism).
> 
> Anthony Fieroni wrote:
> I think you can provide backtrace for issue to be resolved, since to 
> disable plugin in compile time.

I could provide a few nice quotes there, but really, the relevant discussion is 
linked in the description above. Basically, Plasma-5 currently hard-depends on 
a Framework that is (knowingly!) broken on 32 bit and has no maintainer. Even 
though given that, it is not the core reason for trying to make it optional.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99316
---


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> ---
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into 
> Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> ---
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any 
> segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

> On Sept. 20, 2016, 12:29 p.m., Marco Martin wrote:
> > -1, would mean one code path/build config option to maintain for us

I would understand if Plasma did much more with Baloo. But I don't see that 
right now, it enables two rather isolated modules. While the config option can 
be revoked any time in the future should it become impossible to support, there 
are machines right now where the presence of Baloo does not make sense at all.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99320
---


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> ---
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into 
> Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> ---
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any 
> segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote:
> > >Usage of krunner without any segfaults.
> > 
> > You can just disable it with the provided checkbox, you don't gain anything 
> > from disabling it at compile time.
> 
> Andreas Sturmlechner wrote:
> That's not quite true; even with runtime-disabled baloo there have been 
> segfaults (due to the fact there was no db).
> 
> David Edmundson wrote:
> Not if you disable the search plugins in krunner.

That should probably be tied to the KCM checkbox as well - you wouldn't expect 
having to disable it in two places. Regardless, this is all happening after 
login when baloo is already doing its indexing first-run - and we know that the 
KCM checkbox does not stop the ongoing indexing.

Providing it as an option at build time does not mean you are less committed to 
Baloo as a whole. But it makes it possible to disable it based on architecture 
(you may argue with the 1GB-segfault-limit it is broken enough on 32 bit) or 
choice (using a different indexing mechanism).


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99316
-------


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> ---
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into 
> Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> ---
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any 
> segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote:
> > >Usage of krunner without any segfaults.
> > 
> > You can just disable it with the provided checkbox, you don't gain anything 
> > from disabling it at compile time.

That's not quite true; even with runtime-disabled baloo there have been 
segfaults (due to the fact there was no db).


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99316
---


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> ---
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into 
> Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> ---
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any 
> segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Review Request 128957: Make KF5Baloo optional

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128957/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html

Regardless of the current state of Baloo, it is not very deeply tied into 
Plasma. Usage in plasma-desktop comes down to providing the file search kcm.


Diffs
-

  CMakeLists.txt cf2e79a8eaf12c944fea845ff688840a561abf6b 
  kcms/CMakeLists.txt 53ca49a4d17a05c3d8d9a6a4c2e37a6ec0fd9284 

Diff: https://git.reviewboard.kde.org/r/128957/diff/


Testing
---

Several days of Plasma-5 without any issues. Usage of krunner without any 
segfaults.


Thanks,

Andreas Sturmlechner

Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html

Regardless of the current state of Baloo, it is not very deeply tied into 
Plasma. Usage in plasma-workspace comes down to providing the baloo runner.


Diffs
-

  CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
  runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 

Diff: https://git.reviewboard.kde.org/r/128956/diff/


Testing
---

Several days of Plasma-5 without any issues. Usage of krunner without any 
segfaults.


Thanks,

Andreas Sturmlechner

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128576/#review98020
---



Works for me, thanks!

- Andreas Sturmlechner


On Aug. 2, 2016, 12:11 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128576/
> ---
> 
> (Updated Aug. 2, 2016, 12:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 362531
> https://bugs.kde.org/show_bug.cgi?id=362531
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> The Xcb implementation of KWindowSystem has two operations modes and when
> switching between the two it recreates the NETEventFilter.
> 
> This could result in the compositingChanged signal never to be emitted if:
> 1) NETEventFilter gets created before compositor is started
> 2) NETEventFilter gets recreated after compositor is started but before
>the old filter had a chance to process the XFixes event
> 
> This was the cause for e.g. plasmashell not properly detecting that a
> Compositor is running on X11.
> 
> This change ensures that the signal is emitted if the compositing state
> differs after the recreation. Also a test case is added which simulates
> the condition.
> 
> BUG: 362531
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 690c41bfe2ca981d206c590c3fbd28416d4ae401 
>   autotests/compositingenabled_test.cpp PRE-CREATION 
>   src/platforms/xcb/kwindowsystem.cpp 
> fbff381b61116c6eef47d5c7fa1fc5730857328c 
> 
> Diff: https://git.reviewboard.kde.org/r/128576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127662: [kwin] Fix build with future glibc (major/minor macros)

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127662/
---

Review request for Plasma.


Repository: kwin


Description
---

...where sys/sysmacros.h is going to be removed from sys/types.h

See also: https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html


Diffs
-

  logind.cpp 22a86cdfceaac3138a186cb2f7ab3eae674a1c77 
  virtual_terminal.cpp 40628315620e3d943b7ae0462c4415072fc256b8 

Diff: https://git.reviewboard.kde.org/r/127662/diff/


Testing
---

builds fine with older glibc (tested with glibc-2.21) as well as a patched 
glibc-2.23 with the removal already implemented.


Thanks,

Andreas Sturmlechner

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127365: [plasma-sdk] Make Qt5Test really optional, fix plasmate dependencies

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127365/
---

(Updated March 23, 2016, 5:03 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit a3176e4ef2f09c766e22bceb0855beff8fe2f344 by Andreas 
Sturmlechner to branch master.


Repository: plasma-sdk


Description
---

KF5NewStuff, KF5Parts are only required for plasmate. Could not push 
KF5ItemModels down into plasmate without breaking build. Is it a problem with 
KDevPlatform linking?

Also, fixes reviewboardrc.


Diffs
-

  .reviewboardrc d6b7a1b1d87b33fadcbfc6316dcacf543b969eb0 
  CMakeLists.txt b556de6333b9dde3a4470dad692b3b3b9cf2f7e7 
  cuttlefish/CMakeLists.txt 6eaa78aa60caa83446456bdfb5126b8e9fdce11c 
  plasmate/CMakeLists.txt 8f28ec400cb80a8af92ea4fcb86be195e3aebd13 

Diff: https://git.reviewboard.kde.org/r/127365/diff/


Testing
---

Built fine with and without plasmate.


Thanks,

Andreas Sturmlechner

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel