Re: semicolons and the policy that was none

[Arjen Hiemstra]

On Wednesday, 10 August 2022 15:57:53 CEST Harald Sitter wrote:
> Aloha,
> 
> Someone recently dug up this page from 2012
> 
> https://community.kde.org/Plasma/QMLStyle#JS_Code_Blocks
> 
> First I'd like to point out that this page isn't a policy page, if it
> was meant to be then it needs to be linked on the policies page and
> supposedly somehow agreed upon, which I don't recall this one being
> (but then I wasn't really following plasma 10 years ago).
> 
> Secondly, can we clarify our stance on semicolons?
> 
> a) we don't care, do whatever you feel like but be consistent with
> your surrounding
> b) use semicolons never [*unless required]
> c) use semicolons always
> d) use semicolons sometimes [*define sometimes]
> 

In effect, I've been writing code as (b) so I'd prefer that. That said, I would 
add something about it only applying to new code, to avoid the pointless 
"remove semicolons" MRs as Aleix mentioned. I'd also be fine with (a), which is 
basically the status quo.

- Arjen

> Please cast votes
> 
> I vote for a) or b) because the point of having a policy on this
> eludes me entirely
> 
> HS

Re: testing UIs and improving a11y all at once!

[Arjen Hiemstra]

On Wednesday, 10 August 2022 12:29:14 CEST Harald Sitter wrote:
> Servus,
> 
> A while ago I prototyped a "new" approach to UI testing and I'm
> wondering if there's general interest in doing more Plasma testing
> using it. I'm able to invest time in polishing the experience for us.
> 
> Very rough prototype:
> https://invent.kde.org/sitter/selenium-webdriver-at-spi
> 
> The testing is run through the accessibility API we have on Linux
> https://www.freedesktop.org/wiki/Accessibility/AT-SPI2/ as well as the
> testing API selenium https://www.selenium.dev/ respectively the more
> specific appium https://appium.io/
> 
> Architecturally appium is an extension to selenium and selenium is a
> client-server system where the client is the test and the server is a
> so called webdriver. Webdriver is a standardized well-defined API of
> various UI interactions https://www.w3.org/TR/webdriver/ and we'd
> implement one based on the a11y APIs (the feature sets match fairly
> well).
> 
> Since selenium has wide spread use across the industry we get to use
> excellent tooling on the client without any extra work from us. And
> because it is so wide spread the stuff is generally very well
> maintained. All we need to maintain is the webdriver that interacts
> with the a11y API.
> 
> The way this type of testing works is by UI interaction and state
> validation. There is a kcalc test available in the prototype repo [1]
> - the test operates the various UI elements to perform a calculation
> and then checks that the output UI element contains the expected
> value.
> 
> A simple plasma test might open kickoff, and launch one of the
> favorites, then validate that indeed a new window has opened.
> 
> Since all this is driven by the a11y API there is the additional
> advantage of making us notice a11y problems and deal with them,
> resulting in bettery a11y support in the long run. Two birds, one
> stone!
> 
> What do you reckon?

One of my conclusions from spending time looking at behaviour/integration 
testing was that you don't want some tool that uses screenshots for the tests, 
as they become a maintenance nightmare. I also thought about using the 
accessibility APIs instead, which provide a way to get at the actual behaviour 
without relying too much on stuff like positions. It's great to see that same 
idea proposed here.

It's also nice to be able to plug this into existing tools that are already 
widely used for this sort of thing, it makes it a lot simpler to reuse other 
things that already talk to Selenium. For example, I quite like behave[1], 
which allows writing tests in more of a natural language format and which is 
pretty easy to glue to Selenium.

Have you thought about how to integrate this into our projects? Ideally I 
suppose we would have the tests as part of each project's repo, but that might 
not work for things like Plasma, where running things depend on a lot of other 
dependencies. On the other hand having some sort of "plasma-tests" repo is 
much more likely to lead to unmaintained tests. But maybe we can tie things 
together with Gitlab pipeline triggers?

- Arjen

> 
> [1]
> https://invent.kde.org/sitter/selenium-webdriver-at-spi/-/blob/91486b50995a
> de23c6b03a54f77347c263c2f03a/calculatortest.py
> 
> HS

libksysguard respin request

[Arjen Hiemstra]

Hi,

A FreeBSD build failure slipped into ksystemstats that was best resolved with 
some API addition in libksysguard. Please respin the libksysguard tar so 
ksystemstats can build properly on FreeBSD.

Relevant commit: https://invent.kde.org/plasma/libksysguard/-/commit/
dbf3020563f31755486935ea34fa337c69c58c44

- Arjen

Re: 5.22 Soft Freeze

[Arjen Hiemstra]

On Thursday, 29 April 2021 14:52:11 CEST Jonathan Riddell wrote:
> List of git repos I have to turn into tars for Plasma 5.22:
> 
> bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi
> kactivitymanagerd kde-cli-tools kde-gtk-config kdecoration kdeplasma-addons
> kgamma5 khotkeys kinfocenter kmenuedit kscreen kscreenlocker ksshaskpass
> ksysguard ksys
> temstats kwallet-pam kwayland-integration kwayland-server kwin kwrited
> {+layer-shell-qt+} libkscreen [-libksysguard-] milou oxygen
> plasma-browser-integration plasma-desktop plasma-disks plasma-firewall
> plasma-integration plasma-nano pla
> sma-nm plasma-pa plasma-phone-components plasma-sdk plasma-systemmonitor
> plasma-tests plasma-thunderbolt plasma-vault plasma-workspace
> plasma-workspace-wallpapers plymouth-kcm polkit-kde-agent-1 powerdevil
> qqc2-breeze-style sddm-kcm systemsettings xdg-desktop-portal-kde
> 
> This is made from the script at
> https://invent.kde.org/sdk/releaseme/-/blob/master/plasma/plasma-git-repos
> 
> layer-shell-qt is new and libksysguard is gone.  Anything else?

ksystemstats (which is in your list) is new. libksysguard shouldn't be 
removed, but ksysguard can be.

- Arjen

Splitting KSystemStats out of ksysguard

[Arjen Hiemstra]

Hi,

During the beta phase of Plasma 5.21 there was some discussion with regards to 
what to do with ksysguard now that we are shipping a replacement. Back then, a 
plan was made to ship the ksysguard repo for 5.21 and to split out 
ksystemstats for 5.22.

I spent some time over the last two weeks to do this. We now have a new repo 
located at https://invent.kde.org/plasma/ksystemstats that contains 
ksystemstats and its plugins with appropriate history. Futhermore, the library 
parts to support ksystemstats and its plugins have been moved into 
libksysguard and are now treated the same as other parts of libksysguard, 
which should make it possible to create plugins for ksystemstats outside of 
the ksystemstats repo. Finally, the plugins for the processcore library will 
be moved to libksysguard/processcore/plugins once https://invent.kde.org/
plasma/libksysguard/-/merge_requests/143 has been merged.

With these changes, it should no longer be necessary to ship the ksysguard 
repo for 5.22 and we can move that elsewhere. libksysguard still contains some 
parts that are only of use to the old ksysguard UI, we will be looking at 
moving those into the ksysguard repository at some point in the future.

For the translators: I changed the catalog name for the ksystemstats plugins 
from `ksysguard_global_plugins` to `ksystemstats_plugins`. Apart from the 
mentioned location changes, there should be no other changes to the 
translations.

Cheers,
Arjen

Re: qqc2-breeze-style

[Arjen Hiemstra]

On Monday, 12 April 2021 23:26:18 CEST Carl Schwan wrote:
> Le lundi, avril 12, 2021 10:20 PM, Nate Graham  a écrit :
> > [explicitly CCing Noah]
> > 
> 
> And I still have the same worries as before. Building a universal theming
> system will takes **years** to make in a way that won't feel like a big
> regression for our users.

It is going to take a while to develop yes. On the other hand, I do not really 
see another option. Maintaining four or more different styles also takes a lot 
of time and leads to us constantly having to reimplement stuff we already fixed 
in another place.

> 
> At least for the QML engine, some part like configuring the paddings,
> margins, borders will be relatively easy since those can be mapped to QQC2
> easily. That will be more complicated is everything that has to do with
> animations Just an example, implementing ripple effects, for example,
> require js in HTML, custom shaders in QML and custom c++ code for the
> animation in QtWidgets. Trying to abstract that will be hard but not
> impossible.

On the other hand, we barely do anything with animations in the current style. 
For starters, qqc2-desktop-style does not support animations so any animation 
from the QStyle is already missing, apart from a few that were manually added. 
Similary, Plasma's SVG themes do not have any animation as far as I know, so 
all animation in Plasma is currently custom and tied to the widget rather than 
the theme.

> 
> Another example of a hard part will be the scrollbars. Currently just
> looking at the different qstyle installed on my machine, I can see many
> completely behaviors and button placements. Again it's not impossible to
> solve by figuring out a good abstraction and adding tons of options. But at
> the end we will end up with a list of configuration options that are passed
> to the engine and two implementations that should be able to handle **all**
> the options required to implement the existing themes.
> 
> here for example to support an oxygen style scrollbar (written in scss)
> 
> scrollbar {
>  border-width: 0;
>  item {
> color: ...
>  }
>  top-buttons {
>move-top: {
>  display: true;
>  icon-name: 
>  background: none;
> 
>}
>move-bottom: { display: false }
>  }
>  item-background {
> box-shadow: inner 2px 2px grey;
> border-radius: 2px
> background-color: ...
> &::hover {
>   background-color: ...
> }
>  }
>  item {
> margin: 2px
> width: calc(100% - 4px);
> background-color:
> &::hover {
>   background-color: ...
>   box-shadow: outer 2px 2px blue;
> }
>  }
>  bottom-buttons {
>move-top: {
>  display: true;
>  icon-name: 
>  background: none;
>}
>move-top: {
>  display: true;
>  icon-name: 
>  background: none;
>}
>  }
> }
> 
> This already seems like a lot of rules and I probably forgot many more...

It would already be a lot simpler if we had a `scrollbar-layout` or similar 
custom property to indicate what buttons to show where. Which is a requirement 
for the CSS parser anyway, we will need support for adding custom properties 
and similar stuff. On the other hand, what I like about CSS is that it is 
completely logic-less, which makes a bunch of things simpler.

> 
> A solution to reduce the number of rules to implement would be to allow
> the engine to accept textures provided by svg files. But that brings
> us back to the problem of it being too slow for the pinephone and require
> some hacks to pass some parameters to the theme (for example for the
> margins or the colors).

We will need some form of image support anyway. On the other hand, if we can 
avoid using images for everything, especially things that change dimensions, 
we can avoid a lot of the slowness of the current implementation.

> 
> Allowing to ship QQC2 themes with QStyles themes sounds a lot easier
> to implement compared to that. And sure it won't be perfect but the
> unified style also won't be perfect anytime soon.

Even if we dropped qqc2-desktop-style, that would still mean maintaining three 
different styles. And it doesn't solve any other problems, it means QStyles are 
still a pain to implement, qqc2 styles can break any application and Plasma 
and Applications cannot share style code.

> 
> Anyway, if someone wants to invest a lot of time in creating the unified
> theme, I won't stop them and I would happy to be proved wrong about my
> worries. But until then I will use the breeze qqc2 style on the desktop too
> because it's smoother and less buggy than the desktop style. I would even
> argue that we should ship it with our QML applications in Android.
> 
> Regards,
> Carl

Re: Plasma 5.22 Kickoff Notes

[Arjen Hiemstra]

On Wednesday, 10 March 2021 14:24:02 CET Marco Martin wrote:
> On Wed, Mar 10, 2021 at 1:57 PM Carl Schwan  wrote:
> > qqc2-desktop-style has the advantage of using in a few places the QStyle
> > so some controls are looking native but in an usual Kirigami application
> > many other components are looking the same as Breeze. You are for example
> > still getting the new ToolArea from Plasma 5.21 even when using GTK2
> > QStyle. Since it is basically using the QPainter API, it is slower and
> > use more memory than an optimized QQC2 theme would.
> 
> do we have actual reliable numbers or is just a feeling?
> On the memory side one
> can say that on the other hand the desktop style even if keeps big textures
> in memory, it creates many less qobjects, so is to be seen how much one
> thing counteracts the other.
> On the painting speed, i can already say there will be exactly one
> scenario where
> the desktop style is measurably much slower: animated resizes of widgets.
> everything else not really. when the texture is uploaded, is uploaded,
> don't have to redo it for every frame.

We do, to a certain extent. I did a fairly extensive benchmark as part of the 
unified style PoC, see https://invent.kde.org/ahiemstra/qtunifiedstyle/-/tree/
master/benchmark . One of the conclusions from that was that the desktop style 
is pretty good with regards to creation times, but the Plasma style really is 
quite bad there. On the other hand, as you say, the desktop style is quite 
slow when it needs to do constant repaints like when resizing an item.

> 
> > qqc2-plasma theme tries to make it easy to create themes by just using
> > svg so that it should be possible to only use Inkscape to make one but
> > unfortunately I think this fails because to make a plasma theme you need
> > to understands many internal things to the theming engine. For example
> > how to name every components, how the margin indicator works, what magic
> > elements need to be added to change the behavior, ... There is also the
> > problems of the themes not designed for Application UI but for Plasma so
> > they looked horribly wrong on Plasma Mobile and using more memory than
> > an optimized qqc2 theme.
> > 
> > qqc2-breeze-style has the problem of more maintenance cost and diverging
> > from the normal breeze style, but at least it is efficient and looks
> > good. So from an end user point of view for Plasma Mobile it is good. A
> > problem I see is that for users to customize the look of the applications,
> > more qqc2 will need to be developed and this isn't an easy task (but
> > developing a QStyle or Plama theme isn't easy either).
> > 
> > A qqc2 css theme doesn't exist yet and I don't think this is a solution
> > either. A css theme contains a set of rules and we would need to develop
> > a qqc2 theme reading and supporting many rules. Currently the proof of
> 
> a basic proof of concept exists as qtunified style done by Arjen.
> It's of course a proof of concept and would need a lot more
> development to be viable,
> but that's where we should start imo.
> 
> > concept use a ShadowedRectangle to support a few rules (shadow, border
> > and colors), but if we want to make it viable to use, we wold need to
> > be able to configure many more rules: customizing the width, color, style
> > every border of a rectangle, the sizing of every elements, animations,
> > transition, gradient, background image, positioning, shadows, ... And
> > those are non trivial thing to solve in both QML and QtWidgets world
> > and more importantly making each control use this heavy weight QML
> > components probably won't be cheap in term of performance. So we might
> > end up with something too slow to be usable.
> 
> the idea is to have c++ elements which paint with shaders, like
> ShadowedRectangle in Kirigami,
> but with other features which are still missing, such as gradients,
> inset shadows and what not.
> those would be performant. then of course you need to put a limit on
> what is customizable and what isn't,
> but that is true for every approach.
> Except perhaps in cases of qqc2 style or qstyle from the ground up,
> and that is *exactly* what makes both of them not acceptable.
> A good solution *has* to define boundaries from which the theme
> developer can't technically go out of

Yeah I agree actually, one of the things I actually liked with regards to CSS 
is that it is very strongly declarative, so it is actually fairly abstract. A 
CSS file says very little about how something needs to be rendered, it simply 
states what should be rendered. This means that the implementation that uses 
that CSS file is quite free to determine the how, as long as it looks correct. 
This also already sets some boundaries on what is possible, as there is 
basically no logic in a CSS file. That said, I would say supporting everything 
in CSS would be too much and we should select a reasonable subset of things to 
support.

- Arjen

Re: Plasma 5.22 Kickoff Notes

[Arjen Hiemstra]

On Wednesday, 10 March 2021 13:57:31 CET Carl Schwan wrote:
> Le mercredi, mars 10, 2021 10:56 AM, Marco Martin  a 
écrit :
> > I knew from a long time it was to be the default style on plamo.. I
> > never really agreed to default to it on plasma mobile but since looked
> > like it was the majority decision i didn't oppose it too much (even
> > qqc2-desktop-style would be fine on plamo for now, there may have been
> > issues with using the plasma style )
> > A QQC2 style is not a plasma style, it's something that is very
> > difficult to maintain .. almost as much as a qstyle, really.
> > 
> > Now having this style in workspace puts all of us quite in a big
> > maintenance burden, throws away all the fixes done through the years
> > in qqc2-desktop-style, makes more difficult to identify where a bug
> > actually is and makes qml apps more inconsistent with qwidget ones.
> > Using it as default on the desktop would be a huge mistake as well,
> > would make hunting any bug much more difficult, putting a maintenance
> > burden and time sync that should be used instead to solve the issue of
> > how we really want to do themes, as this approach is really not
> > sustainable.
> > 
> > The real core issue is:
> > qqc2-desktop-styles are not suitable for generic 3rd party theming.
> > The name suggests otherwise, but that's simply not true.
> > they can control too much of the behavior of controls, to the point of
> > even adding new api if they desire so., and making applications to not
> > start at all if they contain any error (or even if the style uses a
> > qqc2 import version older than what the app uses)
> > so, every platform should really maintain one, as the effort to have a
> > correct one is huge already. (oh, and they can't be switched a runtime
> > without restarting the app)
> > 
> > For a 3rd party theming, is needed really something else way more
> > limited (and the fact that's more limited it's a feature)
> > something based upon some combination of css and images is really the
> > only proper way forward i can see.
> > And working towards a style that gives that, to me is a way better way
> > to spend hundreds of hours of development into.
> 
> I know that this topic has been discussed many times already but I don't
> think there is any perfect solutions for QQC2 theming of applications.
> 
> qqc2-desktop-style has the advantage of using in a few places the QStyle
> so some controls are looking native but in an usual Kirigami application
> many other components are looking the same as Breeze. You are for example
> still getting the new ToolArea from Plasma 5.21 even when using GTK2 QStyle.
> Since it is basically using the QPainter API, it is slower and use more
> memory than an optimized QQC2 theme would.
> 
> qqc2-plasma theme tries to make it easy to create themes by just using
> svg so that it should be possible to only use Inkscape to make one but
> unfortunately I think this fails because to make a plasma theme you need
> to understands many internal things to the theming engine. For example
> how to name every components, how the margin indicator works, what magic
> elements need to be added to change the behavior, ... There is also the
> problems of the themes not designed for Application UI but for Plasma so
> they looked horribly wrong on Plasma Mobile and using more memory than
> an optimized qqc2 theme.
> 
> qqc2-breeze-style has the problem of more maintenance cost and diverging
> from the normal breeze style, but at least it is efficient and looks
> good. So from an end user point of view for Plasma Mobile it is good. A
> problem I see is that for users to customize the look of the applications,
> more qqc2 will need to be developed and this isn't an easy task (but
> developing a QStyle or Plama theme isn't easy either).
> 
> A qqc2 css theme doesn't exist yet and I don't think this is a solution
> either. A css theme contains a set of rules and we would need to develop
> a qqc2 theme reading and supporting many rules. Currently the proof of
> concept use a ShadowedRectangle to support a few rules (shadow, border
> and colors),

The prototype uses ShadowedRectangle because I needed something quickly. The 
goal for the unified style was actually that each API variant is drawn using an 
optimal solution for that variant, so QPainter stuff for widgets but QtQuick 
Scene Graph stuff for QtQuick. 

> but if we want to make it viable to use, we wold need to
> be able to configure many more rules: customizing the width, color, style
> every border of a rectangle, the sizing of every elements, animations,
> transition, gradiant, background image, positioning, shadows, 

The question is actually if you should support all that. I personally think 
that CSS contains too much and we want to select a subset that we can properly 
support. 

> ... And those are non trivial thing to solve in both QML and QtWidgets world
> and more importantly making each control use this heavy weight QML
> compon

Re: Plasma 5.21 repo and soft feature freeze

[Arjen Hiemstra]

On Tuesday, 5 January 2021 17:35:49 CET Jonathan Riddell wrote:
> I propose to exclude ksysguard from 5.21 and do a standalone release
> alongside it

Since we still need ksysguard for the daemon and we're a bit too close to beta 
for major changes, I want to propose releasing both for 5.21, then for 5.22 we 
will split out ksystemstats from ksysguard into its own repo so that ksysguard 
will only be ksysguard. We can then move ksysguard somewhere else.

- Arjen

> 
> libksysguard would still be included as a dependency of plasma-systemmonitor
> 
> Jonathan
> 
> On Tue, 5 Jan 2021 at 16:15, Jonathan Riddell  wrote:
> > Git repos I have for inclusion in 5.21, wdiff compared to 5.20:
> > 
> > bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi
> > kactivitymanagerd kde-cli-tools kde-gtk-config kdecoration
> > kdeplasma-addons
> > kgamma5 khotkeys kinfocenter kmenuedit kscreen kscreenlocker ksshaskpass
> > ksysguard kwal
> > let-pam kwayland-integration kwayland-server kwin kwrited libkscreen
> > libksysguard milou oxygen plasma-browser-integration plasma-desktop
> > plasma-disks plasma-integration plasma-nano plasma-nm plasma-pa
> > plasma-phone-components plasma-sdk
> > {+plasma-systemmonitor+} plasma-tests plasma-thunderbolt plasma-vault
> > plasma-workspace plasma-workspace-wallpapers plymouth-kcm
> > polkit-kde-agent-1 powerdevil {+qqc2-breeze-style+} sddm-kcm
> > systemsettings
> > xdg-desktop-portal-kde
> > 
> > plasma-firewall should be included too, it's currently in network category
> > on invent.kde.org so that should be moved
> > 
> > Noah is qqc2-breeze-style to be included?  It has not yet passed
> > kdereview.
> > 
> > Dan Vratil what about plasma-pass?
> > 
> > plasma-systemmonitor is to be included.  This duplicates functionality
> > with ksysguard which is still included.  I'm not sure how to explain this
> > to packagers or users.
> > 
> > Stuff in the plasma category which is excluded:
> > kde-vdg-extras lancelot latte-dock oxygen-gtk plasma-active-window-control
> > plasma-bigscreen plasma-pass plasma-redshift-control plasma-simplemenu
> > user-manager
> > 
> > The list is made with this script which grabs everything in the plasma
> > category and excludes listed items
> > https://invent.kde.org/sdk/releaseme/-/blob/master/plasma/plasma-git-repos
> > 
> > Jonathan
> > 
> > 
> > 
> > 
> > On Sun, 3 Jan 2021 at 21:58, David Edmundson 
> > 
> > wrote:
> > > Plasma 5.21 has a feature freeze in a few days on the 7th January.
> > > If anything needs urgent attention from reviewers, please do reply
> > > here ASAP so they can be prioritised.
> > > 
> > > David

Re: Plasma 5.21 repo and soft feature freeze

[Arjen Hiemstra]

On Wednesday, 6 January 2021 13:23:47 CET Jonathan Riddell wrote:
> So should plasma-systemmonitor packages depend on ksysguard packages for
> ksystemstats ?

Hmm, I suppose it should yes, since it can't run without ksystemstats.

> 
> Jonathan
> 
> On Wed, 6 Jan 2021 at 12:18, Arjen Hiemstra  wrote:
> > On Tuesday, 5 January 2021 17:35:49 CET Jonathan Riddell wrote:
> > > I propose to exclude ksysguard from 5.21 and do a standalone release
> > > alongside it
> > 
> > We still need the ksysguard repo as it contains the ksystemstats daemon
> 
> and
> 
> > all its plugins. We could disable building ksysguard GUI but that may get
> 
> a
> 
> > bit hairy.
> > 
> > > libksysguard would still be included as a dependency of
> 
> plasma-systemmonitor
> 
> > > Jonathan
> > > 
> > > On Tue, 5 Jan 2021 at 16:15, Jonathan Riddell  wrote:
> > > > Git repos I have for inclusion in 5.21, wdiff compared to 5.20:
> > > > 
> > > > bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover
> 
> drkonqi
> 
> > > > kactivitymanagerd kde-cli-tools kde-gtk-config kdecoration
> > > > kdeplasma-addons
> > > > kgamma5 khotkeys kinfocenter kmenuedit kscreen kscreenlocker
> 
> ksshaskpass
> 
> > > > ksysguard kwal
> > > > let-pam kwayland-integration kwayland-server kwin kwrited libkscreen
> > > > libksysguard milou oxygen plasma-browser-integration plasma-desktop
> > > > plasma-disks plasma-integration plasma-nano plasma-nm plasma-pa
> > > > plasma-phone-components plasma-sdk
> > > > {+plasma-systemmonitor+} plasma-tests plasma-thunderbolt plasma-vault
> > > > plasma-workspace plasma-workspace-wallpapers plymouth-kcm
> > > > polkit-kde-agent-1 powerdevil {+qqc2-breeze-style+} sddm-kcm
> > > > systemsettings
> > > > xdg-desktop-portal-kde
> > > > 
> > > > plasma-firewall should be included too, it's currently in network
> 
> category
> 
> > > > on invent.kde.org so that should be moved
> > > > 
> > > > Noah is qqc2-breeze-style to be included?  It has not yet passed
> > > > kdereview.
> > > > 
> > > > Dan Vratil what about plasma-pass?
> > > > 
> > > > plasma-systemmonitor is to be included.  This duplicates functionality
> > > > with ksysguard which is still included.  I'm not sure how to explain
> 
> this
> 
> > > > to packagers or users.
> > > > 
> > > > Stuff in the plasma category which is excluded:
> > > > kde-vdg-extras lancelot latte-dock oxygen-gtk
> 
> plasma-active-window-control
> 
> > > > plasma-bigscreen plasma-pass plasma-redshift-control plasma-simplemenu
> > > > user-manager
> > > > 
> > > > The list is made with this script which grabs everything in the plasma
> > > > category and excludes listed items
> 
> https://invent.kde.org/sdk/releaseme/-/blob/master/plasma/plasma-git-repos
> 
> > > > Jonathan
> > > > 
> > > > 
> > > > 
> > > > 
> > > > On Sun, 3 Jan 2021 at 21:58, David Edmundson <
> 
> da...@davidedmundson.co.uk>
> 
> > > > wrote:
> > > > > Plasma 5.21 has a feature freeze in a few days on the 7th January.
> > > > > If anything needs urgent attention from reviewers, please do reply
> > > > > here ASAP so they can be prioritised.
> > > > > 
> > > > > David

Re: Plasma 5.21 repo and soft feature freeze

[Arjen Hiemstra]

On Tuesday, 5 January 2021 17:35:49 CET Jonathan Riddell wrote:
> I propose to exclude ksysguard from 5.21 and do a standalone release
> alongside it

We still need the ksysguard repo as it contains the ksystemstats daemon and 
all its plugins. We could disable building ksysguard GUI but that may get a 
bit hairy.

> 
> libksysguard would still be included as a dependency of plasma-systemmonitor
> 
> Jonathan
> 
> On Tue, 5 Jan 2021 at 16:15, Jonathan Riddell  wrote:
> > Git repos I have for inclusion in 5.21, wdiff compared to 5.20:
> > 
> > bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi
> > kactivitymanagerd kde-cli-tools kde-gtk-config kdecoration
> > kdeplasma-addons
> > kgamma5 khotkeys kinfocenter kmenuedit kscreen kscreenlocker ksshaskpass
> > ksysguard kwal
> > let-pam kwayland-integration kwayland-server kwin kwrited libkscreen
> > libksysguard milou oxygen plasma-browser-integration plasma-desktop
> > plasma-disks plasma-integration plasma-nano plasma-nm plasma-pa
> > plasma-phone-components plasma-sdk
> > {+plasma-systemmonitor+} plasma-tests plasma-thunderbolt plasma-vault
> > plasma-workspace plasma-workspace-wallpapers plymouth-kcm
> > polkit-kde-agent-1 powerdevil {+qqc2-breeze-style+} sddm-kcm
> > systemsettings
> > xdg-desktop-portal-kde
> > 
> > plasma-firewall should be included too, it's currently in network category
> > on invent.kde.org so that should be moved
> > 
> > Noah is qqc2-breeze-style to be included?  It has not yet passed
> > kdereview.
> > 
> > Dan Vratil what about plasma-pass?
> > 
> > plasma-systemmonitor is to be included.  This duplicates functionality
> > with ksysguard which is still included.  I'm not sure how to explain this
> > to packagers or users.
> > 
> > Stuff in the plasma category which is excluded:
> > kde-vdg-extras lancelot latte-dock oxygen-gtk plasma-active-window-control
> > plasma-bigscreen plasma-pass plasma-redshift-control plasma-simplemenu
> > user-manager
> > 
> > The list is made with this script which grabs everything in the plasma
> > category and excludes listed items
> > https://invent.kde.org/sdk/releaseme/-/blob/master/plasma/plasma-git-repos
> > 
> > Jonathan
> > 
> > 
> > 
> > 
> > On Sun, 3 Jan 2021 at 21:58, David Edmundson 
> > 
> > wrote:
> > > Plasma 5.21 has a feature freeze in a few days on the 7th January.
> > > If anything needs urgent attention from reviewers, please do reply
> > > here ASAP so they can be prioritised.
> > > 
> > > David

Re: plasma-systemmonitor in kdereview

[Arjen Hiemstra]

On Thursday, 1 October 2020 14:11:16 CET Harald Sitter wrote:
> 
> Cool stuff.
> 
> L10n is currently a bit incomplete.
> Notably
> - the pages files lack any localization at all and I'm also not sure how
> those could be best localized.

As an update to this, this should be fixed for 5.21. The pages are now treated 
as desktop files and include the translations once things have been extracted.

Since that was as far as I know the last major issue raised during review and 
we did the release yesterday it has now been moved to Plasma proper.

Thank you everyone who reviewed.

- Arjen

> 
> HS

Re: plasma-systemmonitor in kdereview

[Arjen Hiemstra]

On Friday, 2 October 2020 17:10:36 CEST Carl Schwan wrote:
> 
> Plasma System Monitor looks quite good, but it doesn't look like it is
> navigable with the keyboard only. I know that some of the issues are caused
> by Kirigami and Qml but it looks like many custom components can't get any
> focus with tab and need the mouse to work.
> 

As an update to this, I did a first pass to improve keyboard navigation, now in 
"view" mode things should work correctly, with everything that should get 
focus receiving focus, including the applications table on the overview page. 
As said before, the edit mode is a different beast and we're not yet entirely 
sure how to handle keyboard for that.

- Arjen

Re: plasma-systemmonitor in kdereview

[Arjen Hiemstra]

On Monday, 19 October 2020 00:28:38 CEST Albert Astals Cid wrote:
> How serious are these cmake warnings? http://paste.debian.net/1167754/

I've seen those before; apparently the result is that there's no autogenerated 
appdata for the sensor faces. Not sure how important that is to be honest. At 
least the package itself installs properly.

> I'd personally would suggest to remove these default values from 
KillDialog.qml

Done in [1]

> I guess i'm running a too old version of some dependency?
>  
> "file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde
> .ksysguard.processtable/contents/ui/FullRepresentation.qml:127:18:TypeProces
> sTableViewunavailable"
> "file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde
> .ksysguard.processtable/contents/ui/ProcessTableView.qml:97:9:Cannotassignto
> non-existentproperty\"flatList\"" Would make sense to mark that in the
> cmakelists you think? or is it just supposed to be used with plasma master
> in sync?

Actually, the intention was to be able to build against Plasma 5.20. The tree 
view support bits were only added in master though and we apparently forgot to 
check that it still works with 5.20. I've fixed that also in [1]

[1]: https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/56

Re: plasma-systemmonitor in kdereview

[Arjen Hiemstra]

On Friday, 2 October 2020 17:10:36 CEST Carl Schwan wrote:
> Le jeudi, octobre 1, 2020 11:36 AM, Arjen Hiemstra  a 
écrit :
> > Hello,
> > 
> > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It
> > can be found at https://invent.kde.org/plasma/plasma-systemmonitor .
> > 
> > plasma-systemmonitor is a new system monitor UI built with Kirigami. It
> > makes use of the ksystemstats daemon and the faces system for system
> > monitor plasmoids that were both introduced in Plasma 5.19.
> > 
> > Our current plan is to do a "preview release" alongside Plasma 5.20, then
> > have it be an official part of Plasma with 5.21.
> 
> Plasma System Monitor looks quite good, but it doesn't look like it is
> navigable with the keyboard only. I know that some of the issues are caused
> by Kirigami and Qml but it looks like many custom components can't get any
> focus with tab and need the mouse to work.

That's a good point, I think for a first pass I'd ensure that normal "viewing" 
works. Making the edit mode work with keyboard is going to be another thing 
entirely since that very much relies on drag and drop currently.

> 
> It is also normal for Table component to import private api from
> qqc2-desktop-style framework?

Normal, no. Required, yes unfortunately. When this was written there was no 
header control available. And even now if we port to HorizontalHeaderView we'd 
probably need the private import since the API of HorizontalHeaderView is 
severely lacking, so we'd need to replace the delegate which means we'd need 
some way of getting the system-styled header item.

> 
> https://invent.kde.org/plasma/plasma-systemmonitor/-/blob/master/src/table/F
> irstCellDelegate.qml#L13
> 
> Cheers,
> Carl
> 
> > Cheers,
> > Arjen

Re: plasma-systemmonitor in kdereview

[Arjen Hiemstra]

On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote:
> On 01.10.20 11:36, Arjen Hiemstra wrote:
> > Hello,
> > 
> > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It
> > can be found at https://invent.kde.org/plasma/plasma-systemmonitor .
> > 
> > plasma-systemmonitor is a new system monitor UI built with Kirigami. It
> > makes use of the ksystemstats daemon and the faces system for system
> > monitor plasmoids that were both introduced in Plasma 5.19.
> > 
> > Our current plan is to do a "preview release" alongside Plasma 5.20, then
> > have it be an official part of Plasma with 5.21.
> 
> Cool stuff.
> 
> L10n is currently a bit incomplete.
> Notably
> - the pages files lack any localization at all and I'm also not sure how
> those could be best localized.

Yeah that is a good point. If we can somehow extract the strings from these 
files I think we can make it work. But that may need some custom scripting.

> - the 'configure columns' feature doesn't load the translated strings
> into the checkboxes

Huh, weird. They are being populated by i18n calls, wonder what's going on 
there.

> 
> On the subject of configure columns I feel like word wrapping would look
> better than eliding there https://i.imgur.com/RbAeUhH.png
> 
> Something is astray with memory calculation. See konsole which is
> somehow listed as 2.6gib https://i.imgur.com/MjIpj3O.png but its actual
> children aren't getting nowhere near that number. I'm guessing it's
> because even detached processes (notably vscode here) are in the same
> cgroup? If so we probably can't do much about this?
> 

There's two things going on here I expect: everything started from konsole 
will be part of the konsole cgroup unless started through kstart5 or a similar 
tool that explicitly moves things to a new cgroup. I doubt this is solvable 
without patching all major shells. 

The other thing is that the "memory" column here is what is called "Total 
Memory" in KSysGuard, which is the process' private memory with the shared 
memory added divided over the processes that share that memory. This provides 
a more accurate number for the actual memory usage of the process, but does 
mean that it will most likely seem like it suddenly uses more memory, since 
the "memory" in KSysGuard is only the private memory.

> The table highlights are getting messed up when new apps appear/disappear.
> New app appears: https://i.imgur.com/tacWeoI.png mind that suddenly the
> ksysguard memory cell is selected as well. More or less the same happens
> when a process disappears. The cells seem somewhat random though Memory
> is almost always a highlighted one.

Ugh, I thought we fixed that. The trouble here is that QML's TableView has a 
bug where certain bindings aren't properly reevaluated. We have a workaround 
in place but apparently it doesn't work in all cases. :/

> 
> Sometimes the CPU column shows nan% for new apps. Happens a lot with
> bustle for me. In fact, sometimes I have two entries one of which is
> nan% for all eternity https://i.imgur.com/HLavLsI.png

The lingering one is odd, but may have something to do with cgroups not 
getting cleaned up properly. If you can reproduce and provide the output of 
systemd-cgls that would be helpful.

> 
> Possibly related: when editing the Processes page and discarding all
> changes the R/W columns show negative values for a second or two.
> https://i.imgur.com/amrfewG.png

Yeah I've seen that happen as well, it has something to do with the underlying 
ProcessCore processes not being updated yet I expect. This probably also 
causes the NaN above, since the application table currently uses the sum of 
all values of the processes to display values.

> 
> Also the columns in the processes page lack labels.

Gah. And applications works correctly?

> 
> HS

plasma-systemmonitor in kdereview

[Arjen Hiemstra]

Hello,

I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can 
be found at https://invent.kde.org/plasma/plasma-systemmonitor .

plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes 
use of the ksystemstats daemon and the faces system for system monitor 
plasmoids that were both introduced in Plasma 5.19.

Our current plan is to do a "preview release" alongside Plasma 5.20, then have 
it be an official part of Plasma with 5.21.

Cheers,
Arjen

Re: KSysguard - CGroup functionality breakage

[Arjen Hiemstra]

On Wednesday, 19 August 2020 12:29:21 CEST Ben Cooksley wrote:
> Hi all,
> 
> Recently functionality was introduced to KSysguard to allow it to
> interact with Linux CGroups.
> 
> Unfortunately when this change was made the code in question used
> classes/functionality that was introduced in Qt 5.15. This has had the
> effect of breaking the CI system as can be observed in the following
> Dependency Builds:
> 
> https://build.kde.org/job/Administration/job/Dependency%20Build%20Extragear%
> 20kf5-qt5%20SUSEQt5.14/32/console
> 
> Could someone please take a look?

It was decided a while ago that Plasma 5.20 is going to depend on Qt 5.15. See 
also https://mail.kde.org/pipermail/plasma-devel/2020-July/117989.html . 
libksysguard isn't the first one to use Qt 5.15 only features, but I suppose it 
is the first one that other things depend upon. 

I don't really know what the policy is here, so I made https://invent.kde.org/
plasma/libksysguard/-/merge_requests/61 to restore 5.14 support, since I can 
imagine updating all the extragear things to Qt 5.15 right now isn't ideal.

- Arjen

> 
> Thanks,
> Ben

Re: merge request and issue notifications to this list?

[Arjen Hiemstra]

On Wednesday, 29 July 2020 14:16:59 CEST Bhushan Shah wrote:
> Hello everyone!
> 
> KDE sysadmin team introduced the activity filter, which allows us to
> have the MR, commits and issues related notifications to plasma-devel or
> list of our choice.
> 
> This is proposal to enable it for plasma/* repositories to this list. As
> per specified mailing list rules [2], we should discuss this with-in
> mailing list and if no objections are raised within 72 hours. We can
> enable it.
> 
> If you have any ack/nack regarding this, please reply to this thread.
> 
> [2] https://invent.kde.org/sysadmin/activityfilter#mailing-list-rules

Personally, I do not really see what it adds. Doing "watch all" on the plasma 
group on GitLab is easy enough (easier than subscribing to a mailing list in 
my opinion). Sending all mails for the plasma group here just means any actual 
discussion gets drowned out between all the MR discussion mails.

- Arjen

A new UI for KSysGuard

[Arjen Hiemstra]

Hi,

It's been mentioned a few times already over the past, but we have been 
working on a new UI for KSysGuard over the past year. With landing most of the 
base work for Plasma 5.19 the new UI has been split to its own repo and can be 
found at https://invent.kde.org/ahiemstra/ksysguardqml .

The long term the plan is to replace the current KSysGuard UI with this new 
UI, but I don't know yet for what version we will do that. Right now we are 
working on polishing some of the UI elements as well as performance 
improvements to the page editing UI.

Cheers,
Arjen

Re: Gitlab and plasma dev

[Arjen Hiemstra]

On Wednesday, 27 May 2020 20:11:25 CEST David Edmundson wrote:
> One thing I'm missing when I'm doing reviews is I don't have a nice way to
> separate merge requests that need review, and merge requests that are
> awaiting changes.
> 
> I think this could be achieved with a label, that reviewers can set and
> authors can clear when they're ready.
> Somehow it's possible to create a label that covers all of Plasma as the
> VDG have one already.

Maybe we can even go one step further and also make an "accepted" label or 
some such? That would remove the need for people to comment, instead you can 
just apply the label, which should still generate notifications, unlike 
reactions.

- Arjen

> 
> Would that workflow work for other devs?
> 
> David

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

[Arjen Hiemstra]

ahiemstra requested changes to this revision.
ahiemstra added a comment.
This revision now requires changes to proceed.


  Hmm, this is good idea, I'm not really happy about the implementation though. 
It's all C code whereas the rest of the helper is C++. It also relies very 
heavily on magic numbers now.
  
  I think a much simpler implementation would be to split each line on " ", 
select the fields we want and clean them up.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29808

To: dkorth, ahiemstra
Cc: ahiemstra, jpalecek, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29630: Use the new KSysGuard namespace for KSysGuard related targets

[Arjen Hiemstra]

ahiemstra closed this revision.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29630

To: ahiemstra, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29760: Replace MapProxySource with some javascript code

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:1d8f9a9024c0: Replace MapProxySource with some javascript 
code (authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29760?vs=82870&id=82911

REVISION DETAIL
  https://phabricator.kde.org/D29760

AFFECTED FILES
  faces/import/SensorFace.qml

To: ahiemstra, #plasma, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29760: Replace MapProxySource with some javascript code

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  MapProxySource has only been added to QuickCharts master so is not
  available in 5.70, so we cannot use it here. So replicate it using a bit
  of JavaScript code.

TEST PLAN
  Now works without 5.71

REPOSITORY
  R111 KSysguard Library

BRANCH
  no_mapproxy

REVISION DETAIL
  https://phabricator.kde.org/D29760

AFFECTED FILES
  faces/import/SensorFace.qml

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29688: Exclude all loop devices from partition and disk sensors

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:f4e2c2022cd7: Exclude all loop devices from partition and 
disk sensors (authored by ahiemstra).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29688?vs=82738&id=82773

REVISION DETAIL
  https://phabricator.kde.org/D29688

AFFECTED FILES
  ksysguardd/Linux/diskstat.c
  ksysguardd/Linux/diskstats.c

To: ahiemstra, #plasma, davidedmundson
Cc: IlyaBizyaev, anthonyfieroni, jriddell, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29721: Add context to translated strings and clarify some strings

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:857eff12328e: Add context to translated strings and 
clarify some strings (authored by ahiemstra).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29721?vs=82766&id=82771

REVISION DETAIL
  https://phabricator.kde.org/D29721

AFFECTED FILES
  plugins/global/ksgrd/ksgrdiface.cpp
  plugins/global/nvidia/nvidia.cpp
  plugins/process/network/network.cpp

To: ahiemstra, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29721: Add context to translated strings and clarify some strings

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Many of the shorter strings are not really informative, so add context
  so translators can figure out what they mean. Some of the strings were
  also wrong, those have been corrected as well.

TEST PLAN
  Still compiles.

REPOSITORY
  R106 KSysguard

BRANCH
  translation_context

REVISION DETAIL
  https://phabricator.kde.org/D29721

AFFECTED FILES
  plugins/global/ksgrd/ksgrdiface.cpp
  plugins/global/nvidia/nvidia.cpp
  plugins/process/network/network.cpp

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29688: Ignore mount paths that start with '/snap/'

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82738.
ahiemstra added a comment.


  - Exclude all loop devices from partition and disk sensors

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29688?vs=82682&id=82738

BRANCH
  ignore_snap_partitions

REVISION DETAIL
  https://phabricator.kde.org/D29688

AFFECTED FILES
  ksysguardd/Linux/diskstat.c
  ksysguardd/Linux/diskstats.c

To: ahiemstra, #plasma, davidedmundson
Cc: IlyaBizyaev, anthonyfieroni, jriddell, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29688: Ignore mount paths that start with '/snap/'

[Arjen Hiemstra]

ahiemstra added a comment.


  In D29688#669867 , @anthonyfieroni 
wrote:
  
  > Should it /var/lib/flatpak (or just /flatpak/) be included as well?
  
  
  Flatpak doesn't use mounts for this as far as I can tell, or at least they 
don't show up in mtab. So flatpak does not cause problems.
  
  In D29688#669924 , @IlyaBizyaev 
wrote:
  
  > Maybe also /var/lib/docker?
  
  
  Docker mounts already seem to be ignored, at least on my system.

REPOSITORY
  R106 KSysguard

BRANCH
  ignore_snap_partitions

REVISION DETAIL
  https://phabricator.kde.org/D29688

To: ahiemstra, #plasma, davidedmundson
Cc: IlyaBizyaev, anthonyfieroni, jriddell, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29688: Ignore mount paths that start with '/snap/'

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Apparently, each snap is mounted as a squashfs file. This causes a lot
  of sensors to appear if many snaps are installed, with the potential to
  cause major slowdowns.
  
  Since there is no way of identifying these mounts other than their path,
  check to see if the path starts with '/snap/' and if so, exclude it.

TEST PLAN
  Snaps are excluded from the list of sensors in KSysGuard.

REPOSITORY
  R106 KSysguard

BRANCH
  ignore_snap_partitions

REVISION DETAIL
  https://phabricator.kde.org/D29688

AFFECTED FILES
  ksysguardd/Linux/diskstat.c

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

[Arjen Hiemstra]

ahiemstra requested changes to this revision.
ahiemstra added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jpalecek wrote in SensorBrowser.cpp:53
> No, it only deletes the HostInfo structure. See the source 
> .
>  It doesn't disconnect anything. Nor does deleting `this`, as the Agent holds 
> the client as a bare pointer, it can't know that it ceased to exist. It isn't 
> even a `QPointer` (probably bc. `SensorClient` isn't a `QObject`).

I agree with Anthony though, if you delete a hostInfo it _should_ remove its 
connection. So it's better to move this code into a destructor for HostInfo.

> ksysguard.cpp:153
> +{
> +  if (KSGRD::SensorMgr) KSGRD::SensorMgr->disconnectClient(this);
> +}

Coding style: Single line ifs still need braces and should not be on a single 
line.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29616

To: jpalecek, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29630: Use the new KSysGuard namespace for KSysGuard related targets

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  The targets in the KF5 namespace have been deprecated. This updates the
  cmake files to use the new targets.

TEST PLAN
  Builds correctly with most recent libksysguard.

REPOSITORY
  R845 Plasma Vault

BRANCH
  ksysguard_targets

REVISION DETAIL
  https://phabricator.kde.org/D29630

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29628: Use the right targets for KSysGuard

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8ae9b561c82f: Use the right targets for KSysGuard 
(authored by ahiemstra).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29628?vs=82516&id=82522

REVISION DETAIL
  https://phabricator.kde.org/D29628

AFFECTED FILES
  CMakeLists.txt
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/systemmonitor/CMakeLists.txt
  runners/kill/CMakeLists.txt
  systemmonitor/CMakeLists.txt

To: ahiemstra, #plasma, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29628: Use the right targets for KSysGuard

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82516.
ahiemstra added a comment.


  - Also change system monitor plasmoid

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29628?vs=82513&id=82516

BRANCH
  ksysguard_targets

REVISION DETAIL
  https://phabricator.kde.org/D29628

AFFECTED FILES
  CMakeLists.txt
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/systemmonitor/CMakeLists.txt
  runners/kill/CMakeLists.txt
  systemmonitor/CMakeLists.txt

To: ahiemstra, #plasma, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

[Arjen Hiemstra]

ahiemstra requested changes to this revision.
ahiemstra added a comment.
This revision now requires changes to proceed.


  You need to change `find_package(KF5 REQUIRED COMPONENTS SysGuard)` to 
`find_package(KSysGuard CONFIG REQUIRED)` in the root CMakeLists file.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29626

To: meven, #plasma, ahiemstra
Cc: ahiemstra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29628: Use the right targets for KSysGuard

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Otherwise the build fails when things try to link to KF5::SysGuard etc.

TEST PLAN
  Builds again

REPOSITORY
  R120 Plasma Workspace

BRANCH
  ksysguard_targets

REVISION DETAIL
  https://phabricator.kde.org/D29628

AFFECTED FILES
  CMakeLists.txt
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/systemmonitor/CMakeLists.txt
  runners/kill/CMakeLists.txt
  systemmonitor/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29623: Fix Warning about KF5::KSysGuard target being deprecated

[Arjen Hiemstra]

ahiemstra added a comment.


  Uh, I'm not sure how this fixes anything? It'll remove the warning but it 
means anything using the previous KF5:: namespaced targets is now broken. So 
this at least needs a follow up to change those usages.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29623

To: meven, #plasma, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29529: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:fc35d85131ed: Use INTERFACE IMPORTED target type instead 
of ALIAS for compatibility targets (authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29529?vs=82263&id=82503

REVISION DETAIL
  https://phabricator.kde.org/D29529

AFFECTED FILES
  KF5SysGuardConfig.cmake.in

To: ahiemstra, #plasma, ngraham, kmaterka
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

[Arjen Hiemstra]

ahiemstra added a comment.


  Please see if D29529  resolves it.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29302

To: ahiemstra, #plasma, davidedmundson
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29529: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Apparently IMPORTED_GLOBAL is a 3.11 feature and Neon uses 3.10

TEST PLAN
  Use CMake 3.10, plasma-workspace compiles again.

REPOSITORY
  R111 KSysguard Library

BRANCH
  ancient_cmake_fix

REVISION DETAIL
  https://phabricator.kde.org/D29529

AFFECTED FILES
  KF5SysGuardConfig.cmake.in

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

[Arjen Hiemstra]

ahiemstra added a comment.


  Which version of CMake are you using? I needed to promote the imported 
KSysGuard targets to "global" using set_target_property. Without that, I saw 
similar errors. The IMPORTED_GLOBAL property was added in CMake 3.11.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29302

To: ahiemstra, #plasma, davidedmundson
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29507: Use KSysGuard namespace for KSysGuard targets

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:dbb0b515364b: Use KSysGuard namespace for KSysGuard 
targets (authored by ahiemstra).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29507?vs=82204&id=82207

REVISION DETAIL
  https://phabricator.kde.org/D29507

AFFECTED FILES
  CMakeLists.txt
  gui/CMakeLists.txt
  kstats/CMakeLists.txt
  libkstats/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/nvidia/CMakeLists.txt
  plugins/process/network/CMakeLists.txt
  plugins/process/nvidia/CMakeLists.txt

To: ahiemstra, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29507: Use KSysGuard namespace for KSysGuard targets

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  With D29302  all KSysGuard targets have 
been placed in the KSysGuard namespace
  and the KF5 versions deprecated. This changes KSysGuard to use the new
  namespace. In addition, it renames the libkstats target from 
"PW5::KSysGuardBackend"
  to "KSysGuard::StatsBackend".

TEST PLAN
  Things still compile.

REPOSITORY
  R106 KSysguard

BRANCH
  library_targets

REVISION DETAIL
  https://phabricator.kde.org/D29507

AFFECTED FILES
  CMakeLists.txt
  gui/CMakeLists.txt
  kstats/CMakeLists.txt
  libkstats/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/nvidia/CMakeLists.txt
  plugins/process/network/CMakeLists.txt
  plugins/process/nvidia/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:b1e9126e2087: Use KSysGuard namespace for KSysGuard 
library targets (authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29302?vs=82193&id=82194

REVISION DETAIL
  https://phabricator.kde.org/D29302

AFFECTED FILES
  CMakeLists.txt
  KF5SysGuardConfig.cmake.in
  KSysGuardConfig.cmake.in
  autotests/CMakeLists.txt
  ksgrd/CMakeLists.txt
  lsofui/CMakeLists.txt
  processcore/CMakeLists.txt
  processui/CMakeLists.txt
  signalplotter/CMakeLists.txt

To: ahiemstra, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Arjen Hiemstra]

ahiemstra added a comment.


  > This is a major identity change better suited for Plasma 6.
  
  I disagree. I would like Plasma 6 to be a really uneventful release, not one 
that has a whole bunch of changes. There's going to be enough breakage as it 
is, let's do things that can be done now, now, instead of waiting for some 
nebulous "Plasma 6".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: ahiemstra, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82193.
ahiemstra added a comment.


  - Add backward-compatibility package config file

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29302?vs=81594&id=82193

BRANCH
  lib_namespace

REVISION DETAIL
  https://phabricator.kde.org/D29302

AFFECTED FILES
  CMakeLists.txt
  KF5SysGuardConfig.cmake.in
  KSysGuardConfig.cmake.in
  autotests/CMakeLists.txt
  ksgrd/CMakeLists.txt
  lsofui/CMakeLists.txt
  processcore/CMakeLists.txt
  processui/CMakeLists.txt
  signalplotter/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28140: Add a declarative plugin to ProcessCore

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:82879c590d99: Add a declarative plugin to ProcessCore 
(authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28140?vs=78360&id=82182

REVISION DETAIL
  https://phabricator.kde.org/D28140

AFFECTED FILES
  processcore/CMakeLists.txt
  processcore/declarative/CMakeLists.txt
  processcore/declarative/ProcessEnums.cpp
  processcore/declarative/ProcessEnums.h
  processcore/declarative/ProcessPlugin.cpp
  processcore/declarative/ProcessPlugin.h
  processcore/declarative/qmldir
  processcore/process_controller.cpp
  processcore/process_controller.h
  tests/process/test_process.qml

To: ahiemstra, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:5cfc09fd4463: Add KSysGuard::Sensors library (authored by 
ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=82082&id=82181

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma, davidedmundson
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra accepted this revision.
ahiemstra added a comment.
This revision is now accepted and ready to land.


  Let's get this in and fix anything broken in follow ups.

REPOSITORY
  R111 KSysguard Library

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28333: Add a new daemon for stats monitoring

[Arjen Hiemstra]

ahiemstra accepted this revision.
ahiemstra added a comment.


  Let's do this.

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28333

To: davidedmundson, #plasma, mart, ngraham, ahiemstra
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82082.
ahiemstra added a comment.


  Maybe right now?

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=82081&id=82082

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82081.
ahiemstra added a comment.


  Urgh arc

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=82080&id=82081

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82080.
ahiemstra added a comment.


  - Correct Vlad's name in a few more places
  - Make comments in SensorInfo_p.h a bit more useful

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=81577&id=82080

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29437: Use font: instead of font.pointSize: where possible

[Arjen Hiemstra]

ahiemstra added a comment.


  Actually I'm fairly sure `font: someFont` is still going to work, it's 
`font.something: somethingElse` syntax that's going away, instead becoming 
something like `font: Font { something: somethingElse }`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29437

To: ngraham, cblack, #plasma
Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> mart wrote in SensorFaceController.h:47
> how would that work in current faces that have this binded to that single big 
> number inside graphs?

You'd use the first one from the list? If we want to limit it I think we need 
to limit it in the UI, not in the backend, since that leads to a complete 
inability to do anything different.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> mart wrote in SensorFaceController.cpp:247
> perhaps line chart?

I was more thinking something along the lines of a new face that's either 
completely empty or displays a "not configured" message.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:a6bf4a67f099: ColorUtils: Use const ref for 
QColor/QJSValue, fix code style (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29046?vs=80747&id=81870

REVISION DETAIL
  https://phabricator.kde.org/D29046

AFFECTED FILES
  src/colorutils.cpp
  src/colorutils.h

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28487: Redesign of system monitor plasmoids

[Arjen Hiemstra]

ahiemstra added a comment.


  In D28487#661262 , @ksmanis wrote:
  
  > Is there an ETA for this? Is it worth fixing any bugs in the old applets in 
the meantime?
  
  
  We'd really like this in 5.19, but it's a pretty large set of changes in 
multiple parts of the stack. If you want it sooner extra reviews would be nice. 
:)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28487

To: mart, #plasma
Cc: ngraham, ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> ConfigAppearance.qml:90
> +}
> +RowLayout {
> +Kirigami.FormData.label: i18n("Presets:")

It would probably be nice if we can make this a GridLayout with flow bound to 
the FormLayout's wide setting. Right now, if the layout becomes less wide, 
these buttons will be pushed out of bounds.

> ConfigAppearance.qml:127
> +
> +RowLayout {
> +Kirigami.FormData.label: i18n("Display Style:")

As above, these also have a tendency to get pushed out of bounds.

> SensorFaceController.cpp:43
> +
> +auto list = 
> KPackage::PackageLoader::self()->listPackages(QStringLiteral("Plasma/SensorApplet"));
> +// NOTE: This will diable completely the internal in-memory cache 

"Plasma/SensorApplet" should probably be changed to something non-plasma?

> SensorFaceController.cpp:77
> +clear();
> +QList plugins = 
> KPackage::PackageLoader::self()->findPackages(QStringLiteral("Plasma/Applet"),
>  QString(), [](const KPluginMetaData &plugin) {
> +return plugin.value(QStringLiteral("X-Plasma-RootPath")) == 
> QStringLiteral("org.kde.plasma.systemmonitor");

Similar to above, does it still make sense to use "Plasma/Applet" here?

> SensorFaceController.cpp:182
> +//TODO: add i18n context object
> +QQmlContext *context = new QQmlContext(engine);
> +QObject *guiObject = component->beginCreate(context);

This seems to be unused?

> SensorFaceController.cpp:247
> +
> +setFaceId(d->appearanceGroup.readEntry("chartFace", 
> QStringLiteral("org.kde.ksysguard.piechart")));
> +}

I think we should have a "default face" for when no specfic face has been set 
yet, that isn't a pie chart. At least for ksysguard the default pie chart feels 
weird.

> SensorFaceController.cpp:415
> +
> +d->faceMetadata = new KDesktopFile(d->facePackage.path() + 
> QStringLiteral("metadata.desktop"));
> +

Can we define this in the package and then use filePath("metadata") or so?

> SensorFaceController.cpp:476
> +d->faceConfigUi = 
> d->createConfigUi(QStringLiteral(":/FaceDetailsConfig.qml"),
> +{{QStringLiteral("controller"), QVariant::fromValue(this)},
> + {QStringLiteral("source"), d->facePackage.filePath("ui", 
> QStringLiteral("Config.qml"))}});

Code style is a bit messed up here. Maybe run clang-format over the entire 
thing?

> SensorFaceController.h:47
> +Q_PROPERTY(QString faceId READ faceId WRITE setFaceId NOTIFY 
> faceIdChanged)
> +Q_PROPERTY(QString totalSensor READ totalSensor WRITE setTotalSensor 
> NOTIFY totalSensorChanged)
> +Q_PROPERTY(QStringList sensorIds READ sensorIds WRITE setSensorIds 
> NOTIFY sensorIdsChanged)

I think it would be a good idea to make this a list of ids as well. My current 
use case would be the "used/total" version of the pie chart that is used in 
KSysGuardQML, which would need two "total" sensors.

> SensorFaceController.h:50
> +Q_PROPERTY(QStringList sensorColors READ sensorColors WRITE 
> setSensorColors NOTIFY sensorColorsChanged)
> +Q_PROPERTY(QStringList textOnlySensorIds READ textOnlySensorIds WRITE 
> setTextOnlySensorIds NOTIFY textOnlySensorIdsChanged)
> +

Hmm, maybe these names are a little too use-case specific? I wonder if it would 
make sense to name them "highPrioritySensorsIds", "sensorIds", 
"lowPrioritySensorIds" or so.

> SensorFaceController.h:76
> +
> +//TODO: just QQuickItem
> +QQuickItem *fullRepresentation();

This seems superfluous?

> BarChart.qml:38
> +
> +stacked: plasmoid.nativeInterface.faceConfiguration.barChartStacked
> +

This should use the controller.

> Config.qml:50
> +}
> +Controls.SpinBox {
> +id: rangeFromSpin

All these are missing `editable: true` making it rather annoying to edit.

Also, we probably should set `from: -` and `to: ` or so on all 
of them, the minimum and maximum range is rather undefined.

> FullRepresentation.qml:58
> +
> +Faces.ExtendedLegend {
> +Layout.fillWidth: true

This import seems to be missing?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Instead of using KF5 which is wrong since KSysGuard isn't part of
  frameworks.
  
  This needs a follow up patch to the ksysguard repo to make it use the new
  namespace.

TEST PLAN
  Still builds

REPOSITORY
  R111 KSysguard Library

BRANCH
  lib_namespace

REVISION DETAIL
  https://phabricator.kde.org/D29302

AFFECTED FILES
  CMakeLists.txt
  KF5SysGuardConfig.cmake.in
  KSysGuardConfig.cmake.in
  autotests/CMakeLists.txt
  ksgrd/CMakeLists.txt
  lsofui/CMakeLists.txt
  processcore/CMakeLists.txt
  processui/CMakeLists.txt
  signalplotter/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 81577.
ahiemstra added a comment.


  Don't eat the lib Arc

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=81576&id=81577

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 81576.
ahiemstra added a comment.


  - Don't expose private SensorInfo in public interface of SensorQuery

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=80758&id=81576

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorQuery.h
  sensors/declarative/CMakeLists.txt

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> SensorFaceController.h:42
> +
> +class FACES_EXPORT SensorFaceController : public QObject
> +{

Can you place this class (and related classes) in the KSysGuard namespace? Then 
it would match the rest of the libraries.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> CMakeLists.txt:52
>  KF5::I18n
> +KF5::Package
> +KF5::ConfigCore

This is no longer needed.

> CMakeLists.txt:5
>  
> -target_link_libraries(SensorsPlugin Qt5::Qml KSysGuard::Sensors 
> KF5::ProcessCore)
> +target_link_libraries(SensorsPlugin Qt5::Qml KSysGuard::Sensors 
> KF5::ProcessCore KF5::Package KF5::ConfigCore KF5::ConfigGui)
>  

This is no longer needed.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> SensorFaceController.cpp:21
> +#include "SensorFaceController.h"
> +#include "SensorFaceController_p.h"
> +#include "SensorFace_p.h"

This file is missing.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29127: Account for top and bottom margin in default card height

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:a9c8cb612992: Account for top and bottom margin in 
default card height (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29127?vs=80975&id=80979

REVISION DETAIL
  https://phabricator.kde.org/D29127

AFFECTED FILES
  src/controls/Card.qml
  src/controls/templates/AbstractCard.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29129: Remove implicitHeight from cards in main page

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:40f6034f35c1: Remove implicitHeight from cards in main 
page (authored by ahiemstra).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29129?vs=80978&id=80980

REVISION DETAIL
  https://phabricator.kde.org/D29129

AFFECTED FILES
  src/data/contents/ui/MainPage.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart

D29129: Remove implicitHeight from cards in main page

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Card now has a correct default height.
  
  Depends on D29127 

TEST PLAN
  Main page cards display correctly, both in single and double column mode.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  cardheight

REVISION DETAIL
  https://phabricator.kde.org/D29129

AFFECTED FILES
  src/data/contents/ui/MainPage.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart

D29127: Account for top and bottom margin in default card height

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This makes Card account for the negative top and bottom margin when used
  in its default Banner height. In addition, only add top and bottom
  padding when there is a content item. This ensures that cards without
  contents have a correct default height that doesn't leave any gaps at
  the bottom.
  
  Most prominently, this removes the need for any height specification in
  the new Kirigami Gallery main page and fixes the cards' height when
  displaying only one column.

TEST PLAN
  All cards in Kirigami Gallery display correctly now.

REPOSITORY
  R169 Kirigami

BRANCH
  cardheight

REVISION DETAIL
  https://phabricator.kde.org/D29127

AFFECTED FILES
  src/controls/Card.qml
  src/controls/templates/AbstractCard.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
ahiemstra marked an inline comment as done.
Closed by commit R169:5dfa3e9e983b: Various fixes to new Cards (authored by 
ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29092?vs=80962&id=80964

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami, ndavis, mart
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra marked an inline comment as done.
ahiemstra added inline comments.

INLINE COMMENTS

> ndavis wrote in sdf.glsl:199
> I played around with this value and found that 0.625 was pretty decent. It 
> slightly improved the corners in bigscreen and made the corners of 
> Kirigami.Card a bit smoother without making the lines blurry. Top: 0.625; 
> Bottom: 0.4
> F8253710: Screenshot_20200422_125706.png 
> 

Great, I'll use that.

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami, ndavis
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 80962.
ahiemstra added a comment.


  - Use a slightly higher smoothing value.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29092?vs=80891&id=80962

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami, ndavis
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra added a comment.


  In D29092#654887 , @ndavis wrote:
  
  > This has a ShadowedRectangle underneath and a transparent Rectangle with a 
border on top: F8253587: Screenshot_20200422_115104.png 

  >
  > Is there nothing that can be done about that? I have to deal with similar 
issues when working with SVGs, so I'll understand if you can't. We'll just have 
to slightly shrink the rectangle underneath instead.
  
  
  Not really. These kinds of artifacts occur because you're blending two 
semi-transparent pixels together, so the pixel from the rectangle below ends up 
shining through the pixel above it.
  
  That said, why are you using a second rectangle with a border instead of just 
adding a border to the shadowedrectangle?

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami, ndavis
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28333: Add a new daemon for stats monitoring

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> client.cpp:45
> +{
> +for (auto sensor : m_subscribedSensors) {
> +sensor->unsubscribe();

This should probably use `qAsConst`.

> ksysguarddaemon.cpp:76
> +auto factory = qobject_cast(plugin);
> +if (!factory) {
> +return;

Should we do some error logging here? Might help future plugin development.

> ksysguarddaemon.cpp:93
> +m_providers.append(provider);
> +for (auto container : provider->containers()) {
> +m_containers[container->id()] = container;

const auto containers = provider->containers();
  for(auto container : containers) {

> ksysguarddaemon.cpp:111
> +SensorInfoMap sensors;
> +for (auto c : m_containers) {
> +for(auto o : c->objects()) {

`qAsConst(m_containers)`

> ksysguarddaemon.cpp:112
> +for (auto c : m_containers) {
> +for(auto o : c->objects()) {
> +for (auto p : o->sensors()) {

Like above, objects() should be in a const variable. (Also for sensors on the 
line below).

> ksysguarddaemon.cpp:201
> +
> +for (auto client: m_clients) {
> +client->sendFrame();

`qAsConst(m_clients)`

> mart wrote in AggregateSensor.cpp:199
> if this timer is needed for compression, shouldn't be the same timer always 
> restarted?
> if i call singleshot 10 times, iirc that slot will be invoked delayed 10 times

It's guarded with "m_dataChangeQueued" which only gets reset after the timer 
triggers.

> SensorContainer.cpp:64
> +connect(object, &QObject::destroyed, this, [object, this]() {
> +emit objectRemoved(object); //FIXME this is going to crash
> +});

Uh, so shouldn't we fix this?

> SensorContainer.h:56
> + */
> +void addSubObject(SensorObject *object);
> +Q_SIGNALS:

Maybe move this to private with `friend class SensorObject`? Though I don't 
really see why this is internal only. Also probably should rename it to 
`addObject`?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28333

To: davidedmundson, #plasma
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra added a comment.


  Urgh, I knew there was a point to that damn fwidth() call. As far as I can 
tell this version has about the same visual appearance without it changing 
dependent on resolution.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 80891.
ahiemstra added a comment.


  - Restore fwidth() call in shader, tweak smoothing values more

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29092?vs=80885&id=80891

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 80885.
ahiemstra added a comment.


  - Remove sdf_polygon, it is unused and causes breakage on Android

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29092?vs=80878&id=80885

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 80878.
ahiemstra added a comment.


  - Slightly increase smoothing, to avoid too harsh corners

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29092?vs=80876&id=80878

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This contains various small fixes to the new Cards.
  
  - Still show the border of AbstractCard on Cards with images.
  - Round bottom corners of the banner when the card doesn't have any other 
contents.
  - Don't use fwidth for smoothing, instead just use a fixed value, this 
increases the accuracy of lines rendered by cards.
  - Fix batching test for ShadowedTexture, prevents cards being rendered with 
the wrong texture.

TEST PLAN
  The new Kirigami Gallery displays more correct now, though there are some 
layout issues that are not regressions.

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 80758.
ahiemstra added a comment.


  - clang-format sensors lib
  - Capture this rather than =

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=79072&id=80758

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Use const ref for QColor and QJSValue values.
  Clean up code style, lots of missing braces and spaces.
  Don't use std::map if no lookup by key actually happens.
  std::vector is a much less heavy-weight container.

TEST PLAN
  Things still work.

REPOSITORY
  R169 Kirigami

BRANCH
  styling

REVISION DETAIL
  https://phabricator.kde.org/D29046

AFFECTED FILES
  src/colorutils.cpp
  src/colorutils.h

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> mart wrote in SensorsPlugin.cpp:2
> also here

Same issue as above.

> mart wrote in SensorsPlugin.h:2
> shouldn't remove existing copyrights?

It's a new file, but for some reason Phab thinks it's copied from formatter.h 
(which it has nothing to do with).

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28141

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28625: Use ShadowedRectangle for Card backgrounds

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e770b0ddd2af: Use ShadowedRectangle for Card backgrounds 
(authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28625?vs=80735&id=80736

REVISION DETAIL
  https://phabricator.kde.org/D28625

AFFECTED FILES
  src/colorutils.cpp
  src/colorutils.h
  src/controls/AbstractCard.qml
  src/controls/Card.qml
  src/controls/ShadowedImage.qml
  src/controls/private/BannerImage.qml
  src/controls/private/DefaultCardBackground.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedtexturenode.cpp
  src/shadowedtexture.cpp

To: ahiemstra, #kirigami, #vdg, cblack, mart
Cc: mart, ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, 
domson, dkardarakos, apol, ahiemstra, davidedmundson

D28625: Use ShadowedRectangle for Card backgrounds

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 80735.
ahiemstra added a comment.


  - Rebase on most recent master
  - Use ShadowedRectangleNode for ShadowedTexture if source is not set
  - Use transparent color for BannerImage's ShadowedImage
  - Hide BannerImage scrim if source or title is not set
  - Don't set ShadowedTexture source if Image is not properly loaded
  - Add tintWithAlpha method to ColorUtils
  - Use new tintWithAlpha for border colors

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28625?vs=79491&id=80735

BRANCH
  card_shadowrect

REVISION DETAIL
  https://phabricator.kde.org/D28625

AFFECTED FILES
  src/colorutils.cpp
  src/colorutils.h
  src/controls/AbstractCard.qml
  src/controls/Card.qml
  src/controls/ShadowedImage.qml
  src/controls/private/BannerImage.qml
  src/controls/private/DefaultCardBackground.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedtexturenode.cpp
  src/shadowedtexture.cpp

To: ahiemstra, #kirigami, #vdg, cblack, mart
Cc: mart, ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, 
domson, dkardarakos, apol, ahiemstra, davidedmundson

D28625: Use ShadowedRectangle for Card backgrounds

[Arjen Hiemstra]

ahiemstra added a comment.


  In D28625#652529 , @mart wrote:
  
  > In D28625#642954 , @cblack wrote:
  >
  > > Looks like a nice visual improvement.
  > >
  > > Are the changes to the scenegraph stuff related? They don't look like a 
related change to making the Kirigami.Card use the ShadowedRectangle to me.
  >
  >
  > they should be, as far i know, a fix for the 1 pixel border that had some 
blurriness.
  >  @ahiemstra can you confirm?
  
  
  They're both things I encountered while implementing this. One is a crash 
fix, the other is indeed a fix for pixel correctness.

INLINE COMMENTS

> mart wrote in AbstractCard.qml:31
> as we have a ColorUtils class now, since i've seen this super long thing just 
> to make a color translucent many things, is maybe worth to have a 
> ColorUtils.opacity(Kirigami.Theme.highlightColor, 0.3) instead?

This basically does the same thing as Kirigami.Separator. I think it'd be good 
to have this entire thing in ColorUtils yeah.

REPOSITORY
  R169 Kirigami

BRANCH
  card_shadowrect

REVISION DETAIL
  https://phabricator.kde.org/D28625

To: ahiemstra, #kirigami, #vdg, cblack, mart
Cc: mart, ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, 
domson, dkardarakos, apol, ahiemstra, davidedmundson

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[Arjen Hiemstra]

ahiemstra accepted this revision.
ahiemstra added a comment.
This revision is now accepted and ready to land.


  Seems fine to me now. You didn't have a developer account right?

REPOSITORY
  R106 KSysguard

BRANCH
  acpi-energy

REVISION DETAIL
  https://phabricator.kde.org/D28127

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28625: [WIP] Use ShadowedRectangle for Card backgrounds

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added reviewers: Kirigami, VDG.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This switches cards to use ShadowedRectangle for their background. It also 
refreshes their
  design a bit, based on feedback from the VDG.
  
  Still WIP because of potential design issues and I'm not entirely happy with 
the code for
  the actual cards. Ideally I'd also move a bunch of this stuff to C++ but 
that'd involve a
  reimplementing a bunch of Control behaviour.

REPOSITORY
  R169 Kirigami

BRANCH
  card_shadowrect

REVISION DETAIL
  https://phabricator.kde.org/D28625

AFFECTED FILES
  src/controls/AbstractCard.qml
  src/controls/Card.qml
  src/controls/ShadowedImage.qml
  src/controls/private/BannerImage.qml
  src/controls/private/DefaultCardBackground.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedtexturenode.cpp

To: ahiemstra, #kirigami, #vdg
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28314: Allow setting separate corner radii for ShadowedRectangle

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:eb4e9064e7e4: Allow setting separate corner radii for 
ShadowedRectangle (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28314?vs=79075&id=79480

REVISION DETAIL
  https://phabricator.kde.org/D28314

AFFECTED FILES
  src/controls/ShadowedImage.qml
  src/kirigamiplugin.cpp
  src/scenegraph/shaders/shadowedborderrectangle.frag
  src/scenegraph/shaders/shadowedbordertexture.frag
  src/scenegraph/shaders/shadowedrectangle.frag
  src/scenegraph/shaders/shadowedtexture.frag
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  src/shadowedtexture.cpp
  src/shadowedtexture.h
  tests/ShadowedImageTest.qml
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami, mart
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> acpi.c:73
>  
> -void registerBatteryRate(int number, struct SensorModul *sm)
> +void registerBatteryEnergy(char name, int number, struct SensorModul *sm)
>  {

Uhm, this should be `const char *name` right? I don't really see how this can 
work otherwise.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28127

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28438: Add per-partition total and all partitions sensors

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:0fbf39bc37a7: Add per-partition total and all partitions 
sensors (authored by ahiemstra).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28438?vs=78903&id=79130

REVISION DETAIL
  https://phabricator.kde.org/D28438

AFFECTED FILES
  ksysguardd/Linux/diskstat.c
  ksysguardd/Linux/diskstat.h

To: ahiemstra, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[Arjen Hiemstra]

ahiemstra added a comment.


  Good stuff. Just two small comments.
  
  Additionally, you may be interested in https://phabricator.kde.org/D28333 , 
which will eventually replace ksysguardd and has a better API for sensors.

INLINE COMMENTS

> acpi.c:82
> +char name[ ACPIFILENAMELENGTHMAX ];
> +readTypeFile("/sys/class/power_supply/BAT%d/type", number, name, 
> sizeof(name));
> +

These two lines are now repeated in all "registerX" functions. Maybe move this 
to initAcpiBattery and pass it to each function as a parameter?

> acpi.c:163
>  if ( maximum > 0) {
> -state = charge * 100 / maximum;
> +state = charge/(double)(maximum/100);/* to get 0.1% changes */
>  }

You cast to double but then store it in a float, which implies a cast to float. 
Probably better to just cast to float directly. (Also applies to the functions 
below.)

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28127

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28314: Allow setting separate corner radii for ShadowedRectangle

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 79075.
ahiemstra added a comment.


  Rebase onto master, also support ShadowedTexture

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28314?vs=78574&id=79075

BRANCH
  shadowedrect_separatecorners

REVISION DETAIL
  https://phabricator.kde.org/D28314

AFFECTED FILES
  src/controls/ShadowedImage.qml
  src/kirigamiplugin.cpp
  src/scenegraph/shaders/shadowedborderrectangle.frag
  src/scenegraph/shaders/shadowedbordertexture.frag
  src/scenegraph/shaders/shadowedrectangle.frag
  src/scenegraph/shaders/shadowedtexture.frag
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  src/shadowedtexture.cpp
  src/shadowedtexture.h
  tests/ShadowedImageTest.qml
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 79072.
ahiemstra added a comment.


  - Fix qmldir file

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78985&id=79072

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28487: Upstream of the ksysguard based plasmoids

[Arjen Hiemstra]

ahiemstra added a comment.


  In D28487#639476 , @mart wrote:
  
  > should faces be still installed under .local/share/ksysguard/sensorapplet/ 
or under share/plasma?
  
  
  Ideally, I'd like to see them installed into share/ksysguard/faces or 
something similar. I want to try and reuse them for custom pages in the new 
KSysGuard UI.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28487

To: mart, #plasma
Cc: ahiemstra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D28383: Add PageRouter component

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> mart wrote in pagerouter.h:84
> how many routes an app would normally be going to have?
> 
> this seems really a thing for QQmlListProperty (which then each route must 
> become a qobject tough)
> so routes: [
> Route {
> 
>   name: "home"
>   component: homeComponent
>   cache: true
>   initialProperties: {"name": "value,...}
> 
> },
> Route {}
> ]
> 
> which kindof becomes similar to pagepoolaction (which i still think they can 
> be merged)

This is exactly what I was thinking. And if you mark it as default property you 
wouldn't even need to do the "routes: []" awkwardness.

> mart wrote in pagerouter.h:308
> quite ugly name..
> maybe isRouteActive

If you have routes as objects you could have an "active" property on the route, 
removing the need for this invokable.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28383

To: cblack, #kirigami, mart, davidedmundson
Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, mart

D28222: Add ShadowedImage and ShadowedTexture items

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:0c7ba88d3970: Add ShadowedImage and ShadowedTexture items 
(authored by ahiemstra).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28222?vs=78294&id=78987#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28222?vs=78294&id=78987

REVISION DETAIL
  https://phabricator.kde.org/D28222

AFFECTED FILES
  kirigami.qrc
  src/CMakeLists.txt
  src/controls/ShadowedImage.qml
  src/kirigamiplugin.cpp
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc
  src/scenegraph/shaders/header_desktop.glsl
  src/scenegraph/shaders/header_desktop_core.glsl
  src/scenegraph/shaders/header_es.glsl
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shaders/shaders.qrc
  src/scenegraph/shaders/shadowedborderrectangle.frag
  src/scenegraph/shaders/shadowedbordertexture.frag
  src/scenegraph/shaders/shadowedrectangle.frag
  src/scenegraph/shaders/shadowedrectangle.vert
  src/scenegraph/shaders/shadowedtexture.frag
  src/scenegraph/shadowedborderrectangle.frag
  src/scenegraph/shadowedborderrectangle_core.frag
  src/scenegraph/shadowedborderrectanglematerial.cpp
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedbordertexturematerial.h
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle.vert
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectangle_core.vert
  src/scenegraph/shadowedrectanglematerial.cpp
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/scenegraph/shadowedtexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.h
  src/scenegraph/shadowedtexturenode.cpp
  src/scenegraph/shadowedtexturenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  src/shadowedtexture.cpp
  src/shadowedtexture.h
  tests/ShadowedImageTest.qml

To: ahiemstra, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 78985.
ahiemstra added a comment.


  - Update zzag's last name

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78372&id=78985

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28438: Add per-partition total and all partitions sensors

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a "total" sensor for each partition that reports the total
  space for that partition. It also adds a new "all" category with sensors
  that report the used/free space for all partitions.

TEST PLAN
  New sesnors are available in KSysGuard

REPOSITORY
  R106 KSysguard

BRANCH
  partition_sensors

REVISION DETAIL
  https://phabricator.kde.org/D28438

AFFECTED FILES
  ksysguardd/Linux/diskstat.c
  ksysguardd/Linux/diskstat.h

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28314: Allow setting separate corner radii for ShadowedRectangle

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a "corners" grouped property that allows setting separate radii for
  the different corners of ShadowedRectangle. By default, these are ignored and
  instead the value of "radius" is used.

TEST PLAN
  The manual test has been updated, it should look like this:

REPOSITORY
  R169 Kirigami

BRANCH
  shadowedrect_separatecorners

REVISION DETAIL
  https://phabricator.kde.org/D28314

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/scenegraph/shadowedborderrectangle.frag
  src/scenegraph/shadowedborderrectangle_core.frag
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart