D21980: Fix ocasional crash on the touchpad kded

[Atul Bisht]

atulbi accepted this revision.
atulbi added a comment.


  Me too

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21980

To: aacid, atulbi, ngraham
Cc: ngraham, knambiar, atulbi, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21915: Fix crash in the touchpad kded

[Atul Bisht]

atulbi added a comment.


  In D21915#482877 , @aacid wrote:
  
  > In D21915#482182 , @knambiar 
wrote:
  >
  > > In D21915#482145 , @aacid 
wrote:
  > >
  > > > The other question is if "enabled" was ever the correct atom to check 
for
  > > >
  > > > libinput Tapping Enabled
  > >
  > >
  > > I'm fairly sure we were checking for `libinput Tapping Enabled` atom in 
the past, and so does GNOME: 
https://gitlab.gnome.org/GNOME/gtk/blob/master/gdk/x11/gdkdevicemanager-xi2.c#L410
  >
  >
  > I can't find any use of that, the current use of "enabled" was added by 
@atulbi
  
  
  Whoops... It should be "libinput Send Events Mode Enabled" or 
LIBINPUT_PROP_SENDEVENTS_ENABLED rather than enabled. my bad  ;) , Just 
replacing "enabled" fixes the issue :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21915

To: aacid
Cc: atulbi, knambiar, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

[Atul Bisht]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ecea8b93d997: [Touchpad KCM] Fix kded crashing at startup 
(authored by atulbi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21278?vs=58319=58343

REVISION DETAIL
  https://phabricator.kde.org/D21278

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h

To: atulbi, romangg, davidedmundson
Cc: fvogt, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

[Atul Bisht]

atulbi updated this revision to Diff 58319.
atulbi added a comment.


  - Now we have separate m_touchpadOffAtom for synaptics and Libinput. On 
Libinput, used m_enabled prop.
  - setTouchpadOff will be ignored on X Libinput.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21278?vs=58266=58319

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21278

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

[Atul Bisht]

atulbi added a comment.


  In D21278#466804 , @romangg wrote:
  
  > > by kded on key press other than Kded Keyboard shortcuts
  >
  > Do you mean it's sent on shortcut or not? Just wondering why I couldn't 
replicate the issue in my testing.
  
  
  kded5 did not crash until I pressed some key which is not Kded Keyboard 
shortcuts. Like Ctrl+Alt+T did not crash it, but just pressing any other key 
crashed it.
  Sending patch for it in a while.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21278

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

[Atul Bisht]

atulbi added a comment.


  In D21278#466801 , @davidedmundson 
wrote:
  
  > > m_connection seems to be having null or 0x0 value.
  >
  > Which means we're calling XcbAtom::atom after being constructed from the 
default constructor not the proper one.
  >
  > That doesn't sound right. If you can explain why we end up in this 
situation and it's legit, I'll accept, otherwise it looks like we're just 
treating a symptom.
  
  
  As Roman pointed out, X Libinput backend do not call `XcbAtom::intern` for 
m_touchpadOffAtom. Rightly said we're just treating a symptom.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21278

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

[Atul Bisht]

atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  When XcbAtom::atom() is called (by kded on key press other than Kded Keyboard 
shortcuts), m_connection seems to be having null or 0x0 value.
  Small check on m_connection solves the issue for me.

TEST PLAN
  kded5 do not crashed at startup.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21278

AFFECTED FILES
  kcms/touchpad/src/backends/x11/xcbatom.cpp

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21269: [Touchpad KCM] Fixed loading of wrong qml file

[Atul Bisht]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3e0fd10ddc27: [Touchpad KCM] Fixed loading of wrong qml 
file (authored by atulbi).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21269?vs=58248=58260#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21269?vs=58248=58260

REVISION DETAIL
  https://phabricator.kde.org/D21269

AFFECTED FILES
  CMakeLists.txt
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpad.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/resources.qrc

To: atulbi, romangg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21269: [Touchpad KCM] Fixed loading of wrong qml file

[Atul Bisht]

atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  On system settings, If Mouse KCM is opened first, then touchpad KCM loads the 
same Mouse QML file (qrc::/libinput/main.qml) instead of Touchpad Qml file.
  Having same url (qrc::/libinput/main.qml).
  
  Fix: simply renaming qml files fixed the issue.There could be better 
solutions though.

TEST PLAN
  1. Renamed main.qml to touchpad.qml .
  2. Edited resource file to reflect change.
  3. When compiled with these changes and opened touchpad setting, it was all 
blank, which was expected (because i did not changed the source).But opening 
mouse and then
  
  touchpad shows mouse settigs. So it Confirmed the cause.
  
  4. Now changing source and compiling it fixes the issue. Now, no more mouse 
on Touchpad and vice-versa.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  touchpad-mouse

REVISION DETAIL
  https://phabricator.kde.org/D21269

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpad.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/resources.qrc

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21228: [Touchpad KCM] Load previous setting on reboot

[Atul Bisht]

atulbi added a comment.


  Thank you so much for fixing it.
  Wanted it to on beta.

INLINE COMMENTS

> romangg wrote in libinputtouchpad.cpp:426
> Why this write back? What's configProps.

Yeah realized later that there is no need to write config here. So no need for 
configProps. Should I open a new patch for removing it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21228

To: romangg, ngraham, davidedmundson, atulbi
Cc: fvogt, davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21228: [Touchpad KCM] Load previous setting on reboot

[Atul Bisht]

atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  Earlier Previous setting were not loaded on reboot instead default settings 
were loaded.
  So, added config file for saving the settings.
  
  Now on startup, settings from config file will be loaded.

TEST PLAN
  Tested using kcminit and manually rebooting.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  AddConfig

REVISION DETAIL
  https://phabricator.kde.org/D21228

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#465586 , @ngraham wrote:
  
  > Also keep in mind that it's possible to have global config files in 
`/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work 
around the lack of this feature being implemented yet:
  >
  >   $  cat /etc/X11/xorg.conf.d/99-libinput.conf
  >   Section "InputClass"
  >   Identifier "libinput touchpad catchall"
  >   MatchIsTouchpad "on"
  >   MatchDevicePath "/dev/input/event*"
  >   Driver "libinput"
  >   Option "ClickMethod" "clickfinger" # other option is "buttonareas"
  >   Option "DisableWhileTyping" "false"
  >   Option "AccelSpeed" "0.2"
  >   #Option "MiddleEmulation" "true" # Only use this with the 
"buttonareas" clickmethod
  >   EndSection
  >
  >
  > Others may have similar settings. If possible, it might be nice to read 
these config files to determine the default option state in the KCM. Then once 
the user modifies anything, a new user-specific config file gets written that 
takes priority.
  
  
  Is there any specific library which could read these files ??

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  > In D20186#465395 , @romangg 
wrote:
  > 
  >> I found a grave issue now when testing though: Saved values are not 
restored on Reboot. Are they saved at all to a config file?
  >>
  >> EDIT: No, they are not. In X11 + evdev the KCM does this, not the backend. 
We need to:
  >>
  >> 1. add config file write and load functions to the X11-libinput backend
  >> 2. add a hook to kcm_init such that the load function is called on startup.
  >>
  >>   @atulbi: Do you have time to try this tomorrow?
  
  Yeah just starting to work on it. I'll try to complete it by today.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#465361 , @ngraham wrote:
  
  > @atulbi This has caused a failure in the CI:
  >
  > 
https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console
  >
  >   09:12:41  /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 
SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal 
error: libinput-properties.h: No such file or directory
  >   09:12:41   #include 
  >   09:12:41^~~
  >   09:12:41  compilation terminated.
  >
  >
  > Looks like we need to make the libinput xorg dev package a mandatory dep 
(boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I 
know it's short notice but we branch in two days; do you think you could fix 
this? Thanks!
  
  
  Whoops...
  If it's just because of "libinput-properties.h", then we could replace all 
macros with their property name, then there is no need for 
libinput-properties.h .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#465278 , @ngraham wrote:
  
  > Are you ready for me to land this?
  
  
  Yeah \o/
  I'll take that for the next patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 58083.
atulbi added a comment.


  Set visible to false, until accel profiles are not supported.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=58082=58083

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 58082.
atulbi added a comment.


  Finally no more greyed settings there \o/
  
  Work I've planned for future releases :
  
  - Adding support to disable horizontal scrolling on wayland.
  - Provide settings to Disable touchpad on external mouse.
  
  Regarding acceleration profile, maybe we should set visible to false for now.
  
  If no touchpad is connected, we could also show a large icon in middle  with 
"No touchpad Detected" written below it.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57933=58082

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57933.
atulbi added a comment.


  - lmr mapping working now

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57923=57933

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57923.
atulbi added a comment.


  - Added Copyright notice
  - Corrected asterisk placement

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57521=57923

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added inline comments.

INLINE COMMENTS

> romangg wrote in libinputtouchpad.h:57
> Why is there the negation? Put the Enabled-related function in the parent 
> class.

X provides property for the disabled, while Wayland provides property for 
enabled.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#462883 , @GB_2 wrote:
  
  > Ping
  
  
  Hey... Have you tried this patch ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57521.
atulbi added a comment.


  - Remove CMakeLists.txt.user

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57520=57521

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57520.
atulbi added a comment.


- Changes Made :
  1. Added abstract class LibinputCommon.
  2. All the Q_PROPERTY are in LibinputCommon.
  3. Added Disable Horizontal Support on X11 on Libinput.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57519=57520

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  CMakeLists.txt.user
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57519.
atulbi added a comment.


  - Removed last commit

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57508=57519

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57508.
atulbi added a comment.


  - Added new abstract class LibinputCommon
  - Add overriding destructor
  - Added support for disable horizontal scrolling on Libinput On X11.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55532=57508

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#458259 , @ngraham wrote:
  
  > @atulbi were you able to get in touch with @romangg? Can I help in any way?
  >
  > The feature freeze for Plasma 5.16 is in a little over two weeks 
(https://community.kde.org/Schedules/Plasma_5) and it would really nice to 
finally have full Libinput support in our KCM in that release. Right now we'd 
still have enough time for testing because of the beta period, but we'll need 
to get it in within the next two weeks.
  
  
  Sorry for the delay. My pre-university exams will end in just 2 days. I'll 
continue the work as soon as exams are over. I'm already halfway through.
  I've found the solution to the problem though  . Now it should not take much 
time to complete.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#454420 , @ngraham wrote:
  
  > @atulbi ping! Does Roman's request make sense? In general I think it does 
make sense to do code clean-up in a separate patch first.
  
  
  Totally!! I'm working on it... Currently facing some error. I'll contact 
Roman for help

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#443596 , @romangg wrote:
  
  > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file 
are copy-paste from the Wayland backend. It would make sense to have a new 
abstract parent class such that the code is shared.
  
  
  Initially, I also wanted to implement it that way, but it'll mess up existing 
code, and especially because LibinputTouchpad class already extends 
XlibTouchpad class. I wanted to have minimal changes to existing code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 55532.
atulbi added a comment.


  - Resolved issues

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55277=55532

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#443723 , @knambiar wrote:
  
  > > Wherever you're currently listed, remove your name and replace it with 
Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made 
@atulbi the default assignee for bugs to the Touchpad-KCM product.
  >
  > @atulbi  Congratulations, you’re now the maintainer of Touchpad KCM. In 
certain countries, there’s something called “inheritance tax” and you just 
inherited a few dozen bugs. Don’t despair, many of them should be fixed by now 
and some will be fixed by this commit.
  
  
  Many of the bugs were created during my school days XD

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#443554 , @ngraham wrote:
  
  > In D20186#443262 , @knambiar 
wrote:
  >
  > > >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be 
more than happy to hand that hat over if you wish to maintain this code. :-D
  > > > 
  > > > Hey, I would be happy to take that responsibility.
  > >
  > > Fantastic.
  > >
  > > @ngraham @jriddell Would you let me know the technicalities to make Atul 
maintainer of Touchpad KCM? I couldn't find a guideline in the wiki/techbase.
  >
  >
  > Wherever you're currently listed, remove your name and replace it with 
Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made 
@atulbi the default assignee for bugs to the Touchpad-KCM product.
  >
  > @atulbi is anything special needed to compile the KCM? After compiling 
plasma-desktop with your patch, no touchpad shared library was produced.
  
  
  I've only made changes to the existing files.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#442088 , @knambiar wrote:
  
  > > Got to Know a lot about how X works with input handling. XD
  >
  > I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more 
than happy to hand that hat over if you wish to maintain this code. :-D
  
  
  Hey, I would be happy to take that responsibility.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 55277.
atulbi added a comment.


  - Code Cleanup and resolved unexpected behaviour

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55251=55277

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 55251.
atulbi added a comment.


  - Avoid Setup Backend two times

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55234=55251

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#441892 , @ngraham wrote:
  
  > Thanks so much for this!
  
  
  Got to Know a lot about how X works with input handling. XD

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 55234.
atulbi added a comment.


  - Minor changes to optimise code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55230=55234

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  Earlier when libinput was used on X11, XInput specific UI was shown, due to 
which most of the options were grayed out.
  Now we show libinput specific UI that is already used on wayland if libinput 
driver is used on X11.
  
  - loaded all libinput properties that are available on X11.
  - exposed all Q_PROPERTY to Libinput specific UI.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

[Atul Bisht]

atulbi added a comment.


  Thanks. Yes, I'll take this for sure.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18912

To: atulbi, ngraham, #plasma, romangg, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

[Atul Bisht]

atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  - Added Properties to wayland Backend
  - User can switch between areas and clickfinger methods if touchpads has no 
physical buttons.
  - when areas mode is selected, user can enable and enable/disable 
middle-emulation.
  - In clickfinger mode , for informative purposes checked but disabled 
checkbox will be shown with "Press anywhere with three fingers" text.
  
  1. NEW DIFFERENTIAL REVISION
  2. Describe the changes in this new revision. #
  
  Included commits in branch libinput-click-method:
  
260c7a7562a4 [libinput-touchpad-kcm-click-method] Add click method Areas 
and Clickfinger for buttonless touchpads

REPOSITORY
  R119 Plasma Desktop

BRANCH
  libinput-click-method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18912

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart