Re: Oxygen Sounds split

[Benjamin Port]

Thanks Jonathan

-- 
Benjamin Port - enioka Haute Couture
06 38 83 18 16
On mercredi 26 janvier 2022 17:29:08 CET Jonathan Riddell wrote:
> I've added licencing to the oxygen-sounds repo after discussion with
> Ruphy.  I've removed the sounds from the oxygen repo and in Plasma 5.25
> I'll release the oxygen-sounds repo.
> 
> https://invent.kde.org/plasma/oxygen/commit/3a99c77f70c3d2b211861b22ce7405e491c50804
> https://invent.kde.org/plasma/oxygen-sounds/commit/e30bcb7680e5ef66e13e261061f4edbd71e6fc5a
> 
> Jonathan
> 

Re: Proposal: Split oxygen sounds

[Benjamin Port]

Thanks for your reply Aleix,

I suggest to do an oxygen-sounds repository that will install sounds to 
/usr/share/sounds/oxygen/stereo/name_without_oxygen and add an oxygen.theme file
We can then create a breeze-sounds repository and as first step we can inherit 
oxygen
Create symlink to /usr/share/sounds/name_starting_with_Oxygen (like now)

We will still need to implement the spec in knotification to support the spec

Benjamin

> On Thu, Nov 25, 2021 at 2:55 PM Benjamin Port  
> wrote:
> >
> > Hello,
> >
> > Currently all plasma sounds came from oxygen, even if you use breeze theme 
> > you still need to install oxygen package in order to have sound 
> > notification for example.
> >
> > That's why I will suggest to split oxygen repository. Current oxygen 
> > repository will keep everything except sounds. And a new one oxygen-sounds 
> > will have them.
> >
> > This will allow to not depend on the whole oxygen theme anymore, and allow 
> > more minimal setup
> >
> > My action Plan (if you are ok with the split):
> > - Ask sysadmin to create the new repository
> > - Do the split
> 
> Not opposing, but:
> - We need to be clear to coordinate with whoever takes on the task to
> do the new sound theme:
> https://community.kde.org/SoK/Ideas/2022#Plasma_Sound_Design
> - Are you sure about oxygen-sounds? If we rely on it (at least for
> now) from breeze it should be called something different like ocean or
> whatever.
> 
> Aleix
> 

Proposal: Split oxygen sounds

[Benjamin Port]

Hello,

Currently all plasma sounds came from oxygen, even if you use breeze theme you 
still need to install oxygen package in order to have sound notification for 
example.

That's why I will suggest to split oxygen repository. Current oxygen repository 
will keep everything except sounds. And a new one oxygen-sounds will have them.

This will allow to not depend on the whole oxygen theme anymore, and allow more 
minimal setup

My action Plan (if you are ok with the split):
- Ask sysadmin to create the new repository
- Do the split

Best regards,
Benjamin

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  Default indicator discussion is now on https://phabricator.kde.org/T13008

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart
Cc: GB_2, mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, ahiemstra

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

[Benjamin Port]

bport accepted this revision.
bport added a comment.


  ok then ship it

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-setnearest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29155

To: ahmadsamir, #plasma, bport, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

[Benjamin Port]

bport added a comment.


  I don't think we will have same behavior, we don't only check name but also 
size, type...
  If we are ok to fallback in all case to the same font that can work.
  
  From your test plan, something look strange you don't end with a monospaced 
font for fixed font as fallback ?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-setnearest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29155

To: ahmadsamir, #plasma, bport, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

[Benjamin Port]

bport accepted this revision.
bport added a comment.


  OK for me, as long as VDG is ok with this behavior

INLINE COMMENTS

> fonts.cpp:272
> +const int generalFontPointSize = font.pointSize();
> +if (generalFontPointSize > 8) {
> +smallestFont.setPointSize(generalFontPointSize - 2);

Nit-pick can we align comment and code either higher than 8pt (comment) or >= 9 
on the code

REPOSITORY
  R119 Plasma Desktop

BRANCH
  make-small-font-smaller-when-changing-all-font-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29156

To: ngraham, #plasma, ahmadsamir, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29056: [libtaskmanager] add stacking order data for wayland

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c46446e65b98: [libtaskmanager] add stacking order data 
for wayland (authored by bport).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29056?vs=80774=81349

REVISION DETAIL
  https://phabricator.kde.org/D29056

AFFECTED FILES
  libtaskmanager/waylandtasksmodel.cpp

To: bport, broulik, davidedmundson, zzag, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29064: Support module commandline paramenter

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> IconMode.cpp:204
> +
> +if (!startupModule().isEmpty()) {
> +MenuItem *item = rootItem()->descendantForModule(startupModule());

Indentation is not correct

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29064

To: mart, #plasma
Cc: bport, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28916: fix(kded): center action OSD on wayland

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:b3b45721ee17: fix(kded): center action OSD on wayland 
(authored by bport).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28916?vs=80376=80899#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28916?vs=80376=80899

REVISION DETAIL
  https://phabricator.kde.org/D28916

AFFECTED FILES
  kded/osd.cpp
  kded/qml/OsdSelector.qml

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29056: [libtaskmanager] add stacking order data for wayland

[Benjamin Port]

bport created this revision.
bport added reviewers: broulik, davidedmundson, zzag, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Depends on D29055  and D29054 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29056

AFFECTED FILES
  libtaskmanager/waylandtasksmodel.cpp

To: bport, broulik, davidedmundson, zzag, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Benjamin Port]

bport added a comment.


  In D28740#652419 , @broulik wrote:
  
  > This is for displaying whether do not disturb is on. The "until disabled" 
option just sets it to one year in the future. But it's odd to show "until 
2021", so we don't show the date when it's too far in the future.
  
  
  Why not change what the option do ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28740

To: broulik, #plasma
Cc: bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Benjamin Port]

bport added a comment.


  According to settings.h documentation
  When invalid or in the past, do not disturb mode should be considered 
disabled.
  
  So why not setting date to invalid date or one year in the past and do a test 
if date is in the future

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28740

To: broulik, #plasma
Cc: bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28916: fix(kded): center action OSD on wayland

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> davidedmundson wrote in OsdSelector.qml:34
> That was confusing, I'll rephrase.
> 
> Is it so the property "x" remains unset when running under the x windowing 
> environment?

Yes I wanted to ensure we don't change it on X
Didn't found a way to do it with a binding

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28916

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28653: Set cursor size default to 24 to align with KCM default value

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:4a7786999d31: Set cursor size default to 24 to align with 
KCM default value (authored by bport).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28653?vs=79570=80380

REVISION DETAIL
  https://phabricator.kde.org/D28653

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28655: Set default cursor size as 24 to follow new default on KCM

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7d19c5fc0fa7: Set default cursor size as 24 to follow new 
default on KCM (authored by bport).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28655?vs=79572=80381

REVISION DETAIL
  https://phabricator.kde.org/D28655

AFFECTED FILES
  startkde/startplasma.cpp

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a68554d39c5c: [Cursors] Remove Resolution Dependant 
option (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28652?vs=79590=80379

REVISION DETAIL
  https://phabricator.kde.org/D28652

AFFECTED FILES
  doc/kcontrol/cursortheme/index.docbook
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemesettings.kcfg
  kcms/cursortheme/delete_cursor_old_default_size.pl
  kcms/cursortheme/delete_cursor_old_default_size.upd
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/krdb/krdb.cpp
  kcms/lookandfeel/kcm.cpp
  kcms/mouse/backends/x11/x11_backend.cpp

To: bport, #plasma, meven, davidedmundson, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, ragreen, ZrenBot, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28916: fix(kded): center action OSD on wayland

[Benjamin Port]

bport created this revision.
bport added reviewers: romangg, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Currently on wayland action OSD is not centered on the screen.
  On Wayland we will center it on m_output (laptop, with fallback to primary 
and then to first one).
  X behavior is not changed.
  
  BUG: 397586

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28916

AFFECTED FILES
  kded/osd.cpp
  kded/qml/OsdSelector.qml

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28462: [KCM] Add color state probe to allow system settings to display current default state

[Benjamin Port]

bport updated this revision to Diff 80215.
bport added a comment.


  fix build

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28462?vs=79781=80215

REVISION DETAIL
  https://phabricator.kde.org/D28462

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorsdata.cpp
  kcms/colors/colorsdata.h
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemedata.cpp
  kcms/cursortheme/cursorthemedata.h
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsdata.cpp
  kcms/fonts/fontsdata.h
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingdata.cpp
  kcms/spellchecking/spellcheckingdata.h

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: fix (kcm): correct output identifier position on wayland

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:538116fd1096: fix (kcm): correct output identifier 
position on wayland (authored by bport).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28817?vs=80121=80125#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80121=80125

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28818: fix(kcm): show output ids in reference to currently applied config

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:544a7c14946a: fix(kcm): show output ids in reference to 
currently applied config (authored by bport).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28818?vs=80086=80126

REVISION DETAIL
  https://phabricator.kde.org/D28818

AFFECTED FILES
  kcm/config_handler.h
  kcm/kcm.cpp

To: bport, #plasma, romangg
Cc: romangg, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: fix (kcm): correct output identifier position on wayland

[Benjamin Port]

bport updated this revision to Diff 80121.
bport added a comment.


  Fix import order (remove unused one)
  Remove QTimer m_timer (field not used). Let me know if you want this one in a 
separate commit.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80120=80121

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28817: fix (kcm): correct output identifier position on wayland

[Benjamin Port]

bport updated this revision to Diff 80120.
bport added a comment.


  fix leak and style

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80090=80120

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport added a comment.


  In D28817#647930 , @anthonyfieroni 
wrote:
  
  > In D28817#647912 , @bport wrote:
  >
  > > I don't think we have a leak, on destructor we delete all view
  > >  qDeleteAll(m_views);
  >
  >
  > At that point, when rootObj is nullptr, view is not added to m_views.
  
  
  Indeed...

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, meven, ervin
Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport updated this revision to Diff 80090.
bport added a comment.


  Remove border and shadow

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80085=80090

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, meven, ervin
Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport added a comment.


  I don't think we have a leak, on destructor we delete all view
  qDeleteAll(m_views);

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, meven, ervin
Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport updated this revision to Diff 80085.
bport added a comment.


  update commit message

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80082=80085

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, meven, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: Identify output according to current applied position, not an unapplied position

[Benjamin Port]

bport updated this revision to Diff 80086.
bport added a comment.


  update commit message

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28818?vs=80083=80086

REVISION DETAIL
  https://phabricator.kde.org/D28818

AFFECTED FILES
  kcm/config_handler.h
  kcm/kcm.cpp

To: bport, #plasma, meven, ervin
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: Identify output according to current applied position, not an unapplied position

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, meven, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Depends on D28817 .

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

AFFECTED FILES
  kcm/config_handler.h
  kcm/kcm.cpp

To: bport, #plasma, meven, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, meven, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  BUG: 385672

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, meven, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28462: [KCM] Add color state probe to allow system settings to display current default state

[Benjamin Port]

bport updated this revision to Diff 79781.
bport added a comment.


  Rename state probe to data and use them in KCM
  
  And fix defaultness of spellchecking inside data (default at loading without 
widget state)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28462?vs=79497=79781

REVISION DETAIL
  https://phabricator.kde.org/D28462

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorsdata.cpp
  kcms/colors/colorsdata.h
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemedata.cpp
  kcms/cursortheme/cursorthemedata.h
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsdata.cpp
  kcms/fonts/fontsdata.h
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingdata.cpp
  kcms/spellchecking/spellcheckingdata.h

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport updated this revision to Diff 79771.
bport added a comment.


  - Factorize QML code
  - Rename isDefault to showDefaultIndicator

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28461?vs=79499=79771

REVISION DETAIL
  https://phabricator.kde.org/D28461

AFFECTED FILES
  core/MenuItem.cpp
  core/MenuItem.h
  core/MenuModel.cpp
  core/MenuModel.h
  core/ModuleView.cpp
  core/ModuleView.h
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/CategoryItem.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart
Cc: mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, ahiemstra

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

[Benjamin Port]

bport accepted this revision.
bport added a comment.
This revision is now accepted and ready to land.


  Thanks for your work

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-kfontchooserdialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

bport added a comment.


  For the wayland one at least I'm sure it's not that because without 
restarting session nothing happen
  For the X one I didn't see anything related to apply on the bug report (but 
yes the apply bug exist)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28652

To: bport, #plasma, meven, davidedmundson, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

bport added a comment.


  In D28652#643733 , @ngraham wrote:
  
  > After locally fixing the compile error, applying this patch as well as all 
three others, and restarting KWin, I'm unfortunately seeing the bugs marked as 
fixed still happening: I change the cursor size, click Apply in the KCM, then 
the cursor size still changes back to the old size when hovering over the 
desktop, a KWin-drawn titlebar, or the header area of a System Settings KCM.
  
  
  I guess is another bug, can you test by restarting the session
  The hot apply is still not working on wayland and still broken on X

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28652

To: bport, #plasma, meven, davidedmundson, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

bport updated this revision to Diff 79590.
bport added a comment.


  Add migration to delete old default

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28652?vs=79576=79590

REVISION DETAIL
  https://phabricator.kde.org/D28652

AFFECTED FILES
  doc/kcontrol/cursortheme/index.docbook
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemesettings.kcfg
  kcms/cursortheme/delete_cursor_old_default_size.pl
  kcms/cursortheme/delete_cursor_old_default_size.upd
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/krdb/krdb.cpp
  kcms/lookandfeel/kcm.cpp
  kcms/mouse/backends/x11/x11_backend.cpp

To: bport, #plasma, meven, davidedmundson, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> ngraham wrote in x11_backend.cpp:145
> Would `size` ever be empty now (not a leading question; I'm genuinely asking)

No never be empty, not sure what I made there... looks like I reverted 
something before commiting

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28652

To: bport, #plasma, meven, davidedmundson, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

bport planned changes to this revision.
bport added a comment.


  In D28652#643612 , @ngraham wrote:
  
  > For them I guess we'll need a kconf update file to migrate them to the new 
24 value.
  
  
  We will need to remove this entry we don't write default value
  I will add a migration to be sure nobody have this kind of entry

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28652

To: bport, #plasma, meven, davidedmundson, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

bport updated this revision to Diff 79576.
bport added a comment.


  fix build

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28652?vs=79569=79576

REVISION DETAIL
  https://phabricator.kde.org/D28652

AFFECTED FILES
  doc/kcontrol/cursortheme/index.docbook
  kcms/cursortheme/cursorthemesettings.kcfg
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/krdb/krdb.cpp
  kcms/lookandfeel/kcm.cpp
  kcms/mouse/backends/x11/x11_backend.cpp

To: bport, #plasma, meven, davidedmundson, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

bport added a comment.


  Those code review are linked to this one:
  https://phabricator.kde.org/D28653
  https://phabricator.kde.org/D28654
  https://phabricator.kde.org/D28655

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28652

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28653: Set cursor size default to 24 to align with KCM default value

[Benjamin Port]

bport added a comment.


  Those code review are linked to this one:
  https://phabricator.kde.org/D28652
  https://phabricator.kde.org/D28654
  https://phabricator.kde.org/D28655

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D28653

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28655: Set default cursor size as 24 to follow new default on KCM

[Benjamin Port]

bport added a comment.


  Those code review are linked to this one:
  https://phabricator.kde.org/D28652
  https://phabricator.kde.org/D28653
  https://phabricator.kde.org/D28654

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28655

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28655: Set default cursor size as 24 to follow new default on KCM

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, meven, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28655

AFFECTED FILES
  startkde/startplasma.cpp

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28653: Set cursor size default to 24 to align with KCM default value

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, meven, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D28653

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, meven, davidedmundson.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  This option don't work as expected for years on X, and current wayland 
protocol don't allow to have a proper size for all application (each framework 
came with this own solution for this option, that mean we will not have same 
cursor size on different application)
  
  We set default size as 24
  
  BUG: 385920
  BUG: 413783

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28652

AFFECTED FILES
  doc/kcontrol/cursortheme/index.docbook
  kcms/cursortheme/cursorthemesettings.kcfg
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/krdb/krdb.cpp
  kcms/lookandfeel/kcm.cpp
  kcms/mouse/backends/x11/x11_backend.cpp

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport updated this revision to Diff 79499.
bport added a comment.


  Change icon with a blue dot

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28461?vs=78970=79499

REVISION DETAIL
  https://phabricator.kde.org/D28461

AFFECTED FILES
  core/MenuItem.cpp
  core/MenuItem.h
  core/MenuModel.cpp
  core/MenuModel.h
  core/ModuleView.cpp
  core/ModuleView.h
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart
Cc: mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, ahiemstra

D28462: [KCM] Add color state probe to allow system settings to display current default state

[Benjamin Port]

bport updated this revision to Diff 79497.
bport added a comment.


  Adapt to kcmutils update and add cursor, fonts, spellchecking example

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28462?vs=78971=79497

REVISION DETAIL
  https://phabricator.kde.org/D28462

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colorsstateprobe.cpp
  kcms/colors/colorsstateprobe.h
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemestateprobe.cpp
  kcms/cursortheme/cursorthemestateprobe.h
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fontsstateprobe.cpp
  kcms/fonts/fontsstateprobe.h
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellcheckingstateprobe.cpp
  kcms/spellchecking/spellcheckingstateprobe.h

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> mart wrote in CategoriesPage.qml:207
> try to keep the item count as small as possible, especially in item delegates.
> I would really prefer if we could do without this wrapper

Indeed this wrapper is not needed

> mart wrote in SubCategoryPage.qml:198
> width: Kirigami.Units.iconSizes.small

Thanks I will fix that

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart
Cc: mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, ahiemstra

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  Yes we will need to have a probe for each KCM, and I currently look to reuse 
this probe in the KCM that will split a bit more data and UI.
  Some KCM like pulseaudio one don't need that for example, because there is no 
default setup

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  In D28461#639056 , @ngraham wrote:
  
  > Is D28460  the only other patch that's 
needed? I applied that and then this patch compiled fine, but I don't see any 
difference in the sidebar, despite having changed some settings from their 
default values.
  
  
  No we also need to add probe to each KCM there is an example with the color 
one there D28462  (locally I have more 
example but need some code cleanup and not needed for code review so I will do 
code cleanup after probe API cleanup is done i.e. patch D28460 
)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  In D28461#639022 , @ngraham wrote:
  
  > I get a compile error:
  >
  >   /home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function 
‘void MenuItem::updateDefault()’:
  >   /home/nate/kde/src/systemsettings/core/MenuItem.cpp:154:36: error: 
‘isDefaults’ is not a member of ‘KCModuleLoader’
  > 154 | d->isDefault = KCModuleLoader::isDefaults(d->item);
  > |^~
  >
  >
  > Does this have un-merged dependencies? If so, you can mark them in Phab by 
adding the text `Depends on D12345` (but the actual patch ID, not D12345 
 :) ) in the Summary section.
  
  
  Ok I will add it I thought setting a parent revision on the right sidebar was 
enough

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  In D28461#639016 , @abetts wrote:
  
  > If I am understanding correctly, this patch adds icons in the kcm list to 
indicate changes you can revert by going to the kcm. Basically, default 
settings have changed and now you have the possibility to see that changes have 
been made. I am not sure that I like the implementation. I have some questions.
  >
  > What will you do when all of them are changed in some way? Will the entire 
kcm list show an icon indicating change? If you think about it, KDE is the DE 
of changes and options. I feel all of these are going to show some kind of 
change, that could be overwhelming. At the end of the day, is it necessary? 
Wouldn't this be something that probably works best by having it in the 
reset/defaults button?
  
  
  Being the DE of "changes and options" don't mean all people are changing 
everything, but that also mean some people will do some change and then don't 
remember what they changed, and will never find what differ from the default 
values. Reset / Default button have totally different purpose, default button 
will set back default value and will be indeed active if module don't have 
default value. However, user will know that only if he goes to the good module. 
Problem for a "lambda" user is to remember what change.
  
  > Also, these icons indicate change, if you click on the item and then land 
in a kcm that doesn't present more clues as to what changed, then you are left 
with the default action to click defaults or reset on the kcm anyway. There 
doesn't seem to be much more value there.
  
  There is another patch for this purpose
  https://phabricator.kde.org/D27540

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, 
LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  F8208462: image.png 
  
  Test with a blue dot, took less space than an icon
  Wa can imagine a tooltip when you go hover the  dot explaining it

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  Goal of this feature is to improve user discoverability and allow them to 
find more easily which settings diverged from defaults one, so they can more 
easily revert to the default value when needed
  Indeed the current indicator is not the good one, and I will be happy to have 
some help to find a nicest one.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28462: [KCM] Add color state probe to allow system settings to display current default state

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, meven, crossi, hchain.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28462

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colorsstateprobe.cpp
  kcms/colors/colorsstateprobe.h

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, meven, crossi, hchain.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

AFFECTED FILES
  core/MenuItem.cpp
  core/MenuItem.h
  core/MenuModel.cpp
  core/MenuModel.h
  core/ModuleView.cpp
  core/ModuleView.h
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Benjamin Port]

bport added a comment.


  Some coding style nitpicking

INLINE COMMENTS

> export_scheme_dialog.cpp:46
>  int item=0;
> -Q_FOREACH(QString component, mComponents)
> +for (const QString  : qAsConst(mComponents))
>  {

{ on same line

> export_scheme_dialog.cpp:74
> +const auto buttons = mButtons.buttons();
> +for (const QAbstractButton *button : buttons)
>  {

{ on same line

> kglobalshortcutseditor.cpp:168
>  
> -for( KServiceGroup::List::ConstIterator it = list.constBegin();
> +for ( KServiceGroup::List::ConstIterator it = list.constBegin();
>   it != list.constEnd(); ++it) {

you have an unneeded space after (

> kglobalshortcutseditor.cpp:543
> +for (const QString  : groupList)
>  {
>  // do not overwrite the Settings group. That makes it possible to

{ on same line

> kglobalshortcutseditor.cpp:832
> +for (const QString  : keys)
>  {
>  if (components.value(text)->uniqueName() == componentUnique)

{ same line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28232: [SpellChecking KCM] Fix the build

[Benjamin Port]

bport added a comment.


  https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series
  So we need to see if we can update the CI

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28232: [SpellChecking KCM] Fix the build

[Benjamin Port]

bport added a comment.


  Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem to 
depend on it

INLINE COMMENTS

> CMakeLists.txt:9
>  set(QT_MIN_VERSION "5.12.0")
> -set(KF5_MIN_VERSION "5.66.0")
>  

Indeed this is needed thanks

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:38a874ab82aa: [KCM Spellchecking] port to 
KPropertySkeletonItem (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27503?vs=77267=78297

REVISION DETAIL
  https://phabricator.kde.org/D27503

AFFECTED FILES
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingskeleton.cpp
  kcms/spellchecking/spellcheckingskeleton.h

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Benjamin Port]

bport accepted this revision.
bport added a comment.
This revision is now accepted and ready to land.


  Ok for me but need to wait approval on font dialog review (to ensure correct 
font style is selected when editing)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d28337b6d379: KCM Fonts port anti aliasing part to 
KPropertySkeletonItem (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75890=77274

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/kxftconfig.h
  kcms/fonts/package/contents/ui/main.qml

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 77267.
bport added a comment.


  fix

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27503?vs=76516=77267

REVISION DETAIL
  https://phabricator.kde.org/D27503

AFFECTED FILES
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingskeleton.cpp
  kcms/spellchecking/spellcheckingskeleton.h

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

[Benjamin Port]

bport requested changes to this revision.
bport added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fonts.cpp:115
> +if (!sameFont) {
> +if (font.weight() == QFont::Normal && font.styleName().isEmpty()
> +&& result.weight() == QFont::Normal

You can use && to have only one if there

> fonts.cpp:552
>  {
> -m_settings->setFont(nearestExistingFont(m_settings->font()));
> -m_settings->setFixed(nearestExistingFont(m_settings->fixed()));

Those change will compare font twice, here and on setters so I will keep old 
code there

> fonts.cpp:576
> -// KCM expect save state to be false at this point (can be true because 
> of setNearestExistingFonts
> -setNeedsSave(false);
>  }

I will keep that until we have a proper tested fix for 
https://phabricator.kde.org/D27452
can prevent bug and ensure apply button is on the good state on all case

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Benjamin Port]

bport added a comment.


  With your change, we are not allowed anymore to change for example only font 
and keeping different size, style for each kind of font (window, menu, 
toolbar...), right ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> ervin wrote in spellchecking.cpp:88
> Sure but still, the skeleton is expected to be already be in a "loaded" state 
> at that point, that's why it works for the items (otherwise a findItem 
> wouldn't be enough, it'd have to call readConfig on them or load on the whole 
> skeleton, and it doesn't). I think the problem is more that in the ctor of 
> the skeleton you initialize the items just fine but you don't initialize the 
> extra properties you need a call to usrRead() at the end of that ctor.

Yes, or I can probably also use item like before, and that will be handled for 
me

> ervin wrote in spellchecking.cpp:118
> I'd expect this to be the same block than the one in load() now. Since 
> `KCModule::defaults()` will reset the skeleton to defaults, ignoreList, 
> preferredLanguages and defaultLanguage will hold the default values.

no because we hold loaded data if we do that, apply button will be deactivated 
after clicking default

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> ervin wrote in spellchecking.cpp:88
> Are you sure this is necessary? I'd expect KCModule::load() to call load() on 
> m_skeleton

no load only do findItem for managed widget on the skeleton

> ervin wrote in spellcheckingskeleton.cpp:51
> I have a doubt, is it really necessary? I'd expect it to work without that 
> line.

Yes is necessary no code is run after that so nobody will take care of saving 
this skeleton.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 76516.
bport marked 19 inline comments as done.
bport added a comment.


  cleanup

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27503?vs=76385=76516

REVISION DETAIL
  https://phabricator.kde.org/D27503

AFFECTED FILES
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingskeleton.cpp
  kcms/spellchecking/spellcheckingskeleton.h

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 76385.
bport added a comment.


  Take change from sonnet patch in consideration and other ervin feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27503?vs=75998=76385

REVISION DETAIL
  https://phabricator.kde.org/D27503

AFFECTED FILES
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingskeleton.cpp
  kcms/spellchecking/spellcheckingskeleton.h

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

[Benjamin Port]

bport accepted this revision.
bport added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> DeviceAutomounter.cpp:39
>  DeviceAutomounter::DeviceAutomounter(QObject *parent, const QVariantList 
> )
> -: KDEDModule(parent)
> +: KDEDModule(parent), m_settings(new AutomounterSettings(this))
>  {

m_settings need to go to the next line

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27127

REVISION DETAIL
  https://phabricator.kde.org/D27480

To: meven, ervin, crossi, bport, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, meven, crossi, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

AFFECTED FILES
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingskeleton.cpp
  kcms/spellchecking/spellcheckingskeleton.h

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> style_widgetstyle_default_breeze.pl:8
> +chomp;
> +s/widgetStyle=breeze/widgetStyle=Breeze/;
> +print "$_\n";

This will fix only for Breeze theme
This will fix existing case but we also need to fix the root cause (i.e. how we 
end up with a lowercase name).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27470: Set good default value for cursor theme and size in KRDB

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ca9f0eeb9b53: Set good default value for cursor theme and 
size in KRDB (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27470?vs=75892=75962

REVISION DETAIL
  https://phabricator.kde.org/D27470

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: bport, #plasma, broulik, ervin, meven, crossi, davidedmundson
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27470: Set good default value for cursor theme and size in KRDB

[Benjamin Port]

bport added a comment.


  This is not a KCM, and because of how stuff works with KRDB we can't reuse 
kcfg easily there (because build by 5 or 6 kcm)
  About the 0 as default value, perhaps we can change that but it's totally 
unrelated to this patch, goal there is only to honor default value as set by 
kcfg

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27470

To: bport, #plasma, broulik, ervin, meven, crossi
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27470: Set good default value for cursor theme and size in KRDB

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, broulik, ervin, meven, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27470

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: bport, #plasma, broulik, ervin, meven, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75890.
bport added a comment.


  fix build. KRDB can't use Kxftconfig directly so we can't avoid stuff in 
kdeglobals

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75844=75890

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/kxftconfig.h
  kcms/fonts/package/contents/ui/main.qml

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> DeviceAutomounterKCM.cpp:84
>  saveLayout();
> +delete m_settings;
>  }

We can also change kcfgc to add parent in constructor

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75844.
bport added a comment.


  Add missing space

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75813=75844

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fontremovenantialiasingkeys.upd
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/kxftconfig.h
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Write Font without style name

[Benjamin Port]

bport added a comment.


  I just read bug report again and the from seems to came from , not from 
localization.
  
  By the way I neved end with localized style, how do you achieve that ? (I 
mean even in UI)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven
Cc: davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Write Font without style name

[Benjamin Port]

bport added a comment.


  I think a good fix can be to use @davidedmundson solution combined with a 
check to know if font styleName is not set (if it set it will be not translated.
  
  I think
  QFont yourFont = QFont(...);
  auto f = QFontInfo(youFont)
  f.styleName(); <<=  is in theory empty if it's not enforced. In other case 
stuff based on enum will be ok. Goal of style name is to express "irregular" 
style name according to Qt documentation

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven
Cc: davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75813.
bport added a comment.


  Add kconfupdate script to remove unused keys

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75541=75813

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fontremovenantialiasingkeys.upd
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/kxftconfig.h
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Benjamin Port]

bport requested changes to this revision.
bport added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> componentchooserbrowser.cpp:107
>  {
> +if (currentIndex() == count() -1) {
> +// no browser installed, nor selected

add a space between -  and 1

By the way this check seems strange to me, can you confirm it still allow to 
save custom browser ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0c4da0774e43: [KCM Fonts] force need save to false during 
load to avoid state to be true too… (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27384?vs=75639=75668

REVISION DETAIL
  https://phabricator.kde.org/D27384

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Benjamin Port]

bport added a comment.


  I will look at a proper fix in the next days

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Benjamin Port]

bport added a comment.


  Yes emiting signal from setNeedsSave in all case fix stuff too
  
  So this patch is here to solve for "short term"
  
  In more long term we need to fix ConfigModule do you think is better to do a 
setNeedsSave(false) after loading or emiting signal in all case ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Benjamin Port]

bport added a comment.


  @davidedmundson 
  We have 2 bugs :
  
  - KCModuleQML apply button will stay disabled forever if at the end of load 
function need save is true (probably qml connection not yet done or something 
like that I guess, not yet found why) => We need to investigate on it too, I 
reproduced the same behavior with KCM icons  by changing a setting at the end 
of load method.
  - In theory at the end of load we don't need to save data. However in some 
case for the font KCM data are dirty and need save. Came from Qt font 
comparison, if in your kdeglobals you have a font definition without style 
name, our algorithm to match a nearest font will add one, and font comparison 
between referential data and current data will return false because they are 
different.
  
  - My first approach was to fix algorithm to find the nearest font and keep 
style name empty if we don't have information. After this fix apply button work 
as expected, but when you adjust this font the selected style will be the first 
one on the list and not the one expected  (regular)
  - Second approach by setting need save to false at the end of load allow us 
to be on the good state and the next change will allow us to enable apply 
button. By the way apply button will be enable directly because settings 
changed is trigered by another time after loading not sure where (didn't 
investigated yet)
  
  About KCModuleQML didn't investigate a lot but KCModule (parent class) emit a 
changed false on showEvent (the way the handle to set need save to false. On 
qml side we use directly stNeedsSave (you can look at save method 
implementation), so a proper fix can be to add 
"d->configModule->setNeedsSave(false);" after loading

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27381: [sidebar] Resolve changes in module before switching

[Benjamin Port]

bport accepted this revision.
bport added a comment.
This revision is now accepted and ready to land.


  Can reproduce bug and fix work as expected

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27381

To: davidedmundson, #plasma, bport
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, broulik, ervin, crossi, meven, ngraham, 
davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  This will resolve a bug (apply never enabled). Bug occurs (at least) when 
kdeglobals contains QFont serialization without styleName (old style)
  
  BUG: 416358

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75541.
bport added a comment.


  Fix reset and default button for Anti Aliasing area (states were ok, but UI 
values were not updated after clicking them)
  
  depends on https://phabricator.kde.org/D27342

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75465=75541

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/kxftconfig.h
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> usta wrote in main.qml:242
> I am really away from qml thing but are you sure this one correct ? I mean 
> isnt this should be 
> kcm.dpi instead of kcm.fontsAASettings.dpi ??

No dpi is declared inside fontsAASettings

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27156

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75465.
bport added a comment.


  fix coding style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75446=75465

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75446.
bport added a comment.


  coding style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75444=75446

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75444.
bport added a comment.


  Fix

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75442=75444

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75442.
bport added a comment.


  Take in consideration Cyril's feedbacks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75000=75442

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> kcm.cpp:257
> +{
> +m_currentBehavior = m_behaviorSettingsList[identifier];
> +emit behaviorSettingsChanged();

Add a if to emit signal only if needed

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27188

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, crossi, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontssettingsaa.cpp
  kcms/fonts/fontssettingsaa.h
  kcms/fonts/fontssettingsaabase.kcfg
  kcms/fonts/fontssettingsaabase.kcfgc
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Benjamin Port]

bport added a comment.


  In D26842#605839 , @fvogt wrote:
  
  > Does this mean the default fonts have a style name of "Regular" now? That 
will break setting bold fonts and such, see https://phabricator.kde.org/D9070.
  
  
  Default is not serialized in the configuration file (because it's the default 
value).
  
  I do some check with current KCM version, and when we save it, we end up with 
font=Noto Sans,10,-1,5,87,1,0,0,0,0,Regular
  Because nearest font algorithm return the regular one. So if I well 
understood everything this patch will not break anything.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26842

To: bport, #plasma, ervin, crossi, meven, ngraham
Cc: fvogt, broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0a107dcbe9fc: Fix fonts KCM button state (authored by 
bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26842?vs=74576=74982

REVISION DETAIL
  https://phabricator.kde.org/D26842

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontssettings.kcfg

To: bport, #plasma, ervin, crossi, meven, ngraham
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Benjamin Port]

bport added a comment.


  In D26842#602522 , @ngraham wrote:
  
  > We are getting duplicates of https://bugs.kde.org/show_bug.cgi?id=416358, 
so I guess it would be nice if this made it into 5.18.
  
  
  Ok I will land it to 5.18 and then merge to master

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26842

To: bport, #plasma, ervin, crossi, meven, ngraham
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Benjamin Port]

bport updated this revision to Diff 74576.
bport added a comment.


  fix coding style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26842?vs=74127=74576

REVISION DETAIL
  https://phabricator.kde.org/D26842

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontssettings.kcfg

To: bport, #plasma, ervin, crossi, meven
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart