D28873: Add SwipeNavigator component

[Camilo Higuita]

camiloh added a comment.


  What about having as a view a component that is not a Kirigami.Page? Such as 
a StackView or a Rectangle. Why not use an attached property to define its 
title, icon and other props instead of focing to wrap those components into a 
kirigami.Page?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D27212: Have pullback toolbars on scrollable pages also for footers

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:7712c75953c5: Have pullback toolbars on scrollable pages 
also for footers (authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27212?vs=76337&id=77111

REVISION DETAIL
  https://phabricator.kde.org/D27212

AFFECTED FILES
  src/controls/templates/AbstractApplicationHeader.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

[Camilo Higuita]

camiloh added a comment.


  works okay for me with qqc2 actions

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27653

To: ahiemstra, #kirigami
Cc: camiloh, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D27212: Have pullback toolbars on scrollable pages also for footers

[Camilo Higuita]

camiloh marked 2 inline comments as done.
camiloh added a comment.


  everythign is now fixed :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27212

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24623: Missing links to pagepool source files

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:51205eba731a: Missing links to pagepool source files 
(authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24623?vs=67873&id=76338

REVISION DETAIL
  https://phabricator.kde.org/D24623

AFFECTED FILES
  kirigami.pri

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27212: Have pullback toolbars on scrollable pages also for footers

[Camilo Higuita]

camiloh updated this revision to Diff 76337.
camiloh added a comment.


  downgrade qqc2 version to 2.4 and remove white spaces

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27212?vs=75195&id=76337

BRANCH
  arcpatch-D27212

REVISION DETAIL
  https://phabricator.kde.org/D27212

AFFECTED FILES
  src/controls/templates/AbstractApplicationHeader.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27638: allow to take qqc2 actions and fix issues with it not having the visible prop

[Camilo Higuita]

camiloh created this revision.
camiloh added reviewers: ahiemstra, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REVISION SUMMARY
  This allows to correctly display the QQC2 Actions too, the issue was due to 
the loader source component not being picked as visible form parent loader and 
quering wrong the existance of the QQC2 visible prop

TEST PLAN
  test it wiht K.Action and QQC2.Action. setting K.Action with the displayHint 
proprs and visible props and that QQC2 gets displayed, collapsed and respects 
the actiontoolbar display props

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27638

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/private/ActionToolBarLayoutDetails.qml

To: camiloh, ahiemstra, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27212: Have pullback toolbars on scrollable pages also for footers

[Camilo Higuita]

camiloh updated this revision to Diff 75195.
camiloh added a comment.


  correct undefined line

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27212?vs=75168&id=75195

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27212

AFFECTED FILES
  src/controls/templates/AbstractApplicationHeader.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27212: Have pullback toolbars on scrollable pages also for footers

[Camilo Higuita]

camiloh created this revision.
camiloh added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27212

AFFECTED FILES
  src/controls/templates/AbstractApplicationHeader.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24623: Missing links to pagepool source files

[Camilo Higuita]

camiloh created this revision.
camiloh added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REVISION SUMMARY
  failing to build on android with qmake

REPOSITORY
  R169 Kirigami

BRANCH
  missing_pri_links (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24623

AFFECTED FILES
  kirigami.pri

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D23081: remove references from the icon qrc to missing icons.

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:b3ffca1363b1: remove references from the icon qrc to 
missing icons. (authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23081?vs=63518&id=63889

REVISION DETAIL
  https://phabricator.kde.org/D23081

AFFECTED FILES
  kirigami-icons.qrc

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D23154: allow to set custom icon for the left drawer handle

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:191ff22b1cb9: allow to set custom icon for the left 
drawer handle (authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23154?vs=63742&id=63758

REVISION DETAIL
  https://phabricator.kde.org/D23154

AFFECTED FILES
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/OverlayDrawer.qml

To: camiloh, #kirigami, mart
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23154: allow to set custom icon for the left drawer handle

[Camilo Higuita]

camiloh added a comment.


  In D23154#511924 , @ngraham wrote:
  
  > Needs moar `@since 5.62`
  
  
  where ?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23154

To: camiloh, #kirigami, mart
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23154: allow to set custom icon for the left drawer handle

[Camilo Higuita]

camiloh updated this revision to Diff 63742.
camiloh added a comment.


  code style spaces

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23154?vs=63740&id=63742

BRANCH
  left-drawer-handle-custom-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23154

AFFECTED FILES
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/OverlayDrawer.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D23154: allow to set custom icon for the left drawer handle

[Camilo Higuita]

camiloh updated this revision to Diff 63740.
camiloh added a comment.


  more compact code and fix coding style spaces

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23154?vs=63738&id=63740

BRANCH
  left-drawer-handle-custom-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23154

AFFECTED FILES
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/OverlayDrawer.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D23154: allow to set custom icon for the left drawer handle

[Camilo Higuita]

camiloh updated this revision to Diff 63738.
camiloh added a comment.


  add default handle icon props to null

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23154?vs=63737&id=63738

BRANCH
  left-drawer-handle-custom-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23154

AFFECTED FILES
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/OverlayDrawer.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D23154: allow to set custom icon for the left drawer handle

[Camilo Higuita]

camiloh created this revision.
camiloh added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REVISION SUMMARY
  it allows to set a icon to the globaldrawer handle, for that both close and 
open handle icons need to be set

REPOSITORY
  R169 Kirigami

BRANCH
  left-drawer-handle-custom-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23154

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/OverlayDrawer.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:fd8fec5b8923: Allow usage of QQC2 actions on Kirigami 
components and now make K.Action based… (authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22974?vs=63727&id=63728

REVISION DETAIL
  https://phabricator.kde.org/D22974

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/private/ActionButton.qml
  src/controls/private/ActionsMenu.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh updated this revision to Diff 63727.
camiloh added a comment.


  clean up code, remove comments and documentation fixes

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22974?vs=63726&id=63727

BRANCH
  k-action-to-qqc2-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22974

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/private/ActionButton.qml
  src/controls/private/ActionsMenu.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh updated this revision to Diff 63726.
camiloh added a comment.


  remove debugging line

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22974?vs=63725&id=63726

BRANCH
  k-action-to-qqc2-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22974

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/private/ActionButton.qml
  src/controls/private/ActionsMenu.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh added a comment.


  In D22974#508067 , @mart wrote:
  
  > good direction, unfortunately we can't remove the custom toolbutton 
contentitem yet, so for now let's keep the custom icon group
  
  
  The solution here was to add back the kirigamiAction property to the 
PrivateActionToolButton, so it avoids the QQC2.ToolButton action prop

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22974

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh updated this revision to Diff 63725.
camiloh added a comment.


  fallback to custom kirigamiAction property for PrivateActionToolButton
  
  - useage of the fallback property due to: if we use QQC2.ToolButton default 
action property then the style will draw the content, and since this component 
draws the dropDown icon it still needs to be able to draw its own content in 
place, so the kirigamiAction hides the action prop and then avoids duplicating 
of icons.
  
  Still, an ideal solution would be to be able to let the style draw the 
content, but there was not an easy way to anchors the dropDown icon in a nice 
manner by relaying on the style.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22974?vs=63242&id=63725

BRANCH
  k-action-to-qqc2-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22974

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/private/ActionButton.qml
  src/controls/private/ActionsMenu.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D23081: remove references from the icon qrc to missing icons.

[Camilo Higuita]

camiloh created this revision.
camiloh added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REVISION SUMMARY
  this issue was affecting the building of app when using kirigami static linked

REPOSITORY
  R169 Kirigami

BRANCH
  qrc_missing_icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23081

AFFECTED FILES
  kirigami-icons.qrc

To: camiloh, #kirigami
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh updated this revision to Diff 63242.
camiloh added a comment.


  remove todo line

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22974?vs=63241&id=63242

BRANCH
  k-action-to-qqc2-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22974

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/GlobalDrawer.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/ActionButton.qml
  src/controls/private/ActionsMenu.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh updated this revision to Diff 63241.
camiloh added a comment.


  Correct possible undefined result pointed out by Aleix

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22974?vs=63240&id=63241

BRANCH
  k-action-to-qqc2-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22974

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/GlobalDrawer.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/ActionButton.qml
  src/controls/private/ActionsMenu.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh added inline comments.

INLINE COMMENTS

> camiloh wrote in ActionToolBar.qml:184
> I think it then gets marked as visible = true

You were right, I have now fixed it.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22974

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh updated this revision to Diff 63240.
camiloh marked an inline comment as done.
camiloh added a comment.


  further changes to make components work with new Kirigami.Action based on 
QQC2.Action, and proposed solution to draw the PrivateActionToolButton

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22974?vs=63219&id=63240

BRANCH
  k-action-to-qqc2-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22974

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/GlobalDrawer.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/ActionButton.qml
  src/controls/private/ActionsMenu.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh marked 2 inline comments as done.
camiloh added a comment.


  I have worked on the duplicating icons, by not using the contentItem to draw 
the icons and label, and instead use the style implementation. The only thing 
missing would be the dropdown icon for actions with submenus, I'm anchoring 
that icon to the right con the contentItem. I will update this patch.
  I will push my proposal for duplicating icons, it can be reviewed. And then I 
can split this patch into different parts as suggested by Aleix.

INLINE COMMENTS

> apol wrote in Action.qml:76
> Can you check that we're not missing some API? is ActionIconGroup a subset of 
> what Qt offers?

from Kirigami actionIconGroup:
string name
string source
int width
int height
color color

from QQC2 icon property:
icon.name
icon.source
icon.width
icon.height
icon.color

> apol wrote in ActionToolBar.qml:184
> If `ourAction` doesn't have a visible property, won't `ourAction.visible` be 
> undefined?

I think it then gets marked as visible = true

> apol wrote in PrivateActionToolButton.qml:89
> Wouldn't it be control.action.icon.name?

yes. fixed now on new commit

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22974

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Camilo Higuita]

camiloh created this revision.
camiloh added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REVISION SUMMARY
  The ideal is to be able to add regular qqc2 actions to the actiontoolbar, 
pageheaders, globaldrawers and different components, and make kirigami.action 
based on qqc2.action, so implementations are not duplicated.

TEST PLAN
  So far i have tested this with different kirigami components, such as 
pageheadertoolbar, globaldrawers, kirigamiactiontoolbar, and it is working.
  There is an issue now with the PrivateActionToolButton, since K.Actions is 
based on QQC2.Action, it make sthe control to draw two icons, one from 
PrivateActionToolBar own contentItem implementation and another one from the 
style background
  
  I will continue testing this, and pls let me know how i could proceed better 
with the PrivateActionToolButton issue.

REPOSITORY
  R169 Kirigami

BRANCH
  k-action-to-qqc2-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22974

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: camiloh, #kirigami
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22648: make handle follow arbitrary height of the drawer

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:518444e4191a: make handle follow arbitrary height of the 
drawer (authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22648?vs=62345&id=62535

REVISION DETAIL
  https://phabricator.kde.org/D22648

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: camiloh, mart, #kirigami
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22648: make handle follow arbitrary height of the drawer

[Camilo Higuita]

camiloh updated this revision to Diff 62345.
camiloh added a comment.


  now using root.parent instead of applicationWindow()

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22648?vs=62309&id=62345

BRANCH
  handle-follow-drawer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22648

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: camiloh, mart, #kirigami
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22648: make handle follow arbitrary height of the drawer

[Camilo Higuita]

camiloh updated this revision to Diff 62309.
camiloh added a comment.


  take into consideration the y position
  
  Summary: if the drawer height prop has been set to a custom value, might as 
well the y position too, so take it into account to position the handle

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22648?vs=62302&id=62309

BRANCH
  handle-follow-drawer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22648

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: camiloh, mart, #kirigami
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22648: make handle follow arbitrary height of the drawer

[Camilo Higuita]

camiloh created this revision.
camiloh added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REVISION SUMMARY
  If the height of the drawer is set to a different value from the 
applicationWindow height, then the drawer handle follows the bottom on the 
drawer, staying at the bottom the the new arbitrary height value

REPOSITORY
  R169 Kirigami

BRANCH
  handle-follow-drawer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22648

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: camiloh, mart
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22572: Remove scaling of iconsize unit for isMobile

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:a89b2334f137: Remove scaling of iconsize unit for 
isMobile (authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22572?vs=62086&id=62285

REVISION DETAIL
  https://phabricator.kde.org/D22572

AFFECTED FILES
  src/controls/Units.qml

To: camiloh, #vdg, mart, ngraham
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22572: Remove scaling of iconsize unit for isMobile

[Camilo Higuita]

camiloh created this revision.
camiloh added a reviewer: VDG.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REVISION SUMMARY
  On Android icons using the iconSizes units look to big for the intended size, 
this changed has been tested on different screen sizes with devices running 
Android and also on a Nexus 5x running Plamo, and the result is goo. I'm 
attaching the resulting screenshots and screencast.

REPOSITORY
  R169 Kirigami

BRANCH
  mobile-iconsize-unit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22572

AFFECTED FILES
  src/controls/Units.qml

To: camiloh, #vdg
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

Re: Kirigami/qmake deployment on Android problems

[Camilo Higuita Rodriguez]

Even more, in my case
the combination of:

Style=Material

and

import org.kde.kirigami 2.2 as Kirigami

always exists with code 255 on the desktop. On android the error:

W/libmedOS_App.so( 5081): qrc:/styles/org.kde.desktop/Units.qml:100
QtQuickControlsPrivate.StyleItem is not a type

disappears but still dies.


2017-10-23 11:03 GMT-05:00 Camilo Higuita Rodriguez :

> I've been messing around more and i found out that the minimalqmake
> example dies on my desktop when in the file qtquickcontrols2.conf is set
>
> Style=Material
>
>  but if instead is set
>
> Style=Default
>
>  it works on the desktop.
>
> On android it still crashes
>
>
> 2017-10-23 9:27 GMT-05:00 Camilo Higuita Rodriguez 
> :
>
>> Hi Marco,
>>
>> did you manage to get a simple hello world (new project by qt creator"
>>> to run properly?
>>
>>
>> Yes, i can deploy any qml project with qtcreator to my android device
>> without problems.
>> The minimalqmake example crashes both on desktop and android for me.
>> on desktop: exited with code 255
>>
>> I used the same structure for qmake with another example and it all works
>> fine in the desktop, and also builds on android but crashes
>> Here's the project: https://github.com/milohr/medOS-kirigami
>>
>> I'm cloning the breeze-icons and kirigami into the 3rdparty folder, as
>> mentioned in the api doc.
>> The app builds okay on the desktop and on android, but it dies cause of
>> problems with kirigami and i get error messages when compiling like :
>>
>> Warning: QML import could not be resolved in any of the import paths:
>> org.kde.kirigami
>>
>>
>> -- Adding '/home/camilo/Desktop/medOS_App/3rdparty/kirigami/autotests/tests'
>> as QML dependency
>>
>> -- Skipping because file does not exist.
>>
>>
>> This is the full compile log: https://paste.kde.org/poec9v793
>>
>> And when it builds and installs the apk on my android device the app dies
>> with this error:
>>
>> W/libmedOS_App.so( 5081): qrc:/styles/org.kde.desktop/Units.qml:100
>> QtQuickControlsPrivate.StyleItem is not a type
>>
>>
>> This is the full application output log: https://paste.kde.org/pgpbgyczx
>>
>>
>>
>> The app on andorid dies at:
>>
>>
>> if (engine.rootObjects().isEmpty())
>>
>> return -1;
>>
>>
>> Thank you for replying back. I'm looking forward to fix this issue and start 
>> creating my Kirigami app.
>>
>>
>>
>> 2017-10-23 4:18 GMT-05:00 Marco Martin :
>>
>>> On Sun, Oct 22, 2017 at 10:10 PM, Camilo Higuita Rodriguez
>>>  wrote:
>>> > Hi,
>>> > I've been trying for the past two days to get my Kirigami application
>>> up and
>>> > working on Android. It all works fine in the desktop, but when i try to
>>> > deploy it to an android device the application dies.
>>>
>>> did you manage to get a simple hello world (new project by qt creator"
>>> to run properly?
>>>
>>> also, in the kirigami repo, i have a minimal example of application
>>> built with cmake that statically links to kirigami, under
>>> examples/minimalqmake/
>>> that has been checked to work even on machines with no kde deps
>>> installed and with android qt binaries downloaded from Qt website, so
>>> it's a good starting point
>>>
>>> >
>>> > Here's the error log:
>>> > https://paste.kde.org/prrj64zsd/p2rbd5
>>>
>>> it says "the paste is password protected"
>>>
>>> --
>>> Marco Martin
>>>
>>
>>
>

Re: Kirigami/qmake deployment on Android problems

[Camilo Higuita Rodriguez]

I've been messing around more and i found out that the minimalqmake example
dies on my desktop when in the file qtquickcontrols2.conf is set

Style=Material

 but if instead is set

Style=Default

 it works on the desktop.

On android it still crashes


2017-10-23 9:27 GMT-05:00 Camilo Higuita Rodriguez :

> Hi Marco,
>
> did you manage to get a simple hello world (new project by qt creator"
>> to run properly?
>
>
> Yes, i can deploy any qml project with qtcreator to my android device
> without problems.
> The minimalqmake example crashes both on desktop and android for me.
> on desktop: exited with code 255
>
> I used the same structure for qmake with another example and it all works
> fine in the desktop, and also builds on android but crashes
> Here's the project: https://github.com/milohr/medOS-kirigami
>
> I'm cloning the breeze-icons and kirigami into the 3rdparty folder, as
> mentioned in the api doc.
> The app builds okay on the desktop and on android, but it dies cause of
> problems with kirigami and i get error messages when compiling like :
>
> Warning: QML import could not be resolved in any of the import paths:
> org.kde.kirigami
>
>
> -- Adding '/home/camilo/Desktop/medOS_App/3rdparty/kirigami/autotests/tests'
> as QML dependency
>
> -- Skipping because file does not exist.
>
>
> This is the full compile log: https://paste.kde.org/poec9v793
>
> And when it builds and installs the apk on my android device the app dies
> with this error:
>
> W/libmedOS_App.so( 5081): qrc:/styles/org.kde.desktop/Units.qml:100
> QtQuickControlsPrivate.StyleItem is not a type
>
>
> This is the full application output log: https://paste.kde.org/pgpbgyczx
>
>
>
> The app on andorid dies at:
>
>
> if (engine.rootObjects().isEmpty())
>
> return -1;
>
>
> Thank you for replying back. I'm looking forward to fix this issue and start 
> creating my Kirigami app.
>
>
>
> 2017-10-23 4:18 GMT-05:00 Marco Martin :
>
>> On Sun, Oct 22, 2017 at 10:10 PM, Camilo Higuita Rodriguez
>>  wrote:
>> > Hi,
>> > I've been trying for the past two days to get my Kirigami application
>> up and
>> > working on Android. It all works fine in the desktop, but when i try to
>> > deploy it to an android device the application dies.
>>
>> did you manage to get a simple hello world (new project by qt creator"
>> to run properly?
>>
>> also, in the kirigami repo, i have a minimal example of application
>> built with cmake that statically links to kirigami, under
>> examples/minimalqmake/
>> that has been checked to work even on machines with no kde deps
>> installed and with android qt binaries downloaded from Qt website, so
>> it's a good starting point
>>
>> >
>> > Here's the error log:
>> > https://paste.kde.org/prrj64zsd/p2rbd5
>>
>> it says "the paste is password protected"
>>
>> --
>> Marco Martin
>>
>
>

Re: Kirigami/qmake deployment on Android problems

[Camilo Higuita Rodriguez]

Hi Marco,

did you manage to get a simple hello world (new project by qt creator"
> to run properly?


Yes, i can deploy any qml project with qtcreator to my android device
without problems.
The minimalqmake example crashes both on desktop and android for me.
on desktop: exited with code 255

I used the same structure for qmake with another example and it all works
fine in the desktop, and also builds on android but crashes
Here's the project: https://github.com/milohr/medOS-kirigami

I'm cloning the breeze-icons and kirigami into the 3rdparty folder, as
mentioned in the api doc.
The app builds okay on the desktop and on android, but it dies cause of
problems with kirigami and i get error messages when compiling like :

Warning: QML import could not be resolved in any of the import paths:
org.kde.kirigami


-- Adding
'/home/camilo/Desktop/medOS_App/3rdparty/kirigami/autotests/tests' as QML
dependency

-- Skipping because file does not exist.


This is the full compile log: https://paste.kde.org/poec9v793

And when it builds and installs the apk on my android device the app dies
with this error:

W/libmedOS_App.so( 5081): qrc:/styles/org.kde.desktop/Units.qml:100
QtQuickControlsPrivate.StyleItem is not a type


This is the full application output log: https://paste.kde.org/pgpbgyczx



The app on andorid dies at:


if (engine.rootObjects().isEmpty())

return -1;


Thank you for replying back. I'm looking forward to fix this issue and
start creating my Kirigami app.



2017-10-23 4:18 GMT-05:00 Marco Martin :

> On Sun, Oct 22, 2017 at 10:10 PM, Camilo Higuita Rodriguez
>  wrote:
> > Hi,
> > I've been trying for the past two days to get my Kirigami application up
> and
> > working on Android. It all works fine in the desktop, but when i try to
> > deploy it to an android device the application dies.
>
> did you manage to get a simple hello world (new project by qt creator"
> to run properly?
>
> also, in the kirigami repo, i have a minimal example of application
> built with cmake that statically links to kirigami, under
> examples/minimalqmake/
> that has been checked to work even on machines with no kde deps
> installed and with android qt binaries downloaded from Qt website, so
> it's a good starting point
>
> >
> > Here's the error log:
> > https://paste.kde.org/prrj64zsd/p2rbd5
>
> it says "the paste is password protected"
>
> --
> Marco Martin
>

Kirigami/qmake deployment on Android problems

[Camilo Higuita Rodriguez]

Hi,
I've been trying for the past two days to get my Kirigami application up
and working on Android. It all works fine in the desktop, but when i try to
deploy it to an android device the application dies.

I'm using qmake, because with cmake i haven't been able to get pass this
error:

/usr/share/cmake-3.9/Modules/CMakeTestCCompiler.cmake:51: error: The C
compiler
"/opt/android-sdk/ndk-bundle/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc"
is not able to compile a simple test program. It fails with the following
output: Change Dir:
/tmp/QtCreator-Dzolzo/qtc-cmake-XXyC6vei/CMakeFiles/CMakeTmp

I'm using QtCreato 4.4.1 and I'm under Arch Linux

Here's the application i'm trying to build:

https://github.com/milohr/medOS-kirigami

Apparently the error comes from here:
On android it dies cause of engine.rootObjects().isEmpty()

 engine.load(QUrl(QLatin1String("qrc:/main.qml")));

if (engine.rootObjects().isEmpty())

{

qDebug()<<"engine.load is empty";

return -1;

}else

{

qDebug()<<"engine.load is not empty";

}



Here's the error log:
https://paste.kde.org/prrj64zsd/p2rbd5

Any kind of help would be greatly appreciated.

Kirigami/qmake problems (updated)

[Camilo Higuita Rodriguez]

Hi, sorry for spamming but in my last message i was missing some
information.

I'm trying to build an application using Kirigami, but i'm stuck with a few
issues, and i thought  maybe you could help me figure out what's wrong,
since i lack experience.

I'm using qmake and QtCreator to deploy the app to my android device.
Here's the basic app template using kirigami:
https://github.com/milohr/medOS-kirigami

I'm cloning the breeze-icons and kirigami into the 3rdparty folder, as
mentioned in the api doc.

The app builds okay on the desktop and on android, but it dies because of
problems with kirigami:

The problem is found on engine.rootObjects().isEmpty()) and then it returns
-1

engine.load(QUrl(QLatin1String("qrc:/main.qml")));
if (engine.rootObjects().isEmpty())
return -1;

I get errors like this when building:

 -- Adding
'/home/camilo/Desktop/medOS_App/3rdparty/kirigami/src/controls/AbstractApplicationWindow.qml/templates/private'
as QML dependency
-- Skipping because file does not exist.
  -- Adding '/home/camilo/Qt/5.9.2/android_armv7/qml/QtQuick.2' as QML
dependency
  -- Adding
'/home/camilo/Desktop/medOS_App/3rdparty/kirigami/src/controls/AbstractListItem.qml/private'
as QML dependency
-- Skipping because file does not exist.
  -- Adding
'/home/camilo/Desktop/medOS_App/3rdparty/kirigami/src/controls/AbstractListItem.qml/templates'
as QML dependency
-- Skipping because file does not exist.

here's the full building log:
https://paste.kde.org/poec9v793

and this is the application log until the app dies:
https://paste.kde.org/pgpbgyczx


Any help would be great!

Fwd: Kirigami/qmake deployment on Android problems

[Camilo Higuita Rodriguez]

Hi,
I've been trying for the past two days to get my Kirigami application up
and working on Android. It all works fine in the desktop, but when i try to
deploy it to an android device the application dies.

I'm using qmake, because with cmake i haven't been able to get pass this
error:

/usr/share/cmake-3.9/Modules/CMakeTestCCompiler.cmake:51: error: The C
compiler "/opt/android-sdk/ndk-bundle/toolchains/arm-linux-
androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc" is not
able to compile a simple test program. It fails with the following output:
Change Dir: /tmp/QtCreator-Dzolzo/qtc-cmake-XXyC6vei/CMakeFiles/CMakeTmp

I'm using QtCreato 4.4.1 and I'm under Arch Linux

Here's the application i'm trying to build:

https://github.com/milohr/medOS-kirigami

Apparently the error comes from here:
On android it dies cause of engine.rootObjects().isEmpty()

 engine.load(QUrl(QLatin1String("qrc:/main.qml")));

if (engine.rootObjects().isEmpty())

{

qDebug()<<"engine.load is empty";

return -1;

}else

{

qDebug()<<"engine.load is not empty";

}



Here's the error log:
https://paste.kde.org/prrj64zsd/p2rbd5

Any kind of help would be greatly appreciated.