Re: Meeting on store content distribution after Monday's Plasma meeting

[Carl Schwan]

On Thursday, March 21, 2024 3:46:47 PM CET Nate Graham wrote:
> 
> For the purpose of stimulating ideas and discussion in the meeting, let
> me note down a few complementary routes that I could see us going down:
> 
> # Moderation
> have trusted experts filter out dangerous or broken content so it
> doesn't get distributed to unsuspecting users in the first place.
> Example: the distro packaging model.
> 
> This would have to be done on pling.com. It would look like a
> fundamentally different upload process involving new content being
> checked automatically against templates of allowed files and folder
> structures, and humans manually reviewing and verifying everything.
> **Feasible now, but doesn't scale well, or at all (as evidenced by the
> lack of anyone volunteering to do it during the time it's been known
> that this was an issue)**

It's a bit of a chicken and egg problem. Currently there is no way to review 
new package being uploaded before they are published, so no one can do it even 
if they wanted. Another issue is that the package is directly uploaded by the 
user, instead of doing it a bit like distros and requiring to provide an url + 
checksum which would at least ensure that the content in store is the same as 
in the linked repository.

Flathub has a manual review process to submit a new package and they are 
currently improving it so that updating the permissions also require another 
manual review (in addition to be sandboxed). I think not even from a security 
point of view, but having some quality requirement before allowing users to 
upload a package would be a good thing.

This whole discussion make me want to restart my work on an alternative store 
implementation ;)

> # Restriction
> Limit the damage that dangerous or broken content on the user's system
> can cause. Here are some examples of what could be done on the KDE side:
> 
> 1. Only allow the executable data engine to be run by widgets, not any
> other kind of QML code (e.g. logout greeters and OSDs). **Probably
> feasible**

I'm not sure it is feasible to exclude a specific data engine for non-widgets 
QML but it is also not the solution for this particular problem. If I 
understood correctly, the script was executed in this particular case by a 
widget. One thing that make plasma widgets powerful is the capability to run 
scripts, so instead of disallowing executing scripts completely, I think a 
plasmoid should declare in their metadata the script they can execute (with a 
list of regex) and if the widget tries to execute a script outside of the 
things they are allowed to, the script is simply not executed and a warning 
could be displayed. This also makes it easier for a manual review to know what 
type of script the widget will execute.

We should also do the same for HTTP request.

> 2. Because it's so security-sensitive, prevent Plasma from loading
> custom lockscreen QML code in Global Themes (as we did for custom
> KRunner QML in Plasma 5 times). **Feasible but would disable themed
> lockscreens until we roll out a new no-code theming engine**

We already have a no-code theming engine for the lockscreen which is the 
plasma style. The more advanced QML style is only really helpful when doing 
custom layouts (e.g. plasma mobile) which a no-code theming engine won't be 
able to do. The custom layout thing is only really useful for plasma mobile 
and custom shells and the idea from this MR to move this to the shell package 
makes sense to me.
https://invent.kde.org/plasma/plasma-mobile/-/merge_requests/482

> 3. Run all 3rd-party widgets in a Flatpak-like sandboxed process and
> make them use portals to interact with various parts the system **Maybe
> feasible and would only break some widgets?**

This is unfortunately from a performance point of view not possible. Maybe we 
could run instead only run the Script DataEngine in a sandboxed container? So 
instead of runing QProcess directly, do more fancy stuff with bubblewrap.

> 3. Change the `ConfigFile()` feature of Plasma scripting so that it's
> only able to touch an allow-listed set of config files in Plasma and
> maybe other KDE software, not arbitrary ones on the system. **Maybe
> feasible and would only break some Global Themes**

I don't think this would make a difference as soon as the user is able to 
inject a QML file it's game over.

> 4. Remove or disable the executable data engine and force widgets to use
> Plasma and KWin scripting APIs, or else prompt for confirmation every
> time it's used. **Probably unfeasible as it would break most 3rd-party
> widgets and/or be super annoying to users**
>
> 
> 
> # Segregation
> This would also be done on the KDE side and look like any of these:
> 
> 1. Show a much more scary warning for content that can run arbitrary
> code, such as QML Widgets and Dolphin servicemenu entries. **Feasible now**

We also need to keep in mind that saying to the user: "don't use it, it's 
dangerous" while also keeping the 

Re: Plasm 6.1 Kickoff Meeting notes

[Carl Schwan]

On Wednesday, March 13, 2024 11:49:45 PM CET Nate Graham wrote:
> On 3/11/24 10:31, Nicolas Fella wrote:
> > ## 6.1 release planning
> > 
> > Idea: Keep the megarelese?
> 
> I think there's something to it. Releasing everything at once was good
> for branding and user perception, and it seems for distros too.

Agree and after talking with some journalists they told me it is also easier 
for them to write an article about the megarelease as it contains more content 
and it's less frequent. It's also less work for me and the promo team to work 
on one announcement every 4 months than having alterning a gear and a plasma 
release every 2 months.

> 
> One thing I'd like to change is to further unify the release schedules.
> Plasma's fibonacci bugfix releases have ensured we didn't need to tell
> distros to urgently patch a ton of things because the next bugfix
> release was less than a week away, but Frameworks and Gear's longer
> release cycles didn't have that luxury. I'd like to see that kind of
> bugfix schedule at least extended to Gear.

+1 the first minor release for gear is today and we already had two bugfixes 
release for Plasma.

Carl

> Nate

Stale MRs

[Carl Schwan]

Hello,

Friendly reminder that the following repository will give you a list of 
stalled merge requests without review and is updated every week,

https://invent.kde.org/teams/gardening/gitlab/-/issues

It would be nice if some more devs would subscribe to this repo and try to 
unblock some of the pending MRs. In particular the Non-Dev MRs category where 
we should try to give new contributors feedback in a timely manner.

Cheers,
Carl

Re: KDE Gear features list

[Carl Schwan]

On Monday, November 27, 2023 10:49:04???PM CET Carl Schwan wrote:
> Hello,
> 
> I started working on the announcement for the the megarelease. For Plasma,
> Nate collected all the new user facing changes here:
> https://community.kde.org/Plasma/Plasma_6#User-facing_changes
> 
> I would appreciate if gear app maintainers and contributors could do the
> same for KDE gear: https://community.kde.org/Gear/Gear_24.02 I just need a
> link to commit, MR or bug report and a few words about the change.
> 
> I'm also working on a sliglty tweeaked format for the announcement which
> would allow to mention both the big major changes as well as more minor
> improvements than previously. So don't mind also adding more minor changes
> to the wiki page, but I can't promise I will manage to mention everything.
> 
> If you posted your progress already on a blog post (like we do in KDE PIM) a
> link to that is also great.

Thanks to all who contributed so far to the wiki page and a gentle ping to 
those who didn't yet.

Preview of the announcement is available here:
https://api.carlschwan.eu/announcements/megarelease/6/
(user: kde, password: kde)

If you think I missed something important or there are some incorrect details, 
the corresponding merge request is here ;)
https://invent.kde.org/websites/kde-org/-/merge_requests/244

Note that the screenshots are far from being the final and I will retake most 
if not all of them in the coming weeks.

Cheers,
Carl

Re: Unified internal communications channel

[Carl Schwan]

On Thursday, December 7, 2023 4:15:36?PM CET Nate Graham wrote:
> Hello everyone,
> 
> There have been a couple instances of drama this week caused by
> decisions being made without some of the relevant stakeholders knowing
> about them. In all cases, the decisions were announced, but either not
> announced in the places where all the stakeholders saw it, or not all
> stakeholders were able to notice the announcement in a place where they
> do generally pay attention.

The drama could have been avoided if the promo folks would have followed my 
recommandation to contact the relevant stakeholders in the plasma-
de...@kde.org mailing list or attend the Plasma chat meeting hapenning every 
Monday at 4 PM in the Plasma matrix/irc channel. I tried to bring this up many 
times and it was dismissed every time i brough it up and I was told that I 
didn't understood the proposed idea and that should re-read the previous 
messages. It is unfortunately a recurring pattern in the promo channel and I 
decided for now to leave the kde-promo matrix channel as I feel like I'm 
wasting my time there.

> It makes me think that maybe the KDE development community has grown so
> large that we can't reasonably expect everyone to be paying attention to
> everything, or for everyone with something to announce to know exactly
> where the people who need to know it expect to find those messages.
> 
> So perhaps this could be addressed at the source by creating a single
> unified "internal announcements" place that everyone can pay attention
> to without fear of being spammed with too many messages. In theory the
> kde-devel mailing list is one such place, but it's got more than just
> announcements, and also mailing lists aren't very accessible for a lot
> of newer contributors who didn't grow up with them.
>
> What I'm proposing is some kind of place that *only* has internal
> announcements and is very log signal-to-noise such that we can
> fearlessly recommend that *everybody* subscribe to it. In addition,
> ideally those who want to subscribe via mailing list could do so, but
> its content would automatically appear in other places too, such as
> discuss.kde.org and an invent.kde.org project. That way people can
> subscribe by whatever means is most comfortable to them.
> 
> Thoughts?

I fear this will just create a new source of information instead of unifying 
the source of information. We already have the following channels for 
announcements:

- planet.kde.org: contains release announcements, gear release schedule 
announcement from Albert as well as random development updates
- kde-code-de...@kde.org: contains mostly news about new apps and modules
- kde-de...@kde.org: contains the gear release schedule announcements and 
other technical announcements
- plasma-devel@kde.org: contains important for plasma developers and the 
meeting notes of the monday chat meeting.
- kde-commun...@kde.org contains general community (non technical) 
announcements

Adding a new channel that is either a mailing list, rss feed or a forum 
category won't help and will probably only makes it worse. It's also very 
difficult to defines that is an important internal news for the whole community 
is as it will be different for every subproject in KDE. The plasma logo 
discussion would have not been very relevant for any app developers. Similarly 
discussion about the new default database backend for Akonadi won't be 
interesting for Plasma developers but might be interesting for KMyMoney and 
other non-PIM apps using Akonadi.

Something that might help is merging the kde-core-devel and kde-devel mailing 
lists as those are very similar and should hopefully not be too complicated to 
do.

Cheers,
Carl
> 
> Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

[Carl Schwan]

On Sunday, November 5, 2023 6:01:38 PM CET Nate Graham wrote:
> On 11/5/23 07:42, Kevin Ottens wrote:
> > I was clumsily advocating for this Akademy 2021 or 2022 (can't remember
> > which).
> > 
> > This way it's clearer to application authors when they tie themselves to a
> > given workspace or not.
> > 
> > Also, isn't Elisa able to work without Baloo? It even seems to do the
> > right
> > thing if I trust its CMakeLists.txt. It has Baloo as a recommended but
> > optional dependency, and disable it altogether for Win32 builds.
> 
> Yes, Elisa also includes an internal indexer, for use on Windows and
> Android, or on *Nix when Baloo isn't installed or is disabled.
> 
> I think the original idea for the app was to delegate all the indexing
> heavy lifting to Baloo to avoid internal complication, but clearly this
> has not worked out in practice, since to be truly cross-platform, it
> can't assume that Baloo is present and active and does need its own
> indexer. So maybe the best course of action is actually to remove Baloo
> support entirely and always use the internal indexer, so that we don't
> have two different code paths.
> 
> Nate

I do not belive this is a good idea. Mostly because it means we would then 
have an indexer in Baloo and one indexer in Elisa running at the same time and 
doing something similar which is wasteful. It becomes even more of an issue 
when other apps like Peruse or Arianna start doing the same and use their own 
indexer instead of Baloo on Plasma.

This defeat the point of having a general purpose indexer in Plasma.

Cheers,
Carl

Re: Latte Dock Farewell

[Carl Schwan]

Someone is trying to step up. See 
https://invent.kde.org/plasma/latte-dock/-/merge_requests/46/ 


We probably should try to support them, instead of shutting down the project.
Cheers,
Carl

On Fri, Oct 13, 2023, at 9:01 AM, Jonathan Riddell wrote:
> A year later nobody has stepped up to help maintain this.  As I understand 
> it's not a case of simply switching to KF6 but using various internal and 
> private APIs are need closely tracked. Correct me if I'm wrong but I'd like 
> to propose to archive this project for now until a maintainer is found.
> 
> Jonathan
> 
> 
> On Sat, 30 Jul 2022 at 13:31, Nicolas Fella  wrote:
>> On 7/27/22 13:14, Aleix Pol wrote:
>> > On Wed, Jul 27, 2022 at 12:15 PM Jonathan Riddell  
>> > wrote:
>> >> Michail has announced he's not going to be developing Latte Dock in future
>> >> https://psifidotos.blogspot.com/2022/07/latte-dock-farewell.html
>> >> Thanks for all your work Michail!
>> >>
>> >> As far as we can tell Latte Dock is a popular Plasma addon.  If anyone is 
>> >> looking for a project to take on this is your chance.
>> >>
>> >> Otherwise I expect it'll stop working before too long as it uses various 
>> >> private APIs so we'll need to tell distros to stop shipping it when it 
>> >> does.
>> > Maybe someone could sit down and see which private APIs are being
>> > used? then we can make sure it's in the right side of things and it
>> > keeps working *FOREVER*.
>> >
>> > Aleix
>> 
>> I think it could make sense to add Latte to the regular Plasma release,
>> for the following reasons:
>> 
>>   - It gives us regular releases "for free", which makes sure that
>> occasional fixes/improvements actually reach users. It would be a shame
>> if those never see the users because no one feels responsible enough to
>> make a release
>> 
>> - Having Plasma and Latte in sync helps with the private API problem
>> since a release of Latte has to only support one Plasma release. See
>> e.g. the recent KPipeWire topic where Plasma wanted to remove things
>> Latte uses.

Re: semicolons and the policy that was none

[Carl Schwan]

Le mercredi 10 août 2022 à 3:57 PM, Harald Sitter  a écrit :

> Aloha,
> 
> Someone recently dug up this page from 2012
> 
> https://community.kde.org/Plasma/QMLStyle#JS_Code_Blocks
> 
> First I'd like to point out that this page isn't a policy page, if it
> was meant to be then it needs to be linked on the policies page and
> supposedly somehow agreed upon, which I don't recall this one being
> (but then I wasn't really following plasma 10 years ago).
> 
> Secondly, can we clarify our stance on semicolons?
> 
> a) we don't care, do whatever you feel like but be consistent with
> your surrounding
> b) use semicolons never [*unless required]
> c) use semicolons always
> d) use semicolons sometimes [*define sometimes]
> 
> Please cast votes

I would vote for c, it's more consistent with C++ and avoids some rare
issues where removing the semicolon creates issues. This is what I'd been
already doing for the app I maintain.

Cheers,
Carl

PS: speaking of outdated policies, we ought to maybe revisit this one
https://community.kde.org/Policies/Packaging_Policy since we provide
binary packages in some cases now

and we should probably also try to enforce this one
https://community.kde.org/Frameworks/Frameworks_Documentation_Policy
more often in kirigami and plasma frameworks


> 
> Please cast votes
> 
> I vote for a) or b) because the point of having a policy on this
> eludes me entirely
> 
> HS

Re: Can we remove or quiet down the commit bot in the chatrooms

[Carl Schwan]

Le mercredi, mai 19, 2021 8:37 PM, Nate Graham  a écrit :

> I find it rather difficult to use #plasma for chats and discussions
> because of the near-constant spam from the commit announcement bot.
>
> It's not that it's useless to have commits announced, but when it
> happens in a room where humans are interacting, it's rather disruptive
> and spammy. Maybe we could move the bot into a dedicated commit announce
> room so that the people who care about this can still see the
> announcements there?

I did something similar in kde-www and ihmo this is so much better
experience.
>
> Alternatively could we change the bot so that it sends one message for
> each commit instead of like 4 or 5?

Another alternative would be to switch from skreamer for commit notification
to the Matrix gitlab bot[1]. This provides the improvement of sending
notifications as notices in Matrix so that Matrix clients don't create
notifications for these type of messages and also display the events using
a lighter color. This would also notify us about new MR (but I guess this
is configurable if not desirable).

Carl

[1]: https://github.com/maubot/gitlab
>
> Nate

Re: 5.22 Soft Freeze

[Carl Schwan]

Le jeudi, avril 29, 2021 1:10 PM, David Edmundson  
a écrit :

> At the end of the day is the soft freeze for Plasma 5.22, with the
> beta out on the 13th of May.
>
> After this point we should avoid any huge refactors and big features
> until we split the branch.
>
> Small features and changes can still land, we just now start to be
> cautious so things can get an appropriate amount of testing before the
> beta.
>
> Also please note that we will be using the next frameworks (tagged
> this Saturday).
>
> Please do comment if anything is stuck in review and needs attention.

Also since we are now in a soft freeze period, it would be a good idea
to start collecting all the new features in a list. I created:
https://invent.kde.org/websites/kde-org/-/edit/work/plasma5-22/content/announcements/plasma/5/5.22.md?from_merge_request_iid=103

Also like I said after the 5.21 announcement, I'm not really motivated
to work on the Plasma 5.22 announcement and would enjoy, if someone else
could lead the effort of coordinating with Promo and doing the layout
and content work of the announcement.

I can probably help a tiny bit but I have been doing Plasma announcements
since 5.15 and I need a small pause.

Cheers,
Carl
>
> David

Re: qqc2-breeze-style

[Carl Schwan]

Le mardi, avril 13, 2021 1:10 PM, Arjen Hiemstra  a écrit :

> On Monday, 12 April 2021 23:26:18 CEST Carl Schwan wrote:
>
> > Le lundi, avril 12, 2021 10:20 PM, Nate Graham n...@kde.org a écrit :
> >
> > > [explicitly CCing Noah]
> >
> > And I still have the same worries as before. Building a universal theming
> > system will takes years to make in a way that won't feel like a big
> > regression for our users.
>
> It is going to take a while to develop yes. On the other hand, I do not really
> see another option. Maintaining four or more different styles also takes a lot
> of time and leads to us constantly having to reimplement stuff we already 
> fixed
> in another place.
>
> > At least for the QML engine, some part like configuring the paddings,
> > margins, borders will be relatively easy since those can be mapped to QQC2
> > easily. That will be more complicated is everything that has to do with
> > animations Just an example, implementing ripple effects, for example,
> > require js in HTML, custom shaders in QML and custom c++ code for the
> > animation in QtWidgets. Trying to abstract that will be hard but not
> > impossible.
>
> On the other hand, we barely do anything with animations in the current style.
> For starters, qqc2-desktop-style does not support animations so any animation
> from the QStyle is already missing, apart from a few that were manually added.
> Similary, Plasma's SVG themes do not have any animation as far as I know, so
> all animation in Plasma is currently custom and tied to the widget rather than
> the theme.

Yeah the lack of animations is a bit of a problem in the desktop and plasma 
style.
The breeze qqc2 is a vast improvement in this aspect.

> > Another example of a hard part will be the scrollbars. Currently just
> > looking at the different qstyle installed on my machine, I can see many
> > completely behaviors and button placements. Again it's not impossible to
> > solve by figuring out a good abstraction and adding tons of options. But at
> > the end we will end up with a list of configuration options that are passed
> > to the engine and two implementations that should be able to handle all
> > the options required to implement the existing themes.
> > here for example to support an oxygen style scrollbar (written in scss)
> > scrollbar {
> > border-width: 0;
> > item {
> > color: ...
> > }
> > top-buttons {
> > move-top: {
> > display: true;
> > icon-name: 
> > background: none;
> > }
> > move-bottom: { display: false }
> > }
> > item-background {
> > box-shadow: inner 2px 2px grey;
> > border-radius: 2px
> > background-color: ...
> > &::hover {
> > background-color: ...
> > }
> > }
> > item {
> > margin: 2px
> > width: calc(100% - 4px);
> > background-color:
> > &::hover {
> > background-color: ...
> > box-shadow: outer 2px 2px blue;
> > }
> > }
> > bottom-buttons {
> > move-top: {
> > display: true;
> > icon-name: 
> > background: none;
> > }
> > move-top: {
> > display: true;
> > icon-name: 
> > background: none;
> > }
> > }
> > }
> > This already seems like a lot of rules and I probably forgot many more...
>
> It would already be a lot simpler if we had a`scrollbar-layout` or similar
> custom property to indicate what buttons to show where. Which is a requirement
> for the CSS parser anyway, we will need support for adding custom properties
> and similar stuff. On the other hand, what I like about CSS is that it is
> completely logic-less, which makes a bunch of things simpler.

Yeah, custom css properties will be required and the parser will probably need
to be based on stylo (the rust css parser from firefox) since it's the only
one that is fast, available as a library, well tested and maintained.
>
> > A solution to reduce the number of rules to implement would be to allow
> > the engine to accept textures provided by svg files. But that brings
> > us back to the problem of it being too slow for the pinephone and require
> > some hacks to pass some parameters to the theme (for example for the
> > margins or the colors).
>
> We will need some form of image support anyway. On the other hand, if we can
> avoid using images for everything, especially things that change dimensions,
> we can avoid a lot of the slowness of the current implementation.

It's probably worth investigating if we want to support custom geometries,
if we are fine with a rust dependency, it wouldn't be that hard to convert
svg path segment to both QPainter instructi

Re: qqc2-breeze-style

[Carl Schwan]

Le lundi, avril 12, 2021 10:20 PM, Nate Graham  a écrit :

> [explicitly CCing Noah]
>
> On 3/10/21 8:52 AM, Marco Martin wrote:
>
> > On Wed, Mar 10, 2021 at 4:09 PM Nate Graham n...@kde.org wrote:
> >
> > > People go off an do their own thing in an un-coordinated manner when
> > > there is a significant problem that's not being solved, that problem has
> > > existed for a while without being addressed, and there is no clear
> > > direction or centrally coordinated plan for solving it.
> >
> > yes, that's exactly what happened and is a good warning for the future.
> > Also a good signal that we should start thinking and actually doing 
> > something
> > wrt a good theming story, which we clearly don't have.
> > To me, the most promising approach was the quick prototype Arjen did
> > back at akademy
> > https://invent.kde.org/ahiemstra/qtunifiedstyle
> > whether is something realistic to turn is something actually useful or
> > not remains to be seen.
> > We do have a ton of things to do otherwise, so is not easy to find
> > time for this, but is becoming
> > more and more important
>
> Based on other random conversations since this email thread petered out,
> it seems like we're going to end up considering qqc2-breeze-style to be
> a successful yet temporary stopgap solution from PlaMo, and continue
> using the qqc2-desktop-style theme bridge we currently have--fixing bugs
> and improving performance as needed--until we re-do and unify our whole
> theming system.
>
> On that subject, have we done any further brainstorming? I remember
> being fairly impressed with Arjen's prototype as well. I love the idea
> of finally being able to theme everything consistently, and also the
> possibility of using CSS which is simple, easily writable, and easily
> readable in a diff view without losing your mind :)
>
> As I understand it, here's the latest proposal:
>
> 1.  We make a universal theme of some sort (using CSS, QML, or something
> else; exact format TBD)
>
> 2.  We make a QStyle that is essentially a Kvantum-style theming engine
> that consumes the universal theme and applies it to Widgets-based
> apps
>
> 3.  We make a QQC2 style that consumes the universal theme and applies it
> to QtQuick software, including (optionally) Plasma, without going
> through QPainter or the QStyle at all
>
> 4.  We keep the existing Plasma QQC2 style that knows how to consume
> existing SVG-based Plasma themes, for compatibility's sake
>
> 5.  We add a user-facing setting for apps to allow people to choose
> whether to have:
> -   Their apps use the universal theme
> -   Their apps use a different QStyle, such as Lightly or Kvantum
> 6.  We add a user-facing setting for Plasma to allow people to choose
> whether to have:
> -   Plasma use the same universal style as their apps
> -   Plasma use a different universal style from the one being used for
> their apps
>
> -   Plasma use an SVG-based Plasma 5 theme, which we deprecate in
> Plasma 6 but continue to support
>
> 7.  In Plasma 7, we sunset support for SVG-based Plasma themes as well as
> generic QStyles (including Kvantum!) and only support the new
> universal theme--whatever it is we come up with
>
> Am I representing everything accurately, to the best of everyone else's
> memory?
>
> Nate
>

And I still have the same worries as before. Building a universal theming
system will takes **years** to make in a way that won't feel like a big
regression for our users.

At least for the QML engine, some part like configuring the paddings, margins,
borders will be relatively easy since those can be mapped to QQC2 easily.
That will be more complicated is everything that has to do with animations
Just an example, implementing ripple effects, for example, require js in HTML,
custom shaders in QML and custom c++ code for the animation in QtWidgets.
Trying to abstract that will be hard but not impossible.

Another example of a hard part will be the scrollbars. Currently just looking
at the different qstyle installed on my machine, I can see many completely
behaviors and button placements. Again it's not impossible to solve by
figuring out a good abstraction and adding tons of options. But at the end
we will end up with a list of configuration options that are passed to the
engine and two implementations that should be able to handle **all** the
options required to implement the existing themes.

here for example to support an oxygen style scrollbar (written in scss)

scrollbar {
 border-width: 0;
 item {
color: ...
 }
 top-buttons {
   move-top: {
 display: true;
 icon-name: 
 background: none;

   }
   move-bottom: { display: false }
 }
 item-background {
box-shadow: inner 2px 2px grey;
border-radius: 2px
background-color: ...
&::hover {
  background-color: ...
}
 }
 item {
margin: 2px
width: calc(100% - 4px);
background-color:
&::hover {
  

Re: Plasma 5.22 Kickoff Notes

[Carl Schwan]

Le mercredi, mars 10, 2021 10:56 AM, Marco Martin  a 
écrit:

> I knew from a long time it was to be the default style on plamo.. I
> never really agreed to default to it on plasma mobile but since looked
> like it was the majority decision i didn't oppose it too much (even
> qqc2-desktop-style would be fine on plamo for now, there may have been
> issues with using the plasma style )
> A QQC2 style is not a plasma style, it's something that is very
> difficult to maintain .. almost as much as a qstyle, really.
>
> Now having this style in workspace puts all of us quite in a big
> maintenance burden, throws away all the fixes done through the years
> in qqc2-desktop-style, makes more difficult to identify where a bug
> actually is and makes qml apps more inconsistent with qwidget ones.
> Using it as default on the desktop would be a huge mistake as well,
> would make hunting any bug much more difficult, putting a maintenance
> burden and time sync that should be used instead to solve the issue of
> how we really want to do themes, as this approach is really not
> sustainable.
>
> The real core issue is:
> qqc2-desktop-styles are not suitable for generic 3rd party theming.
> The name suggests otherwise, but that's simply not true.
> they can control too much of the behavior of controls, to the point of
> even adding new api if they desire so., and making applications to not
> start at all if they contain any error (or even if the style uses a
> qqc2 import version older than what the app uses)
> so, every platform should really maintain one, as the effort to have a
> correct one is huge already. (oh, and they can't be switched a runtime
> without restarting the app)
>
> For a 3rd party theming, is needed really something else way more
> limited (and the fact that's more limited it's a feature)
> something based upon some combination of css and images is really the
> only proper way forward i can see.
> And working towards a style that gives that, to me is a way better way
> to spend hundreds of hours of development into.

I know that this topic has been discussed many times already but I don't
think there is any perfect solutions for QQC2 theming of applications.

qqc2-desktop-style has the advantage of using in a few places the QStyle
so some controls are looking native but in an usual Kirigami application
many other components are looking the same as Breeze. You are for example
still getting the new ToolArea from Plasma 5.21 even when using GTK2 QStyle.
Since it is basically using the QPainter API, it is slower and use more
memory than an optimized QQC2 theme would.

qqc2-plasma theme tries to make it easy to create themes by just using
svg so that it should be possible to only use Inkscape to make one but
unfortunately I think this fails because to make a plasma theme you need
to understands many internal things to the theming engine. For example
how to name every components, how the margin indicator works, what magic
elements need to be added to change the behavior, ... There is also the
problems of the themes not designed for Application UI but for Plasma so
they looked horribly wrong on Plasma Mobile and using more memory than
an optimized qqc2 theme.

qqc2-breeze-style has the problem of more maintenance cost and diverging
from the normal breeze style, but at least it is efficient and looks
good. So from an end user point of view for Plasma Mobile it is good. A
problem I see is that for users to customize the look of the applications,
more qqc2 will need to be developed and this isn't an easy task (but developing
a QStyle or Plama theme isn't easy either).

A qqc2 css theme doesn't exist yet and I don't think this is a solution
either. A css theme contains a set of rules and we would need to develop
a qqc2 theme reading and supporting many rules. Currently the proof of
concept use a ShadowedRectangle to support a few rules (shadow, border
and colors), but if we want to make it viable to use, we wold need to
be able to configure many more rules: customizing the width, color, style
every border of a rectangle, the sizing of every elements, animations,
transition, gradiant, background image, positioning, shadows, ... And
those are non trivial thing to solve in both QML and QtWidgets world
and more importantly making each control use this heavy weight QML components
probably won't be cheap in term of performance. So we might end up with
something too slow to be usable.

Carl Schwan

>
> The fact that things like that are needed to keep the VDG kids
> excited, is not an argument, we really cannot compromise the
> quality for the sake of that.
>
> On Wed, Mar 10, 2021 at 10:21 AM David Redondo k...@david-redondo.de wrote:
>
> > Thank you for your opinion Marco.
> > Am Mittwoch, 10. März 2021, 09:30:35 CET schrieb Marco Martin:
> >
> > > wasn't present at t

Re: releaseme license clarifications

[Carl Schwan]

I'm fine with it

 Original Message 
On 24 Feb 2021, 1:29 PM, Harald Sitter wrote:

> Yo! If you are in the CC list please respond whether you are ok with the 
> licenses or not. I'm in the process of moving releaseme to reuse compliance 
> and need y'all to approve the following clarifications on the plasma 
> extensions inside releaseme. They are all following the general guidelines we 
> have for licensing That is: all random data and configs are CC0-1.0. All 
> programs/scripts are our GPL triplet. The plan would also relicense 4 files: 
> plasma-changelog, plasma-update-versions, plasma-update-versions-kf5 and 
> plasma-xenon-download. All of these are presently marked public domain but 
> since that isn't a license and altogether unclear vis a vis legal meaning in 
> a global context I propose they be relicensed to the GPL triplet instead. 
> List of files with proposed license and applicable authors, as per git: 
> .gitignore CC0-1.0 Jonathan, Harald README.md CC0-1.0 Jonathan, Thomas, 
> Harald lib/releaseme/data/release_help.txt.erb CC0-1.0 Aleix, Harald 
> lib/releaseme/data/ticket_description.txt.erb CC0-1.0 Jonathan, Harald 
> plasma/Gemfile CC0-1.0 Jonathan plasma/README CC0-1.0 Jonathan, David, Harald 
> plasma/VERSIONS-lts.inc CC0-1.0 Jonathan, David, Carl 
> plasma/VERSIONS-normal.inc CC0-1.0 Jonathan, Harald, Bhushan, Carl 
> plasma/create_log.py GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Albert, Jonathan, David, Bhushan, Carl 
> plasma/create_sources_inc CC0-1.0 Jonathan, Harald 
> plasma/git-repositories-for-release CC0-1.0 Jonathan, David, Bhushan 
> plasma/git-repositories-for-release-lts CC0-1.0 Jonathan, David 
> plasma/git-repositories-for-release-normal CC0-1.0 Jonathan, David 
> plasma/lib/plasma-tag-test.rb GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan plasma/plasma-branch GPL-2.0-only OR 
> GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL Jonathan plasma/plasma-changelog 
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL Jonathan, 
> Bhushan, Harald plasma/plasma-dot-story GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan, David plasma/plasma-release 
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL Jonathan, Carl, 
> Bhushan plasma/plasma-branch-webpages GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan plasma/plasma-tag GPL-2.0-only OR 
> GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL Jonathan plasma/plasma-tag-test 
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL Jonathan 
> plasma/plasma-tars GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan, Harald plasma/plasma-update-1-tar 
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL Jonathan 
> plasma/plasma-update-versions GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan, Harald, Bhushan 
> plasma/plasma-update-versions-kf5 GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan, Harald, Bhushan 
> plasma/plasma-xenon-download GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan plasma/templates/plasma-changelog.md 
> CC0-1.0 Carl plasma/templates/plasma_announce_template.md.erb CC0-1.0 Carl, 
> Jonathan plasma/templates/plasma_info_template.md.erb CC0-1.0 Carl, Jonathan 
> plasma/update-web-svn GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan, Carl projects/kdeedu-data.yml CC0-1.0 
> Jonathan projects/plasma-mediacenter.yml CC0-1.0 Jonathan projects/plasma.yml 
> CC0-1.0 Jonathan test/plasma-tag-test-test.rb GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan test/translationunit_test.rb 
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL Jonathan, Harald 
> test/plasma-webpages_test.rb GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Jonathan, Harald, Bhushan, Carl 
> plasma/plasma-webpages GPL-2.0-only OR GPL-3.0-only OR 
> LicenseRef-KDE-Accepted-GPL Harald, Jonathan, Carl

Re: Synchronized release schedule for Plasma

[Carl Schwan]

Le jeudi, janvier 7, 2021 12:28 PM, niccolo  a écrit :

> Hi,
> sorry to bring this up again, but I would be in favor of a switching to 2 
> releases every year. I'd like to add some reasons to do that on the 
> promotional side:
> 1) In Promo, we are quite stepping up our game in the quality of 
> announcements, to both the website and the release video. We are already a 
> bit stretched out with time, and having more of that to prepare each release 
> would benefit us, especially if we intend - and I think we do - to improve 
> our work even further.

I don't agree. The problem is that we are always starting working on an 
announcement too late. If we were starting more early writing the announcement, 
it would be easier.

> 2) We have measured that doing less announcements every year usually gives 
> those more engagement; we'd expect a good rise of that if we switch from 3 to 
> 2 yearly.

This is the case for 'release service' announcements. Plasma announcements are 
getting more and more engagement. Also I'm not sure that having if we were to 
make 2 announcements instead of 3, the engagement would be more then 50% higher.

> 3) Finally, we also expect higher engagement if we have more big features to 
> promote. In all the releases I've worked on, I always felt - yes, this is 
> subjective - that the changes were not quite enough to make the user go "wow" 
> (we are generally talking about 2/4 big features each release). Bringing that 
> up by ~50% would help a lot.

The Plasma 5.21 announcements, I have been working on, is already big enough, 
so don't worry :) Large set of big features also means more chance of big 
regressions, big announcements to translate, ...

> 4) It is much easier to explain to the users that they are going to get the 
> new features soon in an announcement, if major distributions such as Ubuntu 
> and Kubuntu have the new release ready soon, rather than having to wait 
> months to actually get them.

I'm not convinced but I might be biased since I believe full rolling 
distributions are the only way forward for most end users.

> I would also suggest switching to 6 months from a developer point of view, 
> but here I'd prefer to only argue the benefit in the promotional side, adding 
> up to the advantage of synced release frequency with distributions. It 
> doesn't make much sense to be annoyed that your changes do not reach the 
> users in time in a 6 months release cycle, when you currently have to wait 
> about the same amount of time, changing every time, before that version gets 
> picked up by major distributions with most users, as said before.

Cheers,
Carl

> Thanks,
> Niccolò
>
> p.s.: my mail could be arriving with a big delay and duplicated; if so, I'm 
> sorry, I did some confusion with my different email addresses.
>
> From "Plasma-devel" plasma-devel-boun...@kde.org
> To "plasma-devel" plasma-devel@kde.org
> Cc kde-de...@kde.org
> Date Tue, 1 Dec 2020 16:01:29 +
> Subject Re: Synchronized release schedule for Plasma
>
> We discussed this in the Plasma meeting on Monday and I'm afraid there's 
> little appetite in moving to a 6 monthly release or a 3 monthly release.  We 
> did used to have a 3 monthly schedule but that is too tight given the length 
> of beta and freezes we want to have now.  But also 6 monthly feels too long, 
> for distros that miss the release that become a long time that we have users 
> on an older release. 
>
> Having said that if there's occasions where we can shift a release a bit to 
> help distros we're happy to do that.
>
> Jonathan

Re: plasma-systemmonitor in kdereview

[Carl Schwan]

Le jeudi, octobre 1, 2020 11:36 AM, Arjen Hiemstra  a écrit 
:

> Hello,
>
> I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can
> be found at https://invent.kde.org/plasma/plasma-systemmonitor .
>
> plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes
> use of the ksystemstats daemon and the faces system for system monitor
> plasmoids that were both introduced in Plasma 5.19.
>
> Our current plan is to do a "preview release" alongside Plasma 5.20, then have
> it be an official part of Plasma with 5.21.

Plasma System Monitor looks quite good, but it doesn't look like it is navigable
with the keyboard only. I know that some of the issues are caused by Kirigami 
and
Qml but it looks like many custom components can't get any focus with tab and 
need
the mouse to work.

It is also normal for Table component to import private api from 
qqc2-desktop-style
framework?

https://invent.kde.org/plasma/plasma-systemmonitor/-/blob/master/src/table/FirstCellDelegate.qml#L13

Cheers,
Carl

>
> Cheers,
> Arjen

D28305: Systemd Startup

[Carl Schwan]

ognarb added a comment.


  I guess this was merged here: 
https://invent.kde.org/plasma/plasma-workspace/-/commit/256b6e1738d907cd2e4aaa0e89f113f096473258.
 So we can close this MR :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: ognarb, peterhoeg, hchain, apol, ahiemstra, benjaminberg, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

Licensing clarification in Plasma Vault

[Carl Schwan]

Hello Kees vd Broek,
you contributed to the file kded/ui/backendchooserwidget.ui in the plasma vault 
project,
we are currently converting all the license statements and unfortunately, it 
seems that
this file didn't contain a license statement.

The file can be found here: 
https://invent.kde.org/plasma/plasma-vault/-/blob/master/kded/ui/backendchooserwidget.ui

Do you agree to license this file under GPL-2.0, GPL-3.0, or any later version 
of the GPL
accepted by the membership of KDE e.V.?
(Reuse statement: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL)

If you could reply to this email and make sure plasma-devel@kde.org is in CC
or directly reply to this MR: 
https://invent.kde.org/plasma/plasma-vault/-/merge_requests/7.

Thanks for contributing to KDE,
Carl

D29466: [applets/appmenu] Add search to global application menu

[Carl Schwan]

ognarb added a comment.


  What is the state of this MR?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: ognarb, Leon0402, trmdi, nicolasfella, gikari, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Carl Schwan]

ognarb added a comment.


  Ping? it would be sad to see this good work lost :(

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28686: [Battery Monitor] Choose better wording

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  Change makes sense to me, IIRC Kai doesn't have much time for KDE anymore

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham, ognarb
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Carl Schwan]

ognarb added a comment.


  I rebased this merge request on top of master and moved it to gitlab. 
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/37
  
  I see a major problem to move forward with this patch, not all the files have 
a license header and as such can't be merged. @gpark do you agree with me using 
your work under the GPL-2.0-or-later license?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: ognarb, davideichelsdoerfer, yerilov, kucharczyk, lavender, ngraham, apol, 
plasma-devel, hein, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D29625: Add global shortcut

[Carl Schwan]

ognarb added a comment.


  I think khotkeys is deprecated: https://phabricator.kde.org/T2050

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Carl Schwan]

ognarb added a comment.


  CC-0 or any license compatible with CC-BY-SA-4.0 are fine.
  
  The Unsplash license is non-free too: "This license does not include the 
right to compile photos from Unsplash to replicate a similar or competing 
service. ".

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Carl Schwan]

ognarb added a comment.


  Photo using the Unsplash licence can't be included in our repositories. The 
license is not consired open source :(

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29203: kirigami.pri: Add missing includes

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29203

To: patrickelectric, apol, mart, cblack, ognarb
Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28806: Provide light icon for dark mode via theme_icons

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  For reference this is the bug report in firefox for adding js scripting: 
https://bugzilla.mozilla.org/show_bug.cgi?id=1416871

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28806

To: broulik, #plasma, fvogt, ognarb, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

[Carl Schwan]

ognarb added a comment.


  > I'd like to solve that by removing the sidebar and adding a back button, 
but that would be for another patch in the future.
  
  -1 from me to remove the sidebar. I really liked how the sidebar looked in 
the final mockup in T10470  and it is 
consistent with the Kirigami collapsible sidebar drawer  (only the color is 
wrong) F8215991: image.png  F8216863: 
image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: ognarb, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28211: [applets/systemtray] Make Pin button a bit larger

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  +1 for using standard size instead of using an hardcoded size.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  normal-sized-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28211

To: ngraham, #vdg, #plasma, ognarb
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> ActionToolBarLayoutDetails.qml:126
> +
> +if (modelData.hasOwnProperty("displayHint") &&
> +
> modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide)) {

I think this can be simplified to

  return !modelData.hasOwnProperty("displayHint") || 
!modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide;

> ActionToolBarLayoutDetails.qml:180
> +}
> +if (modelData.hasOwnProperty("displayHint")
> +&& 
> modelData.displayHintSet(Kirigami.Action.DisplayHint.KeepVisible)) {

same here

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27653

To: ahiemstra, #kirigami
Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D27265: Use Kirigami.PasswordField instead of plain text field

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:5fbc994c959a: Use Kirigami.PasswordField instead of plain 
text field (authored by ognarb).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27265?vs=75301=75316

REVISION DETAIL
  https://phabricator.kde.org/D27265

AFFECTED FILES
  mobile/wifi/package/contents/ui/PasswordField.qml

To: ognarb, jgrulich, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27265: Use Kirigami.PasswordField instead of plain text field

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
ognarb requested review of this revision.

REVISION SUMMARY
  Allow showing the plain text password when typing (optional)

TEST PLAN
  :(

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  passwordfield

REVISION DETAIL
  https://phabricator.kde.org/D27265

AFFECTED FILES
  mobile/wifi/package/contents/ui/PasswordField.qml

To: ognarb, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27011: Update plasma startup sequence README

[Carl Schwan]

ognarb added a comment.


  I think I found some small typos

INLINE COMMENTS

> README:25
> +which may be 0, 1 or 2 (the default). Kded phase 0 means the module is
> +always loaded by kded, even outside of KDE session. It should used only
> +by kded modules which must be always running. Kded phase 1 modules are

It should used -> It should be used

> README:37
> +
> +StartPlasma finaly then spawns plasma-session that takes care of the rest of 
> the process.
> +

finaly -> finally

> README:63
> +After this session restore is triggered. i.e. launching all applications that
> +were running during last session saving (usually logout).
> +

during last session -> during the last session

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27011

To: davidedmundson
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2

[Carl Schwan]

ognarb added a comment.


  Thanks for the review :) I will create a follow up patch with the ComboBox 
port when I figure that is going wrong with my desktop theme.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25778

To: ognarb, #vdg, #plasma, davidedmundson
Cc: davidedmundson, GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:3e0877c9c99d: refactor(lookandfeelexplorer): Port almost 
entire look and feel explorer to QQC2 (authored by ognarb).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25778?vs=71733=71739

REVISION DETAIL
  https://phabricator.kde.org/D25778

AFFECTED FILES
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml

To: ognarb, #vdg, #plasma, davidedmundson
Cc: davidedmundson, GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

[Carl Schwan]

ognarb updated this revision to Diff 71733.
ognarb marked 2 inline comments as done.
ognarb added a comment.


  - fix naming

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25778?vs=71732=71733

BRANCH
  arcpatch-D25778

REVISION DETAIL
  https://phabricator.kde.org/D25778

AFFECTED FILES
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml

To: ognarb, #vdg, #plasma
Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> guoyunhe wrote in MetadataEditor.qml:108
> This need to be changed to `QQC2.ComboBox`

I tried but I get

  Type QQC2.ComboBox unavailable
  60: StylePrivate.PropertyWriter is not a type

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25778

To: ognarb, #vdg, #plasma
Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

[Carl Schwan]

ognarb updated this revision to Diff 71732.
ognarb marked 2 inline comments as done.
ognarb added a comment.


  - Use same button width as for the text field
  - Fix dialog not closing
  - Improve margin

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25778?vs=70999=71732

BRANCH
  arcpatch-D25778

REVISION DETAIL
  https://phabricator.kde.org/D25778

AFFECTED FILES
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml

To: ognarb, #vdg, #plasma
Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24238: Port the pager applet away from QtWidgets

[Carl Schwan]

ognarb added a comment.


  This patch maybe created this bug: https://bugs.kde.org/show_bug.cgi?id=414849

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24238

To: dfaure, hein, apol
Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> main.qml:46
>  titleIcon: "preferences-desktop-theme"
> +modal: true;
> +collapsible: false;

This sadly didn't work :(

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25778

To: ognarb, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  I wasn't able to convert the conbox box :(
  
  I'm getting a strange error

TEST PLAN
  Screenshot comming

REPOSITORY
  R118 Plasma SDK

BRANCH
  qqc2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25778

AFFECTED FILES
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25692: Rename Look and Feel Explorer to Plasma Global Theme Explorer

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:49a2d8a4988a: Rename Look and Feel Explorer to Plasma 
Global Theme Explorer (authored by ognarb).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25692?vs=70774=70797

REVISION DETAIL
  https://phabricator.kde.org/D25692

AFFECTED FILES
  lookandfeelexplorer/package/metadata.desktop

To: ognarb, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25692: Rename Look and Feel Explorer to Plasma Global Theme Explorer

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

TEST PLAN
  not tested

REPOSITORY
  R118 Plasma SDK

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25692

AFFECTED FILES
  lookandfeelexplorer/package/metadata.desktop

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Carl Schwan]

ognarb added a comment.


  :)

INLINE COMMENTS

> CMakeLists.txt:2
>  # KI18N Translation Domain for this library
> +# KI18N Translation Domain for this library
>  add_definitions(-DTRANSLATION_DOMAIN=\"kcmaccess\")

Duplicate line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25392: [414174] - Panel background transition color bug

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:a21f46d85ff8: [414174] - Panel background transition 
color bug (authored by acemond, committed by ognarb).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25392?vs=69977=70004

REVISION DETAIL
  https://phabricator.kde.org/D25392

AFFECTED FILES
  containment/package/contents/ui/PanelBox.qml

To: acemond, mvourlakos
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25392: [414174] - Panel background transition color bug

[Carl Schwan]

ognarb added a comment.


  @acemond you need to wait for @mvourlakos to commit the change. You should 
also provide your authorship information name and email address.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D25392

To: acemond, mvourlakos
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25104: Fix PageRow globalToolBar documentation

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb
Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D24720: [applets/systemtray] Rewrite popups with layouts

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:48
> +//Menu mode
> +if (!activeApplet && hiddenItemsView.visible && 
> LayoutMirroring.enabled === false) {
> +return units.smallSpacing;

!LayoutMirroring.enabled instead of === false

> ExpandedRepresentation.qml:136
> +Layout.fillHeight: true
> +Layout.leftMargin: hiddenItemsView.visible && activeApplet && 
> LayoutMirroring.enabled === false ? units.largeSpacing : 0
> +Layout.rightMargin: hiddenItemsView.visible && activeApplet && 
> LayoutMirroring.enabled === true ? units.largeSpacing : 0

Same

> ExpandedRepresentation.qml:137
> +Layout.leftMargin: hiddenItemsView.visible && activeApplet && 
> LayoutMirroring.enabled === false ? units.largeSpacing : 0
> +Layout.rightMargin: hiddenItemsView.visible && activeApplet && 
> LayoutMirroring.enabled === true ? units.largeSpacing : 0
>  }

Same

REPOSITORY
  R120 Plasma Workspace

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg, ngraham
Cc: ognarb, ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

Re: Discover and KSysGuard in kde.org/applications?

[Carl Schwan]

Since neither Discover nor KSysguard has a website, having both applications in 
kde.org/applications would allow both applications to still have a 'web 
presence'. This can be useful if we want to link to Discover from somewhere 
else.

And kde.org/applications is not only display applications part of KDE 
Applications, but also extragear stuffs, so I don't see it as a problem to also 
display applications that are part of Plasma.

Carl

 Original Message 
On 18 Oct 2019, 23:03, Aleix Pol < aleix...@kde.org> wrote:
On Fri, Oct 18, 2019 at 2:11 PM Jonathan Riddell  wrote:
>
> Would Plasma team like these listed on the KDE Apps webpage? So far I've not 
> had them because Plasma is a product of KDE that is not a standalone app.
Hi Jonathan,
I would say it's okay that they are not, I agree with your resoning.
At least Discover. But I can be persuaded otherwise.
Aleix

publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys

D24766: Revert change to make the notification persistent

[Carl Schwan]

ognarb added a comment.


  +1 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24766

To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Carl Schwan]

ognarb added a comment.


  I would add text on the button e.g "Show more", otherwise it's quite 
difficult to know how to show more apps

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24499: Do not warn about LayoutDirection in SearchField

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  Thanks

REPOSITORY
  R169 Kirigami

BRANCH
  searchfield_nowarning

REVISION DETAIL
  https://phabricator.kde.org/D24499

To: ahiemstra, #kirigami, broulik, ognarb
Cc: ognarb, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D24192: WIP: Active page follow the focus

[Carl Schwan]

ognarb added a subscriber: mart.
ognarb added inline comments.

INLINE COMMENTS

> PageRow.qml:172
> +print("focus not current item");
> +root.removePage(columnView.currentItem);
> +print("pop");

@mart removePage doesn't work well, how can I change the current page?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24192

To: ognarb, #kirigami, #plasma_accessibility
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, hein

D24192: WIP: Active page follow the focus

[Carl Schwan]

ognarb created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  This doesn't work well yet.
  
  - Need a long time (2-4 seconde) before the page is updated
  - Loss focus after changing page

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24192

AFFECTED FILES
  src/controls/PageRow.qml

To: ognarb
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24165: Add SettingsUtil utility class

[Carl Schwan]

ognarb added a comment.


  +1 but I couldn't test it (changed my distro recently and can't get pbi to 
work yet).
  
  The js class is available in firefox since Firefox 45 
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes#Browser_compatibility
 so it should work in firefox esr

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24165

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  It's a huge improvement. You shouldn't forget to add your copyright to some 
files.

REPOSITORY
  R118 Plasma SDK

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham, ndavis, ognarb
Cc: ognarb, GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, 
ngraham, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24011: Provide a telemetrics kcm module for Plasma

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> main.qml:46
> +wrapMode: Text.WordWrap
> +text: i18n("We make Plasma for you. You can help us improve it 
> by contributing information on how you use it. This allows us to make 
> sure we focus on things that matter to you. Contributing statistics is of 
> course entirely anonymous, will not use any kind of unique identifier and 
> will not cover any data you process with this application.")
> +}

strange  tag in the text

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24011

To: apol, #plasma, vkrause
Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23151: Implement Web Share API through Purpose

[Carl Schwan]

ognarb added a comment.


  I will try to find time to test it today

INLINE COMMENTS

> content-script.js:24
> +return '--4xxx-yxxx-'.replace(/[xy]/g, 
> function(c) {
> +var r = Math.random()*16|0, v = c == 'x' ? r : (r&0x3|0x8);
> +return v.toString(16);

var -> const

> content-script.js:148
>  
> -// we give our transfer div a "random id" for privacy
> -// from 
> https://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript
> -var mediaSessionsTransferDivId 
> ='--4xxx-yxxx-'.replace(/[xy]/g, function(c) {
> -var r = Math.random()*16|0, v = c == 'x' ? r : (r&0x3|0x8);
> -return v.toString(16);
> -});
> +var mediaSessionsTransferDivId = generateGuid();
>  

var -> let

> content-script.js:852
> +//
> +var purposeTransferDivId = generateGuid();
> +var purposeTransferClassName = "p" + purposeTransferDivId.replace(/-/g, "");

var -> let

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23151

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:e649d5a706b6: Improve keyboard navigation (authored by 
ognarb).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23975?vs=66154=66158

REVISION DETAIL
  https://phabricator.kde.org/D23975

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/main.qml

To: ognarb, #plasma, #plasma_accessibility, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

ognarb added a comment.


  Thanks, I will try to send a kirigami patch, if I don't send anything before 
the next weekend consider that I forgot ;p

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23975

To: ognarb, #plasma, #plasma_accessibility, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

ognarb added a comment.


  Looking at the behavior more in details. The 'bug' with a smaller screen 
should be fixed in kirigami instead. The focus is correct and I can move back 
the main category and select anoter subcategory.  The problem is that Kirigami 
pageStack should display the page that as focus automaticly.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23975

To: ognarb, #plasma, #plasma_accessibility
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

ognarb planned changes to this revision.
ognarb added a comment.


  In D23975#532059 , @ngraham wrote:
  
  > Definitely better than before!
  >
  > One use case still doesn't work though: Returning to the first column of 
the sidebar when you're in the second column and only a single column is 
visible (i.e. because the window is unmaximized).
  
  
  Good catch, I will try to fix this case too.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23975

To: ognarb, #plasma, #plasma_accessibility
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Since the tab view is dead, we should improve the keyboard navigation of the 
sidebar view

TEST PLAN
  Played a bit with it, it looks like it's working.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23975

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/main.qml

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: New Plasma Desktop website

[Carl Schwan]

Hi,

I don't think that removing the two first images is a good idea. The second 
image is used to link to the latest announcement and if I only remove the first 
image, the user when landing on the page will not see a screenshot of Plasma 
without scrolling.

I now changed the Plasma wallpaper for the first screenshot so that I don't 
overpromote the Ice Cold wallpaper and this also makes the page less version 
specific (less work after each release).

Cheers

Carl

‐‐‐ Original Message ‐‐‐
On Saturday, September 14, 2019 3:10 PM, Christoph Feck  wrote:

> On 09/14/19 14:38, Carl Schwan wrote:
> 

> > I finalized the first version of the new plasma-desktop webpage, a preview 
> > is available at https://kde.carlschwan.eu/plasma-desktop. There are still 
> > two parts missing (p-b-i and privacy) and some possible improvement that I 
> > would like to add later. Can I get approval from the Plasma team to land 
> > the current state?
> 

> Nice work! I would remove the first two images, since they don't show
> anything that isn't already shown in the first Laptop screenshot. They
> basically only show the Ice wallpaper.



publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

New Plasma Desktop website

[Carl Schwan]

Hello Plasma team,

It was nice to meet you all to the Akademy, I hope you had all a safe travel 
back home and see you all next year. :p

I finalized the first version of the new plasma-desktop webpage, a preview is 
available at https://kde.carlschwan.eu/plasma-desktop. There are still two 
parts missing (p-b-i and privacy) and some possible improvement that I would 
like to add later. Can I get approval from the Plasma team to land the current 
state?

Cheers,

Carl Schwan



publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

D23799: Get rid of khtml usage (kill classic mode)

[Carl Schwan]

ognarb added a comment.


  +1
  is there a task somewhere where we can track all the KDE projects still  
using khtml?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma
Cc: ognarb, ngraham, #plasma, GB_2, sitter, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23714: Manipulate Document prototype for createElement

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  Tested in a modern browser and it still works

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23714

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23651: WIP: Add support for a theming in Kicker Dashboard

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  - Replace hardcoded color with Kirigami.Theme.*
  - Replace search bar with Kirigami.Search
  
  I tried to use PlasmaCore.Theme but this didn't work

TEST PLAN
  Screenshot comming

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kicker-dask-theme-support

REVISION DETAIL
  https://phabricator.kde.org/D23651

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/DashboardTabButton.qml
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemMultiGridView.qml

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23345: Fix mpris plugin in Firefox when Content-Security-Policy is enabled

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:a14c58b1d5f2: Fix mpris plugin in Firefox when 
Content-Security-Policy is enabled (authored by ognarb).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23345?vs=64297=64853

REVISION DETAIL
  https://phabricator.kde.org/D23345

AFFECTED FILES
  extension/content-script.js

To: ognarb, broulik, fvogt
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  Much better now thanks :)

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  window-button-symbolics (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23451

To: cblack, #breeze, #vdg, ngraham, ognarb
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

[Carl Schwan]

ognarb added a comment.


  Could it be possible to remove most of the code duplication between 
_window_decorations.scss and _chromium.scss?

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  window-button-symbolics (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23451

To: cblack, #breeze, #vdg, ngraham
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23345: Fix mpris plugin in Firefox when Content-Security-Policy is enabled

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Credit to kbroulik, he did all the work.

TEST PLAN
  Tested in firefox, chromium with Nextclould Music and Youtube

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23345

AFFECTED FILES
  extension/content-script.js

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23318: Add dark theme in the extension popup

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:02ea1012348d: Add dark theme in the extension popup 
(authored by ognarb).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23318?vs=64209=64210

REVISION DETAIL
  https://phabricator.kde.org/D23318

AFFECTED FILES
  extension/action_popup.css

To: ognarb, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23318: Add dark theme in the extension popup

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

TEST PLAN
  Tested in firefox

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  darkTheme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23318

AFFECTED FILES
  extension/action_popup.css

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23126: Add browser action for status reporting

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  For the png problem it was because I had a navbar with the same color.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23126

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23126: Add browser action for status reporting

[Carl Schwan]

ognarb added a comment.


  Tested in Firefox:
  
  The PNG is not displayed.
  
  I'm not a fan of using string as enum value (portStatus).

INLINE COMMENTS

> action_popup.css:22
> +
> +section {
> +padding: 1em;

Not used

> ognarb wrote in action_popup.css:32
> Why it is empty?

Or maybe add a breezy background-color :)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23126

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23126: Add browser action for status reporting

[Carl Schwan]

ognarb added a reviewer: ognarb.
ognarb added a comment.


  I will provide more feedback tomorrow, when I have more time.

INLINE COMMENTS

> action_popup.css:32
> +
> +main {
> +

Why it is empty?

> action_popup.css:45
> +}
> +.message.error {
> +

same

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23126

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23049: Add Kirigami ListSectionHeader component

[Carl Schwan]

ognarb added a comment.


  It's a new version so probably 2.9 everywhere

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart
Cc: ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, 
domson, dkardarakos, apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSectionHeader component

[Carl Schwan]

ognarb added a comment.


  Something is probably wrong with the version numbers.

INLINE COMMENTS

> kirigamiplugin.cpp:131
>  qmlRegisterType(componentUrl(QStringLiteral("BasicListItem.qml")), uri, 
> 2, 0, "BasicListItem");
> +qmlRegisterType(componentUrl(QStringLiteral("ListSectionHeader.qml")), 
> uri, 2, 0, "ListSectionHeader");
>  qmlRegisterType(componentUrl(QStringLiteral("OverlayDrawer.qml")), uri, 
> 2, 0, "OverlayDrawer");

Why 2.0?

> qmldir:19
>  BasicListItem 2.5 BasicListItem.qml
> +ListSectionHeader 2.5 ListSectionHeader.qml
>  AbstractItemViewHeader 2.1 AbstractItemViewHeader.qml

Why 2.5?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart
Cc: ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, 
domson, dkardarakos, apol, davidedmundson, mart, hein

D22817: Port KRunner to Plasma Components 3

[Carl Schwan]

ognarb added a comment.


  To add the clear button, maybe you can use Kirigami.SearchField instead?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22817

To: apol, #plasma, broulik
Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22543: [LNF KCM] make it possible to close the preview

[Carl Schwan]

ognarb added a comment.


  I had the same problem today with qt 5.13.0, framework 5.59 and plasma 
5.16.3. I switched to a tty to close system settings :/.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22543

To: ngraham, #plasma, apol
Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22426: Add Unsplash POTD Provider

[Carl Schwan]

ognarb added a comment.


  In D22426#494745 , @guoyunhe wrote:
  
  > Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be 
copyright issues.
  >
  > I do think it is good to show photographers' credits. But that will require 
changes to POTD class and wallpaper widget.
  
  
  Where did you read that Unsplash images were CC0? The license 
 is not CC0 and is in fact non-free. Or are the 
pictures fetched at https://unsplash.com/wallpaper/1065396/desktop-wallpapers 
licensed explicitly under CC0?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22426

To: guoyunhe, #plasma, ngraham
Cc: ognarb, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21435: [ActionTextField] Make QML tooltip consistent

[Carl Schwan]

ognarb added a reviewer: Kirigami.
ognarb added a comment.


  +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D21435

To: GB_2, #plasma, #vdg, #kirigami
Cc: ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D19454: Fix errors in kirigami example files

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8dc09a000125: Fix errors in kirigami example files 
(authored by ognarb).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19454?vs=54124=54354#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19454?vs=54124=54354

REVISION DETAIL
  https://phabricator.kde.org/D19454

AFFECTED FILES
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml
  examples/simpleexamples/simpleChatApp.qml

To: ognarb, #kirigami, mart
Cc: mart, apol, plasma-devel, domson, dkardarakos, davidedmundson, hein

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:546f82f9e645: Add a SearchField and PasswordField 
component (authored by ognarb).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19502?vs=54119=54353

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19454: Fix errors in kirigami example files

[Carl Schwan]

ognarb updated this revision to Diff 54124.
ognarb added a comment.


  Remove goBack funtion, and I repported the bug 
https://bugs.kde.org/show_bug.cgi?id=405571 :)

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19454?vs=52927=54124

BRANCH
  arcpatch-D19454

REVISION DETAIL
  https://phabricator.kde.org/D19454

AFFECTED FILES
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml
  examples/simpleexamples/simpleChatApp.qml

To: ognarb, #kirigami
Cc: mart, apol, plasma-devel, domson, dkardarakos, davidedmundson, hein

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb updated this revision to Diff 54119.
ognarb added a comment.


  Rebase

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19502?vs=54117=54119

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb updated this revision to Diff 54117.
ognarb added a comment.


  - Use qsTr instead of i18n
  - Kirigami version 2.7 -> 2.8

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19502?vs=53106=54117

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19662: Fix Qmake based build

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f7100e2c9ca6: Fix Qmake based build (authored by ognarb).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19662?vs=53621=53664

REVISION DETAIL
  https://phabricator.kde.org/D19662

AFFECTED FILES
  kirigami.qrc

To: ognarb, #kirigami, mart
Cc: mart, plasma-devel, domson, dkardarakos, apol, davidedmundson, hein

D19662: Fix Qmake based build

[Carl Schwan]

ognarb created this revision.
ognarb added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  This patch should resolve 
https://www.reddit.com/r/kde/comments/azgfbj/cant_compile_kirigami_for_android/
  
  Also fix a warning duplicate entry in qrc

TEST PLAN
  Build with cmake and qmake works

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19662

AFFECTED FILES
  kirigami.qrc

To: ognarb, #kirigami
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:245677bfb31a: Update documentation for kcontrol desktop 
theme (now plasma theme) (authored by ognarb).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19618?vs=53465=53466

REVISION DETAIL
  https://phabricator.kde.org/D19618

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/edit-delete.png
  doc/kcontrol/desktopthemedetails/edit-undo.png
  doc/kcontrol/desktopthemedetails/get-new-theme.png
  doc/kcontrol/desktopthemedetails/index.docbook
  doc/kcontrol/desktopthemedetails/main.png

To: ognarb, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, 
Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

[Carl Schwan]

ognarb updated this revision to Diff 53465.
ognarb marked 4 inline comments as done.
ognarb added a comment.


  Fix typos and use entites
  
  Thanks yuri :D

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19618?vs=53463=53465

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19618

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/edit-delete.png
  doc/kcontrol/desktopthemedetails/edit-undo.png
  doc/kcontrol/desktopthemedetails/get-new-theme.png
  doc/kcontrol/desktopthemedetails/index.docbook
  doc/kcontrol/desktopthemedetails/main.png

To: ognarb, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, 
Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

[Carl Schwan]

ognarb created this revision.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Some part were copied from kcontrol icons. Need proofreading

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19618

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/edit-delete.png
  doc/kcontrol/desktopthemedetails/edit-undo.png
  doc/kcontrol/desktopthemedetails/get-new-theme.png
  doc/kcontrol/desktopthemedetails/index.docbook
  doc/kcontrol/desktopthemedetails/main.png

To: ognarb
Cc: plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, Pitel, 
ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19454: Fix errors in kirigami example files

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> apol wrote in AbstractApplicationWindow.qml:105
> Why's that?

Without I get the errror: TypeError: Property 'goBack' of object 
QQuickStackView_QML_91(0x55ea59443ee0) is not a function

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19454

To: ognarb, #kirigami
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> broulik wrote in SearchField.qml:44
> I think this is fine but may need a translation domain 
> `i18nd("whatever_domain_kirigami_uses", "Search...")`

Are you sure? It would mean that Kirigami should then depends on ki18n. And 
them Kirigami wouldn't be a Tier 1 KDE framework anymore.

@mart should I move this in the example code or it is fine with a translation 
domain?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19502

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19315: Use ActionTextField to implement the searchField in system settings

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:e80cbf128f77: Use ActionTextField to implement the 
searchField in system settings (authored by ognarb).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19315?vs=52553=53115

REVISION DETAIL
  https://phabricator.kde.org/D19315

AFFECTED FILES
  CMakeLists.txt
  sidebar/package/contents/ui/CategoriesPage.qml

To: ognarb, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb updated this revision to Diff 53106.
ognarb marked 8 inline comments as done.
ognarb edited the summary of this revision.
ognarb added a comment.


  - Fix typos in doc
  - Remove edi-clear button in password field

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19502?vs=53093=53106

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Provide a small abstraction over ActionTextField to implement consistent 
standard special text field
  
  **Warning:** I include a placeholder text in this two example, not sure if 
this is correct, because kirigami probably shouldn't include translatable 
content.

TEST PLAN
  Compile, example work

REPOSITORY
  R169 Kirigami

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19301: Use Kirigami.ActionTextField for the SearchField

[Carl Schwan]

ognarb added a comment.


  In D19301#423523 , @ngraham wrote:
  
  > Also it would be nice to port Discover itself to use this.
  
  
  I'm not sure, I understand your comment. What do you mean with this? Discover 
already implement the actionSearchField.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store, ngraham
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19454: WIP: Fix errors in kirigami example files

[Carl Schwan]

ognarb updated this revision to Diff 52927.
ognarb added a comment.


  More fix

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19454?vs=52920=52927

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19454

AFFECTED FILES
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml
  examples/simpleexamples/simpleChatApp.qml

To: ognarb
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein