D28172: [applets/digital-clock] Fix date sizing in vertical panel

2020-03-23 Thread Christian Muehlhaeuser 
muesli added a comment.


  While it's not completely consistent yet, it still's an improvement that 
reverts the recent regression. As such, I'm tempted to say LGTM.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28172

To: ngraham, #vdg, #plasma
Cc: muesli, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28172: [applets/digital-clock] Fix date sizing in vertical panel

2020-03-21 Thread Christian Muehlhaeuser 
muesli added a comment.


  Your patch indeed makes the date behave like in previous releases again! 
However I noticed it's still not quite consistent in its behavior: when I start 
plasmashell freshly, the date is a lot wider than after resizing it to roughly 
the same width. I've added a new attachment, which hopefully explains what I'm 
trying to say.
  
  F8191155: 2020-03-21 01-12-05.mkv 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28172

To: ngraham, #vdg, #plasma
Cc: muesli, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28083: Use methods in KF5-activities to switch to previous/next activity

2020-03-17 Thread Christian Muehlhaeuser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:805e70bb6e75: Use methods in KF5-activities to switch to 
previous/next activity (authored by muesli).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28083?vs=77780=77820

REVISION DETAIL
  https://phabricator.kde.org/D28083

AFFECTED FILES
  shell/shellcorona.cpp

To: muesli, ngraham, ivan, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28083: Use methods in KF5-activities to switch to previous/next activity

2020-03-16 Thread Christian Muehlhaeuser 
muesli created this revision.
muesli added reviewers: ngraham, ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
muesli requested review of this revision.

REVISION SUMMARY
  Since the release of KDE Frameworks 5.68.0 we can now
  use the methods exposed in KActivities::Controller to trigger a
  switch to the previous or next activity from ShellCorona.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28083

AFFECTED FILES
  shell/shellcorona.cpp

To: muesli, ngraham, ivan
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-13 Thread Christian Muehlhaeuser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1d6b5376eaa7: Add global shortcuts for switching to the 
previous/next activity (authored by muesli).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22382?vs=73412=73418

REVISION DETAIL
  https://phabricator.kde.org/D22382

AFFECTED FILES
  shell/shellcorona.cpp

To: muesli, apol, davidedmundson, #vdg, #plasma, ngraham
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-13 Thread Christian Muehlhaeuser 
muesli added a comment.


  Alright, I think this looks sane again. @ngraham Mind if I land this in its 
current state?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22382

To: muesli, apol, davidedmundson, #vdg, #plasma
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-13 Thread Christian Muehlhaeuser 
muesli updated this revision to Diff 73412.
muesli added a comment.


  Hopefully fix phabricator getting out of sync with the changeset.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22382?vs=73354=73412

BRANCH
  shortcut-prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22382

AFFECTED FILES
  shell/shellcorona.cpp

To: muesli, apol, davidedmundson, #vdg, #plasma
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-12 Thread Christian Muehlhaeuser 
muesli added a comment.


  Oops, I'm not sure what I've did here was what I intended: I rebased master 
(>800 commits since my original changeset) into my feature branch because I 
otherwise couldn't build/test my changes anymore, but obviously I didn't 
touch/change > 600 files.
  Is this how phabricator is supposed to look in such a scenario, or how should 
I have resolved this scenario?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22382

To: muesli, apol, davidedmundson, #vdg, #plasma
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-12 Thread Christian Muehlhaeuser 
muesli updated this revision to Diff 73354.
muesli added a comment.


  - Remove default key-sequence for "Previous/Next Activity" shortcut

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22382?vs=61521=73354

BRANCH
  shortcut-prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22382

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  applets/CMakeLists.txt
  applets/activitybar/metadata.desktop
  applets/analog-clock/metadata.desktop
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/package/contents/ui/main.qml
  applets/appmenu/package/metadata.desktop
  applets/appmenu/plugin/appmenumodel.cpp
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/CompactRepresentation.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js
  applets/batterymonitor/package/metadata.desktop
  applets/calendar/package/metadata.desktop
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/ImageItemDelegate.qml
  applets/clipboard/metadata.desktop
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  applets/devicenotifier/package/metadata.desktop
  applets/devicenotifier/test-predicate-openinwindow.desktop
  applets/digital-clock/package/contents/config/config.qml
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml
  applets/digital-clock/package/contents/ui/main.qml
  applets/digital-clock/package/metadata.desktop
  applets/digital-clock/plugin/CMakeLists.txt
  applets/digital-clock/plugin/clipboardmenu.cpp
  applets/icon/iconapplet.cpp
  applets/icon/package/metadata.desktop
  applets/kicker/CMakeLists.txt
  applets/kicker/Messages.sh
  applets/kicker/plugin/abstractentry.cpp
  applets/kicker/plugin/abstractentry.h
  applets/kicker/plugin/abstractmodel.cpp
  applets/kicker/plugin/abstractmodel.h
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appentry.h
  applets/kicker/plugin/appsmodel.cpp
  applets/kicker/plugin/appsmodel.h
  applets/kicker/plugin/computermodel.cpp
  applets/kicker/plugin/computermodel.h
  applets/kicker/plugin/contactentry.cpp
  applets/kicker/plugin/contactentry.h
  applets/kicker/plugin/containmentinterface.cpp
  applets/kicker/plugin/containmentinterface.h
  applets/kicker/plugin/dashboardwindow.cpp
  applets/kicker/plugin/dashboardwindow.h
  applets/kicker/plugin/draghelper.cpp
  applets/kicker/plugin/draghelper.h
  applets/kicker/plugin/fileentry.cpp
  applets/kicker/plugin/fileentry.h
  applets/kicker/plugin/forwardingmodel.cpp
  applets/kicker/plugin/forwardingmodel.h
  applets/kicker/plugin/funnelmodel.cpp
  applets/kicker/plugin/funnelmodel.h
  applets/kicker/plugin/kastatsfavoritesmodel.cpp
  applets/kicker/plugin/kastatsfavoritesmodel.h
  applets/kicker/plugin/kickerplugin.cpp
  applets/kicker/plugin/kickerplugin.h
  applets/kicker/plugin/menuentryeditor.cpp
  applets/kicker/plugin/menuentryeditor.h
  applets/kicker/plugin/placeholdermodel.cpp
  applets/kicker/plugin/placeholdermodel.h
  applets/kicker/plugin/processrunner.cpp
  applets/kicker/plugin/processrunner.h
  applets/kicker/plugin/qmldir
  applets/kicker/plugin/recentcontactsmodel.cpp
  applets/kicker/plugin/recentcontactsmodel.h
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/rootmodel.h
  applets/kicker/plugin/runnermatchesmodel.cpp
  applets/kicker/plugin/runnermatchesmodel.h
  applets/kicker/plugin/runnermodel.cpp
  applets/kicker/plugin/runnermodel.h
  applets/kicker/plugin/simplefavoritesmodel.cpp
  applets/kicker/plugin/simplefavoritesmodel.h
  applets/kicker/plugin/submenu.cpp
  applets/kicker/plugin/submenu.h
  applets/kicker/plugin/systementry.cpp
  applets/kicker/plugin/systementry.h
  applets/kicker/plugin/systemmodel.cpp
  applets/kicker/plugin/systemmodel.h
  applets/kicker/plugin/systemsettings.cpp
  applets/kicker/plugin/systemsettings.h
  applets/kicker/plugin/wheelinterceptor.cpp
  applets/kicker/plugin/wheelinterceptor.h
  applets/kicker/plugin/windowsystem.cpp
  applets/kicker/plugin/windowsystem.h
  applets/lock_logout/contents/config/config.qml
  applets/lock_logout/metadata.desktop
  applets/mediacontroller/contents/ui/main.qml
  applets/mediacontroller/metadata.desktop
  applets/notifications/CMakeLists.txt
  applets/notifications/globalshortcuts.cpp
  applets/notifications/globalshortcuts.h
  applets/notifications/notificationapplet.cpp

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-11 Thread Christian Muehlhaeuser 
muesli added a comment.


  While waiting for that separate discussion and decision, does anyone mind if 
I land this _without_ default shortcuts set?
  
  At least it enables people to switch to the previous/next activity when they 
configure a shortcut manually. Currently that's not possible, as one can only 
define shortcuts for specific activities.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22382

To: muesli, apol, davidedmundson, #vdg, #plasma
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

2019-10-22 Thread Christian Muehlhaeuser 
muesli added a comment.


  Would love to finish this one up! :)
  Any suggestions how to move forward?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22382

To: muesli, apol, davidedmundson, #vdg, #plasma
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22381: Add previous-/nextActivity methods

2019-10-03 Thread Christian Muehlhaeuser 
This revision was automatically updated to reflect the committed changes.
muesli marked an inline comment as done.
Closed by commit R161:e3a7cb2f1b18: Add previous-/nextActivity methods 
(authored by muesli).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22381?vs=67276=67278

REVISION DETAIL
  https://phabricator.kde.org/D22381

AFFECTED FILES
  src/common/dbus/org.kde.ActivityManager.Activities.xml
  src/service/Activities.cpp
  src/service/Activities.h
  src/service/Activities_p.h

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22381: Add previous-/nextActivity methods

2019-10-03 Thread Christian Muehlhaeuser 
muesli updated this revision to Diff 67276.
muesli added a comment.


  Fix typo in 'nameBasedOrdering'

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22381?vs=61590=67276

BRANCH
  prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22381

AFFECTED FILES
  src/common/dbus/org.kde.ActivityManager.Activities.xml
  src/service/Activities.cpp
  src/service/Activities.h
  src/service/Activities_p.h

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22382: Add global shortcuts for switching to the previous/next activity

2019-10-03 Thread Christian Muehlhaeuser 
muesli added a comment.


  In D22382#541626 , @ivan wrote:
  
  > I'm not thrilled about having default shortcuts set. We have the shortcuts 
space quite polluted as it is.
  
  
  I'm happy to remove the defaults (even though I consider them fairly 
consistent with our other defaults), but at least users can still define their 
own global shortcuts then.
  
  > Maybe the text should explicitly state what 'next' means in this case.
  
  Like: "switch to next activity (in alphabetical order)"?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22382

To: muesli, apol, davidedmundson
Cc: ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22381: Add previous-/nextActivity methods

2019-07-11 Thread Christian Muehlhaeuser 
muesli updated this revision to Diff 61590.
muesli added a comment.


  Move nameBaseOrdering to an anonymous namespace and mark it as inline.

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22381?vs=61589=61590

BRANCH
  prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22381

AFFECTED FILES
  src/common/dbus/org.kde.ActivityManager.Activities.xml
  src/service/Activities.cpp
  src/service/Activities.h
  src/service/Activities_p.h

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22381: Add previous-/nextActivity methods

2019-07-11 Thread Christian Muehlhaeuser 
muesli updated this revision to Diff 61589.
muesli added a comment.


  Addressed @ivan's change requests
  
  Summary:
  
  - Renamed sorting method to nameBaseOrdering
  - Remove activity from sorted cache without re-sorting the entire list
  - Switch to prev/next running activity, skipping other states

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22381?vs=61588=61589

BRANCH
  prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22381

AFFECTED FILES
  src/common/dbus/org.kde.ActivityManager.Activities.xml
  src/service/Activities.cpp
  src/service/Activities.h
  src/service/Activities_p.h

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22381: Add previous-/nextActivity methods

2019-07-11 Thread Christian Muehlhaeuser 
muesli updated this revision to Diff 61588.
muesli added a comment.


  Use a QVector instead of a QList to store sorted activities.

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22381?vs=61579=61588

BRANCH
  prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22381

AFFECTED FILES
  src/common/dbus/org.kde.ActivityManager.Activities.xml
  src/service/Activities.cpp
  src/service/Activities.h
  src/service/Activities_p.h

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22396: Fix typo in CREATE_GETTER_AND_SETTER

2019-07-11 Thread Christian Muehlhaeuser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R161:d15446776e23: Fix typo in CREATE_GETTER_AND_SETTER 
(authored by muesli).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22396?vs=61581=61586

REVISION DETAIL
  https://phabricator.kde.org/D22396

AFFECTED FILES
  src/service/Activities.cpp

To: muesli, ivan, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22396: Fix typo in CREATE_GETTER_AND_SETTER

2019-07-11 Thread Christian Muehlhaeuser 
muesli created this revision.
muesli added a reviewer: ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
muesli requested review of this revision.

REVISION SUMMARY
  Fix typo when undefining CREATE_GETTER_AND_SETTER.

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  undef-typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22396

AFFECTED FILES
  src/service/Activities.cpp

To: muesli, ivan
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22381: Add previous-/nextActivity methods

2019-07-11 Thread Christian Muehlhaeuser 
muesli updated this revision to Diff 61579.
muesli added a comment.


  Keep an alphabetically sorted list of activities
  
  Summary:
  Instead of re-sorting the activity list every time previous-/nextActivity gets
  called, maintain a sorted list.

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22381?vs=61517=61579

BRANCH
  prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22381

AFFECTED FILES
  src/common/dbus/org.kde.ActivityManager.Activities.xml
  src/service/Activities.cpp
  src/service/Activities.h
  src/service/Activities_p.h

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22381: Add previous-/nextActivity methods

2019-07-10 Thread Christian Muehlhaeuser 
muesli added inline comments.

INLINE COMMENTS

> ivan wrote in Activities.cpp:218
> I don't like the fact that it constantly resorts the activities.
> 
> The second problem is that ListActivities returns a list in one order, and 
> this traverses activities in another order. If this will work by name, 
> probably the List functions should as well.

List probably returns a fairly randomized (per session) list, seeing how it's 
returning keys() from a QHash. Maybe I misunderstood you on IRC, I thought 
you'd rather not store a sorted list here. Instead of keeping a sorted cache 
though, maybe we should just keep the original list in a sorted order?

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D22381

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22382: Add global shortcuts for switching to the previous/next activity

2019-07-10 Thread Christian Muehlhaeuser 
muesli created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
muesli requested review of this revision.

REVISION SUMMARY
  We currently have a mouse-wheel action to switch to the previous/next desktop,
  but it wasn't possible to assign a global keyboard shortcut to these actions.
  
  I've assigned Ctrl-Meta-Left and Ctrl-Meta-Right respectively as the default
  shortcuts to these actions, as they seem to fit and are currently unused.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shortcut-prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22382

AFFECTED FILES
  shell/shellcorona.cpp

To: muesli
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22381: Add previous-/nextActivity methods

2019-07-10 Thread Christian Muehlhaeuser 
muesli created this revision.
muesli added a reviewer: ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
muesli requested review of this revision.

REVISION SUMMARY
  These two methods can be used to switch to the previous/next activity in
  alphabetical order. They are exposed via the DBus interface. This
  functionality can also be accessed by kactivities(-cli) and plasmashell, which
  currently both implement their own separate versions of it.
  
  @Ivan mentioned being a bit wary of keeping a sorted activity list in
  kactivitymanagerd, so I've opted to only retrieve and sort the list on demand
  here.

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22381

AFFECTED FILES
  src/common/dbus/org.kde.ActivityManager.Activities.xml
  src/service/Activities.cpp
  src/service/Activities.h
  src/service/Activities_p.h

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart