D8469: Use XDG_DATA_HOME and security fix

2017-10-26 Thread Crypto Dude
cryptodude updated this revision to Diff 21364. cryptodude retitled this revision from "Use XDG_DATA_DIR and security fix" to "Use XDG_DATA_HOME and security fix". cryptodude edited the summary of this revision. cryptodude added a comment. Updated git and task comments to use XDG_DATA_HOME.

D8469: Use XDG_DATA_DIR and security fix

2017-10-26 Thread Crypto Dude
cryptodude added a comment. In https://phabricator.kde.org/D8469#160263, @cryptodude wrote: > Updated to use QStandardPaths Hmm, I forgot to test if the XDG_DATA_DIR actually is honoured by the QStandardDirs, and a quick test shows that it doesn't. I'll have to find out

D8469: Use XDG_DATA_DIR and security fix

2017-10-26 Thread Crypto Dude
cryptodude updated this revision to Diff 21363. cryptodude added a comment. Updated to use QStandardPaths REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8469?vs=21303=21363 REVISION DETAIL https://phabricator.kde.org/D8469 AFFECTED FILES

D8469: Use XDG_DATA_DIR and security fix

2017-10-25 Thread Crypto Dude
cryptodude added a comment. > I'm not sure the users will like what you did with encfs, but we can at least test the waters. :) Sounds good. I know for every feature you take away from users they will be a user that will complain about it. No doubt. I hope we can stand by the

D8449: Have a default backend (if one available)

2017-10-25 Thread Crypto Dude
cryptodude added a comment. Ok, I see the confusion. The name of this pull request uses the word 'default' and that confused everyone. What I meant with that is that the User Interface should respond to the packager picking a default. The UI itself does not pick a default. It just

D8469: Use XDG_DATA_DIR and security fix

2017-10-25 Thread Crypto Dude
cryptodude created this revision. cryptodude added reviewers: ivan, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The EncFS has security issues when the encrypted files are shared in the open. For instance on

D8449: Have a default backend (if one available)

2017-10-25 Thread Crypto Dude
cryptodude updated this revision to Diff 21302. cryptodude added a comment. I tested this version to do what I described. Please review and/or merge. The point about EncFS being a security issue when saved on something like a USB pen is a separate commit I'll create a different

D8449: Have a default backend (if one available)

2017-10-24 Thread Crypto Dude
cryptodude added a comment. In https://phabricator.kde.org/D8449#159406, @ivan wrote: > Having a default backend (IMO) has nothing to do with the UI. I'm not sure what else it would have an effect on. Default to me means its just a suggested one and users can still override it.

D8449: Have a default backend (if one available)

2017-10-24 Thread Crypto Dude
cryptodude added a comment. In https://phabricator.kde.org/D8449#159337, @ngraham wrote: > I don't think choosing a random backend makes sense without at least some information provided to the user. How about adding a text view below the combobox showing a quick human-friendly summary

D8449: Have a default backend (if one available)

2017-10-24 Thread Crypto Dude
cryptodude edited the summary of this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8449 To: cryptodude, ivan, #plasma Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

2017-10-24 Thread Crypto Dude
cryptodude created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The creation of a new vault uses a wizard. The first page of the wizard currently shows a combobox with 2 backends, with one