Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119990/ --- Review request for Plasma. Repository: libksysguard Description --- Since libksysguard probably aims to be a framework, the libraries should have respective names and includes should be installed to KF5_INCLUE_INSTALL_DIR. Solves conflicts with KDE 4. Diffs - ksgrd/CMakeLists.txt 64ad24a lsofui/CMakeLists.txt 2b0c8ac processcore/CMakeLists.txt 31eee10 processui/CMakeLists.txt 150e198 signalplotter/CMakeLists.txt 67aa8bb Diff: https://git.reviewboard.kde.org/r/119990/diff/ Testing --- Builds, installs, libraries are called libKF5*.so, includes in /usr/include/KF5/KSysGuard/ Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 26, 2014, 2:44 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs - ksmserver/screenlocker/greeter/CMakeLists.txt 4837017 ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119885: Use CMAKE_INSTALL_FULL_BINDIR in plasma.desktop
On Aug. 25, 2014, 1:24 a.m., Aleix Pol Gonzalez wrote: plasma.desktop.cmake, line 5 https://git.reviewboard.kde.org/r/119885/diff/1/?file=306866#file306866line5 The TryExec is wrong now? :P Oooops, fixed now. Thanks! - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119885/#review65163 --- On Aug. 21, 2014, 9:11 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119885/ --- (Updated Aug. 21, 2014, 9:11 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Prevents ending up with /usr//usr/bin/startkde in plasma.desktop when CMAKE_INSTALL_BINDIR is absolute. It's already used in startkde, so I think it makes sense to use it here too. Diffs - plasma.desktop.cmake 81ca9a7 Diff: https://git.reviewboard.kde.org/r/119885/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:39 p.m.) Review request for Plasma. Changes --- Lukas Tinkl found a nice way to get Caps Lock status and changes from the KeyState DataEngine, so the patch now makes use of the DataEngine and removes the X11-dependent CapsLock status detection from greeterapp.cpp Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs (updated) - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 25, 2014, 3:43 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs (updated) - ksmserver/screenlocker/greeter/CMakeLists.txt 4837017 ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 2:11 p.m.) Review request for Plasma and Andrew Lake. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 25, 2014, 4:11 p.m., David Edmundson wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 167 https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line167 does it not work to do visible: keystateSource.data[Caps Lock][Locked] and then get rid of the function? Yep, that works perfectly. - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65213 --- On Aug. 25, 2014, 4:11 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 4:11 p.m.) Review request for Plasma and Andrew Lake. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:10 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Andrew Lake. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119885: Use CMAKE_INSTALL_FULL_BINDIR in plasma.desktop
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119885/ --- Review request for Plasma. Repository: plasma-workspace Description --- Prevents ending up with /usr//usr/bin/startkde in plasma.desktop when CMAKE_INSTALL_BINDIR is absolute. It's already used in startkde, so I think it makes sense to use it here too. Diffs - plasma.desktop.cmake 81ca9a7 Diff: https://git.reviewboard.kde.org/r/119885/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119885: Use CMAKE_INSTALL_FULL_BINDIR in plasma.desktop
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119885/ --- (Updated Aug. 21, 2014, 7:11 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- Prevents ending up with /usr//usr/bin/startkde in plasma.desktop when CMAKE_INSTALL_BINDIR is absolute. It's already used in startkde, so I think it makes sense to use it here too. Diffs - plasma.desktop.cmake 81ca9a7 Diff: https://git.reviewboard.kde.org/r/119885/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: lookandfeel/contents/lockscreen/LockScreen.qml, lines 166-167 https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line166 So you tell it to be centered horizontally, and wrap, but a maximum of one line is allowed? This will have no effect whatsoever since the label will just grow outside horizontally because it has no width/side anchors set. Just copy-pasted from the notificationLabel above :-) On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 32 https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line32 You generally don't need semicolons after QML properties Sorry, habit of a C++ programmer - punch semicolon after every line :) On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 63 https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line63 units.largeSpacing * 15 Nonetheless, that looks wrong to me, don't we have gridUnit for stuff like that? This actually represents the height of the actual content block - I'm not sure we can/want to use some generic value for that. I think in ideal case the height of the element should be based on total height of the elements it contains - I'm not sure why this is not the case but I'll try to do it that way first. - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64587 --- On Aug. 15, 2014, 12:25 a.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 15, 2014, 12:25 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:19 p.m.) Review request for Plasma. Changes --- Fix review comments Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs (updated) - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:21 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs (updated) - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
On Aug. 16, 2014, 1:58 p.m., Emmanuel Pescosta wrote: lookandfeel/contents/components/KeyboardLayout.qml, line 28 https://git.reviewboard.kde.org/r/119794/diff/2/?file=305631#file305631line28 really?! ;) Ooops, copy paste :) On Aug. 16, 2014, 1:58 p.m., Emmanuel Pescosta wrote: lookandfeel/contents/components/KeyboardLayout.qml, line 47 https://git.reviewboard.kde.org/r/119794/diff/2/?file=305631#file305631line47 Maybe a simple modulo operation instead of this check? This seems a bit easier to understand and a is I'd say more common solution for is this the last item in the list check - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/#review64630 --- On Aug. 14, 2014, 11:40 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 14, 2014, 11:40 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs - ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 18, 2014, 4:24 p.m., Aleix Pol Gonzalez wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 32 https://git.reviewboard.kde.org/r/119797/diff/4/?file=306152#file306152line32 I don't see who is setting the value for capsLockOn, did I miss something? Also this could be an alias to the label visible property. This property is set by UnlockApp in ksmserver/screenlocker/greeter/greeterapp.cpp on l383 - the code for capslock state detection has already been there (brough in from KDE 4), we were just not making use of the property in QML. Should I add a comment where this is comming from? - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64758 --- On Aug. 18, 2014, 4:21 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:21 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119758: Add option to DigitalClock applet to show date
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/ --- (Updated Aug. 14, 2014, 8:20 p.m.) Review request for Plasma. Changes --- Added code to force-recalculate size of the applet when date changes, because the date string length might change (shorter/longer day or month name) Bugs: 335006 https://bugs.kde.org/show_bug.cgi?id=335006 Repository: plasma-workspace Description --- This patch adds option to show date in the DigitalClock applet, something I was very much missing after switching to Plasma 5 :-) Similary to the KDE 4 applet, users can choose from long, short and narrow date formats. Diffs (updated) - applets/digital-clock/package/contents/config/main.xml 74ac640 applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 Diff: https://git.reviewboard.kde.org/r/119758/diff/ Testing --- File Attachments In vertical panel https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7e08759e-18a2-46b7-92f7-a3bff6946cf4__clock1.png In horizontal panel https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/b55b1ab2-98fc-4ab8-a64e-c4635574d3e1__clock3.png Settings dialog https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7c309d90-6b4b-42a2-907e-98c0b47389e8__clock2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs - ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 14, 2014, 11:40 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs (updated) - ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments (updated) https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 15, 2014, 12:25 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs (updated) - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 10:39 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs (updated) - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119758: Add option to DigitalClock applet to show date
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/ --- Review request for Plasma. Repository: plasma-workspace Description --- This patch adds option to show date in the DigitalClock applet, something I was very much missing after switching to Plasma 5 :-) Similary to the KDE 4 applet, users can choose from long, short and narrow date formats. Diffs - applets/digital-clock/package/contents/config/main.xml 74ac640 applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 Diff: https://git.reviewboard.kde.org/r/119758/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119758: Add option to DigitalClock applet to show date
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/ --- (Updated Aug. 13, 2014, 12:51 p.m.) Review request for Plasma. Bugs: 335006 https://bugs.kde.org/show_bug.cgi?id=335006 Repository: plasma-workspace Description --- This patch adds option to show date in the DigitalClock applet, something I was very much missing after switching to Plasma 5 :-) Similary to the KDE 4 applet, users can choose from long, short and narrow date formats. Diffs - applets/digital-clock/package/contents/config/main.xml 74ac640 applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 Diff: https://git.reviewboard.kde.org/r/119758/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 12:54 p.m.) Review request for Plasma. Bugs: 336705 https://bugs.kde.org/show_bug.cgi?id=336705 Repository: plasma-desktop Description --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119758: Add option to DigitalClock applet to show date
On Aug. 13, 2014, 1 p.m., David Edmundson wrote: applets/digital-clock/package/contents/ui/DigitalClock.qml, line 70 https://git.reviewboard.kde.org/r/119758/diff/1/?file=305016#file305016line70 Do we really want the same text label with the same font? I'd like some screenshots. Why not? I played with having two labels, but it was a huge mess and I wasn't able to make it work properly. On Aug. 13, 2014, 1 p.m., David Edmundson wrote: applets/digital-clock/package/contents/ui/configAppearance.qml, line 39 https://git.reviewboard.kde.org/r/119758/diff/1/?file=305017#file305017line39 can be just: property string cfg_dateFormat: model[currentIndex][name] and remove the onCurrentIndexChanged That does not work, the property is not updated when I select another item in the combobox. On Aug. 13, 2014, 1 p.m., David Edmundson wrote: applets/digital-clock/package/contents/ui/DigitalClock.qml, line 148 https://git.reviewboard.kde.org/r/119758/diff/1/?file=305016#file305016line148 In the size helper we calculate the size of 00:00:00 which is the widest string so that text doesn't jump about. Here you're working out the size of the current day. Which is going to be dynamic. Given this is only calculated once on startup, if you start it in May you'll get it broken if Plasma keeps running till September when the text will no longer fit. Hmm, that's true - it might even break just when a day changes. - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/#review64446 --- On Aug. 13, 2014, 12:51 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/ --- (Updated Aug. 13, 2014, 12:51 p.m.) Review request for Plasma. Bugs: 335006 https://bugs.kde.org/show_bug.cgi?id=335006 Repository: plasma-workspace Description --- This patch adds option to show date in the DigitalClock applet, something I was very much missing after switching to Plasma 5 :-) Similary to the KDE 4 applet, users can choose from long, short and narrow date formats. Diffs - applets/digital-clock/package/contents/config/main.xml 74ac640 applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 Diff: https://git.reviewboard.kde.org/r/119758/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119758: Add option to DigitalClock applet to show date
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/ --- (Updated Aug. 13, 2014, 3:04 p.m.) Review request for Plasma. Bugs: 335006 https://bugs.kde.org/show_bug.cgi?id=335006 Repository: plasma-workspace Description --- This patch adds option to show date in the DigitalClock applet, something I was very much missing after switching to Plasma 5 :-) Similary to the KDE 4 applet, users can choose from long, short and narrow date formats. Diffs - applets/digital-clock/package/contents/config/main.xml 74ac640 applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 Diff: https://git.reviewboard.kde.org/r/119758/diff/ Testing --- File Attachments (updated) In vertical panel https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7e08759e-18a2-46b7-92f7-a3bff6946cf4__clock1.png In horizontal panel https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/b55b1ab2-98fc-4ab8-a64e-c4635574d3e1__clock3.png Settings dialog https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7c309d90-6b4b-42a2-907e-98c0b47389e8__clock2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119758: Add option to DigitalClock applet to show date
On Aug. 13, 2014, 1 p.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/ui/DigitalClock.qml, line 71 https://git.reviewboard.kde.org/r/119758/diff/1/?file=305016#file305016line71 That will cause the date to be in the same font as the clock? Hmm… Martin Klapetek wrote: For the record, I like it. (I've seen it on Dan's laptop; also the fonts autoscales so it all fits) Do you think the date should be in different font? And why? Yeah, why not? :) - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/#review64449 --- On Aug. 13, 2014, 12:51 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/ --- (Updated Aug. 13, 2014, 12:51 p.m.) Review request for Plasma. Bugs: 335006 https://bugs.kde.org/show_bug.cgi?id=335006 Repository: plasma-workspace Description --- This patch adds option to show date in the DigitalClock applet, something I was very much missing after switching to Plasma 5 :-) Similary to the KDE 4 applet, users can choose from long, short and narrow date formats. Diffs - applets/digital-clock/package/contents/config/main.xml 74ac640 applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 Diff: https://git.reviewboard.kde.org/r/119758/diff/ Testing --- File Attachments In vertical panel https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7e08759e-18a2-46b7-92f7-a3bff6946cf4__clock1.png In horizontal panel https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/b55b1ab2-98fc-4ab8-a64e-c4635574d3e1__clock3.png Settings dialog https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7c309d90-6b4b-42a2-907e-98c0b47389e8__clock2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 1:07 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Bugs: 336705 https://bugs.kde.org/show_bug.cgi?id=336705 Repository: plasma-desktop Description --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119748: Properly align KickoffButtons to center when in vertical mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- Review request for Plasma. Repository: plasma-desktop Description --- The labels in Kickoff are misaligned when Kickoff is in vertical mode (see the first screenshot). This patch fixes it by making sure the KickoffButton is always as wide as the parent container, even when the label string is shorter, so that the text is always centered. Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/dd8b7151-2ab1-43de-acaf-b010d57e3efb__kickoff-after.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 2:35 a.m.) Review request for Plasma. Changes --- Now the icons and the labels are both horizontally and vertically centered in both vertical and horizontal mode \o/ (see the last screenshot) Repository: plasma-desktop Description --- The first and the last labels in Kickoff are misaligned (see the first screenshot) for some reason - even though the Label correctly fills the entire parent width, the test is still aligned to left. To workaround this issue, this patch wraps the Label into an Item - now the labels are correctly aligned in the center . I don't have any explanation for why does this happen, nor do I understand why wrapping the stuff in Item fixes the problem, so please don't ask (but please explain it to me if you happen to know) :-). Diffs (updated) - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments (updated) Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/dd8b7151-2ab1-43de-acaf-b010d57e3efb__kickoff-after.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 2:37 a.m.) Review request for Plasma. Repository: plasma-desktop Description (updated) --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments (updated) Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119575: Fix krunner contacts pllugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119575/#review64153 --- Ship it! Looks OK now, thanks for the fix! - Dan Vrátil On Aug. 9, 2014, 1:55 p.m., Marc Deop wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119575/ --- (Updated Aug. 9, 2014, 1:55 p.m.) Review request for KDEPIM and Plasma. Bugs: 282567 http://bugs.kde.org/show_bug.cgi?id=282567 Repository: kdeplasma-addons Description --- Fix krunner contacts plugin to lookup contacts through Akonadi Diffs - runners/contacts/contactsrunner.cpp 2261e3744c695d046ec95e6dd97f1ad26c800d71 runners/contacts/contactsrunner.h 9bcb40d34a40dad414ea5154b745c97c18d6d81b Diff: https://git.reviewboard.kde.org/r/119575/diff/ Testing --- Compiled, installed and tested locally Thanks, Marc Deop ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119575: Fix krunner contacts pllugin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119575/#review64156
---
Oops, don't ship it! Sorry, I haven't checked the rest of the code - your patch
breaks the contacts query (that should return *all* available contacts), and
the foreach loop is now doing some unnecessary comparisions (that have already
been done by Baloo).
runners/contacts/contactsrunner.cpp
https://git.reviewboard.kde.org/r/119575/#comment44808
This can go completely away, since the list already contains results that
match name or email.
runners/contacts/contactsrunner.cpp
https://git.reviewboard.kde.org/r/119575/#comment44805
Since the foreach loop is now not iterating over all the contacts in
addressbook, but only those that match the given term, this will never be true.
The point of this condition is to ensure, that when users write contacts
into krunner, they will get list of *all* contacts. So I think this should be
moved before the foreach(...) so that we have something like
```
if (term.compare(...contacts ... ) {
fetchAllContacts();
} else {
// Perform the search on Akonadi
Akonadi::ContactSearchJob *job = new Akonadi::ContactSearchJob(this);
}
```
and then you can iterate over the list of results.
runners/contacts/contactsrunner.cpp
https://git.reviewboard.kde.org/r/119575/#comment44810
This should be kept, so that we know if the result was matched by email or
by name - you can however move this to the line 76.
runners/contacts/contactsrunner.cpp
https://git.reviewboard.kde.org/r/119575/#comment44807
This will always be true (since the list is already filtered), so you can
remove the condition and unindent the block
runners/contacts/contactsrunner.cpp
https://git.reviewboard.kde.org/r/119575/#comment44809
This should stay here
- Dan Vrátil
On Aug. 9, 2014, 1:55 p.m., Marc Deop wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119575/
---
(Updated Aug. 9, 2014, 1:55 p.m.)
Review request for KDEPIM and Plasma.
Bugs: 282567
http://bugs.kde.org/show_bug.cgi?id=282567
Repository: kdeplasma-addons
Description
---
Fix krunner contacts plugin to lookup contacts through Akonadi
Diffs
-
runners/contacts/contactsrunner.cpp
2261e3744c695d046ec95e6dd97f1ad26c800d71
runners/contacts/contactsrunner.h 9bcb40d34a40dad414ea5154b745c97c18d6d81b
Diff: https://git.reviewboard.kde.org/r/119575/diff/
Testing
---
Compiled, installed and tested locally
Thanks,
Marc Deop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119358: Fix position of ToolBox on second screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119358/ --- Review request for Plasma. Repository: plasma-workspace Description --- Due to a typo, the offset of the ToolBox on first screen was applied to ToolBoxes on all other screens. This is only visible when panel inteferes with position of the ToolBox, i.e. when it's on the left or on the top. Diffs - shell/shellcorona.cpp 60de8ff Diff: https://git.reviewboard.kde.org/r/119358/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119358: Fix position of ToolBox on second screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119358/ --- (Updated July 18, 2014, 6:50 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- Due to a typo, the offset of the ToolBox on first screen was applied to ToolBoxes on all other screens. This is only visible when panel inteferes with position of the ToolBox, i.e. when it's on the left or on the top. Diffs - shell/shellcorona.cpp 60de8ff Diff: https://git.reviewboard.kde.org/r/119358/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110476/ --- (Updated June 9, 2013, 3:11 p.m.) Review request for Plasma. Description --- Call KNotification::close() when user clicks the 'X' button in the Notifications applet. This prevents leaking persistent notifications and allows applications to depend on KNotification::closed() signal. Diffs - plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml 64d9298 plasma/generic/applets/notifications/contents/ui/Notifications.qml c5be0a3 plasma/generic/dataengines/notifications/notificationaction.cpp 397073e plasma/generic/dataengines/notifications/notificationsengine.cpp 25fccbb Diff: http://git.reviewboard.kde.org/r/110476/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fix orientation of the arrow indicating grouped tasks
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107608/ --- Review request for Plasma. Description --- The new arrow that indicates grouped tasks in the tasks applet has inverted orientation when the panel is in vertical position. I think it makes more sense for the arrow to point left when the panel is at the right edge of the screen and vice versa. Diffs - plasma/desktop/applets/tasks/abstracttaskitem.cpp edf4be7 Diff: http://git.reviewboard.kde.org/r/107608/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Save and restore position of widgets in vertically-oriented FlowGroup
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107477/ --- Review request for Plasma. Description --- This fixes a bug when widgets were all stacked at (0,0) in a vertically-oriented Grouping Panel after plasma restart Downstream bug report: https://bugzilla.redhat.com/show_bug.cgi?id=879802 Diffs - containments/groupingdesktop/lib/groups/flowgroup.cpp d330679 Diff: http://git.reviewboard.kde.org/r/107477/diff/ Testing --- Created a vertical Grouping Panel, placed a widget into middle, restarted plasma, widget position is correctly restored. Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Display Configuration KCM design review
On Tuesday 02 of October 2012 16:23:02 Aaron J. Seigo wrote: On Tuesday, October 2, 2012 14:29:24 Dan Vrátil wrote: I'm now working on new KCM. code -- where is the code currently? i find it is often a lot easier to comment (and help out) when i can build and try the code directly Hi, the code is on git.kde.org/scratch/dvratil/displayconfiguration.git, you also need git.kde.org/scratch/dvratil/libkscreen-clone.git, it was linked in the original email ;-) duality in interaction -- my first thought is: why are there two areas for interaction? all the informaton is currently shown on the screens in the preview area, and i have to interact with the preview area to move or rotate a screen ... ... but if i want to change other information i see there, then i have to go to the bottom area (after noticing that they are connected :), find the matching information and then change it there. why can't i just change which is the primary monitor by pressing on the star (or whatever it eneds up being) in the preview area? why not be able to change the resolution and refresh by pressing on the information in the monitor itself? having some interaction in one area and some in another feels scattered. i find my eyes (and mouse) going back and forth a lot. that some things are able to be configured in both the preview and the details below demonstrates some additional inconsistencies. perhaps the nicest thing about having the previews where configuration happens is that one does not need to translate between the representation (the preview on screen) of the real thing (the actual screen) and a further abstraction (the collection of widgets at the bottom). it's one layer of mental re-direction less. I originally written the KCM without the bottom panel, but then I had to add it because all the controls won't just fit into the monitor rectangle when it's too small (1024x768 is already problematic), so right when the rectangle becomes too small, I just hide or scale some of the controls there and rely on those in the pane below. layout finesse -- i'll echo the suggestion to put a little bit of space between the monitors. yes, the screens are connected in the real world in that the graphics they show are connected (though in the real real world, there is always some separation, if only by the bezel). however, visually in the settings it doesn't look ellegant but like someone forgot a margin somewhere :) nobody will end up confused or balk a the lack of literal pixel truth if there is a nice little margin between the screens. if anything, it is likely to help people see that they are separate things more easily, useful when the screens are otherwise identical. Ok :) i do prefer the two rotation arrows over the one rotation icon as seen in http://i.minus.com/j0jCsZ3DaQQPO.jpg .. it's fewer clicks to get what i want and very clear what will happen. it would be nice to find a prettier way to show the bottom of the monitor than dark line (which isn't obvious at all at first to me?) ... probably will require an artist's intervention ;) As some suggested, the arrows for rotation could be always attached to the bottom side of the monitor, so that when you rotate the monitor by 90 degrees, the arrows would be on the left side. I think that could be obvious enough? the on/off checkbox is perhaps one of the few perfect times to use the toggle switch QML Component on the desktop as it is rather literall on or off :) \o/ I like the switch! Cheers, Dan thanks for working on this :) -- Aaron J. Seigo -- -- dvra...@redhat.com | Associate Software Engineer / BaseOS / KDE, Qt GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Display Configuration KCM design review
Hi! As some might notice [0], we are working with Alex Fiestas on new display management for KDE. I'm now working on new KCM. Aaron suggested in comments below the blog post that it would be nice to discuss design of the KCM with you, Plasma guys. As d_ed and few others suggested, I have rewritten the bottom control pane to use standard QWidgets rather then QML, so now it looks like this: [1]. Still, I really suck at UI design, so I would appreciate any input from you on what can improve not just integration with the rest of Workspaces but also user experience. There are two problems with icons I already know about, but I'm unsure of the what the best step would be: 1) icons for rotation - should I make special 90 deg clockwise and 90 deg counterclockwise icons, as shown here [2]? 2) icon for primary output - some people did not understand that the bookmark icon represents primary monitor. Is it OK or should I try to find something better (and what do you think would fit best)? If you want to try it, you need my fork of Alex's libkscreen (contains things I didn't send to Alex for review yet) from scratch/dvratil/libkscreen- clone.git and the KCM from scratch/dvratil/displayconfiguration.git Note: the KCM can be already used to configure monitors, but does not yet react to changes (i.e. it won't update when you unplug a monitor) Cheers, Dan [0] https://www.progdan.cz/2012/09/display-management-in-kde/ [1] http://i.imgur.com/Lijng.png [2] http://i.minus.com/j0jCsZ3DaQQPO.jpg -- -- dvra...@redhat.com | Associate Software Engineer / BaseOS / KDE, Qt GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Display Configuration KCM design review
On Tuesday 02 of October 2012 14:48:25 Sebastian Kügler wrote: On Tuesday, October 02, 2012 14:29:24 Dan Vrátil wrote: As some might notice [0], we are working with Alex Fiestas on new display management for KDE. I'm now working on new KCM. Aaron suggested in comments below the blog post that it would be nice to discuss design of the KCM with you, Plasma guys. As d_ed and few others suggested, I have rewritten the bottom control pane to use standard QWidgets rather then QML, so now it looks like this: [1]. Still, I really suck at UI design, so I would appreciate any input from you on what can improve not just integration with the rest of Workspaces but also user experience. There are two problems with icons I already know about, but I'm unsure of the what the best step would be: 1) icons for rotation - should I make special 90 deg clockwise and 90 deg counterclockwise icons, as shown here [2]? 2) icon for primary output - some people did not understand that the bookmark icon represents primary monitor. Is it OK or should I try to find something better (and what do you think would fit best)? If you want to try it, you need my fork of Alex's libkscreen (contains things I didn't send to Alex for review yet) from scratch/dvratil/libkscreen- clone.git and the KCM from scratch/dvratil/displayconfiguration.git Note: the KCM can be already used to configure monitors, but does not yet react to changes (i.e. it won't update when you unplug a monitor) Could you post a screenshot using the default color scheme? I'm a bit confused how it would look like for normal users... Sure, sorry. http://i.imgur.com/1GnRV.png It does not look exactly like I expected (I'm so used to my theme it did not occur to me to try the default one), the background should not be white, but rather...darker gray, possibly the same like in krandr KCM now. Dan -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 -- -- dvra...@redhat.com | Associate Software Engineer / BaseOS / KDE, Qt GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Display Configuration KCM design review
On Tuesday 02 of October 2012 14:50:01 Marco Martin wrote: On Tuesday 02 October 2012, Dan Vrátil wrote: Hi! As some might notice [0], we are working with Alex Fiestas on new display management for KDE. I'm now working on new KCM. Aaron suggested in comments below the blog post that it would be nice to discuss design of the KCM with you, Plasma guys. I thinks it already looks prettier than the old one ;) There are two problems with icons I already know about, but I'm unsure of the what the best step would be: 1) icons for rotation - should I make special 90 deg clockwise and 90 deg counterclockwise icons, as shown here [2]? in [2] those rotation icons look better (i don't think colored icons go so well there) 2) icon for primary output - some people did not understand that the bookmark icon represents primary monitor. Is it OK or should I try to find something better (and what do you think would fit best)? i was about to ask what it was for ;) maybe the primary should just have written primary in it the others have a make primary below the monitor (not in it since doesn't fit) also, what does the green thick? When you click the green tick, you disable the output (and it changes into a red cross). in general some remarks: QWidget area below: * It should use a Form layout: recognizable because has the labels aligned to the right * checkboxes should be aligned with the combobox * (here a bit more controversial) instead of checkboxes with text, have text on the left, then checkbox Will do. Graphical area (is it in qml?): Yup, QML * there should be as little stuff as possible in the monitors, would remove the thickmark if not really necessary Without the border it looks weird when the monitor are touching (see below). Someone suggested removing the resolution and the enable/disable switch (see below too) and having only rotate and primary buttons and output label... * no underline below the resolution The underline represents physical bottom side of the monitor. When you rotate the output 90 degrees clockwise, the underline would be on the right side. * could them be a bit spaced? now they are touching and looks quite cramped They are touching in real world, so they have to be touching here too. The positioning of the outputs in the view represent mutual positioning of the physical monitors on your table. * green rounded rectanlgles doesn't look that good We actually have a Plasma theme element to represent a monitor: it's the one that is still used in the screensaver kcm: it's a framesvg, so it can be resized to any size without looking deformed, would be nice to use that (not sure about the monitor stand, can be tried both with or without. we have a qwidget for it in the kworkspace lib or in qml would be trivial to do. I'll check that. I'd have to go without the stand as it would make it difficult to position outputs above each other. Although without the stand it looks more like a tablet then a monitor..:) Thanks! Dan Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- -- dvra...@redhat.com | Associate Software Engineer / BaseOS / KDE, Qt GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Display Configuration KCM design review
On Tuesday 02 of October 2012 14:52:50 Marco Martin wrote: On Tuesday 02 October 2012, Marco Martin wrote: * no underline below the resolution * could them be a bit spaced? now they are touching and looks quite cramped * green rounded rectanlgles doesn't look that good ah, another thing: what is the use of that i icon? it seems rendered at the wrong size, should at least be rendered at an unscaled size (any size known to kiconloader) It's equivalent to Identify outputs button in the krandr KCM. It's unscaled because of a bug (??) in QIconItem from qmlextracomponents, which seems to only load Desktop size of the icon, regardless of the actual dimensions of the QML item. Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- -- dvra...@redhat.com | Associate Software Engineer / BaseOS / KDE, Qt GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
