Re: Clang Format Update

2020-10-26 Thread David Edmundson
In a similar topic I've been pointed to a tool called qmlformat. It's
basically clang-format for QML.

It seems to work quite well. It insists on a very specific code layout :
https://doc.qt.io/qt-5/qml-codingconventions.html
id first, then newly declared properties and so on. This makes the changes
applied to files quite extreme.

It also removes braces on single line if statements with no possibility for
configuration currently.

I don't want to block the C++ tidying discussion on this, but it's
definitely worth looking into in parallel.

David


Re: Clang Format Update

2020-10-26 Thread David Edmundson
Jan Blackwill has bumped this in a recent MR:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/381
It's a bit easier to visualise the changes, but note gitlab isn't showing
all the changes.  It still does better than Phabricator did last year which
just fell over completely.

Bumping this thread so people are aware.

David


Re: LiFE Exam

2020-10-05 Thread David Edmundson
>
> this seems to happen on a live usb flash drive only..  (or when booting
> the iso file in virtualbox)
> it is very easy to reproduce and it makes no sense to me at all.
>
>
This ISO on your website: https://life-edu.eu/public/life-2004-1.iso ?

David


Re: Plasma Beta Review Day

2020-09-28 Thread David Edmundson
Feedback on the "beta review day"

The day was worthwhile - we got 3 or 4 new people involved.

Mostly the day ended up being users with specific bugs that only they had,
and us using the real-time chat and having time set aside to get on with
fixing things quicker than we could have done on bugzilla.
Not what I had really imagined for the day to be, but not a bad use either.

Things also seemed to go better when I said "I need someone to test blah"
it got more response than keeping things vague. Next time a bunch of those
upfront would help.

Overall I wasn't super impressed with the turnout. Maybe Thursday isn't a
good day? I had expected a bunch of people in the evening, but that didn't
materialise. In hindsight I should have done some more on-the-day promo
too. None of the new people turned on their mics/webcams and just used the
chat, I thought BBB might make it more social, but maybe it just made
things pressuring and awkward?

I think it is worth trying again but only with some adjustments.

David


Re: Adding Bitbar functionality to Plasma

2020-09-21 Thread David Edmundson
On Mon, Sep 21, 2020 at 7:44 AM Lasath Fernando  wrote:

> Hello There!
>
> I don't know if any of you remember me -
>

Of course!

it's been many years since I made any contributions to KDE. However, I
> would like to change that! :D
> Recently, I became the maintainer for a plasma applet called "Kargos":
> https://github.com/lipido/kargos
> It's a Plasma port of Mac OSX's BitBar: https://github.com/matryer/bitbar
> (I tried to include a screenshot, but it looks like these mailing lists
> have a limit of 40KB)
>
> Those github pages give a lot of detail about exactly what it does and how
> to use it, but the short version is that it runs a given script
> periodically and displays the stdout in a panel.
> This has made Plasma applets much more accessible to anyone that knows
> programming (or even shell scripting), as they can simply instantiate this
> to watch something. (No need to worry about Ui/Layout logic or Qt/QML at
> all).
>
> However, I believe this kind of functionality should be built into Plasma
> itself, rather than being a far-away applet users have to stumble upon.
> (Kind of like how the earlier versions of Chrome included direct support
> for Firefox's Greasemonkey scripts without users having to install the
> Greasemonkey plugin ;-)
>
> First of all, I would like the Plasma team's blessing before I start doing
> any significant amount of work on this.
>

It existing somewhere as a thing. Sure.

I'm not sure how much we want to treat it as a super first class citizen,
given output will never look as native or be as dynamic.
I don't think we want any of our main applets written in it, but supporting
it like we support the web slice as a plasmoid, seems pretty sensible.


> Secondly, (assuming I have the first), I would like to hear your thoughts
> on the best architecture for it.
>

Currently it's an applet right? It seems like a sensible design as it
shields the shell from caring about the applet internals which I like.

What are the specific problems with this that we want to address?

David


Re: Plasma Beta Review Day

2020-09-21 Thread David Edmundson
Blog post done and published.

http://blog.davidedmundson.co.uk/blog/plasma-beta-review-day/


Re: Plasma Beta Review Day

2020-09-21 Thread David Edmundson
>
> Or will that be determined who who shows up and what they want to do? :)
>

A bit of that :)

We can certainly have a set of small regressions for when someone says "I
want to fix something", and we can try and prioritise things.

David


Re: Plasma Beta Review Day

2020-09-20 Thread David Edmundson
>
> I have some questions:
>
> - What actually happens during the review day? What do you do?
>

To be completely honest, it's slightly free-flow.

I used to run some years ago (e.g
https://community.kde.org/Get_Involved/Quality/Beta/4.10/Plasma
https://community.kde.org/Get_Involved/Quality/Beta/4.10/AreasToTest) where
I'd make a list of things to focus on and people would go yolo.

We'd hang out on IRC during and it seemed a lot would get done. To some
extent the checklists and whatever wasn't too important, it was the invite
to an "event" that helped get some new people in.

--

A super draft blog:

http://blog.davidedmundson.co.uk/?p=329=1&_ppp=104a0f

Needs some links and whatnot.

David


Re: Plasma Beta Review Day

2020-09-20 Thread David Edmundson
I'll draft a blog ready for proof reading by the meeting tomorrow.

David


Re: How to enable notification history for an application

2020-09-18 Thread David Edmundson
On Fri, Sep 18, 2020 at 3:45 PM Kai Uwe Broulik 
wrote:

> Hi,
>
>
> > Is it possible for the application to change its own "show in history"
> > setting, instead of the user going to System Settings to do this?
>
> It is not.
>

Let's back up a bit, what's the end goal we're trying to achieve for the
kalarm notifications that isn't fulfilled out of the box.

David


Re: drkonqi and the windows build

2020-09-17 Thread David Edmundson
>yet it gets built on windows. shall we stop
doing that

AFAIK it is used and this was something explicitly requested.

There is a KF6 workboard task to get into frameworks for kf6
David


D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2020-09-17 Thread David Edmundson
davidedmundson added a comment.


  But I could still just copy the relevant lines into kcmshell directly instead 
of linking.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23883

To: heikobecker, #plasma
Cc: davidedmundson, asturmlechner, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2020-09-17 Thread David Edmundson
davidedmundson added a comment.


  > Any update here? Can this hack be dropped now?
  
  I did follow up on that. A distro is still wanting to do the setup which 
requires this opt-in hack.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23883

To: heikobecker, #plasma
Cc: davidedmundson, asturmlechner, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


Re: Integration of layer-shell in plasma

2020-08-28 Thread David Edmundson
>* Mimic absolute positioning via relative positioning. It's good as a
short-term solution, but imho, we need something better

I'm not quite sure I understand which way you're describing:

Do you mean having plasma code still do absolute co-ordinates and then have
us turn it into relative positions like how Qt does popups?

Or having client code do things in relative co-ordinates and locally
convert it to absolute and using the existing plasmashell protocol.

> The most ideal case is where Qt provides native support for the
layer-shell protocol out of the box.

Qt6 will have a new way of doing native functions on platform windows which
looks very encouraging.

Effectively it'll become QWaylandWindow: public QPlatformWindow, public
QWaylandSpecificMagicWindowStuff

Then Qt ships a header file of QPublicWaylandSpecificMagicWindowStuff which
will contain all the getters with native code and a bunch of virtuals for
setting things and one can downcast the platform window.
Compared to the old nativeinterface approach it's /amazing/. I think
that'll be a good entry point for all this.

Then at a KDE level we can surface that as agnostic public API that does
it's own local thing on X, and uses this Qt-platform-specific API on
wayland.

David


Re: C++17 in Plasma

2020-08-24 Thread David Edmundson
On Fri, Aug 21, 2020 at 6:21 PM Nicolas Fella  wrote:

> Hi,
>
> do we have any rules on the C++ standard used in Plasma?


All our rules can be boiled down to one point:
 - Don't break distros

>Given that kactivitymanagerd is technically part of Plasma we even have
precedence of using C++17

Yeah, so it's clearly fine. Feel free to go for it.
The only repo we need to be slightly cautious about is libksysguard as
that's used outside plasma. (b)

It was also briefly discussed at the plasma weekly meeting. No objections
were made.

One comment was brought up.

[11:15]  Keep in mind that there are is a few (one?) incompatible
change where noexcept is part of the type of a function
[11:16]  Because that does stuff with function pointers
[11:16] 
https://invent.kde.org/plasma/drkonqi/-/merge_requests/2/diffs
[11:17]  So the type of a function potentially differs when you
build in c++17 or c++14 mode

David


Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

2020-08-10 Thread David Edmundson
Right now the component "plasma-widget" is filled with bugs about common
klipper code.
If we move the component to plasmashell that's not going to change.

Unless you have a new idea on making it really "applet only" we're
ultimately just going to spread bug reports out across two places, and
that's just making life harder for everyone.

David


Re: merge request and issue notifications to this list?

2020-07-29 Thread David Edmundson
On Wed, Jul 29, 2020 at 1:25 PM Bhushan Shah  wrote:

> On Wed, Jul 29, 2020 at 05:47:02PM +0530, Bhushan Shah wrote:
> > If you have any ack/nack regarding this, please reply to this thread.
>
> Personally speaking I'd say it makes sense to enable this so we do not
> miss any merge requests and/or tasks discussions. Currently this mailing
> list is mostly dormant and gets CI emails only.
>
> I've quite enjoyed these last few months of having plasma-devel a readable
place where people can actually discuss things.
I would even say the CI emails have had more attention because there's been
less noise.


> Other option would be to create a separate plasma-notifications mailing
> list which people can subscribe if they wish to for this purpose.
>
> ++

> ...
>
> Also,
>
> Had forgotten first reference completely, but here you go.
>
> [1] https://mail.kde.org/pipermail/kde-community/2020q3/006451.html
> > [2] https://invent.kde.org/sysadmin/activityfilter#mailing-list-rules
> >
> > --
> > Bhushan Shah
> > http://blog.bshah.in
> > IRC Nick : bshah on Freenode
> > GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
>
>
>
> --
> Bhushan Shah
> http://blog.bshah.in
> IRC Nick : bshah on Freenode
> GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
>


Re: Gitlab and plasma dev

2020-07-23 Thread David Edmundson
Gitlab has a new "approve" feature. I think it naturally makes sense to use
this instead of the labels as our official workflow.

One thing to note is that (like labels) the approve button does not send
any emails to the recipient.

David


[Powerdevil] [Bug 353463] RFE: Make use of iio-sensor-proxy

2020-07-22 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=353463

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #14 from David Edmundson  ---
Kscreen currently supports QtSensors. QtSensors supports iio-sensor-proxy.

That has been merged. If there is a bug in that it needs to be addressed with
more detail.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.15 - Build # 57 - Still Failing!

2020-07-21 Thread David Edmundson
Investigated, kwin is just failing as BSD is missing some frameworks
changes. All good from a Plasma POV.


Re: Killing the systemd user session on logout

2020-07-16 Thread David Edmundson
On Mon, Jul 13, 2020 at 8:15 PM Bernie Innocenti  wrote:

> On 13/07/2020 17.48, David Edmundson wrote:
> >
> >
> > On Sun, Jul 12, 2020 at 5:29 PM Bernie Innocenti  > <mailto:ber...@codewiz.org>> wrote:
> >
> > (re-posting because most subscribers might have missed my previous
> post
> > due to an excessively strict DKIM policy applied by my domain).
> >
> >
> > I'm trying to fix this longstanding bug where there are dangling user
> > processes after the desktop session exists:
> >
> > https://bugs.kde.org/show_bug.cgi?id=359651
> > <https://bugs.kde.org/show_bug.cgi?id=359651>
> >
> > This is reproducible every time on multiple distributions and KDE
> > versions. It also causes subsequent logins to fail or behave
> > surprisingly due to the presence of extraneous dbus services,
> > pulseaudio
> > clients, etc.
> >
> > Yes it's a problem.
> > Pulseaudio deliberately tries to survive whilst a user is logged in, so
> > that's fine
> > The DBus services is a bit weird.
> >
> > Apparently gnome used to solve this problem by killing dbus-daemon
> > explicitly :/
> >
> > I looked into plasma-workspace/startkde, and there's no hint of it
> > starting "systemd --user" directly.
> >
> >
> >  >So I'm starting to think that it might be done implicitly via PAM
> >
> > (there's a pam_systemd module).
> >
> > That's exactly what happens.
> >
> > But, if a PAM module is starting "systemd
> > --user", shouldn't the same PAM module also do the cleanup?
> >
> >
> > IMHO yes, what I've been trying to do to solve this is to make the
> > systemd user session aware of all our stuff.
> > We've currently introduced cgroups round the apps, we're tackling the
> > services slowly as part of the plasma boot.
> >
> > Then "all" we need to do is ship two drop-ins for app-*  and plasma-*
> > scopes and services.
> > That include the line BindsTo=graphic-session.target
> >
> > Once that ends, it'll tear down everything in a controlled manner just
> > like a system process.
> > This is also what gnome is doing to do.
>
> Do you have a work-in-progress patch I could see?
>
> The actual scoping of applications is already merged (see systemd-cgls on
Plasma 5.19).
Scoping of the background services is on review and scattered around the
place.

Then we need these drop-ins to scope them to the lifespan of the session.
https://invent.kde.org/davidedmundson/systemd-dropins

Let me know if that makes a difference, it seems to be working nicely for
me.

David


Re: How should we handle multi-screen bug reports?

2020-07-13 Thread David Edmundson
>2. KWin | multihead

Technically not that at all. Multihead is something we had 10 years ago.

I don't think we can do anything to accept the mess of bugs coming in and
triage appropriately once we can get a good description from the reporter.
I think most plasma devs look at all plasma bugs anyway...

Generally speaking:
 - if monitors are in the wrong place, kscreen
 - if only windows misbehave, kwin
 - entire session crashes on wayland, kwin
 - client crashes on wayland, Qt
 - if only widgets or taskbar are wrong but you can drag dolphin there
absolutely fine, plasmashell

Obviously with some exceptions.

David


Re: 5.19.3 and logout

2020-07-13 Thread David Edmundson
I'm sorry to hear there are issues.

So just to confirm:

with "confirm logout" enabled:
 - everything works correctly

with "confirm logout" disabled:
 - the menu works correctly
 - the logout widget sometimes does the wrong thing and shuts down instead
of logging out.

David


Re: Killing the systemd user session on logout

2020-07-13 Thread David Edmundson
On Sun, Jul 12, 2020 at 5:29 PM Bernie Innocenti  wrote:

> (re-posting because most subscribers might have missed my previous post
> due to an excessively strict DKIM policy applied by my domain).
>
>
> I'm trying to fix this longstanding bug where there are dangling user
> processes after the desktop session exists:
>
>https://bugs.kde.org/show_bug.cgi?id=359651
>
> This is reproducible every time on multiple distributions and KDE
> versions. It also causes subsequent logins to fail or behave
> surprisingly due to the presence of extraneous dbus services, pulseaudio
> clients, etc.
>
> Yes it's a problem.
Pulseaudio deliberately tries to survive whilst a user is logged in, so
that's fine
The DBus services is a bit weird.

Apparently gnome used to solve this problem by killing dbus-daemon
explicitly :/



> I looked into plasma-workspace/startkde, and there's no hint of it
> starting "systemd --user" directly.
>

>So I'm starting to think that it might be done implicitly via PAM

> (there's a pam_systemd module).
>
> That's exactly what happens.


>

> But, if a PAM module is starting "systemd
> --user", shouldn't the same PAM module also do the cleanup?
>

IMHO yes, what I've been trying to do to solve this is to make the systemd
user session aware of all our stuff.
We've currently introduced cgroups round the apps, we're tackling the
services slowly as part of the plasma boot.

Then "all" we need to do is ship two drop-ins for app-*  and plasma-*
scopes and services.
That include the line BindsTo=graphic-session.target

Once that ends, it'll tear down everything in a controlled manner just like
a system process.
This is also what gnome is doing to do.

Some notes about that topic: https://systemd.io/DESKTOP_ENVIRONMENTS/

David


> --
> _ // Bernie Innocenti
> \X/  https://codewiz.org/
>


D28651: Load and use global animation settings

2020-07-09 Thread David Edmundson
davidedmundson added a comment.


  Just push it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28651

To: sandsmark, #breeze
Cc: cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, 
#breeze, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, trickyricky26, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Re: dipping a toe in waywater? :)

2020-07-03 Thread David Edmundson
Select "plasma (wayland)" from SDDM.

David


Re: Gitlab merge workflow: reverse it?

2020-06-25 Thread David Edmundson
> You have this button from commit page, not merge request page.
>
> https://i.imgur.com/9kgdpVy.png


Found it, that's perfect thanks.

That's also a useful feature in the current workflow.
Seems you can cherry-pick a commit in a work/branch to a new merge request.


> If you use git cherry-pick with -x option, git automatically adds this
> message in commit.
>

That's handy. Clearly it's a common workflow then.


> >   - without making people commit locally into stable, could it encourage
> > people to not test as much?
>
> I did not actually suggest using Web UI but using the git operation
> locally. And in fairness either way we do end up with one bit where
> thing is untested,
>

It was the use of the web UI that I thought might encourage it, as then
you're not even changing branches locally to test things.
You're right that changing the workflow doesn't necessarily mean changing
that.

And yes, it's a problem already, which is why I don't want it getting worse!

There's another advantage in this pattern we've not discussed yet. We can
commit something to master, test for a few days and only then decide to
cherry-pick to stable, that could potentially improve some things.

David


Re: Gitlab merge workflow: reverse it?

2020-06-25 Thread David Edmundson
On Thu, Jun 25, 2020 at 3:46 PM Bhushan Shah  wrote:

> Hello everyone!
>
> This is a proposal to change our workflow regarding release branches and
> our merge workflow,
>
> # Current workflow
>
> - Current workflow is that we commit to stable branch and then merge it
>   upwords until master branch
> - i.e commit to Plasma/5.18 branch, merge 5.18 into 5.19 and then
>   master
>
> # Proposed workflow
>
> - Proposed workflow is to instead commit all changes in master, and
>   cherry-pick related changes in the stable branch as needed
>
>
Gitlab supposedly has a magic button for it just after a commit has landed
in master.
https://docs.gitlab.com/ee/user/project/merge_requests/cherry_pick_changes.html

Though I don't know how to trigger that in our UI.


> # Why?
>
> We occasionally hit several issues with current workflow,
>
> - Merge conflicts when merging changes upwords
> - Changes which are valid only for stable branch needs to be reverted in
>   master branches
> - Accidential merges from the master branch to stable branch which needs
>   to be force-pushed
>
> It's worth noting that Qt also recently changed to merge to dev,
cherry-pick backwards.
In principle I completely agree.

I have a few fears, which I hope are all addressable.

  - we need some reference to the real commit.

Qt adds
"(cherry picked from commit 6de0287d7c3aa4251fe6eb4f970d73ce11cf07fc)"
to the commit message automagically somehow in their workflow.

  - without making people commit locally into stable, could it encourage
people to not test as much?


> For now I am proposing this change only for Plasma repositories if we
> like it, we can propose this workflow for rest of KDE repositories, but
> that needs discussions in kde-devel/kde-core-devel separately.
>
> Thoughts?
>

I like consistency across KDE, otherwise it's very difficult for people who
contribute in N places.
We should at least email before we change, though we can still discuss
things here first.

David


Sprint notes - widget and plasma styling in Plasma 6

2020-06-15 Thread David Edmundson
We all agree we should have a custom QStyle and QtQuick Controls style that
can load a theme written in some declarative text + image format then we
use the native toolkit support to render that in the best way. Only this
would be supported.

However:
 - Realistically this is not feasible for Plasma 6.0
 - We should go as-is for Plasma 6.0 with our QtQuick plasma style and
QtQuick desktop style which will do QPainter things and upload large
textures. Maybe Qt6's new API can help, maybe not.

This still leaves the problem of plasma configuration where we want the
desktop view in the same process as where the QQC2 theme is the plasma
style.

 - Continue using Plasma imports to explicitly set the theme. We
universally decided we don't want this in Plasma 6.

  - something clever with QUrlInterceptor. This may need changes to
QUrlInterceptor, so we should look into it early

 - Run config UIs as a separate process

 - just use the plasma theme in configs.


All have pros and cnos.

David


Re: Sprint notes for gitlab discussion

2020-06-15 Thread David Edmundson
So to clarify, there are two allowed gitlab workflows.

MRs for chains of nicely done rebased commits
MRs where one MR represents a single logical commit to be squashed and the
list of actual commits uploaded is garbage.


>
> One issue with such a workflow is that code reviewers will have to
> accumulate all commits in their mind. Speaking for myself, that is
> really difficult.
>

Not really, we either just either review individual commits, or we review
the whole merge request depending on what is relevant from the style used.
It's normally clear from the commit names.


> Another issue is that it's not clear how the commits are going to be
> squashed, which makes it even more hard to add "ship it."
>



> For example, let's consider that a person has created a merge request
> with two commits
>

If the person is good at git, they'll squash C locally before force pushing.
If the person is not, they should just have made two merge requests to
begin with.

I think we can certainly encourage the good git pattern especially for an
advanced complicated multi-commit branch.
it's just a case of finding a balance for the people just doing really
simple changes.

David


Sprint notes from KF6 Architectural plans discussion

2020-06-14 Thread David Edmundson
Everything is in note form. I've tried to tidy things up to be readable,
but please do ping if there are questions.

We've made quite a few porting goals of things we should try and do within
Plasma 5.



Systemsettings:
 - QtQuick only
 - Use binary plasma-settings for everything, effectively drop the
kcmutils part
 - The models in system settings may be better so we can copy that
 - This means porting all the KCMs within the next few years.
 - Font install KCM is a tricky thing to port, maybe we can just keep
it separated as it's not a setting.
 - To help aid porting we need a plugin selector QML (kwin sort of has
one)
 - We should ban new widget KCMs
 - Some of big ones left include; powerdevil, bluetooth, network need
some design

Plasmoids:
- We should simplify the Applet/AppletQuick/AppletInterface mess that we
have.  Contaminants should deal with the graphical item, the internal
Plasmoid object isn't very relevant.
- New plan is that the Plasmoid attached object /is/ the plugin (if
applicable) or the current Applet superclass. We remove clients having to
call nativeInterface, so it and attached Plasmoid are all one object. Which
allows plugins to register types etc.
(to summarise, we copy paste what we do for KCMs into plasmoids)

- The concept of systemtray should become the job of panel, not an applet
within the containment.
 - should handling compact/full representations be the task of the applet
rather than a core part of the framework? (no real agreement there, The
deciding factor is how systray could still work)

DataEngines?
   - We should remove them all?
   - Ideally things should be declarative plugins in the respective
framework
   - Dataengines are not really usable in applications, proper QML imports
would fix that
   - We should try to port away from dataengines in plasma5 lifetime, if we
fail, we'll move in own legacy library, not keep it in frameworks

Applets:
   - We should have more base classes for things
   - eg. BaseCalendar, which anyone can import when making a clock and get
the same fullscreen wallapers. Or an ImageWallpaper base that does the
transition (and cache) and anyone inherits.
- Currently battery is one example of such a shared component that is
used now.

All the SVG stuff:
 - Marco likes them :)
 - We will  to another framework, marco started already
 - intertwined wtih plasma::theme which we want to kill...
- theme access replaced with kpackage
- This currently only has QPainter stuff
- Intention is to add the QtQuick bindings

David


Sprint notes for gitlab discussion

2020-06-14 Thread David Edmundson
  - Generally working well
 - There seems to be an uptick in new contributors \o/



 - We had a discussion about how to make review queues a big more
manageable.
We intend to use some labels.

Action plan is to copy + paste the labels Krita uses...as if it works for
them, they're probably good enough. Bshah is to do this.

Labels are technically per-project, but as long as they have the same name
it's fine.



 - There was a discussion on the two different styles of use gitlab use.
Some people squash locally and have a nice neat commit history. Others
don't, and then just squash at end.

 - Conclusion was it's unreasonable to get devs to squash and rebase
"nicely" as it's perceived as too hard (even though it really isn't - ed)

 - As reviewers we're just cope with the fact that these two workflows
exist

 - We do need to be careful when people squash as the commit message
used is not the merge messages

  - Maybe we should make squash a default option - in current gitlab
this option doesn't exist

David


Plasma 5.20 and Qt versions

2020-06-12 Thread David Edmundson
Distros,

We're in the process of determining our dependencies for Plasma 5.20, our
release in about 4 months.

Ideally we would like to depend on Qt5.15, we can land some wayland fixes
that would be otherwise hard to  #ifdef as well as do some big code cleanup.

Obviously we're only comfortable doing that if we're not going to lock out
any potential users.

Are there any distros that are currently planning to ship Plasma 5.20 and
not have Qt5.15? If so, could you let us know.

David


A recommended applet for KDE devs

2020-06-11 Thread David Edmundson
Chris Holland (or zren) has written an applet that lists gitlab merge
requests in a plasmoid.

It's /amazing/

https://store.kde.org/p/1381655/

Despite the name, it also shows pending merge requests which is quite
useful. It's sort of like an RSS feed, but better. I would recommend it to
all the plasma core maintainers.

David


D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

2020-06-11 Thread David Edmundson
davidedmundson added a comment.


  Sorry! pushed.
  
  Please do feel free to nag if I forget things.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17960

To: kvanton, #plasma
Cc: ltoscano, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Re: Plasma virtual sprint 2020

2020-06-09 Thread David Edmundson
Can everyone send topics they want to discuss to this ML. Then maybe we can
assemble some sort of program.

David


Re: kde-gtk-config repository name change

2020-06-01 Thread David Edmundson
On Mon, Jun 1, 2020 at 12:46 PM Mikhail Zolotukhin 
wrote:

> Hello,
>
> I am the de facto maintainer of the kde-gtk-config repository. As of now
> the name of this repository on GitLab is "KDE GTK Configurator" and the
> description is "Syncs KDE settings to GTK applications". I think there
> could be a better name and a description for the project. Current one has a
> couple of issues:
>
> 1. Current repository name itself does not show the purpose of the things,
> that it contains. Why it exists? What problem it actually solves?
> 2. The description is not accurate. It's not only about syncing some kde
> (maybe Plasma?) settings to GTK. It also provides a way to set a GTK theme
> in Plasma.
> 3. The name does not show its relation to Plasma and the fact, that that
> "Configurator" only works in that desktop envinroment.
>
> Actually the code's job in that repository is providing a smooth
> experience for GTK applications in Plasma, so that they looks more native,
> in other words it integrates GTK into Plasma.
>
> Given all of that I think the better name for the repository would be
> "plasma-gtk-integration", On GitLab it could be called "Plasma GTK
> Integration" with the description "Components necessary to integrate GTK
> applications into the Plasma Desktop".
>
> The name is good.


> What do people think of that change? Does anyone have any suggestions to
> improve the renaming?
>
>
Changing the repo implies changing the release tarball name.

Distributions won't like that, it's making a lot of work for them. They'll
have to rewrite packaging and add migratory steps based on previous
installs and update various metapackages.
That's fine if it's a valid useful fix that affect end users, but we
shouldn't do it without good reason.

Something to factor in when weighing up pros and cons.
Please message kde-distro-packag...@kde.org before committing to anything.

David


Re: Gitlab and plasma dev

2020-05-27 Thread David Edmundson
One thing I'm missing when I'm doing reviews is I don't have a nice way to
separate merge requests that need review, and merge requests that are
awaiting changes.

I think this could be achieved with a label, that reviewers can set and
authors can clear when they're ready.
Somehow it's possible to create a label that covers all of Plasma as the
VDG have one already.

Would that workflow work for other devs?

David


Re: Remove stale branches?

2020-05-26 Thread David Edmundson
Yes, we should remove stale personal branches

git push origin :someBranchName   (with the colon)

for non-stale branches you use the prefix "work/someBranchName"  and you
can use that directly from gitlab without a fork which you can force push
to.
Gitlab has a button to auto-remove those on merge.

David


D29827: Give users the ability to disable the microphone indicator

2020-05-23 Thread David Edmundson
davidedmundson added a comment.


  It's an SNI, I thought the systemtray could already filter SNIs in the  
enties tab of the system tray?
  
  
  
  > I made different attempts to achieve this. The class was imagined like a 
singleton, but it's not really a singleton, anyway it's initialized by the 
volume applet and it stays there having only one instance.
  
  The class was a singleton within the given QML context, The configuration UI 
is another context, which is why it instantiated a new one.
  
  
  
  One major comment about the config that I don't understand.

INLINE COMMENTS

> ConfigGeneral.qml:114
> +Kirigami.FormData.label: i18n("Show an indicator when an application 
> is using the:")
> +checked: micIndicator.enabled
> +text: i18n("Microphone")

I don't see why we're doing this.

Firstly it's a bit messy with regards to when this binds and updates vs when 
kcfg overwrites this binding.

Secondly and much more importantly why should whether this is currently enabled 
or not ultimately change the config value stored of whether we show the 
indicator when something is recording?

Once that's gone the entire singleton aspect is a lot less relevant.

> microphoneindicator.cpp:320
> +
> +void MicrophoneIndicatorInterface::setStatus(bool status)
> +{

setStatus(bool) is confusing naming

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: davidedmundson, meven, bcooksley, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D29476: WIP: Port klipper to use wayland clipboard

2020-05-18 Thread David Edmundson
davidedmundson abandoned this revision.
davidedmundson added a comment.


  Moving to invent

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: ngraham, cblack, apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D29682: Elide sensor names in config view

2020-05-18 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:b62b7719c7e1: Elide sensor names in config view (authored 
by davidedmundson).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29682?vs=82670=83037

REVISION DETAIL
  https://phabricator.kde.org/D29682

AFFECTED FILES
  faces/UsedSensorsView.qml

To: davidedmundson, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Gitlab and plasma dev

2020-05-18 Thread David Edmundson
Pasting relevant gitlab factoids from the meeting:

All of Plasma is on gitlab now. New review requests should go there.

New review requests are *not* currently coming to come to this mailing list.

If you are a maintainer you can subscribe to all of plasma by going to:
https://invent.kde.org/plasma

signing in, and clicking the bell icon near the top

You can also subscribe to just individual repos.



 Small PSA: you can arc land things from Phab to gitlab, assuming
the remote is setup properly

-

We should all collectively make an effort to clear our phabricator queue of
pending patches.

Regards

David


Re: New Plasma modules and localization

2020-05-16 Thread David Edmundson
>
> > It is sad, however, to see some regressions in translations. I cannot
> test by
> > myself but there are reports that some parts of the new KWin Rules KCM
> are
> > untranslatable:
> >
> > https://phabricator.kde.org/D29413
> >
> > Can somebody test if it's true?
>

Reading the code I can't immediately see any reason why it would be true.

>
> > The new ksysguard translations are broken. Extraction scripts do not
> work.
> >
> > $XGETTEXT *.cpp -o ksysguard_plugins_global.pot
> >  $XGETTEXT *.cpp -o ksysguard_plugins_process.pot
> >
> > should be replaced with
> >
> > $XGETTEXT `find -name \*.cpp` -o $podir/ksysguard_plugins_global.pot
> > $XGETTEXT `find -name \*.cpp` -o $podir/ksysguard_plugins_process.pot
> >
>
Indeed. That's on me. Sorry.

Will push when git KDE works again.
Thanks


> > The root localization of libksysguard is broken as well.
> >
> > Messages.sh extracts to KSysGuardSensorFaces.pot, QML code contains
> something
> > like i18nd("KSysGuardSensorFaces", "Remove") but CMakeLists.txt points
> to
> > add_definitions(-DTRANSLATION_DOMAIN=\"ksysguard_faces\")
> >
>

Shouldn't be a huuge issue, only the c++ code uses the add_definitions and
that's for anything UI user facing.
Will fix anyway.


> > What should be used for this to work as expected?
> >
> > (Spotted by Victor Ryzhykh)
> >
> > Thanks in advance for your answers.
>
> Plasma people, please test translations using the x-test locale before any
> change.
>

Can someone link to some docs on how to do that?
I can find are some docs for how to actually run Messages.sh and confirm
there's some files and some docs on how to run with x-test after
translations are downloaded.

Regards

David


D29757: Only search for Qt5::Test inside the autotests dir

2020-05-14 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29757

AFFECTED FILES
  CMakeLists.txt
  kstats/autotests/CMakeLists.txt

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29753: Only build autotests when enabled

2020-05-14 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:053d42077d6c: Only build autotests when enabled (authored 
by davidedmundson).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29753?vs=82849=82856

REVISION DETAIL
  https://phabricator.kde.org/D29753

AFFECTED FILES
  kstats/CMakeLists.txt

To: davidedmundson, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29752: Prefix disk name on size labels

2020-05-14 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:ae6c4ac8e39d: Prefix disk name on size labels (authored 
by davidedmundson).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29752?vs=82848=82855

REVISION DETAIL
  https://phabricator.kde.org/D29752

AFFECTED FILES
  ksysguardd/Linux/diskstat.c

To: davidedmundson, lbeltrame, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29753: Only build autotests when enabled

2020-05-14 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  BUG: 421514

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29753

AFFECTED FILES
  kstats/CMakeLists.txt

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29752: Prefix disk name on size labels

2020-05-14 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  labels for CPU frequency are "CPU 1 Clock Frequency". Network speeds
  have the interface name at front.  Partitions didn't match, leaving the
  key in the graph to be just "Available" several times if you plotted
  multiple disks.
  
  This adds a prefix so it's consistent.
  
  BUG: 421513

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29752

AFFECTED FILES
  ksysguardd/Linux/diskstat.c

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29700: Add a show label option to the pie chart face

2020-05-14 Thread David Edmundson
davidedmundson abandoned this revision.
davidedmundson added a comment.


  Arjen suggested in a PM that we already have the concept of "total sensor" 
being optional or not. No point hiding it at a UI level when we should be doing 
it at a data level.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29700

To: davidedmundson, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29717: Fix translation domain for ksysguard plugins

2020-05-14 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:644648e165fb: Fix translation domain for ksysguard 
plugins (authored by davidedmundson).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29717?vs=82757=82822

REVISION DETAIL
  https://phabricator.kde.org/D29717

AFFECTED FILES
  plugins/CMakeLists.txt
  plugins/global/CMakeLists.txt
  plugins/global/Messages.sh
  plugins/process/CMakeLists.txt
  plugins/process/Messages.sh

To: davidedmundson, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Re: kwallet-pam >= 5.18.4 and ecryptfs homes

2020-05-13 Thread David Edmundson
>
> Opinions?

It's a tough situation, with no good answer.

>SOLUTION 2:
> * Ignore it and hope people will read my blog
https://tsdgeos.blogspot.com/2020/05/kwallet-pam-5184-and-ecryptfs-homes.html

We can simplify the bit about needing another user. If you use

sudo mount --bind / /tmp/IAmACoolNewMount  you should be able to retrieve
the file in the unmounted /home

That would then potentially allow this to be a shipped script to run.

Albeit user interaction and root would still be required, but a run-once
migration might be easier to write and maintain than long term hacks in the
pam side.


D29721: Add context to translated strings and clarify some strings

2020-05-13 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  more context never hurts. Good idea

REPOSITORY
  R106 KSysguard

BRANCH
  translation_context

REVISION DETAIL
  https://phabricator.kde.org/D29721

To: ahiemstra, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29717: Fix translation domain for ksysguard plugins

2020-05-13 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29717

AFFECTED FILES
  plugins/CMakeLists.txt
  plugins/global/CMakeLists.txt
  plugins/global/Messages.sh
  plugins/process/CMakeLists.txt
  plugins/process/Messages.sh

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29706: support translations in faces

2020-05-13 Thread David Edmundson
davidedmundson added a comment.


  Who extracts and loads the translations for:
  
  ./ConfigAppearance.qml
  ./ConfigSensors.qml
  ./FaceDetailsConfig.qml
  ./UsedSensorsView.qml
  
  in the top level of faces but not in an individual package.
  
  
  
  code for the other stuff looks correct.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29706

To: mart, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29700: Add a show label option to the pie chart face

2020-05-13 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  To control the large "20%" text in the middle of a pie which can be 
  obnoxious in the panel

REPOSITORY
  R111 KSysguard Library

BRANCH
  showLabelOnPie

REVISION DETAIL
  https://phabricator.kde.org/D29700

AFFECTED FILES
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29157: force systemsettings for kcms

2020-05-12 Thread David Edmundson
davidedmundson added a comment.


  We need a fix for https://bugs.kde.org/show_bug.cgi?id=421431
  
  Which could just be me removing making it hidden.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29157

To: mart, #plasma, ngraham
Cc: davidedmundson, broulik, ngraham, davidre, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-05-12 Thread David Edmundson
davidedmundson added a comment.


  > Show me where the documentation for this QtWaylandClientExtension is and 
where you documented that we "agreed" on using that in Plasma exclusively and 
we can talk about libkscreen using it in 5.20
  
  It was documented here https://phabricator.kde.org/T11903 at the end and it 
was discussed in the meeting on #kwin  
that you were in.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29682: Elide sensor names in config view

2020-05-12 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Eyes

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29682

AFFECTED FILES
  faces/UsedSensorsView.qml

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

2020-05-12 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> kstart.cpp:121
> +} else {
> +printf("%d\n", job->pid());
> +}

I know it's copied but, there's no need to randomly go to C to use std::cout

> kstart.cpp:128
> +if (job->error()) {
> +KStartupInfo::sendFinish( id ); // failed to start
> +} else {

Isn't command launcherjob doing KStartupInfo things?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D29621

To: broulik, #plasma, dfaure
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29615: Nice all threads of multithreaded programs

2020-05-12 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Still, I think this behavior is actually the only one usable,
  
  Indeed.  A user shouldn't be expected to know what each thread is doing 
inside an app, there isn't enough metadata to do anything useful there anyway. 
Especially with use of threadpools.
  
  FWIW,  I've been taking this logic further in the other direction from 
looking at threads. From 5.19 spawned apps will each have their own cgroup. The 
intention being to get to a point (5.20 or so) where we can do management on an 
entire cgroup (and therefore app with multi processes and threads) all at once. 
The management is way nicer, the UX is nicer, and we won't have this sort of 
problem.
  
  --
  
  > Note: this only changes the behavir for remote computers. Local use needs a 
similar fix in libksysguard.
  
  Yeah, that's the more useful one.

INLINE COMMENTS

> ProcessList.c:657
> +goto failure;
> +  /* NOTE: this is racy; threads may die or be spawned during our
> + iteration. Inthat case, we either fail with an error or fail to

heh, our use of PID is already racey

REPOSITORY
  R106 KSysguard

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D29615

To: jpalecek, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29476: WIP: Port klipper to use wayland clipboard

2020-05-12 Thread David Edmundson
davidedmundson updated this revision to Diff 82650.
davidedmundson added a comment.


  shuffle files about

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29476?vs=82106=82650

BRANCH
  davidedmundson/clipboard2

REVISION DETAIL
  https://phabricator.kde.org/D29476

AFFECTED FILES
  klipper/CMakeLists.txt
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/systemclipboard/CMakeLists.txt
  klipper/systemclipboard/qtclipboard.cpp
  klipper/systemclipboard/qtclipboard.h
  klipper/systemclipboard/systemclipboard.cpp
  klipper/systemclipboard/systemclipboard.h
  klipper/systemclipboard/waylandclipboard.cpp
  klipper/systemclipboard/waylandclipboard.h
  klipper/tests/CMakeLists.txt
  klipper/tests/paste.cpp

To: davidedmundson, #kwin
Cc: ngraham, cblack, apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-05-11 Thread David Edmundson
davidedmundson added a comment.


  > These are not specific issues but some general complains about the overall 
concept chosen here without providing an alternative solution.
  
  Well yes, it makes sense to do high level discussion first.
  
  With the Plasma agreed "new approach" that we will be porting to we will be 
using QtWaylandClientExtension and removing the need for the connection thread 
- having that in the interface will hold up progress we want to do upstream.
  
  > here without providing an alternative solution.
  
  static bool isValid() in the plugin. That is made synchronous by use of 
roundtrip. The existing plugin gets a very tiny refactor.
  
  (also you could just qputenv("KSCREEN_BACKEND") from your fork before 
launching the shell which is even less invasive)

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-05-11 Thread David Edmundson
davidedmundson added a comment.


  It's still got this pointless plugin within plugin situation.
  
  > For that at least one Wayland event loop has to be launched
  
  It needs a roundrip after the registry is fetched. That doesn't need an event 
loop.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29623: Fix Warning about KF5::KSysGuard target being deprecated

2020-05-11 Thread David Edmundson
davidedmundson added a comment.


  thanks

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29623

To: meven, #plasma, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-10 Thread David Edmundson
davidedmundson added a comment.


  > Does the mechanism of standard shortcuts really apply here?
  
  It's not implementing it yet, but that's the entire point.
  
  The bigger problem is someone added some vim shortcuts to krunner a year ago: 
(plasma-workspace a58e48707601d627781c6681389e4abe0f6e8899 
) in 
hindsight I shouldn't have accepted it.
  
  This is showing there's a bigger problem that needs to be addressed at the 
root. We can't be inconsistent with secondary shortcuts within our own code. 
Sorry.
  
  In terms of actions this means:
  
  - exposing KStandardAction::rotateUp/rotateDown somewhere generic
  - porting from KeyEvent to Shortcuts inside the QML

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29571

To: mlibera, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-09 Thread David Edmundson
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  KDE has a concept of "standard shortcuts". Instead of duplicating this same 
code everywhere with various combinations for people doing all sorts of crazy 
bindings, which is eternal we should be just looking into fixing this (if it's 
indeed broken) or expanding upon it if needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29571

To: mlibera, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28154: Add users KCM

2020-05-07 Thread David Edmundson
davidedmundson added a comment.


  From my POV. +1
  
  I still need a reply on:
  
  "Which release?"

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28154: Add users KCM

2020-05-07 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:121
> that looks like it could possibly run into race conditions, as the applyjob 
> is executed asynchronously and IIRC is able to still be running when 
> everything else, including this, has destructed and removed one of the files 
> it could be using

new QTemporaryFile(qApp) then

KJobs have an QEventLoopLocker that will stop qApp from quitting until they 
finish so you can be sure your applyjob is done.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28154: Add users KCM

2020-05-07 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:121
> whoever is normally cleaning up tempfiles

Normally the app creating a temp file would clean it up.

A quick fix would be
file = new QTemporaryFile(this);

It's sort of leaking the object, but on exit it'll tidy everything up.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28154: Add users KCM

2020-05-07 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:97
> taking the initials of a user's real name

OH!

Initial-ise

not initialise as in "to prepare"

Makes sense :)

> usermodel.cpp:37
> +connect(m_dbusInterface, ::UserAdded, 
> this, [this](const QDBusObjectPath ) {
> +User *user = new User();
> +user->setPath(path);

This one isn't parented to the model

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-07 Thread David Edmundson
davidedmundson added a comment.


  > There's going to be enough breakage as it is, let's do things that can be 
done now, now, instead of waiting for some nebulous "Plasma 6".
  
  That's a good argument when it comes to adding new code.
  For flipping defaults it doesn't really apply. We support both styles of 
layout both now and will continue to do so in Plasma 6.  There's no extra 
breakage potential.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: davidedmundson, ahiemstra, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D28154: Add users KCM

2020-05-07 Thread David Edmundson
davidedmundson added a comment.


  Which release?
  
  We need to remove user-manager. We're technically in a repo freeze, and this 
would involve changing (removing) a repo a breakage of that.
  
  
  
  Generally this looks quite neat and tidy. A big simplification +++

INLINE COMMENTS

> kcm.cpp:94
> +KQuickAddons::ConfigModule::save();
> +Q_EMIT apply();
> +}

what's this for?

> kcm.cpp:97
> +
> +QString KCMUser::initializeString(const QString& stringToInitial)
> +{

This is an odd method name.

I don't really understand what it's doing, some sort of title casing?

> kcm.cpp:121
> +QTemporaryFile file;
> +file.setAutoRemove(false);
> +if (file.open()) {

so who cleans this up?

> user.cpp:96
> +}
> +QString trueVal = value.toString();
> +if (value.toString().startsWith(QStringLiteral("file://"))) {

use url.path and url.protocol for this not string manipulation

> usermodel.cpp:72
> +connect(user, ::dataChanged, [=]() {
> +beginResetModel();
> +endResetModel();

why are we resetting the whole model instead of just dataChanged() on the 
relevant row

> usermodel.cpp:78
> +std::sort(m_userList.begin(), m_userList.end(), [](User *lhs, User *) {
> +return lhs->loggedIn();
> +});

The ones not logged in will be sorted randomly.

Also note that if the intention is to have your user at the top, this check 
won't suffice as you can have 2 things logged in.

> broulik wrote in usermodel.cpp:96
> You're leaking all the users.
> `qDeleteAll(m_userList)`

this is marked as done, yet I can't see where ?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread David Edmundson
davidedmundson updated this revision to Diff 82106.
davidedmundson added a comment.


  Fix the klipper code to handle detecting null buffer better
  X code expected a valid QMimeData object with no contents

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29476?vs=82074=82106

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29476

AFFECTED FILES
  klipper/CMakeLists.txt
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/systemclipboard.cpp
  klipper/systemclipboard.h
  klipper/tests/CMakeLists.txt
  klipper/tests/paste.cpp

To: davidedmundson, #kwin
Cc: apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D28333: Add a new daemon for stats monitoring

2020-05-06 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:75333fc13159: Add a new daemon for stats monitoring 
(authored by davidedmundson).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28333?vs=81871=82105

REVISION DETAIL
  https://phabricator.kde.org/D28333

AFFECTED FILES
  CMakeLists.txt
  kstats/CMakeLists.txt
  kstats/autotests/CMakeLists.txt
  kstats/autotests/main.cpp
  kstats/client.cpp
  kstats/client.h
  kstats/ksysguard_iface.xml
  kstats/ksysguarddaemon.cpp
  kstats/ksysguarddaemon.h
  kstats/main.cpp
  kstats/test/CMakeLists.txt
  kstats/test/README.txt
  kstats/test/main.cpp
  libkstats/AggregateSensor.cpp
  libkstats/AggregateSensor.h
  libkstats/CMakeLists.txt
  libkstats/SensorContainer.cpp
  libkstats/SensorContainer.h
  libkstats/SensorObject.cpp
  libkstats/SensorObject.h
  libkstats/SensorPlugin.cpp
  libkstats/SensorPlugin.h
  libkstats/SensorProperty.cpp
  libkstats/SensorProperty.h
  libkstats/types.h
  plugins/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/ksgrd/ksgrdiface.cpp
  plugins/global/ksgrd/ksgrdiface.h
  plugins/global/nvidia/CMakeLists.txt
  plugins/global/nvidia/nvidia.cpp
  plugins/global/nvidia/nvidia.h

To: davidedmundson, #plasma, mart, ngraham, ahiemstra
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Wayland has an entire new protocol for getting and setting clipboard
  when we don't have focus. Unfortunately this means reinventing
  QClipboard from the QPA.
  
  Not mergable as-is, especially the hardcoded line in CMakeLists but
  uploaded to show direction.
  
  It uses the newly agreed approach of using QtWayland generated classes
  in clients directly rather than writing full pimpl API-fixed wrappers first, 
  as ultimately that didn't really help do anything.
  
  Code is written so that it can be moved to KWindowSystem if needed by
  KDEConnect or others.

TEST PLAN
  Copying and pasting all over the place

REPOSITORY
  R120 Plasma Workspace

BRANCH
  davidedmundson/clipboard2

REVISION DETAIL
  https://phabricator.kde.org/D29476

AFFECTED FILES
  klipper/CMakeLists.txt
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/systemclipboard.cpp
  klipper/systemclipboard.h
  klipper/tests/CMakeLists.txt
  klipper/tests/paste.cpp

To: davidedmundson, #kwin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

2020-05-04 Thread David Edmundson
davidedmundson added a comment.


  That doesn't explain why we're changing the step size.
  
  No-one wants to click the up arrow 100 times.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29431

To: kurmikon
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28333: Add a new daemon for stats monitoring

2020-05-04 Thread David Edmundson
davidedmundson updated this revision to Diff 81871.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  Clear up plugin loading

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28333?vs=81087=81871

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28333

AFFECTED FILES
  CMakeLists.txt
  kstats/CMakeLists.txt
  kstats/autotests/CMakeLists.txt
  kstats/autotests/main.cpp
  kstats/client.cpp
  kstats/client.h
  kstats/ksysguard_iface.xml
  kstats/ksysguarddaemon.cpp
  kstats/ksysguarddaemon.h
  kstats/main.cpp
  kstats/test/CMakeLists.txt
  kstats/test/README.txt
  kstats/test/main.cpp
  libkstats/AggregateSensor.cpp
  libkstats/AggregateSensor.h
  libkstats/CMakeLists.txt
  libkstats/SensorContainer.cpp
  libkstats/SensorContainer.h
  libkstats/SensorObject.cpp
  libkstats/SensorObject.h
  libkstats/SensorPlugin.cpp
  libkstats/SensorPlugin.h
  libkstats/SensorProperty.cpp
  libkstats/SensorProperty.h
  libkstats/types.h
  plugins/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/ksgrd/ksgrdiface.cpp
  plugins/global/ksgrd/ksgrdiface.h
  plugins/global/nvidia/CMakeLists.txt
  plugins/global/nvidia/nvidia.cpp
  plugins/global/nvidia/nvidia.h

To: davidedmundson, #plasma
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash

2020-05-02 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> romangg wrote in Output.qml:60
> Is the change making this unnecessary? I.e. do the graphics still look 
> "smooth"?

Default is true so it makes no difference.

There's generally no reason to set it to false.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D29340

To: davidedmundson, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash

2020-05-02 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:cfd95e6bff4b: fix(kcm): avoid recursive OpacityMask which 
leads to teardown crash (authored by davidedmundson).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29340?vs=81688=81766

REVISION DETAIL
  https://phabricator.kde.org/D29340

AFFECTED FILES
  kcm/package/contents/ui/Output.qml

To: davidedmundson, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27011: Update plasma startup sequence README

2020-05-01 Thread David Edmundson
davidedmundson abandoned this revision.
davidedmundson added a comment.


  There have been changes since. I think the new code is better at being self 
documenting, and that's at least up to date. I'll just rm this file

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27011

To: davidedmundson
Cc: nicolasfella, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash

2020-05-01 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In the current code OpacityMask's source is the parent which contains
  itself, which doesn't make sense. Docs explicitly say this.
  
  This leads to a crash in teardown.
  
  A quick reshuffle fixes it.
  
  BUG: 419625

TEST PLAN
  Found reproducible steps (see bug)
  No longer crashes

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29340

AFFECTED FILES
  kcm/package/contents/ui/Output.qml

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Re: repo freeze tomorrow

2020-04-29 Thread David Edmundson
We have something announced that I'm not sure is on the list.

Plasma will gain a new repo called kwayland-server.
This is a split of half the code currently in framework.

Aleix has things prepared, but we haven't done all the steps to making it
part of Plasma.

David


D28878: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

2020-04-29 Thread David Edmundson
davidedmundson added a comment.


  I don't like this "assistant" object that is just an opaque pointer being 
passed around from QML space. It's not very declarative.
  
  Either we should register this item as a singleton with some nice invokable 
methods to show KNS dialogs, which could be a nice useful re-usable class. Then 
we port WidgetExplorer.qml to use that directly
  
  Or just internally make widgetexplorerassistant some static inside 
WidgetExplorer as a completely private class.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28878

To: sunny, #plasma
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28879: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

2020-04-29 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> WidgetExplorer.qml:66
>  Component.onCompleted: {
>  if (!root.widgetExplorer) {
> +if (!root.widgetExplorerAssistant) {

This existing code is horrible.

It's a very bad idea to reference objects outside our scope. It results in 
unportable, unreusable code. In Qt6 this will be an error.

Case in point AppletAlternatives imports this Item but now root is a different 
object and neither this property or widgetExplorerAssistant exist.

I want us to be tidying that up rather than expanding on it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28879

To: sunny, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28878: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

2020-04-29 Thread David Edmundson
davidedmundson added a comment.


  > Iincluding the removal of KNS functionality?
  
  It's there. It's in widgetexplorerassistant
  
  To help rephrase the commit message.
  
  - WidgetExplorer opens dialogs
  - WidgetExplorer has a limited lifespan and can be recreated each time it's 
shown.
  - This patch creates a new object that exists to track dialogs
  - There will be one of these (presumably in a pending plasma-desktop patch)
  - If you create N WidgetExplorers and open the same dialog multiple times 
because it has a common object it can raise the first one.
  
  It's somewhat overengineered, but will work.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28878

To: sunny, #plasma
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28305: Systemd Startup

2020-04-24 Thread David Edmundson
davidedmundson updated this revision to Diff 81093.
davidedmundson added a comment.


  rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28305?vs=80412=81093

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28305

AFFECTED FILES
  CMakeLists.txt
  config-workspace.h.cmake
  gmenu-dbusmenu-proxy/gmenudbusmenuproxy.desktop
  gmenu-dbusmenu-proxy/plasma-gmenudbusproxy.service.in
  krunner/CMakeLists.txt
  krunner/dbus/org.kde.krunner.service.in
  krunner/plasma-krunner.service.in
  ksmserver/CMakeLists.txt
  ksmserver/plasma-ksmserver.service.in
  ksmserver/server.cpp
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  shell/CMakeLists.txt
  shell/org.kde.plasmashell.desktop.cmake
  shell/plasma-plasmashell.service.in
  startkde/CMakeLists.txt
  startkde/kcminit/CMakeLists.txt
  startkde/kcminit/plasma-kcminit-phase1.service.in
  startkde/kcminit/plasma-kcminit.service.in
  startkde/plasma-core@.target
  startkde/plasma-ksplash-ready.service.in
  startkde/plasma-workspace@.target
  startkde/startplasma.cpp
  xembed-sni-proxy/CMakeLists.txt
  xembed-sni-proxy/plasma-xembedsniproxy.service.in
  xembed-sni-proxy/xembedsniproxy.desktop

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


D28333: Add a new daemon for stats monitoring

2020-04-24 Thread David Edmundson
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in ksysguarddaemon.cpp:58
> needs to be always polling every half a second? could it be somewhat 
> adjustable (maybe depending on ac/on battery?)

Indeed, the current code is every 2s. I ramped it up to expose any issues.

I would quite like it to be somewhat container specific. 
i.e disk storage doesn't change much, CPU is more volatile.

I'll change it, and then maybe we can revisit this topic once some more things 
are ported.

> ahiemstra wrote in SensorContainer.cpp:64
> Uh, so shouldn't we fix this?

Seems like a plan :)

> ahiemstra wrote in SensorContainer.h:56
> Maybe move this to private with `friend class SensorObject`? Though I don't 
> really see why this is internal only. Also probably should rename it to 
> `addObject`?

It was just to explicitly enforce the memory management combined with the tree 
management.

I'll go with private, then we can change if we find we need to

> mart wrote in ksgrdiface.cpp:378
> maybe mapping on a config file?

Plan (with some pending code) is to just move these in natively into a more 
readable plugin

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28333

To: davidedmundson, #plasma
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


D28333: Add a new daemon for stats monitoring

2020-04-24 Thread David Edmundson
davidedmundson updated this revision to Diff 81087.
davidedmundson marked 23 inline comments as done.
davidedmundson added a comment.


  all the changes

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28333?vs=78977=81087

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28333

AFFECTED FILES
  CMakeLists.txt
  kstats/CMakeLists.txt
  kstats/autotests/CMakeLists.txt
  kstats/autotests/main.cpp
  kstats/client.cpp
  kstats/client.h
  kstats/ksysguard_iface.xml
  kstats/ksysguarddaemon.cpp
  kstats/ksysguarddaemon.h
  kstats/main.cpp
  kstats/test/CMakeLists.txt
  kstats/test/README.txt
  kstats/test/main.cpp
  libkstats/AggregateSensor.cpp
  libkstats/AggregateSensor.h
  libkstats/CMakeLists.txt
  libkstats/SensorContainer.cpp
  libkstats/SensorContainer.h
  libkstats/SensorObject.cpp
  libkstats/SensorObject.h
  libkstats/SensorPlugin.cpp
  libkstats/SensorPlugin.h
  libkstats/SensorProperty.cpp
  libkstats/SensorProperty.h
  libkstats/types.h
  plugins/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/ksgrd/ksgrd.json
  plugins/global/ksgrd/ksgrdiface.cpp
  plugins/global/ksgrd/ksgrdiface.h
  plugins/global/nvidia/CMakeLists.txt
  plugins/global/nvidia/nvidia.cpp
  plugins/global/nvidia/nvidia.h
  plugins/global/nvidia/nvidiaplugin.json

To: davidedmundson, #plasma
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

2020-04-24 Thread David Edmundson
davidedmundson added a comment.


  See https://github.com/systemd/systemd/pull/15226

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28424

To: hchain, davidedmundson, broulik, dfaure, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

2020-04-23 Thread David Edmundson
davidedmundson added a comment.


  Generally +1

INLINE COMMENTS

> waylandintegration.cpp:452
> +connect(m_registry, ::Client::Registry::screencastingAnnounced, 
> this, [this] (quint32 name, quint32 version) {
> +qDebug() << "screen!";
> +m_screencasting = m_registry->createScreencasting(name, version, 
> this);

leftover

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28884

To: apol
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29028: feat(wayland): add Wrapland plugin

2020-04-22 Thread David Edmundson
davidedmundson added a comment.


  A new dependency also needs to actually solve an actual problem.
  
  If we say we should support wl_roots' protocol for wlroots users. Fair 
enough. There are some parts of Plasma used by 3rd parties. 
  I'd certainly be very happy for us both to switch to a new standard given 
they're upstreaming some stuff currently.
  
  But we then have to answer the technical question of why does that require a 
library with a different implementation of ConnectionThread/Registry and every 
client protocol in order to do so? Compared to using one technology throughout.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: anthonyfieroni, tcanabrava, apol, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart


D29056: [libtaskmanager] add stacking order data for wayland

2020-04-21 Thread David Edmundson
davidedmundson added a comment.


  assuming others are merged of course

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29056

To: bport, broulik, davidedmundson, zzag, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread David Edmundson
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I don't see why we should have that in KDE code.
  
  As per manifesto
  
  > The project stays true to established practices common to similar KDE 
projects
  
  As a compromise we can install the headers of the plugin interface.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-04-20 Thread David Edmundson
davidedmundson added a comment.


  KScreen already is a plugin system.
  
  We don't need to go all inception, and have a plugin load plugins. It doesn't 
look to bring anything other than complexity.
  
  If there is any duplication, we can just add some extra base classes in the 
lib using the split you've done above that the plugin can inherit from.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28859: Detect QQC2 version at build time with actual detection.

2020-04-20 Thread David Edmundson
davidedmundson added a comment.


  So the problem we're solving is that we want to go
  
  Qt5.12 - QQC2.5
  Qt5.13 - QQC2.6
  Qt5.14 - QQC2.7
  Qt5.15 - QQC2.15
  
  correct?
  
  We now know all Qt5 versions, and we know that Qt6 won't have versions.
  
  I don't see why need this complicated thing instead of an "if" statement on 
Qt5QuickControls2_VERSION_MINOR

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28859

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28985: [Kickoff] Disable tabBar's mouseArea when searching

2020-04-19 Thread David Edmundson
davidedmundson resigned from this revision.
davidedmundson added a comment.


  Ah, I see.
  
name: "Search"
  PropertyChanges {
  target: tabBar
  opacity: 0
  }
  
  It's opacity zero, but technically still visible,  still enabled and with the 
same valid size. That sounds super weird :/
  But it means our mousearea is active and now I understand why you're saying 
it shouldn't be. Gotcha (in future longer commit messages can help make 
reviewing a bit faster)
  
  Surely then it'd still be active in the tabfocus chain too? And our property 
change should update enabled on tabbar too?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein, ngraham
Cc: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D28985: [Kickoff] Disable tabBar's mouseArea when searching

2020-04-19 Thread David Edmundson
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I don't understand.
  
  Why is the search page a special case that should affect the tab bar 
behaviour?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein, ngraham, davidedmundson
Cc: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D28941: startplasma: Sort environment scripts prior to sourcing

2020-04-18 Thread David Edmundson
davidedmundson added a comment.


  Concept makes sense.
  
  QStandardPaths is ordered: "The list of directories is sorted from high to 
low priority, starting with writableLocation()"
  
  so we can cut this code in half by doing some sort of
  
void runEnvironmentScripts()
{
 const auto locations = QStandardPaths::
 locations.reverse();
 for (const QString :locations) {
runScriptsInDir(location)
  }
}

void runScriptsInDir(const QString )
{
QDir dir(location);
...
std::sort(
...
}

which will keep addition XDG_CONFIG_DIRS in the right order too

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28941

To: auxym, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28305: WIP: Systemd Startup

2020-04-17 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> hchain wrote in plasma-core@.target:3
> can we make this `plasma-kwin@%i.service` ?

can do, the _ is just to match the binary name

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


  1   2   3   4   5   6   7   8   9   10   >