D27036: KApiDox: add "Plasma Workspaces Libraries" group info

2020-11-17 Thread David Redondo
davidre added a comment.


  Ping?

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D27036

To: davidedmundson, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Re: Monday meeting notes for 9/11/2020

2020-11-09 Thread David Redondo
Am Montag, 9. November 2020, 15:22:51 CET schrieb Nate Graham:
> On 11/9/20 5:18 AM, Marco Martin wrote:
> > Missing form David Redondo:
> > * I made a simple patch so QMenus are polished before creating the
> > platform window
> > * https://codereview.qt-project.org/c/qt/qtbase/+/320154
> > <https://codereview.qt-project.org/c/qt/qtbase/+/320154>
> > *  Which was the cause for ugly menus appearing in some places
> 
> Nice! Does this fix https://bugs.kde.org/show_bug.cgi?id=428095 or
> https://bugsfiles.kde.org/attachment.cgi?id=133043 or both or neither?
> 
> Nate

Would need some investigation,
the instance which led me to the above was right clicking on menu bars.
However I found one place where the application was the cause by explicitly
creating the window right after constructing the menu (submitted a MR for that 
too of course)

David






Re: Plasma and a bachelor thesis

2020-10-23 Thread David Redondo
Hi Ilya,

> That's fair. Even though the format would declare it an engineering thesis
> and shift the focus more to the code, I would still need to show research
> skills, explain the novelty of this work (maybe by using a more general
> topic name) and write plenty of text. Do you think the topic allows for
> that?

I think such a topic fits a thesis quite well. I do not know the requirements 
of your university for a Bachelor's thesis but I think it could also work as a 
Master's thesis depending on the scope with which you are approaching the 
topic. Ample opportunity to write about current/past approaches done by other
software, IPC mechanisms and what you end up doing for whatever reasons.
 
> 
> Best regards,
> 
> Ilya

Best Regards,
David





Plasma Beta Review Day

2020-09-20 Thread David Redondo
Hi, 

during the last kickoff meeting we decided to hold a public Plasma Beta Review 
day on BBB to get more feedback on the beta release.  The date in the wiki is 
Thursday next week (exactly one week after the beta). If we want to go through 
with this idea, we need to decide on a time frame and publicly announce it 
somewhere. 
I think the time frame should not be to small so that everybody can have a 
chance to join and report their experience. Maybe promo (CC'ed) can help with 
announcing the session on the main KDE channels?
I also CC'ed sysadmin for the needed scaling of the BBB instance.

Best Regards,
David




Relicensing a file in Dr. Konqi

2020-09-11 Thread David Redondo
Hello Hans,
 
we are currently converting copyright headers to SPDX expressions to be in 
line with the REUSE specification, see https://phabricator.kde.org/T12528
and https://invent.kde.org/teams/licensing
During this I found this file https://invent.kde.org/plasma/drkonqi/-/blob/
master/src/drkonqi.cpp which seems to be partly licensed as GPL-2+ and partly 
as MIT because it includes code that you originally contributed under this 
license.
Are you okay with relicensing your code from MIT to GPL-2+?

Best Regards,
David




Monday Meeting Notes for 10/08/2020

2020-08-10 Thread David Redondo
Nico:
- Update Flatpak runtime to KF5 5.73 
https://invent.kde.org/packaging/flatpak-kde-runtime/-/merge_requests/17
- Tweak some margins in the dialer: https://invent.kde.org/plasma-mobile/
plasma-dialer/-/merge_requests/20
- Some code cleanup in Kongress
- Fix passive notification padding when using Plasma style: https://
invent.kde.org/frameworks/kirigami/-/merge_requests/72
- Allow refreshing device list in kdeconnect-app: https://invent.kde.org/
network/kdeconnect-kde/-/merge_requests/306
- Cleanup kirigami app template: https://invent.kde.org/frameworks/kirigami/-/
merge_requests/71
- Fix PC3 toolbar https://invent.kde.org/frameworks/plasma-framework/-/
merge_requests/62 https://invent.kde.org/frameworks/plasma-framework/-/
merge_requests/63

Arjen:
- so the biggest thing is that I merged the actiontoolbar rewrite to Kirigami 
last week which had a bit of fallout (as I kinda expected) and a few more 
issues popped up
- the fallout was mostly windows build failing (which is fixed) and the unit 
test failing (which is ongoing)
- the main issue now remaining is that toolbuttons with menus don't display 
correctly when non-flat which turns out to be a problem with breeze since that 
lacks menu arrows for instant-popup toolbuttons
- the plan there is to add that functionality to breeze, then fixup qqc2-
desktop-style and kirigami to make use of it
- there's also a Qt bug I filed because the toolbutton change I did triggers a 
very unexpected binding loop
see https://bugreports.qt.io/browse/QTBUG-85941

David E:
- I merged the wayland klipper side
- It exposes a race at a protocol level - clipbord replacements in wayland 
aren't necessarily atomic
- I have a horribly bodgy workaround, but it seems to work - I have yet to 
fully merge the workaround
- Nvidia did a big update and it's caused a mess :/ 
   systemsettings randomly will stop showing the sidebar even after restarting 
systemsettings
   so there must be something about creating multiple contexts in one app? Not 
sure of the details, fortunately I can now reproduce that 
   But this potentially could end up quite a major problem if we don't 
diagnose what's wrong and get a fix soo

Kai Uwe:
plasma-browser-integration:
* Released version 1.7.6 \o/
* https://blog.broulik.de/2020/08/plasma-browser-integration-1-7-6/
* Patch to calculate transfer speed manually if download size isn't known, 
please review: https://invent.kde.org/plasma/plasma-browser-integration/-/
merge_requests/8
* Split "page" context menus from links
* There's a regression in the release on Firefox where right clicking on an 
empty are in the page doesn't offer KDE Connect sharing anymore, please 
review: https://invent.kde.org/plasma/plasma-browser-integration/-/
merge_requests/9
  * Might warrant doing a 1.7.6.1 for Firefox
* Also added the share entry to the tab bar, so you can right click a tab to 
send it
PowerDevil:
* Introduce dedicated "turn off keyboard backlight" action, please review: 
https://invent.kde.org/plasma/powerdevil/-/merge_requests/17
  * Especially some hints on how to make a proper kconf update script would be 
appreciated 
[hint were given by d_ed, see https://phabricator.kde.org/P628]
* Remove shortcut migration code, please review: https://invent.kde.org/
plasma/powerdevil/-/merge_requests/16
* Fixed keyboard backlight not turning back on when closing the lid to suspend 
and then waking back up
KWin:
* Apply maximize animation also to full screen changes: https://
invent.kde.org/plasma/kwin/-/merge_requests/171
* d_ed had the idea of installing the effect twice and then using plugin ID to 
distinguish the two, so we have a dedicated "full screen" effect
* Will need to look into that, might need to expose the plugin ID through 
KWin effects API first
Solid:
* Anything else left for imobile backend? https://invent.kde.org/frameworks/
solid/-/merge_requests/9

Aleix:
- I've been mostly working on the input method v1 support for wayland which is 
mostly ready right now, it has some annoyances with maliit that I'm looking to 
polish so not to break plasma mobile
- I think I've hit some kind of bug deep in Qt so there's that...
- but it only happens when explicitly closing the keyboard other than that it 
works well
- all screencasting stuff should be merged, I hope you all are testing it 
already :D
- [d_ed]: there's been some Qt upstream reviews for keyboard input stuff 
lately, I don't know if it's relevant
-my problem is related to issuing the set_input_mask call
- it's in wl_surface
- null requests are never issued for some reason; issued or received, one of 
those

Marco:
# Plasma
* made breeze decoration use global animation duration
* made a branch for the top headerbar area in breeze qstyle different approach 
to one by Jan, but that has problems as well... i guess hacky thing is hacky 
(giving up in trying to have fluid animations: i guess the only way to make it 
work is the (hacky) thing some style do of having all windows argb and 

Re: Plasma related BoFs at Akademy 2020

2020-08-04 Thread David Redondo
Hi Aleix,

Am Montag, 3. August 2020, 16:40:21 CEST schrieb Aleix Pol:
> We do have several Plasma BoF. I see at least Plasma Discover and
> Plasma Mobile. ;)
Seems like I should have used ctrl+f instead of scrolling over the page and 
looking manually. ;)
> Hardware collaborations should also be related to Plasma IMHO.
> 
> Maybe it would make sense to have one about "Getting started to
> collaborate with Plasma"?
I think that would be a great topic. Do you imagine it as a session that would 
be useful for people who want to start collaborating? 

Regards,
David







Plasma related BoFs at Akademy 2020

2020-08-03 Thread David Redondo
Hi,

currently I see no Plasma related BoFs at https://community.kde.org/Akademy/
2020/AllBoF . Do you think we should have some specific BoFs and/or a general 
Plasma one? Or maybe you already have a subject that you feel warrants a BoF? 
Then feel free to tell us and add it to the wiki.

Regards,
David




Re: Breakage in Breeze Icons

2020-07-21 Thread David Redondo
I fixed the build now. There was a symlink to a removed file which
cmake -E copy_directory didn't like.

Regards,
David




Re: dipping a toe in waywater? :)

2020-07-03 Thread David Redondo
Hello René,

maybe this blog post from Aleix can help you. It explains how to started a 
nested session or wayland session.
https://www.proli.net/2020/04/03/developing-kwin-wayland/ 

Regard, David






D29154: Use QWindow overload of QIcon::pixmap

2020-06-13 Thread David Redondo
davidre added a comment.


  In my testing dragging a window to a screen with a different scalefactor has 
no issue and @apol said for him it's better than the status quo. So I  would 
like to land this

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-06-08 Thread David Redondo
davidre added a comment.


  Ping

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29462

To: Zren, #kirigami, mart
Cc: davidre, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart


D29140: Show POTD in lock screen

2020-05-16 Thread David Redondo
davidre added inline comments.

INLINE COMMENTS

> kded_potd.cpp:25
> +delete engine;
> +delete watcher;
> +}

Don't need to delete watcher because you constructed it with `this` as parent. 
https://doc.qt.io/qt-5/objecttrees.html
For the engine don't delete it because you don't have the ownership pof the 
object. The function just returned a pointer to it.

> When the DataEngineConsumer class is deleted, all engines accessed using it 
> are de-referenced and possibly deleted (in the case that there are no other 
> users of the engine in question).

https://api.kde.org/frameworks/plasma-framework/html/classPlasma_1_1DataEngineConsumer.html

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29140: Show POTD in lock screen

2020-05-16 Thread David Redondo
davidre added a comment.


  Flickr works here F8325269: Screenshot_20200516_095930.png 

  
  > For the leaks, I really have no idea. (also asked some friends but no help) 
C++ isn't my primary programming language. If you can share some 
document/tutorials/examples...
  
  In C++ there is automatic and dynamic storage duration (and some others but 
you don't need to care about them for now). Automatic is the normal when you 
write
  
 void f() {
int i = 0;
[complicated code]
}
  
  i is automatically allocated at the start of the function and deallocated at 
the end of the function. Objects with automatic storage duration are 
deallocated at the end of the scope they were declared in. You can't use a 
variable that you declare in a for loop or inside an if block outside of them 
because the scope they were declared in (the foor loop or the if block) has 
ended. You can also manually create a scope by wrapping code with braces.
  
  Dynamic storage duration happens when you manually allocate memory by writing 
`new Object` or more C-like by calling `malloc` or `calloc`. Here the memory is 
not automatically freed again. It's on the programmer to deallocate it when 
it's no longer needed. You need to call `delete` (or `free` if you used 
`malloc`) to free the memory again.
  
  Here it's not a huge problem because I guess the module will be only 
instantiated once but it's something one should always keep an eye on it. 
Imagine if the class was instantiated multilple times. After some (or longer) 
time your memory would be full because each object allocates a 
`Plasma::DataEngineConsumer` but never frees the corresponding memory even if 
the object itself is destroyed. That's what's called a leak.  You have to call 
`delete consumer` in the destructor of `PotdModule`.
  
  There are some tools that help with memory managment `std::unique_ptr` and 
`QScopePointer` wrap a pointer created with new and will delete it if they are 
destroyed themelves, so you don't forget the delete. `std::shared_ptr` and 
`QSharedPointer` count how many places hold a refrence to it, if noone holds a 
reference anymore the memory is freed. Finally in Qt there is the 
`QObject(QObject *parent)` pattern.  A QObject will delete it this children. So 
if you write `new QWidget(this)` you don't need to care about freeing the 
memory occupied of  the new widget.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29140: Show POTD in lock screen

2020-05-14 Thread David Redondo
davidre added a comment.


  I don't get how saving as a png fails if we have the image as QImage.

INLINE COMMENTS

> kded_potd.cpp:9
> +{
> +consumer = new Plasma::DataEngineConsumer();
> +engine = consumer->dataEngine(QStringLiteral("potd"));

still leaks

> kded_potd.cpp:28
> + */
> +void PotdModule::dataUpdated(const QString& sourceName, const 
> Plasma::DataEngine::Data& data)
> +{

This method can be removed it's not referenced anywhere.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29140: Show POTD in lock screen

2020-05-14 Thread David Redondo
davidre added a comment.


  I fail to see what the kded module actually does. Or is it the case that 
simply requesting the data from the engine causes it to cache the image on 
disk? Maybe that should be documented.

INLINE COMMENTS

> CMakeLists.txt:44
>  CoreAddons
> +DBusAddons
>  Declarative

Seems unused?

> CMakeLists.txt:68
>  )
> -
>  add_definitions(

unrelated

> PoTD-list.txt:8
>  where YY is the 2 digits year, MM is the 2 digits month and DD is the 2 
> digits day.
> +Note: sometimes, the webpage shows a YouTube video and picture cannot be 
> fetched.
>  

Unrelated

> cachedprovider.cpp:54
>  const QString path = CachedProvider::identifierToPath( m_identifier );
> -m_image.save(path, "PNG");
> +m_image.save(path, "JPEG");
>  emit done( m_identifier, path, m_image );

Can't we save the image in its original format?

> kded_potd.cpp:3
> +
> +#include 
> +

QDebug

> kded_potd.cpp:10
> +
> +#define COMPONENT_NAME "potd"
> +

unused

> kded_potd.cpp:12
> +
> +K_PLUGIN_FACTORY_WITH_JSON(PotdModuleFactory,
> +   "kded_potd.json",

You can use K_PLUGIN_CLASS_WITH_JSON

> kded_potd.cpp:18
> +{
> +Plasma::DataEngineConsumer *consumer = new Plasma::DataEngineConsumer();
> +engine = consumer->dataEngine(QStringLiteral("potd"));

this leaks

> kded_potd.cpp:34
> +
> +void PotdModule::dataUpdated(const QString& sourceName, const 
> Plasma::DataEngine::Data& data)
> +{

Why don't we care if the data was updated?

> kded_potd.cpp:46
> +engine->connectSource(previousSource, this);
> +watcher->addPath(configPath); // when recreated, it needs to be added to 
> watcher again
> +}

Why?

> kded_potd.cpp:49
> +
> +QString PotdModule::getSource()
> +{

Maybe getProvider or getProviderName no to confuse it with the dataSource?

> kded_potd.cpp:51
> +{
> +KConfig config(configPath);
> +KConfigGroup group = config.group(QStringLiteral("Greeter"))

Couldn't we get the config directly with "kscreenlockerrc" if we use cascading 
either way? No need to seach for the actual path

> kded_potd.h:21
> +
> +public Q_SLOTS:
> +

remove

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29703: Disable horizontal scrollbar in systemtray settings

2020-05-13 Thread David Redondo
davidre updated this revision to Diff 82728.
davidre added a comment.


  do it for all

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29703?vs=82721=82728

BRANCH
  scroll (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D29703

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configTimeZones.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  wallpapers/image/imagepackage/contents/ui/config.qml

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29704: [kcms/baloo] Disable horizonal scrollbar

2020-05-13 Thread David Redondo
davidre updated this revision to Diff 82727.
davidre added a comment.


  Do it for every scrollview

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29704?vs=82722=82727

BRANCH
  scroll (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D29704

AFFECTED FILES
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/qml/privacyTab/BlacklistApplicationView.qml
  kcms/baloo/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29704: [kcms/baloo] Disable horizonal scrollbar

2020-05-13 Thread David Redondo
davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  We need to hardcode it now because of QTBUG-83890.
  CCBUG: 419514

REPOSITORY
  R119 Plasma Desktop

BRANCH
  scroll (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D29704

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29703: Disable horizontal scrollbar in systemtray settings

2020-05-13 Thread David Redondo
davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  We need to hardcode it now because of QTBUG-83890.
  
  CCBUG: 419514

REPOSITORY
  R120 Plasma Workspace

BRANCH
  scroll (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D29703

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29701: Disable horizontal scrollbar in kcm

2020-05-13 Thread David Redondo
davidre added a comment.


  Should this go to master, too? Or should we hope that we need the workaround 
only for 5.18 and 5.19 and the qtbug will be fixed eventually?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29701

To: davidre, broulik, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29701: Disable horizontal scrollbar in kcm

2020-05-13 Thread David Redondo
davidre updated this revision to Diff 82719.
davidre added a comment.


  .

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29701?vs=82718=82719

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29701

AFFECTED FILES
  kcm/qml/main.qml

To: davidre, broulik, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29701: Disable horizontal scrollbar in kcm

2020-05-13 Thread David Redondo
davidre created this revision.
davidre added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
davidre requested review of this revision.

REVISION SUMMARY
  We need to hardcode it now because of QTBUG-83890.
  CCBUG: 419514

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29701

AFFECTED FILES
  kcm/qml/main.qml

To: davidre, broulik, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29632: [kcms/keys] Use better collator settings

2020-05-12 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:847d9216e0c1: [kcms/keys] Use better collator settings 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29632?vs=82625=82626

REVISION DETAIL
  https://phabricator.kde.org/D29632

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D29632: [kcms/keys] Use better collator settings

2020-05-12 Thread David Redondo
davidre updated this revision to Diff 82625.
davidre added a comment.


  numeric

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29632?vs=82529=82625

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D29644: Select application after it is added

2020-05-12 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bc5c1d882ed8: Select application after it is added 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29644?vs=82621=82624

REVISION DETAIL
  https://phabricator.kde.org/D29644

AFFECTED FILES
  kcms/keys/package/contents/ui/main.qml

To: davidre, broulik, ngraham, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29579: [kcms/keys] Really ignore unknown action

2020-05-12 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:12a14a789da4: [kcms/keys] Really ignore unknown action 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29579?vs=82407=82623

REVISION DETAIL
  https://phabricator.kde.org/D29579

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ngraham, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29635: [kcms/keys] Make saving sync

2020-05-12 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fcb04768142f: [kcms/keys] Make saving sync (authored by 
davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29635?vs=82535=82622

REVISION DETAIL
  https://phabricator.kde.org/D29635

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, broulik, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29644: Select application after it is added

2020-05-12 Thread David Redondo
davidre updated this revision to Diff 82621.
davidre added a comment.


  Use PropertyAction

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29644?vs=82545=82621

BRANCH
  addIndex (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29644

AFFECTED FILES
  kcms/keys/package/contents/ui/main.qml

To: davidre, broulik, ngraham, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29644: Select application after it is added

2020-05-11 Thread David Redondo
davidre created this revision.
davidre added reviewers: broulik, ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  After adding an application, an user will probably want to edit shortcuts for 
  the new application. Having to select it again is cumbersome.

TEST PLAN
  Add an application.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  addIndex (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29644

AFFECTED FILES
  kcms/keys/package/contents/ui/main.qml

To: davidre, broulik, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29632: [kcms/keys] Use better collator settings

2020-05-11 Thread David Redondo
davidre added inline comments.

INLINE COMMENTS

> shortcutsmodel.cpp:89
>  QCollator collator;
> +collator.setCaseSensitivity(Qt::CaseInsensitive);
>  std::sort(m_components.begin(), m_components.end(), 
> [&](const Component , const Component ){

We typically don't have apps with numbers but I can also add it?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D29635: [kcms/keys] Make saving sync

2020-05-11 Thread David Redondo
davidre created this revision.
davidre added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  If it's async it will not save when changing modules, or quitting kcmshell, 
see T13140 .
  BUG: 421333

TEST PLAN
  Make a change, change module in systemsettings. Changes are saved.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  syncSave (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29635

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29632: Use better collator settings

2020-05-11 Thread David Redondo
davidre created this revision.
davidre added reviewers: ognarb, broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ognarb, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29619: Improve StatusNotifierTest

2020-05-11 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5459a533974e: Improve StatusNotifierTest (authored by 
davidre).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29619?vs=82491=82521

REVISION DETAIL
  https://phabricator.kde.org/D29619

AFFECTED FILES
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui

To: davidre, kmaterka, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28208: Move sni icon handling logic from data engine to applet

2020-05-11 Thread David Redondo
davidre updated this revision to Diff 82519.
davidre added a comment.


  - fix

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=82492=82519

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg, #frameworks
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29625: Add global shortcut

2020-05-11 Thread David Redondo
davidre added a comment.


  In D29625#668203 , @davidre wrote:
  
  > -1 for khotkeys.
  
  
  Add `X-KDE-Shortcuts`  to the desktop file instead and instal it to 
share/kglobalaccel

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29625: Add global shortcut

2020-05-11 Thread David Redondo
davidre added a comment.


  -1 for khotkeys.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28208: Move sni icon handling logic from data engine to applet

2020-05-11 Thread David Redondo
davidre updated this revision to Diff 82492.
davidre added a comment.


  - Rebase without test

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=78982=82492

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg, #frameworks
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29619: Improve StatusNotifierTest

2020-05-11 Thread David Redondo
davidre added a comment.


  F8308915: Screenshot_20200511_093148.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29619

To: davidre, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29619: Improve StatusNotifierTest

2020-05-11 Thread David Redondo
davidre created this revision.
davidre added a reviewer: kmaterka.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Allows to set Icon, AttentionIcon and OverlayIcon either by name or pixmap.
  Makes it easier to test combinations of those.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  snitest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29619

AFFECTED FILES
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui

To: davidre, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29580: [kcms/keys] Also consider portable text when filtering

2020-05-10 Thread David Redondo
davidre created this revision.
davidre added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Enables searching for "ctrl" or "shift" in non english locale

REPOSITORY
  R119 Plasma Desktop

BRANCH
  portabletext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29580

AFFECTED FILES
  kcms/keys/filteredmodel.cpp

To: davidre, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29579: [kcms/keys] Really ignore unknown action

2020-05-10 Thread David Redondo
davidre created this revision.
davidre added reviewers: ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Otherwise the end() iterator is dereferenced resulting in a crash
  BUG: 421016

TEST PLAN
  Import a predefined scheme

REPOSITORY
  R119 Plasma Desktop

BRANCH
  crash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29579

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-30 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1ee6660ceb62: Rewrite of the global shortcuts kcm 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81441=81607

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25144: [RFC][Global Shortcuts KCM] Categorize into Applications and System Services

2020-04-29 Thread David Redondo
davidre abandoned this revision.
davidre added a comment.


  Superseeded by total rewrite of the kcm

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma, mlaurent, ngraham
Cc: mlaurent, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-29 Thread David Redondo
davidre added a comment.


  In D28744#659447 , @ngraham wrote:
  
  > I find that I'm not able to set shortcuts involving the space key. The key 
sequence get repeated twice in the button and the Apply button ever becomes 
enabled. Can you reproduce?
  
  
  That's the current behavior of KeySequenceItem and KKeySequenceWidget. You 
should be able to observe it everywhere such an item is used

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-28 Thread David Redondo
davidre updated this revision to Diff 81441.
davidre added a comment.


  - Reinstate the pointingHand mouseAreas
  - Make delegate automatically expand if it's the only one

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81435=81441

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-28 Thread David Redondo
davidre updated this revision to Diff 81435.
davidre added a comment.


  - Make the delegate use states

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81305=81435

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29154: Use QWindow overload of QIcon::pixmap

2020-04-28 Thread David Redondo
davidre added a comment.


  I did some digging and think that things should be repainted when they change 
screen
  
https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#_ZN13QWidgetWindow18handleScreenChangeEv

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-27 Thread David Redondo
davidre updated this revision to Diff 81305.
davidre added a comment.


  rebasae

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81304=81305

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-27 Thread David Redondo
davidre updated this revision to Diff 81304.
davidre added a comment.


  - Use model.* properties
  - Use placeholder message
  - Still don't know why model properties are undefined when switching 
components

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81016=81304

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29140: Fix POTD in lock screen (partly)

2020-04-25 Thread David Redondo
davidre added a comment.


  In D29140#656817 , @guoyunhe wrote:
  
  > To totally solve the issue, there are several solutions I can find:
  >
  > 1. POTD need to have a daemon process that can always access network. The 
lock screen send request to the daemon through DBus or other protocol.
  > 2. Create an invisible lock screen widget in the desktop, so it fetches and 
updates the POTD even before screen locks.
  >
  >   The second option is much easier to do. Both will cause some performance 
impact.
  
  
  
  
  2. doesn't sound something like we want do

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29154: Use QWindow overload of QIcon::pixmap

2020-04-25 Thread David Redondo
davidre added a comment.


  Actually everything in the sidebad is very blurry at 2x

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29154: Use QWindow overload of QIcon::pixmap

2020-04-25 Thread David Redondo
davidre added a comment.


  In D29154#656690 , @apol wrote:
  
  > This is what it looks like for me with the patch applied.
  >
  > scale 1x: F8258193: Screenshot_20200424_203628.png 

  >  scale 2x: F8258201: Screenshot_20200424_203729.png 

  >
  > master:
  >  scale 1x: F8258205: Screenshot_20200424_203923.png 

  >  scale 2x:F8258207: Screenshot_20200424_203959.png 

  >
  > I can see a noticeable wonky-ness on 1x master, so I'd say this patch helps.
  
  
  Is master scale 1x the correct image? Also  notice the network icon looks bad 
at 2x in both images

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29157: force systemsettings for kcms

2020-04-24 Thread David Redondo
davidre added a comment.


  Maybe todo remove?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29157

To: mart, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29154: Use QWindow overload of QIcon::pixmap

2020-04-24 Thread David Redondo
davidre added a comment.


  In D29154#656585 , @apol wrote:
  
  > +1
  >
  > I did the same thing for kirigami @ D29100 
 and plasma-framework @ D29102 
 yesterday after looking at Qt's code and 
assessing it was the right thing to do.
  >  I am not familiar with Breeze's code but the patch is sound.
  >
  > I do have all of the dpis so if you tell me how I'll test it.
  >
  > This should probably fix the BUG 418869.
  
  
  I guess how you tested your patches? Looking at icons on all the dpis?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29154: Use QWindow overload of QIcon::pixmap

2020-04-24 Thread David Redondo
davidre updated this revision to Diff 81107.
davidre added a comment.


  Correct code style when I'm touching these lines either way

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29154?vs=81106=81107

BRANCH
  window

REVISION DETAIL
  https://phabricator.kde.org/D29154

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29154: Use QWindow overload of icon.pixmap

2020-04-24 Thread David Redondo
davidre created this revision.
davidre added reviewers: apol, broulik, ndavis, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Previously only the combobox used this overload but that dropped in
  0eaf762705d84fab5c70a8934ffa7cfeadeeebde 
 
because of the changes in
  582f5ebad1686d47168a3246e2aff5beefb59121 
. 
However we should prefer that
  overload because it takes the screen into account on which the icon is 
rendered.
  This reinstates the code removed in 0eaf762 
 as a 
helper function to retrieve the
  window from a window or styleObject.

TEST PLAN
  Icons look correct
  (I don't have a high dpi screen myself but this should be straightforward)

REPOSITORY
  R31 Breeze

BRANCH
  window

REVISION DETAIL
  https://phabricator.kde.org/D29154

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: davidre, apol, broulik, ndavis, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28908: Use the same icon mode calculation for comboboxes as for buttons

2020-04-24 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:5a62232415bc: Use the same icon mode calculation for 
comboboxes as for buttons (authored by davidre).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28908?vs=80359=81105

REVISION DETAIL
  https://phabricator.kde.org/D28908

AFFECTED FILES
  kstyle/breezestyle.cpp

To: davidre, broulik, #breeze, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29012: Fix variable mixup

2020-04-24 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:49cff2127371: Fix variable mixup (authored by davidre).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29012?vs=80657=81104

REVISION DETAIL
  https://phabricator.kde.org/D29012

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre, #breeze, #plasma, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-23 Thread David Redondo
davidre updated this revision to Diff 81016.
davidre added a comment.


  - Don't drop installing scheme files

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80767=81016

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29058: Set a component display name for the action collection of ksmserver

2020-04-23 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9056449edc89: Set a component display name for the action 
collection of ksmserver (authored by davidre).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29058?vs=80778=81013

REVISION DETAIL
  https://phabricator.kde.org/D29058

AFFECTED FILES
  ksmserver/server.cpp

To: davidre, ngraham, #plasma, #vdg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29052: Set component display name for touchboard and keyboard kcm action collections

2020-04-23 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e64a3cb2af23: Set component display name for touchboard 
and keyboard kcm action collections (authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29052?vs=80770=81012

REVISION DETAIL
  https://phabricator.kde.org/D29052

AFFECTED FILES
  kcms/keyboard/bindings.cpp
  kcms/touchpad/kded/kdedactions.cpp

To: davidre, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29058: Set a component display name for the action collection of ksmserver

2020-04-21 Thread David Redondo
davidre created this revision.
davidre added reviewers: ngraham, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  "ksmserver" is not a good user visible string.

TEST PLAN
  check in global shortcuts kcm

REPOSITORY
  R120 Plasma Workspace

BRANCH
  serverdisplayname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29058

AFFECTED FILES
  ksmserver/server.cpp

To: davidre, ngraham, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29052: Set component display name for touchboard and keyboard kcm action collections

2020-04-21 Thread David Redondo
davidre created this revision.
davidre added reviewers: ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Otherwise they get assigned a generic "KDE Daemon" name because of kded

TEST PLAN
  restart kded, check in qdbusviewer or global shortcut kcm

REPOSITORY
  R119 Plasma Desktop

BRANCH
  displayNames (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29052

AFFECTED FILES
  kcms/keyboard/bindings.cpp
  kcms/touchpad/kded/kdedactions.cpp

To: davidre, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-21 Thread David Redondo
davidre updated this revision to Diff 80767.
davidre added a comment.


  - Fix defaults
  - Add pending deletion thing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80675=80767

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-21 Thread David Redondo
davidre added a comment.


  In D28744#652925 , @ngraham wrote:
  
  > Here's how it looks with the old KCM: F8249724: 
Screenshot_20200420_125405.png 
  >
  > So my KDE Daemon category has one entry in French for some odd reason. And 
the two KRunner entries are indeed still there and different, not merged.
  >
  > And the Power Management entry is full of duplicates internally and it's 
very confusing: F8249731: Screenshot_20200420_130010.png 

  >
  > So yeah, it's not great in the existing KCM. In the new one it's nice that 
you can delete these duplicates, but I don't actually know what will happen 
when I do so, and the inability to get them back if I make a mistake makes me 
not want to try.
  
  
  In the old one you can delete them too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre added a comment.


  In D28744#652854 , @ngraham wrote:
  
  > Yay. Almost there! I just see a few more things:
  >
  > 1. If I delete a whole item from the left-most list, there's no obvious way 
to get it back (what if I delete a system entry by accident?)
  
  
  I agree. Probably should do it like other kcms with pending deletion then.
  
  > 2. The Defaults button is present, but always disabled
  
  Hmm it works for me when changing shortcuts or changing defaults but the 
initial state is wrong probably because loading is now async. Will look into it.
  
  > 3. I see duplicate entries with different items inside them:
  
  These are not really duplicated but boil down to that the backend is 
represented correctly here. Some components have a different unique identifier  
and happen to have the same user visible name. The old kcm merged them but I 
don't as I think most of these should be seperate because they  are related to 
different things.
  
  - The kded ones are not really duplicate but rather seperate. I think most of 
them are part of plasma(?) so I will see if I can change them to something more 
sensible (for example "Touchpad" or "Keyboard").
  - The powerdevil duplication  shouldn't even exist, @davidedmundson messed up 
while migrating the shortcuts but also fixed that. See D10668 
.
  - The run command one I have not seen but they also have different user 
visible names? How does the old kcm handle that?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80675.
davidre added a comment.


  - Implement Kai's idea for importing
  - Fix importing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80673=80675

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80673.
davidre added a comment.


  - Fix scrollview and use level 3 heading
  - use better string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80672=80673

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre marked an inline comment as done.
davidre added a comment.


  In D28744#652703 , @ngraham wrote:
  
  > Clicking the Apply button makes System Settings crash for me:
  
  
  Fixed now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80672.
davidre added a comment.


  - Fix errors and leave error message disabled

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80631=80672

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D29012: Fix variable mixup

2020-04-20 Thread David Redondo
davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Caused icons to be not longer recolored when changing the color scheme until 
an
  application is started again

TEST PLAN
  Change color scheme while having an application open, icons should change 
color correctly

REPOSITORY
  R31 Breeze

BRANCH
  typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29012

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80631.
davidre added a comment.


  Use Nate's string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80629=80631

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80629.
davidre added a comment.


  - Fix index reset when clicking reset button and use own property for 
shortcuts listview
  
  currentIndex was reset to 0 when resetting, now warnings are generated when 
switching components need to figure out why

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80622=80629

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80622.
davidre added a comment.


  - Add tooltip to remove toolbutton

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80620=80622

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80620.
davidre added a comment.


  Make it build again

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80553=80620

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27669: [kstyle] Tools area

2020-04-20 Thread David Redondo
davidre added inline comments.

INLINE COMMENTS

> breezestyle.cpp:907
> +auto rect = _helper->toolsAreaToolbarsRect(widget);
> +qDebug() << rect;
> +

Stray qdebug

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-19 Thread David Redondo
davidre updated this revision to Diff 80553.
davidre added a comment.


  - Make loading async
  - Make everything async

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80405=80553

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28908: Use the same icon mode calculation for comboboxes as for buttons

2020-04-18 Thread David Redondo
davidre added a comment.


  In D28908#651078 , @ndavis wrote:
  
  > Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's 
process filtering and tools comboboxes are right next to each other and have 
different behavior.
  >
  > This patch causes another problem with all monochrome icons on the Breeze 
colorscheme though:
  >  F8245273: Screenshot_20200418_104206.png 

  
  
  Isn't one of them a toolbuttons with menu, not a combobox? 
  I don't think this patches causes that issue. Do you have
  https://phabricator.kde.org/R31:66d0b0b4e3e1adc389dbd4ce1976d81860d1880d ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28908

To: davidre, broulik, #breeze
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-17 Thread David Redondo
davidre updated this revision to Diff 80405.
davidre added a comment.


  - Use less DBus calls for loading

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80398=80405

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-17 Thread David Redondo
davidre added inline comments.

INLINE COMMENTS

> broulik wrote in shortcutsmodel.cpp:38
> Hmm...
> how about
> 
>   QStringList actionId;
>   actionId.reserve(4);

This actually crashes now

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-17 Thread David Redondo
davidre updated this revision to Diff 80398.
davidre added a comment.


  - Fix defaults

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80387=80398

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-17 Thread David Redondo
davidre updated this revision to Diff 80387.
davidre added a comment.


  - Remove components as good as the current kcm

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80224=80387

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28908: Use the same icon mode calculation for comboboxes as for buttons

2020-04-17 Thread David Redondo
davidre added a comment.


  I don't understand. The palette doesn't change when a widget is selected, 
does it?  The selected state is used by KIconLoader to decide which color to 
use for text color, or highlight
  
state == KIconLoader::SelectedState ? pal.highlightedText().color().name() 
: pal.windowText().color().name(),

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28908

To: davidre, broulik, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28908: Use the same icon mode calculation for comboboxes as for buttons

2020-04-17 Thread David Redondo
davidre created this revision.
davidre added reviewers: broulik, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  When hovering a focused combobox the icon was in Selected  state resulting in 
a wrong color.

TEST PLAN
  Hover over a focused combobox that has an icon

REPOSITORY
  R31 Breeze

BRANCH
  combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28908

AFFECTED FILES
  kstyle/breezestyle.cpp

To: davidre, broulik, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28830: Don't set a custom palette if we have the same palette as the currently active one

2020-04-17 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:66d0b0b4e3e1: Dont set a custom palette if we have 
the same palette as the currently active… (authored by davidre).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28830?vs=80127=80356#toc

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28830?vs=80127=80356

REVISION DETAIL
  https://phabricator.kde.org/D28830

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-15 Thread David Redondo
davidre updated this revision to Diff 80224.
davidre added a comment.


  - Add section checkbox

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80216=80224

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-15 Thread David Redondo
davidre updated this revision to Diff 80216.
davidre marked an inline comment as done.
davidre added a comment.


  - Use pointing hand cursor
  - Rename error signals to errorOccured

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80198=80216

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-15 Thread David Redondo
davidre updated this revision to Diff 80198.
davidre added a comment.


  - Update the delegate

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80137=80198

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

2020-04-15 Thread David Redondo
davidre added subscribers: dfaure, davidre.
davidre added a comment.


  This causes expired notifications to not vanish any more. This is supposed to 
work in the following way `ExpiredRole` is assigned `true` and  
`NotficiationFilterProxyModel` filters expired notifications out. I verified 
that upon timeout of the timer the data is updated correctly but the filter 
model behaves in a strange way. Even though filterAcceptsRow returns false  the 
model still includes the index. I added the following debug output to the 
class:  https://phabricator.kde.org/P584
  Which results in this debug output
  
QModelIndex(0,0,0x0,QConcatenateTablesProxyModel(0x557a51b00d90)) is expired
QModelIndex(-1,-1,0x0,QObject(0x0)) not expired
rowCount NotificationManager::NotificationFilterProxyModel(0x557a51f6ab00) 
QModelIndex(-1,-1,0x0,QObject(0x0)) 1
QModelIndex(0,0,0x0,QConcatenateTablesProxyModel(0x557a51b00d90)) is expired
filter returns for filterAcceptsRow(index(0, mapToSource(parent)) false
rowCount NotificationManager::NotificationFilterProxyModel(0x557a51f6ab00) 
QModelIndex(-1,-1,0x0,QObject(0x0)) 1
QModelIndex(0,0,0x0,QConcatenateTablesProxyModel(0x557a51b00d90)) is expired
filter returns for filterAcceptsRow(index(0, mapToSource(parent)) false
  
  So it still has one row even though the first row should get filtered.
  
  Adding @dfaure because he wrote both  K/QConcatenate... models

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28649

To: broulik, #plasma
Cc: davidre, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre updated this revision to Diff 80137.
davidre marked 3 inline comments as done.
davidre added a comment.


  - Use QCollator and one more coding style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80136=80137

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre updated this revision to Diff 80136.
davidre marked an inline comment as done.
davidre added a comment.


  - Set transient window for application dialog

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80135=80136

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre updated this revision to Diff 80135.
davidre added a comment.


  - redo exportActive and exportWarning bindings

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80088=80135

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28830: Don't set a custom palette if we have the same palette as the currently active one

2020-04-14 Thread David Redondo
davidre created this revision.
davidre added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Caused some icons not be colored correctly

TEST PLAN
  Close KWrite with unsaved changes, all icons should be colored correctly

REPOSITORY
  R31 Breeze

BRANCH
  ffs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28830

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre marked 5 inline comments as done.
davidre added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:94
> Is `contentItem` the default property?

Yes

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre updated this revision to Diff 80088.
davidre added a comment.


  - Search when entering text and correctly color delegates
  - use fallback if action doesn't have a friendly name
  - Remove friend declaration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80074=80088

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre marked an inline comment as done.
davidre added inline comments.

INLINE COMMENTS

> shortcutsmodel.h:59
> +friend FilteredShortcutsModel;
> +enum Roles {
> +SectionRole = Qt::UserRole,

It does in filterAcceptRows to not have to go through data each time

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre added inline comments.

INLINE COMMENTS

> shortcutsmodel.h:59
> +friend FilteredShortcutsModel;
> +enum Roles {
> +SectionRole = Qt::UserRole,

Nevermind it goes through data, apparently I forgot that I changed that :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre added inline comments.

INLINE COMMENTS

> filteredmodel.cpp:41
> +bool displayMatches = 
> index.data(Qt::DisplayRole).toString().contains(m_filter, 
> Qt::CaseInsensitive);
> +if (!source_parent.isValid() || displayMatches) {
> +return displayMatches;

If it's a toplevel item we can just return if the name matches. Recursive 
filtering will take care of the rest

> filteredmodel.cpp:45
> +
> +if (index.parent().data(Qt::DisplayRole).toString().contains(m_filter, 
> Qt::CaseInsensitive)) {
> +return true;

No if the parent matches but the child not, the child is filtered. Recursive 
filtering makes the parent show if it doesn't match but the child does

> ShortcutActionDelegate.qml:58
> +if (model.activeShortcuts.length != 0) {
> +return model.display + ": " + 
> model.activeShortcuts.map(s => kcm.keySequenceToString(s)).join(", ")
> +} else {

Shouldn't QKeySequence::NativeText take care of that or because of the list 
format?

> main.qml:53
> +enabled: exportWarning.visible
> +function onNeedsSaveChanged () {
> +exportWarning.visible = kcm.needsSave

The way I used it caused a binding loop

  Binding on visible {
  when: exportWarning.visible
  value: kcm.needsSave
  restoreMode: Binding.RestoreValue
  }

> main.qml:141
> +icon.name: "list-add"
> +text: i18n("Add application...")
> +onClicked: {

I know...
I will look into what's the most reliable way of deleting things...

> metadata.desktop:4
> +
> +Comment=Global Keyboard Shortcuts
> +

It's the same as in the main desktop file. What will be the user visible one?

> shortcutsmodel.cpp:298
> +{
> +   if (!checkIndex(index) || !index.parent().isValid())  {
> +return;

I think that's wrong way round here

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre updated this revision to Diff 80074.
davidre marked 33 inline comments as done.
davidre added a comment.


  Minor things and codestyle

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=79940=80074

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


  1   2   3   4   5   >