D25327: Fix cmake project command position

2019-11-15 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R169:55cd76337897: Fix cmake project command position (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25327?vs=69802=69817 REVISION DETAIL

D25327: Fix cmake project command position

2019-11-15 Thread Dimitris Kardarakos
dkardarakos created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Establish version and policy settings before invoking other commands REPOSITORY R169 Kirigami BRANCH

D25104: Fix PageRow globalToolBar documentation

2019-11-02 Thread Dimitris Kardarakos
dkardarakos added a comment. In D25104#557851 , @ahiemstra wrote: > Great, thank you! It was nothing! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25104 To: dkardarakos, ognarb, ahiemstra Cc: ahiemstra,

D25104: Fix PageRow globalToolBar documentation

2019-11-02 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c504f1327e5e: Fix PageRow globalToolBar documentation (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25104?vs=69185=69196 REVISION

D25104: Fix PageRow globalToolBar documentation

2019-11-02 Thread Dimitris Kardarakos
dkardarakos added a comment. More fixes F7716989: after_2.png REPOSITORY R169 Kirigami BRANCH fix-pagerow-doc (branched from master) REVISION DETAIL https://phabricator.kde.org/D25104 To: dkardarakos, ognarb Cc: ahiemstra, ognarb,

D25104: Fix PageRow globalToolBar documentation

2019-11-02 Thread Dimitris Kardarakos
dkardarakos updated this revision to Diff 69185. dkardarakos added a comment. Fix globalToolBar documentation Ensure that the documentation of each property of the globalToolBar group property is presented correctly REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Dimitris Kardarakos
dkardarakos added a comment. Before F7709694: before.png After F7709700: after.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25104 To: dkardarakos Cc: plasma-devel,

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Dimitris Kardarakos
dkardarakos created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY In PageRow documentation, globalToolBar's style contains an unordered list of the various style value options. With this

D25103: Simplify application load

2019-11-01 Thread Dimitris Kardarakos
dkardarakos created this revision. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY These is no need to have two different main QML files for desktop and mobile, and we do need to check

D24674: Fix Kirigami template image

2019-10-16 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R169:03adbbcd2f74: Fix Kirigami template image (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24674?vs=67995=68026 REVISION DETAIL

D24674: Fix Kirigami template image

2019-10-15 Thread Dimitris Kardarakos
dkardarakos created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Kirigami template image file is empty. An image file that shows a Kirigami application was added. TEST PLAN Try to

D23853: Add api urls into the information sheet

2019-09-18 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R1014:876324b565cc: Add api urls into the information sheet (authored by dkardarakos). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23853?vs=65797=66367

D23843: Add template for Kirigami application development

2019-09-18 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R169:150acfd8820b: Add template for Kirigami application development (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23843?vs=65786=66366

D23854: Fix wrong title of the Drawers page

2019-09-12 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R1014:21c571099542: Fix the wrong title of the Drawers page (authored by dkardarakos). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23854?vs=65798=65933

D23854: Fix wrong title of the Drawers page

2019-09-10 Thread Dimitris Kardarakos
dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY The Drawers page title was erroneously set to Overlay Sheets. This commit

D23853: Add api urls into the information sheet

2019-09-10 Thread Dimitris Kardarakos
dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Users will be able to directly navigate to the api.kde.org page of the

D23843: Add template for Kirigami application development

2019-09-10 Thread Dimitris Kardarakos
dkardarakos created this revision. dkardarakos added reviewers: kossebau, apol. dkardarakos added a project: Plasma: Mobile. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY With this commit developers

D19977: Prevent context drawer from disappearing

2019-04-01 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R169:b897b37b254b: Prevent context drawer from disappearing (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19977?vs=54565=55192 REVISION

D19977: Prevent context drawer from disappearing

2019-04-01 Thread Dimitris Kardarakos
dkardarakos added a comment. Any comments? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19977 To: dkardarakos, mart Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19977: Prevent context drawer from disappearing

2019-03-22 Thread Dimitris Kardarakos
dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Currently, on plasma mobile, if you navigate from a page that contains contextual

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

2019-02-09 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R1014:d8ce1591e861: Port Cards Grid, Cards List and Inline Messages extra information to json-based… (authored by dkardarakos). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

2019-02-08 Thread Dimitris Kardarakos
dkardarakos updated this revision to Diff 51172. dkardarakos edited the summary of this revision. dkardarakos added a comment. Changed links that pointed to the kirigami repository, to kirigami-gallery which is more useful for the contributors. REPOSITORY R1014 Kirigami Gallery CHANGES

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

2019-02-08 Thread Dimitris Kardarakos
dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Info sheet is fed by a single json file that contains extra info and links to

D18823: Create a dynamic way to provide component information

2019-02-07 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R1014:d780fc1db376: Create a dynamic way to provide component information (authored by dkardarakos). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE

D18823: Create a dynamic way to provide component information

2019-02-07 Thread Dimitris Kardarakos
dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY In some components, an action is offered that provides descriptive info about

D16807: Fix colors in sound settings

2018-11-10 Thread Dimitris Kardarakos
dkardarakos created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY In Plasma Mobile, when Breeze Dark is selected, color text is hardly visible. Labels' color has been set to fix the issue.

D15143: Allow creation of separator Actions

2018-10-01 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R169:91ea75c37045: Allow creation of separator Actions (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15143?vs=42465=42655 REVISION DETAIL

D15143: Allow creation of separator Actions

2018-09-28 Thread Dimitris Kardarakos
dkardarakos updated this revision to Diff 42465. dkardarakos added a comment. Previously introduced "separator mode" removed from AbstractListItem and BasicListItem. Instead of a solution totally inside globaldrawer and contextdrawer I opted for a new BasicListItem alias property

D15143: Allow creation of separator Actions

2018-08-29 Thread Dimitris Kardarakos
dkardarakos updated this revision to Diff 40647. dkardarakos edited the summary of this revision. dkardarakos added a comment. Function isSeparator removed REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15143?vs=40639=40647 REVISION DETAIL

D15143: Allow creation of separator Actions

2018-08-29 Thread Dimitris Kardarakos
dkardarakos added a comment. isSeparator function has been added to ensure compatibility with QAction https://doc.qt.io/qt-5/qaction.html#isSeparator. We do not need it? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15143 To: dkardarakos, mart Cc: broulik,

D15143: Allow creation of separator Actions

2018-08-29 Thread Dimitris Kardarakos
dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY The QAction class allows an action to be considered a separator. In Kirigami Action