D25327: Fix cmake project command position

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:55cd76337897: Fix cmake project command position 
(authored by dkardarakos).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25327?vs=69802=69817

REVISION DETAIL
  https://phabricator.kde.org/D25327

AFFECTED FILES
  templates/kirigami/CMakeLists.txt

To: dkardarakos, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25327: Fix cmake project command position

[Dimitris Kardarakos]

dkardarakos created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  Establish version and policy settings before invoking other commands

REPOSITORY
  R169 Kirigami

BRANCH
  cmake-command-order (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25327

AFFECTED FILES
  templates/kirigami/CMakeLists.txt

To: dkardarakos
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

[Dimitris Kardarakos]

dkardarakos added a comment.


  In D25104#557851 , @ahiemstra 
wrote:
  
  > Great, thank you!
  
  
  It was nothing!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb, ahiemstra
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c504f1327e5e: Fix PageRow globalToolBar documentation 
(authored by dkardarakos).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25104?vs=69185=69196

REVISION DETAIL
  https://phabricator.kde.org/D25104

AFFECTED FILES
  src/controls/PageRow.qml

To: dkardarakos, ognarb, ahiemstra
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

[Dimitris Kardarakos]

dkardarakos added a comment.


  More fixes 
  F7716989: after_2.png 

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

[Dimitris Kardarakos]

dkardarakos updated this revision to Diff 69185.
dkardarakos added a comment.


  Fix globalToolBar documentation
  
  Ensure that the documentation of each property of the globalToolBar group 
property is presented correctly

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25104?vs=69154=69185

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

AFFECTED FILES
  src/controls/PageRow.qml

To: dkardarakos, ognarb
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

[Dimitris Kardarakos]

dkardarakos added a comment.


  Before
  F7709694: before.png 
  
  After
  F7709700: after.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

[Dimitris Kardarakos]

dkardarakos created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  In PageRow documentation, globalToolBar's style contains an unordered list of 
the various style value options. With this commit, the list is properly 
displayed.

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

AFFECTED FILES
  src/controls/PageRow.qml

To: dkardarakos
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25103: Simplify application load

[Dimitris Kardarakos]

dkardarakos created this revision.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  These is no need to have two different main QML files for desktop and mobile, 
and we do need to check environmental variables to load a platform-specific QML 
file.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  simple-main (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25103

AFFECTED FILES
  src/data/contents/ui/BaseApp.qml
  src/data/contents/ui/mobileApp.qml
  src/main.cpp
  src/resources.qrc

To: dkardarakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart, hein

D24674: Fix Kirigami template image

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:03adbbcd2f74: Fix Kirigami template image (authored by 
dkardarakos).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24674?vs=67995=68026

REVISION DETAIL
  https://phabricator.kde.org/D24674

AFFECTED FILES
  templates/kirigami/kirigami-app.png

To: dkardarakos, apol, ngraham, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24674: Fix Kirigami template image

[Dimitris Kardarakos]

dkardarakos created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  Kirigami template image file is empty. An image file that shows a Kirigami 
application was added.

TEST PLAN
  Try to create a Kirigami application with kdevelop or kapptemplate, using the 
template found in Qt > Graphical > Kirigami Application; an image is shown, 
showing how the application will look like.

REPOSITORY
  R169 Kirigami

BRANCH
  TemplateImage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24674

AFFECTED FILES
  templates/kirigami/kirigami-app.png

To: dkardarakos
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D23853: Add api urls into the information sheet

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:876324b565cc: Add api urls into the information sheet 
(authored by dkardarakos).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23853?vs=65797=66367

REVISION DETAIL
  https://phabricator.kde.org/D23853

AFFECTED FILES
  src/InfoData.cpp
  src/InfoData.h
  src/data/contents/ui/gallery/components/InfoSheet.qml
  src/data/info-data.json

To: dkardarakos, mart
Cc: fabianr, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, domson, dkardarakos, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D23843: Add template for Kirigami application development

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:150acfd8820b: Add template for Kirigami application 
development (authored by dkardarakos).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23843?vs=65786=66366

REVISION DETAIL
  https://phabricator.kde.org/D23843

AFFECTED FILES
  CMakeLists.txt
  templates/CMakeLists.txt
  templates/kirigami/CMakeLists.txt
  templates/kirigami/kirigami-app.png
  templates/kirigami/kirigami.kdevtemplate
  templates/kirigami/org.kde.%{APPNAMELC}.appdata.xml
  templates/kirigami/org.kde.%{APPNAMELC}.desktop
  templates/kirigami/src/CMakeLists.txt
  templates/kirigami/src/contents/ui/main.qml
  templates/kirigami/src/main.cpp
  templates/kirigami/src/resources.qrc

To: dkardarakos, kossebau, apol, #kirigami, mart
Cc: jbbgameich, plasma-devel, hannahk, frmdstryr, fbampaloukas, GB_2, emrek, 
mkraemer, cahfofpai, asghaier, domson, tbalzer, dkardarakos, PureTryOut, lnj, 
neofytosk, alexeymin, IlyaBizyaev, dvasin, jessep, Sergobot, sebas, apol, 
davidedmundson, mart, hein

D23854: Fix wrong title of the Drawers page

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:21c571099542: Fix the wrong title of the Drawers page 
(authored by dkardarakos).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23854?vs=65798=65933

REVISION DETAIL
  https://phabricator.kde.org/D23854

AFFECTED FILES
  src/data/contents/ui/gallery/DrawerGallery.qml

To: dkardarakos, mart, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, domson, dkardarakos, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D23854: Fix wrong title of the Drawers page

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  The Drawers page title was erroneously set to Overlay Sheets. This commit 
fixes it.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D23854

AFFECTED FILES
  src/data/contents/ui/gallery/DrawerGallery.qml

To: dkardarakos, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, domson, dkardarakos, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D23853: Add api urls into the information sheet

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  Users will be able to directly navigate to the api.kde.org page of the 
specific kirigami type

TEST PLAN
  Select a component that offers extra information (e.g. FormLayoutGallery), 
trigger the Info action and click to the API.. button.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D23853

AFFECTED FILES
  src/InfoData.cpp
  src/InfoData.h
  src/data/contents/ui/gallery/components/InfoSheet.qml
  src/data/info-data.json

To: dkardarakos, mart
Cc: fabianr, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, domson, dkardarakos, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D23843: Add template for Kirigami application development

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added reviewers: kossebau, apol.
dkardarakos added a project: Plasma: Mobile.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  With this commit developers will be able to create a new kirigami application 
using a template

TEST PLAN
  Create a new project with these steps:
  Project > New From Template > Qt > Graphical > Kirigami Application

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23843

AFFECTED FILES
  CMakeLists.txt
  templates/CMakeLists.txt
  templates/kirigami/CMakeLists.txt
  templates/kirigami/kirigami-app.png
  templates/kirigami/kirigami.kdevtemplate
  templates/kirigami/org.kde.%{APPNAMELC}.appdata.xml
  templates/kirigami/org.kde.%{APPNAMELC}.desktop
  templates/kirigami/src/CMakeLists.txt
  templates/kirigami/src/contents/ui/main.qml
  templates/kirigami/src/main.cpp
  templates/kirigami/src/resources.qrc

To: dkardarakos, kossebau, apol
Cc: jbbgameich, plasma-devel, hannahk, frmdstryr, fbampaloukas, GB_2, emrek, 
mkraemer, cahfofpai, asghaier, domson, tbalzer, dkardarakos, PureTryOut, lnj, 
neofytosk, alexeymin, IlyaBizyaev, dvasin, jessep, Sergobot, sebas, apol, 
davidedmundson, mart, hein

D19977: Prevent context drawer from disappearing

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:b897b37b254b: Prevent context drawer from disappearing 
(authored by dkardarakos).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19977?vs=54565=55192

REVISION DETAIL
  https://phabricator.kde.org/D19977

AFFECTED FILES
  src/controls/ContextDrawer.qml

To: dkardarakos, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19977: Prevent context drawer from disappearing

[Dimitris Kardarakos]

dkardarakos added a comment.


  Any comments?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19977

To: dkardarakos, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19977: Prevent context drawer from disappearing

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  Currently, on plasma mobile, if you navigate from a page that contains 
contextual actions to a page without contextual actions and back, context 
drawer disappears. Looking for contextual actions in 
pageStack.layers.currentItem only when pageStack.layers.depth > 1, then 
checking pageStack.currentItem and finally, checking pageStack.lastVisibleItem, 
we ensure that we look for contextual actions in the most relevant page.

TEST PLAN
  On mobile, navigate from a page that contains contextual actions to a page 
without contextual actions and back.
  
  Before patching:
  Context drawer disappears
  
  After patching:
  Context drawer is still visible

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19977

AFFECTED FILES
  src/controls/ContextDrawer.qml

To: dkardarakos, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:d8ce1591e861: Port Cards Grid, Cards List and Inline 
Messages extra information to json-based… (authored by dkardarakos).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18839?vs=51172=51239

REVISION DETAIL
  https://phabricator.kde.org/D18839

AFFECTED FILES
  src/data/contents/ui/gallery/CardsGridViewGallery.qml
  src/data/contents/ui/gallery/CardsListViewGallery.qml
  src/data/contents/ui/gallery/InlineMessagesGallery.qml
  src/data/info-data.json

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

[Dimitris Kardarakos]

dkardarakos updated this revision to Diff 51172.
dkardarakos edited the summary of this revision.
dkardarakos added a comment.


  Changed links that pointed to the kirigami repository, to kirigami-gallery 
which is more useful for the contributors.

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18839?vs=51153=51172

REVISION DETAIL
  https://phabricator.kde.org/D18839

AFFECTED FILES
  src/data/contents/ui/gallery/CardsGridViewGallery.qml
  src/data/contents/ui/gallery/CardsListViewGallery.qml
  src/data/contents/ui/gallery/InlineMessagesGallery.qml
  src/data/info-data.json

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  Info sheet is fed by a single json file that contains extra info and links to 
source and hig. Cards Grid, Cards List and Inline Messages should use this to 
provide extra info.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D18839

AFFECTED FILES
  src/data/contents/ui/gallery/CardsGridViewGallery.qml
  src/data/contents/ui/gallery/CardsListViewGallery.qml
  src/data/contents/ui/gallery/InlineMessagesGallery.qml
  src/data/info-data.json

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D18823: Create a dynamic way to provide component information

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:d780fc1db376: Create a dynamic way to provide component 
information (authored by dkardarakos).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18823?vs=51124=51133

REVISION DETAIL
  https://phabricator.kde.org/D18823

AFFECTED FILES
  src/CMakeLists.txt
  src/InfoData.cpp
  src/InfoData.h
  src/data/contents/ui/gallery/CardsLayoutGallery.qml
  src/data/contents/ui/gallery/DrawerGallery.qml
  src/data/contents/ui/gallery/FormLayoutGallery.qml
  src/data/contents/ui/gallery/OverlaySheetGallery.qml
  src/data/contents/ui/gallery/SelectionControlsGallery.qml
  src/data/contents/ui/gallery/components/InfoSheet.qml
  src/data/info-data.json
  src/main.cpp
  src/resources.qrc

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D18823: Create a dynamic way to provide component information

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  In some components, an action is offered that provides descriptive info about 
the component as well as links to the source code and the hig website. All this 
info has been gathered into a json file. The InfoData plugin has been created 
to serve the data to the QML code.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D18823

AFFECTED FILES
  src/CMakeLists.txt
  src/InfoData.cpp
  src/InfoData.h
  src/data/contents/ui/gallery/CardsLayoutGallery.qml
  src/data/contents/ui/gallery/DrawerGallery.qml
  src/data/contents/ui/gallery/FormLayoutGallery.qml
  src/data/contents/ui/gallery/OverlaySheetGallery.qml
  src/data/contents/ui/gallery/SelectionControlsGallery.qml
  src/data/contents/ui/gallery/components/InfoSheet.qml
  src/data/info-data.json
  src/main.cpp
  src/resources.qrc

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D16807: Fix colors in sound settings

[Dimitris Kardarakos]

dkardarakos created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  In Plasma Mobile, when Breeze Dark is selected, color text is hardly visible. 
Labels' color has been set to fix the issue.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16807

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/VolumeSlider.qml

To: dkardarakos
Cc: bshah, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15143: Allow creation of separator Actions

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:91ea75c37045: Allow creation of separator Actions 
(authored by dkardarakos).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15143?vs=42465=42655

REVISION DETAIL
  https://phabricator.kde.org/D15143

AFFECTED FILES
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ActionsMenu.qml

To: dkardarakos, mart
Cc: broulik, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15143: Allow creation of separator Actions

[Dimitris Kardarakos]

dkardarakos updated this revision to Diff 42465.
dkardarakos added a comment.


  Previously introduced "separator mode" removed from AbstractListItem and 
BasicListItem.
  
  Instead of a solution totally inside globaldrawer and contextdrawer I opted 
for a new BasicListItem alias property (reserveSpaceForLabel) similar to the 
existing reserveSpaceForIcon. With this approach we have more control when 
adding new items (like the Separator) to BasicListItems.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15143?vs=40647=42465

REVISION DETAIL
  https://phabricator.kde.org/D15143

AFFECTED FILES
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ActionsMenu.qml

To: dkardarakos, mart
Cc: broulik, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15143: Allow creation of separator Actions

[Dimitris Kardarakos]

dkardarakos updated this revision to Diff 40647.
dkardarakos edited the summary of this revision.
dkardarakos added a comment.


  Function isSeparator removed

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15143?vs=40639=40647

REVISION DETAIL
  https://phabricator.kde.org/D15143

AFFECTED FILES
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ActionsMenu.qml
  src/controls/templates/AbstractListItem.qml

To: dkardarakos, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D15143: Allow creation of separator Actions

[Dimitris Kardarakos]

dkardarakos added a comment.


  isSeparator function has been added to ensure compatibility with QAction 
https://doc.qt.io/qt-5/qaction.html#isSeparator. We do not need it?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15143

To: dkardarakos, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D15143: Allow creation of separator Actions

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  The QAction class allows an action to be considered a separator. In Kirigami 
Action the separator property and the isSeparator function have been added to 
serve the same purpose. A set of delegates have been changed to draw a 
separator in case that an Action with separator:true has been found in the 
model.

TEST PLAN
  Add contextual or global actions like this:
  
  Kirigami.Action {
  
separator: true
  
  }

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15143

AFFECTED FILES
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ActionsMenu.qml
  src/controls/templates/AbstractListItem.qml

To: dkardarakos, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein