from:"Furkan Tokac"

D14017: Splitting Touchpad KCM, Stage 3

2018-07-09 Thread Furkan Tokac

furkantokac created this revision.
furkantokac added a project: Plasma.
furkantokac requested review of this revision.

REVISION SUMMARY
  kcm_touchpad (Wayland) and kcm_touchpadx (X11) are available by this commit. 
kcm_touchpad is dummy for now. Tested, it is working.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14017

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/touchpad/CMakeLists.txt
  kcms/touchpad/README.md
  kcms/touchpad/cmake/modules/COPYING-CMAKE-SCRIPTS
  kcms/touchpad/cmake/modules/FindX11_XCB.cmake
  kcms/touchpad/cmake/modules/FindXCB.cmake
  kcms/touchpad/icon/128-devices-input-touchpad.png
  kcms/touchpad/icon/16-devices-input-touchpad.png
  kcms/touchpad/icon/22-devices-input-touchpad.png
  kcms/touchpad/icon/24-devices-input-touchpad.png
  kcms/touchpad/icon/256-devices-input-touchpad.png
  kcms/touchpad/icon/32-devices-input-touchpad.png
  kcms/touchpad/icon/48-devices-input-touchpad.png
  kcms/touchpad/icon/64-devices-input-touchpad.png
  kcms/touchpad/icon/96-devices-input-touchpad.png
  kcms/touchpad/icon/CMakeLists.txt
  kcms/touchpad/icon/makeicons.sh
  kcms/touchpad/icon/sc-devices-input-touchpad.svgz
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/applet/CMakeLists.txt
  kcms/touchpad/src/applet/dataengine.desktop
  kcms/touchpad/src/applet/qml/contents/ui/touchpad.qml
  kcms/touchpad/src/applet/qml/metadata.desktop
  kcms/touchpad/src/applet/touchpad.operations
  kcms/touchpad/src/applet/touchpad.svg
  kcms/touchpad/src/applet/touchpadengine.cpp
  kcms/touchpad/src/applet/touchpadengine.h
  kcms/touchpad/src/applet/touchpadservice.cpp
  kcms/touchpad/src/applet/touchpadservice.h
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/listdevices.cpp
  kcms/touchpad/src/backends/x11/propertyinfo.cpp
  kcms/touchpad/src/backends/x11/propertyinfo.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xcbatom.cpp
  kcms/touchpad/src/backends/x11/xcbatom.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibnotifications.cpp
  kcms/touchpad/src/backends/x11/xlibnotifications.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/backends/x11/xrecordkeyboardmonitor.cpp
  kcms/touchpad/src/backends/x11/xrecordkeyboardmonitor.h
  kcms/touchpad/src/kcm/kcm_touchpad.desktop
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/resources.qrc
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/customconfigdialogmanager.cpp
  kcms/touchpad/src/kcm/xlib/customconfigdialogmanager.h
  kcms/touchpad/src/kcm/xlib/customslider.cpp
  kcms/touchpad/src/kcm/xlib/customslider.h
  kcms/touchpad/src/kcm/xlib/sliderpair.cpp
  kcms/touchpad/src/kcm/xlib/sliderpair.h
  kcms/touchpad/src/kcm/xlib/testarea.cpp
  kcms/touchpad/src/kcm/xlib/testarea.h
  kcms/touchpad/src/kcm/xlib/testbutton.cpp
  kcms/touchpad/src/kcm/xlib/testbutton.h
  kcms/touchpad/src/kcm/xlib/touchpad.kcfg
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/kcm/xlib/touchpadparameters.kcfgc
  kcms/touchpad/src/kcm/xlib/touchpadparametersbase.cpp
  kcms/touchpad/src/kcm/xlib/touchpadparametersbase.h
  kcms/touchpad/src/kcm/xlib/ui/kded.ui
  kcms/touchpad/src/kcm/xlib/ui/pointermotion.ui
  kcms/touchpad/src/kcm/xlib/ui/scroll.ui
  kcms/touchpad/src/kcm/xlib/ui/sensitivity.ui
  kcms/touchpad/src/kcm/xlib/ui/tap.ui
  kcms/touchpad/src/kcm/xlib/ui/testarea.ui
  kcms/touchpad/src/kded/kcm_touchpad.notifyrc
  kcms/touchpad/src/kded/kded.cpp
  kcms/touchpad/src/kded/kded.h
  kcms/touchpad/src/kded/kded_touchpad.desktop
  kcms/touchpad/src/kded/kdedactions.cpp
  kcms/touchpad/src/kded/kdedactions.h
  kcms/touchpad/src/kded/kdedsettings.kcfgc
  kcms/touchpad/src/kded/touchpaddaemon.kcfg
  kcms/touchpad/src/logging.cpp
  kcms/touchpad/src/logging.h
  kcms/touchpad/src/plugins.cpp
  kcms/touchpad/src/plugins.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h
  kcms/touchpad/src/version.h.cmake
  kcms/touchpadx/CMakeLists.txt
  kcms/touchpadx/COPYING

D14016: Splitting Touchpad KCM, Stage 2

2018-07-09 Thread Furkan Tokac

furkantokac created this revision.
furkantokac added a project: Plasma.
furkantokac requested review of this revision.

REVISION SUMMARY
  Minimum changes are done since there will be another commit for kcm_touchpadx 
cleaning. The kcm_touchpad is changed as kcm_touchpadx and it is moved to new 
folder "touchpadx". Since "touchpad" folder is changed, you can review the diff 
by checking it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14016

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/touchpad/CMakeLists.txt
  kcms/touchpad/Messages.sh
  kcms/touchpad/README.md
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/applet/CMakeLists.txt
  kcms/touchpad/src/applet/qml/metadata.desktop
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/kcm/kcm_touchpad.desktop
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/resources.qrc
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpadx/CMakeLists.txt
  kcms/touchpadx/COPYING
  kcms/touchpadx/Messages.sh
  kcms/touchpadx/README.md
  kcms/touchpadx/cmake/modules/COPYING-CMAKE-SCRIPTS
  kcms/touchpadx/cmake/modules/FindX11_XCB.cmake
  kcms/touchpadx/cmake/modules/FindXCB.cmake
  kcms/touchpadx/icon/128-devices-input-touchpad.png
  kcms/touchpadx/icon/16-devices-input-touchpad.png
  kcms/touchpadx/icon/22-devices-input-touchpad.png
  kcms/touchpadx/icon/24-devices-input-touchpad.png
  kcms/touchpadx/icon/256-devices-input-touchpad.png
  kcms/touchpadx/icon/32-devices-input-touchpad.png
  kcms/touchpadx/icon/48-devices-input-touchpad.png
  kcms/touchpadx/icon/64-devices-input-touchpad.png
  kcms/touchpadx/icon/96-devices-input-touchpad.png
  kcms/touchpadx/icon/CMakeLists.txt
  kcms/touchpadx/icon/makeicons.sh
  kcms/touchpadx/icon/sc-devices-input-touchpad.svgz
  kcms/touchpadx/src/CMakeLists.txt
  kcms/touchpadx/src/applet/CMakeLists.txt
  kcms/touchpadx/src/applet/dataengine.desktop
  kcms/touchpadx/src/applet/qml/contents/ui/touchpad.qml
  kcms/touchpadx/src/applet/qml/metadata.desktop
  kcms/touchpadx/src/applet/touchpad.operations
  kcms/touchpadx/src/applet/touchpad.svg
  kcms/touchpadx/src/applet/touchpadengine.cpp
  kcms/touchpadx/src/applet/touchpadengine.h
  kcms/touchpadx/src/applet/touchpadservice.cpp
  kcms/touchpadx/src/applet/touchpadservice.h
  kcms/touchpadx/src/backends/x11.cmake
  kcms/touchpadx/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpadx/src/backends/x11/libinputtouchpad.h
  kcms/touchpadx/src/backends/x11/listdevices.cpp
  kcms/touchpadx/src/backends/x11/propertyinfo.cpp
  kcms/touchpadx/src/backends/x11/propertyinfo.h
  kcms/touchpadx/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpadx/src/backends/x11/synapticstouchpad.h
  kcms/touchpadx/src/backends/x11/xcbatom.cpp
  kcms/touchpadx/src/backends/x11/xcbatom.h
  kcms/touchpadx/src/backends/x11/xlibbackend.cpp
  kcms/touchpadx/src/backends/x11/xlibbackend.h
  kcms/touchpadx/src/backends/x11/xlibnotifications.cpp
  kcms/touchpadx/src/backends/x11/xlibnotifications.h
  kcms/touchpadx/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpadx/src/backends/x11/xlibtouchpad.h
  kcms/touchpadx/src/backends/x11/xrecordkeyboardmonitor.cpp
  kcms/touchpadx/src/backends/x11/xrecordkeyboardmonitor.h
  kcms/touchpadx/src/kcm/kcm_touchpadx.desktop
  kcms/touchpadx/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpadx/src/kcm/touchpadconfigcontainer.h
  kcms/touchpadx/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpadx/src/kcm/touchpadconfigplugin.h
  kcms/touchpadx/src/kcm/xlib/customconfigdialogmanager.cpp
  kcms/touchpadx/src/kcm/xlib/customconfigdialogmanager.h
  kcms/touchpadx/src/kcm/xlib/customslider.cpp
  kcms/touchpadx/src/kcm/xlib/customslider.h
  kcms/touchpadx/src/kcm/xlib/sliderpair.cpp
  kcms/touchpadx/src/kcm/xlib/sliderpair.h
  kcms/touchpadx/src/kcm/xlib/testarea.cpp
  kcms/touchpadx/src/kcm/xlib/testarea.h
  kcms/touchpadx/src/kcm/xlib/testbutton.cpp
  kcms/touchpadx/src/kcm/xlib/testbutton.h
  kcms/touchpadx/src/kcm/xlib/touchpad.kcfg
  kcms/touchpadx/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpadx/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpadx/src/kcm/xlib/touchpadparameters.kcfgc
  kcms/touchpadx/src/kcm/xlib/touchpadparametersbase.cpp
  kcms/touchpadx/src/kcm/xlib/touchpadparametersbase.h
  kcms/touchpadx/src/kcm/xlib/ui/kded.ui
  kcms/touchpadx/src/kcm/xlib/ui/pointermotion.ui
  kcms/touchpadx/src/kcm/xlib/ui/scroll.ui
  kcms/touchpadx/src/kcm/xlib/ui/sensitivity.ui

D13997: Splitting Touchpad KCM

2018-07-09 Thread Furkan Tokac

furkantokac updated this revision to Diff 37484.
furkantokac added a comment.


  Phase 1

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13997?vs=37464=37484

REVISION DETAIL
  https://phabricator.kde.org/D13997

AFFECTED FILES
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/kcm/kcm_touchpad.desktop
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/resources.qrc
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h
  kcms/touchpad/src/touchpadbackend.cpp

To: furkantokac, romangg, ngraham, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13997: Splitting Touchpad KCM

2018-07-09 Thread Furkan Tokac

furkantokac added a comment.


  In D13997#289384 , @romangg wrote:
  
  > If we go with this split the stages should be:
  >
  > 1. Append an x to the name of the old Touchpad KCM, make the KCM show only 
on X and add the new Wayland KCM without the X code as kcm_touchpad.
  > 2. Remove all Wayland related code from the old KCM.
  > 3. Rewrite the new Wayland KCM as KConfigModule.
  > 4. Your stage 4.
  
  
  Makes sense!
  
  In D13997#289384 , @romangg wrote:
  
  > If we go with this split the stages should be:
  >
  > 1. Append an x to the name of the old Touchpad KCM, make the KCM show only 
on X and add the new Wayland KCM without the X code as kcm_touchpad.
  > 2. Remove all Wayland related code from the old KCM.
  > 3. Rewrite the new Wayland KCM as KConfigModule.
  > 4. Your stage 4.
  
  
  kded_touchpad is handling the Wayland touchpad so I couldn't compile the 
Wayland part by just seperating it. If you know the solution, I can do that too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13997

To: furkantokac, romangg, ngraham, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13997: Splitting Touchpad KCM

2018-07-09 Thread Furkan Tokac

furkantokac updated this revision to Diff 37464.
furkantokac edited the test plan for this revision.
furkantokac added a comment.


  Stage 3
  kcm_touchpad (Wayland) and kcm_touchpadx (X11) are available by this commit. 
Tested and working fine. To test it, you should manually remove the old 
kcm_touchpad files since the names are clashing imho. This problem will be 
handled by packagers after the patch is pushed to master. I'm implementing the 
backend now (kcm.cpp, kcm.h).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13997?vs=37438=37464

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13997

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/touchpad/CMakeLists.txt
  kcms/touchpad/README.md
  kcms/touchpad/cmake/modules/COPYING-CMAKE-SCRIPTS
  kcms/touchpad/cmake/modules/FindX11_XCB.cmake
  kcms/touchpad/cmake/modules/FindXCB.cmake
  kcms/touchpad/icon/128-devices-input-touchpad.png
  kcms/touchpad/icon/16-devices-input-touchpad.png
  kcms/touchpad/icon/22-devices-input-touchpad.png
  kcms/touchpad/icon/24-devices-input-touchpad.png
  kcms/touchpad/icon/256-devices-input-touchpad.png
  kcms/touchpad/icon/32-devices-input-touchpad.png
  kcms/touchpad/icon/48-devices-input-touchpad.png
  kcms/touchpad/icon/64-devices-input-touchpad.png
  kcms/touchpad/icon/96-devices-input-touchpad.png
  kcms/touchpad/icon/CMakeLists.txt
  kcms/touchpad/icon/makeicons.sh
  kcms/touchpad/icon/sc-devices-input-touchpad.svgz
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/applet/CMakeLists.txt
  kcms/touchpad/src/applet/dataengine.desktop
  kcms/touchpad/src/applet/qml/contents/ui/touchpad.qml
  kcms/touchpad/src/applet/qml/metadata.desktop
  kcms/touchpad/src/applet/touchpad.operations
  kcms/touchpad/src/applet/touchpad.svg
  kcms/touchpad/src/applet/touchpadengine.cpp
  kcms/touchpad/src/applet/touchpadengine.h
  kcms/touchpad/src/applet/touchpadservice.cpp
  kcms/touchpad/src/applet/touchpadservice.h
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/listdevices.cpp
  kcms/touchpad/src/backends/x11/propertyinfo.cpp
  kcms/touchpad/src/backends/x11/propertyinfo.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xcbatom.cpp
  kcms/touchpad/src/backends/x11/xcbatom.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibnotifications.cpp
  kcms/touchpad/src/backends/x11/xlibnotifications.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/backends/x11/xrecordkeyboardmonitor.cpp
  kcms/touchpad/src/backends/x11/xrecordkeyboardmonitor.h
  kcms/touchpad/src/kcm/kcm_touchpad.desktop
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/resources.qrc
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/customconfigdialogmanager.cpp
  kcms/touchpad/src/kcm/xlib/customconfigdialogmanager.h
  kcms/touchpad/src/kcm/xlib/customslider.cpp
  kcms/touchpad/src/kcm/xlib/customslider.h
  kcms/touchpad/src/kcm/xlib/sliderpair.cpp
  kcms/touchpad/src/kcm/xlib/sliderpair.h
  kcms/touchpad/src/kcm/xlib/testarea.cpp
  kcms/touchpad/src/kcm/xlib/testarea.h
  kcms/touchpad/src/kcm/xlib/testbutton.cpp
  kcms/touchpad/src/kcm/xlib/testbutton.h
  kcms/touchpad/src/kcm/xlib/touchpad.kcfg
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/kcm/xlib/touchpadparameters.kcfgc
  kcms/touchpad/src/kcm/xlib/touchpadparametersbase.cpp
  kcms/touchpad/src/kcm/xlib/touchpadparametersbase.h
  kcms/touchpad/src/kcm/xlib/ui/kded.ui
  kcms/touchpad/src/kcm/xlib/ui/pointermotion.ui
  kcms/touchpad/src/kcm/xlib/ui/scroll.ui
  kcms/touchpad/src/kcm/xlib/ui/sensitivity.ui
  kcms/touchpad/src/kcm/xlib/ui/tap.ui
  kcms/touchpad/src/kcm/xlib/ui/testarea.ui
  kcms/touchpad/src/kded/kcm_touchpad.notifyrc
  kcms/touchpad/src/kded/kded.cpp
  kcms/touchpad/src/kded/kded.h
  kcms/touchpad/src/kded/kded_touchpad.desktop
  kcms/touchpad/src/kded/kdedactions.cpp
  kcms/touchpad/src/kded/kdedactions.h
  kcms/touchpad/src/kded/kdedsettings.kcfgc
  kcms/touchpad/src/kded/touchpaddaemon.kcfg

D13997: Splitting Touchpad KCM

2018-07-09 Thread Furkan Tokac

furkantokac updated this revision to Diff 37438.
furkantokac added a comment.


  Stage 2 :
  Minimum changes are done since there will be another commit for kcm_touchpadx 
cleaning. The kcm_touchpad is changed as kcm_touchpadx and it is moved to new 
folder "touchpadx". Since "touchpad" folder is changed, you can review the diff 
by checking it. Tested on X and everything is working fine. In Wayland, the KCM 
is not shown at all.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13997?vs=37425=37438

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13997

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/touchpad/CMakeLists.txt
  kcms/touchpad/Messages.sh
  kcms/touchpad/README.md
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/applet/CMakeLists.txt
  kcms/touchpad/src/applet/qml/metadata.desktop
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/kcm/kcm_touchpad.desktop
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/resources.qrc
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpadx/CMakeLists.txt
  kcms/touchpadx/COPYING
  kcms/touchpadx/Messages.sh
  kcms/touchpadx/README.md
  kcms/touchpadx/cmake/modules/COPYING-CMAKE-SCRIPTS
  kcms/touchpadx/cmake/modules/FindX11_XCB.cmake
  kcms/touchpadx/cmake/modules/FindXCB.cmake
  kcms/touchpadx/icon/128-devices-input-touchpad.png
  kcms/touchpadx/icon/16-devices-input-touchpad.png
  kcms/touchpadx/icon/22-devices-input-touchpad.png
  kcms/touchpadx/icon/24-devices-input-touchpad.png
  kcms/touchpadx/icon/256-devices-input-touchpad.png
  kcms/touchpadx/icon/32-devices-input-touchpad.png
  kcms/touchpadx/icon/48-devices-input-touchpad.png
  kcms/touchpadx/icon/64-devices-input-touchpad.png
  kcms/touchpadx/icon/96-devices-input-touchpad.png
  kcms/touchpadx/icon/CMakeLists.txt
  kcms/touchpadx/icon/makeicons.sh
  kcms/touchpadx/icon/sc-devices-input-touchpad.svgz
  kcms/touchpadx/src/CMakeLists.txt
  kcms/touchpadx/src/applet/CMakeLists.txt
  kcms/touchpadx/src/applet/dataengine.desktop
  kcms/touchpadx/src/applet/qml/contents/ui/touchpad.qml
  kcms/touchpadx/src/applet/qml/metadata.desktop
  kcms/touchpadx/src/applet/touchpad.operations
  kcms/touchpadx/src/applet/touchpad.svg
  kcms/touchpadx/src/applet/touchpadengine.cpp
  kcms/touchpadx/src/applet/touchpadengine.h
  kcms/touchpadx/src/applet/touchpadservice.cpp
  kcms/touchpadx/src/applet/touchpadservice.h
  kcms/touchpadx/src/backends/x11.cmake
  kcms/touchpadx/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpadx/src/backends/x11/libinputtouchpad.h
  kcms/touchpadx/src/backends/x11/listdevices.cpp
  kcms/touchpadx/src/backends/x11/propertyinfo.cpp
  kcms/touchpadx/src/backends/x11/propertyinfo.h
  kcms/touchpadx/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpadx/src/backends/x11/synapticstouchpad.h
  kcms/touchpadx/src/backends/x11/xcbatom.cpp
  kcms/touchpadx/src/backends/x11/xcbatom.h
  kcms/touchpadx/src/backends/x11/xlibbackend.cpp
  kcms/touchpadx/src/backends/x11/xlibbackend.h
  kcms/touchpadx/src/backends/x11/xlibnotifications.cpp
  kcms/touchpadx/src/backends/x11/xlibnotifications.h
  kcms/touchpadx/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpadx/src/backends/x11/xlibtouchpad.h
  kcms/touchpadx/src/backends/x11/xrecordkeyboardmonitor.cpp
  kcms/touchpadx/src/backends/x11/xrecordkeyboardmonitor.h
  kcms/touchpadx/src/kcm/kcm_touchpadx.desktop
  kcms/touchpadx/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpadx/src/kcm/touchpadconfigcontainer.h
  kcms/touchpadx/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpadx/src/kcm/touchpadconfigplugin.h
  kcms/touchpadx/src/kcm/xlib/customconfigdialogmanager.cpp
  kcms/touchpadx/src/kcm/xlib/customconfigdialogmanager.h
  kcms/touchpadx/src/kcm/xlib/customslider.cpp
  kcms/touchpadx/src/kcm/xlib/customslider.h
  kcms/touchpadx/src/kcm/xlib/sliderpair.cpp
  kcms/touchpadx/src/kcm/xlib/sliderpair.h
  kcms/touchpadx/src/kcm/xlib/testarea.cpp
  kcms/touchpadx/src/kcm/xlib/testarea.h
  kcms/touchpadx/src/kcm/xlib/testbutton.cpp
  kcms/touchpadx/src/kcm/xlib/testbutton.h
  kcms/touchpadx/src/kcm/xlib/touchpad.kcfg
  kcms/touchpadx/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpadx/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpadx/src/kcm/xlib/touchpadparameters.kcfgc
  kcms/touchpadx/src/kcm/xlib/touchpadparametersbase.cpp
  kcms/touchpadx/src/kcm/xlib/touchpadparametersbase.h
  kcms/touchpadx/src/kcm/xlib/ui/kded.ui

D13997: Splitting Touchpad KCM

2018-07-09 Thread Furkan Tokac

furkantokac added a comment.


  Since you can review the old diff, I'm moving to stage 2. If you have problem 
with the Stage 1's diff, please tell me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13997

To: furkantokac, romangg, ngraham, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13997: Splitting Touchpad KCM

2018-07-09 Thread Furkan Tokac

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13997

AFFECTED FILES
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/kcm/kcm_touchpad.desktop
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/resources.qrc
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h
  kcms/touchpad/src/touchpadbackend.cpp

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

2018-06-27 Thread Furkan Tokac

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:86e674c6a2b9: Touchpad KCM Pointer Speed Slider 
Improvement (authored by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13767?vs=36801=36802

REVISION DETAIL
  https://phabricator.kde.org/D13767

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

2018-06-27 Thread Furkan Tokac

furkantokac updated this revision to Diff 36801.
furkantokac added a comment.


  Comment correction.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13767?vs=36783=36801

BRANCH
  arcpatch-D13767

REVISION DETAIL
  https://phabricator.kde.org/D13767

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

2018-06-27 Thread Furkan Tokac

furkantokac updated this revision to Diff 36783.
furkantokac added a comment.


  "value" part of last "Slider" patch is reverted since that kind of changes 
will be handled with another patch.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13767?vs=36782=36783

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13767

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

2018-06-27 Thread Furkan Tokac

furkantokac added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:239
> Let's do this in a separate commit where we change it along with the same 
> value in the Mouse KCM.

Sure it will be better. Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13767

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

2018-06-27 Thread Furkan Tokac

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13767

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13672: Mouse KCM Pointer Speed Slider Improvement

2018-06-26 Thread Furkan Tokac

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:13b35bd8025a: Mouse KCM Pointer Speed Slider Improvement 
(authored by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13672?vs=36495=36714

REVISION DETAIL
  https://phabricator.kde.org/D13672

AFFECTED FILES
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13672: Mouse KCM Pointer Speed Slider Improvement

2018-06-25 Thread Furkan Tokac

furkantokac added a comment.

  In D13672#281774 , @ngraham wrote:

  > `BUG: 395681` can't be a link, I don't think. It's gotta just be plain old 
dumb text. :)

  This patch actually solves the problem specified on bug title, "libinput 
pointer kcm needs 11 ticks on the speed slider so that the middle one can 
correspond to 0.0". Still you think that it doesn't solve the bug ?

  > Also, it seems that this is dependent on D13573 
. So please also add `Depends on D13573` to 
the Summary section somewhere. Then do `arc amend` locally. Thanks!

  D13573  patch is for Touchpad KCM but 
this patch is for Mouse KCM There is a confusion  So I'm going to apply the 
same patch for Touchpad KCM too. Same issue, same solution.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13573: Touchpad KCM QtQuickControls2 Conversion

2018-06-25 Thread Furkan Tokac

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6a4b5870fb2f: Touchpad KCM QtQuickControls2 Conversion 
(authored by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13573?vs=36648=36649

REVISION DETAIL
  https://phabricator.kde.org/D13573

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/components/ToolTip.qml
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/resources.qrc

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13573: Touchpad KCM QtQuickControls2 Conversion

2018-06-25 Thread Furkan Tokac

furkantokac updated this revision to Diff 36648.
furkantokac added a comment.


  Typo fix.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13573?vs=36308=36648

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13573

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/components/ToolTip.qml
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/resources.qrc

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13672: Mouse KCM Pointer Speed Slider Improvement

2018-06-22 Thread Furkan Tokac

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

AFFECTED FILES
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13573: Touchpad KCM QtQuickControls2 Conversion

2018-06-19 Thread Furkan Tokac

furkantokac added a comment.


  In D13573#280026 , @ngraham wrote:
  
  > Looks good to me too.
  >
  > In D13573#279852 , @furkantokac 
wrote:
  >
  > > - Please review it. After your review, I'll also enable the Acceleration 
Profile with this patch by some editing.
  >
  >
  > That would be unrelated to this code cleanup. Please do that in another 
patch.
  
  
  So its okay no problem. Thanks for the feedback.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13573

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13573: Touchpad KCM QtQuickControls2 Conversion

2018-06-19 Thread Furkan Tokac

furkantokac updated this revision to Diff 36308.
furkantokac added a comment.


  V0.2
  Converted everything to qqc2. SizeHint is corrected. Tested.
  Please review it. After your review, I'll also enable the Acceleration 
Profile with this patch.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13573?vs=36236=36308

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13573

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/components/ToolTip.qml
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/resources.qrc

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13573: Touchpad KCM QtQuickControls2 Conversion

2018-06-18 Thread Furkan Tokac

furkantokac added a comment.


  @davidedmundson @mart 
  Thanks for the feedback. New patch is coming.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13573

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13573: Touchpad KCM QtQuickControls2 Conversion

2018-06-16 Thread Furkan Tokac

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13573

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13372: Mouse KCM Redesign Using Kirigami

2018-06-13 Thread Furkan Tokac

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e4ce025aa706: Mouse KCM Redesign Using Kirigami (authored 
by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13372?vs=36119=36122

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/mouse/kcm/resources.qrc

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-13 Thread Furkan Tokac

furkantokac updated this revision to Diff 36119.
furkantokac added a comment.


  V0.6
  Wayland version (main.qml) is tested (X was already tested). Corrections are 
done. Functionality is same. All the possibilities are tested. Works fine. 
Ready to push.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13372?vs=36061=36119

BRANCH
  arcpatch-D13372

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/mouse/kcm/resources.qrc

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-12 Thread Furkan Tokac

furkantokac updated this revision to Diff 36061.
furkantokac added a comment.


  V0.5
  import org.kde.plasma.core is removed for main.qml.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13372?vs=36059=36061

BRANCH
  arcpatch-D13372

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/mouse/kcm/resources.qrc

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-12 Thread Furkan Tokac

furkantokac updated this revision to Diff 36059.
furkantokac added a comment.


  V0.4
  QtQuickControls version is updated to 2.0. Some code cleaning.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13372?vs=35974=36059

BRANCH
  arcpatch-D13372

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/mouse/kcm/resources.qrc

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-11 Thread Furkan Tokac

furkantokac added a comment.


  In D13372#277078 , @mart wrote:
  
  > here a patch against this which ports it to qqc2, using the completely 
different radiobutton mechanics qqc2 uses, fixing separators, removing 
plasmacore import
  >  F5907175: qqc2.diff 
  >  with qqc2-desktop-style master, the spacing issues should be solved
  
  
  Thank you so much! I'll check it today when I back home. This will be a nice 
guide for me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-11 Thread Furkan Tokac

furkantokac added a comment.


  In D13372#277040 , @mart wrote:
  
  > for me, using qqc1 in a new kcm, is an absolute blocker, no matter what the 
problem is with qqc2, problems must be fixed, not worked around. ever.
  
  
  So please keep following the topic and help to find the best way to fix the 
problems.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-10 Thread Furkan Tokac

furkantokac updated this revision to Diff 35974.
furkantokac added a comment.


  Stupid mistake that I have done is fixed. Thank you romangg.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13372?vs=35961=35974

BRANCH
  arcpatch-D13372

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/mouse/kcm/resources.qrc

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-10 Thread Furkan Tokac

furkantokac updated this revision to Diff 35961.
furkantokac added a comment.


  V0.3
  sizeHint and minimumSizeHint are added.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13372?vs=35926=35961

BRANCH
  arcpatch-D13372

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/mouse/kcm/resources.qrc

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-09 Thread Furkan Tokac

furkantokac added a comment.


  If everyone is happy and the patch is tested, I'll push the code after a last 
test for Wayland and Xorg.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-09 Thread Furkan Tokac

furkantokac updated this revision to Diff 35926.
furkantokac added a comment.


  After a discussion, decided to go back to V0.2 because of some UI issues. Bug 
reports will be filed about the issues. For now, we'll use qqc1.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13372?vs=35908=35926

BRANCH
  arcpatch-D13372

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/mouse/kcm/resources.qrc

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-09 Thread Furkan Tokac

furkantokac added a comment.


  Just realized that paddings look bad in QQC2. Any recommendation ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-09 Thread Furkan Tokac

furkantokac added inline comments.

INLINE COMMENTS

> main.qml:251
> +id: accelProfileFlat
> +Kirigami.FormData.label: i18n("Acceleration profile:")
> +text: i18n("Flat")

This label doesn't show up. If we put it to Column, it shows up vertically 
centered. Please recommend a solution for this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-09 Thread Furkan Tokac

furkantokac updated this revision to Diff 35908.
furkantokac added a comment.


  V0.3 - QtQuickControls version is updated to 2.0. Some code cleaning.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13372?vs=35809=35908

BRANCH
  arcpatch-D13372

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/mouse/kcm/resources.qrc

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-09 Thread Furkan Tokac

furkantokac added a comment.


  In D13372#275788 , @safaalfulaij 
wrote:
  
  > Small question, why we're not using QQC2-based controls?
  
  
  Thanks! New diff is coming with QQC2-based controls.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-07 Thread Furkan Tokac

furkantokac marked an inline comment as done.
furkantokac added a comment.


  Please test the code and if everyone is happy, I'll push the code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-07 Thread Furkan Tokac

furkantokac marked an inline comment as done.
furkantokac added inline comments.

INLINE COMMENTS

> mart wrote in main.qml:31
> KCM.SimpleKCM

This is not based on KConfigModule yet so it is not okay to convert it to 
SimpleKCM since it'll look for "kcm" reference from the backend but will not be 
able to find.  It is added as TODO task to the code. After this rewrite, I am 
planning to work on the backend so that time it may be converted to

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM Redesign Using Kirigami

2018-06-07 Thread Furkan Tokac

furkantokac updated this revision to Diff 35809.
furkantokac added a comment.


  Update V0.2
  Page is converted to ScrollablePage. ExclGroupBox converted to RadioButton 
since the titling is issue with ExclGroupBox + ScrollablePage. Middle-click 
title is updated.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13372?vs=35657=35809

BRANCH
  arcpatch-D13372

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/mouse/kcm/resources.qrc

To: furkantokac, ngraham, romangg, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13372: Mouse KCM is redesigned by using Kirigami. Tested on Xorg and Wayland. Functionality is same.

2018-06-05 Thread Furkan Tokac

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13372

AFFECTED FILES
  kcms/mouse/kcm/libinput/components/ExclGroupBox.qml
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-06-04 Thread Furkan Tokac

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dd1244d66766: Touchpad KCM Redesign Using Kirigami 
(authored by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13141?vs=35554=35563

REVISION DETAIL
  https://phabricator.kde.org/D13141

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, abetts
Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-06-04 Thread Furkan Tokac

furkantokac updated this revision to Diff 35554.
furkantokac added a comment.


  Combobox is expanded. MiddleEmulayion string is changed.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13141?vs=35545=35554

BRANCH
  arcpatch-D13141

REVISION DETAIL
  https://phabricator.kde.org/D13141

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, abetts
Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-06-04 Thread Furkan Tokac

furkantokac updated this revision to Diff 35545.
furkantokac added a comment.


  Combobox is always visible. Combobox manual resizing is removed.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13141?vs=35527=35545

BRANCH
  arcpatch-D13141

REVISION DETAIL
  https://phabricator.kde.org/D13141

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, abetts
Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-06-04 Thread Furkan Tokac

furkantokac updated this revision to Diff 35527.
furkantokac added a comment.


  Tapping strings are changed. Natural scrolling string is added. If
  there is only 1 touchpad, device combobox set to insvisible.
  ScrollablePage is changed with Page.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13141?vs=35066=35527

BRANCH
  arcpatch-D13141

REVISION DETAIL
  https://phabricator.kde.org/D13141

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, abetts
Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-29 Thread Furkan Tokac

furkantokac added a comment.


  In D13141#269989 , @ngraham wrote:
  
  > Here's another idea for the multi-tapping radio button to reduce the string 
length:
  >
  >   Two-finger tap: (o) Right-click (three-finger tap to middle-click)
  >   ( ) Middle-click (three-finger tap to right-click)
  >
  
  
  Elegant! I was looking for something like this. Done :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13141

To: furkantokac, ngraham, romangg, abetts
Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-28 Thread Furkan Tokac

furkantokac added a comment.


  In D13141#269402 , @ngraham wrote:
  
  > Sadly, Libinput only allows one scrolling method to be active at once. See 
https://wayland.freedesktop.org/libinput/doc/latest/scrolling.html
  >
  > So until and unless we can change Libinput itself, this has to stay as a 
radio button.
  
  
  Thanks Nate! We can discuss the issue later then.
  
  In D13141#268894 , @abetts wrote:
  
  > In D13141#268862 , @ngraham 
wrote:
  >
  > > As for wanting to making this non-scrollable: in general, we should 
aspire for the main views of our KCMs to never require scrolling (subviews like 
tables are okay, of course). It's very awkward to able to scroll a UI that's 
packed full of UI controls. It can even introduce issues since some controls 
respond to scroll events; it becomes easy to accidentally manipulate a control 
via a scroll event when you means to just move the view. Let's shoot for 
keeping all the content fully in view with a 1024x768 window size.
  >
  >
  > I feel this is a "must". The vision is that we will empower the user to 
make changes quickly with minimal effort or digging. We already have a 3 layer 
deep system settings. Hopefully with this design, we can bring that number 
lower. Showing all settings within a window without scrolling is essential to 
that end. If you encounter a list that seems too long to fit in the space, 
bring it up to use and we can help.
  
  
  Thanks. I got the issue. Is Page fully support the mobile phones or 
small-screen devices ? I supposed that we're using ScrollablePage to support 
more/different devices because I saw that some other KCMs using ScrollablePage 
too (Font, Translation, Launch KCM etc.) Is it okay to use Page for small 
screen devices ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13141

To: furkantokac, ngraham, romangg, abetts
Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-28 Thread Furkan Tokac

furkantokac updated this revision to Diff 35066.
furkantokac added a comment.


  "NoScroll" setting is removed. Feedbacks are applied.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13141?vs=34950=35066

BRANCH
  kcmtouchpad-kirigamidesign

REVISION DETAIL
  https://phabricator.kde.org/D13141

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, abetts
Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-27 Thread Furkan Tokac

furkantokac added a comment.


  In D13141#269312 , @esedgh wrote:
  
  > Sorry guys I'm not sure if this is the appropriate place to report this as 
I'm not involved in the development.
  >
  > But now that you're at it, I may give you a bit of feedback in here.
  >
  > Touchpad settings has "Two Finger Scrolling" and "Edge Scrolling" as a 
radio button: You can choose only one.
  >
  > But why? I'm used to having both enabled. Is that not doable in the new 
stack?
  
  
  All recommendations are welcome!
  
  Very nice point. It should be as you said I think. I'll implement it if there 
is no opposite opinion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13141

To: furkantokac, ngraham, romangg, abetts
Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-26 Thread Furkan Tokac

furkantokac added inline comments.

INLINE COMMENTS

> main.qml:94
> +enabled: touchpadCount > 1
> +//Layouts.Layout.fillWidth: true
> +implicitWidth: units.gridUnit * 10

This will go if nobody tells me it is necessary. I couldn't find any use case 
that this will be important.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13141

To: furkantokac, ngraham, romangg, abetts
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-26 Thread Furkan Tokac

furkantokac added a comment.


  @romangg There are some "TODO"s in the code. Please tell me if they still 
need to be applied so I'll do them, if they are not, I'll remove them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13141

To: furkantokac, ngraham, romangg, abetts
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-26 Thread Furkan Tokac

furkantokac added a comment.

  In D13141#268853 , @ngraham wrote:

  > Is the user-facing control for the click method (areas or clickfinger) 
 going to come in a separate 
patch? It might make sense to add that feature first and then we can do all the 
UI review in a single patch.

  Yes it'll be nice to having the feature with this patch. I'll implement it.

  > Why is "acceleration profile" still disabled?

  It was like that for me all the time. @romangg is it okay to activate 
"acceleration profile" ?

  > I also have some UI suggestions:
  > 
  > - Let's try to avoid making this a scrollable page, if at all possible. If 
we can avoid that, we may be able to remove the scrollview.

  Currently the page is enough to keep everything. I'll convert it to page. 
Just want to know, why we should avoid using scrollable page ?

  > - "Emulate Middle button" -> We should come up with a less technical 
explanation for this. Suggestions welcome.

  At first, I didn't understand it too but tooltip helped. Tooltip is as 
following;
  "Clicking left and right button simultaneously sends middle button click."
  My suggestions are too long so it may not be appropriate. Lets think for 
sometime.

  > - "Acceleration" -> "Speed" or "Pointer speed"

  We can change "Acceleration" as "Speed" and "Acceleration Profile" as "Speed 
Profile". If you think that it is okay, I'll change it like that.

  > - "Two tap right, three middle" -> "Tap twice for right-click; three times 
for middle-click"
  > - "Two tap middle, three right" -> "Tap twice for middle-click; three times 
for right-click"

  Yay!

  > - I don't think anyone will ever choose "No scroll" on purpose; this would 
just be a source of bugs. Let's remove that option.

  Actually yes. I'll remove it if there is no use case found by someone.

  > In general much nicer!

  Very much thanks for your nice suggestions!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13141

To: furkantokac, ngraham, romangg, abetts
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-26 Thread Furkan Tokac

furkantokac updated this revision to Diff 34950.
furkantokac added a comment.


  Comment correction.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13141?vs=34949=34950

BRANCH
  kcmtouchpad-kirigamidesign

REVISION DETAIL
  https://phabricator.kde.org/D13141

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, abetts
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-26 Thread Furkan Tokac

furkantokac added inline comments.

INLINE COMMENTS

> main.qml:466
> +} // END Kirigami.FormLayout
> +} // END KCM.SimpleKCM

This comment will be changed as "END Kirigami.ScrollablePage"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13141

To: furkantokac, ngraham, romangg, abetts
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-26 Thread Furkan Tokac

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REVISION SUMMARY
  Touchpad KCM is redesigned in Kirigami. Tested in 
  Wayland+Libinput and Xorg+Libinput. Works fine.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmtouchpad-kirigamidesign

REVISION DETAIL
  https://phabricator.kde.org/D13141

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-23 Thread Furkan Tokac

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:de742972bf31: Workspace KCM Code Improvement (authored by 
furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12974?vs=34656=34759

REVISION DETAIL
  https://phabricator.kde.org/D12974

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: mart, davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12974: Workspace KCM Code Improvement

2018-05-22 Thread Furkan Tokac

furkantokac updated this revision to Diff 34656.
furkantokac added a comment.


  .qrc file is cancelled.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12974?vs=34652=34656

BRANCH
  kcmworkspace-CodeFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12974

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: mart, davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12974: Workspace KCM Code Improvement

2018-05-22 Thread Furkan Tokac

furkantokac updated this revision to Diff 34652.
furkantokac added a comment.


  Changes are done according to feedbacks. For detailed information,
  please check the commit message.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12974?vs=34499=34652

BRANCH
  kcmworkspace-CodeFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12974

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/resources.qrc
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, ngraham, romangg, #plasma
Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-22 Thread Furkan Tokac

furkantokac marked 8 inline comments as done.
furkantokac added inline comments.

INLINE COMMENTS

> davidedmundson wrote in workspaceoptions.cpp:97
> We want to batch our syncs to plasmarc, which the old code did better.
> 
> I wouldn't bother trying to be clever with checking if it's the original 
> state or not here, as KConfig will do all of that for us anyway at a more 
> correct lower level.

Nice point. I tested the situation for the old code. When I just change 
single/double click option, other option files (plasmarc) are not opened. That 
means KConfig handles the situation. Thank you. Correction will be done now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12973: Workspace KCM Redesign Using Kirigami

2018-05-21 Thread Furkan Tokac

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:78cd8bb31ea3: Workspace KCM Redesign Using Kirigami 
(authored by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12973?vs=34500=34616

REVISION DETAIL
  https://phabricator.kde.org/D12973

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12973: Workspace KCM Redesign Using Kirigami

2018-05-19 Thread Furkan Tokac

furkantokac updated this revision to Diff 34500.
furkantokac added a comment.


  Comment correction.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12973?vs=34459=34500

BRANCH
  kcmworkspace-Redesign

REVISION DETAIL
  https://phabricator.kde.org/D12973

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Furkan Tokac

furkantokac marked 3 inline comments as done.
furkantokac added inline comments.

INLINE COMMENTS

> zzag wrote in workspaceoptions.cpp:37
> I think you could do something like this in the header file
> 
>   class ...  {
>   ...
>   m_stateToolTip = true;
>   m_stateVisualFeedback = true;
>   m_stateSingleClick = true;
>   ...
>   };

This one is more clear imho because they are not optional initializations, they 
are must so we emphasize that.

> zzag wrote in workspaceoptions.cpp:180
> I would remove it. It doesn't add any useful information. I don't see any 
> word about commets in the kdelibs coding style(I assume Plasma follows it) 
> but as a rule of thumb: comment things that are not obvious.
> 
> For example, see 
> https://google.github.io/styleguide/cppguide.html#Implementation_Comments

Actually this is optional. Not a big issue. Makes it easier to follow. 
Specifically for this patch, it's okay imho.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Furkan Tokac

furkantokac updated this revision to Diff 34499.
furkantokac added a comment.


  State variable names are changed. Some formatting improvements.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12974?vs=34458=34499

BRANCH
  kcmworkspace-CodeFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12974

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, ngraham, romangg, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Furkan Tokac

furkantokac added a comment.


  In D12974#264920 , @ngraham wrote:
  
  > While we're doing some formatting and style cleanup work, how about 
renaming some variables? For example `m_ostateToolTip` and 
`m_ostateVisualFeedback` aren't very descriptive IMHO. Maybe instead, they 
could be `m_currentToolTipState` and `m_currentVisualFeedbackState`.
  
  
  So they'll be changed as
  m_toolTipCurrentState m_toolTipOriginalState etc.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12973: Workspace KCM Redesign and Formatting Improvement

2018-05-18 Thread Furkan Tokac

furkantokac updated this revision to Diff 34459.
furkantokac added a comment.


  Workspace KCM is redesigned by using Kirigami.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12973?vs=34454=34459

BRANCH
  kcmworkspace-Redesign

REVISION DETAIL
  https://phabricator.kde.org/D12973

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-18 Thread Furkan Tokac

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REVISION SUMMARY
  Code formatting is improved. "save" function is improved by preventing 
unnecessary file open and file write.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmworkspace-CodeFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12974

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions.cpp

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12973: Workspace KCM Redesign and Formatting Improvement

2018-05-18 Thread Furkan Tokac

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmWorkspaceFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12973

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

2018-05-18 Thread Furkan Tokac

furkantokac added inline comments.

INLINE COMMENTS

> zzag wrote in workspaceoptions.cpp:110
> Coding style nitpick: No whitespace after `(` and before `)`. Also, I 
> believe, there should be a whitespace between control statement keyword and 
> opening parentheses.

Done. Thanks. I avoid small changes for better diff revision so now I'm 
reviewing the whole patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12946: Single/Double Click Option at Workspace KCM

2018-05-17 Thread Furkan Tokac

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d3ef895516fe: Single/Double Click Option at Workspace KCM 
(authored by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12946?vs=34382=34393

REVISION DETAIL
  https://phabricator.kde.org/D12946

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12936: Rewrite workspace KCM in QtQuick

2018-05-17 Thread Furkan Tokac

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:856f58955aec: Rewrite workspace KCM in QtQuick (authored 
by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12936?vs=34357=34387

REVISION DETAIL
  https://phabricator.kde.org/D12936

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/mainpage.ui
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.desktop
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma
Cc: zzag, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12946: Single/Double Click Option at Workspace KCM

2018-05-17 Thread Furkan Tokac

furkantokac updated this revision to Diff 34382.
furkantokac added a comment.


  QDBus is reorganized. Implementation is clear now.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12946?vs=34381=34382

BRANCH
  bug393547-SingleDoubleClickClicking

REVISION DETAIL
  https://phabricator.kde.org/D12946

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12946: Single/Double Click Option at Workspace KCM

2018-05-17 Thread Furkan Tokac

furkantokac updated this revision to Diff 34381.
furkantokac added a comment.


  Qml padding added. Some small fixes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12946?vs=34380=34381

BRANCH
  bug393547-SingleDoubleClickClicking

REVISION DETAIL
  https://phabricator.kde.org/D12946

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12946: Single/Double Click Option at Workspace KCM

2018-05-17 Thread Furkan Tokac

furkantokac updated this revision to Diff 34380.
furkantokac added a comment.


  QDBus is organized.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12946?vs=34379=34380

BRANCH
  bug393547-SingleDoubleClickClicking

REVISION DETAIL
  https://phabricator.kde.org/D12946

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12946: Single/Double Click Option at Workspace KCM

2018-05-17 Thread Furkan Tokac

furkantokac updated this revision to Diff 34379.
furkantokac added a comment.


  Single/Double click implementation is done. Tested. Everything
  is working fine.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12946?vs=34370=34379

BRANCH
  bug393547-SingleDoubleClickClicking

REVISION DETAIL
  https://phabricator.kde.org/D12946

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12946: Single/Double Click Option at Workspace KCM

2018-05-17 Thread Furkan Tokac

furkantokac added inline comments.

INLINE COMMENTS

> romangg wrote in main.qml:90
> Just: `onSingleClickChanged: singleClick.checked = kcm.singleClick;`

This is not okay. If singleclick is not set initially, doubleclick radio button 
should be enabled. This code doesn't to that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12946

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

2018-05-17 Thread Furkan Tokac

furkantokac updated this revision to Diff 34357.
furkantokac added a comment.


  Bug fixed about checkbox check states.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12936?vs=34354=34357

BRANCH
  bug393547-SingleDoubleClickFunc

REVISION DETAIL
  https://phabricator.kde.org/D12936

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/mainpage.ui
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.desktop
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

2018-05-17 Thread Furkan Tokac

furkantokac updated this revision to Diff 34354.
furkantokac added a comment.


  kcm.cpp and kcm.h files are renamed as workspaceoptions.cpp and 
workspaceoptions.h to preserve the git history better.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12936?vs=34353=34354

BRANCH
  bug393547-SingleDoubleClickFunc

REVISION DETAIL
  https://phabricator.kde.org/D12936

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/mainpage.ui
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.desktop
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

2018-05-17 Thread Furkan Tokac

furkantokac updated this revision to Diff 34353.
furkantokac added a comment.


  kcm.cpp and kcm.h files are renamed as workspaceoptions.cpp and 
workspaceoptions.h to preserve the git history better.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12936?vs=34351=34353

BRANCH
  bug393547-SingleDoubleClickFunc

REVISION DETAIL
  https://phabricator.kde.org/D12936

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/mainpage.ui
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.desktop
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

2018-05-17 Thread Furkan Tokac

furkantokac updated this revision to Diff 34351.
furkantokac marked 16 inline comments as done.
furkantokac added a comment.


  Bracked style correction. Removed translation data in ".desktop" files.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12936?vs=34343=34351

BRANCH
  bug393547-SingleDoubleClickFunc

REVISION DETAIL
  https://phabricator.kde.org/D12936

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh
  kcms/workspaceoptions/kcm.cpp
  kcms/workspaceoptions/kcm.h
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/mainpage.ui
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.desktop
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

2018-05-16 Thread Furkan Tokac

furkantokac added a comment.


  In D12936#263969 , @ngraham wrote:
  
  > Please follow standard KDE style for braces in new code:
  >
  >   void myFunction() {
  >   int stuff = 1;
  >   }
  >
  
  
  According to Kdelibs Coding Style 
, functions and 
classes should be
  
void fun()
{
}
  
  like this. Did I miss a point ?

INLINE COMMENTS

> ngraham wrote in kcm.cpp:51
> Why are these within braces?

To make the

  const KConfigGroup cg(config, QStringLiteral("PlasmaToolTips"));

this definition local.

> ngraham wrote in kcm.cpp:133
> How about `handleNeedsSave()` instead?

Makes more sense :) Done.

> ngraham wrote in ToolTip.qml:2
> If this code is used in multiple KCMs, we shouldn't duplicate it; we should 
> upstream it so that it only needs to exist in one place at a time.

It can be reused. I'll delete it now (new patch is coming) then we can talk 
about it for the other patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: kcm_workspace is finished.

2018-05-16 Thread Furkan Tokac

furkantokac updated this revision to Diff 34343.
furkantokac added a comment.


  Rewrite workspace KCM in QtQuick

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12936?vs=34332=34343

BRANCH
  bug393547-SingleDoubleClickFunc

REVISION DETAIL
  https://phabricator.kde.org/D12936

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh
  kcms/workspaceoptions/kcm.cpp
  kcms/workspaceoptions/kcm.h
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/mainpage.ui
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.desktop
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, romangg, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: kcm_workspace is finished.

2018-05-16 Thread Furkan Tokac

furkantokac added a comment.


  In D12936#263939 , @ngraham wrote:
  
  > In D12936#263907 , @furkantokac 
wrote:
  >
  > > In D12936#263886 , 
@davidedmundson wrote:
  > >
  > > > Can you change the title to something more specific.
  > >
  > >
  > > There will be other options so that time it will make more sense I think 
(see the ss). Maybe we can change it to "General Workspace Settings". If you 
have any suggestion, you're welcome.
  > >  F5852492: Screenshot_20180517_015512.png 

  >
  >
  > David meant the title of the patch, not the title of the KCM. :)
  
  
  Got it :) I fixed "Default" button and some important things and applied the 
suggestions. Update is coming.

INLINE COMMENTS

> kcm.cpp:42
> +
> +setToolTip(true);
> +}

This is unnecessary. Just ignore it.

> ngraham wrote in ExclGroupBox.qml:1
> Is this file actually used at all?

ExclGroupBox.qml and ToolTip.qml are not used now but they'll be used. I forgot 
to remove them.

> davidedmundson wrote in ToolTip.qml:2
> is this copy pasted from somewhere?

Yeap it's Roman's implementation used in "input" kcm. Shouldn't I use it ?

> davidedmundson wrote in main.qml:24
> this is unused in every file

Actually it is used. It has "units" in it.

Example

  Layouts.ColumnLayout {
  id: maincol
  spacing: units.largeSpacing

> davidedmundson wrote in main.qml:37
> why is here a column inside a columnlayout?

Items under the "Column" has smallSpacing. Items under the "ColumnLayout" has 
largeSpacing. Otherwise, it looks bad.

> davidedmundson wrote in main.qml:43
> i18n

Thanks, fixing...

> davidedmundson wrote in metadata.desktop:105-107
> remove all X-Plasma lines

I'm removing.
Can you explain why ? Just want to learn.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: kcm_workspace is finished.

2018-05-16 Thread Furkan Tokac

furkantokac added a comment.

  In D12936#263894 , @ngraham wrote:

  > BTW, here are a couple of formatting rules you should follow: 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

  Oh I know it but just forgot. Editing. Thanks.

  In D12936#263886 , @davidedmundson 
wrote:

  > Can you change the title to something more specific.

  There will be other options so that time it will make more sense I think (see 
the ss). Maybe we can change it to "General Workspace Settings". If you have 
any suggestion, you're welcome.
  F5852492: Screenshot_20180517_015512.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: kcm_workspace is finished.

2018-05-16 Thread Furkan Tokac

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REVISION SUMMARY
  kcm_workspaceoptions is changed as kcm_workspace.
  It is rewritten in QML, ConfigModule.
  ToolTip and VisualFeedback added.
  All features are tested.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  bug393547-SingleDoubleClickFunc

REVISION DETAIL
  https://phabricator.kde.org/D12936

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh
  kcms/workspaceoptions/kcm.cpp
  kcms/workspaceoptions/kcm.h
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/mainpage.ui
  kcms/workspaceoptions/package/contents/ui/ExclGroupBox.qml
  kcms/workspaceoptions/package/contents/ui/ToolTip.qml
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.desktop
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

83 matches

Mail list logo