D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. @ngraham is there an admin that can review this or should I abandon and make a MR on gitlab? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n,

D29827: Give users the ability to disable the microphone indicator

kurmikon abandoned this revision. kurmikon added a comment. https://invent.kde.org/plasma/plasma-pa/-/merge_requests/2 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29827 To: kurmikon, ngraham, #vdg, #plasma Cc: kmaterka, davidedmundson, meven,

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. In D29827#673551 , @ngraham wrote: > The name needs to be your full name ("Firstname Lastname"). This was a pre-existing requirement, it's just now enforced before patch submission, rather than afterwards. I

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. In D29827#673541 , @bcooksley wrote: > You are being rejected because those commits were made using a name that appears to just be a first name - you will need to amend your user.name in your Git configuration and

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. In D29827#673539 , @ngraham wrote: > You need to push to your fork of the `plasma-pa` repo, not the main location. `git push fork` should do it if you've set up your fork with the name `fork` as described in

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. @ngraham I'm following instructions, but push is rejected: remote: Push declined - commits failed audit REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29827 To: kurmikon, ngraham, #vdg, #plasma Cc: ngraham,

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. In D29827#673534 , @ngraham wrote: > What email? Huh? The page you linked say I have to send an email. Anyway, I'm able to use git, but I don't get how to push my modification in my branch on my personal

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. @ngraham I'm sending the email, but the system reject the request. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29827 To: kurmikon, ngraham, #vdg, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29827: Give users the ability to disable the microphone indicator

kurmikon created this revision. kurmikon added reviewers: ngraham, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Plasma is an high customizable desktop environment. When it comes to system

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon updated this revision to Diff 82966. kurmikon added a comment. Diff updated to a better version. So, I'm explaining what happens here. A RowLayout is placed where the old slider was. This contains a new slider and an additional spinbox. The spinbox gets float values by the

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#671289 , @ngraham wrote: > Typically would would bind both to the same backend value and everything would just magically work. However the code in this KCM is terrible, and is quite imperative, without using

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#671270 , @ngraham wrote: > Actually sorry, I won't get to that refactor soon so I don't want to block your work. > > Is this reviewable in its current state? Can you explain how I can improve this

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon added a comment. In D29431#669402 , @ngraham wrote: > Got confirmation from @davidedmundson that this is okay. Can you provide an email address so I can land your patch with correct git authorship information? kurmi...@libero.it

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon marked an inline comment as done. kurmikon added a comment. @ngraham No reply after one week. I think this can be merged. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29431 To: kurmikon, #plasma, #vdg Cc: davidedmundson, ngraham, plasma-devel,

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#40 , @ngraham wrote: > Indeed, the code here is a catastrophe. I'm actually in the middle of a rewrite to make everything more declarative which should make UI changes much easier. If you'd like to wait a

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon updated this revision to Diff 82323. kurmikon added a comment. So I worked on this. It's not easy to me to do this stuff since the slider and the spinbox have to synchronize themselves on the other one. Making symply and update from one to another would lead to infinite

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#664091 , @ngraham wrote: > I like @ndavis's idea of using a slider and a spinbox. The slider can be used for coarse adjustment, while the spinbox can be used for fine-tuning and have a very fine step size. I

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon updated this revision to Diff 82001. kurmikon added a comment. Removed stepsize property, default value 1. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29431?vs=81946=82001 REVISION DETAIL https://phabricator.kde.org/D29431 AFFECTED

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663827 , @ndavis wrote: > I had a look at the documentation for libinput pointer acceleration (https://wayland.freedesktop.org/libinput/doc/latest/pointer-acceleration.html). For anyone following this

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663671 , @ndavis wrote: > In D29365#663395 , @ngraham wrote: > > > Of course the problem with a spinbox is that by displaying numbers, it demands some kind of

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon added a comment. In D29431#663581 , @ngraham wrote: > Maybe we went too far in the direction of efficiency at the expense of familiarity, because the 24px step size suggests inaccurately that intermediate values can't be entered?

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663597 , @ngraham wrote: > Hmm, 0% as a lower value would imply no movement speed, which is obviously not possible here. As far as I know, libinput manages acceleration rather speed. Let's change the

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. Another solution. Spinbox 0% to 100%. -1 is 0% and 1 is 100%. Libinput default 0 will set 50%. // Acceleration RowLayout { Controls.SpinBox { Kirigami.FormData.label: i18nd("kcm_touchpad", "Pointer speed:") id: accelSpeed

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon added a comment. In D29431#663558 , @davidedmundson wrote: > That doesn't explain why we're changing the step size. > > No-one wants to click the up arrow 100 times. I have to set 101 and the default is 96. The arrow are

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Since the spinbox read and write the DPI value "as is", without performing any format change, there's no need to set a stepsize

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

kurmikon abandoned this revision. kurmikon added a comment. No changes needed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29422 To: kurmikon, bport, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

kurmikon added a comment. In D29422#663389 , @ngraham wrote: > How does subpixel hinting work without anti-aliasing? Good question. I thought they were independent because fontconfig has an hinting option that can be set true or false in

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663395 , @ngraham wrote: > Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc.

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

kurmikon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Now kcm fontconfig has **subpixel rendering** and **hintstyle** options depending on **antialiasing**. This means if I disable

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. Pulseaudio is an abstraction layer over alsa. You, as a developer, can record sources in many ways, but since it's an abstraction layer, you can't be really sure whether the source is a microphone or not. There's a discussion on github where a user was asking

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. In D29312#662773 , @mart wrote: > i think i would prefer a somewhat inaccurate message, rather than an obscuretecnicism which is technically accurate ( I don't agree, but what do you suggest considering that now

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon updated this revision to Diff 81847. kurmikon added a comment. The spinbox would be better a better solution. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29365?vs=81755=81847 REVISION DETAIL https://phabricator.kde.org/D29365

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Plasma System settings can set only 11 values for touchpad acceleration. The option accept a float number between -1 and 1 but,

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. @nicolasfella if an application is recording directly from an input device (a simple microphone), your hint would be the solution: we should check and exclude sink source monitors. This way PulseEffects would be correctly excluded. But I was thinking a special

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. In D29312#660704 , @nicolasfella wrote: > In D29312#660702 , @kurmikon wrote: > > > In D29312#660670 , @nicolasfella wrote: >

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. In D29312#660670 , @nicolasfella wrote: > > but due to a lack in qt libraries > > Can you elaborate on this? What is Qt lacking? I'm not an expert, so I don't really know. Reading the bug report, there's no

D29312: Change microphoneindicator for reporting audio monitors

kurmikon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Microphone indicator was introduced to report applications using a microphone. That wasn't a bad idea, but due to a lack in