D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

2020-06-08 Thread Henri Chain
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6cd25ded9934: Add a new standalone executable to replace X-KDE-Autostart-Condition (authored by hchain). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28305: WIP: Systemd Startup

2020-04-17 Thread Henri Chain
hchain added inline comments. INLINE COMMENTS > plasma-core@.target:3 > +Description=KDE Plasma Workspace Core > +Wants=plasma-plasmashell.service plasma-kwin_%i.service > plasma-kcminit.service plasma-kded.service plasma-kcminit-phase1.service > +Requires=plasma-ksmserver.service can we make

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

2020-03-30 Thread Henri Chain
hchain created this revision. hchain added reviewers: davidedmundson, broulik, dfaure, ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hchain requested review of this revision. REVISION SUMMARY For systemd autostart generator will add a

D28305: WIP: Systemd Startup

2020-03-26 Thread Henri Chain
hchain added inline comments. INLINE COMMENTS > startplasma.cpp:404 > +startPlasmaSession.start(QStringLiteral(CMAKE_INSTALL_FULL_BINDIR > "/plasma_session"), plasmaSessionOptions); > +rc = startPlasmaSession.waitForStarted(); > +#else unrelated change ? REPOSITORY R120 Plasma

D28305: WIP: Systemd Startup

2020-03-26 Thread Henri Chain
hchain added inline comments. INLINE COMMENTS > hchain wrote in plasmawayland-dev.desktop.cmake:2 > does that still work in legacy (non-systemd) mode ? original patch https://phabricator.kde.org/D19004 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28305

D28305: WIP: Systemd Startup

2020-03-26 Thread Henri Chain
hchain added inline comments. INLINE COMMENTS > apol wrote in plasmawayland-dev.desktop.cmake:2 > Is this change related? does that still work in legacy (non-systemd) mode ? > apol wrote in org.kde.plasmashell.desktop.cmake:55 > We probably want it always hidden? maybe add a comment that this