Re: Review Request 106911: ksmserver should ignore non-executable files under ~/.kde4/Autostart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106911/ --- (Updated Sept. 24, 2016, 10:04 a.m.) Status -- This change has been discarded. Review request for Plasma and Luboš Luňák. Bugs: 286658 http://bugs.kde.org/show_bug.cgi?id=286658 Repository: kde-workspace Description --- It does not make sense to feed non-executable files to krun, since that folder is named as "Autostart", which expects executable files. Those .desktop files might be exception to the above rule, but I don't know whether the current situation of supporting .desktop under ~/.kde4/Autostart is an intentional or incidental feature. Diffs - ksmserver/startup.cpp d99ce4c Diff: https://git.reviewboard.kde.org/r/106911/diff/ Testing --- Thanks, Jekyll Wu
Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/ --- (Updated Sept. 22, 2016, 8:33 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 188494 http://bugs.kde.org/show_bug.cgi?id=188494 Repository: kdeplasma-addons Description --- What the current konquerorsessions plugin does is eventually calling "konqueror --profile xyz", so it is really for the profile feature of konqueror, not the session feature of konqueoror. The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review. Diffs - runners/CMakeLists.txt bb4b491 runners/konquerorprofiles/CMakeLists.txt PRE-CREATION runners/konquerorprofiles/Messages.sh PRE-CREATION runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd PRE-CREATION runners/konquerorsessions/CMakeLists.txt be2ea9d runners/konquerorsessions/Messages.sh 0720e1e runners/konquerorsessions/konquerorsessions.cpp f2e437a runners/konquerorsessions/konquerorsessions.desktop df81780 runners/konquerorsessions/konquerorsessions.h 957f976 Diff: https://git.reviewboard.kde.org/r/107868/diff/ Testing --- Thanks, Jekyll Wu
Re: Review Request 107869: Add a real konquerorsessions plugin for krunner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/ --- (Updated Sept. 22, 2016, 8:33 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 188494 http://bugs.kde.org/show_bug.cgi?id=188494 Repository: kdeplasma-addons Description --- This is a follow-up of https://git.reviewboard.kde.org/r/107868/ . The code is based upon the old and unreal konquerorsessions plugin, with minimal modification (since I'm not familiar with krunner plugins) to make it work in the way as its name implies. The patch can't be uploaded as diff, since it depends upon the patch in https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See the attached file below. Diffs - Diff: https://git.reviewboard.kde.org/r/107869/diff/ Testing --- File Attachments the patch https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch Thanks, Jekyll Wu
Re: [RFC] Disable bug reporting till Bugzilla situation is improved
于 2013年05月26日 18:05, Martin Graesslin 写道: Hi all, this is probably a controversial proposal: Let's disable bug reporting for Plasma until the current situation is improved. Reason: the bugtracker in it's current state gets flooded by new incoming reports and we are not able to get the water out of our cellar as long as new water is coming in. So let's put a plug into the leaking pipe and then start to get the water out and let's fix the leak properly and then turn on the water again. I don't know whether it's possible (need to talk to sysadmins), but I would keep it open for kde devs, so that we would get reports for newly introduced regressions/bugs in master. This has to be absolutely temporarily and should be stopped before the release of 4.11. If I had to set a hard date I would say June, 26th, which is the beta 2 release. Opinions? Cheers Martin Hi, I think this is surely better than let's acknowledge the mess, close all existing bugs and restart from zero. But still I think it is a dangerous action which might cause anger, flames and rants. What about organizing a plasma bug days(or weeks) as usual (when was the last one?), then announce and apply that no new bugs any more as a temporary policy only for and during that organized event ? My point is not accepting new bugs is so easy to be misinterpreted by the users and press. Let's cover it up with a better name. Regards Jekyll ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla
On May 24, 2013, 9:44 p.m., Jekyll Wu wrote:
Bugzilla itself (since 4.2.5) already rejects any attempt against disabled
versions. So even without this patch, DrKonqi users won't be able to create
crash report against disabled versions in the end. From developers POV, you
don't need to worry about that.
The problem is usability for users. I'm not sure this reused error dialog
is more informative than the existing one in
https://bugs.kde.org/attachment.cgi?id=78600action=edit. So I'm against
this patch in its current simple form.
As said in [1][2], I'm working on a patch for the usability improvement and
plan to make it into 4.11. I will create a review request today or
tomorrow.
[1] https://bugs.kde.org/show_bug.cgi?id=315073#c3
[2] https://bugs.kde.org/show_bug.cgi?id=318769#c1
Martin Gräßlin wrote:
Bugzilla itself (since 4.2.5) already rejects any attempt against
disabled versions.
Bugzilla does blcok, but DrKonqi still reports them as unknown version.
I know it because I see the crash reports coming in
Martin Gräßlin wrote:
So I'm against this patch in its current simple form.
Are you also against into backporting it to prevent that we stop getting
useless crash reports? I worked on this for fixing a real world problem. Just
look at:
https://bugs.kde.org/buglist.cgi?list_id=661927bug_severity=crashchfieldto=Nowquery_format=advancedchfield=[Bug%20creation]chfieldfrom=2013-01-01version=unspecifiedlongdesc=kwin%20%284.8product=kwinlongdesc_type=allwordssubstr
All crashes reported this year against KWin 4.8.
Yes the dialog might not be best, but I cannot change it because it's in
string freeze. I agree that for 4.11 something better should be done, but
this is more for 4.10 and older (especially older).
Ben Cooksley wrote:
Perhaps it might be worth requesting a string freeze exemption here?
Martin Gräßlin wrote:
Perhaps it might be worth requesting a string freeze exemption here?
We would need that from each and every distribution. It doesn't help that
KDE did the freeze exception and Debian is then not accepting the patch
because it violates their policy.
Those reports are all from KDE SC 4.8.5, where kwin version (using
KDE_VERSION_STRING) was in the strange form of 4.8.5 (4.8.5) . For some
strange reason I'm still not aware of, bugs.kde.org fails to reject reports
with that kind of version (probably due the space in the version) as it should
have. I'm well aware of those reports which shouldn't have been accepted at the
first place (since I'm subscribed to kde-bugs-dist@), but I haven't got the
time to do a good investigation. Anyway, those escaped crash reports are
definitely the race cases.
I understand you are annoyed by those kwin crash reports from 4.8.5, but
backporting this simple patch won't help you much: the DrKonqi from KDE SC
4.8.x simply don't contain the code of fetching version info from bugs.kde.org
through the Product.get webservice API, so backing this simple patch to 4.8.x
is useless. I added those code not long time ago, as the necessary base of my
final goal of preventing outdated crash reports.
So if your goal is not seeing those kwin 4.8.5 crash reports anymore, there are
two quick solutions:
1. apply this simple drkonqi patch to 4.10.x, then ask distribution
packagers(I'm think of Debian Stable) to ship DrKonqi from KDE SC 4.10.4
together with other components from KDE SC 4.8.4/5. I'm not sure how
distribution packagers will think of this kind of mixture.
2. prepare a one-line patch to make kwin from KDE 4.8.5 use version 4.8.5
explicitly, instead of using KDE_VERSION_STRING. That way, bugs.kde.org itself
will reject those crash reports as it has done for 4.9.{0,1,2,3} . Then ask
distribution packers to apply this kwin one-line patch. I think this is more
acceptable for distribution packagers. Or maybe that one line patch should be
created against kdelibs, changing KDE_VERSION_STRING to the plain 4.8.5 ?
- Jekyll
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110633/#review33110
---
On May 24, 2013, 2:54 p.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110633/
---
(Updated May 24, 2013, 2:54 p.m.)
Review request for KDE Runtime, Plasma, Ben Cooksley, and Myriam
Schweingruber.
Description
---
Bugzilla provides a feature to disable versions. This means that the
developers do not want to have further reports for this version. Any crash
report is by that not helpful any more. So let's just disable reporting
crashes
Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla
On May 24, 2013, 9:44 p.m., Jekyll Wu wrote:
Bugzilla itself (since 4.2.5) already rejects any attempt against disabled
versions. So even without this patch, DrKonqi users won't be able to create
crash report against disabled versions in the end. From developers POV, you
don't need to worry about that.
The problem is usability for users. I'm not sure this reused error dialog
is more informative than the existing one in
https://bugs.kde.org/attachment.cgi?id=78600action=edit. So I'm against
this patch in its current simple form.
As said in [1][2], I'm working on a patch for the usability improvement and
plan to make it into 4.11. I will create a review request today or
tomorrow.
[1] https://bugs.kde.org/show_bug.cgi?id=315073#c3
[2] https://bugs.kde.org/show_bug.cgi?id=318769#c1
Martin Gräßlin wrote:
Bugzilla itself (since 4.2.5) already rejects any attempt against
disabled versions.
Bugzilla does blcok, but DrKonqi still reports them as unknown version.
I know it because I see the crash reports coming in
Martin Gräßlin wrote:
So I'm against this patch in its current simple form.
Are you also against into backporting it to prevent that we stop getting
useless crash reports? I worked on this for fixing a real world problem. Just
look at:
https://bugs.kde.org/buglist.cgi?list_id=661927bug_severity=crashchfieldto=Nowquery_format=advancedchfield=[Bug%20creation]chfieldfrom=2013-01-01version=unspecifiedlongdesc=kwin%20%284.8product=kwinlongdesc_type=allwordssubstr
All crashes reported this year against KWin 4.8.
Yes the dialog might not be best, but I cannot change it because it's in
string freeze. I agree that for 4.11 something better should be done, but
this is more for 4.10 and older (especially older).
Ben Cooksley wrote:
Perhaps it might be worth requesting a string freeze exemption here?
Martin Gräßlin wrote:
Perhaps it might be worth requesting a string freeze exemption here?
We would need that from each and every distribution. It doesn't help that
KDE did the freeze exception and Debian is then not accepting the patch
because it violates their policy.
Jekyll Wu wrote:
Those reports are all from KDE SC 4.8.5, where kwin version (using
KDE_VERSION_STRING) was in the strange form of 4.8.5 (4.8.5) . For some
strange reason I'm still not aware of, bugs.kde.org fails to reject reports
with that kind of version (probably due the space in the version) as it
should have. I'm well aware of those reports which shouldn't have been
accepted at the first place (since I'm subscribed to kde-bugs-dist@), but I
haven't got the time to do a good investigation. Anyway, those escaped
crash reports are definitely the race cases.
I understand you are annoyed by those kwin crash reports from 4.8.5, but
backporting this simple patch won't help you much: the DrKonqi from KDE SC
4.8.x simply don't contain the code of fetching version info from
bugs.kde.org through the Product.get webservice API, so backing this simple
patch to 4.8.x is useless. I added those code not long time ago, as the
necessary base of my final goal of preventing outdated crash reports.
So if your goal is not seeing those kwin 4.8.5 crash reports anymore,
there are two quick solutions:
1. apply this simple drkonqi patch to 4.10.x, then ask distribution
packagers(I'm think of Debian Stable) to ship DrKonqi from KDE SC 4.10.4
together with other components from KDE SC 4.8.4/5. I'm not sure how
distribution packagers will think of this kind of mixture.
2. prepare a one-line patch to make kwin from KDE 4.8.5 use version
4.8.5 explicitly, instead of using KDE_VERSION_STRING. That way,
bugs.kde.org itself will reject those crash reports as it has done for
4.9.{0,1,2,3} . Then ask distribution packers to apply this kwin one-line
patch. I think this is more acceptable for distribution packagers. Or maybe
that one line patch should be created against kdelibs, changing
KDE_VERSION_STRING to the plain 4.8.5 ?
Martin Gräßlin wrote:
Or maybe that one line patch should be created against kdelibs,
changing KDE_VERSION_STRING to the plain 4.8.5 ?
That's the place where it needs to be done, I think. KWin doesn't set a
version number it uses KDE_VERSION_STRING. On the other hand fixing in
kdelibs won't fix the problem as it would require to recompile everything.
This is btw. not just a problem for KWin (that's just what I am familiar
with), it applies to all software from KDE SC. The problem of 4.8.4 and 4.8.5
is common in the complete workspaces and it's not going to go away as it's
the version used in Debian Stable and Ubuntu LTS.
Would creating versions 4.8.4 (4.8.4) and 4.8.5 (4.8.5) in bugzilla
fix the problem?
I already created and disabled those (kwin
Re: [RFC] Closing outdated crash reports
On 2013年05月25日 15:19, Martin Graesslin wrote: Hi all, Plasma has many open crash reports for outdated versions [1]. I would suggest to close them all as: a) Stack traces most likely do not match any more b) It's quite likely that it's a duplicate c) Users can easily reopen if it's still valid with latest version d) If it's a crash and still valid it will be reported again (given enough eyes...) I like the idea in general, but the suggested bug list is a little dangerous (meaning it might cause very bad public image) : 1. it contains quite a few CONFIRMED and REOPENED reports, so closing them will certainly make users angry and be reopened again later. For such reports, we could ask can someone try and see whether it is still valid in 4.10.3 ? but really should not close it and wait for angry users to shout and reopen it. 2. it contains quite a few reports with high amount of comments or duplicates. Again, bad candidates for closing. I would suggest using this bug list[1] as the base. [1] https://bugs.kde.org/buglist.cgi?list_id=662021bug_severity=crashcolumnlist=product%2Ccomponent%2Cassigned_to%2Cbug_status%2Clongdescs.count%2Cdupecount%2Cresolution%2Cshort_desc%2Cchangeddatequery_format=advancedbug_status=UNCONFIRMEDversion=unspecifiedversion=4.5%20and%20olderversion=4.6.0version=4.6.1version=4.6.2version=4.6.3version=4.6.4version=4.6.5version=4.7.0version=4.7.1version=4.7.2version=4.7.3version=4.7.4version=4.8.0version=4.8.1version=4.8.2version=4.8.3version=4.9-gitversion=4.7.90version=4.7.95version=4.8.80%20%28beta1%29version=4.7.80version=4.7.97version=4.8.4version=4.8.90%20%28beta2%29version=4.8.95%20%28RC1%29version=4.8.97%28RC2%29version=4.9.0version=4.8.5version=4.9.1version=4.9.2version=4.9.3version=4.9.80%20Beta1version=4.9.90%20Beta2version=4.9.95%20RC1version=4.9.97%20RC2version=4.9.98%20RC3product=plasma ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla
On May 24, 2013, 9:44 p.m., Jekyll Wu wrote:
Bugzilla itself (since 4.2.5) already rejects any attempt against disabled
versions. So even without this patch, DrKonqi users won't be able to create
crash report against disabled versions in the end. From developers POV, you
don't need to worry about that.
The problem is usability for users. I'm not sure this reused error dialog
is more informative than the existing one in
https://bugs.kde.org/attachment.cgi?id=78600action=edit. So I'm against
this patch in its current simple form.
As said in [1][2], I'm working on a patch for the usability improvement and
plan to make it into 4.11. I will create a review request today or
tomorrow.
[1] https://bugs.kde.org/show_bug.cgi?id=315073#c3
[2] https://bugs.kde.org/show_bug.cgi?id=318769#c1
Martin Gräßlin wrote:
Bugzilla itself (since 4.2.5) already rejects any attempt against
disabled versions.
Bugzilla does blcok, but DrKonqi still reports them as unknown version.
I know it because I see the crash reports coming in
Martin Gräßlin wrote:
So I'm against this patch in its current simple form.
Are you also against into backporting it to prevent that we stop getting
useless crash reports? I worked on this for fixing a real world problem. Just
look at:
https://bugs.kde.org/buglist.cgi?list_id=661927bug_severity=crashchfieldto=Nowquery_format=advancedchfield=[Bug%20creation]chfieldfrom=2013-01-01version=unspecifiedlongdesc=kwin%20%284.8product=kwinlongdesc_type=allwordssubstr
All crashes reported this year against KWin 4.8.
Yes the dialog might not be best, but I cannot change it because it's in
string freeze. I agree that for 4.11 something better should be done, but
this is more for 4.10 and older (especially older).
Ben Cooksley wrote:
Perhaps it might be worth requesting a string freeze exemption here?
Martin Gräßlin wrote:
Perhaps it might be worth requesting a string freeze exemption here?
We would need that from each and every distribution. It doesn't help that
KDE did the freeze exception and Debian is then not accepting the patch
because it violates their policy.
Jekyll Wu wrote:
Those reports are all from KDE SC 4.8.5, where kwin version (using
KDE_VERSION_STRING) was in the strange form of 4.8.5 (4.8.5) . For some
strange reason I'm still not aware of, bugs.kde.org fails to reject reports
with that kind of version (probably due the space in the version) as it
should have. I'm well aware of those reports which shouldn't have been
accepted at the first place (since I'm subscribed to kde-bugs-dist@), but I
haven't got the time to do a good investigation. Anyway, those escaped
crash reports are definitely the race cases.
I understand you are annoyed by those kwin crash reports from 4.8.5, but
backporting this simple patch won't help you much: the DrKonqi from KDE SC
4.8.x simply don't contain the code of fetching version info from
bugs.kde.org through the Product.get webservice API, so backing this simple
patch to 4.8.x is useless. I added those code not long time ago, as the
necessary base of my final goal of preventing outdated crash reports.
So if your goal is not seeing those kwin 4.8.5 crash reports anymore,
there are two quick solutions:
1. apply this simple drkonqi patch to 4.10.x, then ask distribution
packagers(I'm think of Debian Stable) to ship DrKonqi from KDE SC 4.10.4
together with other components from KDE SC 4.8.4/5. I'm not sure how
distribution packagers will think of this kind of mixture.
2. prepare a one-line patch to make kwin from KDE 4.8.5 use version
4.8.5 explicitly, instead of using KDE_VERSION_STRING. That way,
bugs.kde.org itself will reject those crash reports as it has done for
4.9.{0,1,2,3} . Then ask distribution packers to apply this kwin one-line
patch. I think this is more acceptable for distribution packagers. Or maybe
that one line patch should be created against kdelibs, changing
KDE_VERSION_STRING to the plain 4.8.5 ?
Martin Gräßlin wrote:
Or maybe that one line patch should be created against kdelibs,
changing KDE_VERSION_STRING to the plain 4.8.5 ?
That's the place where it needs to be done, I think. KWin doesn't set a
version number it uses KDE_VERSION_STRING. On the other hand fixing in
kdelibs won't fix the problem as it would require to recompile everything.
This is btw. not just a problem for KWin (that's just what I am familiar
with), it applies to all software from KDE SC. The problem of 4.8.4 and 4.8.5
is common in the complete workspaces and it's not going to go away as it's
the version used in Debian Stable and Ubuntu LTS.
Would creating versions 4.8.4 (4.8.4) and 4.8.5 (4.8.5) in bugzilla
fix the problem?
Jekyll Wu wrote:
I already created
Re: Fwd: [Bugsquad] Something for the bugsquad :)
On 2013年05月24日 17:55, Aaron J. Seigo wrote: If instead we look for people who might be motivated to do some meaningful triaging, things could improve. I'm sorry, but I really don't think that would work (so easily) . It is not that there were no such motivated contributors in the past. In fact, there were many .The problem is that (according to my personal experience and observation of other people's activity ) they sooner (the common case) or later(the rare case) get frustrated and lose the interest, faith and energy with dealing with plasma bugs. It is not necessarily that they give up with the whole bugs.kde.org. They might just give up with the plasma product and turn to help other products. I would like raise the question: why the plasma product is so inclined to frustrate bug triagers ? My bold answer is : plasma developers expect contributors to do most work for them, while contributors see themselves as helpers instead of bug masters. And when those contributors later realize they care bug reports more seriously than the developers do, they just get frustrated, lose the confidence and stop helping the plasma product. Myriam is a well known bug triager. She has tried hard to help the plasma product, then gave up. I once also tried hard, but now basically give up, too, except filling missing version information of crash reports for my personal interest. By the way, the plasma product has just became #1 in bugs.kde.org, which should have happened long time ago if without kdepope's ongoing work. I really respect kdepepo's patience, but I think it would be more beneficial if he puts more of his excellent knowledge and limited time onto other products. So if you want to recruit more contributors to help the plasma product on bugs.kde.org, the only feasible way in my opinion is work hard on it by yourselves and prove to existing, potential and previous contributors that you care about bug reports more seriously than they do. Unless this culture and impression gets changed, I bet bugzilla contributors are destined to get frustrated and give up with the plasma product, no matter how many you manage to recruit . Regards Jekyll ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: [Bugsquad] Something for the bugsquad :)
On 2013年05月25日 20:59, Martin Graesslin wrote: My aims are: * get the number of bugs down without having humans looking at the reports * reduce the number of bugs coming in Now that plasma-desktop uses KDE_VERSION_STRING (since 4.10.3) instead of the never changing stone 0.4 version, we can make use of bugzilla's new feature of rejecting reports against disabled versions to reduce received crash reports. Since the plasma product is already receiving too many reports, I think it can apply a very strict policy with active versions: only make the current stable and current development version active. That means only making 4.10.3(current stable) and 4.10.60 (current development) active. Actually, since all plasma-desktops form KDE SC 4.10.2 and older use the same 0.4 version, we can simply add and disable that 0.4 version. Once that simple operation is done, plasma product won't receive any plamsa-desktop crash report from KDE SC 4.10.2 and older. I generally won't recommend such a strict or rude policy, but that is indeed one option if really needed. * filter out new bugs quicker (I have some ideas especially for crashes) would like to hear about that. * introduce more components Yes, one component for each plasmoid * assign maintainers to the components assign each component to the fake plasma-compont-b...@kde.org user, and add real maintainer and plasma-b...@kde.org into default CC list of each component. We all know the horrible traffic brought by watching plasma-b...@kde.org. Divide and conqueror. Seriously, I always wonder how many plasma developers are watching plasma-b...@kde.org ? No blame, I just think the horrible traffic would easily defeat most watchers. Never make real users as the default assignee, because that only causes trouble for maintain-ship handover, and make bug watching painful (assume I'm the default assignee of kickoff component and super active in the whole bugs.kde.org ,but some potential contributor is currently only interested with kickoff bugs...) * get the maintainers to care;-) My impression is many components/plasmoids just do not have dedicate maintainer, or has some no longer active maintainer. Regards Jekyll ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110633/#review33110 --- Bugzilla itself (since 4.2.5) already rejects any attempt against disabled versions. So even without this patch, DrKonqi users won't be able to create crash report against disabled versions in the end. From developers POV, you don't need to worry about that. The problem is usability for users. I'm not sure this reused error dialog is more informative than the existing one in https://bugs.kde.org/attachment.cgi?id=78600action=edit. So I'm against this patch in its current simple form. As said in [1][2], I'm working on a patch for the usability improvement and plan to make it into 4.11. I will create a review request today or tomorrow. [1] https://bugs.kde.org/show_bug.cgi?id=315073#c3 [2] https://bugs.kde.org/show_bug.cgi?id=318769#c1 - Jekyll Wu On May 24, 2013, 2:54 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110633/ --- (Updated May 24, 2013, 2:54 p.m.) Review request for KDE Runtime, Plasma, Ben Cooksley, and Myriam Schweingruber. Description --- Bugzilla provides a feature to disable versions. This means that the developers do not want to have further reports for this version. Any crash report is by that not helpful any more. So let's just disable reporting crashes for such bugs. If this change gets accepted I intend to backport it to 4.10 and to inform kde-packagers about it to ship it as an update to *all* version they support. This would automatically prevent most duplicates report we get e.g. for KWin. Diffs - drkonqi/reportinterface.cpp 4190c40 Diff: http://git.reviewboard.kde.org/r/110633/diff/ Testing --- See https://bugs.kde.org/show_bug.cgi?id=320217 - the bug was created with version 4.10.60. Afterward the version got disabled and DrKonqi doesn't allow me to report crashes for this version anymore. File Attachments With it disabled http://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/drkonqi-disabled.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 109906: Make plasma-desktop and krunner use KDE_VERSION_STRING instead of some never changing version.
=chfieldfrom=2008-01-01chfieldto=Nowj_top=ANDf1=noopo1=noopv1=format=tableaction=wrap Diffs - krunner/main.cpp c3dd560 plasma/desktop/shell/main.cpp 225eec2 Diff: http://git.reviewboard.kde.org/r/109906/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Rename krunner plugin konsolesessions to konsoleprofiles
On Jan. 7, 2013, 10:49 a.m., Aaron J. Seigo wrote: i can understand changing the visible name, but why change the plugin name and the rest of it? that's an implementation detail, and while the name used may be technically wrong it is both a smaller change as well as a safer change to leave them as-is. each kconfig update script is something that needs to be processed at runtime, which must be present to provide an upgrade path, etc. so imo only the user visible strings should be altered and the reset should remain as-is. I can see your concern of upgrading (especially for those who compile and install KDE manually instead of using package manager (like emerge) to ensure clean removal of previously installed files). Maybe one dummy konsolesessions.desktop (only containing Hidden=True) should also be installed to avoid users seeing both konsole profiles and konsole sessions in krunner. But the reason I want to also change the reset is not for users, but for developers/contributors, especially for those (including myself) who are not familiar with the history of those runners and just want to investigate and fix some bug quickly from time to time. If I just change the user visible name, then there will be a konsoleseesions/ subfolder providing krunner_konsolesessions.so and konsolesessions.desktop, yet its visual name is konsole profiles , and its entry within krunnerrc is konsolesessionsEnabled, and what it does is konsole profiles. That is just confusing(even more than now) to random contributors. Unless someone digs the code, commit history and this review request, he/she can hardly understand why he/she is seeing such a strange combination. That even does not take into account all those names styled after sessions instead of profiles within the existing code. - Jekyll --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107881/#review24884 --- On Dec. 31, 2012, 6:58 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107881/ --- (Updated Dec. 31, 2012, 6:58 p.m.) Review request for Plasma. Description --- Konsole currently does not provide the session feature like in kate and konqueror. That plugin works with konsole profiles, not the not-reimplemented-yet konsole sessions. Also, the equivalent plasmoid is properly named as konsole profiles. Diffs - runners/CMakeLists.txt bb4b491 runners/konsoleprofiles/CMakeLists.txt PRE-CREATION runners/konsoleprofiles/Messages.sh PRE-CREATION runners/konsoleprofiles/konsoleprofiles.cpp PRE-CREATION runners/konsoleprofiles/konsoleprofiles.desktop PRE-CREATION runners/konsoleprofiles/konsoleprofiles.h PRE-CREATION runners/konsoleprofiles/konsolesessions_renamed_to_konsoleprofiles.upd PRE-CREATION runners/konsolesessions/CMakeLists.txt c1d5cea runners/konsolesessions/Messages.sh 5f03904 runners/konsolesessions/konsolesessions.cpp ed7550a runners/konsolesessions/konsolesessions.desktop 7d9ce5a runners/konsolesessions/konsolesessions.h a98c253 Diff: http://git.reviewboard.kde.org/r/107881/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Rename krunner plugin konsolesessions to konsoleprofiles
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107881/ --- (Updated Dec. 31, 2012, 6:58 p.m.) Review request for Plasma. Changes --- Add kconf_update script Description --- Konsole currently does not provide the session feature like in kate and konqueror. That plugin works with konsole profiles, not the not-reimplemented-yet konsole sessions. Also, the equivalent plasmoid is properly named as konsole profiles. Diffs (updated) - runners/CMakeLists.txt bb4b491 runners/konsoleprofiles/CMakeLists.txt PRE-CREATION runners/konsoleprofiles/Messages.sh PRE-CREATION runners/konsoleprofiles/konsoleprofiles.cpp PRE-CREATION runners/konsoleprofiles/konsoleprofiles.desktop PRE-CREATION runners/konsoleprofiles/konsoleprofiles.h PRE-CREATION runners/konsoleprofiles/konsolesessions_renamed_to_konsoleprofiles.upd PRE-CREATION runners/konsolesessions/CMakeLists.txt c1d5cea runners/konsolesessions/Messages.sh 5f03904 runners/konsolesessions/konsolesessions.cpp ed7550a runners/konsolesessions/konsolesessions.desktop 7d9ce5a runners/konsolesessions/konsolesessions.h a98c253 Diff: http://git.reviewboard.kde.org/r/107881/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107868/ --- (Updated Dec. 31, 2012, 7:12 p.m.) Review request for Plasma. Changes --- Add kconf_update script Description --- What the current konquerorsessions plugin does is eventually calling konqueror --profile xyz, so it is really for the profile feature of konqueror, not the session feature of konqueoror. The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review. This addresses bug 188494. http://bugs.kde.org/show_bug.cgi?id=188494 Diffs (updated) - runners/CMakeLists.txt bb4b491 runners/konquerorprofiles/CMakeLists.txt PRE-CREATION runners/konquerorprofiles/Messages.sh PRE-CREATION runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd PRE-CREATION runners/konquerorsessions/CMakeLists.txt be2ea9d runners/konquerorsessions/Messages.sh 0720e1e runners/konquerorsessions/konquerorsessions.cpp f2e437a runners/konquerorsessions/konquerorsessions.desktop df81780 runners/konquerorsessions/konquerorsessions.h 957f976 Diff: http://git.reviewboard.kde.org/r/107868/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Rename krunner plugin konsolesessions to konsoleprofiles
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107881/ --- Review request for Plasma. Description --- Konsole currently does not provide the session feature like in kate and konqueror. That plugin works with konsole profiles, not the not-reimplemented-yet konsole sessions. Also, the equivalent plasmoid is properly named as konsole profiles. Diffs - runners/CMakeLists.txt bb4b491 runners/konsoleprofiles/CMakeLists.txt PRE-CREATION runners/konsoleprofiles/Messages.sh PRE-CREATION runners/konsoleprofiles/konsoleprofiles.cpp PRE-CREATION runners/konsoleprofiles/konsoleprofiles.desktop PRE-CREATION runners/konsoleprofiles/konsoleprofiles.h PRE-CREATION runners/konsolesessions/CMakeLists.txt c1d5cea runners/konsolesessions/Messages.sh 5f03904 runners/konsolesessions/konsolesessions.cpp ed7550a runners/konsolesessions/konsolesessions.desktop 7d9ce5a runners/konsolesessions/konsolesessions.h a98c253 Diff: http://git.reviewboard.kde.org/r/107881/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107868/ --- Review request for Plasma. Description --- What the current konquerorsessions plugin does is eventually calling konqueror --profile xyz, so it is really for the profile feature of konqueror, not the session feature of konqueoror. The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review. This addresses bug 188494. http://bugs.kde.org/show_bug.cgi?id=188494 Diffs - runners/CMakeLists.txt bb4b491 runners/konquerorprofiles/CMakeLists.txt PRE-CREATION runners/konquerorprofiles/Messages.sh PRE-CREATION runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION runners/konquerorsessions/CMakeLists.txt be2ea9d runners/konquerorsessions/Messages.sh 0720e1e runners/konquerorsessions/konquerorsessions.cpp f2e437a runners/konquerorsessions/konquerorsessions.desktop df81780 runners/konquerorsessions/konquerorsessions.h 957f976 Diff: http://git.reviewboard.kde.org/r/107868/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Add a real konquerorsessions plugin for krunner
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107869/ --- Review request for Plasma. Description --- This is a follow-up of https://git.reviewboard.kde.org/r/107868/ . The code is based upon the old and unreal konquerorsessions plugin, with minimal modification (since I'm not familiar with krunner plugins) to make it work in the way as its name implies. The patch can't be uploaded as diff, since it depends upon the patch in https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See the attached file below. This addresses bug 188494. http://bugs.kde.org/show_bug.cgi?id=188494 Diffs - Diff: http://git.reviewboard.kde.org/r/107869/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make sure ksmserver ignores excluded apps when saving session
On Nov. 11, 2012, 11:13 a.m., Aaron J. Seigo wrote: ksmserver/server.cpp, line 939 http://git.reviewboard.kde.org/r/107276/diff/1/?file=94565#file94565line939 why not check for both program and filename? that should then catch 1, 2 and 4, no? excludeApps could also be pre-processed to include both long paths and filenames which would then allow catching all 4 variations. probably the reason this was written to only catch 1 and 4, however, was in case there were binaries of the same name in different paths that should be treated differently (allowing differentiation by full path).. Lubos will certainly have more insight on this, however. probably the reason this was written to only catch 1 and 4, however, was in case there were binaries of the same name in different paths that should be treated differently (allowing differentiation by full path).. I think that is a valid case, but I also think it is rare. I prefer to first fix this more common problem with a simple patch, and wait to see how many users will notice and complain this rare case not working any more. - Jekyll --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/#review21816 --- On Dec. 9, 2012, 7:50 a.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/ --- (Updated Dec. 9, 2012, 7:50 a.m.) Review request for kdelibs, Plasma and Luboš Luňák. Description --- It is easy to understand why the existing code (usually) fails: * Users are most likely to just specify short names, like dolphin,gwenview,okular,rekonq, instead of /usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq * When ksmserver saves the session, it usually gets the full names, like /usr/bin/dolphin, unless you have started that dolphin instance by typing dolphin exactly in a shell. So there are four possible combinations : 1). config uses short name, runtime gets short name (this guy starts everything from konsole, never using kio/krun) 2). config uses short name, runtime gets long name (I think this is the most common one) 3). config uses long name, runtime gets short name 4). config uses long name, runtime gets long name (I guess some users use this combination because they find only that way works after trying various workaround...) The existing code works with 1) and 4), the patch now works with 1), 2) and 4) . I don't know whether it make senses to support all combinations . This addresses bug 242760. http://bugs.kde.org/show_bug.cgi?id=242760 Diffs - ksmserver/server.cpp a65b35a Diff: http://git.reviewboard.kde.org/r/107276/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make sure ksmserver ignores excluded apps when saving session
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/ --- (Updated Dec. 9, 2012, 7:50 a.m.) Review request for kdelibs, Plasma and Luboš Luňák. Changes --- update the patch to also work with condition 4) update the description to reflect the patch change Description (updated) --- It is easy to understand why the existing code (usually) fails: * Users are most likely to just specify short names, like dolphin,gwenview,okular,rekonq, instead of /usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq * When ksmserver saves the session, it usually gets the full names, like /usr/bin/dolphin, unless you have started that dolphin instance by typing dolphin exactly in a shell. So there are four possible combinations : 1). config uses short name, runtime gets short name (this guy starts everything from konsole, never using kio/krun) 2). config uses short name, runtime gets long name (I think this is the most common one) 3). config uses long name, runtime gets short name 4). config uses long name, runtime gets long name (I guess some users use this combination because they find only that way works after trying various workaround...) The existing code works with 1) and 4), the patch now works with 1), 2) and 4) . I don't know whether it make senses to support all combinations . This addresses bug 242760. http://bugs.kde.org/show_bug.cgi?id=242760 Diffs (updated) - ksmserver/server.cpp a65b35a Diff: http://git.reviewboard.kde.org/r/107276/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: [rssnow] Revert the commit of merging left right arrows into one
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107557/ --- Review request for Plasma and Giorgos Tsiapaliokas. Description --- There is good analyses in https://bugs.kde.org/show_bug.cgi?id=299516#c8 . I really don't understand the rationale behind merging left arrow and right arrow into one. So I just ask for reverting commit 39f506cbb10b08f4c6f8e17048deae9da87812b3. This addresses bug 299516. http://bugs.kde.org/show_bug.cgi?id=299516 Diffs - applets/rssnow/CMakeLists.txt 72be160 applets/rssnow/arrows.svgz 9816b5a4408faaa0ba3dfc4c64c877bcee0a9337 applets/rssnow/left.svgz PRE-CREATION applets/rssnow/right.svgz PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107557/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Bug 310611] Missing accelerators in QML lock screen
https://bugs.kde.org/show_bug.cgi?id=310611 Jekyll Wu adap...@gmail.com changed: What|Removed |Added Component|ui |locker-qml Version|git |4.9.80 Beta1 Assignee|l.lu...@kde.org |plasma-devel@kde.org Product|ksmserver |kscreensaver -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Bug 310871] Screen always locks (requires password) even if not supposed to
https://bugs.kde.org/show_bug.cgi?id=310871 Jekyll Wu adap...@gmail.com changed: What|Removed |Added Version|unspecified |4.9.80 Beta1 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Bug 310611] Missing accelerators in QML lock screen
https://bugs.kde.org/show_bug.cgi?id=310611 Jekyll Wu adap...@gmail.com changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Bug 310871] Screen always locks (requires password) even if not supposed to
https://bugs.kde.org/show_bug.cgi?id=310871 Jekyll Wu adap...@gmail.com changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Make sure ksmserver ignores excluded apps when saving session
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/ --- Review request for kdelibs, Plasma and Luboš Luňák. Description --- It is easy to understand why the existing code (usually) fails: * Users are most likely to just specify short names, like dolphin,gwenview,okular,rekonq, instead of /usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq * When ksmserver saves the session, it usually gets the full names, like /usr/bin/dolphin, unless you have started that dolphin instance by typing dolphin exactly in a shell. So there are four possible combinations : 1). config uses short name, runtime gets short name (this guy starts everything from konsole, never using kio/krun) 2). config uses short name, runtime gets long name (I think this is the most common one) 3). config uses long name, runtime gets short name 4). config uses long name, runtime gets long name (I guess some users use this combination because they find only that way works after trying various workaround...) The existing code works with 1) and 4), this patch works with 1) and 2) . I don't know whether it make senses to support all combinations This addresses bug 242760. http://bugs.kde.org/show_bug.cgi?id=242760 Diffs - Diff: http://git.reviewboard.kde.org/r/107276/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make sure ksmserver ignores excluded apps when saving session
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/ --- (Updated Nov. 10, 2012, 12:45 p.m.) Review request for kdelibs, Plasma and Luboš Luňák. Changes --- Forgot uploading the patch Description --- It is easy to understand why the existing code (usually) fails: * Users are most likely to just specify short names, like dolphin,gwenview,okular,rekonq, instead of /usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq * When ksmserver saves the session, it usually gets the full names, like /usr/bin/dolphin, unless you have started that dolphin instance by typing dolphin exactly in a shell. So there are four possible combinations : 1). config uses short name, runtime gets short name (this guy starts everything from konsole, never using kio/krun) 2). config uses short name, runtime gets long name (I think this is the most common one) 3). config uses long name, runtime gets short name 4). config uses long name, runtime gets long name (I guess some users use this combination because they find only that way works after trying various workaround...) The existing code works with 1) and 4), this patch works with 1) and 2) . I don't know whether it make senses to support all combinations This addresses bug 242760. http://bugs.kde.org/show_bug.cgi?id=242760 Diffs (updated) - ksmserver/server.cpp eb3ac18 Diff: http://git.reviewboard.kde.org/r/107276/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: ksmserver should ignore non-executable files under ~/.kde4/Autostart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106911/ --- Review request for Plasma and Luboš Luňák. Description --- It does not make sense to feed non-executable files to krun, since that folder is named as Autostart, which expects executable files. Those .desktop files might be exception to the above rule, but I don't know whether the current situation of supporting .desktop under ~/.kde4/Autostart is an intentional or incidental feature. This addresses bug 286658. http://bugs.kde.org/show_bug.cgi?id=286658 Diffs - ksmserver/startup.cpp d99ce4c Diff: http://git.reviewboard.kde.org/r/106911/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop
On Aug. 14, 2012, 10:58 a.m., Sebastian Kügler wrote: Did you forget to add the patch to the preview? My stupid mistake :( - Jekyll --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/#review17368 --- On Aug. 12, 2012, 8:28 a.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/ --- (Updated Aug. 12, 2012, 8:28 a.m.) Review request for Plasma. Description --- This bug report is quite similar to bug 285350, so the proposed patch is similar and simple . This addresses bug 304805. http://bugs.kde.org/show_bug.cgi?id=304805 Diffs - Diff: http://git.reviewboard.kde.org/r/105989/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/ --- (Updated Aug. 14, 2012, 11:06 a.m.) Review request for Plasma. Changes --- upload the patch Description --- This bug report is quite similar to bug 285350, so the proposed patch is similar and simple . This addresses bug 304805. http://bugs.kde.org/show_bug.cgi?id=304805 Diffs (updated) - plasma/desktop/containments/desktop/desktop.cpp e5e02c0 Diff: http://git.reviewboard.kde.org/r/105989/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/ --- (Updated Aug. 14, 2012, 12:54 p.m.) Review request for Plasma. Changes --- use !event-text().trimmed().isEmpty() to make the checking more readable Description --- This bug report is quite similar to bug 285350, so the proposed patch is similar and simple . This addresses bug 304805. http://bugs.kde.org/show_bug.cgi?id=304805 Diffs (updated) - plasma/desktop/containments/desktop/desktop.cpp e5e02c0 Diff: http://git.reviewboard.kde.org/r/105989/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Do not trigger krunner when the Space key is pressed in desktop
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/ --- Review request for Plasma. Description --- This bug report is quite similar to bug 285350, so the proposed patch is similar and simple . This addresses bug 304805. http://bugs.kde.org/show_bug.cgi?id=304805 Diffs - Diff: http://git.reviewboard.kde.org/r/105989/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Make sure kmenuedit use predictable order for showing Name and Description between various invocations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105769/ --- Review request for Plasma. Description --- The cause is simple: two flags m_detailedMenuEntries and m_detailedEntriesNamesFirst are never explicitly initialized. So their values are random, and the final results are unpredictable. The patch simply initializes both as true, since that seems to be the default behavior of kickoff. The git history shows those two flags seem to be something left over from the KDE3 era. Maybe they should just be removed from the code. However, I'm not familiar with the code and the history, so this simple patch should be safe choice. This addresses bug 304177. http://bugs.kde.org/show_bug.cgi?id=304177 Diffs - kmenuedit/treeview.cpp 54feff7 Diff: http://git.reviewboard.kde.org/r/105769/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Do not disable the Delete action after deleting one item
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105778/ --- Review request for Plasma. Description --- I fail to figure out from the existing code the intention of disabling the Delete action after deleting one item. Maybe for the edge case of the last item being deleted? But the patched code works well in that edge case, too. The git history does not provide much hint. Those lines of disabling those actions were written and last updated almost ten year ago. This addresses bug 296682. http://bugs.kde.org/show_bug.cgi?id=296682 Diffs - kmenuedit/treeview.cpp d0e6553 Diff: http://git.reviewboard.kde.org/r/105778/diff/ Testing --- I haven't noticed any problem after applying this patch. Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix the wrong usage of Keywords in one .dekstop file
On July 14, 2012, 8:38 p.m., Greg T wrote: Why didn't you replace the commas in the localized keyword entrys? Because those localized entries are supposed to be updated by scripty(in other words, the translation teams). IIRC, If I modify those localized entries manually, scripty will simply remove them later. - Jekyll --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review15859 --- On July 13, 2012, 2:49 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated July 13, 2012, 2:49 p.m.) Review request for Plasma. Description --- It is similar to review 105553. According to the FDO specification[1][2], the type of Keywords is localestring(s), where multiple values are separated by a semicolon. The affected two .desktop files use comma instead of semicolon to separate multiple values. That seems to be the expected behavior for X-KDE-Keywords, but not for Keywords. The patch simply uses semicolon and adds the trailing semicolon. [1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html [2] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html Diffs - applets/microblog/plasma-applet-microblog.desktop b8d3864 Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fix the wrong usage of Keywords in some .dekstop files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105553/ --- Review request for Plasma. Description --- According to the FDO specification[1][2], the type of Keywords is localestring(s), where multiple values are separated by a semicolon. The affected two .desktop files use comma instead of semicolon to separate multiple values. That seems to be the expected behavior for X-KDE-Keywords, but not for Keywords. The patch simply uses semicolon and adds the trailing semicolon. [1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html [2] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html Diffs - plasma/generic/applets/batterymonitor/metadata.desktop 9a520ee plasma/generic/applets/lock_logout/metadata.desktop 6d90856 Diff: http://git.reviewboard.kde.org/r/105553/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fix the wrong usage of Keywords in one .dekstop file
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- Review request for Plasma. Description --- It is similar to review 105553. According to the FDO specification[1][2], the type of Keywords is localestring(s), where multiple values are separated by a semicolon. The affected two .desktop files use comma instead of semicolon to separate multiple values. That seems to be the expected behavior for X-KDE-Keywords, but not for Keywords. The patch simply uses semicolon and adds the trailing semicolon. [1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html [2] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html Diffs - applets/microblog/plasma-applet-microblog.desktop b8d3864 Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105483/ --- (Updated July 9, 2012, 12:27 p.m.) Review request for KDE Runtime, Plasma, Ivan Čukić, and George Kiagiadakis. Changes --- add plasma into groups Description (updated) --- There is now the kactivities product in BKO (corresponding to the kactivities repository where kactivitymanagerd lives) So I think DrKonqi should forward the crashes of kactivitymanagerd to the kactivies product. Diffs - drkonqi/data/mappings 147bcdc Diff: http://git.reviewboard.kde.org/r/105483/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: ksysguard.deskstop shoud not use generic name System Monitor for its Name key
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105338/ --- Review request for Plasma and John Tapsell. Description --- Currently, ksysguard.desktop contains Name=System Monitor and GenericName=System Monitor. FOD specification[1] writes: NameSpecific name of the application, for example Mozilla. GenericName Generic name of the application, for example Web Browser. So I think using a generic name like System Monitor for Name is problematic. The current situation of using the same generic name for both Name and GenericName is also questionable. The patch simply uses KSysGuard for the Name key . [1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys Diffs - ksysguard/gui/ksysguard.desktop 7e8ff32 Diff: http://git.reviewboard.kde.org/r/105338/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
