Re: Review Request 110504: Group tasks by activity
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110504/
---
(Updated Sept. 22, 2016, 8:35 p.m.)
Status
--
This change has been discarded.
Review request for Plasma.
Repository: kde-workspace
Description
---
New grouping strategy was created to allow tasks to be grouped by activity.
If an item is available in multiple activities, it will only appear in one of
the activities the task is available on (except if it's available on all
activities).
GroupManager was modified so that whether items should be grouped just when the
task bar is full or not is not only taken into account when grouping by program
but also when grouping by activity.
Activity icons are not handled yet, so an icon from the first task which was on
the group is used as the icon of the task group.
Diffs
-
libs/taskmanager/CMakeLists.txt 70fa791
libs/taskmanager/groupmanager.h ad4167a
libs/taskmanager/groupmanager.cpp 9ac15e7
libs/taskmanager/strategies/activitygroupingstrategy.h PRE-CREATION
libs/taskmanager/strategies/activitygroupingstrategy.cpp PRE-CREATION
plasma/desktop/applets/tasks/tasks.cpp dbbb0cb
Diff: https://git.reviewboard.kde.org/r/110504/diff/
Testing
---
Three activities were created (named "Activity 1", "Activity 2" and "Activity
3").
One instance of KDialog was assigned to Activity 1, two instances of KDialog
were assigned to Activity 2, three instances of KDialog were assigned to
Activity 3 and one instance of KDialog was assigned both to Activities 2 & 3.
The tasks applet was executed in plasma-windowed in all activities.
Screenshot 1 & 2 show the task manager in the situation described above.
Screenshot 3 shows the same task manager after leaving only one instance of
KDialog in each activity ("Only group when taskbar is full" enabled), and
screenshot 4 shows the task manager when the tasks are the same that in
screenshot 3 but "Only group when taskbar is full" is disabled.
File Attachments
Screenshot 1
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png
Screenshot 2
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png
Screenshot 3
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png
Screenshot 4
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png
Thanks,
José Millán Soto
Re: Review Request 110504: Group tasks by activity
On May 26, 2013, 9:42 a.m., Marco Martin wrote: The libtaskmanager part is nice. However the applet is about t be replaced, so the display part would have to be redone I am aware that the tasks applet is going to be replaced soon, but most changes of this patch are in the library and not in the applet. I don't mind creating a patch for the new version of the applet to handle this grouping once the new version of the applet is available. - José --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110504/#review33145 --- On May 18, 2013, 2:13 p.m., José Millán Soto wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110504/ --- (Updated May 18, 2013, 2:13 p.m.) Review request for Plasma. Description --- New grouping strategy was created to allow tasks to be grouped by activity. If an item is available in multiple activities, it will only appear in one of the activities the task is available on (except if it's available on all activities). GroupManager was modified so that whether items should be grouped just when the task bar is full or not is not only taken into account when grouping by program but also when grouping by activity. Activity icons are not handled yet, so an icon from the first task which was on the group is used as the icon of the task group. Diffs - plasma/desktop/applets/tasks/tasks.cpp dbbb0cb libs/taskmanager/strategies/activitygroupingstrategy.cpp PRE-CREATION libs/taskmanager/groupmanager.cpp 9ac15e7 libs/taskmanager/strategies/activitygroupingstrategy.h PRE-CREATION libs/taskmanager/CMakeLists.txt 70fa791 libs/taskmanager/groupmanager.h ad4167a Diff: http://git.reviewboard.kde.org/r/110504/diff/ Testing --- Three activities were created (named Activity 1, Activity 2 and Activity 3). One instance of KDialog was assigned to Activity 1, two instances of KDialog were assigned to Activity 2, three instances of KDialog were assigned to Activity 3 and one instance of KDialog was assigned both to Activities 2 3. The tasks applet was executed in plasma-windowed in all activities. Screenshot 1 2 show the task manager in the situation described above. Screenshot 3 shows the same task manager after leaving only one instance of KDialog in each activity (Only group when taskbar is full enabled), and screenshot 4 shows the task manager when the tasks are the same that in screenshot 3 but Only group when taskbar is full is disabled. File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 110504: Group tasks by activity
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110504/ --- Review request for Plasma. Description --- New grouping strategy was created to allow tasks to be grouped by activity. If an item is available in multiple activities, it will only appear in one of the activities the task is available on (except if it's available on all activities). GroupManager was modified so that whether items should be grouped just when the task bar is full or not is not only taken into account when grouping by program but also when grouping by activity. Activity icons are not handled yet, so an icon from the first task which was on the group is used as the icon of the task group. Diffs - plasma/desktop/applets/tasks/tasks.cpp dbbb0cb libs/taskmanager/strategies/activitygroupingstrategy.cpp PRE-CREATION libs/taskmanager/groupmanager.cpp 9ac15e7 libs/taskmanager/strategies/activitygroupingstrategy.h PRE-CREATION libs/taskmanager/CMakeLists.txt 70fa791 libs/taskmanager/groupmanager.h ad4167a Diff: http://git.reviewboard.kde.org/r/110504/diff/ Testing --- Three activities were created (named Activity 1, Activity 2 and Activity 3). One instance of KDialog was assigned to Activity 1, two instances of KDialog were assigned to Activity 2, three instances of KDialog were assigned to Activity 3 and one instance of KDialog was assigned both to Activities 2 3. The tasks applet was executed in plasma-windowed in all activities. Screenshot 1 2 show the task manager in the situation described above. Screenshot 3 shows the same task manager after leaving only one instance of KDialog in each activity (Only group when taskbar is full enabled), and screenshot 4 shows the task manager when the tasks are the same that in screenshot 3 but Only group when taskbar is full is disabled. File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110413: Show in the tasks applet the activities a task is available on
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 15, 2013, 9:03 a.m.) Review request for Plasma. Changes --- New version of the patch. It solves the issues reported. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs (updated) - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110413: Show in the tasks applet the activities a task is available on
On May 15, 2013, 1:43 p.m., Aaron J. Seigo wrote: Ship It! Commited in 2ac45a07d6f4d5732219677795d0d280d2549956 (In the commit message instead I made a mistake and use the keyword FEATURE instead of REVIEW, leaving BUG where it should be FEATURE :( ) - José --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/#review32563 --- On May 15, 2013, 9:03 a.m., José Millán Soto wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 15, 2013, 9:03 a.m.) Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110413: Show in the tasks applet the activities a task is available on
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 15, 2013, 4:04 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 110453: Order tasks by activity in tasks applet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110453/ --- Review request for Plasma. Description --- A new ordering strategy ActivitySortingStrategy was created. This strategy will order elements by the activities they are available on. The ones which are available in the activities with more tasks will be displayed first. Diffs - libs/taskmanager/CMakeLists.txt 375a0d6 libs/taskmanager/groupmanager.h f7e9878 libs/taskmanager/groupmanager.cpp 45c15a9 libs/taskmanager/strategies/activitysortingstrategy.h PRE-CREATION libs/taskmanager/strategies/activitysortingstrategy.cpp PRE-CREATION plasma/desktop/applets/tasks/tasks.cpp 0a86dcf Diff: http://git.reviewboard.kde.org/r/110453/diff/ Testing --- Three activities were created (called Activity 1, 2 and 3), and several dialogs were created (the activities to which each dialog were assigned are marked by the numbers after the A in the title). Screenshot 1 shows the task manager running in plasma-windowed with grouping disabled, and the task manager being assigned to all activities. The second screenshot shows the task manager if the task manager is assigned only to Activity 1, an instance of xmessage is assigned to activity 2 and the grouping by program is active. File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img2.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110453: Order tasks by activity in tasks applet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110453/#review32589 --- I'm aware that a new version of the tasks applet is being done in QML, but most of the changes are done in the library and not in the applet itself (the only change made to the applet is to add the ordering in the Order by combobox of the config dialog), so I think this patch can be applied even if the tasks applet is going to be replaced. - José Millán Soto On May 15, 2013, 5:34 p.m., José Millán Soto wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110453/ --- (Updated May 15, 2013, 5:34 p.m.) Review request for Plasma. Description --- A new ordering strategy ActivitySortingStrategy was created. This strategy will order elements by the activities they are available on. The ones which are available in the activities with more tasks will be displayed first. Diffs - libs/taskmanager/CMakeLists.txt 375a0d6 libs/taskmanager/groupmanager.h f7e9878 libs/taskmanager/groupmanager.cpp 45c15a9 libs/taskmanager/strategies/activitysortingstrategy.h PRE-CREATION libs/taskmanager/strategies/activitysortingstrategy.cpp PRE-CREATION plasma/desktop/applets/tasks/tasks.cpp 0a86dcf Diff: http://git.reviewboard.kde.org/r/110453/diff/ Testing --- Three activities were created (called Activity 1, 2 and 3), and several dialogs were created (the activities to which each dialog were assigned are marked by the numbers after the A in the title). Screenshot 1 shows the task manager running in plasma-windowed with grouping disabled, and the task manager being assigned to all activities. The second screenshot shows the task manager if the task manager is assigned only to Activity 1, an instance of xmessage is assigned to activity 2 and the grouping by program is active. File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img2.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 110413: Show in the tasks applet the activities a task is available on
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110413: Show in the tasks applet the activities a task is available on
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 13, 2013, 11:10 a.m.) Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110413: Show in the tasks applet the activities a task is available on
On May 13, 2013, 11:18 a.m., Eike Hein wrote: This isn't a call to reject this patch (which I think is a nice idea), but FWIW: The Task Manager widget is still intended to be replaced by a QML rewrite before feature freeze, and the QML bindings to Plasma's tooltip primitive currently don't allow for a lot in the way of layouting custom content, so I might not be able to recreate this too easily there, specifally having a line break between the two bits of info (unless the tooltip subtext prop accepts rich text). That said since I already had to fork the QML ToolTip component to get window preview thumbnails in there, I guess I could always fork my way further out of that dilemma. In libplasma2 QML ToolTips are fortunately going to be much more flexible, ending the need for a fork. Eike Hein wrote: Turns out that throwing a br/ in there is no problem, so this is easy to sync up with after all. If that's the case, I suppose I should do a commit which includes the changes in TaskItem but not the changes in WindowTaskItem. Am I right? - José --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/#review32437 --- On May 13, 2013, 11:10 a.m., José Millán Soto wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 13, 2013, 11:10 a.m.) Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
