D16611: Fix build with libc++

ktatunov added a comment. Could you commit this for me please? I don't have a developer account. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D16611 To: ktatunov, #plasma, #kwin, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16611: Fix build with libc++

ktatunov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ktatunov requested review of this revision. REVISION SUMMARY The build breaks with clang & libc++ because apparently libc++ doesn't transitively include so to use EPERM we need to add it

D12468: Enable anti-aliasing for user avatars

ktatunov added a comment. Could someone commit this for me please? I don't have a developer account. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D12468 To: ktatunov, #plasma, davidedmundson Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel,

D12469: Fix avatar picture aliasing and stretching in kickoff

ktatunov added a comment. Could someone commit this for me please? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12469 To: ktatunov, #plasma, mart Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12469: Fix avatar picture aliasing and stretching in kickoff

ktatunov updated this revision to Diff 32902. ktatunov added a comment. Replace `mipmap` with `sourceSize`. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12469?vs=32891=32902 REVISION DETAIL https://phabricator.kde.org/D12469 AFFECTED FILES

D12469: Fix avatar picture aliasing and stretching in kickoff

ktatunov added a comment. Thanks for the pointer. Upon further investigation it looks like setting sourceSize.width: width sourceSize.height: height instead of mipmap works well for more or less square images. However, for images that are significantly wider than they are

D12469: Fix avatar picture aliasing and stretching in kickoff

ktatunov added a comment. In D12469#252388 , @davidedmundson wrote: > why mipmap? Because smooth property is enabled by default and it's apparently not enough for a good looking image. Unless I'm missing something, nothing else is

D12469: Fix avatar picture aliasing and stretching in kickoff

ktatunov created this revision. ktatunov added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ktatunov requested review of this revision. REVISION SUMMARY QML Image element has some smoothing when scaling an image by

D12468: Enable anti-aliasing for user avatars

ktatunov updated this revision to Diff 32890. ktatunov added a comment. Qt::IgnoreAspectRatio -> Qt::KeepAspectRatio REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12468?vs=32880=32890 REVISION DETAIL https://phabricator.kde.org/D12468 AFFECTED

D12468: Enable anti-aliasing for user avatars

ktatunov added a comment. In D12468#252342 , @davidedmundson wrote: > why ignore aspect ratio? I kept the default behaviour for this argument since it wasn't what I was after. But now that you mention it it would probably be better to

D12468: Enable anti-aliasing for user avatars

ktatunov created this revision. ktatunov added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ktatunov requested review of this revision. REVISION SUMMARY By default, QT uses fast transformations when scaling pixmaps