D27866: Make it compile against qt5.15. ::unite is deprecated.

2020-03-08 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:9e3f9fb2c8cb: Make it compile against qt5.15. ::unite is 
deprecated. (authored by mlaurent).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27866?vs=77016=77246

REVISION DETAIL
  https://phabricator.kde.org/D27866

AFFECTED FILES
  src/advancedconfig.cpp
  src/advancedconfig.h
  src/sddmkcm.cpp
  src/themeconfig.cpp
  src/themeconfig.h

To: mlaurent, davidedmundson, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27866: Make it compile against qt5.15. ::unite is deprecated.

2020-03-07 Thread Laurent Montel
mlaurent added a comment.


  ping ?:)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27866

To: mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27866: Make it compile against qt5.15. ::unite is deprecated.

2020-03-05 Thread Laurent Montel
mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Make it compile against qt5.15

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  build_against_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27866

AFFECTED FILES
  src/advancedconfig.cpp
  src/advancedconfig.h
  src/sddmkcm.cpp
  src/themeconfig.cpp
  src/themeconfig.h

To: mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Laurent Montel
mlaurent added a comment.


  So you review all patch from all repo ? :) awesome ! I am not able to do it! 
And I don't want to do it otherwise no possible to work on my projects.
  But I am happy that you do it ! :)
  
  So for sure I will not review all patchs from framework/plasma, but I am not 
against for reviewing qt5.15 patch.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Laurent Montel
mlaurent added a comment.


  no each reviews but when you create a patch for qt5.15 as I was the only dev 
which worked on qt5.15 it was logical to add me.
  I will not subscribe for each commit in plasma/framework, for sure after 
20-30 commits I will not read them. I have ~ 200 mails by days, so for sure I 
will not be able to read them.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Laurent Montel
mlaurent added a comment.


  In D27408#613565 , @ngraham wrote:
  
  > @mlaurent ^^
  
  
  Just a question: How I can see it if nobody adds me as reviewer (if I 
remember I was the only one guys who works against qt5.15 from several months 
so why don't add me as reviewer ? )? (For sure I have some scripts for automate 
theses changes so I commit quickly it)
  
  but this patch was wrong as QOverload::of(::currentIndexChanged), was created in qt5.15 not in 
"<= qt5.15" so in qt5.15.1 it will failed when  we compile without deprecated 
methods.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27066: remove pointless ifdef

2020-01-31 Thread Laurent Montel
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  wrong as static_cast is deprecated and it will 
not work without deprecated method.
  Or you can convert it to  static_cast
  but "int" signal doesn't exist when we build without deprecarted method

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D27066

To: sitter, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26912: Use Qt5 signal syntax, format files, optimizations

2020-01-29 Thread Laurent Montel
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  seems ok for me now.
  Thanks

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26912: Use Qt5 signal syntax, format files, optimizations

2020-01-28 Thread Laurent Montel
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> autostart.cpp:64
> +connect(widget->btnProperties, ::clicked,
> +this, static_cast (Autostart::*)()>((::slotEditCMD)));
> +connect(widget->listCMD, ::itemDoubleClicked,

why double ( ?

> autostart.cpp:66
> +connect(widget->listCMD, ::itemDoubleClicked,
> +this, static_cast *)>((::slotEditCMD)));
>  

same

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26912: Use Qt5 signal syntax, format files, optimizations

2020-01-25 Thread Laurent Montel
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> addscriptdialog.cpp:39
> +QVBoxLayout *lay = new QVBoxLayout;
> +setLayout(lay);
> +QLabel *lab = new QLabel(i18n("Shell script path:"), this);

you can remove this line and adding (this) to new QVBoxLayout
... lay = new QVBoxLayout(this);

> advanceddialog.cpp:39
>  lay->addWidget(buttons);
> -setLayout( lay );
> +setLayout(lay);
>  

you can remove this line as we have = new QVBoxLayout(this);

> autostart.cpp:198
> +
> +for (const QFileInfo  : autostartdir.entryInfoList()) {
> +const QString filename = fi.fileName();

you must use qAsConst(...)

> const auto var = autostartdir.entryInfoList();


for (const ... : var) {
}

> autostart.cpp:244
>  
> -ScriptStartItem *item = new ScriptStartItem( 
> fi.absoluteFilePath(), m_scriptItem,this );
> -int typeOfStartup = 
> m_paths.indexOf((item->fileName().adjusted(QUrl::RemoveScheme | 
> QUrl::RemoveFilename).toString()) );
> +for (const QFileInfo  : autostartdir.entryInfoList()) {
> +ScriptStartItem *item = new 
> ScriptStartItem(fi.absoluteFilePath(), m_scriptItem, this);

same here

> autostart.cpp:408
>  {
> -if ( widget->listCMD->currentItem() == nullptr )
> +if (widget->listCMD->currentItem() == nullptr) {
>  return;

if (!widget...) {
}

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash

2020-01-20 Thread Laurent Montel
mlaurent closed this revision.
mlaurent added a comment.


  Done in 2 commits.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26790

To: mlaurent, apol
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein


D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash

2020-01-20 Thread Laurent Montel
mlaurent created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Make it compile without deprecated method (qt5.15)

REPOSITORY
  R169 Kirigami

BRANCH
  make_it_compile_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26790

AFFECTED FILES
  src/icon.cpp

To: mlaurent
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D26533: Add a logging category for the backend

2020-01-09 Thread Laurent Montel
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok now for me :) thanks

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26533

To: meven, apol, ngraham, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26533: Add a logging category for the backend

2020-01-08 Thread Laurent Montel
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:14
>  TransactionSet.cpp
> +libdiscover_backend_debug.cpp
>  pkui.qrc

Why adding it ? it's autogenerated so it's added by cmake directly

> CMakeLists.txt:30
> +add_library(DiscoverPackageKitNotifier MODULE PackageKitNotifier.cpp
> +libdiscover_backend_debug.cpp
> +)

Why you add this file too ? it's autogenerated by 
ecm_qt_declare_logging_category and added directly

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26533

To: meven, apol, ngraham, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26189: Port to QRandomGenerator

2019-12-23 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:161b6c42205f: Port to QRandomGenerator (authored by 
mlaurent).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26189?vs=72085=72098

REVISION DETAIL
  https://phabricator.kde.org/D26189

AFFECTED FILES
  tests/graphicssignalplotterbenchmark.cpp
  tests/signalplotterbenchmark.cpp

To: mlaurent, dfaure, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26189: Port to QRandomGenerator

2019-12-23 Thread Laurent Montel
mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QRandomGenerator

TEST PLAN
  autotest ok

REPOSITORY
  R111 KSysguard Library

BRANCH
  port_QRandomGenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26189

AFFECTED FILES
  tests/graphicssignalplotterbenchmark.cpp
  tests/signalplotterbenchmark.cpp

To: mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26063: QMultiHash::insertMulti is deprecated. Use directly ::insert

2019-12-17 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:3f2fab734574: QMultiHash::insertMulti is deprecated. Use 
directly ::insert (authored by mlaurent).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26063?vs=71700=71713

REVISION DETAIL
  https://phabricator.kde.org/D26063

AFFECTED FILES
  processui/ProcessModel.cpp

To: mlaurent, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26063: QMultiHash::insertMulti is deprecated. Use directly ::insert

2019-12-16 Thread Laurent Montel
mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  QMultiHash::insertMulti is deprecated

REPOSITORY
  R111 KSysguard Library

BRANCH
  remove_qmultihash_insertmulti (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26063

AFFECTED FILES
  processui/ProcessModel.cpp

To: mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25736: Make it compile without deprecated method

2019-12-08 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:c38b6a9f2953: Make it compile without deprecated method 
(authored by mlaurent).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25736?vs=70896=71078

REVISION DETAIL
  https://phabricator.kde.org/D25736

AFFECTED FILES
  src/qml/plugin.cpp

To: mlaurent, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25736: Make it compile without deprecated method

2019-12-07 Thread Laurent Montel
mlaurent added a comment.


  ping ?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D25736

To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25736: Make it compile without deprecated method

2019-12-04 Thread Laurent Montel
mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without deprecated method

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  compile_without_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25736

AFFECTED FILES
  src/qml/plugin.cpp

To: mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25729: Make it compile without qt deprecated method

2019-12-04 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:f32965ea3a9f: Make it compile without qt deprecated 
method (authored by mlaurent).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25729?vs=70877=70890

REVISION DETAIL
  https://phabricator.kde.org/D25729

AFFECTED FILES
  discover/DiscoverDeclarativePlugin.cpp
  discover/DiscoverObject.cpp

To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25709: Make it compile against qt5.14 without deprecated method

2019-12-04 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8eca435225b6: Make it compile against qt5.14 without 
deprecated method (authored by mlaurent).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25709?vs=70876=70891

REVISION DETAIL
  https://phabricator.kde.org/D25709

AFFECTED FILES
  plugin/kquickstyleitem.cpp
  plugin/qqc2desktopstyleplugin.cpp

To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25729: Make it compile without qt deprecated method

2019-12-03 Thread Laurent Montel
mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Compile without deprecated qt5.x method

REPOSITORY
  R134 Discover Software Store

BRANCH
  compile_against_qt514_no_deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25729

AFFECTED FILES
  discover/DiscoverDeclarativePlugin.cpp
  discover/DiscoverObject.cpp

To: mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25709: Make it compile against qt5.14 without deprecated method

2019-12-03 Thread Laurent Montel
mlaurent updated this revision to Diff 70876.
mlaurent added a comment.


  Forgot to commit it

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25709?vs=70875=70876

BRANCH
  fix_compile_qt5.14 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25709

AFFECTED FILES
  plugin/kquickstyleitem.cpp
  plugin/qqc2desktopstyleplugin.cpp

To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25709: Make it compile against qt5.14 without deprecated method

2019-12-03 Thread Laurent Montel
mlaurent updated this revision to Diff 70875.
mlaurent added a comment.


  Fix comment

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25709?vs=70808=70875

BRANCH
  fix_compile_qt5.14 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25709

AFFECTED FILES
  plugin/kquickstyleitem.cpp
  plugin/qqc2desktopstyleplugin.cpp

To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25709: Make it compile against qt5.14 without deprecated method

2019-12-03 Thread Laurent Montel
mlaurent added a comment.


  yep it seems more logical

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25709

To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25709: Make it compile against qt5.14 without deprecated method

2019-12-02 Thread Laurent Montel
mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Compile against 5.14 without deprecated method

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  fix_compile_qt5.14 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25709

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25609: Port KSMServer's KCM to KConfigXT

2019-11-29 Thread Laurent Montel
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmsmserver.h:50
>  
> +  Ui::SMServerConfigDlg *ui;
> +  SMServerSettings *m_settings;

it seems that ui is never deleted. (I can't see it deleted in destructor.)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25609

To: ervin, #plasma, mart, davidedmundson, crossi, bport, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25086: Port to KGlobalAccel

2019-11-16 Thread Laurent Montel
mlaurent added a comment.


  Did you have some problem for commiting it ?
  Regards

REPOSITORY
  R103 KMenu Editor

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D25086: Port to KGlobalAccel

2019-11-11 Thread Laurent Montel
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  for me all is ok.

REPOSITORY
  R103 KMenu Editor

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D25086: Port to KGlobalAccel

2019-11-09 Thread Laurent Montel
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  After that it seems ok for me

INLINE COMMENTS

> globalaccel.cpp:25
> +kmenueditGroup = KConfigGroup(, 
> QStringLiteral("Data_%1").arg(i));
> +if (kmenueditGroup.readEntry("Name", QString()) == 
> QStringLiteral("KMenuEdit")) {
> +foundKmenuedit = true;

QLatin1String("...") it's a minor optimization
--

> globalaccel.cpp:38
> +// only migrate the launch actions for now, not the default search 
> action
> +if (KConfigGroup(, groupName).readEntry("Type") != 
> QStringLiteral("MENUENTRY_SHORTCUT_ACTION_DATA")) {
> +continue;

same here

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D25086: [WIP] Port to KGlobalAccel

2019-11-06 Thread Laurent Montel
mlaurent added a comment.


  For me it seems ok
  
  Did you finish it ? is it work ? or still in progress ?

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-04 Thread Laurent Montel
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kglobalshortcutseditor.cpp:436
> +// Do we have an application with that name?
> +KService::List apps = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"),
> +QStringLiteral("Name == '%1' or Name == 
> '%2'").arg(id,  friendlyName));

const KService::List

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma, mlaurent
Cc: mlaurent, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25086: [WIP] Port to KGlobalAccel

2019-11-01 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> basictab.cpp:38
>  
>  #ifndef Q_OS_WIN
> +#include "globalaccel.h"

still necessary to #ifndef ?

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> globalaccel.cpp:55
> +const QList shortcut = 
> KGlobalAccel::self()->globalShortcut(desktopFile, QStringLiteral("_launch"));
> +if (shortcut.size() > 0) {
> +return shortcut[0];

if (!shortcut.isEmpty()) {

> menuinfo.cpp:180
>  if (s_deletedApps) {
>  #ifdef WITH_HOTKEYS
>  // Remove hotkeys for applications that have been deleted

you can remove this ifdef

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> CMakeLists.txt:39
> -find_package(KHotKeysDBusInterface QUIET)
> -if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
> -   add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06)

Why removing it ?

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24530: [XembedSNIProxy] If available, always use 32-bit color.

2019-10-14 Thread Laurent Montel
mlaurent added a comment.


  Hi,
  You can't commit yet as nobody accepted this patch.
  Regards

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24615: Fix crash with sortAllByName/Description

2019-10-14 Thread Laurent Montel
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  it seems ok for me.
  Thanks

REPOSITORY
  R103 KMenu Editor

BRANCH
  ahmad/takechildren-crash-on-index-rootItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24615

To: ahmadsamir, mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D23823: [KMenuEdit] port away from KStandardDirs

2019-09-10 Thread Laurent Montel
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok for me.

REPOSITORY
  R103 KMenu Editor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23823

To: dfaure, mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


Re: CI system maintainability

2019-03-28 Thread laurent Montel
Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit :
> Thanks for reply. More below:
> 
> Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel:
> > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit :
> > > Hi Laurent,
> > > 
> > > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > > > For example I works all days on kde (pim or other) when I wake up, or
> 
> at
> 
> > > > noon after my lunch or the evening, I will not wait several days for a
> > > > review because nobody has time to do it.
> > > > 
> > > > (For example I make ~ 15 commits by days on pim/ruqola/framework, I
> > > > don't
> > > > want to wait several days/weeks until someone wants to review my
> 
> patchs)
> 
> > > Something might be lost in translation here, do you think, because you
> > > work
> > > daily on code of KDE projects, and other people (so potential reviewers)
> > > do
> > > not, this is an argument to do instant pushes of unreviewed commits?
> > 
> > I maintain pim* from several years, I fix bugs, I improve apps, I fix all
> > bugs that I put in my code, so for this one I consider that I can commit
> > without review them (as other guys on other project that they maintain).
> > For framework I mainly use phabricator.
> 
> I was thinking of projects where there are multiple persons contributing/
> maintaining, like Frameworks.

For framework I use mainly phabricator
See https://phabricator.kde.org/people/revisions/196/


> 
> So for projects where you are the only person who has any real insight,
> indeed I agree to pushing directly, as I do that as well :)
> 
> Because IMHO the costs for having to hope & wait for somebody else to do a
> "review", where one then spends lots of time rather explaining things to
> someone, who is not really into the project and also never might be, is not
> anywhere worth the time one could have otherwise invested in fixing other
> existing bugs or adding new features or improving code quality.
> 
> If people want to get into a project, doing own patches or just watching the
> commits and asking normally on irc or by email about the architecture
> should work good enough. Abusing reviews for teaching about some project
> would annoy me at least, usually the patch is to fix some annoying bug or
> add a wanted feature, so it should get in as early as possible.
> 
> > > Not sure where this is from, but often I have seen an unwritten policy
> > > applied where people for a patch uploaded for review after one week of
> > > no
> > > response add a ping and then wait another week, before finally pushing
> 
> the
> 
> > > change. To me this seems a fair and reasonable policy, only ignores
> 
> people
> 
> > > who are on vacation for some more weeks or otherwise inactive, but I
> > > have
> > > not seen that ever been a real issue.
> > 
> > 2 weeks for a commit, for me it's too long.
> > I understand why people can be demotivated when they must wait long time
> > until having an answer.
> 
> Well, 2 weeks is the time-out, only reached in worst case. Ideally people
> give some feedback before, which often enough happens. And indeed one also
> has to hunt people down to get a review, like at meetings or in chat (or
> trade review work with each other :) ). But isn't this the same also at
> work- work, unless there is a dedicated review team which needs to react by
> itself? Co-operating on something needs social interaction after all.
> 
> > > Given the actual purpose of this thread, I would be more curious how you
> > > have CI integrated in your workflow?
> > 
> > CI: sometime I look at it, sometime not, sometime some guys informs me
> > that
> > it's broken (I remember that Luca told me some days ago that a package
> > didn't compile, so I fixed it).
> > Sometime my code compiles on local so for me it's ok but it's just that I
> > forgot to trash my builddir.
> 
> So you do not go on yourself to build.kde.org and check yourself? Does #kde-
> pim have a bot reporting build failures?

Long time ago we had it in #kontact.
It's not the case now.

> 
> For what I can tell e.g. for KDevelop, personally I rely on the bot on
> #kdevelop  reporting the CI state/build results, as I only look at emails
> rather once a day, while the chat channel is more real-time, and one also
> can immediately talk to peers about why some build now fails, as well as
> coordinate who will fix that.
> 
> > > And where things could be improved, 

Re: CI system maintainability

2019-03-28 Thread laurent Montel
Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit :
> Hi Laurent,
> 
> Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > For example I works all days on kde (pim or other) when I wake up, or at
> > noon after my lunch or the evening, I will not wait several days for a
> > review because nobody has time to do it.
> > 
> > (For example I make ~ 15 commits by days on pim/ruqola/framework, I don't
> > want to wait several days/weeks until someone wants to review my patchs)
> 
> Something might be lost in translation here, do you think, because you work
> daily on code of KDE projects, and other people (so potential reviewers) do
> not, this is an argument to do instant pushes of unreviewed commits?

I maintain pim* from several years, I fix bugs, I improve apps, I fix all bugs 
that I put in my code, so for this one I consider that I can commit without 
review them (as other guys on other project that they maintain).
For framework I mainly use phabricator.

> 
> While I understand one can get impatient if not getting instant review of
> changes one would like to depend on with further changes (I know this well
> :) ), still this seems a flawed argument at least for
> part-time-contributors based KDE projects, where the people one co-operates
> with only have time now and then, like once per week. It could be seen
> unfair & ignorant to them if one simply ignores their opinion, because one
> has more time reserved/ available.

KPIM doesn't have a big active team...

> Not sure where this is from, but often I have seen an unwritten policy
> applied where people for a patch uploaded for review after one week of no
> response add a ping and then wait another week, before finally pushing the
> change. To me this seems a fair and reasonable policy, only ignores people
> who are on vacation for some more weeks or otherwise inactive, but I have
> not seen that ever been a real issue.

2 weeks for a commit, for me it's too long. 
I understand why people can be demotivated when they must wait long time until 
having an answer.
I know that I don't participate a lot on qtcreator dev as we need to wait long 
time to have some review...


> 
> Given the actual purpose of this thread, I would be more curious how you
> have CI integrated in your workflow?

CI: sometime I look at it, sometime not, sometime some guys informs me that 
it's broken (I remember that Luca told me some days ago that a package didn't 
compile, so I fixed it).
Sometime my code compiles on local so for me it's ok but it's just that I 
forgot to trash my builddir.

> And where things could be improved, to
> prevent the current state of unhappiness for people who care about CI some
> more? Given you said you work daily on KDE projects, it seems that the
> brokeness of those projects on the KDE CI has slipped your attention. So
> how does this happen, and how could this be prevented, other than people
> having to hunt you down on irc and tell you :)

I think that Luca idea to send an email directly to the people which breaks 
code when it breaks from several commit is a good idea.

If I received directly a message about kcontact 19.04 after 1 days I fixed it 
directly. Master build correctly and unfortunately I don't have 19.04 and 
master in parallel.

Regards 

> 
> Cheers
> Friedrich


-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 




Re: CI system maintainability

2019-03-28 Thread laurent Montel
Le jeudi 28 mars 2019, 09:29:22 CET Kevin Ottens a écrit :
> Hello,
> 
> On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > Please note that the commits in this instance were pushed without
> > review, so restrictions on merge requests wouldn't make a difference
> > in this case unfortunately.
> 
> Maybe it's about time to make reviews mandatory... I know it's unpopular in
> KDE, and I advocated for "don't force a tool if you can get someone to look
> at your screen or pair with you" in the past. Clearly this compromise gets
> somewhat exploited and that's especially bad in the case of a fragile and
> central component like KDE PIM.
> 
> Regards.

Hi,

I am against to force mandatory review, as it will create a lot of lose of 
time, and we will not be sure that review is correct (see comment from Volker 
about "transaction lock regression")

It's necessary to having a big team for doing it.

Ok a repo was broken, but it was just that fix was created in master not 
19.04, I didn't see nobody on IRC told us "this package is always broken", 
when I saw it this morning I just cherry pick (2 seconds for fixing it).


For example I works all days on kde (pim or other) when I wake up, or at noon 
after my lunch or the evening, I will not wait several days for a review 
because nobody has time to do it. (we can see a review from zanshin for 
example https://phabricator.kde.org/D16210 we can see that David waited 2 
months until having an answer...).

(For example I make ~ 15 commits by days on pim/ruqola/framework, I don't want 
to wait several days/weeks until someone wants to review my patchs)

I will not lose my time to review some code that I don't understand... I never 
reviewed Akonadi patch as I don't understand this code, and I will take time 
on it just for the pleasure as I prefer fixing bug or adding new features in 
components that I maintain.

When we have a big team as Qt team it can help but in pim component where we 
don't have any redundant guy, we will lose a lot of time.

So for each increase version for each package I will wait a review. For sure 
not.

Each time that I will improve code as coding style I will wait that someone 
wants to review...


I know that it's easy to write "make reviews mandatory" there is not an impact 
about your work as we know that you are not really active on kde at the 
moment...

For sure I broke kcontact 2 days ago, but as a friend told me when I started 
to work on kde "We can't create a bug when we don't code..."

Regards

-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 




D19799: QNetworkReply was not deleted

2019-03-24 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:4adbb68bf405: QNetworkReply was not deleted (authored by 
mlaurent).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19799?vs=54387=54647

REVISION DETAIL
  https://phabricator.kde.org/D19799

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp

To: mlaurent, apol, #discover_software_store
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19799: QNetworkReply was not deleted

2019-03-23 Thread Laurent Montel
mlaurent added a comment.


  is it ok now ?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19799

To: mlaurent, apol, #discover_software_store
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19959: Fixed issue causing changed signal to be called with false argument

2019-03-23 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:ed3decc06e38:   Fixed issue causing changed signal to be 
called with false argument (authored by mlaurent).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19959?vs=54521=54594

REVISION DETAIL
  https://phabricator.kde.org/D19959

AFFECTED FILES
  src/advanceconfig.cpp

To: tigrang, mlaurent
Cc: mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19959: Fixed issue causing changed signal to be called with false argument

2019-03-22 Thread Laurent Montel
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Good catch.
  it's a bug in clazy.
  
  Thanks
  Do you have an commit access ?
  or do you want that I commit for you ?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

To: tigrang, mlaurent
Cc: mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19799: QNetworkReply was not deleted

2019-03-20 Thread Laurent Montel
mlaurent updated this revision to Diff 54387.
mlaurent added a comment.


  Fix QScopedPointer

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19799?vs=54015=54387

BRANCH
  delete_qnetwork_reply (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19799

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp

To: mlaurent, apol, #discover_software_store
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19851: [kirigami] make it compile without foreach

2019-03-19 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:12fb6c5de392: [kirigami] make it compile without foreach 
(authored by mlaurent).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19851?vs=54207=54311

REVISION DETAIL
  https://phabricator.kde.org/D19851

AFFECTED FILES
  CMakeLists.txt
  src/kirigamiplugin.cpp

To: mlaurent, dfaure, mart
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein


D19851: [kirigami] make it compile without foreach

2019-03-18 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> apol wrote in kirigamiplugin.cpp:48
> qAsConst isn't necessary because the method is already const.
> Is it just for readability?

Yep just for readability. It's just for avoiding that we thing it will detach.
For sure here it will not detach.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19851

To: mlaurent, dfaure
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein


D19851: [kirigami] make it compile without foreach

2019-03-18 Thread Laurent Montel
mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R169 Kirigami

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19851

AFFECTED FILES
  CMakeLists.txt
  src/kirigamiplugin.cpp

To: mlaurent, dfaure
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein


D19799: QNetworkReply was not deleted

2019-03-16 Thread Laurent Montel
mlaurent updated this revision to Diff 54015.
mlaurent added a comment.


  Use QScopedPointer

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19799?vs=53998=54015

BRANCH
  delete_qnetwork_reply (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19799

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp

To: mlaurent, apol, #discover_software_store
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19799: QNetworkReply was not deleted

2019-03-16 Thread Laurent Montel
mlaurent updated this revision to Diff 53998.
mlaurent added a comment.


  Fix indent

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19799?vs=53990=53998

BRANCH
  delete_qnetwork_reply (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19799

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp

To: mlaurent, apol, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19799: QNetworkReply was not deleted

2019-03-16 Thread Laurent Montel
mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  delete networkreply

REPOSITORY
  R134 Discover Software Store

BRANCH
  delete_qnetwork_reply (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19799

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp

To: mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18939: KMenuEdit: add search/filter bar

2019-02-12 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> kmenuedit.cpp:137
> +m_searchLine = new KTreeWidgetSearchLine(this, m_tree);
> +m_searchLine->setCaseSensitivity(Qt::CaseSensitivity::CaseInsensitive);
> +m_searchLine->setKeepParentsVisible(true);

you can use directly Qt::CaseInsensitive

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: mlaurent, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D14423: Mingw compile fix

2018-08-17 Thread Laurent Montel
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  For me it seems ok :)
  I can't test it.
  
  > +2 I trust you :)
  ===

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14423

To: habacker, mlaurent
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12116: Use const'ref here too

2018-04-11 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:58f9e46b1dad: Use constref here too (authored by 
mlaurent).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12116?vs=31895=31949

REVISION DETAIL
  https://phabricator.kde.org/D12116

AFFECTED FILES
  kded/osd.cpp
  kded/osd.h

To: mlaurent, dvratil, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12116: Use const'ref here too

2018-04-11 Thread Laurent Montel
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mlaurent requested review of this revision.

TEST PLAN
  compile

REPOSITORY
  R104 KScreen

BRANCH
  use_const_ref

REVISION DETAIL
  https://phabricator.kde.org/D12116

AFFECTED FILES
  kded/osd.cpp
  kded/osd.h

To: mlaurent
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12113: Use nullptr. Use const/ref.

2018-04-11 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:5dbe76009828: Use nullptr. Use const/ref. (authored by 
mlaurent).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12113?vs=31880=31892

REVISION DETAIL
  https://phabricator.kde.org/D12113

AFFECTED FILES
  kcm/src/declarative/qmloutput.cpp
  kcm/src/declarative/qmlscreen.cpp
  kcm/src/resolutionslider.cpp
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/widget.cpp
  kded/generator.cpp
  kded/osd.cpp
  kded/osd.h

To: mlaurent, dvratil, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12110: Extract i18n from qml too

2018-04-11 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:31b72f4ad003: Extract i18n from qml too (authored by 
mlaurent).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12110?vs=31876=31881

REVISION DETAIL
  https://phabricator.kde.org/D12110

AFFECTED FILES
  kded/Messages.sh

To: mlaurent, dvratil, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12111: Remove unused code.

2018-04-11 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:0cc080688be5: Remove unused code. (authored by mlaurent).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12111?vs=31877=31882

REVISION DETAIL
  https://phabricator.kde.org/D12111

AFFECTED FILES
  CMakeLists.txt
  plasma/CMakeLists.txt
  plasma/Messages.sh
  plasma/kscreenapplet.cpp
  plasma/kscreenapplet.h
  plasma/package/contents/ui/ActionIcon.qml
  plasma/package/contents/ui/main.qml
  plasma/package/metadata.desktop.cmake
  plasma/plasma-applet-kscreen.desktop.cmake

To: mlaurent, dvratil, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12113: Use nullptr. Use const/ref.

2018-04-11 Thread Laurent Montel
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mlaurent requested review of this revision.

TEST PLAN
  Build

REPOSITORY
  R104 KScreen

BRANCH
  clean_code

REVISION DETAIL
  https://phabricator.kde.org/D12113

AFFECTED FILES
  kcm/src/declarative/qmloutput.cpp
  kcm/src/declarative/qmlscreen.cpp
  kcm/src/resolutionslider.cpp
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/widget.cpp
  kded/generator.cpp
  kded/osd.cpp
  kded/osd.h

To: mlaurent
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12111: Remove unused code.

2018-04-11 Thread Laurent Montel
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REPOSITORY
  R104 KScreen

BRANCH
  remove_unused_plasma

REVISION DETAIL
  https://phabricator.kde.org/D12111

AFFECTED FILES
  CMakeLists.txt
  plasma/CMakeLists.txt
  plasma/Messages.sh
  plasma/kscreenapplet.cpp
  plasma/kscreenapplet.h
  plasma/package/contents/ui/ActionIcon.qml
  plasma/package/contents/ui/main.qml
  plasma/package/metadata.desktop.cmake
  plasma/plasma-applet-kscreen.desktop.cmake

To: mlaurent
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12110: Extract i18n from qml too

2018-04-11 Thread Laurent Montel
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  i18n from qml was not extracted

REPOSITORY
  R104 KScreen

BRANCH
  fix_extract_message

REVISION DETAIL
  https://phabricator.kde.org/D12110

AFFECTED FILES
  kded/Messages.sh

To: mlaurent
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12109: Fix clone action (typo in enum)

2018-04-11 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:c17c08526424: Fix clone action (typo in enum) (authored 
by mlaurent).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12109?vs=31874=31875

REVISION DETAIL
  https://phabricator.kde.org/D12109

AFFECTED FILES
  kded/qml/OsdSelector.qml

To: mlaurent, dvratil
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12109: Fix clone action (typo in enum)

2018-04-11 Thread Laurent Montel
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  We can't clone screen (typo in enum action)

TEST PLAN
  Plug another screen and try to unify it.

REPOSITORY
  R104 KScreen

BRANCH
  fix_clone_action

REVISION DETAIL
  https://phabricator.kde.org/D12109

AFFECTED FILES
  kded/qml/OsdSelector.qml

To: mlaurent
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10605: Fix location of Firefox dbCacheFile

2018-02-19 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:745cffc9ffd3: Fix location of Firefox dbCacheFile 
(authored by z3ntu, committed by mlaurent).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10605?vs=27414=27534

REVISION DETAIL
  https://phabricator.kde.org/D10605

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10605: Fix location of Firefox dbCacheFile

2018-02-19 Thread Laurent Montel
mlaurent added a comment.


  Ok I will commit for you.
  Regards

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D10605

REVISION DETAIL
  https://phabricator.kde.org/D10605

To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10605: Fix location of Firefox dbCacheFile

2018-02-19 Thread Laurent Montel
mlaurent added a comment.


  Do you have commit access ?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D10605

REVISION DETAIL
  https://phabricator.kde.org/D10605

To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10605: Fix location of Firefox dbCacheFile

2018-02-17 Thread Laurent Montel
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D10605

REVISION DETAIL
  https://phabricator.kde.org/D10605

To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10605: Fix location of Firefox dbCacheFile

2018-02-17 Thread Laurent Montel
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  Otherwise patch is correct.

INLINE COMMENTS

> firefox.cpp:58
>  if (m_dbCacheFile.isEmpty()) {
> -m_dbCacheFile = 
> QStandardPaths::writableLocation(QStandardPaths::CacheLocation) + 
> QStringLiteral("bookmarkrunnerfirefoxdbfile.sqlite");
> +m_dbCacheFile = 
> QStandardPaths::writableLocation(QStandardPaths::CacheLocation) + "/" + 
> QStringLiteral("bookmarkrunnerfirefoxdbfile.sqlite");
>  }

or QStringLiteral("/bookmarkrunnerfirefoxdbfile.sqlite"); directly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10605

To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10151: Solved bug 382512

2018-02-02 Thread Laurent Montel
mlaurent added a comment.


  Ping ?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Solved bug 382512

2018-01-27 Thread Laurent Montel
mlaurent added a comment.


  For patch it seems ok. 
  But Nathaniel is right. Describe how you tested it, add BUG: etc.
  
  Otherwise it's a good start :)
  
  Thanks.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10111: [Klipper] Force plain text on the edit dialog

2018-01-26 Thread Laurent Montel
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  Indeed it's better. but we need to use setAcceptRichText(false) in edit 
otherwise we can set html text by dnd or copy.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10111

To: safaalfulaij, #plasma, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D9325: Use QUrl in the ScreenMapper API

2017-12-18 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> screenmapper.cpp:101
>  const auto screenPathWithScheme = screenUrl.url();
> -const bool isEmpty = (path.isEmpty() || screenUrl.path() == "/");
> +const bool isEmpty = (screenUrl.isEmpty() || screenUrl.path() == "/");
>  // restore the stored locations

"== QLatin1Char('/') ?"

REVISION DETAIL
  https://phabricator.kde.org/D9325

To: amantia, #plasma, mwolff, dakon, broulik
Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D9323: Use ScreenMapper everywhere as a singleton

2017-12-18 Thread Laurent Montel
mlaurent added a comment.


  Seems ok for me.

REVISION DETAIL
  https://phabricator.kde.org/D9323

To: amantia, #plasma, mwolff, hein
Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D9325: Use QUrl in the ScreenMapper API

2017-12-14 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> foldermodeltest.cpp:34
>  
> +static QUrl stringToUrl(const QString ) {
> +return QUrl::fromUserInput(path, {}, QUrl::AssumeLocalFile);

new line after ')'

> positionertest.cpp:38
>  
> +static QUrl stringToUrl(const QString ) {
> +return QUrl::fromUserInput(path, {}, QUrl::AssumeLocalFile);

I don't think that it used in this file.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9325

To: amantia, #plasma, mwolff, dakon, broulik
Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D9300: Store screenMapping info only once

2017-12-13 Thread Laurent Montel
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  seems good for me

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9300

To: amantia, #plasma, mwolff, hein, broulik, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D9300: Store screenMapping info only once

2017-12-13 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> screenmapper.cpp:202
> +KConfigGroup group(config, QLatin1String("ScreenMapping"));
> +QStringList mapping = 
> group.readEntry(QLatin1String("screenMapping"), QStringList{});
> +setScreenMapping(mapping);

const QStringList

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9300

To: amantia, #plasma, mwolff, hein, broulik
Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8444: Define default Action when we plug unknown monitor

2017-11-30 Thread Laurent Montel
mlaurent added a comment.


  Ping ?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


D8444: Define default Action when we plug unknown monitor

2017-11-27 Thread Laurent Montel
mlaurent added a comment.


  @sebas: What do you want as widget design ?
  
  Is it ok to add plasma dependancy in kscreen ?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


D8444: Define default Action when we plug unknown monitor

2017-11-27 Thread Laurent Montel
mlaurent added a comment.


  (I was in vacation.)
  Ok so I need to create an osd plasma  for it.
  I can trash this current patch.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


D8493: Make Folder View screen aware

2017-11-03 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> foldermodeltest.cpp:70
> +delete m_folderDir;
> +m_folderDir = 0;
>  delete m_folderModel;

m_folderDir = nullptr

> foldermodeltest.cpp:294
> +FolderModel secondFolderModel;
> +secondFolderModel.setUrl(m_folderDir->path()  + QDir::separator() + 
> desktop );
> +secondFolderModel.setUsedByContainment(true);

remove extra space before +

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, 
apol, mwolff
Cc: ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


D8493: Make Folder View screen aware

2017-10-31 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> foldermodel.h:192
> +ScreenMapper* screenMapper() const;
> +void setScreenMapper(ScreenMapper* screenMapper);
> +

Coding style "space before *"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid
Cc: broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol


D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent edited the test plan for this revision.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent edited the test plan for this revision.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent edited the test plan for this revision.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent edited the test plan for this revision.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Laurent Montel
mlaurent retitled this revision from "WIP: Define default Action when we plug 
unknown monitor" to "Define default Action when we plug unknown monitor".

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8432: Use nullptr. Initialize pointer

2017-10-30 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:7c602a831f5d: Use nullptr. Initialize pointer (authored 
by mlaurent).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8432?vs=21172=21566

REVISION DETAIL
  https://phabricator.kde.org/D8432

AFFECTED FILES
  backends/xcbwrapper.cpp
  backends/xrandr/xrandrconfig.cpp
  backends/xrandr/xrandroutput.cpp
  src/backendlauncher/backenddbuswrapper.h
  src/backendlauncher/backendloader.cpp
  src/backendlauncher/backendloader.h
  src/backendmanager.cpp
  src/config.cpp
  src/configmonitor.cpp
  src/doctor/doctor.h
  src/doctor/dpmsclient.h
  src/edid.h
  src/getconfigoperation.h
  src/mode.cpp
  src/setconfigoperation.h

To: mlaurent, davidedmundson, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8553: It's autotests not tests

2017-10-30 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:357bb3ab75c9: Its autotests not tests (authored by 
mlaurent).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8553?vs=21558=21565#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8553?vs=21558=21565

REVISION DETAIL
  https://phabricator.kde.org/D8553

AFFECTED FILES
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/autotests/foldermodeltest.h
  containments/desktop/plugins/folder/autotests/positionertest.cpp
  containments/desktop/plugins/folder/autotests/positionertest.h
  containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.h
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/foldermodeltest.h
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h

To: mlaurent, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8553: It's autotests not tests

2017-10-30 Thread Laurent Montel
mlaurent added a reviewer: hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8553

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8553: It's autotests not tests

2017-10-30 Thread Laurent Montel
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  compile

REPOSITORY
  R119 Plasma Desktop

BRANCH
  rename_as_autotest

REVISION DETAIL
  https://phabricator.kde.org/D8553

AFFECTED FILES
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/autotests/foldermodeltest.h
  containments/desktop/plugins/folder/autotests/positionertest.cpp
  containments/desktop/plugins/folder/autotests/positionertest.h
  containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.h
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/foldermodeltest.h
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8549: We use Q_DECL_OVERRIDE or override.

2017-10-30 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0adccf18e3d0: We use Q_DECL_OVERRIDE or override. 
(authored by mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8549?vs=21551=21553

REVISION DETAIL
  https://phabricator.kde.org/D8549

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin.h
  containments/desktop/plugins/folder/itemviewadapter.h
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/wheelinterceptor.h

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8515: Don't loop twice here

2017-10-30 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9a5e9be03fe6: Dont loop twice here (authored by 
mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8515?vs=21422=21552

REVISION DETAIL
  https://phabricator.kde.org/D8515

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/positioner.cpp

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8549: We use Q_DECL_OVERRIDE or override.

2017-10-30 Thread Laurent Montel
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  > use unique keyword override
  =

TEST PLAN
  compile

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use_override

REVISION DETAIL
  https://phabricator.kde.org/D8549

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin.h
  containments/desktop/plugins/folder/itemviewadapter.h
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/wheelinterceptor.h

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8515: Don't loop twice here

2017-10-30 Thread Laurent Montel
mlaurent added a comment.


  This one too ?:)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8515

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8516: Emit signal when we change PerStripe

2017-10-30 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bf0a2b81426e: Emit signal when we change PerStripe 
(authored by mlaurent).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8516?vs=21421=21550#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8516?vs=21421=21550

REVISION DETAIL
  https://phabricator.kde.org/D8516

AFFECTED FILES
  containments/desktop/plugins/folder/positioner.cpp

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8517: Test enable status change and perStripe change

2017-10-30 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:27fb7629ce1d: Test enable status change and perStripe 
change (authored by mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8517?vs=21426=21549

REVISION DETAIL
  https://phabricator.kde.org/D8517

AFFECTED FILES
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h
  containments/desktop/plugins/folder/viewpropertiesmenu.h

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8516: Emit signal when we change PerStripe

2017-10-30 Thread Laurent Montel
mlaurent added a comment.


  Ping ?:)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8516

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


  1   2   >