manuelc abandoned this revision.
manuelc added a comment.
Okay, no, that clearly didn't work, I think I don't quite know how to resolve
that... But, what I also just noticed, is that someone else took on this task
anyway, so I'm just gonna abandon this.
REPOSITORY
R114 Plasma Addons
manuelc updated this revision to Diff 33814.
manuelc added a comment.
And I think I totally messed up the diff just now, here I go again...
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10791?vs=33813=33814
REVISION DETAIL
manuelc updated this revision to Diff 33813.
manuelc added a comment.
After some time and careful consideration of how the other providers work I
rewrote the JSON parsing code. While doing that I noticed that I overlooked an
object in the second return value...
I don't know though,
manuelc planned changes to this revision.
REVISION DETAIL
https://phabricator.kde.org/D10791
To: manuelc, #plasma
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
manuelc reclaimed this revision.
REVISION DETAIL
https://phabricator.kde.org/D10791
To: manuelc, #plasma
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
manuelc abandoned this revision.
manuelc added a comment.
I'm sorry, I realised I had to look over my changes once more, more closely
REVISION DETAIL
https://phabricator.kde.org/D10791
To: manuelc, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas,
manuelc updated this revision to Diff 27908.
manuelc added a comment.
I didn't know how important this was and building took a bit long.
Also, should these be initialised externally since they never change or is it
fine to put them directly into the function?
CHANGES SINCE LAST UPDATE
manuelc added a reviewer: Plasma.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D10791
To: manuelc, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
manuelc created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
manuelc requested review of this revision.
REVISION SUMMARY
Since the previously used method is no longer working because the page
doesn't exist anymore I
