D29264: New tabs for Breeze

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Invent link in case it's useful for anyone: 
https://invent.kde.org/plasma/breeze/-/merge_requests/6

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: bcooksley, ndavis, niccolove, manueljlin, filipf, ngraham, cblack, 
plasma-devel, dmenig, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, 
jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ZrenBot, firef, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D29264: New tabs for Breeze

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  In D29264#663444 , @ngraham wrote:
  
  > I would suggest to re-add the darkened background for inactive tabs
  
  
  +1
  I think it would still look fine with the 1px color line rounded at the top
  
  F8289464: image.png 
  
  2x
  F8289499: image.png 
  
  Maybe it could even be extended to the top of the outline so it's 2px, but 
that might be slightly hacky and/or inconsistent
  F8289535: image.png 
  
  > Using only color to communicate the "current tab" state would jive with 
that, but then I start to think that we don't have enough color here and that 
it should look more like a Plasma tab, with a thicker highlight bar and the 
whole background colored
  
  Hmm, I think that might look out of place seeing how breeze mostly uses
  1px lines. I also believe that instead of coloring the entire tab background
  with the highlight color, it should just use contrasting colors (selected tab
  and content with view bg, the slightly darker inactive tab bg and the
  outline of the tabs should work)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, Orage, 
LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, 
zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

[Manuel Jesús de la Fuente]

manueljlin accepted this revision.
manueljlin added a comment.
This revision is now accepted and ready to land.


  Much better

REPOSITORY
  R97 Bluedevil

BRANCH
  almost-always-show-applet-toolbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29132

To: ngraham, #vdg, niccolove, manueljlin
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29117: [applet] Put the toolbar in the header area

[Manuel Jesús de la Fuente]

manueljlin accepted this revision as: manueljlin.
manueljlin added a comment.


  Looks good  Should I accept as VDG or wait for @niccolove 's review?

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  put-toolbar-in-header-area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29117

To: ngraham, #vdg, #plasma, jgrulich, niccolove, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  The last one doesn't have a sidebar and goes back to the list after pressing 
the back button. It looks a bit cleaner but UX wise it's a bit worse too, 
having to click two times to do what currently only requires one. I prefer the 
first and second design but since that one was discussed in the VDG chat I 
didn't want to leave it there

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Some mockups: F8216924: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  In D27199#627422 , @gvgeo wrote:
  
  > Differently sized icons are about to be restored in D28034 
.
  
  
  Nice! Thanks
  
  >> ...text indicator replaced with a 1px divider...   Is it a good idea to 
tweak it or is it better to leave it like it is?
  > 
  > The alternative is the first version from T10470 
 mocups, right? If #VDG 
 team doesn't like as it is, don't see a 
reason to keep it as it is.
  
  Yes, it would be like the first mockup
  
  > Would be nice to hear about details labels too, which have 0.6 opacity now:
  >  F8098508: Screenshot_20200211_234124.png 

  
  LGTM
  
  > And of course any other change, to avoid changing the UI with every release.
  
  If you could align the password field to the padding like this it would be 
great F8182886: image.png 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  I know this is closed now, but some people from the VDG didn't like the text 
indicator replaced with a 1px divider and the differently sized networks. Is it 
a good idea to tweak it or is it better to leave it like it is?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin accepted this revision as: manueljlin.
manueljlin added a comment.


  Looks good, let's wait for ngraham so he accepts as vdg

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Thanks, and sorry for wasting your time :x

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  you can close this task if you want, after talking a bit over T10470 
 it's better to use headers instead of 
footers

REVISION DETAIL
  https://phabricator.kde.org/D27257

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: anthonyfieroni, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27199: [WIP][Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  I think that it should use a footer to be consistent with the other ones

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  I think 1.4 looks too small

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: alexde, ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

[Manuel Jesús de la Fuente]

manueljlin accepted this revision.
manueljlin added a comment.
This revision is now accepted and ready to land.


  Looks significantly better in my opinion

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  I love how it looks :D
  The only thing I would change is the progress bar padding by either extending 
the bar to the left border to the album art or to the ~11px border from before

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: davidedmundson, ngraham, manueljlin, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Might be better to be aligned to the left since it looks similar now to the 
battery percentage, but aside from that it's great! Also, sorry for replying 
late :P

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin accepted this revision.
manueljlin added a comment.


  Nice, looks great! About the stream name, it doesn't look like it's useful 
most of the time so it might be better to remove it

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  layout2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  If it isn't possible that's okay (it looks really nice right now, great job 
btw :D), although it'd be nice to make it consistent with the kirigami style 
divider

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Looking at the screenshots, UI wise it's looking good already, only that the 
checkbox seems too big (should be the same size as the radio button, 16px) and 
there's a 5px sized padding after the divider that cuts off part of the 
Internal Microphone button and volume slider earlier than it's supposed to  
F7849101: image.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  I though that would just affect every app's titlebar without actually 
checking if the app has a toolbar, etc etc and just add/remove the divider 
everywhere and be done with it. However, if the app can actually send a hint to 
Kwin to make it hide or show the divider depending if it has a toolbar or not 
(or maybe through a window / app rule), then it's great

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  But that style of line / divider was going to be after the toolbars too, like 
kirigami apps, so removing it just would make that inconsistent later on. If 
it's possible, fixing the color scheme and making it configurable should 
probably be the way to go.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart