Re: Plasma 5.10 voice over text

2017-05-16 Thread Martin Gräßlin
Am 16. Mai 2017 23:25:11 MESZ schrieb "Łukasz Sawicki" : >Hi, > >Here is a script/voice over text for Plasma 5.10 video. It is heavily >based on Plasma 5.10 beta announcement. Please check it for grammar, >typos etc. > >https://notes.kde.org/p/Plasma_5.10_script > >If you think that I missed some

D5731: Fix regression for timestamp handling for Xwayland windows

2017-05-07 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:32939fa7b522: Fix regression for timestamp handling for Xwayland windows (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5731?vs=14210&id=14218

D5733: Keep all touchpad QActions in the main thread

2017-05-07 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > input.cpp:1759 > + // steal touchpad shortcuts > +QAction *touchpadToggleAction = new QAction(this); > +QAction *touchpadOnAction = new QAction(this); I think this should be in the if (con) branch. Given that the method is already q

D5731: Fix regression for timestamp handling for Xwayland windows

2017-05-06 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Change https://phabricator.kde.org/R108:0bec9ad7337536e319c17c5684d97e1156399fdb introduced a regrssion on Wayland. On Wayland getTime

D5726: Fix regression for timestamp handling for Xwayland windows

2017-05-06 Thread Martin Gräßlin
graesslin added a comment. New version at https://phabricator.kde.org/D5731 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5726 To: graesslin, #kwin, #plasma, sebas Cc: luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jens

D5726: Fix regression for timestamp handling for Xwayland windows

2017-05-06 Thread Martin Gräßlin
graesslin abandoned this revision. graesslin added a comment. Going for Thomas's suggestion to check in setX11Time REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5726 To: graesslin, #kwin, #plasma, sebas Cc: luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, le

D5728: Release the wl_registry before QPA shutdown in QStyl

2017-05-06 Thread Martin Gräßlin
graesslin added a comment. I had already investigated the problem, pushed a change and reverted it. I think the qstyle gets destroyed too early. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5728 To: davidedmundson, #plasma, hpereiradacosta Cc: graesslin, cfeck, pla

D5726: Fix regression for timestamp handling for Xwayland windows

2017-05-05 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Change https://phabricator.kde.org/R108:0bec9ad7337536e319c17c5684d97e1156399fdb introduced a regrssion on Wayland. On Wayland getTime

D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA

2017-05-05 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. This is genius, using release! I spent hours on thinking how to properly clean that up and always came to the conclusion it's not possible as we cannot properly clean up because we do

D5704: Improve the x11 timestamp handling

2017-05-05 Thread Martin Gräßlin
graesslin added a comment. This caused a regression for XWayland windows. On Wayland QX11Info::getTimestamp always returns 0 and thus our timestamp gets set to 0. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5704 To: graesslin, #kwin, #plasma, davidedmundson Cc: cfe

D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down

2017-05-05 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:572f730e8ecd: [helper] Terminate xclipboardsyncer if kwin_wayland goes down (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5589?vs=13800&id=14

D5704: Improve the x11 timestamp handling

2017-05-05 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:0bec9ad73375: Improve the x11 timestamp handling (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5704?vs=14122&id=14169 REVISION DETAIL http

D5712: Validate surface is valid when sending TextInput leave event

2017-05-05 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Thanks for adding the test! REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D5712 To: davidedmundson, #plasma, graesslin Cc: apol, graesslin

D5712: Validate surface is valid when sending TextInput leave event

2017-05-04 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please add a unit test case. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5712 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-dev

D5710: Sync kscreen outputs to wayland

2017-05-04 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D5710 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, j

D5704: Improve the x11 timestamp handling

2017-05-03 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far KWin only updated the x11 timestamp if the new timestamp is larger than the existing one. While this is a useful thing it creates

D5697: Fix Output::geometry() when dealing with a scaled monitor

2017-05-03 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D5697 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, ab

D5694: activate all suitable launchers instead of only the first encountered

2017-05-03 Thread Martin Gräßlin
graesslin added a comment. as the one who implemented this, I have to say that I disagree with the argumentation. I think it is wrong to activate all and fear that this could result in annoying issues especially as launchers close when losing focus. This could result in random launcher activ

D5549: [platformx/x11] Fix touch events for internal Qt windows

2017-05-02 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:014afe1c0559: [platformx/x11] Fix touch events for internal Qt windows (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5549?vs=13714&id=14095

D5551: Make WindowSwitching (Alt+Tab) the default left touch screen edge

2017-05-02 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:c453eb696cc9: Make WindowSwitching (Alt+Tab) the default left touch screen edge (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5551?vs=13716&i

D5683: Add output scale to Wayland overview

2017-05-02 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R102:f8296597119a: Add output scale to Wayland overview (authored by graesslin). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5683?vs=14057&id=14066 REVISION DETA

D5683: Add output scale to Wayland overview

2017-05-01 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change lists the scale factor for the Wayland outputs. REPOSITORY R102 KInfoCenter BRANCH wayland-output-scale REVISION DETAIL

D5549: [platformx/x11] Fix touch events for internal Qt windows

2017-04-29 Thread Martin Gräßlin
graesslin added a comment. ping! This one is super important for enabling touch screen edges on X11! REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5549 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensr

Re: Plasma 5.10 Frameworks version problem

2017-04-28 Thread Martin Gräßlin
Am 2017-04-28 17:22, schrieb David Edmundson: What's the minimum version of frameworks we can use in Plasma 5.10? The schedule currently is: 2017-05-06: Frameworks 5.33 gets tagged 2017-05-11: Plasma 5.10 beta is tagged && released 2017-05-13: Frameworks 5.33 comes out 2017-05-25: Plasma 5.10 i

D5635: Sync wayland output scale to KScreen config

2017-04-28 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D5635 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreut

D3504: Implment DRM EGL scaling

2017-04-28 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. @davidedmundson feel free to push the complete series once you think it's ready. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3504 To: davidedmundson, #plas

Re: ksmserver errors after updating to Plasma 5.9.5

2017-04-27 Thread Martin Gräßlin
Should we do a 5.9.5.1 release for plasma-workspace? Am 27. April 2017 12:05:46 MESZ schrieb Jonathan Riddell : >Anyone have experience of this bug? seems to be a regression in 5.9.5 > >https://bugs.kde.org/show_bug.cgi?id=379254 > >possible guilty commits > >https://cgit.kde.org/plasma-workspace.

D5602: [Greeter] Expose wallpaper QML item as "wallpaper" context property

2017-04-26 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5602 To: broulik, #plasma, graesslin Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down

2017-04-26 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5589#104948, @luebking wrote: > This boils down to the question why the process is still lingering around. It lingers around when kwin_wayland crashes. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/

D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down

2017-04-26 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5589#104724, @luebking wrote: > If the child survives the parent that normally means it's forked at some point and the fork will clear the flag - anyway: clear which flag? The idea of PDEATHSIG is to get signalled when the

D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down

2017-04-25 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Normally the xclipboardsyncer should terminate because the socket becomes unusable. But we have reports of it not really going down and

D5588: Also list wayland sessions in autostart list

2017-04-25 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5588 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai,

D5583: [Lock Screen] Show Previous/Next buttons only if supported

2017-04-25 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5583 To: broulik, #plasma, #vdg, graesslin Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, ab

Re: failing build tests

2017-04-24 Thread Martin Gräßlin
Am 2017-04-24 20:53, schrieb Martin Gräßlin: Am 2017-04-24 18:26, schrieb Jonathan Riddell: In master kscreenlocker and plasma-integration are also broken while kwin is pleasingly green In case of kwin I must say that Plasma 5.9 had never been green, but the same state on master when it

D5540: Add a KSharedConfigPtr for kcminputrc to KWin::Application

2017-04-24 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:857d8a9c37c6: Add a KSharedConfigPtr for kcminputrc to KWin::Application (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5540?vs=13691&id=13762

D5452: Handle modifier updates in the same sequence as Wayland does

2017-04-24 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:a039c2760f64: Handle modifier updates in the same sequence as Wayland does (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5452?vs=13444&id=137

D5262: Animate quick tiling outline

2017-04-24 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5262 To: broulik, #vdg, #plasma, #kwin, graesslin Cc: fabianr, graesslin, plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, jen

Re: failing build tests

2017-04-24 Thread Martin Gräßlin
Am 2017-04-24 18:26, schrieb Jonathan Riddell: In master kscreenlocker and plasma-integration are also broken while kwin is pleasingly green In case of kwin I must say that Plasma 5.9 had never been green, but the same state on master when it branched was green. To me it looks like a false

D5547: Prevent kcheckpass from becoming an orphan

2017-04-24 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:c5e49e466e48: Prevent kcheckpass from becoming an orphan (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5547?vs=13712&id=13754 REVIS

Plasma 5.10 release announcement

2017-04-23 Thread Martin Gräßlin
Hi plasmates, I setup a notes for the Plasma 5.10 release announcement: https://notes.kde.org/p/plasma_5_10 already filled with some KWin stuff Cheers Martin

Re: Default touch screen edge gestures

2017-04-23 Thread Martin Gräßlin
Am 2017-04-08 11:24, schrieb Martin Gräßlin: Hi Plasmates, now that we have touch screen edge swipe gesture support both on X11 and Wayland we could define which actions to put on each edge. My suggestion would be to put a sensible action on each of the four actions. Personal proposal

D5551: Make WindowSwitching (Alt+Tab) the default left touch screen edge

2017-04-23 Thread Martin Gräßlin
graesslin added a dependency: D5549: [platformx/x11] Fix touch events for internal Qt windows. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5551 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg

D5549: [platformx/x11] Fix touch events for internal Qt windows

2017-04-23 Thread Martin Gräßlin
graesslin added a dependent revision: D5551: Make WindowSwitching (Alt+Tab) the default left touch screen edge. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5549 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening

D5551: Make WindowSwitching (Alt+Tab) the default left touch screen edge

2017-04-23 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Based on the feedback from discussion on plasma-devel the currently only default touch action on a screen edge should be window switchin

D5549: [platformx/x11] Fix touch events for internal Qt windows

2017-04-23 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY To have touch events working we need to do memory layout changes on the xcb events. This is fine for identifying the touch events which

D5547: Prevent kcheckpass from becoming an orphan

2017-04-23 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY With the long running kcheckpass there is the possibility that kcheckpass becomes an orphan. Kcheckpass terminates once it gets SIGUSR2 s

D5540: Add a KSharedConfigPtr for kcminputrc to KWin::Application

2017-04-21 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There are a few places where KWin needs to read values from kcminputrc. As I need to add yet another one it makes more sense to properly

D5403: Support blocking of screen edges on active fullscreen windows also for touch

2017-04-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:e9a44a275e74: Support blocking of screen edges on active fullscreen windows also for touch (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5403

D5528: Don't map screenedge approach window if edge is only used for touch

2017-04-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:eec6afe6f5fe: Don't map screenedge approach window if edge is only used for touch (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5528?vs=13653

D5438: [plugins/qpa] Do not replace a valid FBO with an invalid one

2017-04-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:ac08c5ac9d45: [plugins/qpa] Do not replace a valid FBO with an invalid one (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5438?vs=13411&id=136

D5315: Add support for keyboard layout switching policy "window"

2017-04-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:c8274dbe5798: Add support for keyboard layout switching policy "window" (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5315?vs=13131&id=13686#toc REPOSITORY R108 KWi

D5365: Add support for keyboard layout switching policy "winclass"

2017-04-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:b132fe7c245c: Add support for keyboard layout switching policy "winclass" (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5365?vs=13262&id=1368

D5301: Introduce support for keyboard layout switching policies

2017-04-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:bf99d9ffdd91: Introduce support for keyboard layout switching policies (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5301?vs=13245&id=13685

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

2017-04-21 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=378445 --- Comment #12 from Martin Gräßlin --- Assuming the signal handler is the reason the steps to reproduce are: Let screen lock through idle timeout and during grace period lock the screen through shortcut -- You are receiving this mail because: You

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

2017-04-21 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=378445 --- Comment #11 from Martin Gräßlin --- In the case of sigusr1 it could happen that memory gets allocated from the signal handler. -- You are receiving this mail because: You are the assignee for the bug.

Re: [KWin Quest. - Update] - KWin authorize external docks to manipulate tasks and windows

2017-04-21 Thread Martin Gräßlin
Am 2017-04-21 15:05, schrieb Michail Vourlakos: Following the previous discussion concerning this topic: https://www.mail-archive.com/plasma-devel@kde.org/msg62432.html https://www.reddit.com/r/kde/comments/668yul/common_developer_forum_for_docks_wayland_case/?st=j1ru5ogg&sh=5771f221 Based on

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

2017-04-21 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=378445 --- Comment #9 from Martin Gräßlin --- or another explanation could be memory corruption or even defect RAM. -- You are receiving this mail because: You are the assignee for the bug.

D4893: Layout and animations on the on screen keyboard

2017-04-21 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D4893#103772, @mart wrote: > In https://phabricator.kde.org/D4893#103745, @graesslin wrote: > > > Just verified: reverting this change also fixes the issues mentioned for Wayland. > > > i think i found the problem, it was

D4893: Layout and animations on the on screen keyboard

2017-04-20 Thread Martin Gräßlin
graesslin added a comment. Just verified: reverting this change also fixes the issues mentioned for Wayland. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4893 To: mart, #plasma, broulik, graesslin Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-moh

D4893: Layout and animations on the on screen keyboard

2017-04-20 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D4893#103687, @mart wrote: > In https://phabricator.kde.org/D4893#103663, @graesslin wrote: > > > In https://phabricator.kde.org/D4893#103472, @graesslin wrote: > > > > > I fear this change caused regressions. I now don't ha

D5528: Don't map screenedge approach window if edge is only used for touch

2017-04-20 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Another regression from enabling touch support on X11. The approach window for pointer input gets unmapped as soon as the mouse enters

D4893: Layout and animations on the on screen keyboard

2017-04-20 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D4893#103472, @graesslin wrote: > I fear this change caused regressions. I now don't have the virtual keyboard button on the layout anymore (X11 and Wayland) and on Wayland it's impossible to unlock the screen. I just reve

D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer

2017-04-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:c3ecf55bf8e0: Do not handle ScreenEdges::check for Edges which don't activate for Pointer (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5421?

D5462: [effects/slideback] Consider windows which do have painting disabled as not usable

2017-04-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:919b497f9020: [effects/slideback] Consider windows which do have painting disabled as not… (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5462

D5461: Don't update the focused pointer Surface if a button is pressed

2017-04-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:9a13743c4988: Don't update the focused pointer Surface if a button is pressed (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5461?vs=13474&id=

D5520: [platforms/x11] Do not grab touch events

2017-04-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:a5735e19b99d: [platforms/x11] Do not grab touch events (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5520?vs=13623&id=13647 REVISION DETAIL

D5520: [platforms/x11] Do not grab touch events

2017-04-19 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Grabbing the touch events seems to cause issues. It seems to also grab pointer events from touchpad and breaks touch input on other even

D4893: Layout and animations on the on screen keyboard

2017-04-19 Thread Martin Gräßlin
graesslin added a comment. I fear this change caused regressions. I now don't have the virtual keyboard button on the layout anymore (X11 and Wayland) and on Wayland it's impossible to unlock the screen. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4893

D4806: [greeter] Send the auth result through the server instead return value

2017-04-19 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:d666fe879d46: [greeter] Send the auth result through the server instead return value (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4

D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

2017-04-19 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:5e3c7b337c95: Use seccomp for implementing a sandbox for kscreenlocker_greet (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5029?vs=13189&id=13604#toc REPOSITORY R13

D4997: Support for long running kcheckpass supporting multiple authentications

2017-04-19 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:07d38ba65adc: Support for long running kcheckpass supporting multiple authentications (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

Re: Next Plasma LTS and openSUSE

2017-04-18 Thread Martin Gräßlin
Am 2017-04-18 13:55, schrieb Luca Beltrame: Hi everyone, this is basically the same discussion as already took place for 5.8. According to distrowatch, it looks very much like we're currently the _only_ remaining Top 10 distro with KDE (Plasma+Apps) installed and used by default. Not only has

D5488: Improve the escape key handling for breaking constrained pointers

2017-04-17 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far KWin started to filter out the escape key as soon as it gets pressed. This was done by unsetting keyboard focus. The idea was to

D5461: Don't update the focused pointer Surface if a button is pressed

2017-04-15 Thread Martin Gräßlin
graesslin updated this revision to Diff 13474. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Use range-based for loop with qAsConst REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5461?vs=13456&id=13474 BRANCH

D5464: Nextcloud Upload Purpose Plugin

2017-04-15 Thread Martin Gräßlin
graesslin added a comment. neat :-) Looking forward to use it REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464 To: yuenlim, apol, #plasma Cc: graesslin, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5461: Don't update the focused pointer Surface if a button is pressed

2017-04-15 Thread Martin Gräßlin
graesslin added a subscriber: broulik. graesslin added inline comments. INLINE COMMENTS > markg wrote in pointer_input.cpp:440 > Just curious, why do you define end as opposed tho this: > for (auto it = m_buttons.constBegin(); it != m_buttons.constEnd(); it++) { > > } > > Another route you can

D5462: [effects/slideback] Consider windows which do have painting disabled as not usable

2017-04-15 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY On Wayland it can happen that a window is still in the stacking order although it is not visible. This is mostly the case for Plasma win

D5461: Don't update the focused pointer Surface if a button is pressed

2017-04-15 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY During pointer motion we already had the condition that an update of focused pointer surface can only happen when no button is pressed.

D3571: [effects] Use arg="true" in the kcfg files

2017-04-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:2132b1e0c829: [effects] Use arg="true" in the kcfg files (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3571?vs=8703&id=13452#toc REPOSITORY R108 KWin CHANGES SINCE

D5452: Handle modifier updates in the same sequence as Wayland does

2017-04-14 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Consider the case that capslock gets pressed and released. In the case of Weston we have a sequence of: 1. Key press event 2. Mod

D5438: [plugins/qpa] Do not replace a valid FBO with an invalid one

2017-04-13 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY With the TabBox I observed the following issue: 1: trigger TabBox through screen edge 2: exit TabBox 3: trigger TabBox again thro

D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer

2017-04-13 Thread Martin Gräßlin
graesslin updated this revision to Diff 13410. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fixing arc mess REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5421?vs=13409&id=13410 BRANCH screenedge-touch-check

D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer

2017-04-13 Thread Martin Gräßlin
graesslin updated this revision to Diff 13409. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. - [plugins/qpa] Do not replace a valid FBO with an invalid one REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5421?vs=

Re: [Wayland] plasma crashes and cannot attach gdb to kwin_wayland

2017-04-13 Thread Martin Gräßlin
Am 2017-04-13 17:19, schrieb Germano Massullo: Il 13/04/2017 16:49, Martin Gräßlin ha scritto: Am 2017-04-13 16:08, schrieb Germano Massullo: Il 13/04/2017 13:12, David Edmundson ha scritto: ​"echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope" (or run GDB as root) David As root

Re: [Wayland] plasma crashes and cannot attach gdb to kwin_wayland

2017-04-13 Thread Martin Gräßlin
Am 2017-04-13 16:08, schrieb Germano Massullo: Il 13/04/2017 13:12, David Edmundson ha scritto: ​"echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope" (or run GDB as root) David As root in tty3 I attached GDB to kwin_wayland and as soon I got back to the graphical session, the system got st

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5405#101628, @stikonas wrote: > Ok, so let us not change kcoreaddons now although it's still something that could have better default behaviour in KF6. My comment was not meant as a stop-this-effort comment. If we can impr

D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer

2017-04-12 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY On X11 the edges reserved only for pointer started to show the approach geometry. This problem is addressed by this change. Touch s

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5405#101626, @ltoscano wrote: > In https://phabricator.kde.org/D5405#101624, @graesslin wrote: > > > In https://phabricator.kde.org/D5405#101621, @ltoscano wrote: > > > > > In https://phabricator.kde.org/D5405#101615, @grae

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5405#101621, @ltoscano wrote: > In https://phabricator.kde.org/D5405#101615, @graesslin wrote: > > > The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broke

D5415: [lnf] Honor the new noModifierGrab in TabBox

2017-04-12 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea9489f32a6c: [lnf] Honor the new noModifierGrab in TabBox (authored by graesslin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5415?vs=13362&id=13365

D5414: [tabbox] Expose noModifierGrab to QtQuick

2017-04-12 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:259e373bfc93: [tabbox] Expose noModifierGrab to QtQuick (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5414?vs=13361&id=13364 REVISION DETAIL

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Martin Gräßlin
graesslin added a comment. The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broken. Given that I mentioned this several times at KDE conferences, blogged about it, sent mails to KDE devel lists I assume the application ma

D5414: [tabbox] Expose noModifierGrab to QtQuick

2017-04-12 Thread Martin Gräßlin
graesslin added a dependent revision: D5415: [lnf] Honor the new noModifierGrab in TabBox. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5414 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, seb

D5415: [lnf] Honor the new noModifierGrab in TabBox

2017-04-12 Thread Martin Gräßlin
graesslin added a dependency: D5414: [tabbox] Expose noModifierGrab to QtQuick. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5415 To: graesslin, #kwin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5415: [lnf] Honor the new noModifierGrab in TabBox

2017-04-12 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When the TabBox is in the noModifierGrab mode we should activate an item when being clicked/touched. TEST PLAN Tested on X11 and Wayland

D5414: [tabbox] Expose noModifierGrab to QtQuick

2017-04-12 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There is a special mode in TabBox which is the noModifierGrab mode. This is Alt+Tab active without a modifier being hold. This mode is e

D5249: [RFC] New effect plugin - projector (keystone) correction

2017-04-11 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > nalvarez wrote in projector.cpp:101-126 > I think it would be acceptable if the cursor is drawn just like it is now, on > its own layer, even if drawing it without the transformation would make it > slightly deformed visually. > > You just hav

D5403: Support blocking of screen edges on active fullscreen windows also for touch

2017-04-11 Thread Martin Gräßlin
graesslin added a reviewer: leinir. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5403 To: graesslin, #kwin, #plasma, leinir Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D5403: Support blocking of screen edges on active fullscreen windows also for touch

2017-04-11 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change ensures that the blocking condition of screen edges is also honored for touch screen swipe gestures. TEST PLAN Only the a

D5388: Cancel popup if the user clicked window decoration of parent window

2017-04-11 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:3259d5e11326: Cancel popup if the user clicked window decoration of parent window (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5388?vs=13305

  1   2   3   4   5   6   7   8   9   10   >