D25428: Improved support for desktop "Folder View"

2020-10-01 Thread Nathaniel Graham
ngraham added a comment.


  Awesome!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham, mart
Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra


D27271: [kcms/colors] RFC: Accent Colours

2020-09-29 Thread Nathaniel Graham
ngraham added a comment.


  Could you move this and the dependent patches to Gitlab? It would be good to 
get this in for 5.21.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D17533: Make the button's purpose more clear

2020-09-28 Thread Nathaniel Graham
ngraham added a comment.


  @amantia, if you would like to continue with this, could you move it to 
invent.kde.org? as a merge request for plasma-desktop? Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17533

To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham
Cc: pino, gladhorn, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29466: [applets/appmenu] Add search to global application menu

2020-09-08 Thread Nathaniel Graham
ngraham added a comment.


  Putting it in KRunner could make at least a little bit of sense if it worked 
everywhere--i.e. with in-window menubars as well. However since it does not, I 
think the current location makes sense.
  
  Could you move this to GitLab maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: meven, ngraham, ognarb, Leon0402, trmdi, nicolasfella, gikari, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28651: Load and use global animation settings

2020-08-04 Thread Nathaniel Graham
ngraham added a comment.


  Agreed. @sandsmark, would you be interested in following up with that?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28651

To: sandsmark, #breeze, ngraham
Cc: meven, cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, 
plasma-devel, #breeze, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, trickyricky26, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28651: Load and use global animation settings

2020-08-03 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28651

To: sandsmark, #breeze, ngraham
Cc: meven, cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, 
plasma-devel, #breeze, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, trickyricky26, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28686: [Battery Monitor] Choose better wording

2020-07-16 Thread Nathaniel Graham
ngraham removed a reviewer: broulik.
ngraham added a comment.
This revision is now accepted and ready to land.


  Go ahead and land this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, #vdg, ngraham, ognarb, broulik
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-07-10 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  Cleaned this up a bit and moved it to 
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/151

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28321

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-07-09 Thread Nathaniel Graham
ngraham added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28321

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-07-06 Thread Nathaniel Graham
ngraham added a comment.


  In D24223#675737 , @Boxie wrote:
  
  > In D24223#675715 , @ngraham 
wrote:
  >
  > > Do folks have any ideas for alternative layouts that don't explicitly 
mimic other platforms?
  >
  >
  > How about a "Laptop" Layout.
  >
  > - Typically on a laptop you have a lot of horizontal space, not much 
vertical - Having the default menu on the left is a good idea for that (at 
least for languages that read left to right)
  > - A top "global menu" might get in the way here, as not all programs have a 
menu (web browsers hide it be default or have an alternative system, spotify, 
discord etc all go without)
  > - Using an Icon style task switcher to make good use of the horizontal 
space and keep battery life
  > - As laptops might be touch friendlier, having larger icons on the desktop 
and task manager and maybe the Application Dashboard too
  
  
  All of these are already the default settings except for the icons-only task 
manager being on the bottom rather than on the left edge.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: felixernst, Boxie, wstephenson, davidre, LeGast00n, enriqueme, mart, 
fabianr, Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, Orage, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra


D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-07-01 Thread Nathaniel Graham
ngraham added a comment.


  Do folks have any ideas for alternative layouts that don't explicitly mimic 
other platforms?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: felixernst, Boxie, wstephenson, davidre, LeGast00n, enriqueme, mart, 
fabianr, Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, Orage, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra


D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-06-27 Thread Nathaniel Graham
ngraham added a comment.


  I'm open to re-doing this to expose alternative layouts that don't explicitly 
mimic other platforms. The problem is, I'm not very creative in my use of this 
functionality. All I really do is put my panel on the left screen edge. I would 
need ideas for alternative layouts.
  
  Another idea is to put these explicitly-other-platform-mimicking layouts on 
store.kde.org so they're available but people need to manually download them. 
Not sure how much that would actually satisfy the original goal, though.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: Boxie, wstephenson, davidre, LeGast00n, enriqueme, mart, fabianr, Zren, 
mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, plasma-devel, Orage, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra


D16897: Allow windows to be closed from the window switchers

2020-06-24 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  Continued at 
https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/5 and 
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/115

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg, davidedmundson
Cc: graesslin, davidedmundson, abetts, Zren, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart


D29741: [Logout] Port to QQC2 and PC3

2020-06-24 Thread Nathaniel Graham
ngraham added a comment.


  Was there a reason why this never landed?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  port-logout-screen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29741

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2020-06-23 Thread Nathaniel Graham
ngraham added a comment.


  Plasma now depends on Qt 5.14. Is there anything in there that would allow 
this to move forward?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D12405

To: fvogt, #plasma
Cc: luxus, snugghash, gladhorn, mart, hein, ngraham, graesslin, davidedmundson, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra


D29140: Show POTD in lock screen

2020-06-19 Thread Nathaniel Graham
ngraham added a comment.


  Done and landed! You can close this now.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D19444: Make long menus optionally scrollable instead of always expanding horizontally

2020-06-13 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  Doesn't seem like there's interest in this.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-06-13 Thread Nathaniel Graham
ngraham added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28321

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-06-13 Thread Nathaniel Graham
ngraham added a comment.


  I'd like to land this early in the 5.20 cycle so we have lots of time for 
testing, if possible.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28321

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-06-12 Thread Nathaniel Graham
ngraham added a comment.


  We discussed this at the sprint and concluded broadly that we could move 
forward with it (once the TODOs are addressed of course). We also decided for 
T11746  that we would go with the approach 
of a sheet that lets you enable and disable parts of a global theme when you go 
to apply it.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: wstephenson, davidre, LeGast00n, enriqueme, mart, fabianr, Zren, mmustac, 
niccolove, rikmills, cblack, broulik, mvourlakos, plasma-devel, Orage, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra


D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-06-12 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma, niccolove, cblack
Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra


D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-06-12 Thread Nathaniel Graham
ngraham added a comment.


  I'm going to stand firm on 2.5x gridUnit for now. That works out to 46px, 
which is not too tall (IMO) and increases touch friendliness by a lot. Let's 
all keep in mind that this is super easily configurable.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra


D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-06-12 Thread Nathaniel Graham
ngraham added a comment.


  We discussed this and D29501  at the 
virtual plasma sprint today and concludes that we should probably do the 
horizontal version here. Nobody overtly hated the vertical version, but issues 
displaying the clock +date and system tray items were brought up and we don't 
really have a great solution for those. So let's shelve that idea for now and 
stick with this one here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra


D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-06-12 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  We discussed this and D27845  at the 
virtual plasma sprint today and concludes that we should probably do the 
horizontal version. Nobody overtly hated this proposal, but issues displaying 
the clock+date and system tray items were brought up and we don't really have a 
great solution for those. So let's shelve the idea for now and stick with this 
one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: ndavis, niccolove, felixernst, davidedmundson, ahiemstra, broulik, filipf, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI

2020-06-12 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma, mart
Cc: mart, ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-06-09 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29462

To: Zren, #kirigami, mart
Cc: davidre, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart


D29603: Adds custom spacing between task manager icons

2020-06-08 Thread Nathaniel Graham
ngraham commandeered this revision.
ngraham edited reviewers, added: martellini; removed: ngraham.
ngraham added a comment.


  Cool, thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: ngraham, #vdg, martellini
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29820: Correction when displaying "badger counter" icons using software rendering

2020-06-08 Thread Nathaniel Graham
ngraham commandeered this revision.
ngraham edited reviewers, added: brunogoncalves; removed: ngraham.
ngraham added a comment.


  This was done on GitLab, and was gated on hardware rendering being used.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29820

To: ngraham, brunogoncalves
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D29847: Fixes compile problem for freebsd because of missing crypt.h

2020-06-06 Thread Nathaniel Graham
ngraham added a reviewer: adridg.
ngraham added a subscriber: adridg.
ngraham added a comment.


  Adding @adridg as a reviewer.
  
  Note that we have moved to Gitlab, so future contributions should be 
submitted at invent.kde.org. Thanks! You can find the documentation at 
https://community.kde.org/Infrastructure/GitLab.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29847

To: usta, #plasma, bcooksley, ngraham, adridg
Cc: adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-06-04 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-06-04 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I'll fix that for you and land this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29845: Added option to change grid thickness

2020-06-03 Thread Nathaniel Graham
ngraham added a comment.


  Would it make sense to have it scale smoothly according to panel size by 
default?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29845

To: piotrkakol
Cc: gladhorn, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D29603: Adds custom spacing between task manager icons

2020-05-31 Thread Nathaniel Graham
ngraham added a comment.


  Thanks! Do you think you could maybe re-open this at 
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/? We're 
transitioning patch review over to GitLab.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: martellini, #vdg, ngraham
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29831: Update availableScreenRect when a panel moves to another screen

2020-05-29 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29831

To: akandaurov, #plasma, davidedmundson
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-28 Thread Nathaniel Graham
ngraham added a comment.


  Overall it works very well given the current plumbing here! I'll accept it 
after one little change:

INLINE COMMENTS

> touchpad.qml:294
> +
> +Controls.SpinBox {
> +id: accelSpeedSpinbox

Can you set `Layouts.Layout.minimumWidth: Kirigami.Units.gridUnit * 4` on this 
so it doesn't change in width when the numberincreases in size?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29140: Show POTD in lock screen

2020-05-26 Thread Nathaniel Graham
ngraham added a comment.


  @davidre is this better now?
  
  Also @broulik and other #plasma  
people may want to review.
  
  Finally, you might consider moving this to GitLab for greater visibility.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29603: Adds custom spacing between task manager icons

2020-05-26 Thread Nathaniel Graham
ngraham added a comment.


  Thanks! And sorry for the long delay before reviewing. However this doesn't 
seem to be working for me; no matter what value I enter, my vertical 
icons-only-task manager's icon spacing does not change.
  
  Also, instead of allowing the user to specify a pixel value, what do you 
think about using more general terminology and a combobox? For example:
  
  - "Narrow" => 2px spacing
  - "Medium" => 4px spacing
  - "Wide" => 8 px spacing
  - "Extra wide" => 12 px spacing
  
  (numbers are totally random, just for example purposes)
  
  What do you think?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: martellini, #vdg, ngraham
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27078: Drag-and-drop files at the right coordinates

2020-05-26 Thread Nathaniel Graham
ngraham closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D27078

To: painlessroaster, hein, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-26 Thread Nathaniel Graham
ngraham added a comment.


  In D29501#669458 , @ndavis wrote:
  
  > That's a good point. Is there a way to choose a different default layout 
based on info about the user's setup? I think choosing layouts based on the 
user's hardware may be necessary to get defaults that please most people while 
still being touch friendly in contexts where that is needed.
  
  
  Yes, apparently there is. See 
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/10/diffs
  
  And on that subject, it seems like doing this for ultra-widescreen displays 
would have some benefit since there a horizontal panel is sort of absurd 
because it's like 90% empty space most of the time, and the things you want to 
click on are waay far away in the corners. See also T13156 
.
  
  However I still think this makes sense as the default for everything. It's 
notably better for certain use cases (touchscreen, ultra widescreen display) 
and IMO no worse for others.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: ndavis, niccolove, felixernst, davidedmundson, ahiemstra, broulik, filipf, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-25 Thread Nathaniel Graham
ngraham added a comment.


  Sorry for the delay in reviewing this. It's on my to-do list. I'll try to 
make some time today (it is a national holiday in my country).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29827: Give users the ability to disable the microphone indicator

2020-05-24 Thread Nathaniel Graham
ngraham added a comment.


  In D29827#673734 , @kmaterka 
wrote: the system tray icon (some applications have such option).
  
  > If you don't want the icon, do not start an app in the first place
  
  
  Yeah that's not gonna be an option here.
  
  > or hide it or ask author of an app for an option to disable tray icon. 
  >  In case of Microphone Indicator, it will run and take resources, it will 
try to create an icon and will take the resources. If we give users an option 
to disable SNI icons in system tray settings it may look like disabling the 
service entirely, which is not true.
  > 
  > IMO the initial idea is good - add an option to plasma-pa settings.
  
  All right, let's continue with this then.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: kmaterka, davidedmundson, meven, bcooksley, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D29827: Give users the ability to disable the microphone indicator

2020-05-24 Thread Nathaniel Graham
ngraham added a comment.


  In D29827#673615 , @meven wrote:
  
  > In D29827#673611 , 
@davidedmundson wrote:
  >
  > > It's an SNI, I thought the systemtray could already filter SNIs in the  
enties tab of the system tray?
  >
  >
  > Currently it appears in the systray config only when the microphone is 
activated.
  >  I guess we should make it more permanent.
  
  
  Yes, that seems like a better option. Then the existing config UI will be 
used for this, and can be used to disable other SNIs too.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: davidedmundson, meven, bcooksley, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment.


  The name needs to be your full name ("Firstname Lastname"). This was a 
pre-existing requirement, it's just not enforced before patch submission, 
rather than afterwards.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: bcooksley, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28539: [Emoji panel] search when the user begins typing

2020-05-22 Thread Nathaniel Graham
ngraham closed this revision.
ngraham added a comment.


  This landed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28539

To: ngraham, apol, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment.


  You need to push to your fork of the `plasma-pa` repo, not the main location. 
`git push fork` should do it if you've set up your fork with the name `fork` as 
described in 
https://community.kde.org/Infrastructure/GitLab#Add_the_fork_to_your_source_checkout

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment.


  In D29827#673535 , @kurmikon wrote:
  
  > In D29827#673534 , @ngraham 
wrote:
  >
  > > What email? Huh?
  >
  >
  > The page you linked say I have to send an email.
  >
  > Anyway, I'm able to use git, but I don't get how to push my modification in 
my branch on my personal repository. Tried to clone on my system and push, but 
the commit is rejected.
  
  
  Emailing a merge request it just one option; you can do the standard 
fork-and-branch thing too, if you're familiar with the GitHub workflow. Anyway, 
here's some documentation: https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment.


  What email? Huh?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for the patch! KDE has since moved to GitLab at invent.kde.org/ and we 
would prefer not to use Phabricator for new patches. Could you re-submit this 
as a merge request at https://invent.kde.org/plasma/plasma-pa/-/merge_requests, 
and then Abandon this?
  
  Thanks!

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-20 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  All right, I'll abandon this revision and turn it into a Phab task: T13180: 
Make it easier to apply the wallpaper to the desktop(s), lock screen, and login 
screen all at once 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29798

To: ngraham, #vdg, #plasma
Cc: mart, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D27669: [kstyle] Tools area

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  Now disabled toolbar items don't use the disabled text color when disabled.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra


D28154: Add users KCM

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  Great, that works!
  
  BTW I think you can change the KCM name to `kcm_users` as you originally 
wanted. Sorry for saying otherwise.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra


D28154: Add users KCM

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  The avatar sheet still does not close with Esc. :/

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra


D28317: Adjust default color scheme and titlebar appearance for Tools Area

2020-05-19 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  Moved to Invent: https://invent.kde.org/plasma/breeze/-/merge_requests/3

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: cblack, ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27669: [kstyle] Tools area

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  I think this should land early in the 5.20 cycle so we have a lot of time for 
testing. However I think we need to land it alongside the new colorscheme so 
people don't get a bad first impression, or else re-work it to pull the color 
from a new "toolsarea" color set that we add to KColorScheme.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra


D20569: Use more compact OSD

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: ngraham, #plasma, #vdg, broulik, niccolove, ndavis
Cc: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, 
hein, Codezela, filipf, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart


D29333: Don't show an empty error dialog when canceling the sync password prompt

2020-05-19 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  Looked into it and concluded that PolKit/Kauth are... special.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D29333

To: ngraham, filipf, davidedmundson, #plasma
Cc: broulik, mthw, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D20569: Use more compact OSD

2020-05-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 83067.
ngraham edited the test plan for this revision.
ngraham added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20569?vs=56281=83067

BRANCH
  arcpatch-D20569_2

REVISION DETAIL
  https://phabricator.kde.org/D20569

AFFECTED FILES
  lookandfeel/contents/osd/OsdItem.qml

To: ngraham, #plasma, #vdg, broulik
Cc: kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, 
Codezela, Fuchs, filipf, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart


D20569: Use more compact OSD

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  I would like to formally re-submit this for consideration.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: ngraham, #plasma, #vdg, broulik
Cc: kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, 
Codezela, Fuchs, filipf, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart


D20569: RFC: Use more compact OSD

2020-05-19 Thread Nathaniel Graham
ngraham commandeered this revision.
ngraham added a reviewer: broulik.
ngraham added a comment.


  Yoink.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: ngraham, #plasma, #vdg, broulik
Cc: kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, 
Codezela, Fuchs, filipf, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart


D26881: [Applets/Folder View] Allow using a folder that ends with a space

2020-05-19 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  What a silly little patch this was.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26881

To: ngraham, hein, #plasma
Cc: anthonyfieroni, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 83066.
ngraham added a comment.


  Compute background color in a more colorscheme-friendly way

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29081?vs=83065=83066

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 83065.
ngraham added a comment.


  Fix non-rounded corners

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29081?vs=83064=83065

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 83064.
ngraham added a comment.


  Rebase

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29081?vs=80924=83064

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  Ah, it doesn't cherry-pick cleanly. You'll have to wait for 5.20, sorry. This 
is a good incentive to start living on git master. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29818

To: epopov, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  Oh you mean both of them. Yeah, seems reasonable.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29818

To: epopov, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29438: Use font: instead of font.pointSize: where possible

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29438

To: ngraham, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29437: Use font: instead of font.pointSize: where possible

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29437

To: ngraham, cblack, #plasma
Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  In D29818#672947 , @epopov wrote:
  
  > In D29818#672942 , @ngraham 
wrote:
  >
  > > was landed on master, not 5.19
  >
  >
  > Can it be moved to Plasma 5.19?
  
  
  Rut the regression isn't on 5.19 because it was introduced in D29652 
, which is not in 5.19.
  
  Right?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29818

To: epopov, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29818

To: epopov, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  Oops, sorry for not catching that. D29652 
 was landed on master, not 5.19, so it's 
not urgent. Thanks.
  
  Note that we have migrated to GitLab; would you mind submitting future 
patches as Merge Requests at https://invent.kde.org?  See also 
https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29818

To: epopov, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  In D29798#672886 , @mart wrote:
  
  > the length of that button text is quite daunting,  i fear imagining how 
would be in geman :p
  
  
  Indeed, and Brazilian Portuguese, and probably many others too.
  
  What are your thoughts regarding my idea above?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29798

To: ngraham, #vdg, #plasma
Cc: mart, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D24721: Show backend name and version in app delegates

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  Ping! This is an important thing to have overall; could you please submit it 
as a Merge Request at https://invent.kde.org/plasma/discover/-/merge_requests?
  
  Thanks!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24721

To: brunogoncalves, #discover_software_store, ngraham
Cc: plasma-devel, #discover_software_store, nicolaas, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, semareit, jraleigh, zachus, fbampaloukas, ragreen, 
ixoos, ZrenBot, James, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29819: Using background rectangle in icon text when in software rendering

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  We have moved to GitLab now; could you submit this as a Merge Request at 
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests?
  
  Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29819

To: brunogoncalves, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29820: Correction when displaying "badger counter" icons using software rendering

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  We have moved to GitLab now; could you submit this as a Merge Request at 
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests?
  
  Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29820

To: brunogoncalves, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29712

To: ngraham, mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29713: [applets] Show KCMs in System Settings

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29713

To: ngraham, mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29714: [applets] Show KCMs in System Settings

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29714

To: ngraham, mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29716: [applet] Show KCM in System Settings

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29716

To: ngraham, jgrulich, mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29799: [kcms/notifications] Port "no search result" message to PlaceholderMessage

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29799

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29766: [applets/taskmanager] Match default tooltip spacing in custom tooltip

2020-05-18 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29766

To: ngraham, #vdg, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29771: [Notifications] Don't take updated time into account for sorting

2020-05-18 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29771

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29785: Always use Window colorset for AbstractApplicationHeader

2020-05-18 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:5a716f3947dd: Always use Window colorset for 
AbstractApplicationHeader (authored by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29785?vs=82968=83040

REVISION DETAIL
  https://phabricator.kde.org/D29785

AFFECTED FILES
  src/styles/org.kde.desktop/AbstractApplicationHeader.qml

To: ngraham, #kirigami, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart


D29785: Always use Window colorset for AbstractApplicationHeader

2020-05-18 Thread Nathaniel Graham
ngraham added a comment.


  Not all of the headers use toolbars, but I thought the idea was for them all 
to use a consistent base appearance? @mart?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29785

To: ngraham, #kirigami, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart


D28154: Add users KCM

2020-05-17 Thread Nathaniel Graham
ngraham added a comment.


  Now that D29394  has landed, you can add 
those images here!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra


D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-16 Thread Nathaniel Graham
ngraham added a comment.


  You're probably right. This was a pretty lazy patch.
  
  The inherent challenge here is that desktop wallpapers are per-containment 
("Containment" means a screen or activity), while the lock and login screens 
are per-session. A further complication is that the login screen is only able 
to display still images (though maybe that could change?). So there isn't a 
super clean way to have a single config UI work for everything.
  
  One thing I could imagine would be the following:
  
  We make a new KCM in System Settings called "Wallpaper". This KCM essentially 
displays the current desktop wallpapers UI with one exception: it has multiple 
Apply options:
  
  - Apply to desktop //(shown when there is only one containment)//
  - Apply to current desktop //(shown when there is more than one containment)//
  - Choose which desktops to apply it to //(shown when there is more than one 
containment; needs a clever UI)//
  - Apply to all desktops //(shown when there is more than one containment)//
  - Apply to lock screen //(always shown)//
  - Apply to login screen //(always shown, but only enabled when the chosen 
wallpaper is a still image)//
  
  Maybe a sheet with these options could appear when you click on the Apply 
button. They would each be checkable, so you could apply the wallpapers to 
everything all at once if you wanted to.
  
  This is similar to how most smartphones handle this (as well as GNOME as of a 
recent version IIRC) and I think it works pretty well there.
  
  Thoughts?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29798

To: ngraham, #vdg, #plasma
Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29799: [kcms/notifications] Port "no search result" message to PlaceholderMessage

2020-05-16 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Now the appearance is consistent with other similar messages, as well as the
  one to the right of it.

TEST PLAN
  F8326167: Screenshot_20200516_085803.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  port-notifications-kcm-to-placeholdermessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29799

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-16 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This should make it a bit easier for people to change the wallpapers in all
  three places. In general I rather like the idea of adding more inter-KCM 
links like this and if people are positive about the idea, I plan to do it in
  more places

TEST PLAN
  F8326153: vokoscreenNG-2020-05-16_08-47-44.webm 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  easier-changing-lock-and-login-screen-wallpapers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29798

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-15 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for your work. Will re-review soon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28873: Add SwipeNavigator component

2020-05-15 Thread Nathaniel Graham
ngraham added a comment.


  Looking fine.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, 
plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, 
davidedmundson


D29784: Hardcode less colorSets

2020-05-15 Thread Nathaniel Graham
ngraham added a comment.


  Fixed the Kirigami half of this in D29785 
. Just address the inline comment and then 
this is good to go!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29784

To: apol, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29785: Always use Window colorset for AbstractApplicationHeader

2020-05-15 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  ...Otherwise when an `AbstractApplicationHeader` is used on a page that
  overrides the color set, such as `ScrollablePage`, the header color is
  inappropriately set to the view BG color.
  
  BUG: 421573
  FIXED-IN; 5.71

TEST PLAN
  List view of Cards and Grid view of Cards in Kirigami gallery look
  correct now: F8323628: Screenshot_20200515_113715.png 


REPOSITORY
  R169 Kirigami

BRANCH
  always-use-window-colorset-for-application-header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29785

AFFECTED FILES
  src/styles/org.kde.desktop/AbstractApplicationHeader.qml

To: ngraham, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart


D29784: Hardcode less colorSets

2020-05-15 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Now the tiny toolbar above the sidebar is a different color from the one 
beside it: F8323489: Screenshot_20200515_105617.png 

  
  It's appropriate for the views to have the view background color (off-white), 
but the toolbar is supposed to use the window background color (gray-ish), not 
the view background color. Why isn't that working?

INLINE COMMENTS

> SourcesPage.qml:27
>  
> +Kirigami.Theme.colorSet: Kirigami.Theme.View
> +Kirigami.Theme.inherit: false

These should not be needed at all

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29784

To: apol, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too

2020-05-15 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  So much better

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29770

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29765: Add a blurless SDDM theme

2020-05-15 Thread Nathaniel Graham
ngraham added a comment.


  I agree, I think we need to come up with some infrastructure to allow SDDM 
themes to display user-visible settings. Even though this new theme is mostly 
symlinks, duplicating `main.qml` is uglier and less nice maintenance-wise then 
putting conditions in it. Also shipping two themes seems less elegant than just 
making this an option in the default theme, which is what users have been 
requesting.
  
  +1 on the appearance though. It looks lovely!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29765

To: filipf, #vdg, #plasma
Cc: ngraham, mart, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D29437: Use font: instead of font.pointSize: where possible

2020-05-14 Thread Nathaniel Graham
ngraham added a comment.


  So is this good to go?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29437

To: ngraham, cblack, #plasma
Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


D29766: [applets/taskmanager] Match default tooltip spacing in custom tooltip

2020-05-14 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The Task Manager app's custom tooltips use level 5 Headings for the 
subtitles, which is
  pointless since that size is the same size as a Label with with a taller line 
height,
  which is overridden anyway.
  
  This patch makes it just use basic Labels to be consistent.

TEST PLAN
  Task Manager launcher item tooltip has same spacing between title and 
subtitle as a panel
  widget's tooltip

REPOSITORY
  R119 Plasma Desktop

BRANCH
  match-default-tooltip-spacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29766

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28873: Add SwipeNavigator component

2020-05-14 Thread Nathaniel Graham
ngraham added a comment.


  When there isn't room to show all labels, eliding the labels or collapsing 
the inactive tabs to square-ish icons-only things that are still 
clickable/touchable would seem to make more sense to me. The above screenshot 
kind of looks like a visual glitch IMO.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, 
plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, 
davidedmundson


D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-14 Thread Nathaniel Graham
ngraham added a comment.


  Typically would would bind both to the same backend value and everything 
would just magically work. However the code in this KCM is terrible, and is 
quite imperative, without using bindings properly. So you'll have to manually 
set both anywhere the slider's value is currently set, and read the value of 
both anywhere the slider's value is read.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-14 Thread Nathaniel Graham
ngraham added a comment.


  Actually sorry, I won't get to that refactor soon so I don't want to block 
your work.
  
  Is this reviewable in its current state?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


  1   2   3   4   5   6   7   8   9   10   >