T13927: Pop shell in KDE Plasma

2020-12-08 Thread Niccolò Venerandi 
niccolove added a comment.


  In T13927#245978 , @ngraham wrote:
  
  > What is "pop shell"?
  
  
  I think they are talking about pop_os customized gnome shell.

TASK DETAIL
  https://phabricator.kde.org/T13927

To: plasma-devel, niccolove
Cc: niccolove, ngraham, rafasantos, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-06-12 Thread Niccolò Venerandi 
niccolove added a comment.


  strong +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D29824: Avoid system tray resizing

2020-05-21 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Currently, there was some code to avoid system tray resizing. However, being 
the properties not set to the root element, this was not having any effect. 
This fixes it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_resize_systray (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29824

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29824: Avoid system tray resizing

2020-05-21 Thread Niccolò Venerandi 
niccolove added a comment.


  whops, this created a diff, not a MR

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29824

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: Adaptive panel opacity

2020-05-21 Thread Niccolò Venerandi 
niccolove added a comment.


  Ping @davidedmundson ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-20 Thread Niccolò Venerandi 
niccolove added a comment.


  I agree with a single KCM called wallpapers used to set all wallpaper in 
System Settings. Not a fan of having so many apply buttons, but I'm sure we can 
come up with something good.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29798

To: ngraham, #vdg, #plasma
Cc: mart, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-16 Thread Niccolò Venerandi 
niccolove added a comment.


  I'm a bit torn about this. It is indeed very nice, but at the same time I 
don't feel like it's the right solution. Ignoring minor complaints I'd have 
("it's a very large button!") it doesn't feel right that the user, in order to 
change login wallpaper, would think that they have to right click on the 
desktop, click on edit desktop, click on "login and logout settings", and then 
change it. I think two other solutions that _might_ be better are:
  
  - Decide that login and lockscreen wallpapers are part of the desktop as much 
as the desktop wallpaper (which doesn't make sense tech-wise, but it might make 
sense user-wise), rename "Wallpaper" to "Desktop Wallpaper" in the Desktop 
Settings KCM and embed directly there "Lockscreen Wallpaper" and "Login screen 
theme". This would mean
- Splitting the "Appearance" tab from the Screen Locking KCM to a new KCM 
called "Lockscreen Wallpaper" which would be in the customize desktop window, 
thus making the content of the Screen Locking KCM just the "activation tab", 
but adding a button "customize wallpaper..." which would open the "Lockscreen 
Wallpaper" KCM
- Doing the same with the "Login Screen" KCM, which would be split in 
"Login Screen Theme" KCM (shown in customize desktop) and "Login Screen" KCM 
(shown in SySe) only containing what now is in the "Advanced" tab, but with a 
"Customize theme..." at the top. OR - probably better - have only one "Login 
Screen" KCM which only shows the theme selector and is both on the "customize 
desktop" and current location in system settings, and add "Advanced" as a 
button that open up a new kirigami page rather than using tabs.
- All of which kinda feel ugly from a "let's categorize things based on how 
they work under the hood" point of view, but instead it could make sense from a 
"let's categorize things based on what the user expects" point of view.
  - OR, show the desktop configuration KCM is system settings, and somehow 
create a category there for wallpapers?
  - OR we just go with what you are proposing. I'm not against it, but I feel 
it's more of a "limiting damage" than a "let's fix the problem at the root"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29798

To: ngraham, #vdg, #plasma
Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: Adaptive panel opacity

2020-05-13 Thread Niccolò Venerandi 
niccolove added a comment.


  In D28627#652806 , @ngraham wrote:
  
  > In D28627#652538 , @niccolove 
wrote:
  >
  > > Actually -- this seems to no longer apply panel internal margins?
  >
  >
  > Works for me.
  
  
  But then you post a video where the panel has no internal margins :P
  Give a look to the task manager: normally, there's a margin between it and 
panel border. This patch currently removes the margin set by the desktop theme.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D29264: New tabs for Breeze

2020-05-12 Thread Niccolò Venerandi 
niccolove added a comment.


  +1 for the direction!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: niccolove, manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, 
Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D29570: Fix some alignments

2020-05-12 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:de52cb8944e8: Fix some alignments (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29570?vs=82389=82631

REVISION DETAIL
  https://phabricator.kde.org/D29570

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: ndavis, abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D29603: Adds custom spacing between task manager icons

2020-05-11 Thread Niccolò Venerandi 
niccolove added a comment.


  Are we really sure this is worth exposing to the user?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: martellini, #vdg
Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29570: Fix some alignments

2020-05-11 Thread Niccolò Venerandi 
niccolove added inline comments.

INLINE COMMENTS

> ndavis wrote in PowerManagementItem.qml:34
> How does this affect RTL layouts?

It does look a bit too close on the right border in LTS. I guess I should add a 
rightMargin here?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixspacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29570

To: niccolove, #vdg, #plasma, ngraham
Cc: ndavis, abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D29570: Fix some alignments

2020-05-09 Thread Niccolò Venerandi 
niccolove added a comment.


  For some reason, the heading is still one or two pixels off... still, much 
better than before

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29570

To: niccolove, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29570: Fix some alignments

2020-05-09 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This fixes some wrong alignments

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixspacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29570

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-09 Thread Niccolò Venerandi 
niccolove added a comment.


  Generic +1 to the idea, but:
  
  - I would not go higher than 50 as panel width
  - The clock is too small, it probably needs a version where there's a new 
line between hour and minutes
  - We should check that all widgets work correctly in a vertical panel

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: niccolove, felixernst, davidedmundson, ahiemstra, broulik, filipf, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Niccolò Venerandi 
niccolove accepted this revision as: niccolove.
niccolove added a comment.
This revision is now accepted and ready to land.


  VDG wise, this looks good and consistent.

REPOSITORY
  R31 Breeze

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove
Cc: niccolove, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29490: This removes the negative top margin, as it's already removed by the NotificationPopup

2020-05-06 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:571f0aba2fc5: This removes the negative top margin, as 
its already removed by the… (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29490?vs=82129=82145

REVISION DETAIL
  https://phabricator.kde.org/D29490

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29490: This removes the negative top margin, as it's already removed by the NotificationPopup

2020-05-06 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  The negative top margin was not necessary and causes missing round corners.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix_top_margin_of_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29490

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7e4b0979: Add inHistory bool and hide heading on 
inHistory (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29474?vs=82066=82128

REVISION DETAIL
  https://phabricator.kde.org/D29474

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This hides the plasmoidHeading on history for not grouped notifications

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_heading_for_ungrouped (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29474

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bf6b8353a73f: Fix various bugs introduced with heading 
(authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=82062=82065

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 82062.
niccolove added a comment.


  Remove inHistory change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=82060=82062

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi 
niccolove added a comment.


  Sorry, I'll make a different patch for that

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi 
niccolove requested review of this revision.
niccolove marked 4 inline comments as done.
niccolove added a comment.


  I added one last thing: I feel like it was not a good idea to show the 
heading in history for notifications that are not in group. I added a inHistory 
bool, false by default, that's set true in FullRepresentation for notifications 
that are in history. Heading is not shown for any notification in the history.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 82060.
niccolove added a comment.


  Address feedback and add inHistory bool

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81791=82060

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-03 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81791.
niccolove added a comment.


  Fix very long application names

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81750=81791

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-02 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81750.
niccolove added a comment.


  Fix very long notification titles

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81748=81750

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-02 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81748.
niccolove added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81733=81748

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-02 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81733.
niccolove added a comment.


  Move lineSvg to root element

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81732=81733

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-02 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81732.
niccolove added a comment.


  Fix visibility

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81730=81732

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-02 Thread Niccolò Venerandi 
niccolove planned changes to this revision.
niccolove added a comment.


  Ah, there's a mistake on visibility, just a sec

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-02 Thread Niccolò Venerandi 
niccolove added a comment.


  Keyboard navigation is now working again; however, pressing tab to focus 
buttons seem to no longer be possible after this patch; looking at the code, 
I'm given the impression that it was true before porting notifications to page 
as well. Is that correct, or should I investigate tabbing?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-02 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81730.
niccolove added a comment.


  Fix keyboard navigation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81727=81730

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-02 Thread Niccolò Venerandi 
niccolove added a comment.


  I used the Svg instead of the plasmoidHeading to avoid using a Control. 
User-wise, it works correctly, but can I get your opinion code-wise?

INLINE COMMENTS

> broulik wrote in FullRepresentation.qml:454
> Move the `Svg` somewhere outside the delegate, I don't want multiple 
> instances of it

I'm a bit confused here. The PlasmaCore.svg{id: lineSvg...} element was inside 
a different PlasmaCore.SvgItem that I removed. So what I did was essentially to 
move it from that SvgItem to this SvgItem. That one is the only instance of 
PlasmaCore.Svg.

> broulik wrote in NotificationItem.qml:125
> hm, ok

I moved it in a RowLayout to remove the necessity of checking altogether 
(otherwise, I should've put anchors.margins AND layout.margins for each case 
and it would've have been quite ugly imo)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-05-02 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81727.
niccolove added a comment.


  Remove plasmoidHeading element as it's a control

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81389=81727

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-04-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81389.
niccolove added a comment.


  Fix close button not clickable

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81372=81389

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-04-27 Thread Niccolò Venerandi 
niccolove added inline comments.

INLINE COMMENTS

> broulik wrote in NotificationItem.qml:125
> Please use one of the `State` below for `inGroup` state

I originally did this but I had a problem. It displays and works just as good, 
but it will throw a "you are using anchors in layouts" error in the console. 
Even though I disable the anchors in the propertychanges, it seems like the 
property is updated after throwing the error.

> broulik wrote in NotificationItem.qml:139
> This `MouseArea` should not be necessary and it makes the close button 
> unusable

Why shouldn't it be necessary?  PlasmoidHeading inherits from the Control 
element, which does not let click events through according to the 
documentation, so I thought I'd need to catch them on top of it.

Regarding the close button unusable, it's due to the order of the elements, 
I'll fix it immediately

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-04-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81372.
niccolove added a comment.


  Fix spacing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81368=81372

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-04-27 Thread Niccolò Venerandi 
niccolove planned changes to this revision.
niccolove added a comment.


  Ahh, this adds top margin in history. Let me fix.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-04-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81368.
niccolove added a comment.


  Missing space

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81367=81368

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-04-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81367.
niccolove added a comment.


  unrelated pt3

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81366=81367

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-04-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81366.
niccolove added a comment.


  Unrelated pt2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81365=81366

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-04-27 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81365.
niccolove added a comment.


  Remove unrelated

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81364=81365

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

2020-04-27 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This fixes:
  
  - Indented notifications line (it's back)
  - Heading being non-clickable
  - Buttons not being right-aligned in history
  
  I'm unsure about my usage of cursorShape: Qt.PointingHandCursor in MouseArea; 
is this correct, or should I use a different component?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29142: Add footer support to systray

2020-04-26 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0f28094f584c: Add footer support to systray (authored by 
niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29142?vs=81184=81221

REVISION DETAIL
  https://phabricator.kde.org/D29142

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29142: Add footer support to systray

2020-04-25 Thread Niccolò Venerandi 
niccolove added a comment.


  Should work now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29142

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29142: Add footer support to systray

2020-04-25 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81184.
niccolove added a comment.


  Set height correctly code and more concise code

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29142?vs=81183=81184

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29142

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29142: Add footer support to systray

2020-04-25 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81183.
niccolove edited the summary of this revision.
niccolove added a comment.


  Fix bars not disappearing when switching to a component without page

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29142?vs=81046=81183

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29142

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29142: Add footer support to systray

2020-04-24 Thread Niccolò Venerandi 
niccolove added a comment.


  Sorry! I'll double check from now on.

INLINE COMMENTS

> ngraham wrote in PlasmoidPopupsContainer.qml:38
> Nothing was using this?

Nothing

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29142

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-04-23 Thread Niccolò Venerandi 
niccolove added a comment.


  Size should be an even number
  
  - For sizes from 36 to 40, I'm OK with it
  - At 42 and 44 the icons in the task manager become too big for the panel; 
their size should be reduced to same as the launcher button, then it's fine
  - At 46 and over it's fine

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D29142: Add footer support to systray

2020-04-23 Thread Niccolò Venerandi 
niccolove created this revision.
niccolove added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29142

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

2020-04-23 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0a7b99bb6ae1: Added plasmoidHeading to clipboard and 
ported to Page (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29137?vs=81038=81044

REVISION DETAIL
  https://phabricator.kde.org/D29137

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/clipboard.qml

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

2020-04-23 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81038.
niccolove added a comment.


  Added margin

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29137?vs=81037=81038

BRANCH
  clipboard_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29137

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/clipboard.qml

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

2020-04-23 Thread Niccolò Venerandi 
niccolove added a comment.


  In D29137#655936 , @ngraham wrote:
  
  > Thanks! Implementation-wise, I would have re-arranged things a bit to have 
only one header for the `PC3.Page`, with the contents changing depending on the 
page in the stack, rather than your approach of giving each page in the stack 
its own header, but that works fine too and it's perfectly valid so I'll accept 
it.
  
  
  That was my first though, but the headings often use variables defined in 
their files which means that I should have brought everything to be one file or 
deal with passing variables though files. This felt cleaner and I guess it 
could scale better to new types of pages.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29137

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

2020-04-23 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 81037.
niccolove added a comment.


  Rebase and enabled

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29137?vs=81036=81037

BRANCH
  clipboard_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29137

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/clipboard.qml

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

2020-04-23 Thread Niccolò Venerandi 
niccolove added a comment.


  Heh, I just noticed :P

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29137

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

2020-04-23 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  clipboard_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29137

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/clipboard.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-22 Thread Niccolò Venerandi 
niccolove accepted this revision.
niccolove added a comment.
This revision is now accepted and ready to land.


  Yeah, I agree. I see that this behavior is consistent, so I'll accept it.

REPOSITORY
  R97 Bluedevil

BRANCH
  port-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-22 Thread Niccolò Venerandi 
niccolove added a comment.


  Correct, but shouldn't the focus state stop after button press, or when I 
click away, or at least when I close the applet? Or am I getting the concept of 
focus wrong?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28996: Converted to page and added heading

2020-04-22 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:a876b365bb22: Converted to page and added heading 
(authored by niccolove).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28996?vs=80589=80940

REVISION DETAIL
  https://phabricator.kde.org/D28996

AFFECTED FILES
  applet/contents/ui/main.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28996: Converted to page and added heading

2020-04-22 Thread Niccolò Venerandi 
niccolove added a comment.


  In D28996#652157 , @ngraham wrote:
  
  > Great! However the footer looks a bit weird since it doesn't touch the 
edges: F8247573: Screenshot_20200419_154306.png 

  
  
  True but it's unrelated to this patch - it's system tray cutting off 
everything that is outside of the applet container. I want to address that in 
another patch

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28996

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-22 Thread Niccolò Venerandi 
niccolove added a comment.


  It seems like the button never gets out of hovered state:
  F8254176: Screenshot_20200422_231804.png 


REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28873: Add SwipeNavigator component

2020-04-21 Thread Niccolò Venerandi 
niccolove added a comment.


  In D28873#652724 , @mart wrote:
  
  > for those that are a sidebar, there is already a standard, agreed upon 
look, that is being slowly and painfully moved to be adopted, which is:
  >  F8249505: Screenshot_20200420_180317.png 

  
  
  I agree that that element has the same function on navigating views. I think 
that either this tasks uses that appearance on desktops (which would kill the 
"horizontal navigation"), or KCM should switch to whatever look this tasks ends 
up using (which I'm more in favor of). That's what I was trying to discuss in 
T11153 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg, ngraham
Cc: ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D28627: Adaptive panel opacity

2020-04-20 Thread Niccolò Venerandi 
niccolove added a comment.


  Actually -- this seems to no longer apply panel internal margins?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28627: Adaptive panel opacity

2020-04-20 Thread Niccolò Venerandi 
niccolove accepted this revision.
niccolove added a comment.


  Works great!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28996: Converted to page and added heading

2020-04-19 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  screenshots coming

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28996

AFFECTED FILES
  applet/contents/ui/main.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-19 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7d0a74721c5f: Converted to page and added Heading 
(authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28576?vs=79484=80583

REVISION DETAIL
  https://phabricator.kde.org/D28576

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-16 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R97:4a8adbaeac4e: Converted to Page with a PlasmoidHeading in 
the heading (authored by niccolove).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=80324=80327

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

2020-04-16 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1a6b40cb5e0e: Make headings of systray and applet merge 
(authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=80315=80326

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 80324.
niccolove added a comment.


  rebase x3

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=80321=80324

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 80321.
niccolove added a comment.


  rebase x2

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=80320=80321

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 80320.
niccolove added a comment.


  rebase

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=79889=80320

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-16 Thread Niccolò Venerandi 
niccolove added a comment.


  In D28467#649913 , @ngraham wrote:
  
  > Hmm, seems broke:
  >
  >   
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/FullRepresentation.qml:145:1:
 Expected token `}'
  >
  
  
  Forgot to rebase 若

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-16 Thread Niccolò Venerandi 
niccolove requested review of this revision.
niccolove added a comment.


  Should finally work with latest D28575 

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

2020-04-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 80315.
niccolove added a comment.


  third one's a charm

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=80314=80315

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28575: Make headings of systray and applet merge

2020-04-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 80314.
niccolove added a comment.


  try 2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=80313=80314

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28575: Make headings of systray and applet merge

2020-04-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 80313.
niccolove added a comment.


  Only merge if header is actually visible

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79483=80313

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28873: Add SwipeNavigator component

2020-04-16 Thread Niccolò Venerandi 
niccolove added inline comments.

INLINE COMMENTS

> mart wrote in SwipeNavigator.qml:55
> different tabbars should really depend only on whether it's a mobile device 
> or not (and be at bottom if mobile): a very small window on desktop is not a 
> mobile app

I think the tabbar should not be at the bottom on mobile. It's not necessary to 
touch the control as swiping from any point of the page should change the page, 
it is more visible when put at top, it is more consistent with kde and not-kde 
applications and introduces a position inconsistency between devices 
(touchscreen laptops should also be taken into consideration).

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28873: Add SwipeNavigator component

2020-04-16 Thread Niccolò Venerandi 
niccolove added a comment.


  My opinion from the consistency side: I actually think this is a good 
possibility for the Consistency goal. After some digging around, my opinion is 
that
  
  > Tabs should only be used on application views that are user-editable (eg: 
when it's possible to open a new tab or close another).
  
  It's imo appropriate to have a different component for changing views, 
especially on Kiri. But of course, that component should be consistent. Right 
now we have big square sidebars, toolbars, etc etc etc etc etc
  
  F8241366: image.png 
  
  I think that this component //could// be a good solution, because we have a 
similar topbar on Maui:
  F8241370: photo_2020-04-16_10-22-45.jpg 
  Plus, this navigation view is really easy to replicate with toolbars (stupid 
wrong example, but you get what I mean):
  F8241377: Screenshot_20200416_102417.png 

  And this patch could add them for Kirigami as well.
  
  Of course, this assumes that some other stuff goes well:
  
  - Pressed buttons in toolbars should use highlight style (1px opaque line all 
around)
  - Possibly, buttons in toolbars should have an option to disable text if 
there's not enough space and they are not pressed
  - Apps should be okay with moving to a top centered mutually exclusive 
toolbuttons for navigating views
  - This patch should also use such highlight style
  - Possibly, Maui should drop his appviews component and use this one since it 
does the same thing, so this patch should coordinate with them and make sure 
this is feature-even
  
  We wouldn't get "swipe to change view" on qwidgets, but it's mostly for 
desktop so I think it's fine.
  
  For reference, I had done some consistency mockups in the past and this idea 
was already there:
  F8241385: image.png 
  
  A problem I see is that most application have a high number of views that 
won't fit horizontal space with labels (I'm looking at Skrooge, KMyMoney, 
Kontact, ...). Should they be fine with only displaying label for the current 
one? They probably would prefer a sidebar, which we currently don't 
consistently offer, so we end up with various inconsistent implementations.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-14 Thread Niccolò Venerandi 
niccolove added inline comments.

INLINE COMMENTS

> ngraham wrote in FullRepresentation.qml:31
> the visibility should be dependent on it having any items in it; or else it's 
> still visible when Bluetooth is disabled.

I though that was done by

  toolbar.visible = (state == "DevicesState" || state == "NoDevicesState");

At the end of the file. If you try to use the widget standalone, you will 
notice that it does disappear. Problem is, system tray doesn't notice. I can't 
understand why it doesn't read the ".visible" property.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: Adaptive panel opacity

2020-04-13 Thread Niccolò Venerandi 
niccolove added a comment.


  I feel like it makes sense for the user to want to use a opaque panel rather 
than a transparent one. Also, that relies on themes actually turning on the 
effect, while users could already benefit from it even on current themes if the 
setting was exposed. Also, that allows for making only some panels adaptive, 
unity-stile.  However, as far as I know, there's no [easy] way to detect 
transparency from the theme. I might be wrong here.
  
  - During the transition from transparent to opaque, the panel becomes 
immediately gray and then trasitions. I guess that's because you turn off blur 
at the beginning of the animation?
  - This should also be implemented for plasmoids popups as well, in order for 
them to integrate correctly:
  
  F8234048: Screenshot_20200413_171827.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28627: WIP: Made panel opaque on maximized window

2020-04-12 Thread Niccolò Venerandi 
niccolove added a comment.


  I have a question though: we ship the pager widget in the panel that does the 
same by default. Wouldn't that have the same efficiency impact, if not even 
more?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: niccolove, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-12 Thread Niccolò Venerandi 
niccolove added a comment.


  In D28467#646626 , @ngraham wrote:
  
  > Does `activeApplet.fullRepresentationItem` actually have a `header` 
property?
  
  
  Yes. I tried to console log it (...header) and it returns Toolbar qml 
element, which is correct, and the element supposed to have the visible 
property.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-11 Thread Niccolò Venerandi 
niccolove added a comment.


  I need a small help for the second one. When there's no toolbar, the 
toolbar.visible is set to false; otherwise, it's true. But when I'm in the 
systemtray and I try to check 
activeApplet.fullRepresentationItem.header.visible, it always returns false. 
What could that be?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-11 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79889.
niccolove added a comment.


  Removed extra line

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=79155=79889

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: WIP: Made panel opaque on maximized window

2020-04-07 Thread Niccolò Venerandi 
niccolove added a comment.


  > You're rendering a transparent panel. we're still even blurring the 
background very expensively. And then we're drawing something on top. That's 
very wasteful.
  >  We're also mixing up shadows from one SVG with the output of another.
  
  Right. Originally I just changed the svg to be opaque, but I couldn't get a 
transition out of it. Also, I guess this doesn't solve the blurring problem.
  
  > Also our isMaximised detection is horrific.
  
  What do you mean with our? Is the way I used TaskManager very wrong (quite 
possible) or is the window.isMaximized implementation bad in win?
  
  > We also need to think about how this plays in with other themes. You can't 
assume everyone uses Breeze.
  
  I checked this. It always fallback to Breeze opaque background following the 
theme colors, so it should always work without breaking them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: niccolove, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: WIP: Made panel opaque on maximized window

2020-04-07 Thread Niccolò Venerandi 
niccolove added a comment.


  Thanks Nate for explaining.
  
  Couple of things that hit my mind:
  
  - Plasmoids should also be opaque, to be fully integrated:
  
  F8223607: Screenshot_20200407_191202.png 

  Should I have very similiar code in the applet code as well, or is there a 
better way to implement it?
  
  - Currently, when I switch from a fullscreen app to an empty desktop it 
doesn't get back to transparent, which is weird, I'll investigate that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: niccolove, #plasma
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27979: Add top area to notifications

2020-04-07 Thread Niccolò Venerandi 
niccolove added a comment.


  In D27979#643330 , @ngraham wrote:
  
  > So I think the padding issue isn't related to fonts after all. I noticed 
while doing a backup today that there's no spacing between the header and the 
content underneath it even when there's no text.
  
  
  I'm sorry, what do you mean with "no text"?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27979

To: niccolove, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: WIP: Made panel opaque on maximized window

2020-04-06 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  The idea is to offer an option, possibly default, to make the panel opaque 
when a window is maximized on the same screen. 
  There are a couple of things missing:
  
  - An option to disable it
  - Making opaque/ background svg same as transparent but opaque (so without 
outline but with shadow)
  - This probably makes all panel opaque if you maximize a window on a screen, 
when you have 2+ screens on a single virtual desktop
  
  Still, I opened the diff to get some feedback on the implementation

REPOSITORY
  R119 Plasma Desktop

BRANCH
  adaptive_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28627

AFFECTED FILES
  desktoppackage/contents/views/Panel.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-06 Thread Niccolò Venerandi 
niccolove added a comment.


  Ok, should be fine now

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

To: niccolove, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79484.
niccolove added a comment.


  Fixed layouts

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28576?vs=79347=79484

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

2020-04-06 Thread Niccolò Venerandi 
niccolove added a comment.


  Should be fixed now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

2020-04-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79483.
niccolove added a comment.


  Unnecessary newline

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79482=79483

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

2020-04-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79482.
niccolove added a comment.


  There was a wrong spacing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79477=79482

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

2020-04-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79477.
niccolove added a comment.


  Generic fixes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79344=79477

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28576: Converted to page and added Heading

2020-04-06 Thread Niccolò Venerandi 
niccolove added a comment.


  Yes, also the notifications don't fill width, just noticed, I'm investigating

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

To: niccolove, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-04 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79347.
niccolove added a comment.


  Fixed context menu

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28576?vs=79346=79347

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

2020-04-04 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  As per D28575 , converted the FullRepr to 
be a Page and added a PlasmoidHeading
  
  Result:
  
  (...)

TEST PLAN
  Test with D28575 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

2020-04-04 Thread Niccolò Venerandi 
niccolove added a comment.


  In D28467#640854 , @ngraham wrote:
  
  > So here's what I see in the system tray popup: F8213414: 
Screenshot_20200403_102113.png 
  >
  > The toolbar doesn't touch the edges of its surroundings, so there's a 
differently-colored margin around it.
  
  
  It's correct, because the systray has clipping disabled. But fear not, as 
D28575  is here :P

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

2020-04-04 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  When the applet is a page with a plasmoidHeading as header, merge it with 
systray one.
  Screenshots incoming.
  
  The only big problem is that it looks bad when you open said applet while in 
sidebar view, see:

REPOSITORY
  R120 Plasma Workspace

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

  1   2   3   >