D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Vladimir Yerilov]

yerilov added a comment.


  Thanks @apol 
  I've built it from your branch and testing it now. Here is a list of issues I 
have faced so far:
  
  1. Layout switch doesn't work on Lock screen. Visually layouts are shown as 
switched, but actually it's always English.
  2. I have 3 layouts: EurKey, Russian and Mozc (fcitx). All work fine except 
for normal layouts are not indicated in tray with their respective names (ru, 
eu). When switching to Mozc, it's icon shows up as expected.
  3. Switching laouts with "Main shift key" (like Alt+Shift or Win+Space) only 
works for ru<->eu, mozc isn't triggered, although "Cycle through layouts" 
shortcut (Ctrl+Alt+K as by default) allows switching to Mozc.
  4. This is of course more of design thing but adding new layout is such a 
pain now: the dialog window is small, list area inside is tiny, searching for 
"Russian" shows huge amount of possible variants and to find and select a 
needed one is not a simple task, given the fact that the scrollbar is small and 
navigation with keyboard arrow keys is not possible.
  5. Each layout in Keyboard kcm has its settings invoked by "Configure" 
button, but when trying to configure Mozc this way its dialog appears blank, 
then entire systemsettings5 segfaults:
  
$ systemsettings5
Icon theme "elementary" not found.
Icon theme "elementary" not found.
QVariant(FcitxQtInputMethodItemList, )
Icon theme "elementary" not found.
"grp" "Switching to another layout"
"lv3" "Key to choose the 3rd level"
QQmlExpression: Expression 
file:///home/openm/kde/usr/share/kpackage/kcms/kcm_keyboard/contents/ui/Layouts.qml:187:13
 depends on non-NOTIFYable properties:
LayoutConfigModel::thirdLevelShortcutModel
QQmlExpression: Expression 
file:///home/openm/kde/usr/share/kpackage/kcms/kcm_keyboard/contents/ui/Layouts.qml:173:13
 depends on non-NOTIFYable properties:
LayoutConfigModel::mainShiftKeyModel
"Keyboard model \"\" not detected"

file:///home/openm/kde/usr/lib/qml/org/kde/kirigami.2/templates/InlineMessage.qml:136:
 TypeError: Value is undefined and could not be converted to an object

file:///home/openm/kde/usr/lib/qml/org/kde/kirigami.2/private/globaltoolbar/PageRowGlobalToolBarUI.qml:71:
 TypeError: Cannot read property 'actions' of null

file:///home/openm/kde/usr/lib/qml/org/kde/kirigami.2/templates/AbstractApplicationHeader.qml:46:5:
 Unable to assign QQuickItem_QML_136 to Page_QMLTYPE_28

file:///home/openm/kde/usr/lib/qml/org/kde/kirigami.2/private/globaltoolbar/BreadcrumbControl.qml:71:21:
 Unable to assign QQuickItem_QML_136 to Page_QMLTYPE_28
QQmlEngine::setContextForObject(): Object already has a QQmlContext
kcm_touchpad: Using X11 backend
QQmlEngine::setContextForObject(): Object already has a QQmlContext
qml: Touchpad configuration of device '1 : ETD2303:00 04F3:3083 Touchpad' 
opened
"eu" false ""
"ru" false ""
"fcitx:mozc" false ""
"1 instead of 2 arguments to message {The input support fo...} supplied 
before conversion."
"eu"
0
Cannot open config description file
Cannot open config description file
fish: “systemsettings5” terminated by signal SIGSEGV (Address boundary 
error)
  
  In order to have fcitx working I used to have .pam_environment with the 
following content:
  
XMODIFIERS=@im=fcitx
GTK_IM_MODULE=fcitx
QT_IM_MODULE=fcitx
DefaultIMModule=fcitx
  
  I don't know if I still need it.
  
  My overall impression is there's lot of things to polish but in general this 
is a //huge// step in the right direction.
  I am ready to test it anytime.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: davideichelsdoerfer, yerilov, kucharczyk, lavender, ngraham, apol, 
plasma-devel, hein, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, ahiemstra, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  @ngraham yeah this is the best way to go as it seems to me. What I did was 
just drawing attention to this problem since I cannot code and it's hard to 
understand how everything works for a non-coder.
  @ltoscano I'd vote for any solution which makes Notes more configurable with 
respect to pasting of formatted text.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  @ltoscano D22774  added the ability to 
choose between paste with and without formatting in the context menu, so yes, 
no problem with distinguishing.
  Adding another shortcut like Ctrl+Shift+V is also a viable solution but these 
kinds (any kinds) of complex shortcuts have more chance to conflict with 
various things like input method switching (fcitx, ibus invoke or IM switch). 
One more reason to revive D14796  which was 
undeservingly abandoned btw. In fact, it won't (I've checked with 
fcitx/kimpanel) but that's another story.
  
  Seems like I gonna stick with my txt file on the desktop, okay, I had to try 
anyway.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  > Do those applications provide the paste-with-formatting action too?
  
  No they don't. So it is one more thing that actually makes Plasma more 
feature-rich DE.
  
  > When you talk about "pastes text", "paste it", etc, which way do you mean?
  
  Well, we're running in circles here. Until everyone here understands which 
paste options Notes applet has now and had before any discussion is useless.
  
  One last time, to clarify how it was, how it is, and how it was proposed to 
be:
  
  1. Until https://phabricator.kde.org/D22774 Notes default paste option was 
"paste with formatting", which was named "Paste" in menu and invoked by Ctrl+V. 
This is how it was.
  2. https://phabricator.kde.org/D22774 changed the default paste option to 
"paste without formatting" and renamed it to "Paste without Formatting", making 
Ctrl+V to paste without formatting. This is how it is as of 5.16.80.
  3. What I propose is to simply rename the menu option introduced by 
https://phabricator.kde.org/D22774, "Paste without Formatting" to "Paste" 
again, but preserve the actual action and Ctrl+V shortcut, and rename another 
(next) option from "Paste" to "Paste With Formatting" in order to make a clear 
difference between the two options in menu. This is how is suggested to be. 
Cosmetic but looks better and in accordance with the expectations of the end 
user (broadly speaking).
  
  Arguing about another applications is irrelevant due to the nature of the 
Notes applet: it is not an application like MS Word, it serves another purpose. 
Needless to say that we all know now that there are some KDE apps like Kate or 
KWrite or KolourPaint (more than one) which have no Paste with formatting 
option at all, this is why any try to argue like "all other KDE application 
have this behavior by default" would contradict the reality.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  Talking about cross-platform: Windows Notes app pastes text with no 
formatting, as Gnome Sticky Notes do, even Android apps do not use pasting with 
formatting by default.
  Yep, I understand expecting pasting with formatting for Office apps, but for 
Notes widget it is more of an additional option.
  I don't know how to explain it more clearly. Just suggest to copy some part 
of, say, Manjaro Linux forum main page and paste it with formatting no Notes. 
That's hardly a thing any user would expect to see in any notes applet on any 
platform.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  Funny thing: I stopped using Notes due to this formatting thing so long ago 
that I cannot remember when exactly. There's a plaintext Kate file on my 
desktop instead.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  @huftis 
  Having thought about this I guess I have my attitude towards the default 
`Ctlr+V` 'Paste' action: it should be without formatting. I can explain why. 
Notes applet is not an application. The reason it exists is to contain quick 
notes and tasks, memos, etc. Such text objects may come from various sources 
with heavy formatting, but Notes //is not// a web page or document processor, 
it shouldn't default to display potentially //hard to read// text (given the 
size of the applet) as a result of `Ctrl+C - Ctrl+V` pasting. Being not an 
application means it can behave differently in some aspects, that's why I find 
the comparison between this applet and other applications //irrelevant//.
  But not only that. Open Kate pls and try to find "Paste with Formatting" 
there. Try to paste some text from this page there. You'll see there's no 
formatting. But Kate is an application, quite powerful one. And //no// 
formatting.
  From the other side, having an way to paste formatted text is quite a neat 
option, that's why I guess it's better to have it untouched (I mean no reason 
to remove it).
  
  > least surprise.
  
  Well, try to Ctrl+V your own comment to Notes on 5.16.5 (it defaults to Paste 
with formatting here). What I see immediately is an ugly white-on-yellow text 
background which comes w/o no doubt from this page formatting. This is actual 
surprise for anyone who wants to make memos.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Vladimir Yerilov]

yerilov added a comment.


  This fails to build now.
  
  > The longer we wait, the harder it will be to integrate
  
  So true.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: davideichelsdoerfer, yerilov, kucharczyk, lavender, ngraham, apol, 
plasma-devel, hein, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  I have no objections regarding default action, be it paste with or w/o 
formatting, it's rather a common sense fix: name what we use for Ctrl+V as 
"Paste", but and another action should get more detailed description. It also 
looks good in menu:
  
_
|   |
| Paste  Ctrl+V |
|   |
| Paste With Formatting |
|   |
-

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: broulik, yurchor, ltoscano, aacid, #localization, yerilov, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  Thanks Nate :)
  Actually it's rational to change `documentHandler.pasteWithoutFormatting()` 
handler as well, but I'm afraid I'm not good at coding to make such amendments.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: yurchor, ltoscano, aacid, #localization, yerilov, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov created this revision.
yerilov added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
yerilov requested review of this revision.

REVISION SUMMARY
  Since this action is the default for Ctrl+V shortcut it should be named just 
"Paste". Hence the other option has to be renamed to "Paste With Formatting" 
accordingly.

TEST PLAN
  build'n'test this Notes applet's context menu

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: yerilov, ngraham
Cc: yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart