D29140: Show POTD in lock screen

guoyunhe added a comment. Also in KDE Invent. https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/3 Can someone review it? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, davidre, broulik Cc: davidre, ngraham,

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82996. guoyunhe added a comment. No delete engine and watcher REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82994=82996 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82994. guoyunhe added a comment. Remove unused slots REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82993=82994 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82993. guoyunhe added a comment. Fix leaks REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82821=82993 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Show POTD in lock screen

guoyunhe added a comment. Maybe it is some unknown Qt bug. You can try set wallpaper as Flickr POTD and check if you have `~/.cache/plasmashell/plasma_engine_potd/flickr` saved. Anyway, for photos, JPEG makes more sense than PNG. For the leaks, I really have no idea. (also asked some

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82821. guoyunhe added a comment. Code improvement REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82819=82821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82819. guoyunhe marked 9 inline comments as done. guoyunhe added a comment. Fix small issues REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82635=82819 BRANCH master REVISION DETAIL

D29140: Show POTD in lock screen

guoyunhe marked 9 inline comments as done. guoyunhe added inline comments. INLINE COMMENTS > davidre wrote in CMakeLists.txt:44 > Seems unused? It is necessary for the KDED module. Without it, the compilation fails. > davidre wrote in CMakeLists.txt:68 > unrelated Will revert. > davidre

D29140: Fix POTD in lock screen (complete)

guoyunhe updated this revision to Diff 82635. guoyunhe added a comment. Fix watcher when file is recreated REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82632=82635 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140

D29140: Fix POTD in lock screen (complete)

guoyunhe added a comment. @ngraham the kded module is working now. please have a look! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29140: Fix POTD in lock screen (partly)

guoyunhe updated this revision to Diff 82632. guoyunhe added a comment. Fix config file path REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82620=82632 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Fix POTD in lock screen (partly)

guoyunhe added a comment. I created the kded service and it seems running. But it doesn't cache the image as I expected. Don't know how to debug it. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, ngraham Cc: davidre, ngraham,

D29140: Fix POTD in lock screen (partly)

guoyunhe updated this revision to Diff 82620. guoyunhe added a comment. Clean up libraries REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82619=82620 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Fix POTD in lock screen (partly)

guoyunhe updated this revision to Diff 82619. guoyunhe added a comment. Add file watcher REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82610=82619 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Fix POTD in lock screen (partly)

guoyunhe updated this revision to Diff 82610. guoyunhe added a comment. Draft for PoTD KDED. Not tested. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=81064=82610 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140

D29140: Fix POTD in lock screen (partly)

guoyunhe added a comment. I was looking for kded documentation but cannot find a good example. Do you know any? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n,

D29625: Add global shortcut

guoyunhe updated this revision to Diff 82532. guoyunhe added a comment. Create symlink REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29625?vs=82515=82532 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29625 AFFECTED FILES

D29625: Add global shortcut

guoyunhe updated this revision to Diff 82515. guoyunhe added a comment. Use KGlobalAccel instead REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29625?vs=82508=82515 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29625 AFFECTED

D29625: Add global shortcut

guoyunhe added a comment. In D29625#668190 , @ognarb wrote: > I think khotkeys is deprecated: https://phabricator.kde.org/T2050 Not yet, it is delayed to KF6. REPOSITORY R124 System Settings REVISION DETAIL

D29625: Add global shortcut

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The "Tools" key is function key in some laptops. In ThinkPad + Windows, when you press that key, it will open Control Panel or

D22700: Sync scaling DPI from Plasma to SDDM

guoyunhe added a comment. In D22700#662323 , @filipf wrote: > In D22700#662134 , @guoyunhe wrote: > > > When I press the synchronize button, it looks like the `-dpi 144` (scale x1.5) option makes

D22700: Sync scaling DPI from Plasma to SDDM

guoyunhe added a comment. When I press the synchronize button, it looks like the `-dpi 144` (scale x1.5) option makes the UI elements huge (feel like x2 scale or more): F8280985: IMG_20200503_152810.jpg REPOSITORY R123 SDDM Configuration Panel

D29140: Fix POTD in lock screen (partly)

guoyunhe added a comment. Anyway, this patch just focus on fixing the cache issue. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29140: Fix POTD in lock screen (partly)

guoyunhe added a comment. To totally solve the issue, there are several solutions I can find: 1. POTD need to have a daemon process that can always access network. The lock screen send request to the daemon through DBus or other protocol. 2. Create an invisible lock screen widget in

D29140: Fix POTD in lock screen (partly)

guoyunhe updated this revision to Diff 81064. guoyunhe added a comment. Fix APOD and Flicker provider cache REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=81043=81064 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140

D29140: Fix POTD in lock screen (partly)

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY POTD was cached in `~/.cache/`. But lock screen seems not a process of current user, so it won't find the cache in user's home

D29040: Use colorful icon instead of monochrome icon for touchpad kcm

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Use icons from preferences folder instead of devices folder. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D27915: Use breeze icons for categories

guoyunhe added a comment. In D27915#623862 , @davidre wrote: > In D27915#623859 , @guoyunhe wrote: > > > In D27915#623854 , @davidre wrote: > > > > >

D27915: Use breeze icons for categories

guoyunhe added a comment. In D27915#623854 , @davidre wrote: > There is something wrong on your system, this is how before looks for me: > F8163706: Screenshot_20200307_171017.PNG Please ignore

D27915: Use breeze icons for categories

guoyunhe updated this revision to Diff 77174. guoyunhe added a comment. Change object-group to object REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27915?vs=77172=77174 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27915

D27915: Use breeze icons for categories

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27915 AFFECTED FILES

D27770: HiDPI improvement of left panel

guoyunhe abandoned this revision. guoyunhe marked an inline comment as done. guoyunhe added a comment. I think there can be better solution. Use Breeze icons in the left panel instead of rendering the emoji. Reference design in Telegram Desktop: F8145244: image.png

D27770: HiDPI improvement of left panel

guoyunhe marked an inline comment as done. guoyunhe added inline comments. INLINE COMMENTS > davidedmundson wrote in emojier.cpp:83 > this is broken Reverted REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27770 To: guoyunhe, #plasma, davidedmundson Cc:

D27770: HiDPI improvement of left panel

guoyunhe updated this revision to Diff 76758. guoyunhe added a comment. Fix size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27770?vs=76741=76758 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27770 AFFECTED FILES

D27770: HiDPI improvement of left panel

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27770 AFFECTED FILES

D27556: HiDPI pixmap

guoyunhe marked an inline comment as done. guoyunhe added inline comments. INLINE COMMENTS > anthonyfieroni wrote in AuthDialog.cpp:108 > You wanna use `devicePixelRatioF` right? Fixed thanks! REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D27556

D27556: HiDPI pixmap

guoyunhe updated this revision to Diff 76146. guoyunhe marked 2 inline comments as done. guoyunhe added a comment. Change devicePixelRatio() to devicePixelRatioF() REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27556?vs=76145=76146

D27556: HiDPI pixmap

guoyunhe marked 2 inline comments as done. guoyunhe added inline comments. INLINE COMMENTS > apol wrote in AuthDialog.cpp:108 > You should get the dpr from the window, not the qApp. Different screens will > have different dprs. Fixed. Getting it from widget now. > apol wrote in

D27556: HiDPI pixmap

guoyunhe updated this revision to Diff 76145. guoyunhe added a comment. Get DPR from widget instead of app REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27556?vs=76128=76145 BRANCH master REVISION DETAIL

D27556: HiDPI pixmap

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Make the big icon at left side sharp in HiDPI screen. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH master REVISION

D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display

guoyunhe added a comment. CPU/IO Plasma widgets work pretty well in HiDPI screen. It should be solved if we make it a QML component, reusing the part from Plasma widgets. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D23831 To: guoyunhe, #plasma Cc:

D25459: fix(kcm): improve i18n of device combobox

guoyunhe added a comment. It seems impossible to align them if they are not in one QML file. `twinFormLayouts` can only refer ids of current context. This happens in several different KCMs. Would be great to have a solution for global alignment. But I think that need some changes to

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

guoyunhe added a comment. If your use `as QQC2` in your imports, `ComboBox` need to be changed to `QQC2.ComboBox`. INLINE COMMENTS > MetadataEditor.qml:108 > } > ComboBox { > id: licenseField This need to be changed to `QQC2.ComboBox`

D25459: fix(kcm): improve i18n of device combobox

guoyunhe added a comment. Should we reassign a reviewer? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25459 To: guoyunhe, kde-i18n-doc, #plasma, #localization, broulik Cc: romangg, broulik, ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe added a comment. I didn't find good solutions for QQC2. It has been a blocker for a long time https://bugs.kde.org/show_bug.cgi?id=403153 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25369 To: guoyunhe, #plasma, ngraham Cc: broulik, plasma-devel,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. In D25381#566128 , @ndavis wrote: > `oxygen-demo5` Thanks for the tip! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma, ngraham, ndavis Cc: ndavis,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. Yes, this patch needs minimization. What is the software in your screenshot? @ndavis REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma, ngraham, ndavis Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n,

D25459: Device ComboBox: fix label and layout

guoyunhe updated this revision to Diff 70151. guoyunhe added a comment. update commit message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25459?vs=70149=70151 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25459 AFFECTED FILES

D25459: Device ComboBox: fix label and layout

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The original label cause i18n problems, the parameter %1 is never given. The layout doesn't fit the form. This patch uses

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. I checked all KCM modules, the bottom row of buttons are all in same height (like the smaller button in your screenshot). Have you tried reboot? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma, ngraham

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. @ngraham which applications are they? I didn't see similar thing in my system. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma, ngraham Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe updated this revision to Diff 70059. guoyunhe added a comment. Force height consistency REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25381?vs=69954=70059 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25381 AFFECTED FILES

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. The remaining 1px difference between QPushButton and QLineEdit is caused by content. QLineEdit directly expands from its content size, while QPushButton calculate size of text metrics and icons. REPOSITORY R31 Breeze REVISION DETAIL

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. Left: JuK (Qt Widgets), Right: Elisa (Qt QML) F7771662: image.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma Cc: ndavis, GB_2, ngraham, plasma-devel,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. In QML applications, buttons and line edits are already same height, the same height as QLineEdit in Qt Widgets applications. If we increase the height of QLineEdit, we have to change QML components' height, too. The amount of work will be bigger. If a view

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. In D25381#564404 , @ndavis wrote: > If we do make flat toolbuttons buttons (`autoRaise == true`) and non-flat buttons the same size, we will need to change the default icon size for all buttons to 22px, or we will have

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. In D25381#564370 , @ngraham wrote: > +1 conceptually, this will be nice to finally have fixed. > > But might the opposite make more sense? If we make buttons shorter, we're slightly reducing their click targets, but

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. In D25381#564378 , @GB_2 wrote: > Plus in the screenshot it looks like it's still not quite the same height. Yes, still 1px taller :( REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY BUG 411811 REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D25381 AFFECTED FILES

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe added a comment. In D25354#564187 , @ngraham wrote: > 5.17 branch please. Not sure if I did it correctly... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25354 To: guoyunhe, #plasma, ngraham

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe updated this revision to Diff 69931. guoyunhe added a comment. Fix typo REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25369?vs=69930=69931 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25369 AFFECTED FILES

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe added a comment. In D25369#564159 , @ngraham wrote: > Thanks! Can you add an explanation in the description section of this patch as to why you're removing the Description strings? Added. REPOSITORY R114 Plasma Addons

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe updated this revision to Diff 69930. guoyunhe added a comment. Keep old translations REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25369?vs=69928=69930 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25369 AFFECTED FILES

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe updated this revision to Diff 69929. guoyunhe added a comment. Move string changes to another patch REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25354?vs=69922=69929 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25354

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY QtQuick Controls 2 ComboBox doesn't handle long option well. Short names can solve the issue of D25354

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe updated this revision to Diff 69922. guoyunhe edited the summary of this revision. guoyunhe added a comment. Shorten POTD provider names and remove descriptions that are never used anywhere. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe added a comment. Another approach is to shorten the texts: F7769821: image.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25354 To: guoyunhe, #plasma Cc: ngraham, plasma-devel, LeGast00n,

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY BUG: 412976 TEST PLAN Open Lock Screen KCM. Change wallpaper type to Picture of The Day. Check the ComboBox of POTD.

D25319: Fix issues from D24798 comments by @davidedmundson

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Lower QQC2 version to minimum requirement. Add context to i18nc function. Cannot use `i18ncp` because the number isn't integer.

D24798: Migrate QQC1 to QQC2

guoyunhe added a comment. I also tried to not use ScrollView but enable ListView's scrollbar: ListView { // add scrollbar, background and border clip: true flickableDirection: Flickable.VerticalFlick boundsBehavior: Flickable.StopAtBounds

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69739. guoyunhe added a comment. Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69730. guoyunhe added a comment. Enable keyboard navigation and proper highlight REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69705=69730 BRANCH master REVISION DETAIL

D24798: Migrate QQC1 to QQC2

guoyunhe added a comment. Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager: F7762797: image.png It also miss the border in the connection list. REPOSITORY R120 Plasma Workspace

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69705. guoyunhe added a comment. Prefix QQC2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69703=69705 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 AFFECTED FILES

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69703. guoyunhe added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69701=69703 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 AFFECTED FILES

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69701. guoyunhe added a comment. Add QQC2 namespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=68733=69701 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 AFFECTED FILES

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 68733. guoyunhe added a comment. Merge kmaterka's patch D24853 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=68345=68733 BRANCH master REVISION DETAIL

D24798: Migrate QQC1 to QQC2

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change. REPOSITORY

D24727: Fix NOAA picture of the day provider

guoyunhe updated this revision to Diff 68225. guoyunhe added a comment. Validate QUrl of image REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24727?vs=68185=68225 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24727 AFFECTED FILES

D24727: Fix NOAA picture of the day provider

guoyunhe added a comment. In D24727#549327 , @ngraham wrote: > Still broken, I'm afraid. Among the console output is the following, which may be helpful: > > kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg") >

D24727: Fix NOAA picture of the day provider

guoyunhe updated this revision to Diff 68185. guoyunhe edited the summary of this revision. guoyunhe added a comment. Change back to the original page URL REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24727?vs=68126=68185 BRANCH master REVISION

D24727: Fix NOAA picture of the day provider

guoyunhe added a comment. In D24727#549199 , @ngraham wrote: > This doesn't fix the problem for me. :( Can you run `plasmashell --replace` in terminal and check the error output? REPOSITORY R114 Plasma Addons REVISION DETAIL

D24727: Fix NOAA picture of the day provider

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The webpage structure of NOAA changed so the old regular expression doesn't work anymore. Updated it. But it can break in future

D24424: Create kf5-network.directory

guoyunhe updated this revision to Diff 67366. guoyunhe added a comment. Change icon name to applications-network REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24424?vs=67350=67366 BRANCH master REVISION DETAIL

D24424: Create kf5-network.directory

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY See D24423 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D24409: Remove kf5-toys.directory because it will not be used by other packages

guoyunhe added a comment. Reverted https://cgit.kde.org/plasma-workspace.git/commit/?id=0e14429e7355e07913ea21ab03abde6dc1ae8a1f REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24409 To: guoyunhe, #plasma_workspaces, ngraham Cc: ltoscano, aacid, ngraham,

D24409: Remove kf5-toys.directory because it will not be used by other packages

guoyunhe added a comment. D24384 has been accepted and seems no one strongly against it... So I landed it. Can you give this patch an approval? @davidedmundson REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24409 To:

D24409: Remove kf5-toys.directory because it will not be used by other packages

guoyunhe added subscribers: ngraham, aacid. guoyunhe added a comment. In D24409#541894 , @davidedmundson wrote: > Ship it (if and only if the other patch is also accepted) The other patch is accepted by @ngraham . But @aacid has

D24409: Remove kf5-toys.directory because it will not be used by other packages

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY See also D24384 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66229. guoyunhe added a comment. Rename and move the find duplicate button REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66193=66229 BRANCH master REVISION DETAIL

D6813: Use customized font size for Digital Clock applet

guoyunhe abandoned this revision. guoyunhe added a comment. It seems not possible to set font size because others insist the font size should grow with panel. Another alternative widget might be better way to push forward. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D17704: Copy to clipboard always copy English texts

guoyunhe added a comment. Yes, this can be closed because another approach is more useful. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17704 To: guoyunhe, #plasma, davidedmundson Cc: davidedmundson, ngraham, gregormi, cfeck, plasma-devel, LeGast00n,

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66193. guoyunhe added a comment. Fix size policy REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66191=66193 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23868 AFFECTED FILES

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66191. guoyunhe added a comment. Avoid scrollbar. Put progressbar and font status to another row. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66157=66191 BRANCH master REVISION DETAIL

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66157. guoyunhe added a comment. Similar filter layout as Colors KCM. Move "Scan Duplicates..." button to the bottom button group. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66101=66157 BRANCH

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe added a comment. Now I can get something like this (the QLineEdit and QPushButton still have different height): F7357403: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe,

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe added a comment. In D23868#532016 , @ngraham wrote: > Maybe in the interests of #consistency , let's make the filter feature look the same way that it does in the Colors KCM: F7357040:

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66101. guoyunhe added a comment. Unify button look REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66074=66101 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23868 AFFECTED FILES

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe added a comment. I changed it to QToolButton, but it still look different: F7352361: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe, #plasma, ngraham Cc: ngraham, plasma-devel,

D23868: kfontinst HiDPI icons

guoyunhe updated this revision to Diff 66074. guoyunhe added a comment. Change icon name. To match patch D23942 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=65841=66074 BRANCH master REVISION

  1   2   3   >