This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE8dbda77a3b8a: systemmonitor: Optimise source
updates. (authored by roberts).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
roberts added reviewers: Plasma, apol.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3141
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: roberts, #plasma, apol
Cc: plasma-devel, lesliezhai, ali-mohamed,
roberts created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Profiling indicates the highest CPU usage process during idle is the
system monitor engine. This attempts to get rid of the most obvious
roberts accepted this revision.
roberts added a reviewer: roberts.
roberts added a comment.
This revision is now accepted and ready to land.
Looks good to me now.
REPOSITORY
rKWAYLAND KWayland
BRANCH
plasma-window-icon
REVISION DETAIL
https://phabricator.kde.org/D3049
EMAIL
roberts added inline comments.
INLINE COMMENTS
> plasmawindowmanagement.cpp:489
> +n = QT_READ(fd, buf, sizeof buf);
> +if (n == -1 && (errno == EAGAIN) && ++retryCount < 1000) {
> +usleep(1000);
EAGAIN comes from reads of O_NONBLOCK fd's, but this seems to be a
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE749f60b89f4a: Systray: Move all icon
resolution to dataengine (authored by roberts).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
roberts updated this revision to Diff 7230.
roberts added a comment.
Recreated diff with arc.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2986?vs=7215=7230
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2986
roberts updated this revision to Diff 7215.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2986?vs=7214=7215
REVISION DETAIL
https://phabricator.kde.org/D2986
AFFECTED FILES
applets/systemtray/package/contents/ui/ConfigEntries.qml
roberts created this revision.
roberts added reviewers: mart, Plasma.
roberts set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
roberts added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Changes triggered by investigation