D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme
This revision was automatically updated to reflect the committed changes. Closed by commit R98:fa8e67c617f3: [GTK3] Recolor CSD titlebuttons according to users color scheme (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23451?vs=64698=64700 REVISION DETAIL https://phabricator.kde.org/D23451 AFFECTED FILES src/assets/breeze-close-active-symbolic.svg src/assets/breeze-close-hover-symbolic.svg src/assets/breeze-close-symbolic.svg src/assets/breeze-maximize-active-symbolic.svg src/assets/breeze-maximize-hover-symbolic.svg src/assets/breeze-maximize-symbolic.svg src/assets/breeze-maximized-active-symbolic.svg src/assets/breeze-maximized-hover-symbolic.svg src/assets/breeze-maximized-symbolic.svg src/assets/breeze-minimize-active-symbolic.svg src/assets/breeze-minimize-hover-symbolic.svg src/assets/breeze-minimize-symbolic.svg src/build_theme.sh src/gtk3/applications/_chromium.scss src/gtk3/widgets/_window_decorations.scss To: cblack, #breeze, #vdg, ngraham, ognarb Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme
ognarb accepted this revision. ognarb added a comment. Much better now thanks :) REPOSITORY R98 Breeze for Gtk BRANCH window-button-symbolics (branched from master) REVISION DETAIL https://phabricator.kde.org/D23451 To: cblack, #breeze, #vdg, ngraham, ognarb Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme
cblack updated this revision to Diff 64698. cblack added a comment. DRY that code REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23451?vs=64606=64698 BRANCH window-button-symbolics (branched from master) REVISION DETAIL https://phabricator.kde.org/D23451 AFFECTED FILES src/assets/breeze-close-active-symbolic.svg src/assets/breeze-close-hover-symbolic.svg src/assets/breeze-close-symbolic.svg src/assets/breeze-maximize-active-symbolic.svg src/assets/breeze-maximize-hover-symbolic.svg src/assets/breeze-maximize-symbolic.svg src/assets/breeze-maximized-active-symbolic.svg src/assets/breeze-maximized-hover-symbolic.svg src/assets/breeze-maximized-symbolic.svg src/assets/breeze-minimize-active-symbolic.svg src/assets/breeze-minimize-hover-symbolic.svg src/assets/breeze-minimize-symbolic.svg src/build_theme.sh src/gtk3/applications/_chromium.scss src/gtk3/widgets/_window_decorations.scss To: cblack, #breeze, #vdg, ngraham Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme
ognarb added a comment. Could it be possible to remove most of the code duplication between _window_decorations.scss and _chromium.scss? REPOSITORY R98 Breeze for Gtk BRANCH window-button-symbolics (branched from master) REVISION DETAIL https://phabricator.kde.org/D23451 To: cblack, #breeze, #vdg, ngraham Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme
cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Window titlebuttons on CSD windows now respect the user's colorscheme, preventing colorschemes such as Breeze Light, which has black on white instead of white on dark window buttons, from having barely discernable window buttons. REPOSITORY R98 Breeze for Gtk BRANCH window-button-symbolics (branched from master) REVISION DETAIL https://phabricator.kde.org/D23451 AFFECTED FILES src/assets/breeze-close-active-symbolic.svg src/assets/breeze-close-hover-symbolic.svg src/assets/breeze-close-symbolic.svg src/assets/breeze-maximize-active-symbolic.svg src/assets/breeze-maximize-hover-symbolic.svg src/assets/breeze-maximize-symbolic.svg src/assets/breeze-maximized-active-symbolic.svg src/assets/breeze-maximized-hover-symbolic.svg src/assets/breeze-maximized-symbolic.svg src/assets/breeze-minimize-active-symbolic.svg src/assets/breeze-minimize-hover-symbolic.svg src/assets/breeze-minimize-symbolic.svg src/build_theme.sh src/gtk3/applications/_chromium.scss src/gtk3/widgets/_window_decorations.scss To: cblack, #breeze, #vdg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
