davidedmundson added a comment.
Due to a confusing design notification objects can delete themselves.
If the network changes after the notification is externally closed this will
crash.
INLINE COMMENTS
> portalmonitor.h:42
> +private:
> +KNotification *m_notification = nullptr;
>
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1ffef126b8f0: Captive portal notification improvements
(authored by jgrulich).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Being in an airport right now myself (as is Harald, I imagine), I'm able to
test this immediately. :) Works great, shipit, and sorry for introducing this
regression when I made the
jgrulich updated this revision to Diff 71660.
jgrulich added a comment.
: - Notification might be already closed
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26042?vs=71659=71660
BRANCH
captive-portal-improvements
REVISION
jgrulich created this revision.
jgrulich added reviewers: ngraham, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.
REVISION SUMMARY
Do not duplicate captive portal notifications and close them when we are no
longer
