D27421: [Cuttleffish] Use proper QSortFilterProxyModel
This revision was automatically updated to reflect the committed changes. Closed by commit R118:2bae103fa66e: [Cuttleffish] Use proper QSortFilterProxyModel (authored by davidre). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27421?vs=77171=77399#toc REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27421?vs=77171=77399 REVISION DETAIL https://phabricator.kde.org/D27421 AFFECTED FILES cuttlefish/autotests/CMakeLists.txt cuttlefish/autotests/iconmodeltest.cpp cuttlefish/package/contents/ui/IconGrid.qml cuttlefish/package/contents/ui/IconGridDelegate.qml cuttlefish/package/contents/ui/Tools.qml cuttlefish/src/CMakeLists.txt cuttlefish/src/iconmodel.cpp cuttlefish/src/iconmodel.h cuttlefish/src/main.cpp cuttlefish/src/sortfiltermodel.cpp cuttlefish/src/sortfiltermodel.h To: davidre, #plasma, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27421: [Cuttleffish] Use proper QSortFilterProxyModel
davidre updated this revision to Diff 77171. davidre added a comment. Remove members that are not needed anymore REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27421?vs=75742=77171 BRANCH searchproxy (branched from master) REVISION DETAIL https://phabricator.kde.org/D27421 AFFECTED FILES cuttlefish/autotests/CMakeLists.txt cuttlefish/autotests/iconmodeltest.cpp cuttlefish/package/contents/ui/IconGrid.qml cuttlefish/package/contents/ui/IconGridDelegate.qml cuttlefish/package/contents/ui/Tools.qml cuttlefish/src/CMakeLists.txt cuttlefish/src/iconmodel.cpp cuttlefish/src/iconmodel.h cuttlefish/src/main.cpp cuttlefish/src/sortfiltermodel.cpp cuttlefish/src/sortfiltermodel.h To: davidre, #plasma Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27421: [Cuttleffish] Use proper QSortFilterProxyModel
apol added inline comments. INLINE COMMENTS > iconmodel.h:100 > QStringList m_icons; > QString m_category; > QStringList m_categories; m_category can be removed? > iconmodel.h:102 > QStringList m_categories; > QString m_filter; > QHash m_data; m_filter can be removed now, right? REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D27421 To: davidre, #plasma Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27421: [Cuttleffish] Use proper QSortFilterProxyModel
davidre added a comment. Ping REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D27421 To: davidre, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27421: [Cuttleffish] Use proper QSortFilterProxyModel
davidre updated this revision to Diff 75742. davidre added a comment. Add new files REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27421?vs=75741=75742 BRANCH searchproxy (branched from master) REVISION DETAIL https://phabricator.kde.org/D27421 AFFECTED FILES cuttlefish/autotests/CMakeLists.txt cuttlefish/autotests/iconmodeltest.cpp cuttlefish/package/contents/ui/IconGrid.qml cuttlefish/package/contents/ui/IconGridDelegate.qml cuttlefish/package/contents/ui/Tools.qml cuttlefish/src/CMakeLists.txt cuttlefish/src/iconmodel.cpp cuttlefish/src/iconmodel.h cuttlefish/src/main.cpp cuttlefish/src/sortfiltermodel.cpp cuttlefish/src/sortfiltermodel.h To: davidre Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27421: [Cuttleffish] Use proper QSortFilterProxyModel
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Don't reload everything when filter or category is changed. Fixes selected icon changing when filtering and the first icon not being selectd when the current icon is selected. TEST PLAN select and filter REPOSITORY R118 Plasma SDK BRANCH searchproxy (branched from master) REVISION DETAIL https://phabricator.kde.org/D27421 AFFECTED FILES cuttlefish/autotests/CMakeLists.txt cuttlefish/autotests/iconmodeltest.cpp cuttlefish/package/contents/ui/IconGrid.qml cuttlefish/package/contents/ui/IconGridDelegate.qml cuttlefish/package/contents/ui/Tools.qml cuttlefish/src/CMakeLists.txt cuttlefish/src/iconmodel.cpp cuttlefish/src/iconmodel.h cuttlefish/src/main.cpp To: davidre Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
