D27577: [KCM]Fix content below scrollbars

This revision was automatically updated to reflect the committed changes. Closed by commit R115:552b0384ffd2: [KCM]Fix content below scrollbars (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76467=76836

D27577: [KCM]Fix content below scrollbars

ngraham added a comment. +1, go ahead REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. I don't see any objections, will push to stable. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ngraham, apol, plasma-devel,

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76467. gvgeo added a comment. Added item as a proxy for the devices and applications. This fixed the vertical binding loop. And made scrollbar touch the top and botoom edges. With this patch content is closer, by smallSpacing, to the frame. And

D27577: [KCM]Fix content below scrollbars

ngraham added a comment. We can wait a bit to get more eyes on it and target 5.18.3. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ngraham, apol,

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. Today for 5.18.2 or can wait? Apol only looked the code for the first change. And I don't know why vertical margins create bind loop, or if Item as a proxy is good. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION

D27577: [KCM]Fix content below scrollbars

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D27577#616919 , @gvgeo wrote: > > The other change to center labels > > They were already centered. Oops, my bad. Seems

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. I would not call them stylistic choice, the position didn't change. And there are included in description. Make Header always fit inside the scrollview area. They had 2 different problems, when the text is too big. As enabled they would cut text left and

D27577: [KCM]Fix content below scrollbars

ngraham added a comment. As far as I can tell, the other four changes are related to the scrollbar/view sizing/positioning. The other change to center labels may fix an issue, but it still represents a stylistic change. It should either be in a separate patch, or else it needs to be

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. In D27577#616579 , @ngraham wrote: > The changes to labels in `Header.qml` seem unrelated. They are as related as the other 4 changes are. Either will make 5 different patches or 1. But I'm not going to change

D27577: [KCM]Fix content below scrollbars

ngraham added a comment. The changes to labels in `Header.qml` seem unrelated. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76202. gvgeo added a comment. typo REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76201=76202 BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76201. gvgeo added a comment. Make scrollbars touch the side of the frame. Fit speaker test grid inside the scrollview area. Fix advanced content layout. Make Header always fit inside the scrollview area. REPOSITORY R115 Plasma Audio Volume Applet

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76200. gvgeo edited the test plan for this revision. gvgeo added a comment. Changed comment. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76173=76200 BRANCH scrollbars (branched from

D27577: [KCM]Fix content below scrollbars

gvgeo added inline comments. INLINE COMMENTS > Advanced.qml:33 > +// TODO Fix contentview width, and Remove policy. > +ScrollBar.horizontal.policy: ScrollBar.AlwaysOff > > What if there's too many devices? No matter how many devices there are, column is always a column. > It doesn't

D27577: [KCM]Fix content below scrollbars

apol added inline comments. INLINE COMMENTS > Advanced.qml:33 > +// TODO Fix contentview width, and Remove policy. > +ScrollBar.horizontal.policy: ScrollBar.AlwaysOff > What if there's too many devices? It doesn't sound like a good solution to hide the ScrollBar forever. Also what

D27577: [KCM]Fix content below scrollbars

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Set content to use available space. BUG:416331 BUG:417447 TEST PLAN Open audio