Re: Discover requires Qt 5.7?

2016-09-22 Thread Marco Martin
On Thursday 22 September 2016 15:40:22 Aleix Pol wrote: > > wait, isn't looking for it at build time? O.o > > of course it should do that > > > > -- > > Marco Martin > > It is now. awesome :) -- Marco Martin

Re: Discover requires Qt 5.7?

2016-09-22 Thread Aleix Pol
On Thu, Sep 22, 2016 at 2:59 PM, Marco Martin wrote: > On Thursday 22 September 2016 14:42:04 Matthias Klumpp wrote: >> One addition: If Kirigami is missing on the system, Discover will >> build but simply crash on startup - so, we should make the application >> handle this

Re: Discover requires Qt 5.7?

2016-09-22 Thread Marco Martin
On Thursday 22 September 2016 14:42:04 Matthias Klumpp wrote: > One addition: If Kirigami is missing on the system, Discover will > build but simply crash on startup - so, we should make the application > handle this case better (= not crash) or simply depend on Kirigami at > build-time, so people

Re: Discover requires Qt 5.7?

2016-09-22 Thread Matthias Klumpp
2016-09-22 14:36 GMT+02:00 Matthias Klumpp : > 2016-09-22 13:15 GMT+02:00 Jonathan Riddell : >> On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote: >>> On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: >>> > Hi, >>> > >>> >

Re: Discover requires Qt 5.7?

2016-09-22 Thread Matthias Klumpp
2016-09-22 13:15 GMT+02:00 Jonathan Riddell : > On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote: >> On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: >> > Hi, >> > >> > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although >> >

Re: Discover requires Qt 5.7?

2016-09-22 Thread Jonathan Riddell
On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote: > On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: > > Hi, > > > > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although > > CMakeLists.txt claims Qt 5.2 is required (which seems to be too low

Re: Discover requires Qt 5.7?

2016-09-22 Thread Aleix Pol
On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: > Hi, > > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although > CMakeLists.txt claims Qt 5.2 is required (which seems to be too low anyway). > > Can you please either replace qAsConst() with const_cast or

Re: Discover requires Qt 5.7?

2016-09-22 Thread Marco Martin
On Thursday 22 September 2016 10:58:42 Harald Sitter wrote: > Dropping qasconst won't help. Discover wants kirigami master which > uses qtquickcontrols2 templates which IIRC was only introduced in Qt > 5.7, so discover needs 5.7 through kirigami I think. no, kirigami master doesn't use

Re: Discover requires Qt 5.7?

2016-09-22 Thread Harald Sitter
Dropping qasconst won't help. Discover wants kirigami master which uses qtquickcontrols2 templates which IIRC was only introduced in Qt 5.7, so discover needs 5.7 through kirigami I think. On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil wrote: > Hi, > > Discover 5.7.95 requires

Discover requires Qt 5.7?

2016-09-22 Thread Daniel Vrátil
Hi, Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although CMakeLists.txt claims Qt 5.2 is required (which seems to be too low anyway). Can you please either replace qAsConst() with const_cast or bump the Qt dependency? Thanks, Dan [0]