Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/#review26828 --- Ship it! Ship It! - Marco Martin On Feb. 7, 2013, 1:22 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/ --- (Updated Feb. 7, 2013, 1:22 a.m.) Review request for Plasma and Marco Martin. Description --- Whenever I started muon-discover I had a lot of issues from QPainter. After some investigation (gdb + breakpoint to qWarning) I found out the problem was that we were trying to render a QIcon with size equal to 0. This patch makes sure that we don't even try to paint empty icons, which solves the problem. Diffs - plasma/declarativeimports/core/iconitem.cpp 765e7ed Diff: http://git.reviewboard.kde.org/r/108825/diff/ Testing --- After patching, ran discover again, without all the qWarnings. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/#review26828 --- On Feb. 7, 2013, 1:22 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/ --- (Updated Feb. 7, 2013, 1:22 a.m.) Review request for Plasma and Marco Martin. Description --- Whenever I started muon-discover I had a lot of issues from QPainter. After some investigation (gdb + breakpoint to qWarning) I found out the problem was that we were trying to render a QIcon with size equal to 0. This patch makes sure that we don't even try to paint empty icons, which solves the problem. Diffs - plasma/declarativeimports/core/iconitem.cpp 765e7ed Diff: http://git.reviewboard.kde.org/r/108825/diff/ Testing --- After patching, ran discover again, without all the qWarnings. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! Marco Martin wrote: ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable Uh ok... Can't we just merge commits? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/#review26828 --- On Feb. 7, 2013, 1:22 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/ --- (Updated Feb. 7, 2013, 1:22 a.m.) Review request for Plasma and Marco Martin. Description --- Whenever I started muon-discover I had a lot of issues from QPainter. After some investigation (gdb + breakpoint to qWarning) I found out the problem was that we were trying to render a QIcon with size equal to 0. This patch makes sure that we don't even try to paint empty icons, which solves the problem. Diffs - plasma/declarativeimports/core/iconitem.cpp 765e7ed Diff: http://git.reviewboard.kde.org/r/108825/diff/ Testing --- After patching, ran discover again, without all the qWarnings. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! Marco Martin wrote: ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable Aleix Pol Gonzalez wrote: Uh ok... Can't we just merge commits? uuh, don't know being in a different repository, different path, but whatever it works - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/#review26828 --- On Feb. 7, 2013, 1:22 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/ --- (Updated Feb. 7, 2013, 1:22 a.m.) Review request for Plasma and Marco Martin. Description --- Whenever I started muon-discover I had a lot of issues from QPainter. After some investigation (gdb + breakpoint to qWarning) I found out the problem was that we were trying to render a QIcon with size equal to 0. This patch makes sure that we don't even try to paint empty icons, which solves the problem. Diffs - plasma/declarativeimports/core/iconitem.cpp 765e7ed Diff: http://git.reviewboard.kde.org/r/108825/diff/ Testing --- After patching, ran discover again, without all the qWarnings. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! Marco Martin wrote: ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable Aleix Pol Gonzalez wrote: Uh ok... Can't we just merge commits? Marco Martin wrote: uuh, don't know being in a different repository, different path, but whatever it works Backported We should find a better way to do this, it will get very tedious to fix stuff... And by the way, why does plasma-frameworks care about QtQuick 1? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/#review26828 --- On Feb. 7, 2013, 1:22 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/ --- (Updated Feb. 7, 2013, 1:22 a.m.) Review request for Plasma and Marco Martin. Description --- Whenever I started muon-discover I had a lot of issues from QPainter. After some investigation (gdb + breakpoint to qWarning) I found out the problem was that we were trying to render a QIcon with size equal to 0. This patch makes sure that we don't even try to paint empty icons, which solves the problem. Diffs - plasma/declarativeimports/core/iconitem.cpp 765e7ed Diff: http://git.reviewboard.kde.org/r/108825/diff/ Testing --- After patching, ran discover again, without all the qWarnings. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! Marco Martin wrote: ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable Aleix Pol Gonzalez wrote: Uh ok... Can't we just merge commits? Marco Martin wrote: uuh, don't know being in a different repository, different path, but whatever it works Aleix Pol Gonzalez wrote: Backported We should find a better way to do this, it will get very tedious to fix stuff... And by the way, why does plasma-frameworks care about QtQuick 1? it doesn't. what still talks about qtquick1 hasn't been ported/reenabled yet - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/#review26828 --- On Feb. 7, 2013, 1:22 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/ --- (Updated Feb. 7, 2013, 1:22 a.m.) Review request for Plasma and Marco Martin. Description --- Whenever I started muon-discover I had a lot of issues from QPainter. After some investigation (gdb + breakpoint to qWarning) I found out the problem was that we were trying to render a QIcon with size equal to 0. This patch makes sure that we don't even try to paint empty icons, which solves the problem. Diffs - plasma/declarativeimports/core/iconitem.cpp 765e7ed Diff: http://git.reviewboard.kde.org/r/108825/diff/ Testing --- After patching, ran discover again, without all the qWarnings. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
