Re: Review Request: Kickoff-qml fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review21387 --- Ship it! If kickoff doesn't fade, kickoff-qml shouldn't fade too - Greg T On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- (Updated Oct. 24, 2012, 6:20 p.m.) Review request for Plasma. Description --- If an application has no generic name return the application name as the title. In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle. This fixes a bug in which Find Files would show with a subtitle but no title as well as Utilities having a pointless subtitle -- Use standard desktop scrolling -- Always show application subtitle. This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example) -- Increase padding on LHS between icon and text Diffs - plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Kickoff-qml fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review21398 --- This review has been submitted with commit 7ead86e6621de733f590ceff7ee14efa03806e89 by David Edmundson to branch kickoff-qml. - Commit Hook On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- (Updated Oct. 24, 2012, 6:20 p.m.) Review request for Plasma. Description --- If an application has no generic name return the application name as the title. In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle. This fixes a bug in which Find Files would show with a subtitle but no title as well as Utilities having a pointless subtitle -- Use standard desktop scrolling -- Always show application subtitle. This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example) -- Increase padding on LHS between icon and text Diffs - plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Kickoff-qml fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- Review request for Plasma. Description --- If an application has no generic name return the application name as the title. In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle. This fixes a bug in which Find Files would show with a subtitle but no title as well as Utilities having a pointless subtitle -- Use standard desktop scrolling -- Always show application subtitle. This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example) -- Increase padding on LHS between icon and text Diffs - plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Kickoff-qml fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review20823 --- Ship it! One issue (inline), otherwise it looks good. plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml http://git.reviewboard.kde.org/r/107026/#comment16439 Why remove this fade in animation? - Sebastian Kügler On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- (Updated Oct. 24, 2012, 6:20 p.m.) Review request for Plasma. Description --- If an application has no generic name return the application name as the title. In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle. This fixes a bug in which Find Files would show with a subtitle but no title as well as Utilities having a pointless subtitle -- Use standard desktop scrolling -- Always show application subtitle. This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example) -- Increase padding on LHS between icon and text Diffs - plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Kickoff-qml fixes
On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 http://git.reviewboard.kde.org/r/107026/diff/1/?file=92249#file92249line109 Why remove this fade in animation? Because as one of the other patches subtitles no longer fades/disappear and remains constant like my current (non QML) kickoff This would then be dead code that's never called. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review20823 --- On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- (Updated Oct. 24, 2012, 6:20 p.m.) Review request for Plasma. Description --- If an application has no generic name return the application name as the title. In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle. This fixes a bug in which Find Files would show with a subtitle but no title as well as Utilities having a pointless subtitle -- Use standard desktop scrolling -- Always show application subtitle. This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example) -- Increase padding on LHS between icon and text Diffs - plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Kickoff-qml fixes
On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 http://git.reviewboard.kde.org/r/107026/diff/1/?file=92249#file92249line109 Why remove this fade in animation? David Edmundson wrote: Because as one of the other patches subtitles no longer fades/disappear and remains constant like my current (non QML) kickoff This would then be dead code that's never called. *editing to use actual English: One of the other patches removes the changing of the opacity so that they remain constantly shown like my current (non QML) kickoff. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review20823 --- On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- (Updated Oct. 24, 2012, 6:20 p.m.) Review request for Plasma. Description --- If an application has no generic name return the application name as the title. In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle. This fixes a bug in which Find Files would show with a subtitle but no title as well as Utilities having a pointless subtitle -- Use standard desktop scrolling -- Always show application subtitle. This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example) -- Increase padding on LHS between icon and text Diffs - plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
