Re: Review Request 109699: Simplify the behavior of the main UI file in the chat plasmoid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109699/#review29912 --- This review has been submitted with commit ee48913d565524d37a32926554a0d3455d0d6574 by Aleix Pol to branch kde-telepathy-0.6. - Commit Hook On March 25, 2013, 2:18 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109699/ --- (Updated March 25, 2013, 2:18 a.m.) Review request for Plasma and Telepathy. Description --- These are some ideas I got from the last commit, let's see: * Provide a bigger minimum size, I thought it would never get to the minimum but it does sometimes, so we can better give a bigger minimum (which is still too small for a proper usage). * Rename preferredWidth/Height - implicit*. It seems like it's the proper way to call these. * When the plasmoid is empty, offer an empty preferred (uh implicit) size. Diffs - chat/org.kde.ktp-chat/contents/ui/main.qml 1ee042a Diff: http://git.reviewboard.kde.org/r/109699/diff/ Testing --- Tested it in plasma-desktop (it's very hard to test sizes with plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess I have to debug other code to get around that. At least now it doesn't get as squeezed. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109699: Simplify the behavior of the main UI file in the chat plasmoid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109699/ --- (Updated March 26, 2013, 8:03 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Telepathy. Description --- These are some ideas I got from the last commit, let's see: * Provide a bigger minimum size, I thought it would never get to the minimum but it does sometimes, so we can better give a bigger minimum (which is still too small for a proper usage). * Rename preferredWidth/Height - implicit*. It seems like it's the proper way to call these. * When the plasmoid is empty, offer an empty preferred (uh implicit) size. Diffs - chat/org.kde.ktp-chat/contents/ui/main.qml 1ee042a Diff: http://git.reviewboard.kde.org/r/109699/diff/ Testing --- Tested it in plasma-desktop (it's very hard to test sizes with plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess I have to debug other code to get around that. At least now it doesn't get as squeezed. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 109699: Simplify the behavior of the main UI file in the chat plasmoid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109699/ --- Review request for Plasma and Telepathy. Description --- These are some ideas I got from the last commit, let's see: * Provide a bigger minimum size, I thought it would never get to the minimum but it does sometimes, so we can better give a bigger minimum (which is still too small for a proper usage). * Rename preferredWidth/Height - implicit*. It seems like it's the proper way to call these. * When the plasmoid is empty, offer an empty preferred (uh implicit) size. Diffs - chat/org.kde.ktp-chat/contents/ui/main.qml 1ee042a Diff: http://git.reviewboard.kde.org/r/109699/diff/ Testing --- Tested it in plasma-desktop (it's very hard to test sizes with plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess I have to debug other code to get around that. At least now it doesn't get as squeezed. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109699: Simplify the behavior of the main UI file in the chat plasmoid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109699/#review29823 --- Ship it! Ship It! - Lasath Fernando On March 25, 2013, 2:18 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109699/ --- (Updated March 25, 2013, 2:18 a.m.) Review request for Plasma and Telepathy. Description --- These are some ideas I got from the last commit, let's see: * Provide a bigger minimum size, I thought it would never get to the minimum but it does sometimes, so we can better give a bigger minimum (which is still too small for a proper usage). * Rename preferredWidth/Height - implicit*. It seems like it's the proper way to call these. * When the plasmoid is empty, offer an empty preferred (uh implicit) size. Diffs - chat/org.kde.ktp-chat/contents/ui/main.qml 1ee042a Diff: http://git.reviewboard.kde.org/r/109699/diff/ Testing --- Tested it in plasma-desktop (it's very hard to test sizes with plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess I have to debug other code to get around that. At least now it doesn't get as squeezed. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
