[Differential] [Changed Subscribers] D2630: Support highlighting windows through EffectsHandlerImpl

2016-09-12 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > effects.h:239 > > +void highlightWindows(const QVector ); > + EffectWindow* ? > highlightwindow.cpp:261 > > +void HighlightWindowEffect::highlightWindows(const > QVector ) > +{ whitespace > highlightwindow.h:58 > > +void

[Differential] [Changed Subscribers] D2630: Support highlighting windows through EffectsHandlerImpl

2016-08-30 Thread Thomas Lübking
luebking added inline comments. INLINE COMMENTS > effects.cpp:1560 > +const auto typeId = qMetaTypeId>(); > +for (int i = 0; i < e->metaObject()->methodCount(); ++i) { > +auto method = e->metaObject()->method(i); Errr... wut? Any reason to not