anthonyfieroni added a comment.
Move mouse over taskmanager :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4667
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
sitter added a comment.
Still does not crash.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4667
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc: hein,
anthonyfieroni added a comment.
diff --git a/applets/taskmanager/plugin/backend.h
b/applets/taskmanager/plugin/backend.h
index 87037c6..ef47344 100644
--- a/applets/taskmanager/plugin/backend.h
+++ b/applets/taskmanager/plugin/backend.h
@@ -104,6 +104,7 @@ class Backend :
hein added a comment.
It's worth keeping in mind KDE stuff has never supported runtime updates.
Consider e.g. kconf_update, which runs while apps run, and apps can undo its
changes on quit.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4667
EMAIL
sitter added a comment.
Provide a diff so we can reproduce?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4667
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc:
anthonyfieroni added a comment.
I'm a bit pretty harsh, add other private variable and handcopy newly plugin
e.g. sudo cp libtaskmanagerplugin.so $(locate
private/taskmanager/libtaskmanagerplugin.so)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4667
sitter added a comment.
You could just build an autotest maybe?
So, let's try with the previously mentioned
https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9=dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e
I am doing:
git clone --branch Plasma/5.9 kde:plasma-desktop
anthonyfieroni added a comment.
OK, upgrading just override existing library, no? So lets make 2 test:
1. Change in taskmanagerplugin that isn't abi -> force replace the lib when
plasmashell works -> nothing happened
2. Make an abi change -> force replace it when plasmashell works ->
davidedmundson added a comment.
> David Ed: you're right, but think of the case where you open a new plugin
(in a long running process) which itself links to a freshly upgraded shared lib
- I'm not sure what happens but it's one of these two cases:
That's a good question; though it
anthonyfieroni added a comment.
> @sitter: **BUT** the user can still add (potentially new) applets to the
shell which in turn is then broken because of the module Plasma refuses to load
because of version-locking.
I think that's not a problem, old plasma can load only old plugins, user
anthonyfieroni added a comment.
Let try to better clarification, we breaking abi like this
(https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9=dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e)
running update from 5.9.1 to 5.9.2 cause a crash in plasmashell, i don't save
backtrace but
11 matches
Mail list logo
